summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-08-22tdf#71087 sfx2: avoid flicker in the start centerMiklos Vajna
There were a couple of problems here: 1) BackingWindow now does double-buffering to avoid flicker when e.g. navigating with the keyboard in sfx2::RecentDocsView 2) But then the menu background turned into white (instead of the gradient), so MenuBarWindow needs to differentiate between doing its own buffering vs painting into a buffer. 3) The focus rectangles were always painted directly, so keyboard navigation in the startcenter lost focus rectangles, making it hard to see which button is active currently. Fix this by explicitly painting a tracking rectangle in PushButton::ImplDrawPushButton(). This brings an improvement for the Windows GDI and Linux gen backends. Windows GL and Linux gtk3 is meant to be unchanged, they were already flicker-free here. Change-Id: Ib01e330c244c2b38a5b5c52399692e19ff811de3 Reviewed-on: https://gerrit.libreoffice.org/77969 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-22weld ODbTypeWizDialogCaolán McNamara
Change-Id: Ie85e8f7a9a7551078e3108e7be9747ae4501d5eb Reviewed-on: https://gerrit.libreoffice.org/77966 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-22weld chart CreationWizardCaolán McNamara
Change-Id: I7ee88c1e1b0eca5c2510a4bbba8b60c0d8a4e3e8 Reviewed-on: https://gerrit.libreoffice.org/77954 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-22Simplify Sequence iterations in packageArkadiy Illarionov
Use range-based loops, STL and comphelper functions Change-Id: Ibd836b9b2df2f30b42f2d7a621188d78f5b53196 Reviewed-on: https://gerrit.libreoffice.org/77246 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-08-22This is an export test.Tamás Zolnai
Change-Id: Idad907f192c7a4e536bd1b8ca899fc6f9d55bbdf Reviewed-on: https://gerrit.libreoffice.org/77962 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-08-22tdf#127085: FILESAVE: Transparency is lost after RTTamás Zolnai
Change-Id: I22ba83b5cc00f84112a3755898ee2be58337afd6 Reviewed-on: https://gerrit.libreoffice.org/77963 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-08-22weld ODbTypeWizDialogSetupCaolán McNamara
split up RoadmapWizard to sit its wizard logic on top of a a native GtkAssistant a) awkwardly GtkAssistant is not a GtkDialog, but derives directly from GtkWindow so some shuffling around required due to that b) hidden/unused pages are shuffled to the end of the list of pages and their titles turned off in order to hide them from the roadmap c) some nonstandard hackery required to get the gtk roadmap titles to wrap Change-Id: I0d2346c489fef744136a2785f33c846d97bd8dc6 Reviewed-on: https://gerrit.libreoffice.org/76876 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-22loplugin:constmethod in testNoel Grandin
Change-Id: I15aa90d962b9d428a911f4b47a06d55318b42ba4 Reviewed-on: https://gerrit.libreoffice.org/77953 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-22loplugin:constmethod in toolkitNoel Grandin
Change-Id: Id80ee487d7083da5c1f1c4d012d6339700471204 Reviewed-on: https://gerrit.libreoffice.org/77952 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-22oox: typos, comments, formattingAshod Nakashian
Change-Id: I6bb138be2a8da91a85248e85d408f54a9b885f9b Reviewed-on: https://gerrit.libreoffice.org/77686 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-08-22tdf#127097 Change tracking: change style of whole deletion at paragraph joinLászló Németh
in all deleted paragraphs to avoid editing problems later. This reverts the behaviour of paragraph join changed by commit 705b728d26b4480ec6b51d9fe1362a0154ea9bf9 "tdf#119571 fix style & numbering at tracked deletion", but now Undo undoes the (sometimes different) styles of the deleted paragraphs in the same deletion, instead of losing them. Change-Id: Ic4641356c28f005efb43bf71b5b23a7bd054fecd Reviewed-on: https://gerrit.libreoffice.org/76862 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-08-22loplugin:constmethod in svtoolsNoel Grandin
Change-Id: I24e2a5844f24b9a3c973e064dad832573339dc7b Reviewed-on: https://gerrit.libreoffice.org/77946 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-22loplugin:constmethod in svlNoel Grandin
Change-Id: I9c16689dfeef11b77504106d22aceaaf9ec3df7d Reviewed-on: https://gerrit.libreoffice.org/77945 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-22tdf#126560 Qt5 fix D'n'D key-modifier handlingJan-Marek Glogowski
The patch has still one problem: the key-modifier state isn't reflected by the cursor, unless the user moves the mouse. There is an upstream Qt bug, reported in 2016-09 against Qt 5.6.1! It is supposed to be fixed in Qt 5.12, according to the bug report at https://bugreports.qt.io/browse/QTBUG-56218, which is still open. I thought about adding a configure test, but I couldn't imagine any realistic way to write it. And after Michael Weghorn found the bug is actually not fixed, as claimed in one of the comments, I decided to drop the warning. Change-Id: Ice8ebc4ea149282b4c1551e755efe3d4856cf782 Reviewed-on: https://gerrit.libreoffice.org/77174 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-08-22Update git submodulesShubham Goyal
* Update helpcontent2 from branch 'master' - tdf#126721 Help page for QR Code Change-Id: Ie4922f4e34798aaf6c49b30a3d09f3f40532076a Reviewed-on: https://gerrit.libreoffice.org/77851 Tested-by: Jenkins Reviewed-by: shubham goyal <22shubh22@gmail.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-22QR Code : ODF import/exportShubham Goyal
Change-Id: I6c1ae63a89d5ed34d2fa245279d4552949bb64a7 Reviewed-on: https://gerrit.libreoffice.org/74853 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-22Reduce default border value in the QRCode DialogShubham Goyal
Change-Id: Ie821f1762bbe941caedd58db330e84950e83f8be Reviewed-on: https://gerrit.libreoffice.org/77868 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-22we can be less verboseCaolán McNamara
Change-Id: I3adf8299b920fc7a9a44fc65ea5d48eb123d7eee Reviewed-on: https://gerrit.libreoffice.org/77951 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-22Move ctors/assignments need non-const rvalue reference to actually moveMike Kaganski
Change-Id: I95fdb807e52ef9e2663a8e291530cfcc3db0d658 Reviewed-on: https://gerrit.libreoffice.org/77947 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-22The AsyncQuitHandler class needs to be implemented in the comphelper DLLTor Lillqvist
Otherwise each file that uses it will get a separate copy of the object that the instance() function returns. I think. Silly me for trying to cut corners. Change-Id: Id9df7d60926e57491fe749dfc50cea8e1de643c3 (cherry picked from commit 6d55c969e58714382e6ccd2cedcabceb1bd43c0a) (cherry picked from commit 057cdd6eb480c19b1b8988ac2ae6de610691c593) Reviewed-on: https://gerrit.libreoffice.org/77949 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-08-22More hacks for quit requests from an OLE Automation clientTor Lillqvist
Actually I am now not so sure whether the TerminationVetoer thing is needed or not. Will have to experiment later with the customer use case what happens if I remove all that. Maybe adding it was a mistake, as misinterpretation of what was going on. Change-Id: I252e1233cae1622099bc3310814132dae58b2aed (cherry picked from commit 9c50273a9f3a15d1ff7ea4880638ca833570e0bd) Reviewed-on: https://gerrit.libreoffice.org/77948 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-08-22tdf#127030 PPTX export: keep fixed size of legacy shapesBalazs Varga
Classical/legacy shapes lost their fixed size by exporting them with the option "Resize shape to fit text". Regression from commit 86b14cc8bd910651cef422a0f7408adc0fc51a17 (tdf#119617 Fix export of Autofit property of shapes to PPTX) Change-Id: Iab67db113edc61f4c94a89ec1bb8df0736c26f21 Reviewed-on: https://gerrit.libreoffice.org/77888 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-08-22loplugin:constmethod in vclNoel Grandin
Change-Id: I20545527b117c9562b91076b748fb3e2659d2497 Reviewed-on: https://gerrit.libreoffice.org/77944 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-22Add some more SAL_INFOsTor Lillqvist
Change-Id: I5b50df5ea6b99164d150f99ae4fd36cddde22a60 Reviewed-on: https://gerrit.libreoffice.org/77928 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-08-22loplugin:constmethod in saxNoel Grandin
Change-Id: I73e8322107d4c3f8890f6c1d059e4853de489d6e Reviewed-on: https://gerrit.libreoffice.org/77932 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-22loplugin:constmethod in connectivityNoel Grandin
Change-Id: Idd81089279b23d93276107d84446c77e49d42b77 Reviewed-on: https://gerrit.libreoffice.org/77933 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-22loplugin:constmethod in packageNoel Grandin
Change-Id: I44bc86a179164e1d039dd3a5f2c8a23396d870b3 Reviewed-on: https://gerrit.libreoffice.org/77931 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-22loplugin:constmethod in canvas,comphelperNoel Grandin
Change-Id: I8790355369159b2325d3992712b2f65e0401db86 Reviewed-on: https://gerrit.libreoffice.org/77930 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-22xmloff: create XMLImpressSettingsExportOOO instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: Iadb687fc4d55a093cef262b1205ca6a4da89bfa3 Reviewed-on: https://gerrit.libreoffice.org/77934 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-22Use range ctor to avoid default-insertion of elements before assignmentMike Kaganski
Change-Id: I9d14ca33349ea92f94362e862fd24e1e468dab05 Reviewed-on: https://gerrit.libreoffice.org/77929 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-22Deduplicate some codeMike Kaganski
Change-Id: I2cdc9f1416a9089e91f30cebe071a4855edc4536 Reviewed-on: https://gerrit.libreoffice.org/77892 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-22Fully support importing of XML with nested repeat elements.Kohei Yoshida
With this change, Calc's XML Source will allow importing XML that contains nested repeat elements. It is something the old implementation did not support. Change-Id: I73fa1087ccd727390a47007bcfabd411cf007621 Reviewed-on: https://gerrit.libreoffice.org/77941 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2019-08-21Fix full url for calc/styles by adding missing '/'Julien Nabet
warn:sc:1272:1272:sc/source/filter/orcus/orcusfiltersimpl.cxx:149: Unable to load styles from xml file! boost::filesystem::file_size: Aucun fichier ou dossier de ce type Thread 1 "soffice.bin" hit Breakpoint 2, (anonymous namespace)::lookup (file=0x5555556435a0, mode=(anonymous namespace)::LOOKUP_MODE_NORMAL, override=false, key="BRAND_BASE_DIRshare", requestStack=0x0) at /home/julien/lo/libreoffice/sal/rtl/bootstrap.cxx:860 860 OUString v; (gdb) bt 0 0x00007ffff7f2ae45 in (anonymous namespace)::lookup(Bootstrap_Impl const*, (anonymous namespace)::LookupMode, bool, rtl::OUString const&, (anonymous namespace)::ExpandRequestLink const*) (file=0x5555556435a0, mode=(anonymous namespace)::LOOKUP_MODE_NORMAL, override=false, key="BRAND_BASE_DIRshare", requestStack=0x0) at /home/julien/lo/libreoffice/sal/rtl/bootstrap.cxx:860 1 0x00007ffff7f2b7f6 in (anonymous namespace)::expandMacros(Bootstrap_Impl const*, rtl::OUString const&, (anonymous namespace)::LookupMode, (anonymous namespace)::ExpandRequestLink const*) (file=0x5555556435a0, text="$BRAND_BASE_DIRshare/calc/styles.xml", mode=(anonymous namespace)::LOOKUP_MODE_NORMAL, requestStack=0x0) at /home/julien/lo/libreoffice/sal/rtl/bootstrap.cxx:995 2 0x00007ffff7f2aa0d in rtl_bootstrap_expandMacros_from_handle(rtlBootstrapHandle, rtl_uString**) (handle=0x5555556435a0, macro=0x7ffffffefb90) at /home/julien/lo/libreoffice/sal/rtl/bootstrap.cxx:791 3 0x00007ffff7f2aa60 in rtl_bootstrap_expandMacros(rtl_uString**) (macro=0x7ffffffefb90) at /home/julien/lo/libreoffice/sal/rtl/bootstrap.cxx:797 4 0x00007fffde89e675 in rtl::Bootstrap::expandMacros(rtl::OUString&) (macro="$BRAND_BASE_DIRshare/calc/styles.xml") at /home/julien/lo/libreoffice/include/rtl/bootstrap.hxx:131 5 0x00007fffde890d5f in ScDocShell::Load(SfxMedium&) (this=0x555558034760, rMedium=...) at /home/julien/lo/libreoffice/sc/source/ui/docshell/docsh.cxx:613 Change-Id: I5e4019c730f25d32b431dbd01c5668189be6cc66 Reviewed-on: https://gerrit.libreoffice.org/77936 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2019-08-21atk: Make sure returned values are initializedSamuel Thibault
-1 is the now-document value to be used in this case, see https://gitlab.gnome.org/GNOME/atk/merge_requests/22 Change-Id: I7e8f1c64cf0dfb337f2c1ee026ca68700c893e78 Reviewed-on: https://gerrit.libreoffice.org/77750 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-08-21tdf#126271 Revert "tdf120965 Simplify SdrPathObj::AddToHdlList()"Regina Henschel
This reverts commit 26001f4f84b0d921c8612d888856613735ba5314. Change-Id: Ib4df476b405e65be9203ab376c9c68b03198c040 Reviewed-on: https://gerrit.libreoffice.org/77882 Tested-by: Regina Henschel <rb.henschel@t-online.de> Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-08-21Resolves: tdf#127048 loosen warning from presence to if parsedCaolán McNamara
rather than warn if lcbCmds indicates some Cmd exist, only warn if we find something in the Cmd data to attempt to import Change-Id: I48f7db22d13688597374f7c77d6033c1ce6d7eb3 Reviewed-on: https://gerrit.libreoffice.org/77926 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-21Avoid extra calls to INetURLObject::decodeStephan Bergmann
Change-Id: I700c4093213395a12342534fb7685969b5e5b220 Reviewed-on: https://gerrit.libreoffice.org/77891 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-21loplugin:constmethod in basctlNoel Grandin
Change-Id: Ib4d7a6690aea4e6f009162cd5b6407906deaaa75 Reviewed-on: https://gerrit.libreoffice.org/77925 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-21loplugin:constmethod in accessibilityNoel Grandin
Change-Id: I1e42811e8e79dd81837dd38570c0f2705bb87fe8 Reviewed-on: https://gerrit.libreoffice.org/77924 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-21Qt5SvpGraphics::handleDamage: Don't leak BitmapBufferMichael Weghorn
Leak found by valgrind. Change-Id: If2d03e94467210bc0e485e6a81bf8480a958323d Reviewed-on: https://gerrit.libreoffice.org/77889 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-08-21hook GtkAssistant buildable to RoadmapWizardCaolán McNamara
Change-Id: I486ee35423be33f0f78780a43afa324aa66f5f26 Reviewed-on: https://gerrit.libreoffice.org/76904 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-21Better use DecodeMechanims ToIUri rather than Unambiguous hereStephan Bergmann
...to avoid erroneously un-escaping input like "file:///%3C" to "file:///<" Change-Id: I973208dac38799794216e1ee36a63662d434e8cf Reviewed-on: https://gerrit.libreoffice.org/77886 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-21Make comphelper::findValue inline template and drop sequence.cxxMike Kaganski
Change-Id: Ibee3424b9a957d5d62e66c3257a4050a2ebc207b Reviewed-on: https://gerrit.libreoffice.org/77881 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-21Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Fix dup entry in makefile Change-Id: Ife5fe8ea701e0b241b048e49d5f137b5aa9b268f Reviewed-on: https://gerrit.libreoffice.org/77887 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-08-21jobset.h: Add missing includeMichael Weghorn
'VCL_DLLPUBLIC' is used, which is defined in '<vcl/dllapi.h>'. A compile error could be provoked e.g. by moving the 'jobset.h' include in 'vcl/unx/generic/print/genprnpsp.cxx' above all other includes. Change-Id: I39de6f213da2fa0ceaa9e9557c24062c2aef1586 Reviewed-on: https://gerrit.libreoffice.org/77883 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-08-21tdf#105000 Make Material palette entries localizableKovács László Zoltán
Change-Id: I8e208ed6b807e43ce53c5604ccb5d544c28189e5 Reviewed-on: https://gerrit.libreoffice.org/77419 Reviewed-by: Gabor Kelemen <kelemen.gabor2@nisz.hu> Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-08-21IDocumentDeviceAccess::setPrinter has no return valueMichael Weghorn
... so don't mention any in the comment either. This looks like it was copy-pasted from the comment of one of the other methods and has always been there since commit 7518fb9e558bb533289f1e789ac07282ee9d826a ("INTEGRATION: CWS writercorehandoff (1.1.2); FILE ADDED"). Change-Id: I727d437fc63fec7eadb041c7ced6c4955fb3e7f3 Reviewed-on: https://gerrit.libreoffice.org/77880 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-08-21make info dialog a child of the dropdown dialogCaolán McNamara
instead of a child of the parent of the dropdown dialog Change-Id: Ib94be49955efb4384a77a524f3614db7e56cd03c Reviewed-on: https://gerrit.libreoffice.org/77860 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-21tdf#123627 DOCX import: fix tinderboxingTünde Tóth
related to commit 4c30848c852c44cbad8509c770feed5244f1940f "tdf#123627 DOCX import: fix relative hyperlinks to documents", until fixing possible profile-dependency of the unit test. Change-Id: Ifbc2a5c94957234d46371655523c8cd2595e98e8 Reviewed-on: https://gerrit.libreoffice.org/77559 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-08-21llvm::make_unique is gone from LLVM trunkStephan Bergmann
(but when targeting older versions of LLVM/Clang, COMPILER_PLUGINS_CXX can still specify -std=c++11) Change-Id: I1b91f2817516d015bc12b6a3faf1874ab938a3ae Reviewed-on: https://gerrit.libreoffice.org/77866 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-23 12:11:58 +0000