summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-04-20tdf#148501 color shades only for filled PolyPolygonsRegina Henschel
For shading parts of a shape not of Type 'ooxml-*', ColorData is used, introduced about 2005. For 'mso_spt*' shapes they are set directly, for others they are encoded as 'col-********' into the Type value. During OOo time two changes were made, resulting in the bugs, that colors are assigned to wrong segments and that shadings are too dark. More details are in the bug report. With this patch the colors are assigned to the correct segments again. The too dark colors are visible in our preset shapes 'Octagon Bevel'. The shape 'Diamond Bevel' with corrected color assignment is also affected. Both need new ColorData. Since it is important for Libreoffice to have good compatibility with OOXML, I have decided to use only the four shading values available in OOXML. In the long run, these shapes should be replaced by ones that contain the shading information inside the <enhanced-path> element. Change-Id: I4b8323c45bf702fc371d6e6c82dd9102d0fd9929 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133132 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-20tdf#148380 sw fieldui: always allow turning off "Fixed Content"Justin Luth
As we add more and more MS fields as fixed, some of them are set so the UI to manage that flag is disabled. While it doesn't necessarily make much sense to allow a user to SET these fields as fixed (so don't ALWAYS enable that flag), at least allow it to be turned off if it somehow did get enabled. Change-Id: I331c871fa7a3e40a7a0154ab4d7d68c67d9c1dad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133086 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-20android: Use android.ndkPath property to set path to NDKMichael Weghorn
Quoting from commit 128de1949ff120ac925dbb06e398fa992fb295ba Date: Tue Apr 19 15:18:49 2022 +0200 android: Use property instead of ANDROID_NDK_HOME env var which ported from an obsolete (no longer supported by current Gradle versions) way of setting the NDK path to a deprecated but still supported one as an intermediate step to allow upgrading Gradle: > Note however, that with this approach of using the `ndk.dir` > property instead of the suggested `android.ndkVersion` > (with the latter having the stricter requirement that > the `ndk` dir would have to be a subdir of the SDK dir), > doing the actual upgrade to a newer Gradle (plugin) version > in follow-up commit > Change-Id Ia982d72d877e229c3006c6d528b830d16c88481f > "android: Update Android Gradle Plugin to 7.1.3" > revealed that the use of the `ndk.dir` property > is deprecated in newer Gradle (plugin) versions as well, > resulting in this warning. > > > > Task :stripStrippedUIDebugDebugSymbols > > [CXX5106] NDK was located by using ndk.dir property. This method is > > deprecated and will be removed in a future release. Please delete > > ndk.dir from local.properties and set android.ndkVersion to > > [20.0.5594570] in all native modules in the project. > > https://developer.android.com/r/studio-ui/ndk-dir > > It might make sense to address that in a follow-up step, > but for now, it's an improvement and keeps it working > after the upgrade without potentially causing any incompatibility > problems with existing autogen configurations, > while support for the `ANDROID_NDK_HOME` env var that was > used so far seems to have been dropped, [...]. The release notes for Android Gradle Plugin version 4.1.0 mention yet another way of setting an explicit NDK path instead of just a version and that one is still supported and not deprecated [1]: > # Set the NDK path > You can set the path to your local NDK installation using the > android.ndkPath property in your module's build.gradle file. > > android { > ndkPath "your-custom-ndk-path" > } > > If you use this property together with the android.ndkVersion property, > then this path must contain an NDK version that matches > android.ndkVersion. Therefore, switch to setting the NDK path using the `android.ndkPath` property in liboSettings.gradle instead of the deprecated `ndk.dir` in local.properties. [1] https://developer.android.com/studio/releases/gradle-plugin?buildsystem=ndk-build#ndk-path Change-Id: I34690ca8e15ff4742bab9a716a58b9ad85fa86e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133197 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-04-20android: Set archivesBaseName differently after gradle updateMichael Weghorn
Setting the archive base name in build.gradle using project.ext.set("archivesBaseName", "LibreOfficeViewer") no longer worked after commit 39326bc7d439170dd24c9d4b837c2cdb720b5d6f Date: Tue Apr 19 15:49:53 2022 +0200 android: Update Android Gradle Plugin to 7.1.3 ... and gradle to 7.2, which is what Android Studio suggested and did automatically when confirming. As a consequence, the generated .apk or .aar files would no longer have the app name in them, but be called e.g. "source-strippedUIEditing-release-unsigned.apk" instead of "LibreOfficeViewer-strippedUIEditing-release-unsigned.apk". Setting `archivesBaseName` in `android.defaultConfig` in libOSettings.gradle works, so move it there. Change-Id: Id03cbe10681aca85c35aeef64527bc7707c95736 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133191 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-04-20use more FastAttributeIter::toViewNoel Grandin
Change-Id: I8a8ad5456fea349a45fca0aa468313cb04aa02f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133198 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-20sw: prefix members of WW8PLCFx_PCDAttrs, WW8PLCFx_SEPX, WW8PLCFx_SubDoc ...Miklos Vajna
... and WW8SprmIter See tdf#94879 for motivation. Change-Id: Ic0c664e0a17b1c897b25efdac631d8ca016e95b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133193 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-04-20loplugin:stringviewparamStephan Bergmann
Change-Id: I487d665875cfb182a5f30b8e6a3834960c0451e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133194 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-20loplugin:stringviewparamStephan Bergmann
Not sure if the given url is guaranteed to be of a form so that neither of the two url.find(':') could return npos, but lets mimic the original code faithfully for now. Change-Id: Ib525b42ccb5b19b4bc13729f973248cf1c8713de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133192 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-20Advanced Diagram support: Use better association Model<->XShapeArmin Le Grand (Allotropia)
To have a more direct and more reliable association between the XShape/oox::Shape and the model data svx::diagram::Point I added optional usage of the Model-UUID for that at the oox::Shape. Also added a 'fake' UUID to work with the BackgroundShape's attributes. Changed all preserve/rescue code to work based on that. Also cleanups/comments and preparations of some flags in the Diagram ModelData to steer behaviour on re-ceration. Change-Id: Ie30effdff34dcdbbc79a766de09157b2a3bd97d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133168 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-04-20android: Update dependencies to current versionsMichael Weghorn
This requires the Gradle update from Change-Id Ia982d72d877e229c3006c6d528b830d16c88481f "android: Update Android Gradle Plugin to 7.1.3" as a prerequisite, since the build would otherwise fail with > > Task :desugarStrippedUIDebugFileDependencies FAILED > D8: Method name '$private$<clinit>' in class > 'com.sun.star.frame.XMenuBarMergingAcceptor$-CC' cannot be represented > in dex format. > > FAILURE: Build failed with an exception. after updating only the dependencies. Change-Id: Ifa007fa0e520e9494ace173d1643abb7d7a5f9c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133183 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-04-20android: Drop obsolete "sourceCompatibility 6"Michael Weghorn
This addresses this warning when building Android Viewer: > > Task :compileStrippedUIDebugJavaWithJavac > warning: [options] source value 6 is obsolete and will be removed in a future release > warning: [options] To suppress warnings about obsolete options, use -Xlint:-options. Change-Id: Ic1a80117e7e8c31774947729452bfafacd7a24c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133182 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-04-20android: Update Android Gradle Plugin to 7.1.3Michael Weghorn
... and gradle to 7.2, which is what Android Studio suggested and did automatically when confirming. Also apply the following optional, but recommended change while doing so: > Migrate from lintOptions to lint > Configuration related to lint is now performed using the lint block. Change-Id: Ia982d72d877e229c3006c6d528b830d16c88481f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133179 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-04-20android: Stop using ANDROID_SDK_HOME env variableMichael Weghorn
Otherwise, upgrading to Android Gradle Plugin 7.1.3 and gradle 7.2 (which will be done in a follow-up commit) would make the build fail like this: > FAILURE: Build failed with an exception. > > * Where: > Build file '/home/michi/development/git/libreoffice-WORKTREE-for-android-x86/android/source/build.gradle' line: 1 > > * What went wrong: > A problem occurred evaluating root project 'source'. > > Failed to apply plugin 'com.android.internal.application'. > > ANDROID_SDK_HOME is set to the root of your SDK: /home/michi/Android/Sdk > ANDROID_SDK_HOME was meant to be the parent path of the preference folder expected by the Android tools. > It is now deprecated. > > To set a custom preference folder location, use ANDROID_USER_HOME. > > It should NOT be set to the same directory as the root of your SDK. > To set a custom SDK location, use ANDROID_HOME. We don't actually rely on `ANDROID_SDK_HOME` being evaluated by the Android toolchain, but it used to be set in configure.ac, and the value was then assigned to the `sdk.dir` property written to `android/source/local.properties`. Just use a new variable name `ANDROID_SDK_DIR` and keep the mechanism otherwise unchanged for now. Change-Id: I44826621a1342119d40036fb704d8ff1eeed7c77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133178 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-04-20android: Use property instead of ANDROID_NDK_HOME env varMichael Weghorn
Write an `ndk.dir` property with the directory path to `android/source/local.properties` instead, similar to how it's done for `sdk.dir`. Also, rename the `ANDROID_NDK_HOME` variable that's assigned in configure.ac that holds the corresponding value to `ANDROID_NDK_DIR`, because the gradle warning still shows up if that environment variable is set in addition to having an `ndk.dir` property in `local.properties`. This makes the following gradle warning disappear: > > Task :stripStrippedUIDebugDebugSymbols > WARNING: Support for ANDROID_NDK_HOME is deprecated and will be removed in the future. Use android.ndkVersion in build.gradle instead. > Support for ANDROID_NDK_HOME is deprecated and will be removed in the future. Use android.ndkVersion in build.gradle instead. Note however, that with this approach of using the `ndk.dir` property instead of the suggested `android.ndkVersion` (with the latter having the stricter requirement that the `ndk` dir would have to be a subdir of the SDK dir), doing the actual upgrade to a newer Gradle (plugin) version in follow-up commit Change-Id Ia982d72d877e229c3006c6d528b830d16c88481f "android: Update Android Gradle Plugin to 7.1.3" revealed that the use of the `ndk.dir` property is deprecated in newer Gradle (plugin) versions as well, resulting in this warning. > > Task :stripStrippedUIDebugDebugSymbols > [CXX5106] NDK was located by using ndk.dir property. This method is > deprecated and will be removed in a future release. Please delete > ndk.dir from local.properties and set android.ndkVersion to > [20.0.5594570] in all native modules in the project. > https://developer.android.com/r/studio-ui/ndk-dir It might make sense to address that in a follow-up step, but for now, it's an improvement and keeps it working after the upgrade without potentially causing any incompatibility problems with existing autogen configurations, while support for the `ANDROID_NDK_HOME` env var that was used so far seems to have been dropped, resulting in > > Task :stripStrippedUIDebugDebugSymbols > Unable to strip the following libraries, packaging them as they are: > libc++_shared.so, libfreebl3.so, liblo-native-code.so, libnspr4.so, > libnss3.so, libnssckbi.so, libnssdbm3.so, libnssutil3.so, > libplc4.so, libplds4.so, libsmime3.so, libsoftokn3.so, > libsqlite3.so, libssl3.so. instead if upgrading gradle without switching to the use of the property. Change-Id: I4a090e8736dac80777f69b0e12819b9c056f582b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133177 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-04-20android: Remove redundant label attribute from activitiesMichael Weghorn
Android Studio was showing an info/warning in the "Problems" pane that this label is redundant, so remove it. (The app name is used by default if nothing else is specified anyway.) Change-Id: I799c681488b95e2fffe89b59e7de18febe654dcb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133174 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-04-20android: Update compileSdkVersion/targetSdkVersion to 31Michael Weghorn
Google Play now requires that apps target API level 30 or higher, and compileSdkVersion/targetSdkVersion 31 is also needed to update the com.google.android.material dependency to >= 1.5.0 [1]. Explicitly set the `android:exported="true"` attribute for activities which is required when targeting Android 12 or newer; quoting from the list of behavior changes for apps targeting Android 12 [1]: > Safer component exporting > > If your app targets Android 12 or higher and contains activities, > services, or broadcast receivers that use intent filters, you must > explicitly declare the android:exported attribute for these app > components. Warning: If an activity, service, or broadcast receiver > uses intent filters and doesn't have an explicitly-declared value for > android:exported, your app can't be installed on a device that runs > Android 12 or higher. > > If the app component includes the LAUNCHER category, set > android:exported to true. In most other cases, set android:exported > to false. > > The following code snippet shows an example of a service that > contains an intent filter whose android:exported attribute is set to > false: > > <service android:name="com.example.app.backgroundService" > android:exported="false"> > <intent-filter> > <action android:name="com.example.app.START_BACKGROUND" /> > </intent-filter> > </service> The app worked fine in a quick test on an x86_64 AVD with API level 31. [1] https://github.com/material-components/material-components-android/releases/tag/1.5.0-alpha03 Change-Id: Ibb919e4edb995740e48ebc3338ffab6ca35c1373 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133167 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-04-20tdf#97228 Move ToolbarValue class to separate include fileVaibhavMalik4187
The ToolbarValue class defined in include/vcl/salnativewidgets.hxx was used only by vcl. Therefore, it is now moved to a seperate include file named toolbarvalue.hxx which is inside vcl/inc folder. This header file only contains the definition of the the ToolbarValue class. All the files that references the ToolbarValue class now include toolbarvalue.hxx. Change-Id: I78fe3ceb09892c5d3f720ee3d66111bdcdf48db2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131321 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-04-19tdf#148620: sd: add UItestXisco Fauli
I tried to implement this test as a CppUnittest but '.uno:OutlineUp' and '.uno:OutlineDown' do nothing there Change-Id: Ie0d35abcc423999891d6a5dac07ec55d4ca8ee71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133176 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-04-19tdf#148565 sw ms export: a new run can't be postponed-startedJustin Luth
This fixes a LO 7.4 regression from commit 46b62f7777c6acdc2c94dc4b2ab79d38a10c49f9. A make check with an assert indicated the following existing unit tests matched - but they had no noticable char run content to test against. ooxmlexport6's testShapeThemePreservation ooxmlexport7's testBnc884615 ooxmlexport9's testTdf90789 ooxmlexport10's testTdf90153 ooxmlexport11's testTdf137655 ooxmlexport14's testTdf131539 ooxmlexport15's testTdf138739 ooxmlexport17's testTdf126287 Change-Id: Iae89ff1f6de06bfe37b886e1e39e8457157ae240 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133187 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-04-19SwNavigator: List fields content type members in document orderJim Raykowski
Currently all Fields content type members may not be listed in the order of document appearance. This happens because the sort is done using *only* the document model position of the text node (paragraph) the field is in. Fields in the same text node (parargraph) have the same sort value which results in an alphabetical sort of these. This patch uses both the document model text node index and start position of the field in the text node text to make the fields content type members list in the order of document appearance. This method is already used to sort Hyperlinks content type members in the order of document appearance. Change-Id: I05f5ad0699764a265b5320047b67e7f418b7fa99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133101 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-04-19ucb: webdav-curl: put user name from config into LOCK requestMichael Stahl
... so that the dialog in SfxMedium::LockOrigFileOnDemand() can show something more useful than hard-coded URL, which has been used since commit 99bdd887a6141883878978bad9beb35e7b326cd1 in 2009 when locking was added. This is half of the user info that is put into LO's own lock files (see svt::LockFileCommon::GenerateOwnEntry()). Change-Id: Iefac724644a536fc37c3c79ce862e25bd9be38af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133186 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-04-19ucb: webdav-curl: fix getting DAV:lockdiscovery propertyMichael Stahl
commit b4576f3da4d90139fc5140962d13cb91dab98797 "tdf#82744: fix WebDAV lock/unlock behaviour - part 3" added a call to get the DAV:lockdiscovery property. But WebDAVResponseParser puts lock related properties into a separate return value maResult_Lock that is only returned for LOCK requests. Just add it as a normal property too, then PROPFIND can get it, and the dialog in SfxMedium::LockOrigFileOnDemand() no longer displays "Unknown user". Change-Id: Icee920588ea40b6e203b18287d75484528cfdebb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133185 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-04-19Fix heap-use-after-freeStephan Bergmann
...when dp_gui::ExtensionRemovedListener::disposing (desktop/source/deployment/gui/dp_gui_extlistbox.cxx) calls > m_pParent->removeEntry( xPackage ); on an already destroyed m_pParent in e.g. the following scenario: In an installation with some bundled extensions (e.g., --enable-ext-ct2n), "Tools - Extension Manager...", deselect "Display Extensions - Bundled with LibreOffice", "Close", "File - Exit LibreOffice". It appears the issue was present ever since at least 051f7b163fa4bf1917fb3db98fed2a6a932a827e "jl152#i77196# Use ExtensionManager instead of PackageManager" Change-Id: I446cba382103828b97a2b1db9fa8afc207b73bc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133180 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-19new loplugin:stringviewvar looks for OUString vars that can beNoel Grandin
... that can be string_view Change-Id: I0ddf66725e08b58e866a764f57200dd188b9f639 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133066 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-19Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 000df5aded9b5cbe2488dc2e9c9406c6b56767c5 - Related:tdf#147107;tdf#144493 update B&N bar command names and explanations tdf#144493 (008cfd5980f31c9e01b5cdbede33631d66f2fb56) changed command names that are found in the Bullets and Numbering toolbar (and menus in Writer, Draw, Impress). tdf#147107 (3b222bcd75d57db404cd2ed5dc97a5c492c28060) made adjustments to some of the command names changed for tdf#144493. This patch addresses the consequences of these name changes for the Bullet and Numbering toolbar in Writer, where the changed commands also appear in the Format menu UI. Meanwhile, some of the help pages for the changed commands are shared with Draw and Impress, so any help file that needed to be changed for Writer was also updated for Draw and Impress. In addition to updating the changes in the command names, the descriptions of the commands were evaluated and corrected when necessary. text/swriter/main0206.xhp (B&N Bar) *reorder controls on help page to correspond to order on toolbar text/shared/02/06100000.xhp (Move Item Up) + appl-inline switch for <h1> and icon name to distinguish Writer from the other modules * adjustments and corrections in descriptions + add appl-switch for mentioning toolbar and shortcut keys + add link to relevant toolbar * correction in command sequence for shortcut keys for Writer and Impress. * refactor to <keycode>,<menuitem> text/shared/02/06110000.xhp (Move Item Down) + appl-inline switch for <h1> and icon name to distinguish Writer from the other modules * adjustments and corrections in descriptions + add appl-switch for mentioning toolbar and shortcut keys + add link to relevant toolbar * correction in command sequence for shortcut keys for Writer and Impress. * refactor to <keycode>,<menuitem> text/shared/02/06120000.xhp (Move Item Up with Subpoints) * correct the description, with separate explanations for list paragraphs and chapter headings, and mention of multiple selection. * update command name * change .png to .svg text/shared/02/06130000.xhp (Move Item Down with Subpoints) * correct the description, with separate explanations for list paragraphs and chapter headings, and mention of multiple selection. * update command name * change .png to .svg text/shared/02/06050000.xhp (Demote Outline Level) * simplify the appl-inline switch for <h1> * correct the description + add separate explanations for chapter headings and list paragraphs for Writer + add link to B&N toolbar + add shortcut key info for Impress * refactor to <menuitem> text/shared/02/06060000.xhp (Promote Outline Level) * simplify the appl-inline switch for <h1> * correct the description + add separate explanations for chapter headings and list paragraphs for Writer + add link to B&N toolbar + add shortcut key info for Impress * refactor to <menuitem> text/swriter/02/06070000.xhp (Demote Outline Level with Subpoints) * correct the description * update command and icon name * refactor to <h1> * change .png to .svg * change icon size to 1cm - remove <colspan="" rowspan=""> text/swriter/02/06080000.xhp (Promote Outline Level with Subpoints) * correct the description * update command and icon name * refactor to <h1> * change .png to .svg * change icon size to 1cm - remove <colspan="" rowspan=""> Change-Id: Iaedfebe4f260658bb1f5821ef279846eba22415a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/132870 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2022-04-19tdf#148635 cache some chart stuffNoel Grandin
cache some intermediate stuff that it does a handful of times when finishing a chart - halves the time taken Change-Id: I75c5621844d4309b64e64219a7c9e2bcd344ce36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133173 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-19tdf#148635 no need to init ChartDataWrapper more than onceNoel Grandin
halves the time to finish a chart2 Change-Id: Ib7f066672878f7630c2d1c90b9487a14f2048029 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133172 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-19tdf#97361 - make unit tests more pythonic.Hannah Meeks
Change-Id: I853cda76522ebf3c9a8f7389d5b2b6fc9611f502 Signed-off-by: Hannah Meeks <hmeeks4135@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133136 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2022-04-19sfx2: do reload on SID_EDITDOC in SfxViewFrame::ExecReload_Impl()Michael Stahl
commit b505ca5b9c31b3d9c639406d03a25bea4e914242 "Switch to read-only mode: do not force reload document if possible" replaced "true" with "bNeedsReload" here - but this is a problem when switching from read-only to editable. 1. Start LO and load a document from WebDAV editable 2. Start other LO and load the same document from WebDAV read-only 3. In first LO, edit document, store it and close it 4. In second LO, click "Edit Document" button 5. LO doesn't reload the document and shows stale content It's not clear what problem that commit was trying to solve, but let's assume that it intended to change only what happens when switching from editable to read-only. Change-Id: I69c779c5c0c5c2ccda677ea8cb353c8716916861 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133171 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-04-19sfx2: fix utterly confusing bools in SfxViewFrame::ExecReload_Impl()Michael Stahl
bPhysObjIsYounger variable is actually true if aPhysObj is *older* than aMedObj. Due to the "bNeedsReload = true" that was added in commit b505ca5b9c31b3d9c639406d03a25bea4e914242 i had first thought that commit b4576f3da4d90139fc5140962d13cb91dab98797 is at fault and inverted the condition - but not so, its only crime is mis-naming the variable and the "bNeedsReload = true" is actually dead code because this branch always returns before any use of bNeedsReload further below. Meanwhile, commit f1035312f80746fdf4a7a04039db73b27d1387c3 actually did invert the condition, but that was in 2004 and presumably intentional. Change-Id: Ie342163a1de434f99c521e97711157a76191da0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133029 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-04-19tdf#148313 Basic IDE crashing while resizing dialogNoel Grandin
Change-Id: Ic68b78f26626f346f3ef8b54a584de64165d9eb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133170 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-19Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to 5bab8a2d2530d7487064a2560c440269018a56b9 - tdf#148621 Make ScriptForge service tables mobile-friendly - Introduce <tablehead> element - While considering text-align, I noticed we do not take RTL languages into account. A CSS rule 'html[dir=ltr] th' was added, which does nothing at the moment. We should look into directionality. Change-Id: Ib59aa0c508529c0beaa35542d96bd5cc1aa4db29 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/133114 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-04-19dont keep writing to config when persona is set to 'no'Noel Grandin
Change-Id: I87233fc2a8b1099a7468b28add1b87e864908f4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133169 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-19tdf#148594 correcting the number of kern spaces.Mark Hung
A glyph item ( or a glyph cluster ) may be made up of more than one sal_Unicode values ( e.g. CJK ideograph extension B characters that need surrogate pairs, or unicode iVS that have a base character and a selector ). Insert the kern space only when KernArray value changes. I.e. character belongs to a different glyph item or cluster. Count the number of needed kern spaces in the same way. Change-Id: If79766bda37cf4d10ca5be2d51dfdc992eaf9cc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133093 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2022-04-19tdf#144493 adjust changes to GenericCommands.xcuSeth Chaiklin
There are no chapters in Draw or Impress, so the label changes by 008cfd5980f31c9e01b5cdbede33631d66f2fb56 in officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu to uno:OutlineUp and uno:OutlineDown were inappropriate. Remove "Chapter" from ContextLabel, and just make it "Label" so that Customize matches command name in menus, and add TooltipLabel for toolbars that gives a more informative tooltip. No text changes for uno:OutlineLeft and uno:OutlineRight, but same label changes to make command name in Customize correspond to name in menus, and add TooltipLabel that gives a more informative tooltip. Change-Id: I03a43089654721b9023912c29835e9f56ffc5b26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133049 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-04-19use of template param here confuses Visual StudioNoel Grandin
version 17.2.0 Preview 3.0 Change-Id: If73d984b0bbcfd85667ab859db7d86514af6c2b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133166 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-19sw: check if cursor position is valid before inserting fileMichael Stahl
SwXTextCursor::insertDocumentFromURL() must not insert the file inside of an input field. If the CH_TXT_ATR_INPUTFIELD* become separated to different text nodes, things are going to break. Change-Id: Ia170e63f6c6d8a8fdd18f0b91e2b333e660ed924 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133028 Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2022-04-19loplugin:stringviewparamStephan Bergmann
Change-Id: I8f27a2260e7195dd0a7dbb0b5e3dd0064ef06c81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133164 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-19Extend insertDocumentFromURL documentationSamuel Mehrbrodt
Change-Id: I892c876ff53a0aaf2ce4d484604ef0c2a95d8801 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133035 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-04-19Following tdf#142151: Red cast rendered in 16 bit TIFF imageJulien Nabet
Just simplify by merging both almost identical parts. Change-Id: I1658621609e10312feed530090adfa873602d2f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133115 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-04-19Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to 26cd9a5e8be28097e59188bcdf6bcaa9c75be4e4 - Fix typo Change-Id: I624ec6267f5a72105c3d600d390849586b839da6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/133154 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-04-19chart2: change define to constantTomaž Vajngerl
Change-Id: Id545105cb48fdd0c28a67e6017570658915f93b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133163 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-04-19chart2: not really worth having a TrueGuard - just use ScopeGuardTomaž Vajngerl
Change-Id: Ia2436d4cc843540a51e00ee937b80303cb600851 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133162 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-04-19chart2: ExplicitValueProvider - make forward declrs. consistentTomaž Vajngerl
Change-Id: I90e8b2d163f700c7b1e251064af8655529f76906 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133126 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-04-19chart2: move ExplicitValueProvider impl. out of ChartViewTomaž Vajngerl
Change-Id: Ie1bcae70c5a5df3978f8890c127f9aae1ae9237b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133125 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-04-18cosmetic changes to support the mold linker instead of "unknown"Luboš Luňák
Current mold 1.2.0 seems to work fine, except possibly for GDB index (https://github.com/rui314/mold/issues/439), which can be worked around by doing 'strip --strip-debug' on the relevant crt*.o files. Change-Id: I097bb0b37fc31393f8e9a45ec068c5f05259b2f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133123 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-04-18tdf#147472: sw: bug in numbering with previous level NONEVasily Melenchuk
Previous fix for tdf#146257 was not complete and was not able to take care of disabled numebering started just at beginning of the numbering string. UI test test_tdf144439_outline with modifications is covering this situation. No need in extra testcases. Change-Id: Id17838cec7fb4fb039f9b457b7ee9ad3ab345678 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133124 Tested-by: Jenkins Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
2022-04-18uitest: sw: move field dialog tests to their own placeXisco Fauli
Change-Id: I9b4b462af85cea7e2427b4025a268dcc200fff51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133130 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-04-18ScriptForge - (SF_Calc) new CreatePivotTable() methodJean-Pierre Ledure
Create a new pivot table with the properties defined by the arguments. If a pivot table with the same name exists already in the targeted sheet, it will be erased without warning. Parameters: PivotTableName: The user-defined name of the new pivottable SourceRange: The range as a string containing the raw data. The first row of the range is presumed to contain the field names of the new pivot table TargetCell: the top left cell or the range as a string where to locate the pivot table. Only the top left cell of the range will be considered. DataFields: A single string or an array of field name + function to apply, formatted like: Array("FieldName[;Function]", ...) The allowed functions are: Sum, Count, Average, Max, Min, Product, CountNums, StDev, StDevP, Var, VarP and Median. The default function is: When the values are all numerical, Sum is used, otherwise Count. RowFields: A single string or an array of the field names heading the pivot table rows ColumnFields: A single string or an array of the field names heading the pivot table columns FilterButton: When True (default), display a "Filter" button above the pivot table RowTotals: When True (default), display a separate column for row totals ColumnTotals: When True (default), display a separate row for column totals Returns: Return the range where the new pivot table is deployed. The method may be used in Basic and Python user scripts. Change-Id: I99df23e1b1b97b17a747ae15a079d7e2f5655b41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133131 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2022-04-18tdf#148620 Crash in Draw using Format > Lists > Move DownNoel Grandin
This reverts commit 35f03f26799747894d1534796b6cb227bd4f233b speed up loading large ODS a little since ImpEditEngine::ImpMoveParagraphs wants to manipulate ParaPortion's and also identify them by pointer Also convert the OSL_ASSERT in this method to an assert to catch such problems earlier Change-Id: Id924d00c9524223db9a96e487b331ce60e3a4fff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133128 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-27 10:19:01 +0000