summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-01-13XUnoTunnel->dynamic_cast in TransferableHelperNoel Grandin
which leads us to find that we can skip all the dynamic_cast'ing altogether in SwView_Impl Change-Id: I8914f78df6bfdd743df370c0017d5b8521863594 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145483 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-13tdf#39650: move UItest to CppUnittestXisco Fauli
Change-Id: I2ff89c53309d7e3a4da11d652aafeb38cbc41205 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145480 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-13Fix typo to complete commit 613baf157375Andrea Gelmini
See https://gerrit.libreoffice.org/c/core/+/145241 Change-Id: Ic9c229fc891ce81c52c7886055a0a3474020f233 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145392 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-01-13tdf#150708 downgrade a11y SAL_WARN to SAL_INFOCaolán McNamara
Change-Id: I4e0a082bfe130bf2a4031f9559ddbdf9bb04c00a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145478 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-13Base OSubComponent on cppu::WeakComponentImplHelperStephan Bergmann
...rather than on cppu::OComponentHelper (which derives from XAggregation) and then manually suppressing support for XAggregation in OSubComponent::queryInterface Change-Id: I6718d36f20579806b508c4bf5048b734643ad716 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145476 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-13XUnoTunnel->dynamic_cast in X509Certificate_MSCryptImplNoel Grandin
Change-Id: If61114df98f4096798281a28ffcdf58168ff7fdc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145475 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-13XUnoTunnel->dynamic_cast in SecurityEnvironment_MSCryptImplNoel Grandin
Change-Id: Idb013bd71b2a90cd6fb8927b199eb36e9bfd9c06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145474 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-13XUnoTunnel->dynamic_cast in SfxUnoStyleSheetNoel Grandin
Change-Id: I22ad42fd0de3de3bddc1b6d3a99f09883e523340 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145464 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-13tdf#152952 sw: don't hyphenate URLs by defaultMichael Stahl
New compatibility flag HyphenateURLs, disabled by default for Word interop and enabled for old ODT documents. Change-Id: I1496819599deb5ed0fd736698d269ab9a22167fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145415 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-01-13tdf#102525: move UItest to CppUnittestXisco Fauli
Change-Id: If7881b49cc006157e177559308048a0f2d2c10b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145473 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-13tdf#95306: move UItest to CppUnittestXisco Fauli
Change-Id: Ic999c9d10d9a3ae16de0df70b435a5d822035193 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145471 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-13tdf#150708 if the old is CARET_OR_STATES then try updating itCaolán McNamara
with the additional states. Hard to know if this is a sensible approach. Change-Id: I0d55d41c4dd9cbb17fb736e5145671cd6a8b25ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145460 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-13oox: also allow tint and shade for fill colorTomaž Vajngerl
This was an obsolete limitation that is not needed anymore. Change-Id: Ie9610516996fc16197f8611843ff621b8a83ebdc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145084 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-13Related: tdf#152703 Eliminate potential blocking during live resizePatrick Luby
Some events and timers call Application::Reschedule() or Application::Yield() so don't block and wait for events when a window is in live resize. Also, only native events and timers need to be dispatched to redraw the window so skip dispatching user events when a window is in live resize. Lastly, only higher priority tasks need to be fired to redraw the window so skip firing potentially long-running tasks, such as the Writer idle layout timer, when a window is in live resize. Change-Id: I5d449caa432399e836b8e59781e5cc53af718873 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145211 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org>
2023-01-13ooxml: fix theme color type mapping: bg -> light, text -> darkTomaž Vajngerl
Change-Id: I19ad3ef7c911943075d7ddc01626047cdf11d5db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145070 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-13xmloff: use XThemeColor in ODF, change the format for themesTomaž Vajngerl
Change the xmloff filter to use XThemeColor and the associated proprties (CharColorThemeReference and FillColorThemeReference). Change the ODF format for referencing a theme color - make it an element instead a series of attributes on the *-properties style element. Change-Id: I0fa7d8ebffecc02897b7fe9824d6f1776ef36380 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144923 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-13XUnoTunnel->dynamic_cast in VCLXFontNoel Grandin
Change-Id: I4afa34805e64f3ff37b76fe8ca4676c1f4eb3e14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145468 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-13XUnoTunnel->dynamic_cast in VCLXDeviceNoel Grandin
Change-Id: I9fa06600d3b9a2172a1818f89a3b9c06d65c8c54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145467 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-13XUnoTunnel->dynamic_cast in SvxUnoNumberingRulesNoel Grandin
Change-Id: I492a951f1d686e1507232e6688c2dc75e8a41cc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145463 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-13tdf#152860 Fix tooltip for .uno:SearchLabel commandRafael Lima
This patch makes the following changes: 1) Silence the string "[placeholder for message]" for translation, since it is never actually used in the UI. 2) Add a generic tooltip for the command. Change-Id: If46d7476638c72d35af2a4c8f242542aae2eafca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145294 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-01-13remove XUnoTunnel from SvxUnoTextFieldNoel Grandin
nothing seems to be using it Change-Id: Ib986d2906ac10df3743a30d912bb8ec356838e20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145462 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-13sw: add a new .uno:DeleteBookmarks UNO commandMiklos Vajna
This is similar to commit c68d06dfa1498f862923eaddf3e5d247650a53d5 (sw: add a new .uno:DeleteTextFormFields UNO command, 2023-01-10), but that was for fieldmarks and this is for bookmarks. The primary use-case is to specify a prefix for the name, so e.g. all Zotero-related bookmarks can be removed, but it can be also used to remove all bookmarks when no prefix is specified. Change-Id: Ifc1f666f66d9fc3f6cd055f9263f0e4f949c191d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145458 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-01-13Fix typosAndrea Gelmini
Change-Id: I173920a96524f991f2965af99e8d95f11d1b3c35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145455 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-01-13tdf#152994 actually return in this caseCaolán McNamara
Change-Id: I40cb4dc4ce1fd3caa2464f92803124c3d2107afb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145433 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-13Fix Emscripten version check to still work with older SDK versionsTor Lillqvist
Change-Id: I051b5edd5936bcb94521f88ec7a7a762c66c9283 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145419 Tested-by: Jenkins Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2023-01-13sw: add a new .uno:UpdateField UNO commandMiklos Vajna
This is similar to commit ea208f6004770eb4b81d28e6930cd0c7bd5d8f12 (sw: add a new .uno:UpdateBookmark UNO command, 2023-01-11, but that was for the bookmark under cursor, and this is for fields (refmarks as a start). Change-Id: I3e547b668361898b7ed734ea325fdf1d74e5dbb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145427 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-01-13OFactoryComponentHelper's XAggregation is apparently unusedStephan Bergmann
It had been using cppu::OComponentHelper (which derives from XAggregation) ever since b525a3115f54576017a576ff842dede5e2e3545d "initial import", bug e.g. ORegistryFactoryHelper deriving from it implements queryInterface in a way that is incompatible with XAggregation (it should only have forwarded to OFactoryComponentHelper::queryInterface, and rather implemented its logic in an ORegistryFactoryHelper::queryAggregation override). Also, without this commit but instead with a local > diff --git a/cppuhelper/source/factory.cxx b/cppuhelper/source/factory.cxx > index c8efcab0e604..9011264b3f3a 100644 > --- a/cppuhelper/source/factory.cxx > +++ b/cppuhelper/source/factory.cxx > @@ -241,6 +241,7 @@ class OFactoryComponentHelper > , public OComponentHelper > , public OSingleFactoryHelper > { > + void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); } > public: > OFactoryComponentHelper( > const Reference<XMultiServiceFactory > & rServiceManager, `make check` still succeeded for me on Linux, without hitting that injected assert that should have fired if that XAggregation mechanism had been used after all. So switch from OComponentHelper to WeakComponentImplHelper here (which is the simplest implementation helper to use, even if it still needs the non-standard OFactoryComponentHelper::getTypes overriding the non-fitting WeakComponentImplHelper default implementation). Change-Id: I9fc2f4f2ef36bd016f9a943a8efd5e4ac5f3baaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145428 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-13Simplify a bitMike Kaganski
Change-Id: Ie2435701078b0e111c1b04b77c857fd1923f2d59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145430 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-01-13sfx2 lok: conditionally revert CreateBackup changesMiklos Vajna
This was enabled by default in commit 5cb7fed2a5a02ff1cb4551752a0bd8d3001a1f22 (tdf#152463 Turn on AutoSave and Backup by default, 2022-12-12), and it makes sense on the desktop, but this breaks LOK clients, e.g. online.git unit-wopi-save-on-exit. Keep the desktop case unchanged, but disable it again for the LOK case to make the failing test pass again. Change-Id: I3a7eed8fdd6d394e9c7e75a477cbc11a6f40f7c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145426 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-01-13Resolves tdf#119919 - Show hidden children in Stylist when in tree modeHeiko Tietze
To avoid styles appearing on root if their parent is hidden (eg. Heading hidden, Heading 1 moves under root), the Stylist shows all styles but with disabled color for the hidden styles Change-Id: Iec73a3010ab05d01e9b7209d81f1f03c1355ef49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145324 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-01-13Merge OSingleFactoryHelper into OFactoryComponentHelperStephan Bergmann
Change-Id: I7faf7a3ad54c80bd3c53525c92c26c0f980110f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145423 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-13Update pdfium to 5522Miklos Vajna
The internal libpng 1.6 is now dropped, but that doesn't really affect us. Change-Id: I777c024c76c17689c20bbe6453467ba5fb22baba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145417 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-01-13sw: rename getBookmarkFor() to getInnerBookmarkFor()Miklos Vajna
Because otherwise it's quite confusing that we have a For() and an At() variant as well, and it would be less clear what happens in For() when there are multiple matches. Also improve getInnerBookmarkFor() a tiny little, so we process the first hit only once. Suggested at <https://gerrit.libreoffice.org/c/core/+/145348/1#message-286262286f234823b390e8f962e3ba11f5fa71b2>. Change-Id: If068f93e6934c9fc042760c03aac866fe5b50bd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145412 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-01-13sw, FN_DELETE_TEXT_FORMFIELDS: allow deleting all fieldmarksMiklos Vajna
As suggested at <https://gerrit.libreoffice.org/c/core/+/145347/1#message-d2e88d8a1923f0fa5d2869b8d92e1d25d15ac645>, in case the provided prefix is empty, then don't try to look up ODF_CODE_PARAM and don't compare it with the provided prefix. This allows deleting all fieldmarks in the document, which is probably intended with an empty prefix. Change-Id: Ic3015925165a9abc13a30889c36c667b10996c4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145409 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-01-13sw lok: expose name of refmark under cursorMiklos Vajna
This is similar to commit 4bcb66ec7b417fbe113267f2615e78fe47eb55ca (sw lok: expose name of bookmark under cursor, 2023-01-11), but that was for the bookmark under the cursor and this is for refmarks. Change-Id: I0acf0181d0acfdc087e1ed737b3c18ab3736031a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145405 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-01-13XUnoTunnel->dynamic_cast in comphelper::ByteReader and comphelper::ByteWriterNoel Grandin
Change-Id: I1f8c864a939dff1252ba15f517f63b62d1a1e1fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145393 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-13tdf#152425 related: don't generate style ids in DocxAttributeOutput::RedlineMike Kaganski
If the style id is unavailable from MSWordStyles::GetStyleId at this point, it is a bug (meaning that we failed to output the style to styles.xml). Local style generation here would skip the "make it unique" step anyway, so the id would be unreliable / useless. Change-Id: I32c3c6a2581a7aaa6c5b1bb3d48f09b90fb65f73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145401 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-01-13introduce {Char,Fill}ColorThemeReference which uses XThemeColorTomaž Vajngerl
Adds a unified UNO property for theme colors *ColorTheme (CharColorTheme and FillColorTheme) which uses XThemeColor, that replaces the properties *Theme, *TintOrShade, *LumOff, *LumMod. The properties are still present for backwards compatibility and to keep ODF support working in tests as that needs a bigger change. Reactor the code and tests to accomodate for this change. Change-Id: If7983decb4ba528b49fe7b5968aa9efc696a9efc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144783 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-12sc: move different UItests to CppUnittestXisco Fauli
it seems Jenkins fails sometimes with this test https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/131248/ this commit might help TODO: convert the remaining test Change-Id: Ib3fb48e2e457a9168fa16c8f9f2ac9f98beabcf3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145422 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-12introduce docmodel comp., model::ThemeColor, use it in SvxColorItemTomaž Vajngerl
Added a new component docmodel, that has the document model types, which only depend on other basic components. This is needed so the types can be used in every relevant component - xmloff, oox, svx, editeng,... Introduces model::ThemeColor, which is a class used to store the theme color data, including transformations (svx::Transformation). For UNO use XThemeColor is added, and the implementation UnoThemeColor which wraps svx::ThemeColor, so it can be tranported around. Reactor all the code and tests to accomodate for this change. Change-Id: I7ce6752cdfaf5e4d3b8e4d90314afa469dd65cfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144847 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-12Don't let OSingleFactoryHelper delegate to derived classes' virtual overridesStephan Bergmann
...as it doesn't make sense that e.g. OFactoryComponentHelper::createInstance checked for bOneInstance, called OSingleFactoryHelper::createInstance, which called [OFactoryComponentHelper::]createInstanceWithContext, which checked for bOneInstance again Change-Id: I53f54079a2ac1af18a6e95f0cb9d7b75c1e46ceb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145418 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-12Fix aggregating OFactoryComponentHelper::queryInterfaceStephan Bergmann
4bfc00aca2441082842f91dfba15886258674227 "#67468# factories support XUnloadingPreference now" had added the check for XUnloadingPreference there, but that's already covered by OFactoryComponentHelper::queryAggregation delegating to OSingleFactoryHelper::queryInterface. (And as OFactoryComponentHelper is inheriting XAggregation via OComponentHelper, the only thing that OFactoryComponentHelper::queryInterface shall do is delegate to OComponentHelper::queryInterface.) Change-Id: Iebe507e88791d1e2390d042a8a9c152512ce212a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145420 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-12CppunitTest_sc_uicalc: remove leftoverXisco Fauli
from commit 3756e3145c39ace4454d2569709c2c0d64ad389a "CppunitTest_sc_uicalc: combine external reference tests" Change-Id: I0c34ae8bd1668aa6ecc02d420aa767f7d631bef4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145404 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-12SwNavigator: Improve mouse move handler for bringing objects toJim Raykowski
attention in the document view Fixes crash that happens in SalInstanceTreeView iter_compare when the mouse enters the content tree at a point that has no tree entry and is then moved over an entry. Moves code to bring entry content to attention in the document view from the mouse move handler to it's own function. Renames the overlay timer handler function and moves it to the area of the code having related functions. Checks added for visible content and if the type has any content to bring to attention. Change-Id: I381eed6ffcf7ddb095c4c09650578a7f7fd874b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145168 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2023-01-12tdf#152994 only query dark mode in Windows >= 10.0.18362Caolán McNamara
Change-Id: I8d8bd368d9d1ee38dac96dd369484ec74ce4835a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145414 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-12draw selection bounds without using RasterOp::InvertCaolán McNamara
Change-Id: I65fa68bbd8ff40c0e324851376dd8a8a1614ac99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145396 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-12mbDragDrawn is always false when queriedCaolán McNamara
Change-Id: Ie8eda3465381eeed62d3271040c1697ef8f6559a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145395 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-12ofz#55034 Stack-buffer-overflow in vcl::bitmap::CreateFromDataCaolán McNamara
since: commit 21734247d58a6e915b058d8fa55ece949d049613 Date: Tue Jan 10 12:56:58 2023 +0200 drop internal support for 1-bit images the input data is still 1 bit here, even if the output will be 8 bit Change-Id: Ib7eb301b2e62ebc61ee61ebb99e6de92c1f4931b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145410 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-12tdf#152921 Fix sidebar tabbar tab highlightingJim Raykowski
Makes the highlight state of the tabbar tab behave as expected when the sidebar is in the collapsed or expanded state. When collapsed, the tabbar should never have a highlighted tab. When expanded, the tab in the tabbar corrosponding to the open deck should be highlighted. Change-Id: I0e6c54aff95b1f1e417f147070742e900fd51513 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145251 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2023-01-12Fix VclTextTest with colorized antialiasingStephan Bergmann
The Flathub build for <https://github.com/flathub/org.libreoffice.LibreOffice/commit/d5ac1d2bd680970ba992c8c6836683262f067592> "Merge pull request #206 from flathub/lo-7.4.4" on 2023-01-12 at <https://buildbot.flathub.org/#/builders/6/builds/16778> consistently failed for both aarch64 and x86_64 builds with > text.cxx:260:Assertion > Test name: VclTextTest::testSimpleText > double equality assertion failed > - Expected: 28 > - Actual : -1 > - Delta : 2 during CppunitTest_vcl_text. The reason (as seen with a temporary build setting mbExportBitmap = true and looking at the resulting workdir/CppunitTest/vcl_text.test.core/simple-text-36-50pct.png) is that the stem of the "L" doesn't contain any COL_BLACK pixels, so getCharacterLeftSideHeight returns early with -1. The stem is drawn as three vertical lines of pixels, a yellow (RGB 255/195/111), a black-ish (RGB 23/0/0), and a blue (RGB 31/155/199) one. In comparison, when running the same test on Fedora 37, the three vertical lines use gray-scale instead of colors, RGB 195/195/195, then true black (RGB 0/0/0), and RGB 115/115/115. An earlier test build of <https://github.com/flathub/org.libreoffice.LibreOffice/pull/206> "Update to LibreOffice 7.4.4" for the same libreoffice-7.4.4.2 tag on 2023-01-02 at <https://buildbot.flathub.org/#/builders/6/builds/14712> succeeded, so I assume that it must be some change in the meantime to the underlying org.fedoraproject.sdk//22.08 that started to cause colorized antialiasing here. Change-Id: I7059268eabcfe8e501d0be4f38746707def7bb35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145411 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2024-12-28 10:45:55 +0000