summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-07-30LOK: Mention name of unknown command in exceptionAron Budea
Change-Id: I665c9aebaa4e215b8bc4622f3e245e5f2c47deab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171133 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 8fe4ca79d4b3cc2a62c59b7dfd2849b7a79d9437) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171196 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com>
2024-07-30tdf#134902 evaluate visibility of VML shapesOliver Specht
VML shapes from docx should be invisible if "visibility:hidden" is set. Change-Id: I8299a5c3a7fca8deae2ec37523c3f2e240376893 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167989 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-07-30related tdf#160621: request extra height for field value entryOliver Specht
With this, both edit and add fields dialog should look near-identical at this spot (seems extra rows are needed for native dialogs like gtk, while Windows wants the extra height-request). Change-Id: Iafee3d60d33c9eee6020e9ef49aaac900222a0e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170835 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-07-29sw: get rid of discardDumpedLayoutXisco Fauli
Change parseLayoutDump to make it the only place where the layout is dumped and once it's not needed anymore, discard it Change-Id: Ia89ff569752e1e592209fa4ccb0b4753eee17e2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171075 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-07-29CppunitTest_sw_mailmerge: simplify a bitXisco Fauli
Change-Id: I5eacde6d4622a9ff464cc30f6cb6124b1d2ca9af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171218 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-07-29CppunitTest_sw_mailmerge: replace usage of parseDumpXisco Fauli
Change-Id: I04f75abb16249fc384ea63b456696f8edf278b4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171215 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-07-29fix macOS codesigning: only mach-o files allowed in Contents/FrameworkChristian Lohmaier
put the other files in Contents/Resources and have them signed with the overall bundle-signature. Putting them into Contents/Framework or Contents/MacOS would require the use of extended attributes and is not recommended, see also 4b9190fc29aec0f005f08c0269bb9ff081f19fe3 / https://gerrit.libreoffice.org/c/core/+/109537 Change-Id: I582e3198b1a006e76d6ad37bd945e0712d17c669 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171217 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-07-29tdf#161846 remove one layout operation (i)Noel Grandin
of the 6 we perform per caption object Change-Id: I8af5a0a4c859241fa350fcd3c45cfdfe1cfb6475 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171170 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-29testtools, wizards, xmlsecurity: fix issues found by Ruff linterIlmari Lauhakangas
Change-Id: I03edbaa7c9a643ca7503fa0e93c2bf0de3ac4e51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171211 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-07-29Resolves: tdf#159343 Implement TableRef API token conversionEike Rathke
Change-Id: I1b0d9e002d267e62dc7cbbbfc9f5c5c728374345 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171165 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2024-07-29CppunitTest_sw_mailmerge: factour out common codeXisco Fauli
Change-Id: I82de04eaabc7efd2440c263064f0c074b30473ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171181 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-07-29Simplify a bitMike Kaganski
Change-Id: I0aeb003cd1e1846da729514a39e9190751996fd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171167 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-07-29Prevent rtl::Reference -> css::uno::Reference -> rtl::Reference implicit pathMike Kaganski
Replace up-casting conversion constructor with respective conversion operator, similar to existing css::uno::Reference conversion operator. Thic change will not allow code like rtl::Reference<Foo> foo; rtl::Reference<Foo> bar(foo, uno::UNO_QUERY_THROW); which was possible because compiler could use temporary css::uno::Reference. Change-Id: I54b79af3e2508b26e9cd59f2cc7e2ae92f6efbbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171166 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-07-29tdf#161846 use unordered_map in SfxItemPropertyMapNoel Grandin
with large property maps, even a binary search starts showing up, but we can do a O(1) search here by using a map Change-Id: Ie7916076073e6dd393f0a1fb5a0db1b973999408 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171173 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-07-29cid#1554812 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1555227 COPY_INSTEAD_OF_MOVE cid#1555329 COPY_INSTEAD_OF_MOVE cid#1555384 COPY_INSTEAD_OF_MOVE cid#1555387 COPY_INSTEAD_OF_MOVE cid#1555399 COPY_INSTEAD_OF_MOVE cid#1555400 COPY_INSTEAD_OF_MOVE cid#1555406 COPY_INSTEAD_OF_MOVE Change-Id: I85dc45e2686c6b3e8b97a23872cb26416edc27c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171178 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-29cid#1615230 silence Overflowed constantCaolán McNamara
bogus but lets see if this makes any difference Change-Id: I7b9a91826eb9fd65e39c0c337e05019c374773a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171176 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-29use more GetItemSurrogatesForItemNoel Grandin
since it is considerably more efficient Change-Id: I224ff890f6dd52481621b46f912f1e8dbf65126c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171182 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-07-29Use NDEBUG to show/hide m_bDeletedOliver Specht
"#ifndef NDEBUG" is now always used to hide/show member m_bDeleted Change-Id: I10f5111cd36e13b8101d2a69ed9268bee622344a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171012 Tested-by: Jenkins Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2024-07-29tdf#162205 sw: Fix incorrect baseline adjust for vertical bidi portionsJonathan Clark
Bidi portion rendering was performing baseline adjustment twice. This caused vertical left-to-right bidi portions to be rendered to the left of their proper position. Change-Id: Ic5258f58d8c8260194ec5ea0921d72f8dd738556 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171071 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-07-29tdf#158504: fix 'applied' for page stylesBjoern Michaelsen
Here is how checking for a used page style used to work before 140079362502408c75ceee67e86d779f61c0ac1b: - SwDocStyleSheet::IsUsed called SwDoc::IsUsed on the page style - ... that used to call GetInfo on the SwPageDesc - ... which then called GetInfo on Master, Left, ... (SwFrameFormats) - ... which then ends up in a SwPageFrame which confirms the page style to be in use To get this to work again after 140079362502408c75ceee67e86d779f61c0ac1b, one would need to reimplement the forwarding in SwFrameFormat (and the other intermediates). However, instead of replicating that encapsulation breaking maintenance nightmare, we instead: - introduce a properly named SwPageDesc::IsUsed - which directly calls SwFrameFormat::IsUsed - use that in SwDocStyleSheet::IsUsed - and then assert in SwDoc::IsUsed if called on random types (as essentially most of Writer derives from sw::BroadcastingModify in some way) Change-Id: I4ca300af61a1f2af383ef2b7ded32ddbee6ec975 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171088 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-07-29tdf#161090 - Spec how many / which values are in remainder of-Pie chartKurt Nordback
This commit moves bar-of-pie and pie-of-pie chart types into a separate line in the chart type selection UI from 'plain' pie chart types. This allows for separate UI controls, including a spin button added in this commit for of-pie types to specify the number of entries to be included in the composite wedge and broken out in the right-hand subchart. Per discussion in this and related bugs, this may not be the long-term best approach for specifying which entries go into the composite, and it still only allows for the last entries in the composite. But it is a step towards allowing greater control. I've also changed the default number in the composite from 3 to 2, to better match MSO. I/O of the 'number in the composite wedge' parameter is not included in this commit. Implementing that for ODF and OOXML perhaps should be a separate bug or bugs. Change-Id: If4afc1417ea94c15e86a9a4dfe967a6f8ecb7ca8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168690 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-07-29package: ZipFile: check Zip64 end of central directory for consistencyMichael Stahl
Change-Id: Iae873ec8175922e210398ef8e0f83e148a795c2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170783 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2024-07-29ofz: sc-rtf "ClusterFuzz Unreproducible" resetCaolán McNamara
so reenable this and bump up min fuzz length Change-Id: Ia5a8c725aa827c18f68c46077fae020831608395 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171177 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-29tdf#85677: fix the vertical panning gesture in ImpressTibor Nagy
Change-Id: I574f802e5f7de260ecb56032098e60018f2675da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171137 Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de> Tested-by: Jenkins
2024-07-29Consistently name UITest targetsStephan Bergmann
Change-Id: Ibdf28a56f66f9513a3d4abb25cea8176e47da941 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171174 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-07-29testtools, uitest, unotest: fix issues found by Ruff linterIlmari Lauhakangas
Change-Id: I4a848b0f1f114d1262b5242786e088eb50a33cef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171145 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins
2024-07-29tdf#161846 remove one layout operations (ii)Noel Grandin
of the 6 we perform per caption object Change-Id: Ib062a7cc0b4691ec0badb759893b737f6f2c4a86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171171 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-29svx: prefix members of SdrUndoObjSetTextMiklos Vajna
See tdf#94879 for motivation. Change-Id: I414fc94c35dc9caa2619b92eeaa436ad17fae5ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171168 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-07-29Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to 8f68a0232112cfa6a8b2baa298c0282442fc2db2 - VBA supported objects Change-Id: Ie2f51790fa25e589a05a8f9a0cf25cc4f891c4c7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171038 Tested-by: Jenkins Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2024-07-29android-viewer translated using WeblateWeblate
Interlingua currently translated at 75.8% (88 of 116 strings) Change-Id: Ic8de20a48ed2bd6c8756b3158432cba86811577b Co-authored-by: SoftInterlingua <softinterlingua@gmail.com> Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ia/ Translation: android-viewer/android-strings Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171103 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-07-29tdf#161875 buffer NameOrIndex Items for fast SurrogatesArmin Le Grand (Collabora)
Problem is that collecting the Items using the ItemSets and PoolItemHolders is too expensive when used too often. For read-only access it is okay to have the Items directly registerd (for write access we *need* the ItemSets and PoolItemHolders, see iterateItemSurrogates). This is limited to Items which need to support surrogates, but can further be limited to the here critical ones - the ones derived from NameOrIndex. This is done here by checking if the Item is a NameOrIndex based one by adding a bool to the item that gets set in the NameOrIndex constructor. If needed this can be changed, e.g. by using besides the SFX_ITEMINFOFLAG_SUPPORT_SURROGATE another flag signaling this. Since only Items that are currently held by an ItemSet or a PoolItemHolder get registered it is not necessary to change the Item's RefCount in any way, doing that may lead (again, we had that with directly set Items at the Pool in the past) to long-living Items that only get cleaned-up when the pool/ document gets destructed. This buffering is now SfxItemType-based, no longer using the WhichID, so the result needs to be checked for WhichID additionally - if needed (?). All in all it's anyways a compromize, every usage of the surrogate mechanism is a 'hack' in the sense that for lazy reasons not the model data is traversed directly, but assumed that all Items set at a pool/model *are* model/document data (what is not always true). CheckNamedItem does not need to be static, changed that. Also all accesses to maRegisteredNameOrIndex *have* to work on the MasterPool instance, same as buffered ItemSets or PoolItemHolders, corrected that, too. Number of instances in the buffer need to be counted, else an instance will be removed too early: The same instance of an Item can be referenced by multiple sets/holders, so the first remove from the buffer would already remove even when the Item is referenced multiple times. Added that. Added more asserts & made sure that all constructors/ destructors of SfxItemSet do take care of registering Items for the surrogate mechanism as needed. Change-Id: Ib33e7f0bd4abd32a3bb68278f33b0abb9a4754c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171084 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-07-28related tdf#115474: improve warning msg for slow autoformatThorsten Behrens
Perhaps this alerts users that they've unintentionally selected a very large range (Ctrl-A vs. Ctrl-End for selecting content)? Change-Id: I8d60cf6186d1faf94c58684cad2ead49381819d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170995 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Jenkins
2024-07-28Related: tdf#162072 compare fallback to what "serif" resolves toCaolán McNamara
instead of assuming that the resolved serif font will have serif in its name. Change-Id: I3f85e2a8abd1dbf851debec9196e55d5c2da4e66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171144 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-28ofz: Null-dereference READCaolán McNamara
Change-Id: I872cd2b0c32f88a5ac09ea3082f05b7d3c41feb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171141 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-07-28Update git submodulesIlmari Lauhakangas
* Update dictionaries from branch 'master' to eff9495b70722d8e590e97b1710cfc7c00f6ce72 - Lightproof: undo some import order changes advised by Ruff linter Change-Id: Iec2b9a1ed9bf2f9a41dc098fcf6ee8026917e3a3 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/171140 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-07-28crashtesting: fix ImplCalcMapResolution assertCaolán McNamara
seen on converting moz1297206-1.svg to odg Change-Id: I56c424eb76f55a52522d519a0faa6df30b017c82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171142 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-07-28cid#1556624 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1556622 COPY_INSTEAD_OF_MOVE cid#1556629 COPY_INSTEAD_OF_MOVE cid#1556632 COPY_INSTEAD_OF_MOVE cid#1556634 COPY_INSTEAD_OF_MOVE cid#1556642 COPY_INSTEAD_OF_MOVE cid#1556644 COPY_INSTEAD_OF_MOVE cid#1556663 COPY_INSTEAD_OF_MOVE cid#1556674 COPY_INSTEAD_OF_MOVE cid#1556682 COPY_INSTEAD_OF_MOVE cid#1556683 COPY_INSTEAD_OF_MOVE cid#1556685 COPY_INSTEAD_OF_MOVE cid#1556694 COPY_INSTEAD_OF_MOVE cid#1556708 COPY_INSTEAD_OF_MOVE cid#1556711 COPY_INSTEAD_OF_MOVE cid#1556712 COPY_INSTEAD_OF_MOVE cid#1556714 COPY_INSTEAD_OF_MOVE cid#1556719 COPY_INSTEAD_OF_MOVE cid#1556727 COPY_INSTEAD_OF_MOVE cid#1556744 COPY_INSTEAD_OF_MOVE cid#1556757 COPY_INSTEAD_OF_MOVE cid#1556782 COPY_INSTEAD_OF_MOVE cid#1556784 COPY_INSTEAD_OF_MOVE Change-Id: I5d5bc884cd7351a81c18b35aaf4e304256242988 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171128 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-07-28cool#9082 - lok: cleanup WakeUpThread before forking, then re-start.Michael Meeks
It seems likely that this lingering briefly after various un-identified and tough to reproduce, longer running operations in calc - which is a big ScProgress user - caused problems with background save. Change-Id: I1d0ec56c759dff30c48c8562b6400b57be4a25b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168033 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168052 Tested-by: Jenkins
2024-07-28tdf#158510 Don't change the initial URL when using fallbackVladislav Tarakanov
The current aURL conversions in the file "unoshap4.cxx" result in the URL obtained when importing the file being replaced with a new one formed from the presentation directory and file name. As a result, the model changes and saving is requested even if no changes were made to the presentation. To fix this problem, we added saving the presentation directory URL into the context for transfer from SlideImpl to ViewMediaShape. Regression after: fe897b36aef28dfe175461c43614e22588fcfd84 Change-Id: Ifda8610d0a4874ffa17e759fd45ddbbd2f934c0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170528 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-07-28restore WakeUpThread::joinThreadCaolán McNamara
removed with: commit 4aa2cc878dae3b34b16ccacd9358fda5e6d6a197 loplugin:unusedmethods Change-Id: Ie6006defdfdab23aef0fa9d9b66b125862b760f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171139 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-28ofz#68339 TimeoutCaolán McNamara
ofz took the reduction in size limit to 256 bytes as a challenge so produced a hang with a 187 byte testcase Change-Id: Ia9a93e6fd846127be2f842949f4338e819432ebc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171125 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-28sfx2, solenv, sw: fix issues found by Ruff linterIlmari Lauhakangas
Change-Id: Iab375e8c8aa4c4915f3c70a9ef6aede268e4619f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171138 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-07-28Resolves: tdf#160509 use BorderWindow client for dialog parentCaolán McNamara
the BorderWindow has no ultimate SystemWindow parent so dialogs using this as a parent end up automatically picking a parent of whatever happens to be in the foreground and not the intended associated frame Change-Id: I713e3c40b0cad934b978ba0b1b46a3c6064be24f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171104 Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-07-28sd: fix issues found by Ruff linterIlmari Lauhakangas
Change-Id: I96dae5eca3bb493500ca1145e141371a5572e29e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171134 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-07-28tdf#68676 Fix textual data length sent to SQLBindColMike Kaganski
The problem was that using Access ODBC drivers, text fields couldn't be set after commit 5ed1415d1cf03a3d671ebd11582dfaa90f1168bd (tdf#68676, tdf#131238: implement and use Unicode ODBC functions on Windows). I had changed the length sent to the function from SQL_NTS into the actual string length; and that caused the problem. Restoring previous behavior. Change-Id: I9ea1f33f30505232a02d42e3182d5449fc8d8f34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171135 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-07-28Fix typoAndrea Gelmini
Change-Id: I7a135a47e5bdbbf37a08f7e876a0ed1d979d4c39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171131 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2024-07-28Remove duplicated includeAndrea Gelmini
Change-Id: Ic50852db74fd6e3b227875932b730e077efbe709 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171130 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2024-07-28tdf#162219: pass correct DecimalDigits value to SQLBindParameterMike Kaganski
... when setting DECIMAL / NUMERIC. Passing 'scale' from setObjectWithInfo to SQLBindParameter was wrong anyway: in setObjectWithInfo, the scale is needed if it converts the object 'x' to the requested format before sending to the database. In this case, it mismatched with the actual count of decimals in the string sent to ODBC: it could be "1" or "1.2"; but 'scale' is always equal to the scale of the parameter in the database (4 in the bugdoc), which resulted in the error returned by driver. Note that there is code that truncates excessive decimals - it is in OKeySet::impl_convertValue_throw, implemented for i#106772; it would be best to remove that code, and let the database do its magic: e.g., passing a string like "1.99999" to a DECIMAL(19,4) field in MS SQL Server would round it to 2, while our code truncates it to 1.9999. The ODBC driver can handle more digits itself. But that isn't in the scope here, and may need to tweak other database connectors. Change-Id: Ib50c6d78bfd0cbf5ecd59f46f300107076ec0037 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171127 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-07-27sc: fix issues found by Ruff linterIlmari Lauhakangas
Change-Id: I6710db13549c42e9ae7231e0434a26b6357083e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171102 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-07-27odk, oox, pyuno: fix issues found by Ruff linterIlmari Lauhakangas
Change-Id: I79d56453877a10502768b522ca93da3990891c0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171098 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-01-24 08:37:32 +0000