summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-05-02tdf#114441 Convert sal_uLong to better integer typesAman Jha
* Use tools::Long for nY as it stores calculations with result values that can be sometimes negative * Cast nLine to sal_uInt16 as rModulWindow.ToggleBreakPoint() takes parameter of type sal_uInt16 Change-Id: Ibfdee40f37714406ee0f089c9a87f8b9a650e492 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145210 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-05-02remove unnecessary methodNoel Grandin
the call to GetObjectItemSet() in OleProperties::ForceDefaultAttributes() is unnecessary, because it is always called before ForceDefaultAttributes is called, and having removed that, the rest of the method becomes unnecessary too. Change-Id: Ibb09020837d47cb9eb1fb8b5deca1defc1465108 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151237 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-02use more specific class in sdr::table::CellNoel Grandin
mpProperties always points at a CellProperties object. Change-Id: Ie78d015a23b48c5b40cbf3564974870e49a0b2af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151239 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-02sw: prefix members of SvXMLImport, SvXMLImportPropertyMapper, ...Miklos Vajna
... SvXMLNumFmtHelper and SvXMLNumFormatContext See tdf#94879 for motivation. Change-Id: I1942fae05f2df1f23e0b05f8cb0eaa1f6df73f18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151252 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-05-02improve windows backtrace_to_stringNoel Grandin
I want to know the symbol address we actually capture, since we seem to getting duplicates in the output of SymFromAddr, I want to know if the fault is in SymFromAddr, or the backtrace capture call. Change-Id: Iece9c204abb780ae6b67a11e6ba77db816351e8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151254 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-02cid#1528432 Argument cannot be negativeCaolán McNamara
Change-Id: Ic55c524a9ec8ae9a4df7f96d284d822616fa3b54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151241 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-02Update git submodulesMarco A.G.Pinto
* Update dictionaries from branch 'master' to 03a891f1b00d9b1a14c6a72fb33cb682b549053a - Updated the English dictionaries: GB+ZA Change-Id: I82eb3829ab615d1b395effc8f149d1f0e5ccf12d Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/151227 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2023-05-02Test tiled rendering view separationParis Oplopoios
Make sure that changing the theme in one view doesn't change it in another view when doing tiled rendering Change-Id: I0a21dc36bfb825337fe74a11099ecc728b99c861 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149324 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-05-02elide temporary copyNoel Grandin
Change-Id: I3818767811ee92b39f475533144d0163a7e6931e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151236 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-02Update mdds to 2.1.1Kohei Yoshida
Change-Id: I4f708faa5b0017e7852e3b085825b6637f6fa988 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151244 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2023-05-01tdf#86630 sw page number wizard: add contextLabelJustin Luth
What the user should see in the menu is "Page Number...", but the label itself is better named Page Number Wizard. This label is used to distinguish it from other Page Number items in Options - Customize. Thanks to Seth for pointing this out in comment 39. Change-Id: I9df14822f3fd69e4dec1d08a198da740479ab571 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151240 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2023-05-01Related: tdf#119659 Use ValidColRowOrReplicated() for matrix dimension checkEike Rathke
... instead of only ValidColRowReplicated(), and check the return value. With this, the abort wouldn't had happened but an empty string returned for this case (which would had been wrong as well, but the caller has to check dimensions). Change-Id: I75218c479896893146b0e73d3c82215fe61cdf6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151235 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-05-01replace SwFrameFormats with sw::FrameFormats<SwFrameFormat*>Bjoern Michaelsen
- SwFrameFormats is now completely replaced by stronger typed sw::FrameFormats<>, thus remove it Change-Id: I7e655a83ba8cf01d1e68dccd1804c167e8daca9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150455 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2023-05-01AutoName is only used as Any, no need to extract into intermediate stringMike Kaganski
Change-Id: I00b0d647946e3943852098ff96cc09b7a2fd49ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151233 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-05-01Simplify and unify a bitMike Kaganski
Change-Id: Ife4b4b3beb4d31948aebbb2028ef0683013a7b58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151229 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-05-01tdf#152246 Test position of RTL elements in PDFHossein
This test checks the position of RTL/LTR elements in the exported PDF files. Without the fix in place, the test fails because the RTL elements will position as LTR, and the "Rect" element will be something else: double equality assertion failed - Expected: 303.349 - Actual : 56.699 - Delta : 1e-06 The Sample DOCX file contains both RTL and LTR content controls for testing. One may run the test with: make CPPUNIT_TEST_NAME=testTdf152246 -sr CppunitTest_vcl_pdfexport For an overview on PDF fill-in forms, please refer to: James C. King, Introduction to the Insides of PDF, pages 81-85 https://www.adobe.com/technology/pdfs/presentations/KingPDFTutorial.pdf Change-Id: I6c15b49bffb1aef6f137f7bb518a291f4d88b888 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151228 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-05-01docmodel: extract ColorDefinition into own file and renameTomaž Vajngerl
ColorDefinition is renamed into ComplexColor. Change-Id: I81c2d97e6b7bf9de4ce703c02b6db40636b04961 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151224 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-05-01docmodel: extract Transformation from ThemeColor into own fileTomaž Vajngerl
Change-Id: I45316e377cf895773037f500c521111f7e4d1ed7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151223 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-05-01Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 4e66412d1c72a51d6548c02baf8de9b4bbcfb92e - tdf#154940 update "Variable" label to "Custom" Change-Id: Ib03c304b6fca75a6e442c50f31accb697a1bd4ee Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151194 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2023-05-01tdf#154940 change label from "Variable" -> "Custom"Seth Chaiklin
Change-Id: I24db05dc26742513c1b6225d5c601ee19078ab87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151117 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-30Use getXWeak in slideshowMike Kaganski
Change-Id: Ica0290ee46286ff6d82634c378e40b3605d48a54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150869 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-30Use getXWeak in saxMike Kaganski
Change-Id: I24d61be2a1e1c21c08e50790b2d7bbb794c4fb07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150862 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-30Use getXWeak in scriptingMike Kaganski
Change-Id: I4370c0bfaa75b150bd05f03a5961e7152ac41e7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150864 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-30Use getXWeak in sotMike Kaganski
Change-Id: I68d6b7393b367b68206c92cd65705326c5aeda7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150870 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-30Use getXWeak in sfx2Mike Kaganski
Change-Id: I364f13308adf8b3257e53da2bc6576088bb958f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150867 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-30Use getXWeak in sdextMike Kaganski
Change-Id: I24563de37b98cad57823fe936e5bfa7e10e8a2c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150866 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-30Use getXWeak in shellMike Kaganski
Change-Id: Ied9a244a0fdd5973f2c9cb3bdd46500f6be2e0cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150868 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-30Firebird: add info FDB/FBK use on READMEJulien Nabet
Thank you again Mike for this info! Change-Id: Iab02f486035de48636d84148a045e86b24307a95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151218 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-30fix fuzzer buildCaolán McNamara
Change-Id: I9b980f3c81d468da4bcc33b6d27df9233f78c365 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151219 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-30ofz#58400 TimeoutCaolán McNamara
Change-Id: I6ded0d0613b66f7ec075796e257d93cf25822d2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151189 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-30adapt the new auto-fitting alg. to work for vertical textTomaž Vajngerl
And remove the old auto-fitting algorithm now. Change-Id: I0bf26d57955018b6d43783d860a0aeae596439b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151183 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-29Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to c02428dbc46618eb781bcbdeb816e20518a44e6c - tdf#152397 Fix Help page about Calc Input settings Change-Id: Ic7a92343279fb1321d4189cca32bad93e611c095 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151132 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-04-29Use getXWeak in avmediaMike Kaganski
Change-Id: I1dc1e597c50b0081375b9216ac4e6436b84aaa0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150832 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-29Use getXWeak in accessibilityMike Kaganski
Change-Id: Ifd6d57bb4087e6934075ff9f0931260cb8d09328 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150830 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-29Introduce cppu::getXWeak and cppu::OWeakObject::getXWeakMike Kaganski
To avoid explicit static casts when XWeak or XInterface is needed Change-Id: I0496a5b8dcd48743bceeef9f90904811acd556cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150807 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-29Simplify a bitMike Kaganski
Change-Id: I201dc0c1b9438b53656802c20c181654ee758a5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151127 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-29These are not applicable to FILEOPEN_SIMPLEMike Kaganski
Change-Id: Id2668a6b30f7062e42ec60b3664b9a7490feccd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151128 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-29Simplify a bitMike Kaganski
Change-Id: Idd17018c0fe452979f699d63f2166ae95241a3b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151129 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-29rename field in GroupPropertiesNoel Grandin
to distinguish it from the similarly named field in the DefaultProperties superclass. Change-Id: I8512c1a60e360a1e31ceaa86a8ff63ebe068d0cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151185 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-29reject fodt input that doesn't load and so doesn't exercise pdf exportCaolán McNamara
Change-Id: Ie8596618f62d245f35cb56e128c529464bc7cc25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151177 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-29add a fodt to pdf fuzzerCaolán McNamara
Initially give it a fairly tiny input size limit. Change-Id: Iabc2611174e88f1f6050edb21da4f28694bac4a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151151 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-29Resolves: tdf#119659 Check found position for result vectorEike Rathke
Change-Id: Idc454462c47b6c7b7b7cb6c86b08650d059221c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151186 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-04-29use XThemeColor instead of XInterface for *ThemeReference propsTomaž Vajngerl
Change-Id: I23b6a7429bbcf7901f3d817c970ee7ef4a453197 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151184 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-29Simplify a bitMike Kaganski
Change-Id: I5b39a16479a69c0683d8e04497ad24421112751c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151126 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-29Simplify a bitMike Kaganski
Change-Id: Id768a3e10eb593af84bdea423ddfd090df33eef2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151182 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-29tdf#155077: use the selected URL when writing languagesMike Kaganski
Regression after commit 9a55b97e980bbf2a0ce12841f6168f1f7545ac96 (tdf#40068 Remember last directory for basic/dialog import/export, 2021-07-14). Change-Id: I6ddb88cbe8a08128c451169de7e9ed4597dc4356 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151181 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-29tdf#45705 Define accelerators for zoom in/outRafael Lima
This patch defines the shortcut Ctrl+Shift+PgUp/PgDown for zooming in and out. Change-Id: I2ba486de82952e3cc06b56e70a8cb157cdae0ba2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150212 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-29Simplify strtmpl.hxxMike Kaganski
Replace bulky and difficult-to-read template argument names with clearer ones; remove excessive whitespaces; reorder to avoid forward declarations (these are remnants from the refactor from macros to templates, when I tried to keep the old structure as close to the original as possible). And also a small code simplification in doubleToString. Change-Id: I901cfb86daf410e85269538f36ebb6b553a4be76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151125 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-29Prevent to get 0 font size in the auto-fitting algorithmTomaž Vajngerl
When the text box is empty, the size of the box can be returned as (0,0) so the auto-fitting algorithm will calculate the scaling to 0%, which means the text is shrinked to very small size or is invisible. This change fixes the issue so that if the size is (0,0) we just return and leave the scaling at 100%. Change-Id: Ie359461f23a1f7a496eb03b5670f588ad48bbf49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151178 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to cac49fecf0b35af451fd0e043b21f86a8a46b38d - tdf#139027 More on INDEX() function + Review after erack comments Change-Id: Ibc294c35dd98cbd5c9f2b638db4e9cf31e768edd Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151175 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>