summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-09-20Clean-up follow-up to a4923f1d25c5449da3547ca5846379d719cee648Stephan Bergmann
..."CppunitTest_vcl_pdfexport: fix use after free" Change-Id: Ic82ea6c606e615f0eb3b62e48d2fd15db214db52 Reviewed-on: https://gerrit.libreoffice.org/60793 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-20tdf#119356 fix hand cursor for none input fieldsJan-Marek Glogowski
Inside the input field the cursor still changes to "edit", as expected. Change-Id: I4cec6ae5233143f5a0e4f1979deeb674d909f76c Reviewed-on: https://gerrit.libreoffice.org/60796 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-20Scope breaks; and add number comments to SwFieldIdsJan-Marek Glogowski
SwFieldIds is fixed, so add number comments to easier find the ID in the long list. Change-Id: I2b9fc00bd0ddc15fc327324c2895810d61e2870e Reviewed-on: https://gerrit.libreoffice.org/60795 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-20update creditsChristian Lohmaier
Change-Id: I1a8c8bc20ee7e97b47f0602dcfaa3cb1b771de8f
2018-09-20Removed executable permission on odt fileAndrea Gelmini
Change-Id: If08e90a11e57698f98af15a3f35648a98b03e062 Reviewed-on: https://gerrit.libreoffice.org/60771 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-20weld CopyDlgCaolán McNamara
Change-Id: Ic55ce7c8297f6a5122cfb4716b9d153a5856aff5 Reviewed-on: https://gerrit.libreoffice.org/60783 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-20rename ParaPrevWindow back to SvxParaPrevWindowCaolán McNamara
Change-Id: I3dc51ed38509a588003137bf295f005b031c20c3 Reviewed-on: https://gerrit.libreoffice.org/60777 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-20drop unused SvxParaPrevWindowCaolán McNamara
Change-Id: Ie217864bc9a5d8dd08d75a651b0826a07b9f1ed9 Reviewed-on: https://gerrit.libreoffice.org/60776 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-20drop unused widgets from glade catalogCaolán McNamara
Change-Id: I2406f24cc4f6de02e7a60cca905fa3139871ab12 Reviewed-on: https://gerrit.libreoffice.org/60775 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-20weld SvxHyphenWordDialogCaolán McNamara
Change-Id: If92d57c5c807a7fc04fe66a748aa385c558be664 Reviewed-on: https://gerrit.libreoffice.org/60774 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-20use can-focus for TB_TABSTOP|WB_NOTABSTOP, not editableCaolán McNamara
Change-Id: I56e60b98151c5dfcf8148ddafb6224bed734d039 Reviewed-on: https://gerrit.libreoffice.org/60773 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-20weld BreakPointDialogCaolán McNamara
Change-Id: Icecef8b0b939c5d87bdf1bb781731df8fc4419b5 Reviewed-on: https://gerrit.libreoffice.org/60756 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-20Do not crash when there are more default personas than intendedMuhammet Kara
Change-Id: I516607375b2f296e562bb378e5051303cd27055b Reviewed-on: https://gerrit.libreoffice.org/60492 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-20loplugin:useuniqueptr in xmlsecurity::BufferNodeNoel Grandin
Change-Id: Ifaea9f2f0ef5b84372b2ba51deacdb4149bb66e1 Reviewed-on: https://gerrit.libreoffice.org/60616 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-20tdf#115405, tdf#119910: don't check if UCRT is already installedMike Kaganski
There appears to be common situation that a system has *some* UCRT libraries in System32, that were installed improperly (presumably by some applications using simple copy).In these cases, our installer would detect the presence of ucrtbase.dll, and not try to install UCRT on the system. Unfortunately, it seems that oftentimes such improper UCRT installations miss some parts of UCRT, which leads to LibreOffice failing to start with messages like "The program can't start because api-ms-win-crt-string-l1-1-0.dll is missing from your computer. Try reinstalling the program to fix this problem." (the missing component varies). This patch removes the check for UCRT presence. Installer will try to install UCRT on applicable systems unconditionally. Since the proper outcomes in case of already present UCRT are either WU_S_ALREADY_INSTALLED or WU_E_NOT_APPLICABLE and both are treated as success in inst_msu action (see InstallMSU in setup_native/source/win32/customactions/inst_msu/inst_msu.cxx), this should only make this part more robust, and not bring new problems (yes, I know that actually there will be new problems, as usual). Change-Id: I22a3d357014d31a8e492ff8a15bcb477eeb79735 Reviewed-on: https://gerrit.libreoffice.org/60789 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-09-20xmlsec: drop no longer needed xmlsec1-1.2.14_fix_extern_c.patch.1Miklos Vajna
Commit 2d1e4290a92a9ac153fa73edbaa050941ee0040b (Merge Gentoo patches from old build and downstream repositories., 2011-03-13) mentions this was necessary for libxml-2.7.8, but xmlsec already depends on 2.8.0 and the same "extern block starts before the include list" pattern is there in every other xmlsec header, so the patch was incomplete anyway. Change-Id: I33fadcb3e5583266a37cf7f240b27b2df1544040 Reviewed-on: https://gerrit.libreoffice.org/60782 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-20CppunitTest_vcl_pdfexport: fix use after freeMiklos Vajna
Just do the minimal fixing, a follow-up commit should clean up the copy&paste coding that happened here in previous commits. Change-Id: I44306e2fee57d55997414e62120c7e5037f306fb Reviewed-on: https://gerrit.libreoffice.org/60757 Tested-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-20Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' - Fix typo Change-Id: Ia566d8214b6b055adbb29b4dcf1c3eb52769fa46 Reviewed-on: https://gerrit.libreoffice.org/60785 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-20Replace SAL_OVERRIDE with override in internal codeStephan Bergmann
Change-Id: Ifa446647b11fd1f1b0dc6a991b752480545634db Reviewed-on: https://gerrit.libreoffice.org/60788 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-20tdf#108402: avoid crash if filter doesn't matchJulien Nabet
See bt https://bugs.documentfoundation.org/attachment.cgi?id=134006 + display warning Change-Id: I38496364c0965015ea54f753f3d3550f317d88d8 Reviewed-on: https://gerrit.libreoffice.org/60413 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-20loplugin:useuniqueptr in QuartzSalBitmap::CreateColorMaskNoel Grandin
Change-Id: I7fbebf3730aa79209a3ad954522ad8695e5d8c24 Reviewed-on: https://gerrit.libreoffice.org/60704 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-20convert SwGlblDocContents to sorted_vector<unique_ptr<>>Noel Grandin
Change-Id: I9766a03739aa63be8f42fc99012577cfa154298d Reviewed-on: https://gerrit.libreoffice.org/60738 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-20tdf#64264 DOCX import: fix row count of repeating table headerLászló Németh
by ignoring isolated tblHeader settings, according to the standard. (OOXML 17.4.49 tblHeader (Repeat Table Row on Every New Page) "...if this row [with tblHeader property] is not contiguously connected with the first row of the table (that is, if this table row is not either the first row, or all rows between this row and the first row are not marked as header rows) then this property shall be ignored.") Note: with this fix, in a mixed environment, LibreOffice is able to fix the known problems of MS Word 2013/2016 by removing the isolated tblHeaders during DOCX import/export (such problems in MSO: missing repeating headers in a few pages or in the whole table, despite the correct settings; and non-modifiable repeat header row property in the table settings). Change-Id: I73e8394a75b77c937a4bac37d99ff747ad95a06e Reviewed-on: https://gerrit.libreoffice.org/60765 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-09-19sw: new unit test for XScriptProviderVasily Melenchuk
Change-Id: I2954bff51d6a507fef4d8a22ff5964735f1cee60 Reviewed-on: https://gerrit.libreoffice.org/60640 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-09-19null parent is a bad ideaCaolán McNamara
Change-Id: Ifcd9039c2de396a4cadf3ba557df3cff3cc6001c Reviewed-on: https://gerrit.libreoffice.org/60772 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19drop some unnecessary headersCaolán McNamara
Change-Id: Ic26c41e1d6be76e28081cc0110cd2335c03d2e27 Reviewed-on: https://gerrit.libreoffice.org/60755 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19weld SmFontDialogCaolán McNamara
Change-Id: Id253631e7dfd44570a4261b7a7a5db1fac9d68ba Reviewed-on: https://gerrit.libreoffice.org/60728 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19set modal flagsCaolán McNamara
Change-Id: I9dca572b413f9cbd19f3f095d049be294be94e4c Reviewed-on: https://gerrit.libreoffice.org/60719 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19weld TPGalleryThemeGeneralCaolán McNamara
Change-Id: Id5ec1b1282c039f30c40fc781be0f6d72a8bfb47 Reviewed-on: https://gerrit.libreoffice.org/60718 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19weld SvxGrfCropPageCaolán McNamara
Change-Id: I7e239e5487a1ae642d009f313dd4aae20ee0de81 Reviewed-on: https://gerrit.libreoffice.org/60717 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19Make compilers combine sUNO_* vars across TUsStephan Bergmann
...by changing them from internal linkage to being inline (where available). The net effect is that compilers (that HAVE_CPP_INLINE_VARIABLES) are required to combine all uses of a given sUNO_* var across a Library, where before that was only possible if the compiler could prove that placing multiple such vars across TUs at the same address didn't change the program's behavior. (And > $ diff <(nm --def instdir/program/libsdlo.so | grep sUNO_ | cut -d ' ' -f 3 | LC_ALL=C sort) <(nm --def instdir/program/libsdlo.so | grep sUNO_ | cut -d ' ' -f 3 | LC_ALL=C sort | uniq) > 2d1 > < _ZL16sUNO_View_ViewId > 8d6 > < _ZL18sUNO_View_PageKind > 23d20 > < _ZL22sUNO_View_LockedLayers > 30d26 > < _ZL23sUNO_View_VisibleLayers > 39d34 > < _ZL25sUNO_View_PrintableLayers showed that there were duplicates, while > $ nm --def instdir/program/libsdlo.so | grep sUNO_ | cut -d ' ' -f 3 | LC_ALL=C sort | uniq | wc -l > 71 shows that only 71 of the 117 sUNO_* vars are actually used at all---there's still room for clean up.) Introduces LIBO_INTERNAL_ONLY SAL_INLINE_VARIABLE. Change-Id: Icf92116de9ea4019d298e325d2a83009317f7a4c Reviewed-on: https://gerrit.libreoffice.org/60743 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-19tdf#90850 Enable align commands for a single shape in WriterMaxim Monastirsky
Similar to images and frames. Just exposes the existing position settings from the "Position and Size" dialog. Change-Id: Ifa7e91f695af74d5297412e5ffeb12286ec63767 Reviewed-on: https://gerrit.libreoffice.org/60649 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-09-19tdf#119819 Disable Rename Layer command when not possibleMaxim Monastirsky
Change-Id: I5bb330295c1052679ed19ebeb0d6e5591640867d Reviewed-on: https://gerrit.libreoffice.org/60650 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-09-19Update orcus to 0.14.1.Kohei Yoshida
Change-Id: I345d2655c1999ab319b92c6e8719c0eb9572000b Reviewed-on: https://gerrit.libreoffice.org/60731 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-09-19Removed duplicated includeAndrea Gelmini
Change-Id: I4e499da70bc1f5656c49dba7c9261a6082b131bc Reviewed-on: https://gerrit.libreoffice.org/60635 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-19drop unused cuilo-BackgroundPreview from catalogCaolán McNamara
Change-Id: Ib8707b29c44291fe18d86660d9bfaaed742afbd6 Reviewed-on: https://gerrit.libreoffice.org/60716 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19rename RectCtl back to SvxRectCtlCaolán McNamara
Change-Id: I4adde35b198d45fed09d837de5c1370d2a879f4b Reviewed-on: https://gerrit.libreoffice.org/60715 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19drop newly unused SvxRectCtlCaolán McNamara
Change-Id: I41fc4f53bedb4d5504aed39bd4d3052e2084fa6d Reviewed-on: https://gerrit.libreoffice.org/60714 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19rename to original namesCaolán McNamara
Change-Id: I1f4f57b77982a71f9be7cb5cd61116c9aa77189e Reviewed-on: https://gerrit.libreoffice.org/60713 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19drop newly unused codeCaolán McNamara
Change-Id: Ie907cfb4bed26cade09cf1c365a5e4cbc9aea31b Reviewed-on: https://gerrit.libreoffice.org/60712 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19weld GraphicFilterSmoothCaolán McNamara
Change-Id: I9f92b49bff105965c13e5977ef39788c6684da29 Reviewed-on: https://gerrit.libreoffice.org/60711 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19weld GraphicFilterPosterCaolán McNamara
Change-Id: I1e8af81267fdadc725eee8ac28e4dcf038cc50d9 Reviewed-on: https://gerrit.libreoffice.org/60710 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19weld GraphicFilterMosaicCaolán McNamara
Change-Id: I2bd52c8a998ecfc168b4fd0cecf79e49c12604eb Reviewed-on: https://gerrit.libreoffice.org/60709 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19weld GraphicFilterSepiaCaolán McNamara
Change-Id: Id57f29f4694a8aaa395f5f166744d06e4adfb492 Reviewed-on: https://gerrit.libreoffice.org/60708 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19Fix typoAndrea Gelmini
Change-Id: I644fed22dd46458623a1f99f7eefbdc2a7b31fc1 Reviewed-on: https://gerrit.libreoffice.org/60770 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-09-19weld GraphicFilterSolarizeCaolán McNamara
Change-Id: If729ea1688e9dc15372a59d75c972ee37511f76e Reviewed-on: https://gerrit.libreoffice.org/60680 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19weld GraphicFilterEmbossCaolán McNamara
Change-Id: Ic3c816ddd7d5df9c5ced14600fffd6ca59f0096e Reviewed-on: https://gerrit.libreoffice.org/60594 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19tdf#118502 Fix loading of eps images with replacement graphicSamuel Mehrbrodt
Change-Id: Iaf9c8e2ed72115e1f82d2541ae2a1d4803795a46 Reviewed-on: https://gerrit.libreoffice.org/60752 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-09-19generateGUIDString: Fix incorrect string lengthSamuel Mehrbrodt
This bug caused signature line IDs in OOXML to be written with an appended "_x0000_". Change-Id: If219279a5d5177ec5fac2d9dd747dc015c16b6bc Reviewed-on: https://gerrit.libreoffice.org/60736 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-09-19convert SwContentArr to sorted_vector<unique_ptr<>>Noel Grandin
Change-Id: I97b9c143bf5e1aefc4324609b6c69e2fb07b8d00 Reviewed-on: https://gerrit.libreoffice.org/60739 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>