summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-10-21Make ConvertFieldsToText privateMike Kaganski
Change-Id: Ie3d22b63260d2b2b05a46c5b2a6ca915cf9d4bcd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158304 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-21tdf#135922 wina11y: Report text-related IA2 obj attrsMichael Weghorn
Extend `CMAccessible::get_attributes` so that it also reports the text-related IAccessible2 object attributes, since what is meant to be reported as a text attribute and what is meant to be reported as an object attribute differs between the IAccessible2 specificiation and what LibreOffice does on the UNO level, s. the commit message in this previous change for more details: Change-Id Ief7c840d3c5274714a914ca0e56df0c5eaffb06d tdf#135922 a11y: Prepare reporting text attrs as IA2 obj attrs Just use a character offset of 0 when querying via the `XAccessibleText` interface here. The exct offset used used shouldn't make any difference for paragraph-specific attributes. With this and the NVDA pull request [1] to evaluate attributes according to the IAccessible2 text attributes and IAccessible2 object attributes specifications, NVDA now reports the alignment of paragraphs in Writer, e.g. says "align center" since the corresponding attribute is now reported for the paragraph object, as can also be seen by querying the IAccessible2 interface manually in NVDA's Python console: >>> focus.IAccessibleObject.attributes 'heading-level:;level:;text-align:center;' ("text-align:center;" was not yet reported without this change in place.) [1] https://github.com/nvaccess/nvda/pull/15649 Change-Id: I5723797232f89db6a2b74d4a601344f2078ee630 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158260 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-21a11y: Improve XAccessibleExtendedAttributes docMichael Weghorn
The existing // MT: I guess it's not formula only? comment was justified. `XAccessibleExtendedAttributes::getExtendedAttributes`, is not only used to report formulae, but e.g. used to report a heading level by Writer paragraphs (s. `SwAccessibleParagraph::getExtendedAttributes`), so adjust the documentation and align it with the `IAcccessible2::attributes` one [1] that also uses the cell formula as an example. [1] https://accessibility.linuxfoundation.org/a11yspecs/ia2/docs/html/interface_i_accessible2.html#a0d51b0c189a000ee3b6ddf7f68da2009 Change-Id: I2d6f38911c3802edb55f9426a35b8986dd6e399a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158259 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-21wina11y: Just return empty attr string when none presentMichael Weghorn
If the `XAccessibleExtendedAttributes` interface isn't implemented, just return an empty string for the attributes instead of an error code. (This seems like a totally valid case to me, no need to report an error.) Change-Id: I986f030bc7a01da0fdd92a5aa2b4cf3c0d6a9200 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158258 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-21wina11y: Indent try blockMichael Weghorn
Change-Id: I89a4ed514e1c24e683b081d04f72cd62ede80065 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158257 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-21tdf#135922 a11y: Report IA2 "text-align" attrMichael Weghorn
Map the "ParaAlign" UNO text attribute to the IAccessibl2 *object* attribute "text-align", as specified in the IAccessible2 object attributes specification. [1] This causes the corresponding "justification" AT-SPI text attribute to be reported when using the qt6 VCL plugin on Linux. For Windows, bridging this to the platform a11y will be implemented in an upcoming change. See the commmit message of the previous change Change-Id Ief7c840d3c5274714a914ca0e56df0c5eaffb06d tdf#135922 a11y: Prepare reporting text attrs as IA2 obj attrs for more details. [1] https://wiki.linuxfoundation.org/accessibility/iaccessible2/objectattributes Change-Id: I6a0478a4ac37f69393e995602ed698b5a78488e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158256 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-21tdf#135922 a11y: Prepare reporting text attrs as IA2 obj attrsMichael Weghorn
According to the IAccessible2 specification, some of the attributes that LibreOffice handles as text attributes are mapped to IAccessible2 text attributes as well [1], but others should be reported as object attributes [2], e.g. text alignment is reported via the "text-align" object attribute on the paragraph object. So far, `AccessibleTextAttributeHelper` was only handling attributes that are mapped to IAccessible2 text attributes. Prepare for reporting object attributes as well, which will be required to report text alignment on Windows in a compliant way (s. tdf#135922). On the other hand, Qt also expects `QAccessibleTextInterface::attributes` to return text formatting using the attributes specified in the IAccessible2 attribute specifications and maps that to the platform-specific attributes (AT-SPI text attributes on Linux), but currently does not provide any way to report object attributes in addition to text attributes. It however supports e.g. the "text-align" attribute mentioned in the IAccessible2 object attribute specification when it's reported as a text attribute [3]. Therefore, add a new `IA2AttributeType` enum that can be used to specify what kind of IAccessible2 attributes (text attributes, object attributes) to report. Only request IA2 text attributes on Windows when text attributes are requested, but both types for Qt. So far, support for none of the object attributes has been implemented, but an upcoming change will do that. [1] https://wiki.linuxfoundation.org/accessibility/iaccessible2/textattributes [2] https://wiki.linuxfoundation.org/accessibility/iaccessible2/objectattributes [3] https://code.qt.io/cgit/qt/qtbase.git/tree/src/gui/accessible/linux/atspiadaptor.cpp?id=546208f0ff23819d216cbb5bf0b5daded79b454e#n2193 Change-Id: Ief7c840d3c5274714a914ca0e56df0c5eaffb06d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158255 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-21clang-format sal/rtl/math.cxxMike Kaganski
Change-Id: I0e807118e6a2196d2f2858ed195782a90572a2e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158303 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-21tdf#153519 Another TreeListEntryUIObject heap-use-after-freeStephan Bergmann
...similar to the one addressed with the commits leading up to 9a23ded27470a4c57015e9e5d686259a60d464f2 "Fix thinko when to sleep" Change-Id: Iecf0146c4c079ae95f980128531ac8f51b4b8535 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158302 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-21Extended loplugin:ostr: Automatic rewrite some O[U]StringLiteral -> O[U]StringStephan Bergmann
Change-Id: I8c08bf41b96d4a6085e7d72cb39e629efa556d09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158300 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-21mariadb connector: upgrade to release 3.3.7 (fixes tdf#157826)Mike Kaganski
Change-Id: I053b827b7bc14535760236fcb057c154c359f4dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158252 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-21Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: fpickerStephan Bergmann
Change-Id: Id2e70665c78f5e5fd3dc7ab0f5889f83880804ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158299 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-21tdf#156182, tdf#156685: vcl_pdfexport: Add unittestXisco Fauli
Change-Id: I6756f1f19b9cc178191a47ea81857981f44aced0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158264 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-10-21Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: writerfilterStephan Bergmann
Change-Id: I6d566f7d7d2ef3d7d5efdd3cc94f129c6b4dbbb3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158292 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: sdStephan Bergmann
Change-Id: I4dc708ee57a7e305f4e377bde0e486299df56f0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158297 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: writerperfectStephan Bergmann
Change-Id: Ibaf69c1d922be6fade028ce6602f215cd9cd35cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158293 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: vclStephan Bergmann
Change-Id: Iaeacacbbb0eec907d884219aa2bcfe7a86f00a2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158291 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: xmlsecurityStephan Bergmann
Change-Id: I6cdabef12d60f9fa554b95c99e702e8c700329e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158296 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: xmlscriptStephan Bergmann
Change-Id: I8cde43bd9999c93b45376e9684f98f654d050864 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158295 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: xmloffStephan Bergmann
Change-Id: I2d58bbea770c4dd188cae13e11218a29f4cd5d05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158294 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: vbahelperStephan Bergmann
Change-Id: Idb944974318a94763532639c9e74040adadf06f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158290 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: toolsStephan Bergmann
Change-Id: I930c794c6f93531ef8d2b91c5e6ad62b486966dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158245 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20tdf#157026 sd notebookbar: add ObjectAlign to MenuTable as popupmenuJustin Luth
The vast majority of this is just eliminating copy/paste, since I have now created a popupmenu.xml list for the popup menu. The "fix" is adding this to the Table menus. .uno:ObjectAlign is basically just a "label". Now it is a label for two different "views": * a toolbar widget dropdown * a menu subcategory Perhaps it is confusing to have one UNO entry serve these two similar purposes? I suppose someone might also complain that a simple <menu:menu menu:id=".uno:ObjectAlign"/> isn't clear that this is a submenu. I considered making mine a new ObjectAlignMenu, but the annoyance of having to create a duplicate string translation in officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu made me just reuse the existing label. Change-Id: I17e037e0c9c5d1f57ac9f174a76cd041983bcea4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157894 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-10-20CppunitTest_sd_import_tests-smartart: make testAutofitSync more robustMiklos Vajna
- replace 'Calibri Light' with 'Noto Sans' (we bundle the later) - replace 'Calibri' with 'Arial' With this: diff --git a/sd/CppunitTest_sd_import_tests-smartart.mk b/sd/CppunitTest_sd_import_tests-smartart.mk index 9b7362b08152..72e0dead7731 100644 --- a/sd/CppunitTest_sd_import_tests-smartart.mk +++ b/sd/CppunitTest_sd_import_tests-smartart.mk @@ -11,4 +11,6 @@ $(eval $(call sd_import_test,-smartart)) +$(eval $(call gb_CppunitTest_set_non_application_font_use,sd_import_tests-smartart,abort)) + # vim: set noet sw=4 ts=4: doesn't abort anymore. In fact the second replacement is just for completeness, the first was enough alredy. Change-Id: I455b473233e351b7a2ee6a1b1b66049e63a8a6ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158263 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: toolkitStephan Bergmann
Change-Id: I67ba7b0f4d99f080b343a9b26a242cf4008b820c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158244 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Avoid double notifications for deletion caseMike Kaganski
Follow-up to commit 34ac12dca3f5af50fddfb7c77e2943897980b815 When old redline is own Insert, and the new one is Delete, it means that it was already handled in DocumentRedlineManager::DeleteRedline. This also reverts the unit test change done in the mentioned commit. Change-Id: I77e59dceb1c880fc6ec10ad98867be3bf5282f70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158253 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: svxStephan Bergmann
Change-Id: Ib5028b826a3f62303b9e0502af70ad62c578fbb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158240 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: scriptingStephan Bergmann
Change-Id: I74516d08ed48f2c9f4a0d4e105c96f95c127485b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158218 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20loplugin:indentation (macOS)Stephan Bergmann
Change-Id: I176ac2153d4f2daa48ed4bf85d123904c234f8f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158251 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Update git submodulesJulien Nabet
* Update dictionaries from branch 'master' to 3978d026b57097ede0be8ac6e4ffd1164ada7474 - Fix path of logo for Spanish dictionary Regression from c1ddcf602ba97f8e99383f34e8027074d8193f61 "Updating RLA-ES Spanish spellcheker to v2.8." There's no "images" subdir in "dictionaries/es" Change-Id: Ia18110dbe04feec6553fb80501450546a0ac79a2 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/158169 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: unodevtoolsStephan Bergmann
Change-Id: I21dd038249b506ecc58a7002fd3dcd4366176b52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158248 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20sc: perf: avoid construction of collector for empty note columns.Michael Meeks
It is extremely common to have empty note columns; so shorten this path profile in: cool#7334 Change-Id: Ibfd550be1a5e8e98df8b4ede0d018c4f85300648 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158158 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: ucbStephan Bergmann
Change-Id: Ic3123585203ebcdf2fe791709d38551e7a326d04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158246 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: ucbhelperStephan Bergmann
Change-Id: Ib4b300e8b21f772c97dcb49d666f93d2821f0859 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158247 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: unotoolsStephan Bergmann
Change-Id: Ia3722b27955e444b67a97c478739db696fa3dcaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158249 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: testtoolsStephan Bergmann
Change-Id: Idc0de002b7ca4e370add311f91576adaaf354764 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158243 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20fix GBUILD_TRACE on cygwin, needs to have unix-style path for the logChristian Lohmaier
make's abspath function turns the path into windows-style, but that fails for appending to the log/the rule needs a unix-style path Change-Id: Ibb4a32bee10f7c69e8f57c1a771efc85ace283e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158238 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-10-20fix make GBUILD_TRACE=/path/to/log.json for non-macChristian Lohmaier
my previous patch to make it work on mac ( 4b67515418ee4f10071b3f0f2275ba37f32b0ae5 ) actually broke the timestamping for other platforms, as the date command no longer was treated as a shell-subcommand due to the lack of the additional $ to quote the statement.. Oups. But at least fixed within a year, people need to use it more! :-)) Change-Id: Id4e20fb11540824555ce4c04d3abed55be9185c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158236 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: testStephan Bergmann
Change-Id: I883d34c9562b48d987a16a0254272f3aeeb4bf5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158242 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: swStephan Bergmann
Change-Id: I85fff7ed6932c5fc196e18f24fa01074ba4837e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158241 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20tdf#157793 limit tdf#157635 fix to only larger palettesPatrick Luby
I don't know why, but the fix for tdf#157635 causes images with a palette of 16 entries to be inverted. Is this the only condition for masking out black pixels in non-transparent animation frames? Change-Id: I9550baab4dc4d9b75a21c8af2f6c0b5eb8e46c12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158214 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Patrick Luby <plubius@neooffice.org>
2023-10-20sw floattable: remove now unused FloattableNomargins compat flagMiklos Vajna
This was noop since commit 626fe9ab5ebebc4ef36e35f4aa597c03a3564d22 (tdf#157573 sw floattable: fix incorrect lack of left margin after table, 2023-10-18). Change-Id: I89a197313ac4ffbcff9bbff534e5411085282ac8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158237 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-10-20Typo in comment "af"->"of" in XReference.idlJulien Nabet
Change-Id: I99c52dcf7fe5db7226090c3685d27b2f333a16eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158235 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2023-10-20ofz#63374 avoid AbrtCaolán McNamara
Change-Id: I63e609e40a9453000a8f296f4b02f167902fd790 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158211 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-20remove SAL_WARN in _setPropertyValueNoel Grandin
since so much code higher level code is now just asking for random properties and just catching the UnknownPropertyException for the cases where the object does not support that property Change-Id: I9198ec0c540252783015cffa088be30451f92c3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158231 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-20external/lxml: Fix --enable-python=fully-internal buildMichael Weghorn
After commit a4b4a90557f9fc1839fc0eb297f4c6a4e94c761a Date: Sun Jul 2 14:54:23 2023 +0900 lxml: upgrade to release 4.9.2 , my `--enable-python=fully-internal` build started to fail with Building lxml version 4.9.2. Building without Cython. Building against libxml2 2.9.14 and libxslt 1.1.35 Traceback (most recent call last): File "setup.py", line 207, in <module> setup( File ".../libreoffice/instdir/program/python-core-3.8.18/lib/distutils/core.py", line 108, in setup _setup_distribution = dist = klass(attrs) File ".../libreoffice/instdir/program/python-core-3.8.18/lib/distutils/dist.py", line 274, in __init__ warnings.warn(msg) UserWarning: Unknown distribution option: 'project_urls' make[1]: *** [.../libreoffice/external/lxml/ExternalProject_lxml.mk:26: .../libreoffice/workdir/ExternalProject/lxml/build] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:289: build] Error 2 and Julien reports the same in [1]. The above commit includes a patch to switch from setuptools to distutils. Possibly the distutils variant of the `setup` function doesn't know about the "project_urls" keyword argument (at least in our bundled Python version), so extend the patch to drop that from the `setup.py`. [1] https://gerrit.libreoffice.org/c/core/+/153863 Change-Id: Icfac9fb0a3c62d3b30c12bc23ddbc0f9b088d788 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158230 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: stocStephan Bergmann
Change-Id: Ic8c251b97f5e5bdf81599534384d86ac9904da53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158222 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20set accessible IndexHint in sdNoel Grandin
to avoid some more spurious SAL_WARN Change-Id: Iff1dfea4857e780d0b3739c7b1688eb7df243907 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158232 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-20CppunitTest_sd_png_export_tests: relax test even moreXisco Fauli
I misread https://gerrit.libreoffice.org/c/core/+/158181/3#message-f54ed5a8dcf1d68fea73ace5ff9851d3d5fe5a2f Change-Id: I31523af088f8fa83f43a8a49e449d27b0f230149 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158229 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-10-20Use getXWeak in toolkitMike Kaganski
Change-Id: I44a0ddd386ea6d262d6102b40f3e9837655068ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150877 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>