summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-05-26fix leak in ScAcceptChgDlgNoel Grandin
Change-Id: I51636d04389c8493377fe906314ef5d8f5c372d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116140 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-26fix also the Win64 tinderboxesChristian Lohmaier
they were using manual configuration instead of the distro-configs Change-Id: I82a690986e24e704c66297c9bc4c3d3d1e70b636
2021-05-26Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 96e26682870d3032dc0cccc6ed0a580f22111998 - Fix SF_UI ShowProgressBar description Change-Id: Ib8b0b89511c1bb04acb7e79064ae5c9d8678b71d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115970 Tested-by: Jenkins Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2021-05-26gtk4: GtkSpinButton has a GtkText not a GtkEntry nowCaolán McNamara
so can't call gtk_entry_set_icon_from_icon_name on it Change-Id: I596a37ec935240b9ed92361e428e398010911b28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116174 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26fix leak in BuildMultiPortionNoel Grandin
Change-Id: I267d59bdc8ac2f17d223d0345c4bcb4ea40a8704 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116149 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-26fix leak of SwCompareLine in CompareDataNoel Grandin
(*) store the SwCompareLine as a vector, SwCompareLine contains a single pointer, no need to allocate separately on heap (*) which means we need to convert SwCompareLine::m_rNode to m_pNode in order that SwCompareLine can have an assignment operator Change-Id: Idafba6f6384f36c9d048169e793db2d50c6d8bc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116151 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-26fix leak in SwRedlineAcceptDlgNoel Grandin
Change-Id: I905d394db9339efda77e4f014e795c4f2d5f4584 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116138 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-26configure: merge extra test for $enable_cupsJan-Marek Glogowski
Change-Id: Ic98a6db70355aa24e29590bb9cb1416c15852090 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116144 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-26tdf#96061 Unset the highlight propertyGülşah Köse
When we have highlight property on specific part of the text the following texts were highligthing. To prevent this we unset the highlight property when we have not highlight property anymore. Change-Id: I802cde1c784afe47201a9ba4f41827dd0c705035 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115800 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-05-26Fix DISABLE_DYNLOADING unused variableJan-Marek Glogowski
Change-Id: Ie8305364971f324bd834ae6bec851637ca60b9e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116118 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-26supress leak checking in JavaVMNoel Grandin
Change-Id: I82cb41518524949bbd578778724b92d9ebcecad4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116139 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-26ofz#34602 missing a componentCaolán McNamara
Change-Id: Ib2f281579af58f536f1291866c9990e8fc9e8cef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116146 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26gtk4: reenable ImageCaolán McNamara
this is possibly wrong wrt scaling/hidpi, something of a stopgap for now anyway I feel Change-Id: Ia0e4bbdf760d7577c304f489795005f7252eb57b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116131 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26fix jenkins tinderboxes config after 15ab55c092e0b474827abe104b73c5bfab6ef28cChristian Lohmaier
Change-Id: I108536fbcd557ed899e1b6fda2316c9d89249681
2021-05-26tdf#115088 convert UITest to CppunitTestMiklos Vajna
So that when it fails, it's easier to debug because it's in-process. Change-Id: Ia7d12291b25304967a22e546b12803864a713541 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116127 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-05-26tdf#142231 sc odf: fix export of single date filter valueSzabolcs Toth
by export the sting value of the filter condition, if its filter by date. Change-Id: I537fbd43810c78c0834480c9f1a480481aedd742 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115775 Tested-by: Balazs Varga <varga.balazs3@nisz.hu> Reviewed-by: Balazs Varga <varga.balazs3@nisz.hu>
2021-05-26Seperate SvxBackgroundColorItem from SvxColorItemGülşah Köse
SvxBackgroundColorItem derivated from SfxPoolItem instead of SvxColorItem. Casting is common usage to control if object is this or not. When we can cast SvxBackgroundColorItem to SvxColorItem we can not seperate them anymore. eg: Char color is a SvxColorItem and char background color is a SvxBackgroundColorItem. They can be hold together and we should understand they are different types. Change-Id: I7b1879a1b00de26c0b8a2d9f8d658aa3aef75ecb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116135 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-05-26Improve error diagnosticStephan Bergmann
Change-Id: I1d7b82da3d0597aa6c5ffb251b9ad08bf464d2e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116136 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-26CoreToPixel should take a SwRect argumentNoel Grandin
Change-Id: Idbed2a8fc6b4bc289c3bb0e761931f0b3d672620 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116121 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-26make SwRect(Rectangle) constructor explicitNoel Grandin
Change-Id: I715aa9499598c483ccf907f829c9ba3540edf216 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116120 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-26Replace a use of select with pollStephan Bergmann
...to avoid undefined behavior with file descriptors >= FD_SETSIZE (cf. 0a126b4c661d65860fd2de92f8cc49bdb65a957c "Deprecate osl_demultiplexSocketEvents et al") Change-Id: I168072b50efc5d50ee3767d0b56be4a8ffa12924 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116119 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-26remove obsolete/duplicated entries from openoffice.lst.inChristian Lohmaier
The xml configuration related stuff is no longer (since 2013, with 89ac3c4acae1f0ffe3e96933d3449749ddf86847) done in installer code, but by postprocess/CustomTarget_registry.mk openoffice.lst is only used for package generation itself, and by extension for the replacement of values used in scp2 (those are replaced by "replace_all_ziplistvariables_in_file" (for the ${NAME} style ones) in solenv/bin/modules/installer/scpzipfiles.pm and (for the <name> style) by replace_setup_variables in solenv/bin/modules/installer/scriptitems.pm the files that would be created by scp2 in case for an installation set (e.g versionrc, bootstraprc) are created by instsetoo_native/CustomTarget_setup.mk for plain instdir Change-Id: I761ea25aa98bbdcc310836257e288322fbfc437b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116128 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-05-26add privacy URL to crashreport dialog & updatecheck tab in optionsChristian Lohmaier
Change-Id: I35cda87c35876469bf581be223bc608e29f07b09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116105 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-05-26clang-format crashreportdlgChristian Lohmaier
Change-Id: I58031cafaa9481ba6e8d77a7106485d8274e5bc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116104 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-05-25tdf#116413 keep AttachNewFormulaCell methods togetherscito
Add public block instead of moving method to a public block. This was suggested in https://gerrit.libreoffice.org/c/core/+/114641/11/sc/inc/column.hxx#724 Change-Id: I30fd8f3348cdcc047d5b0d8856920b6e4e4a0c63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116076 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2021-05-25Related: tdf#81757 Do not even try to re-enter ScDocShell::Do*Recalc()Eike Rathke
That happened when loading bug doc https://bugs.documentfoundation.org/attachment.cgi?id=103462 where form selection events fire asynchronous recalcul() and BASIC Main also calls recalcul. Change-Id: Ic27fb340c7b5019453723c7cabe2122905d400f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116133 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-05-25tdf#139196 - Import/export macros using utf-8 including BOMAndreas Heinisch
In addition, try to detect the charset during the import of a *.bas file. Change-Id: I0dfe7f1b5349db409d90ed92b2e19c9946ae50cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116004 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-05-25ofz#34602 missing a componentCaolán McNamara
Change-Id: Id069c3718a632046fa9df59ee145e0c904aaf718 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116129 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-25ofz#34601 teardown crash under oss-fuzzCaolán McNamara
Change-Id: Icbb1500a85f956c8100878d6a0bef30b98440c32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116114 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-25Don't ignore GCC warnings for static buildsJan-Marek Glogowski
Instead simply (and correctly) test the function pointers in the static build case. Change-Id: I01b3397f40671464b1d2cb472447d8530b996d21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116117 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-25Install GDB pretty printers into cross-toolsetJan-Marek Glogowski
Change-Id: Id42dd694514e104d03c649a19788b5c192ec35a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116116 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-25fix some crypto leaksNoel Grandin
Change-Id: I8f0eddd5ec82200dca374c2191ed5ac28c66089a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116100 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-25configure: Replace tabs with spacesJan-Marek Glogowski
Change-Id: I417c734484481223f1779e0c555b4f3e16e10b23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116112 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-25Add forgotten io/Executable_io-testconnection.mkStephan Bergmann
...missing from ef88aa5e7400769c0a17c28e66b1ee957c2f667e "Resurrect io testconnection executable" Change-Id: I4a41088f1c27cfbc1275a9c00f8c59ec60898ec2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116106 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-25configure: Add gen to VCLplugs outputJan-Marek Glogowski
And move all the output handling into a single place. Change-Id: Ia75440fc12a435b92239d7ec144be3d58e45d7d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116110 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-25Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 0251fd88ce51f96284f471ad4adbc67fd468aef9 - Python support in SF_Exception help page Change-Id: I9100e1b61aca23fbb104c449272da95bd60fd813 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115521 Tested-by: Jenkins Tested-by: Jean-Pierre Ledure <jp@ledure.be> Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2021-05-25postgres: fix internal linking with WITH_GSSAPIJan-Marek Glogowski
Change-Id: If5a741cfe5863d0cad09463ba7e958ac0f3bb24d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116108 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-25gbuild: make pre_BuildTools.mk better readableJan-Marek Glogowski
Change-Id: I6c4e35fcfaf853c83f91b505e9b6308b844c37ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116107 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-25tdf#142479 on 'return' select the entry the cursor is in before calling SelectCaolán McNamara
Change-Id: Ic11f8a12c93d1999dd6fbe555b9823660eb703d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116101 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-25Resurrect io testconnection executableStephan Bergmann
...which appears to be the only code that exercises osl's socket (rather than named pipe) connections, so lets have that available at least for manual execution. Addresses various compiler and loplugin warnings, and extends a wait time to more reliably have the MyThread instance already accept when the second accept (on the main thread) is done. Change-Id: I761d747b08ab45f1ac03dad8b4197fae63228e16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116103 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-25tdf#131390 PPTX: fix custom slide show is not imported.Tibor Nagy
Change-Id: I62e1bfaae23d1b18e71a2c16651d01144a26907c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115475 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-25gtk[3|4] reimplement ImmobilizedViewport without access to opaque GtkViewportCaolán McNamara
Change-Id: Ia7c15c57d399a05f8c94b739a2d64b1cb16735bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116091 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-25upgrade to Expat 2.4.1Caolán McNamara
drop ubsan patch in favour of fix applied as https://github.com/libexpat/libexpat/pull/398 Change-Id: I59eb9e24206b9a4cf323b7f7d48d8df0792a1c46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116092 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-25gtk4: enable some more working dialogsCaolán McNamara
Change-Id: Ia6c5137ca09629919d593f636eaebb5a28a1aa05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116095 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-25gtk[3|4] finish rename to immobilizedCaolán McNamara
Change-Id: I829ad504b791894259b94c8d015795a0dedce449 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116088 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-25fix leak in toolkit testNoel Grandin
Change-Id: I6d3aa0fca6f48145c9c3b4e7d41a486fae026f06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116099 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-25tdf#141644 OOXML shape import: fix upright text rotate angleSzabolcs Toth
Text rotate angle was not imported correctly with "upright" setting, e.g. resulting horizontal text in shapes of XLSX documents instead of vertical. Change-Id: I2ad9ba3465278220e64123c4400acff4125310d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115777 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-25tdf#142257 Replace Ctrl+[ / ] shortcuts for HungarianGabor Kelemen
Had to remove secondary keys for full effect. Those made little sense anyways. For text document this uniformly sets the Ctrl-Shift+,. too unlike Word which goes with Ctrl+Shift+8 / 9 but that's harder to reach IMHO so I chose not use that for now. Change-Id: Ib49823afcf405ed5ed4a2cf6ef4d2836f7b0747e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115772 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-25tdf#138141 sw: fix textbox z-orderAttila Bakos (NISZ)
Textboxes are implemented as loosely connected shape-text frame pairs. Missing synchronization of their z-orders resulted e.g invisible or only partially visible textbox content using Arrange options with textboxes (see in local menu or on Drawing Object Properties toolbar). Note: because it's not possible to send frames to the background, Arrange->To Background hasn't supported, so likely it's worth to remove that option later from local menu of textboxes. Change-Id: I1aa50903ba55dd5b9e72ef203c4e30218bee68fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115227 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-25tdf#118129 - return only the caption property of the frameAndreas Heinisch
Change-Id: I3dc875d54c49f233e2784dcd778c2b6fc42e59cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108958 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>