summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-12-08remove unused SvXMLTokenMapEntryNoel
Change-Id: Idc3005e5604a0c346740a81746fd35b45955afed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107371 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-08remove unused SvXMLTokenMapsNoel
Change-Id: I84a0a47e631e6bf7cfd1c745be6ed5839885861f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107370 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-08remove more no longer needed OpenGL-related codeLuboš Luňák
Change-Id: If7f47cf6dad860e4f8eab68931b72a38a7eda136 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107362 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-12-08reap glxtest process early in soffice_main unconditionallyLuboš Luňák
With the VCL OpenGL backend code removal also isVCLOpenGLEnabled() will be removed, so there won't be anything to call this. And reaching this point in soffice_main takes long enough for the call to be non-blocking, so there's no good reason to delay it anyway. Change-Id: I8f7fee3d8d53bd632672afd8e8941ee7f922f8e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107361 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-12-08Avoid calculating checksums if we can.Michael Meeks
We can compare the underlying mxImpGraphic pointers via the Graphic's uno tunnelling magic easily enough anyway. Change-Id: I09bd0fd97b662f07378197fce2956ed0776ba458 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106186 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ash@collabora.com> (cherry picked from commit a52246d5a45548820dac55395e64dc1ff83ae11f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107375 Tested-by: Jenkins
2020-12-08tdf#135329 revert sw MS export: prevent skipping at-char anchorsJustin Luth
...because Step 2 solved the problem, and I don't want to mask any future issues that miss an anchor position. This reverts LO 7.1 commit d4045509e58180768368db7a77479fc027ff7c42 tdf#135329 sw MS export: prevent skipping at-char anchors This patch is step 1 - write out bypassed flies. Step 2 - don't bypass fly positions. Change-Id: I5246ea531897de493eb050625cebcdcc2488605b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100390 Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-12-08tdf#135217 DOCX import: remove no longer needed top/bottom margin syncMiklos Vajna
Regression from commit b7ae863efeb082816cc4fe660527a9650d90e186 (tdf#117503 DOCX import: fix out of sync first/later top margin, 2018-05-28), which adjusted the import so that the export can pair first/follow page styles and write them into a single Word section. But changing the import for pairing purposes is not a good idea after all, as it also affects the layout of the imported document. In the meantime, commit 51534ac2b9747975945acb6a1e1ba5cc6d73f5c2 (tdf#127778 DOCX import: fix unexpected heading on non-first page when the first page has a heading, 2020-05-11) already fixed the export side, so this is not even necessary, just remove it. Change-Id: I94c02517ae1e0804547f81c43bb5890327d32376 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107363 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-12-08fastparser in stylesNoel Grandin
Change-Id: I39d285f1dd7dd18c396db96863f77f511741951c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107364 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-08fastparser in sc tablesNoel Grandin
Change-Id: I20bdeb490f0642208a9acea43fa5189e7a3910d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107359 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-08Update git submodulesgar Soul
* Update helpcontent2 from branch 'master' to a097662d6678263bb91b6a1dc1f5494fbf47bf38 - tdf#95147 Add note to use Optimal Height with wrapping in XLS files Change-Id: Ia7a0f3a1cdbb514f95a19cf1496b0b82bd1626cd Reviewed-on: https://gerrit.libreoffice.org/c/help/+/107308 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2020-12-08Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to fe288ef6220041285e0a76fe0b418715b63922d2 - tdf#138648 repair module-specific menu sequence for Tools>Autocorrect... ( shared/00/00000406.xhp ) * Writer uses Tools>Autocorrect>Autocorrect Options, while Calc, Draw, Impress use Tools>Autocorrect Options. Therefore add an inline switch for that sequence, plus for the four tabs used by Calc, Draw,and Impress (Options, Localized Options, Relace, and Exceptions), to give one sequence for Writer and the other sequence for the other modules. * update the modified menu sequences to <menuitem> ( shared/01/06040100.xhp ) * update to <h1> - remove irrelevant comment Change-Id: I5bdeb5bce6ceaeef2c815427918891926359a349 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/107376 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2020-12-08Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 4941e91343b1f0d78af7e79c59907bc893309685 - tdf#138714 update help page for Calc shortcut keys Change-Id: I2f99aef41ac34f8cf7fa70d1be6dd19f0bc93912 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/107313 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
2020-12-08Update git submodulesMing Hua
* Update helpcontent2 from branch 'master' to 1fee4fdda2643c941abce00b3b7cb15fa851f85c - Small formatting changes to data validity criteria page - add <keycode></keycode> tag for keyboard shortcut - use precise <emph></emph> tag for UI items, and exclude other text Change-Id: I4d80aab3b82ff2ebe6e0dec6595b9d02708f46e0 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/107213 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-12-08Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to 24db503333ae5193babbd5db33c0344ca0c5e3e1 - ScriptForge library modules - WiP + Array module + Dictionary module Change-Id: Ida2290005befb59f2b7c3699744ff49b32226e24 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/106513 Tested-by: Jenkins Tested-by: Jean-Pierre Ledure <jp@ledure.be> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-12-07Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 3e9c3e7f6da0204042ad3a1f51ec360d62919e17 - Review PDF accessibility page * eliminate e.g * ...more Change-Id: Idcad442a6c1431d867275b4d7f5bbc9d7cdcb22f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/107238 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-12-07sw: layout: SwFlyNotify should invalidate a content or tab frameMichael Stahl
The problem happens during layout for a temporary mail merge document, but that is probably incidental. (The SwRootFrame is the 2nd one out of 3 being createed, the one for the target document.) The problem is that a text frame with a fly moves backward, and ~SwFlyNotify() invalidates the position of the next frame, but the next frame is a section frame, and this does not encourage the text frame inside the section frame to move backward at a later time, which leads to general user unhappiness. So invalidate the lower of the section frame too. Change-Id: I14fa20a279979c029c468f5c6f2e5ecad4ccd240 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107360 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-12-07move various notebookbar widgets into vclCaolán McNamara
and we can drop their factories then Change-Id: I1e261886dd7700710ba628da4bbeeba65efa1531 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107134 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-07no longer need to include vcl/ctrl.hxx hereCaolán McNamara
Change-Id: I9b01eb670b9d2953bf25079ee84371c30a6dad41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107353 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-07loplugin:stringviewparam (macOS)Stephan Bergmann
Change-Id: I75344c7eda051838c015f0c4126788fd3628682f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107356 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-07loplugin:stringview (macOS)Stephan Bergmann
Change-Id: I4d52c1583a47c948eac9712710da4e71953f73cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107357 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-07remove WinGlyphCache and related codeLuboš Luňák
The code for separately rendering glyphs was used only by OpenGL code (and temporarily by Skia code). Change-Id: I8eee764045273705c108f3734b330a2237de15f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107291 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-12-07remove OpenGL VCL backend codeLuboš Luňák
It is by now practically unmaintained, even bugreports in bugzilla have been already closed for it. AFAICT this used to be really used only on Windows, where it's no longer the default. There's still some OpenGL code left, because there are still two other places that use OpenGL. One is OpenGL slideshows, which reuse some of the base OpenGL code (and I've checked they still work even after this removal). Second one is OpenGL canvas, which it seems has never been finished or enabled (or so it most probably should be dumped too). Change-Id: I7ea5aef77ec252eb8e712d167db591209be84a13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107290 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-12-07avoid possible nullptr dereferenceLuboš Luňák
Regression from cb25771fedd12725a72a1eb4f532698d8221c0f2. Change-Id: I6e00f43438882b9c96005ce921fbfd419ca634c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107358 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-12-07Fix typoAndrea Gelmini
Change-Id: Ie6559dc9691741e7daa224aa876a48b60519d469 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107314 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-12-07Fix typoAndrea Gelmini
Change-Id: I6275c21dcadb3dbdf63faaa1fd39bf9c17019f4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107292 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-12-07Fix typoAndrea Gelmini
Change-Id: I4d2955576925ef6d44b32447d953dc75bf41cf37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107293 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-12-07Fix typoAndrea Gelmini
Change-Id: I0c9b522cdbdefa8bd3698f1c1b31a963adf6c00d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107345 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-12-07Removed duplicated includesAndrea Gelmini
Change-Id: Id7eedadd7d6c4a939abca138b7dd00436182d86b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107344 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-12-07vcl graphic export: convert EMF to WMF when WMF is requestedMiklos Vajna
Regression from commit 5868745db74ae930edb0058490076d82aaeafbe9 (emfplus: make VectorFormats Emf/Wmf/Svg work, 2017-06-12), we used to export graphic data as-is when the requested format is WMF and the source format is EMF or WMF. Restrict the as-is copying to the WMF source format only. Change-Id: Iad40aee79df5ae367ae37c2fb3d5f4dfad8a40fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107355 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-12-07loplugin:unusedmethodsNoel
Change-Id: Ib51fd610c5188fe95872d509f004ae88f38c5417 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107351 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-07tdf#43003 - convert parameter to the requested typeAndreas Heinisch
In StepPARAM convert parameters to the requested type, otherwise it loses possible references which leads to an error where the results of a macro has no effect on the caller. Change-Id: I8347eab658e037a29cd04be9c00edd6a4d1b31c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107249 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-12-07loplugin:unusedfieldsNoel
Change-Id: Ia02d8359e0158c7658ac3abcaf2b6c19a3b33131 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107348 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-07loplugin:unnecessaryvirtualNoel
Change-Id: Ie9b6a588e23453aac49ba44e5c50ae70a5fb866a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107347 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-07Make SchedulerMutex non-recursiveJan-Marek Glogowski
While thinking about the "Unlock scheduler in deinit for ProcessEventsToIdle" patch, I came to the conclusion, that this mutex should actually be non-recursive. I had a look at the code and did run "make check" for my symbol build on Linux, but for the rest I'm reying on the LO CI. Maybe this can be converted to a std::mutex later. I've updated the vcl/README.scheduler and added a TODO. Change-Id: Ib9cb086af74b51e48f99ebfa1201d14db12b140e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107254 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-12-07Unlock scheduler in deinit for ProcessEventsToIdleJan-Marek Glogowski
The scheduler is normally never locked when not processing its own task lists. So while the fix is correct, that ProcessEventsToIdle shouldn't run with a locked scheduler, just unlock it in the actual shutdown case, where the deadlock occurred. This also reverts commit 46f6b39c6d8acd064bafb2416feba757ba0d0fbc. Change-Id: If1603c1563772dd1d156dc6d9bcddbf58aa721c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107241 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-12-07jsdialog: use valid window instanceSzymon Kłos
Change-Id: I3b7e98de41f56abbab1d8c15b7928089ebf8159a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107077 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107339 Tested-by: Jenkins
2020-12-07Adding suppor for &#dddd; and &#xhhhh; on fastparser.dante
Change-Id: Iacbbe8a77532fe5034ceae286f50a74310f7d2ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107036 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-07tdf#138612 DOCX import: fix lost part of split table cellLászló Németh
by removing unnecessary rewriting of cell properties during import of w:tblPrEx. Regression from commit da8ea444b004a0be36964ae9a778f73e752b2673 (tdf#133455 DOCX import: fix table border regression) Change-Id: I93ce36991437644db439c8cf02e1a8503fbdfba7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107239 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-12-07remove SID_BASIC_ENABLED and BasicEnabled optionNoel
which has never been used since creation in commit fd069bee7e57ad529c3c0974559fd2d84ec3151a Author: Jens-Heiner Rechtien <hr@openoffice.org> Date: Mon Sep 18 16:07:07 2000 +0000 initial import Change-Id: I018b1f734c8263167dab3d5c6f98a400666f01d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107047 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-07jsdialog: turn off tunneling for JSON dialogsSzymon Kłos
Change-Id: I9a9d359d1769f6c34203bc558efe8189fbf81fd3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106929 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107337 Tested-by: Jenkins
2020-12-07jsdialog: enable Pivot Table dialogsSzymon Kłos
Change-Id: Ic467c95f0d56d28e6c6590d488e2a0b10f65e803 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106997 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107338 Tested-by: Jenkins
2020-12-07SwUserFieldType: Modify no moreBjoern Michaelsen
Change-Id: I1194225011380bf63d854f8054d063e93a832744 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107322 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-12-07Sw{Get,Set}ExpFieldType: Modify no moreBjoern Michaelsen
Change-Id: Id0daf2aa04663127dcbd78d2206d81aab6a783f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107321 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-12-07SwRefPageSetFieldType: Modify no moreBjoern Michaelsen
Change-Id: I313237069eeafd5913468e18e2eb34e9ef185302 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107320 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-12-07SwAuthorityFieldType: Modify no moreBjoern Michaelsen
Change-Id: I59f1e5d25c0defa3b551061fccfeea625d0df3aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107319 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-12-07SwFormat: Modify no moreBjoern Michaelsen
Change-Id: I028e173a7148dfce946189a94aed8b93ff3539b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107318 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-12-07Revert "Fix osl_Security::getHomeDir test under fakeroot"Stephan Bergmann
This reverts commit c8098382da6a7a0448ff8051cac467f91d7e0b36. Conflicts: sal/qa/osl/security/osl_Security.cxx There should be no good reason to run unit tests like CppunitTest_sal_osl_security under fakeroot, esp. not since a58e086ededb8442938e81f971dfae36ef7eb076 "rework the default make target" no longer runs them as part of a plain `make`. (And getting rid of this code means one less place to audit for nullptr issues with getenv in combination with potential OString -> std::string_view changes.) Change-Id: I6bba0ed28ea1ba894ee182f8bda35aad69a54dc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107336 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-07sw: prefix members of SwBlockName, SwTaggedPDFHelper, ...Miklos Vajna
... SwXMLBlockListExport and SwXMLTextBlocks See tdf#94879 for motivation. Change-Id: Ifdaad455e60254f730d95ff91bc4c78b5f61bc7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107331 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-12-07remove unused sal log areas related to openglLuboš Luňák
Change-Id: I8cd870b6e22a30e0e88fcdf347a5584ada7f6950 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107289 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-12-07loplugin:stringviewparam (clang-cl)Stephan Bergmann
Change-Id: Ie29f1a5a66dd53d1e1fc9332ca4b817fa4eb43de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107332 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-11 06:29:18 +0000