summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-08-23tdf#45905 Remove/disable obsolete _XNamedRanges Java testsJens Carl
The _XNamedRanges test are already written in C++ since commit b9337e22ce1dbf2eba0e8c8db294ae99f4111f91. Change-Id: I8610cc50ce23de7183efb5d9b6b436f1b9dceae1 Reviewed-on: https://gerrit.libreoffice.org/41349 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-23tdf#45904 Remove/disable obsolete _XDataPilotTable Java testsJens Carl
The _XDataPilotTable tests are already written in C++ since commit 95780ec73990f96dc16fc677c895d00fa1360008. Change-Id: I5785a2b8edbe3166c8f81348cb36c117a4b9b736 Reviewed-on: https://gerrit.libreoffice.org/41079 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-23tdf#45904 Move Java _XAreaLink tests to C++Jens Carl
Change-Id: I95112555de3a5dd5a75c478edb5856cf79919db9 Reviewed-on: https://gerrit.libreoffice.org/40859 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-23DOCX: Fix an other test case of ActiveX control exportTamás Zolnai
When LO control is anchored to the end of the run, it is exported into a new run. Change-Id: I9269fd1b34924780aad61c452d1e2094dc8e4aad Reviewed-on: https://gerrit.libreoffice.org/41472 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-23loplugin:useuniqueptr, look for containers..Noel Grandin
that can use std::unique_ptr, and apply it in i18npool Change-Id: Ib410abaf73d5f392c7a7a9a322872b08c948f9e9 Reviewed-on: https://gerrit.libreoffice.org/41438 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-23VML, Watermark: detect shapetype from other subdocumentsSzymon Kłos
In some documents Watermark wasn't visible because shapetype wasn't detected. It was impossible to use shapetype defined in header1.xml in shape placed in the header2.xml. Change-Id: Ib406c8fc702968684ad46efd0857b768af2820f5 Reviewed-on: https://gerrit.libreoffice.org/41395 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-23Android: Enable HAVE_FEATURE_NSS and package the NSS libraries with apkGautam Prajapati
This commit enables HAVE_FEATURE_NSS for Android and fixes the svl/ vcl/ and xmlsecurity/ module to use NSS. xmlsecurity/ wasn't built for Android previously, this commit enables building xmlsecurity/ for Android and disables the support of gpgme in the same module(Only for Android). It also enables the linking of NSS shared libraries with liblo-native-code.so and adds a rule to package them along with the apk. Change-Id: I7d0341688ac979ae92e9145c37dd107670417fe1 Reviewed-on: https://gerrit.libreoffice.org/41308 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-23Clean up string constructionStephan Bergmann
Change-Id: I41ca0c7c9ac1892cc87eb4dbba858527aa340c75
2017-08-23ScFiltersTest::testUnicodeFileNameGnumeric only works with UTF-8Stephan Bergmann
Change-Id: If31062abf50125c65a90566f1276f37d6725f73c
2017-08-23libxml2: bunch of CVE fixesMichael Stahl
Change-Id: Ic786fef17cbdb574c342925a4c57875123ef3151
2017-08-23osl::Directory::createPath with excess slashes fails with E_INVAL on WindowsStephan Bergmann
Change-Id: Ic7d8a2e9bdad9a255f984116c4fdecd0e1c0d265
2017-08-23Report osl::Directory::createPath failureStephan Bergmann
Change-Id: I75ede7f03edf80c00d33281afdebc3b620fb33eb
2017-08-23Make ScBootstrapFixture::createFileURL generate properly encoded URLsStephan Bergmann
Requires the rsBaseString arg to the ScBootstrapFixture ctor to consitently be passed as a relative path without a leading slash. Change-Id: Ieff38d465b0053fdae42acc4babfb34d1a4827bd
2017-08-23drop SwBackgroundDestinationItem wrapperJochen Nitschke
other call sites just use SfxUInt16Item and overridden Clone does same as base class. Change-Id: I50acb4fbb08b3c2fdc4c7605d0ccecac0e9cc209 Reviewed-on: https://gerrit.libreoffice.org/41449 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-08-23loplugin:constparam in sc part2Noel Grandin
Change-Id: I4fd18096d7d22d8c146a2437906187d5df1cb268 Reviewed-on: https://gerrit.libreoffice.org/41447 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-23tdf#111964: only trim XML whitespaceMike Kaganski
OUString::trim() uses rtl_uString_newTrim, which relies upon rtl_ImplIsWhitespace. The latter treats as whitespaces not only characters with values less than or equal to 32, but also Unicode General Punctuation area Space and some Control characters. Thus, using OUString::trim() is incorrect when the goal is to trim XML whitespace, which is defined as one of 0x09, 0x0A, 0x0D, 0x20. The comments for OUString::trim() and rtl_uString_newTrim are corrected to describe which characters are considered whitespace. A unit test included. Change-Id: I45a132be923a52dcd5a4c35aeecb53d423b49fec Reviewed-on: https://gerrit.libreoffice.org/41444 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-08-23tdf#109184 auto cell color should be transparentSzymon Kłos
Don't add color to the property map if is set to auto. In this case white color was assumed and tables were white instead of transparent. Change-Id: I7f203b8f3831b86ba8de33dc57de227b3029c6d9 Reviewed-on: https://gerrit.libreoffice.org/41255 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2017-08-23configure: attempt to fix Android buildMichael Stahl
Can't find CONF-FOR-BUILD/donwload.lst Change-Id: Ie6bb993a2d6fcd7723b9f4437284b862eb194316
2017-08-23Don't crash if aProfileId is nullTor Lillqvist
Change-Id: I1505469200c4bcc82f07eae325882fd6454ebcc5
2017-08-23fix bug in ScTable::LastHiddenColRowNoel Grandin
found by inspection, noticed that the for loop is not actually using it's index variable introduced in commit b3579d71c6536ab1d03cc47249d582a574fd054a koheirowlimitperf: #i109369# #i109373# #i109384# #i109385# #i109386# million, and integrated lots of speed optimization and bug fixes to ensure Calc remains usable after the row limit increase. Change-Id: Icfee19ddb051e8d4333ed4c91d384379bf494444 Reviewed-on: https://gerrit.libreoffice.org/41439 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-23tdf#108943 RTF import: handle \tx inside a list level definitionMiklos Vajna
\tx in the list level definition has a different meaning (we should map it to the ListtabStopPosition UNO property), compared to when it's used as a plain text property. Change-Id: I7b98ae3d82bbd2c4ad41d0d7f4ad50525c4d0f9a Reviewed-on: https://gerrit.libreoffice.org/41442 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-23configure: try to keep PYTHON_VERSION from going staleMichael Stahl
Since it was set to 3.5.0, the bundled python was upgraded twice, but the directory is still named python-core-3.5.0 :( Change-Id: I15eec4148c2436e1f289d9851ce5bd212d4a368a Reviewed-on: https://gerrit.libreoffice.org/41433 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-23Fix WID rangesStephan Bergmann
Change-Id: I50e7f6b16d835ec86e8a98e6d94ee812391a37d4
2017-08-23Fix and enable libxmlsec build for AndroidGautam Prajapati
This commit removes the OpenSSL dependency unconditionally from external/libxmlsec/ExternalProject_xmlsec.mk. xmlsec wasn't built for Android previously but it seems like Android was the only user of xmlsec OpenSSL backend. Now we have NSS built for Android as well, so it's safe to remove the OpenSSL dependency. Change-Id: I8652487be146c3ac643c4f6dc7a6a2845093c93f Reviewed-on: https://gerrit.libreoffice.org/41288 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-23convert message box style bits to scoped enumNoel Grandin
and fix harmless bug in ImpSVGDialog::ImpSVGDialog, which there since commit 6456f1d81090dd5fe44455c09ae3ede7ec6ac38a Date: Fri Feb 4 14:52:54 2011 +0100 ka102: added/removed files for SVG import and module cleanup Change-Id: I66b2ec2b029431ab453e54e962863e4ed7d78962 Reviewed-on: https://gerrit.libreoffice.org/41412 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-23ctypeitm no more existsAndrea Gelmini
File deleted on commit 08566ea51944 Change-Id: Iccf35edc92c99779be519a4c722fa5d9bcef4b34 Reviewed-on: https://gerrit.libreoffice.org/41434 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-23Fix typosAndrea Gelmini
Change-Id: Ic78d3e15c5e58f1306f8448c0806db275b3ae616 Reviewed-on: https://gerrit.libreoffice.org/41435 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-08-23SmartArt: shape rotation supportGrzegorz Araminowicz
Change-Id: I13bfbd3fafff5335ce8bc23b2579182aa5a94a80 Reviewed-on: https://gerrit.libreoffice.org/41393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-08-23SmartArt: basic support for layout constraintsGrzegorz Araminowicz
Change-Id: Ie234bfd9760cdacb6a25c04d73a260e7e59ef7d6 Reviewed-on: https://gerrit.libreoffice.org/41273 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-08-23tdf#111844 infobar icons/text on high dpiHeiko Tietze
scaling factor added to text position Change-Id: Iaeb48fd4ac0439680fa3b6ca43f23a617efe1457 Reviewed-on: https://gerrit.libreoffice.org/41417 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-08-23tdf#111975: Inline checkbox control's label is not saved to DOC formatTamás Zolnai
This MiserableFormFieldExportHack lives from the beginning of the git history: 7155b11b7eac65e242aca1efaf29ffcfa28f2564 So it might be a workaround of an old issue. By now when the checkbox is not inline, but a floating one, it is exported as ActiveX control, which works nicely. So just remove this workaround and let the code export also inline checkboxes as ActiveX controls. Change-Id: I350b7a7595bb46334c63d9dfcf40abf9e10943bc Reviewed-on: https://gerrit.libreoffice.org/41436 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-22editeng: warning C4701 potentially uninitialized local varMichael Stahl
Change-Id: I611f0b5652722f0de38dfb82440823b832a6029c
2017-08-22unotest: really run every CppunitTest with its own user profileMichael Stahl
Apparently a sw unit test randomly read a partially written autotbl.fmt that was written by another unit test, in particular the file workdir/unittest/user/config/autotbl.fmt. The tests are actually started with -env:UserInstallation=$(call gb_Helper_make_url,$(call gb_CppunitTest_get_target,$*).user) to prevent exactly this problem, but unfortunately it's then overridden by a call to rtl::Bootstrap::set(), which overrides even command line arguments, from test::BootstrapFixtureBase::setUp(). Change-Id: I618574e94755ea38caf9583f3dcf7715396bca48 Reviewed-on: https://gerrit.libreoffice.org/41432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-22editeng: avoid infinite loop in SvxBoxItem::CreateMichael Stahl
Apparently a sw unit test randomly read a partially written autotbl.fmt and the stream has m_isEof = true. Change-Id: Iacfbc42e83be6320d4aa695a5df4264f1db0b021
2017-08-22drop unused SvxScriptTypeItemJochen Nitschke
apparently there was never a user for this item since initial commit in the year 2000. SvxScriptSetItem gets the ScriptType by parameter see GetItemOfScript and PutItemForScriptType. remove SID_ATTR_CHAR_SCRIPTTYPE and don't put the item in any set. keep the gap in the ID range because it's not part of any range and there are already other gaps. Change-Id: Iee24f13b329593af2dc5548d8b6bc2282c2dc5b3 Reviewed-on: https://gerrit.libreoffice.org/41423 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-22loplugin:constparam in sc part1Noel Grandin
Change-Id: I82fba7ebb3b4f018721642c96bbfa615c6a382c3 Reviewed-on: https://gerrit.libreoffice.org/41419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-22updater: store the updater GUI icon on linux in the codeMarkus Mohrhard
The content can be created through convert from the png version. Change-Id: Icc07a118dfa139f270232a1e708e6907ad02ddea
2017-08-22update creditsChristian Lohmaier
Change-Id: I6e6399008c62fb4feb1ddc4fef306d6c3c0cc0ca
2017-08-22updater: get the updater GUI working on LinuxMarkus Mohrhard
Change-Id: I3e7edb5319ab2e2ec316204b917a7e29c1791b5b
2017-08-22Use SfxItemSet ctor that checks WID range correctness at compile timeStephan Bergmann
Change-Id: Iea0d6334181d63f5c3eaf87df395efc158ba825e
2017-08-22Fix test assertion messageStephan Bergmann
Change-Id: Ifd9f50a68e5dd40003cd1bd32a5b806b0282ce44
2017-08-22EPUB export: initial table supportMiklos Vajna
Focusing on just not loosing plain text content, no actual formatting yet. Change-Id: Ic242f849730e1eb174f621f2235fa04563024e4e
2017-08-22EPUB export: fix validation error around as-char imagesMiklos Vajna
Matching testcase is in libepubgen.git only. Change-Id: Iee00264894099ccafb7b2d7d3252e2c7cc48ab11 Reviewed-on: https://gerrit.libreoffice.org/41427 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-22tdf#97362: TextPortionEnumerationTest partially migrated to python (part 6)jmzambon
Convert tests: - test_range_hyperlink_meta - test_range_ruby_meta - test_range_meta_hyperlink - test_range_meta_ruby - test_range_meta_meta Change-Id: I5e7adba17ad19e8c299d178fe45ed7e987b92cf0 Reviewed-on: https://gerrit.libreoffice.org/41098 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-22tdf#94882 use first page header on first pageLuke Deller
The very first page of the document should always be formatted using the "first page" settings in the page style, regardless of the page number set for that page. Change-Id: I49cb00cef8b1d10120349073dee1511657dc84d1 Reviewed-on: https://gerrit.libreoffice.org/39851 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-22Join adjacent WID rangesStephan Bergmann
...after 5a64d8b20ed74559617d2f97c3f941842b6a9ea1 "drop unused SdrCustomShapeAdjustmentItem" brought SDRATTR_TEXT_CONTOURFRAME next to SDRATTR_XMLATTRIBUTES. Stops CppunitTest_sd_dialogs_test from failing again, similar to previous 45a7f5b62d0b1b21763c1c94255ef2309ea4280b "Keep WID ranges sorted, and join adjacent ones". Change-Id: I0e93a64dd617a09872e19acd5597c5a4dd54b887
2017-08-22tdf#110355: loading options from default configVitaliy Anderson
Enable loading the "Protect Form" and "Use LibreOffice 4.3 anchoring paint order (in current document)" compatibility options from default config Change-Id: Ibb0cd4b66516a8b054974d458edf9f28a4b4743d Reviewed-on: https://gerrit.libreoffice.org/41400 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-22EPUB export: fix unexpected first chapter nameMiklos Vajna
Matching testcase is in libepubgen.git only. Change-Id: I7a6ce6a8f7deaa26a2b31ca024ff98a02a8a85f7 Reviewed-on: https://gerrit.libreoffice.org/41421 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-22tdf#110355: regression fixVitaliy Anderson
The regression from 91ccb4dbf7cbe7e684c7a8183863e597d7205e57 "Compatibility options refactoring. Part 1" patch. SvtCompatibilityOptions_Impl::SvtCompatibilityOptions_Impl() solve problem with wrong filling SvtCompatibilityEntry item fields from lValues sequence Change-Id: I695ad78bacbcce41b19b5fb90b86ff08fc041971 Reviewed-on: https://gerrit.libreoffice.org/41328 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-22OSX fix updates during resizeJan-Marek Glogowski
While resizing MacOS suspends the NSDefaultRunLoopMode. So in this caae we can't post to the system event loop, but must use timers to restart ourself. Since the timer itself is scheduled on the NSEventTrackingRunLoopMode it' also triggers on resize events. There is still some minor glitch: when resizing too fast some part of LibreOffice isn't painted, while the left mouse button is down. Since there isn't any layouting triggered by the mouse up, there has to be an other inconsistency. Change-Id: I3ccba78bd23ec8526f21e7b93b027f3d3279f901