summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-06-27OOXMLFastContextHandler: remove unused stuffMike Kaganski
Change-Id: I02cc740f2701043ca35bbbdb026cbc7f6de200bc Reviewed-on: https://gerrit.libreoffice.org/39300 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-06-27-Werror=shadow (GCC 8)Stephan Bergmann
> include/o3tl/lru_map.hxx:70:24: error: declaration of ‘iterator’ shadows a previous local [-Werror=shadow] > map_iterator_t iterator = mLruMap.find(rPair.first); > ^~~~~~~~ > include/o3tl/lru_map.hxx:61:29: note: shadowed declaration is here > typedef list_iterator_t iterator; > ^~~~~~~~ Change-Id: Ic0f8ab4609a06b713ffa6e8e9fdd04f0c42869d7
2017-06-27Using fast tokens directly:Mohammed Abdul Azeem
Replacing integer-to-integer mapped tokens with fast Tokens direcly for branching. Adding a macro XML_ELEMENT that combines namespace and element tokens. Change-Id: I8701c8af9607392843460fe726bffb6556cf9b33 Reviewed-on: https://gerrit.libreoffice.org/39275 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-06-27tdf#108814 sfx2: fix crash in sidebar when XUpdateModel not implementedMichael Stahl
com.sun.star.ui.XUpdateModel was added in 5.1 so pre-existing extensions don't implement it. (regression from 0635208edf1cdee4235ea87666a473ac81007555) Change-Id: I6749a9cf2fc82b9cd90d85a682247104e369e167
2017-06-27-Werror=catch-value= (GCC 8)Stephan Bergmann
("error: catching polymorphic type ‘class std::length_error’ by value") Change-Id: I56398642709f5f14c17b0b2928ae06d8fea0a13b
2017-06-27In OSQLParseTreeIterator::traverseCreateColumns, nLen has always been ignoredStephan Bergmann
...ever since the code's introduction with 34506a92ae2f972c9a667e1498d62e73807e8084 "INTEGRATION: CWS mozab04" Change-Id: I845a53077f16cdea6d728b9e6964a55ceea3995d
2017-06-27No reason not to use RTLFUNC hereStephan Bergmann
Change-Id: I9f01d84b4c518c178220af5cc310a3ba06bdceaa
2017-06-27xmloff: remove obnoxious ## usage from XML_NAMESPACE macrosMichael Stahl
So we can finally grep these things. Change-Id: I7ab4d0c82d8abf3fad4063321fc73772a7a6cb8d
2017-06-27xmloff: remove duplicate XML_NAMESPACE_##prefix##_IDX macrosMichael Stahl
Why do we need 2 identical constants? Change-Id: Ib969f9b9583261f26fe65e04f183bdfabcb9eefe
2017-06-27Unit test for update reference in deletion of last col/row, tdf#108788Eike Rathke
Change-Id: Ibb7a30144a1eebac3b233320c3d56c7be41cc7e3
2017-06-27Document::retrieveDefaultAttributesImpl did nothingStephan Bergmann
...ever since dac3b388798e78803a5df77894bfd30cddeb77c3 "INTEGRATION: CWS a11ysep" Change-Id: I1bba12e9f6ab69cf561a7eda010cefba91c47a49
2017-06-27tdf#108714: allow <w:br> as direct child of <w:body>Mike Kaganski
LibreOffice doesn't accept <w:br> element as a child of <w:body>. ECMA-376-1:2016 17.3.3.1 describes br as element of a run content, and points to CT_Br in §A.1. CT_Br may appear only as part of EG_RunInnerContent. In turn, EG_RunInnerContent may appear only inside CT_R. So, using <w:br> outside of <w:r> produces ill-formed OOXML. Open XML SDK 2.5 Productivity Tool for Microsoft Office confirms that, showing OpenXmlUnknownElement error. However, Word accepts it as direct child of <w:body>. It behaves as if the <w:br> were used as first element in first run of the following <w:p> (thus creating page break after next paragraph). Another Word bug that provokes third-parties to create ill-formed documents, and requires LibreOffice to be bug-to-bug compatible. This commit makes the following changes: 1. Registers a dedicated complex type CT_Br_OutOfOrder to handle those unusual breaks, with corresponding handler function. 2. In the handler function, saves the gathered property set to parser state to use later in next paragraph group handler. This reproduces Word behaviour. Change-Id: I5df6927e2de9266b58f87807319ad1c4977e45a7 Reviewed-on: https://gerrit.libreoffice.org/39168 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-06-27tdf#100075 DOCX frame height rule updatedVasily Melenchuk
According to "[MS-OE376]: Office Implementation Information for ECMA-376 Standards Support" Word treats default value for hRule attribute in a different way: if frame height is missing it is "auto" (as in specification), but if frame height exist, then default value for hRule is "atLeast". Change-Id: I0ce30b61d1a6b85febbbd8a6bf5af3eb1bb2767f Reviewed-on: https://gerrit.libreoffice.org/39065 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-06-27Sticky here means we can bail out early, tdf#108788 follow-upEike Rathke
Change-Id: I475b95321a2a49148073b7c6aeeb28b7c5b73750
2017-06-27Fix typoEike Rathke
Change-Id: Idac70b87926cfc34712a2e65923d8a035c870765
2017-06-27Resolves: tdf#108788 update references for deletions at end of sheetEike Rathke
ie. when the last column or row is included in the deletion. This seems to have never worked. Change-Id: Ic1bd1944298fe248367597177ca01e109585fcd2
2017-06-27use std::array in BlockInfoNoel Grandin
Change-Id: I28a13592e5993454ae96b0a32ba328013da7856e Reviewed-on: https://gerrit.libreoffice.org/39296 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-27Remove unused ItemProcessor argumentStephan Bergmann
Change-Id: Ie650f8c046f60a749999e1819edb5abad79e5362
2017-06-27svtools: use implicit defined copy assignmentJochen Nitschke
Change-Id: Iea061bbcf0bf6e894f1bb6028de75eb0f8e2c8f0 Reviewed-on: https://gerrit.libreoffice.org/39294 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-27basegfx: remove trivial copy ctorsJochen Nitschke
Change-Id: If6668552ec56d1b6439ead56fb2d77491a84ea13 Reviewed-on: https://gerrit.libreoffice.org/39295 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-27Fix typoAndrea Gelmini
To complete commit 3f3181522bd5fa7cd32dc81c624ef260b29cfc9c Change-Id: Ia6784899e39be6822577e3b8d5f4082ed765fd5e Reviewed-on: https://gerrit.libreoffice.org/39271 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-27Fix typosAndrea Gelmini
Change-Id: If4373f47fdf0ccfcbd490299f8b8d09e17bf92cd Reviewed-on: https://gerrit.libreoffice.org/39272 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-27PresenterPaneBorderPainter::Renderer::PaintBitmap rpBackgroundBitmap is unusedStephan Bergmann
...ever since 4d91841e0bc18d5b01fe85eb03eb0be589cf0c74 "INTEGRATION: CWS presenterscreen". (But PresenterTheme::GetBitmap is called with "Background" at least also from PresenterWindowManager::SetTheme in sdext/source/presenter/PresenterWindowManager.cxx, so that code cannot be cleaned away.) Change-Id: I2cdf96ce4d27af2d0beca51e5769fbf148973431
2017-06-27loplugin:oncevar in swNoel Grandin
Change-Id: Ia96172489eec09607113d388a5b683bb6e0d2dec Reviewed-on: https://gerrit.libreoffice.org/39290 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-27inline ElementPtrNoel Grandin
Change-Id: I93a9527283a819a95563565a252a5088253c91c0 Reviewed-on: https://gerrit.libreoffice.org/39293 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-27android, fix codemaker buildbreakerjan Iversen
Interesting android does not use --enable-java Change-Id: If834485d5a1cfcd2c6ddcd6f30dcbb61aa838dae
2017-06-27sw: fix the assertion in SwModule::Notify()Michael Stahl
This assertion (for i#116192) is actually triggered while loading fdo65932.html in CppunitTest_sw_filters_test: The perverted LoadHiddenDocument() hack in SwHTMLParser::SetControlSize() may create a view too early, before loading finishes, but this shouldn't be a problem because HTML is never a template, so move the assertion into the place where we actually modify the document directly without going via the shell. Change-Id: Ifa4b1ec4ab4142f4159daf5785cd90b5468f7e3e
2017-06-27fdo#43157 convert OSL_ASSERT to assert in sw/sourceBernhard Widl
Change-Id: Ibef2f8deb36e2123f22bd925d1360c34de0ce47b Reviewed-on: https://gerrit.libreoffice.org/39270 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-27tdf#108806: convert CRLF into space in OOXML textMike Kaganski
Change-Id: I8e2e108a705ecdb55c096a589d83d51c48b0b83c Reviewed-on: https://gerrit.libreoffice.org/39286 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-06-27iOS, first attempt to get bridges compiling.jan Iversen
Need to adapt for other iOS CPU´s Change-Id: Icb0b49265d3ec67057e57bfe5610389afe404568
2017-06-27gpg4libre: Show message when no cert manager foundSamuel Mehrbrodt
Change-Id: I0da5f20b049ab2d8c992cb2a04dcf544f0b35aa1 Reviewed-on: https://gerrit.libreoffice.org/39289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-06-27loplugin:oncevar in svxNoel Grandin
Change-Id: I22a3a13e059ac7d3479f12860564fe3eb1b55e44 Reviewed-on: https://gerrit.libreoffice.org/39282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-27gpg4libre: Add seahorse to list of certificate managersSamuel Mehrbrodt
which is the Gnome default app for ḱey management Change-Id: I4c27074f83538640fb1729c5cfddd96981d35f40 Reviewed-on: https://gerrit.libreoffice.org/39288 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-06-27tdf#108809 Message boxes: Add more descriptive window titleSamuel Mehrbrodt
E.g. 'Error' for error boxes instead of just 'LibreOffice 6.0' Change-Id: I7142d15e9219a2aa6733523887cdf43b50200b7b Reviewed-on: https://gerrit.libreoffice.org/39284 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-27PresenterPaneBase::PaintBorderBackground does nothingStephan Bergmann
...ever since 1eeb7358933afbb8d673c16c92bfd8492e8b5620 "INTEGRATION: CWS presenterscreen" Change-Id: Ibb5bf69eb3d11aa3c3b67ed0b342ca95ecf40bfe
2017-06-27tdf#108711 GPG key selection should only be possible for ODF >= 1.2 documentsSamuel Mehrbrodt
gpg4libre Change-Id: I6dbdaefddacf55c9381d156ada20cb3f25d4b3cb Reviewed-on: https://gerrit.libreoffice.org/39263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-27gpg4libre: Show error message when signing failsSamuel Mehrbrodt
Change-Id: I58f3febaaaaa225952e87ad3f092950ace37d15d Reviewed-on: https://gerrit.libreoffice.org/39283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-27Use base class to set/get super/sub scriptTamas Bunth
Looks like some obsolete code Change-Id: If600609ccd0baf3c10261cc850ac5ddc3c046401 Reviewed-on: https://gerrit.libreoffice.org/39216 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com>
2017-06-27iOS, remove java and cppunittestjan Iversen
Low level functions will not be tested Change-Id: I72fa44ea713639db97e39801a3975d6731a684c2
2017-06-27Ported bin/generate-bash-completion from Perl to PythonArkadiy Illarionov
Change-Id: Ie1b5cd0a1f64198f8e6362a02484055c5ae6b26e Reviewed-on: https://gerrit.libreoffice.org/39077 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-27loplugin:oncevar in svtoolsNoel Grandin
Change-Id: Ic97e75c81a0c00853d2f10aaf182ab476c466c86 Reviewed-on: https://gerrit.libreoffice.org/39281 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-27loplugin:oncevar in starmath..svlNoel Grandin
Change-Id: I20e3796407c7e429a88d2811673929ac1141a41c Reviewed-on: https://gerrit.libreoffice.org/39280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-27loplugin:useuniqueptr in variousNoel Grandin
extending it to find places we can use std::unique_ptr on arrays Change-Id: I9feb1d12d738d6931e752ecb6dd51cbc1540c81b Reviewed-on: https://gerrit.libreoffice.org/39255 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-27SmartArt: std::for_each -> range-based for loop.Jan Holesovsky
Change-Id: Ie2b36175a52c897bcf39da0ac2daa35979aac923 Reviewed-on: https://gerrit.libreoffice.org/39285 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-06-26SmartArt: separate LayoutAtomVisitors from LayoutAtomsGrzegorz Araminowicz
Change-Id: Ifbed15c881e4c0b987cd2fdbb903709a0b8b0e36 Reviewed-on: https://gerrit.libreoffice.org/39269 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-06-26Remove nonsense TODOSamuel Mehrbrodt
Change-Id: I97fd74c664e125f6c04f585e20c84ce702927e50 Reviewed-on: https://gerrit.libreoffice.org/39277 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-26Cleanup commentSamuel Mehrbrodt
Change-Id: I218675bcb832c158171f87bb7c52a658ceaa7a67 Reviewed-on: https://gerrit.libreoffice.org/39278 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-26Updated coreAdolfo Jayme Barrientos
Project: help bb320c4e73967aff4b1b92c46c82a5dc5bdd8d3f Expand some useless “MS” abbreviations to “Microsoft” Abbreviations should be used only when we lack space (e.g., in UI), but there’s plenty of it here Change-Id: Ib0ac97b2003ca96e4bc286a1a1436bda0f81bd8a
2017-06-26lwp: use std::array and get copy ctor for freeJochen Nitschke
Change-Id: I3c0f8cea0adca843ec88f4742243c6cdada6bc5f Reviewed-on: https://gerrit.libreoffice.org/39260 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-26assert( nStartCol + nSize <= MAXCOL+1 ); tdf#108788 prepEike Rathke
Change-Id: I647253f32bfac0460c263f662ab95ec0151bf38c