summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-10-03new loplugin:finalclassesNoel Grandin
look for classes which are effectively final, but contain protected members. These members can be made private. Change-Id: If53d535b068b668d1aff548ebfd0fe6c51a48a0e
2017-10-03Partially revert c3609f107b16eb888edf284f4637be6cb09234ebMike Kaganski
Change-Id: I92c84d0d0fba1adcd0adfc93e3fe9b5ea6b8cbf2 Reviewed-on: https://gerrit.libreoffice.org/43065 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-10-03Resolves: tdf#112827 gtk3 menubar not RTL under RTL localesCaolán McNamara
Change-Id: Icb2fa621e1f7da1e2d4bd221c8e1d8677cc956a2 Reviewed-on: https://gerrit.libreoffice.org/43057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-03tdf#112836 master view, bottom areas are wrongly positionedNoel Grandin
Bug was introduced in commit 12b2803f196b897ffb901b0eebe271c5ee43d03e "drop unused PRESOBJ_IMAGE" Change-Id: I50be74b505a674439bd8b67545b89a9660a85a33 Reviewed-on: https://gerrit.libreoffice.org/43062 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-03lok: Fix declaration of ‘xContext’ shadows a global declaration.Jan Holesovsky
Change-Id: Iab3c142cd85ca54bf3c37a0710ce7da7a5d77a35
2017-10-03tdf#112507 RTF import: fix too narrow table cellMiklos Vajna
Commit e6ec0794858df1444f43659b568119bf126a90e6 (tdf#104937 RTF import: \trwWidthA is an absolute value, 2017-08-29) changed the handling of the fake empty cell at the end of table rows so that the parameter of the control word is an absolute, not a relative value. Turns out this wasn't correct, the DOCX equivalent of that bugdoc shows that the parameter is a relative value after all. The RTF spec also talks about a "width", which is assumed to be a relative value. So fix that bug in a different way again (by making sure that this additional fake cell contributes to the total width of the table, so column separators are counted correctly), this time without less side-effects. Change-Id: Ic64fd3a6abae8e0398e8e77123f0473d73f0c4b0 Reviewed-on: https://gerrit.libreoffice.org/43063 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-03LOK: getSpellLanguages() is not necessary in comphelper in the end.Jan Holesovsky
Change-Id: If81cd3d4508ba3f44304a9ec9b643bf771e8930c
2017-10-03framework, lok: It's okay to have valid non-existent user inst. pathPranav Kant
Change-Id: I3b9f00adb76fc702e1847d9fab866b7796cfd942 Reviewed-on: https://gerrit.libreoffice.org/43061 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-03svx: Simplify SdrGluePointList with std::unique_ptrTakeshi Abe
This also inlines SdrGluePointList::GetObject(). Change-Id: I70052a5e94b3451f5a00e1185e6dee59e5537184 Reviewed-on: https://gerrit.libreoffice.org/43059 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-03new loplugin:blockblockNoel Grandin
Change-Id: I7b68b70fa4c7234e8882f7627026959a596968fd Reviewed-on: https://gerrit.libreoffice.org/43025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-03lok: use getCommandValues to obtain a list of languagesHenry Castro
Change-Id: I4a1f04b9dfe9e3ebbc174380db93c332e958ccfa Reviewed-on: https://gerrit.libreoffice.org/43060 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-10-02ofz#3537 Direct-leakCaolán McNamara
Change-Id: Icca25565d396a36154bca0ac748554e95cd83ae9 Reviewed-on: https://gerrit.libreoffice.org/43049 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-02Updated coreGabor Kelemen
Project: help aa1e7fffd4f067414833d593cd0307bd2dc9d6f9 tdf#112804 Fix key combination for inserting paragraph before table Change-Id: Ibe077bd39c5e2a44520052ae0afa9cd69ca59991 Reviewed-on: https://gerrit.libreoffice.org/43054 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-10-02Remove now moot comment about comments and .src file inclusionEike Rathke
Since RSC is gone.. Change-Id: I146e6a7284766f0462ba8099458700507d982214
2017-10-02tdf#42664 Update Navigator drop down listJim Raykowski
Change-Id: I52843868a62cb1b89fba21c4e412a52501d2dc20 Reviewed-on: https://gerrit.libreoffice.org/43007 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-10-02Remove undefined elements after std::uniqueJan-Marek Glogowski
Change-Id: Ifebd1124fa081d50797904175d90e6d26d50ab7f
2017-10-02solenv: support gb_UITest_DEBUGRUN for ui testsMiklos Vajna
This is similar to gb_JunitTest_DEBUGRUN, i.e. allows running soffice in gdb, and then connecting to that soffice from the test, instead of starting an own one. Change-Id: I023d6b0ede146837666c946cb865feb9046e5a94 Reviewed-on: https://gerrit.libreoffice.org/42756 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-02tdf#112769 Don't multi-trigger AllEventsProcessedJan-Marek Glogowski
User events processing - as all event processing - can be nested, which can cause TriggerAllUserEventsProcessed to be called multiple times, when a nested event loops ends. So track TriggerAllUserEventsProcessed calls and just reset, if a new event was inserted. Change-Id: I4a1b1b08901c99a7ece08f8baf008c8bb73506bf Reviewed-on: https://gerrit.libreoffice.org/43043 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-10-02tdf#112677 Correcting buttons position in certificate path dialognigeldias
Change-Id: I80e00083e851cd3db44a3ca9391225657526bfe4 Reviewed-on: https://gerrit.libreoffice.org/43045 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-10-02Fix typosAndrea Gelmini
Change-Id: I325141f90104496c62af8704d75568df3418952a Reviewed-on: https://gerrit.libreoffice.org/43050 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-02lok - sc: lift row limit to 500kMarco Cecchetti
Due to previously intruduced optimizations, it is safe and fast enough to navigate through a 500k rows speadsheet. Change-Id: I865d0b60629b5bbf796e9e48df6ff21242a13e5a Reviewed-on: https://gerrit.libreoffice.org/40454 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-10-02lok - sc: row/column headers are updated fasterMarco Cecchetti
Now the computation of the row/column headers data exploits the cached row/col positions in HeightHelper/WidthHelper. That makes updating row/column headers at the bottom of the document as fast as at the top even for very big spreadsheets. Change-Id: I27381b520aaed68662e4d07c5879046d182c70e6 Reviewed-on: https://gerrit.libreoffice.org/40451 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-10-02lok - sc: make computation of cell cursor position fasterMarco Cecchetti
Now the computation of the cell cursor position exploits the cached row/col positions in HeightHelper/WidthHelper. That makes navigating through arrow keys independent from the current cell cursor position: the cell cursor position is updated at the bottom of the document as fast as at the top even for very big spreadsheets. Change-Id: I2f23d4439f2157e702f09b56106bebdd0e0bbe86 Reviewed-on: https://gerrit.libreoffice.org/40450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-10-02lok - sc: invalidation of cached row/col positions on several casesMarco Cecchetti
Cached row positions are invalidated when one of the following event occurs: - one or more rows are inserted - one or more rows are deleted - one or more hidden rows are made visible - one or more visible rows are made hidden - one row is resized - optimal row height is changed - the value of the PPTY parameter is updated - a undo/redo involving any of the above actions The same occurs for cached column positions. The solution takes care of row/column operations performed in another view and of the current tab each view is displaying Change-Id: I57895506b17986d36ab024eec9c79864ea95dad7 Reviewed-on: https://gerrit.libreoffice.org/40449 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-10-02lok - sc: document size as sum of row heights/col widths in pixelMarco Cecchetti
Grid lines, cursor overlay, row/col headers are all computed by summing up row heights / col widths converted to pixels. On the contrary the document size was converted to pixel only at the end after having summed up heights/widths in twips. All that lead to have a document height/width greater than the position of the last row/col, with the scrolling in online going unplesantly far beyond the last row/column. This patch change the way the document size is computed, so that the spreadsheet height/width matches the position of the last row/column. Moreover it exploits the cache-like structure for row/col positions introduced in a previous commit. Change-Id: Ibb2cc6a7b592e359a0b1202dc9bea1dd4c421354 Reviewed-on: https://gerrit.libreoffice.org/40448 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-10-02lok - sc: a cache-like structure for row/col positions in the documentMarco Cecchetti
ScPositionHelper provides the ability to insert (and remove) row- position pairs where the position is in pixel and related to the spreadsheet top. In this way one can compute a new row position by starting from the nearest row presents in this cache-like data structure. It offers also the ability to invalidate the cache by removing all cached data below a given row or position. This data structure can be used for columns, too. Change-Id: Ifd66a003680ef9a3babf46ae952221c04451be9a Reviewed-on: https://gerrit.libreoffice.org/40447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-10-02lok: sc: overlays and edit view misplaced by other view actionsMarco Cecchetti
The edit view, the cell cursor and the cell selection overlays become misplaced when another user inserts, deletes or resizes a row. The same is true for columns. The solution takes care of the current tab each view is displaying and of undo/redo actions. Change-Id: I24c94f774f3b18028c9356a904e1b14b07c5c61a Reviewed-on: https://gerrit.libreoffice.org/40016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-10-02Removed duplicated includesAndrea Gelmini
Change-Id: I2f2c31e3605c1bff353b5749c593305c3fc7028f Reviewed-on: https://gerrit.libreoffice.org/43044 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-02Add unit tests for ISO 8601 date+time inputEike Rathke
Change-Id: Iab53f39313c1bac04fe5718823455e5ef0e52f13
2017-10-02Number scanner: accept fractional seconds in ISO 8601 also for ',' commaEike Rathke
... if comma is the group separator (or some other separator). Strictly only if 'T' separator was encountered. Change-Id: I4df55235a6a416f0719752dfcde659d846ac208e
2017-10-02Related: tdf#112395 disabled slot with Put leaks entryCaolán McNamara
Change-Id: I326424551c280140db03b4c92ef450cc04f18813 Reviewed-on: https://gerrit.libreoffice.org/43040 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-02WIN handle timer Impl* access via friend functionJan-Marek Glogowski
Not sure if this is the better approach, but this gives the application window dispatch function access to the now private timer implementation, so nobody else can call them. Change-Id: Ic361d2c93116fbd6c85b20f7da3cffbd538b3558 Reviewed-on: https://gerrit.libreoffice.org/43041 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-10-02Translate German variable names in Calc (financial)Johnny_M
These names of variables correspond to German function names in Calc and were translated to their English equivalents. For used translations, see, e.g., https://translations.documentfoundation.org/de/libo54_help/translate/#search=kapz&sfields=target Change-Id: I5c0e4232b2e7b3039a42aff96a44a8f55c818d2e Reviewed-on: https://gerrit.libreoffice.org/42993 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-10-02Translate German variable names in Calc (financial)Johnny_M
These names of variables correspond to German function names in Calc and were translated to their English equivalents. For used translations, see, e.g., https://translations.documentfoundation.org/de/libo54_help/translate/#search=kapz&sfields=target Change-Id: Ifffa1ae8394cafde6dd7a78626b957e07919d5c9 Reviewed-on: https://gerrit.libreoffice.org/42991 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-10-02Resolves: tdf#112780 no ResetDirty() after SetHybridEmptyDisplayedAsString()Eike Rathke
Change-Id: Idea5c1bd8e8577eaf90fc47d39f88c79963c422b
2017-10-02consistently apply std::unique_ptr to SvLBoxButtonDataCaolán McNamara
Change-Id: I307c9095aa562348ce1b9338203995d9d62eebb4 Reviewed-on: https://gerrit.libreoffice.org/43037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-02TSCP: remove classification fields before editingAshod Nakashian
Change-Id: If6f66a03c5c97ec87931944147d64b3f6de1ef03 Reviewed-on: https://gerrit.libreoffice.org/43021 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-10-02TSCP: edit paragraph classificationAshod Nakashian
Change-Id: Ib60a22fefe3464e29427a3d82b3af0926375433b Reviewed-on: https://gerrit.libreoffice.org/43020 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-10-02TSCP: simplify ApplyParagraphClassificationAshod Nakashian
Change-Id: I67f9d173526d785bfbb2c09526f915aa7c6216eb Reviewed-on: https://gerrit.libreoffice.org/43019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-10-02TSCP: refactor RDF reading for metadata fieldsAshod Nakashian
Change-Id: Ia24500f490d24e28446057bd840d8e6084bf3336 Reviewed-on: https://gerrit.libreoffice.org/43018 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-10-02TSCP: paragraph classification supportAshod Nakashian
Change-Id: Ia547e7c68076596d9765a1bad96fd76bd7fa7386 Reviewed-on: https://gerrit.libreoffice.org/43017 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-10-02sw: prefix members of SwFormatRubyMiklos Vajna
Change-Id: I47ca2fa39f93ebb665ccc6b4640238d2686dc0fc Reviewed-on: https://gerrit.libreoffice.org/43026 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-10-02Number scanner: accept fractional separators in an ISO 8601 date+time stringEike Rathke
In a strict ISO 8601 date+time string with 'T' separator the Time100SecSep separating seconds and fractional seconds can be either '.' period or ',' comma, so accept those in all locales. Not accepting '.' in all locales was the cause of tdf#100822 before code was changed to use sax::Converter::parseDateTime() instead. Change-Id: Ica676050b52b11da64afbac6feabb43d9e985bc4
2017-10-02Tone down excessive directional chars in Back/Next buttonsAdolfo Jayme Barrientos
This tiny inconsistency with other software has annoyed me for too long. Change-Id: Ieef8cdcf13f1cea0e414fbe086e45a4e05895467
2017-10-02coverity#1418672 silence Explicit null derefCaolán McNamara
Change-Id: I9c39da02a344316b09c190a3c12bdb17201cf176 Reviewed-on: https://gerrit.libreoffice.org/43027 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-02Bin duplicated forward declarationTor Lillqvist
Change-Id: Id5fda192de625c5fdfd6f9dce3ebcd68e06f1c7a
2017-10-02tdf#44497 run LicenseDialog with SolarMutex lockedJan-Marek Glogowski
Before commit 3840aede596e6fc24f7ed7df9100fb028134aac6 releasing an unlocked SolarMutex was simply ignored, but now it aborts. So run the LicenseDialog GUI code holding the SolarMutex, as required. Change-Id: Id9f5f6146cdfe2b21b68a2cdffc9dd4a527b551c Reviewed-on: https://gerrit.libreoffice.org/42951 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-10-02lokdialog: Add dialog APIs to lok::Document classPranav Kant
Change-Id: I1947dc84c91e2e01072fbff3e97aa94d514ecb5a
2017-10-02lokdialog: Smoother mouse move on floating windowsPranav Kant
Do away with an early hack to create the floating window with every invalidate. This gets rid of persistent blinking when moving the mouse over a listbox, for example. Change-Id: Ida9367156605edc9835529f83529363ad97beaee
2017-10-02lokdialog: button press type debug infoPranav Kant
Change-Id: I193e0ab82e998905b670f7de73daae784de3ef00
generated by cgit (git 2.34.1) at 2025-02-08 12:06:26 +0000