summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-03-02sw: convert DELETEZ to unique_ptr in paintfrm.cxxMichael Stahl
This will now delete these globals on shutdown, hopefully it's only relatively primitive types... Change-Id: Ib7a4bb4507da500e1eb1bb69876bb6d670d99cd4 Reviewed-on: https://gerrit.libreoffice.org/50624 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-02forcepoint #17 nTextBreak is an index into pKernArray of len rInf.GetLen()Caolán McNamara
Change-Id: I3afeaf987cc5e75362560165fea7230904530933 Reviewed-on: https://gerrit.libreoffice.org/50628 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-02Blind build fix for AndroidStephan Bergmann
Change-Id: Ic1ad524d533d3e27d59dacc3f1233de3e4e3e0dc
2018-03-02Related: tdf#114555 cater for lastcolumn+1 oddity if last is last possibleEike Rathke
Else our own saved .xlsx files raise the excess columns warning. Change-Id: Ie1791dd026d9faf4b391ad34da43ec0c70c8de83
2018-03-02related forcepoint #18, reconcile GetPrevCellLeaf with GetNextCellLeafCaolán McNamara
Change-Id: I8998956676ba146cac6f8339a3f5c550f0aabc2e Reviewed-on: https://gerrit.libreoffice.org/50634 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-02ofz#6656 -1 isn't a good flag for all elements filledCaolán McNamara
Change-Id: I163de8fd943859fbf986da0928f3e3552d063a09 Reviewed-on: https://gerrit.libreoffice.org/50622 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-02lxml: Do not build on systems without python dev headersSamuel Thibault
Building our internal lxml requires python development headers, which we don't otherwise need if runtime python support is not enabled. We should also not build it when cross-compiling since we only need it on the build system. Change-Id: I63df25ff9f5932ca537dbbd6937b78d153c11d66 Reviewed-on: https://gerrit.libreoffice.org/50560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-03-02forcepoint #15 notify FormatsContext if Format deletedCaolán McNamara
Change-Id: Icb7b0c3b1fc3d38e2d7e44e0a8bdb03529c5b41d Reviewed-on: https://gerrit.libreoffice.org/50621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-02More sc files relying on float-divide-by-zero resulting in infStephan Bergmann
...triggering -fsanitize=float-divide-by-zero during e.g. CppunitTest_sc_statistical_functions_test. (Found only now after I removed -fno-sanitize-recover=ALL -fsanitize-recover=float-divide-by-zero from CXX and instead added halt_on_error=1 to UBSAN_OPTIONS.) Change-Id: Iead2147e42af33b987edb8e10804bc4eefa1aeca Reviewed-on: https://gerrit.libreoffice.org/50637 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-02Updated coreAndrea Gelmini
Project: help fc5a433b247927c4b134d7d6028c68837e3e003d Fix typo Change-Id: I03ac8de6528ed33d07fe91e52f50964eb7b74b0d Reviewed-on: https://gerrit.libreoffice.org/50478 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2018-03-02Restrict UITest SAL_LOG_FILE hack to WindowsStephan Bergmann
...where it appears to be necessary, as the subprocess.Popen in uitest/libreoffice/connection.py apparently doesn't manage to make the spawned soffice process send stdout/-err output to the python process's stdout/-err (as works fine e.g. on Linux). (Only using that hack on Windows has the advantage that on other platforms output from the python and the soffice process will be properly interspersed. On Windows, at least sal/log.hxx messages from the soffice process are captured that way, while its stdout/-err output is still lost.) Also dump the soffice.out.log content in case of failure. (Note that, despite the file's name, it contains any sal/log.hxx messages from both the python and the soffice process.) Change-Id: Ic99a62b1abbe2fbbf98128a35203e2fd05335266 Reviewed-on: https://gerrit.libreoffice.org/50620 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-02Adapt configure.ac to more ways of making UBSan errors fatalStephan Bergmann
Change-Id: I095ef821b7ab80527d36a32394b34c56c7e2190a Reviewed-on: https://gerrit.libreoffice.org/50615 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-02Make SAL_LOG_FILE work on Windows also without logging.iniStephan Bergmann
...as used by solenv/gbuild/UITest.mk Change-Id: Iefc1c1dc2f775c6872a5075a16e049f00d60273a Reviewed-on: https://gerrit.libreoffice.org/50618 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-02iOS, added same limitations as MACOSXjan Iversen
Change-Id: Ic8490fcea37221f580734e7764e90bb21c9cc28f
2018-03-02tdf#35301 xmloff: load / store loext:ruby-position.Mark Hung
Add a new property loext:ruby-position to ODF filter for the new attribute value "inter-character". Change-Id: I193eb93fba0e2e7861b6c8635244cac36eb29a06 Reviewed-on: https://gerrit.libreoffice.org/48328 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-03-02lo chart2: The LokChartHelper must post the mouse events too.Jan Holesovsky
Calling directly causes freezes in Execute() when instantiating dialogs. Change-Id: I3aa09b99e5a13027892aeba02860e87e29b172da Reviewed-on: https://gerrit.libreoffice.org/50419 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/50483 Tested-by: Jenkins <ci@libreoffice.org>
2018-03-02lok - chart - state switch issue triggers an OLE general error msg boxMarco Cecchetti
Change-Id: I6addd95d1ad3461b6e21328512cbd1301a36cd19 Reviewed-on: https://gerrit.libreoffice.org/50368 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/50482 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2018-03-02lok: Re-introduce the cancellation of tracking.Jan Holesovsky
Without this, the charts tend to crash on double-click. This kind of reverts commit 86ea687d3f19c04192ee2b7a82736e110c7be334. Change-Id: I462e4beec71008a0abe29ec0bb570c8a35c82a7f Reviewed-on: https://gerrit.libreoffice.org/50408 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/50481 Tested-by: Jenkins <ci@libreoffice.org>
2018-03-02Disable -fsanitize=float-divide-by-zero in rtl_math_atanhStephan Bergmann
...which relies on division by zero producing inf, for atanh(1) = inf. (As tested by CppunitTest_sal_rtl.) Change-Id: I0e5de8850ab4cbd05f83027c1eb548e2e0c9a9b2 Reviewed-on: https://gerrit.libreoffice.org/50613 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-02use more Color in ExtendedColorConfigValue and reportdesignNoel Grandin
Change-Id: I710407ccdd373ba686914e1d049bd8c2bcdcd1e3 Reviewed-on: https://gerrit.libreoffice.org/50576 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-02fix fuzzer buildCaolán McNamara
Change-Id: I24c7e32b3dc63f3b5043e186f6af0ffa4d310198
2018-03-02use more Color in HexColorControlNoel Grandin
Change-Id: I889fa9f2a8711e95f24336718e35d11d0945dec1 Reviewed-on: https://gerrit.libreoffice.org/50573 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-02use more Color in SfxWatermarkItemNoel Grandin
Change-Id: Ifbbce6509c02cf3d93d0500104af7c07c3216266 Reviewed-on: https://gerrit.libreoffice.org/50577 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-02tdf#115429 sax,xmloff: assert on empty attribute names & namespacesMichael Stahl
Surely that's indication of a bug somewhere. Change-Id: Ic6219d8eb7f22301d8c4da98b2132ae3ef0467b5 Reviewed-on: https://gerrit.libreoffice.org/50579 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-02forcepoint #12 top empty stackCaolán McNamara
Change-Id: I51f02be13b3cf69e9aaef644a6c4837f1c47ff62 Reviewed-on: https://gerrit.libreoffice.org/50602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-02forcepoint #13 null derefCaolán McNamara
Change-Id: I248316ff3a3df513b8b1d9a8f86ac48d4dc75bb0 Reviewed-on: https://gerrit.libreoffice.org/50603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-02Resolves: tdf#115746 alt+f used twice in the writer menubarCaolán McNamara
Change-Id: I7d1589dbb51072aa328d91c0edee410fc69f2fe8 Reviewed-on: https://gerrit.libreoffice.org/50591 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-02forcepoint #14 check to see if we incremented at allCaolán McNamara
Change-Id: Ia4670adbddcc8501cf522be296b3061a3529f880 Reviewed-on: https://gerrit.libreoffice.org/50605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-02gla11y: do not trigger lxml externalpackage build when system-providedSamuel Thibault
if there was no other external package built already, even just touching lxml.done would fail. Change-Id: I8b3ad63477421d797f2d6eb07b88c86041a5a1af Reviewed-on: https://gerrit.libreoffice.org/50614 Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org>
2018-03-02tdf#116070: Use a valid PaM when confirming the dialog.Jan Holesovsky
Change-Id: I8d45e709e6414814b3cf04bbd09588ab4e096e8c Reviewed-on: https://gerrit.libreoffice.org/50598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-03-02delete colordata.hxxNoel Grandin
move what we still need into color.hxx Change-Id: Ied7e31eb16468aa334c666b1499a6262f16a6350 Reviewed-on: https://gerrit.libreoffice.org/50561 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-02add Color method version of OORGBToXLRGBNoel Grandin
Change-Id: I769ff8aed3caa74679e1b4d03e8fbc3cd5d22b1a Reviewed-on: https://gerrit.libreoffice.org/50587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-02sw HTML export: XHTML ns alias for table markupMiklos Vajna
This was forgotten from the previous mass-conversion of adding namespace aliases to written elements. Change-Id: Id9b7e961c941ec3b3614e3694963c3f9ef9e46eb Reviewed-on: https://gerrit.libreoffice.org/50595 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-02xmlsecurity: create XMLElementWrapper instances with a constructorMiklos Vajna
Change-Id: I0fe7d0a21b0ea35b537466316a637a0a46c52fe5 Reviewed-on: https://gerrit.libreoffice.org/50601 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-02drop old tools/gen methods in vclNoel Grandin
Change-Id: I863ce5ae46ae90f06780261fa17b087a7153c807 Reviewed-on: https://gerrit.libreoffice.org/50445 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-02gbuild-to-json: unblacklist shellMike Kaganski
Change-Id: I42f8a69c5deba1f83f6203f19e5f2fcfad837dea Reviewed-on: https://gerrit.libreoffice.org/50597 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-02Add a new test case for Excel 2003 XML import.Kohei Yoshida
Change-Id: I1ba74f35e44b9cea3e3770d513ae520da02b3406 Reviewed-on: https://gerrit.libreoffice.org/50610 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-03-01Related: tdf#54197 copy AutoSpellData from adjacent if no selectionEike Rathke
Change-Id: I82223a64f5c5ec3c98dba390d88af8369a322bd7
2018-03-01Related: tdf#115297 copy AutoSpellData from row above if no selectionEike Rathke
Change-Id: I62ebb3579d5c05e71ca10879ae0ade5bda3bbeba
2018-03-01Resolves: tdf#54197 update input line with new cell content after Ctrl+D fillEike Rathke
... and invalidate cell slots. Change-Id: Icbe7784430f7ddeed8fa0bc56352269447ee8cbb
2018-03-01tdf#116086 Apparmor profiles fixes for xslm file extensionOlivier Tilloy
This allows opening files with the xlsm and xltm extensions (Excel macro-enabled workbooks and templates). Change-Id: I9282f83ff15108a703b98f1752eeee94a2f174c1 Reviewed-on: https://gerrit.libreoffice.org/50514 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-03-01weld insert row/column dialogCaolán McNamara
Change-Id: Ib035e4ea18e65558e6b7cd7d7ebb643f68241ead Reviewed-on: https://gerrit.libreoffice.org/50594 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-01ofz#6639 Null-dereferenceCaolán McNamara
Change-Id: I55c3de55678066895c38c247fa440143e7733ba2
2018-03-01hook up extended tips to find them in our helpCaolán McNamara
Change-Id: I1360403b3b21eec3fd37bb5ba74e0fab1945af94 Reviewed-on: https://gerrit.libreoffice.org/50590 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-01ofz#6640 avoid recurse to deathCaolán McNamara
Change-Id: Ia798636a5b4013753a268fff68915ec56c384e5f
2018-03-01weld autoformat dialogCaolán McNamara
Change-Id: I93af2393d103d882d08b74e1e5a98b601ebd29dc Reviewed-on: https://gerrit.libreoffice.org/50586 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-01hook up gettext to native dialogCaolán McNamara
Change-Id: Ie5ca8882c8e4c41a8ee41379edc37c4c07e18033 Reviewed-on: https://gerrit.libreoffice.org/50581 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-01ofz#6625 just don't care about exceptions during fuzzingCaolán McNamara
Change-Id: I41cc7491529d2486d96cb3893e6a3b4e5713d078 Reviewed-on: https://gerrit.libreoffice.org/50585 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-01tdf#115429 sax: assert if exporting an invalid XML attribute/elementMichael Stahl
Add a cheap check for this in both SaxWriter and FastSaxSerializer so we can find such bugs earlier, e.g. with the weekly crashtesting. Don't do a correct check but a cheap & fast one, let's ignore non-ASCII characters for now as the only filter with such is UOF and that is implemented with XSLT, not this sax code. Change-Id: I4db8f70ffb23684d4cb4211468519edd6c7c465f Reviewed-on: https://gerrit.libreoffice.org/50507 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-01tdf#115429 xmloff: ODF import: fix handling of unknown attributesMichael Stahl
... in SvXMLLegacyToFastDocHandler::startElement(), so that it does not create invalid "-1" tokens that end up stored as empty-string attribute names in SvXMLAttrCollection and ultimately exported as invalid XML. The maName in struct UnknownAttribute actually stores a QName, i.e. namespace-prefixed, since commit bb59a80ee6000d3922fa95262f67e291fd9d8ee2. The attributes are read and converted again in SvXMLImportContext::startUnknownElement(). Change-Id: Ia69a4da293f1a84ce30766abc09ca19e2620edbd Reviewed-on: https://gerrit.libreoffice.org/50580 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>