summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-02-14base section Titles are invisible in dark modeCaolán McNamara
Change-Id: I46848169f9376588e91d9684e47f388074c41493 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146997 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-14Resolves: tdf#149482 don't insert if the mouse is not still pressedCaolán McNamara
In repeat callback, if we didn't see a mouse up, but find that the mouse is no longer pressed at this point, then bail Change-Id: I6e5d1d7201065fadcc2242fd52323ffb56766383 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146947 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-14fix locking in PersistentPropertySetNoel Grandin
after commit 756185b5795c95180d32d02abfbd65951779b40e Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Mon Feb 13 09:06:02 2023 +0200 osl::Mutex->std::mutex in PersistentPropertySet Change-Id: Ie52432ea1566b840bd88692f00f4753eea7896f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146998 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-14tdf#149786 sc: add VBA function: ExportAsFixedFormatBalazs Varga
Add ExportAsFixedFormat VBA function for calc. Works fine with Workbook/Worksheet/Range objects Optional parameters: - Type: works but only with xlTypePDF. (xlTypeXPS not supperted by LO) - FileName: works but not clear the xlQualityStandard or xlQualityMinimum real value, so just used the lossless export in case of xlQualityStandard and 70% JPEG compression quality for xlQualityMinimum. - IncludeDocProperties: works - IgnorePrintAreas: TODO - From: works - To: works - OpenAfterPublish: works - FixedFormatExtClassPtr: TODO? Change-Id: I128fd880a82a5dd315897496c6f21bb9a7c2270b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146512 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-02-14tdf#134283: MakeSetList should iterate Setters, not GettersBjoern Michaelsen
Change-Id: I811a3b562ead942c98705da29774b77c593eabc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146828 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-02-14osl::Mutex->std::mutex in OpCodeMapDataNoel Grandin
Change-Id: I0b92e2a94060549c39df7d08a6409518252fc757 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146970 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-14sw floattable: improve handling of split flys in SwTextFrame::FormatEmpty()Miklos Vajna
The bugdoc had a non-empty paragraph after the floating table, we painted that text on both page 1 and page 2, while only page 2 is expected. We want that paragraph to be on both pages, but we want to split it before the first char, so apart from providing a place to serve as an anchor, it should be invisible on page 1. Fix the problem by extending SwTextFrame::FormatEmpty() to consider the master anchor text frame as empty in case it has no text, just intersects with a fly frame. Also improve SwTextFrame::HasNonLastSplitFlyDrawObj() a bit, so it returns early when the own and the follow offset is not the same. These are cheap checks and some callers already did it before iterating over all the draw objects of the text frame, but other callers didn't do this. Now we check for this consistently, everywhere. Change-Id: I4b399ae3f9e9f364c61d977359f6c9b16c648629 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146969 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-02-14tdf#153332 reset background to default if new preview has no bgCaolán McNamara
but the old did Change-Id: I59ebd4d5974c5d67c4ac572b091febed879fc290 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146948 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-14UBSan needs SwFlowFrame RTTI to be public nowStephan Bergmann
...for CppunitTest_sw_core_layout_flycnt newly introduced in 995198bfff4ae8abaf2129fe99d9f8ef899a4f25 "sw floattable: handle table-in-fly in SwFrame::GetNextFlyLeaf()" Change-Id: If006a912d365642181b0bc80dc21c55d42214e87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146967 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-14sw: document SwAuthorityFieldMiklos Vajna
Its invariant was already documented, but it wasn't mentioned that the UI's bibliography entry is called an authority field internally. Change-Id: I55a946a5bdb59e8d6e1def54b16d0c986e531c34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146942 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-02-14osl::Mutex->std::mutex in LoadEnvListenerNoel Grandin
Change-Id: If76feb51f0d2f187603fb1af7c27bbe3391b645b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146944 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-14osl::Mutex->std::mutex in ConfigurationAccess_UICommandNoel Grandin
Change-Id: Id92161815cd1f336c030aa4491e67a84aaddeb87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146943 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-14--enable-qt6 constexpr template point of instantiation issueStephan Bergmann
...with --with-latest-c++, > In file included from vcl/qt6/QtMenu.cxx:10: > In file included from vcl/qt6/../qt5/QtMenu.cxx:10: > In file included from vcl/inc/qt6/QtMenu.hxx:10: > In file included from vcl/inc/qt6/../qt5/QtMenu.hxx:12: > In file included from vcl/inc/salmenu.hxx:24: > In file included from include/vcl/menu.hxx:23: > In file included from ~/llvm/inst/bin/../include/c++/v1/memory:898: > In file included from ~/llvm/inst/bin/../include/c++/v1/__memory/shared_ptr.h:31: > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:63:19: error: invalid application of 'sizeof' to an incomplete type 'QMenu' > static_assert(sizeof(_Tp) >= 0, "cannot delete an incomplete type"); > ^~~~~~~~~~~ > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:297:7: note: in instantiation of member function 'std::default_delete<QMenu>::operator()' requested here > __ptr_.second()(__tmp); > ^ > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:263:75: note: in instantiation of member function 'std::unique_ptr<QMenu>::reset' requested here > _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); } > ^ > vcl/inc/qt6/../qt5/QtMenu.hxx:40:7: note: in instantiation of member function 'std::unique_ptr<QMenu>::~unique_ptr' requested here > class QtMenu : public QObject, public SalMenu > ^ > /usr/include/qt6/QtCore/qmetatype.h:2331:47: note: in implicit destructor for 'QtMenu' first required here > reinterpret_cast<S *>(addr)->~S(); > ^ > /usr/include/qt6/QtCore/qmetatype.h:2370:41: note: in instantiation of member function 'QtPrivate::QMetaTypeForType<QtMenu>::getDtor' requested here > /*.dtor=*/ QMetaTypeForType<T>::getDtor(), > ^ > /usr/include/qt6/QtCore/qmetatype.h:2480:48: note: in instantiation of static data member 'QtPrivate::QMetaTypeInterfaceWrapper<QtMenu>::metaType' requested here > return &QMetaTypeInterfaceWrapper<Ty>::metaType; > ^ > /usr/include/qt6/QtCore/qmetatype.h:2537:16: note: in instantiation of function template specialization 'QtPrivate::qTryMetaTypeInterfaceForType<(anonymous namespace)::qt_meta_stringdata_QtMenu_t, QtPrivate::TypeAndForceComplete<QtMenu, std::integral_constant<bool, true>>>' requested here > QtPrivate::qTryMetaTypeInterfaceForType<Unique, T>()... > ^ > workdir/CustomTarget/vcl/qt6/QtMenu.moc:106:5: note: in instantiation of variable template specialization 'qt_incomplete_metaTypeArray<(anonymous namespace)::qt_meta_stringdata_QtMenu_t, QtPrivate::TypeAndForceComplete<QtMenu, std::integral_constant<bool, true>>, QtPrivate::TypeAndForceComplete<void, std::integral_constant<bool, false>>, QtPrivate::TypeAndForceComplete<QtMenuItem *, std::integral_constant<bool, false>>, QtPrivate::TypeAndForceComplete<void, std::integral_constant<bool, false>>, QtPrivate::TypeAndForceComplete<QtMenuItem *, std::integral_constant<bool, false>>, QtPrivate::TypeAndForceComplete<void, std::integral_constant<bool, false>>, QtPrivate::TypeAndForceComplete<QtMenuItem *, std::integral_constant<bool, false>>, QtPrivate::TypeAndForceComplete<void, std::integral_constant<bool, false>>, QtPrivate::TypeAndForceComplete<void, std::integral_constant<bool, false>>, QtPrivate::TypeAndForceComplete<QAbstractButton *, std::integral_constant<bool, false>>>' requested here > qt_incomplete_metaTypeArray<qt_meta_stringdata_QtMenu_t, > ^ > vcl/inc/qt6/../qt5/QtMenu.hxx:23:7: note: forward declaration of 'QMenu' > class QMenu; > ^ Change-Id: I4b4a227411c380e97d4c357708009c5905cef44a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146949 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-14Simplify code a bitStephan Bergmann
("instantiation of XSLT 2.0 transformer service failed" would mean that it throws an exception, not that xTransformer would be null) Change-Id: I8994c4b8d1c7ade8d5c7ef93569315d45fc7265d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146950 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-14Remove an unhelpful try/catchStephan Bergmann
The theMacroExpander operations should never throw, so better leave uncaught any exceptions that would happen after all, rather than silently swallowing them. Change-Id: Ic5160a69e7cd7412c91ae3589b3dc89f6fe4c43b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146951 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-14tdf#153604: include the root element when traversing the treeKohei Yoshida
Change-Id: I35098e687eea832c075f68861e04be7b492ed25e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146966 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2023-02-14tdf#153592 writerfilter: don't defer breaks into shapes/commentsJustin Luth
When starting a pargraph, we already had a clause to avoid deferring page and column breaks when we were in a shape or a comment. These clauses are also necessary in the other sections of the code where we defer these breaks. The provided test proves the two shape cases in lcl_utext. I just took IsInComments along for the ride, as it certainly would apply in that case as well. make CppunitTest_sw_ooxmlexport18 CPPUNIT_TEST_NAME=testTdf153592_columnBreaks ooxmlexport4's testTdf81345_045Original proves that it is also needed in lcl_text. However, it is such a complex document that I wasn't confident that a unit test would be stable enough. Change-Id: I2de15341d3e756bf47fcd85b868a849c8a2419cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146939 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-02-13Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to cd49917023bc58662fa1c6be7294f66955f04525 - Rename Extension Manager to Extensions Follow-up to core commit ef3c81d0fca9c8f80fd0d4e4025c37a114528344 Change-Id: I904f88bd184fb4ea10eb050c21d40041494e2e33 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146952 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-02-13osl::Mutex->std::mutex in ContentResultSetWrapperNoel Grandin
Change-Id: I8d015bf1435c6b3becd40ffd9056b9906a6dd19b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146938 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-13osl::Mutex->std::mutex in DynamicResultSetWrapperNoel Grandin
Change-Id: I218460fac22e65f583a545d41720b0301b67c502 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146937 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-13Fix typoAndrea Gelmini
Change-Id: I587c742957da0bb40ff858180f27b62549ebadbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146912 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-02-13tdf#152605 (tdf#137968) "heading level" -> "outline level"Seth Chaiklin
Reformulate error messages for headings whose outline levels are not in sequence. UX cleanup: Add missing periods to error messages. Change-Id: I62b8f7af79460b644fae20dd521a160907605b76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146807 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-02-13Fix the buildStephan Bergmann
...after 756185b5795c95180d32d02abfbd65951779b40e "osl::Mutex->std::mutex in PersistentPropertySet" caused > ucb/source/core/ucbstore.cxx:1913:75: error: too few arguments to function call, expected 2, have 1 > m_pPropertyChangeListeners->getContainer( rEvent.PropertyName ); > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ > include/comphelper/multiinterfacecontainer4.hxx:71:50: note: 'getContainer' declared here > inline OInterfaceContainerHelper4<listener>* getContainer(std::unique_lock<std::mutex>& rGuard, > ^ > ucb/source/core/ucbstore.cxx:1921:66: error: too few arguments to function call, expected 2, have 1 > m_pPropertyChangeListeners->getContainer( OUString() ); > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ > include/comphelper/multiinterfacecontainer4.hxx:71:50: note: 'getContainer' declared here > inline OInterfaceContainerHelper4<listener>* getContainer(std::unique_lock<std::mutex>& rGuard, ^ Change-Id: Ie13c7bf17d066607ec7095b3e45ab7d6ecea1cb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146940 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-13Adapt to renamed libcairo-lo.so.2Stephan Bergmann
...following up on d552b4a549d614a03aa9328e017dec27bd3ff41e "Enable opening of downloaded fonts only in ForKit in Online" and 9eaa1325a014ff76acd3290752f842ed6bad89ac "Only package the external/cairo library that is named the same as the SONAME" Change-Id: Ifec89813140dcca5eea13943a12883febb6c5cd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146934 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-13Assume that only vnd.sun.star.expand URLs shall be macro-expanded hereStephan Bergmann
...even though XSLTFilter::expandUrl did that unconditionally ever since the function's introduction in 3218e6592694da70760c1a42b7c562c6864799b2 "INTEGRATION: CWS xsltfilter09". Change-Id: I08022091bc15048478c08e3f0f5cfffbb954df5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146911 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-13XSLT2Transformer::create should always succeedStephan Bergmann
Change-Id: Ie2aa4fe48da2362ff1a88fa44a51bed498a4f432 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146935 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-13Fix CustomTarget_postprocess/check_dynamic_objects for --enable-qt6Stephan Bergmann
Change-Id: Id1e76a7ed728beb359e0944b51de84bf720490ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146910 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-13ofz#55872 fix oss-fuzz build wrt fontconfig not getting built staticCaolán McNamara
change from static to dynamic was hidden away in commit: commit d552b4a549d614a03aa9328e017dec27bd3ff41e Date: Tue Sep 20 16:07:14 2022 +0300 Enable opening of downloaded fonts only in ForKit in Online Change-Id: Ia6e636fdbdac31f6cf746fc70c892d71462a9619 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146895 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-13enforce proper locking when calling OInterfaceContainerHelper4Noel Grandin
Change-Id: Ic86305f3d16148925c7753200a687f36f08a6516 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146936 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-13tdf#153499 Add missing colons to labels with buddy controlsSeth Chaiklin
Change-Id: I1260503e12516b3b29d34a317ca3a58cc314b608 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146920 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2023-02-13osl::Mutex->std::mutex in DynamicResultSetWrapperListenerNoel Grandin
Change-Id: Ie8673462fac30132f4e6b3cf7792d8554bf4f14a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146901 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-13osl::Mutex->std::mutex in PropertySetRegistryNoel Grandin
Change-Id: I08a059998cb13f12ad6183ee54754525386dfcd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146853 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-13osl::Mutex->std::mutex in PersistentPropertySetNoel Grandin
Change-Id: If88ac207083a928e2315e2ec1c7ac40951fb2a6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146851 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-13Preserve nullptr between gtk_assistant_get/set_page_titleStephan Bergmann
...in case that might make any difference. Even though <https://docs.gtk.org/gtk3/method.Assistant.get_page_title.html> and <https://docs.gtk.org/gtk3/method.Assistant.set_page_title.html> claim that this must be "a NUL terminated UTF-8 string", it can apparently also be null. This is a follow-up to 6ed7a3cc51e560c6b2a6894f6829c0ac9f991ef2 "tdf#153501 Fix OString construction from nullptr", and at least the recipe in the comment at <https://bugs.documentfoundation.org/show_bug.cgi?id=153501#c0> "Crash when trying to do WollMux mail merge" still works with this change. Change-Id: I9851bbf31cfa5a85ef5d8c7d19a790d004984d0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146909 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-13Only package the external/cairo library that is named the same as the SONAMEStephan Bergmann
Change-Id: Id97fe380c3e3976e56a6962eaebfbd696bab7332 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146908 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-13sw floattable: handle table-in-fly in SwFrame::GetNextFlyLeaf()Miklos Vajna
Trying to lay out a split fly that contains a table resulted in a stack overflow. The reason for this was that SwObjectFormatter::FormatObjsAtFrame_() has a loop that will format all objects of the current fly frame, but we managed to anchor the follow fly into itself. Fix the problem by improving SwFrame::GetNextFlyLeaf(), somewhat based on how SwFrame::GetNextSctLeaf() has special cases for tables. This way once we split the fly frame, we'll try to move the follow anchor frame to the next page's body frame, and not to a child of the follow fly itself. Also add a first floattable testcase, we can already assert that the table is split correctly. Do this in a separate suite for now, since the pool's default SwFormatFlySplit is only created once, so SwFormatFlySplit::SetForce(false) doesn't have the wanted effect. The anchor's text is still on both pages, should be on page 2 only. Change-Id: Ie2ce75dbace5d9716008351aedb6a8989036badb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146854 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-02-13tdf#152964: sw: move UItest to CppUnittestXisco Fauli
Change-Id: I9470bce1350a87d5773674b55148b64b02997210 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146902 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-02-13tdf#143148 Use pragma once instead of include guardbuldi
Change-Id: I6fa77335ced02442eec69b0dbb088505eb4b1aa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146818 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-02-13Rename: Extension Manager -> ExtensionsSamuel Mehrbrodt
simplify dialog title, should be clear what this is about. Change-Id: I65d8ca89e32cc225a07483703cd27b0fdc630b42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146715 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-02-13sw: use try/finally to reset the changes in OptionsTreeDialogXisco Fauli
Otherwise it might affect other tests if it hits an assert Change-Id: I16b818edc0f4414937f28b8459d06712c7db9eac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146896 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-02-13sw: use try/finally to reset the changes in OptionsTreeDialogXisco Fauli
Otherwise it might affect other tests if it hits an assert Change-Id: Iee4ee4964640114126c2ec404df567598668ed99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146894 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-02-13sw: use try/finally to reset the changes in OptionsTreeDialogXisco Fauli
Otherwise it might affect other tests if it hits an assert Change-Id: I987d5b4493d599a7ad21c916464efca52f24f548 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146897 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-02-13sc: use try/finally to reset the changes in OptionsTreeDialogXisco Fauli
Otherwise it might affect other tests if it hits an assert Change-Id: Iee86221cc7b4bd66fc19dc63b162d72aacec5016 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146874 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-02-13Fix/simplify some vnd.sun.star.expand: handlingMike Kaganski
The vnd.sun.star.expand: payload must be URL-decoded prior to passing it to expandMacros; the protocol must be checked case-insensitively. Use startsWithIgnoreAsciiCase for that. Change-Id: I2be993a0400a27cb7dc57207cd0824b4505afd2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146855 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-02-13Fix typoAndrea Gelmini
Change-Id: I58611c416b2fe198dc847336a592be6683e9b3bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146899 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-02-13tdf#143148 Use pragma once instead of include guardsbuldi
Change-Id: I5a88b699425a37b914a71400e918965a9f6116eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146730 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-02-13sc: avoid divide by zero in ScEEImport::GraphicSizeXisco Fauli
See https://crashreport.libreoffice.org/stats/signature/ScEEImport::GraphicSize(short,long,ScEEParseEntry%20*) Change-Id: Ia5acccb1118aff2486d23eabd536053e67f346ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146746 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-13fix openssl build on aarch64 - _umul128 is not available on non x64Christian Lohmaier
adding upstream patch that uses __umulh as a fallback Change-Id: Ib95de30d3f7208c38421df0c63eb1ceafccd9354 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146839 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-02-13Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to a295ef1fa2462d9a828341e7b947eae05ba14154 - tdf#153417 Edit module options Help page Change-Id: Iadc6b9b9be76d0f4c57336e43872d4ab3aa3f7f6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146823 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-02-13Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to 5b8658e58d02f8f3ec6a613f7c4edd32ca2e5d76 - FormatPercent New Basic function / VBA Change-Id: I0ad4022394632f0d49417bb56ecda641af3b0b42 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146519 Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-01-30 13:06:52 +0000