summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-09-14Resolves tdf#33714 - Option to disable "only active sheet"Heiko Tietze
Based on work by Martin van Zijl in I5f5b65b132d91beb24aa6e9282390dead235d849 Change-Id: Ie4543a2fc4b52715b5d87783a57e982c20274114 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173220 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-09-14use more concrete UNO type in SwAccessibleEvent_ImplNoel Grandin
Change-Id: I8785016caed0d56c50eceb3611091fffdc2a353e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173358 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-09-14use more concrete UNO type in CDocumentNoel Grandin
Change-Id: Ifd7306ab7219d940c55b3cc1054f65f64141616e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173352 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-09-14use more concrete UNO type in SwXCellRangeNoel Grandin
Change-Id: I177f37127a7856ade21b0ace4c93121000967cf8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173354 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-14qt: Use modern connect syntax in QtInstanceMichael Weghorn
Change-Id: I3126ca571e8120797ca9d61da6a902398f57b337 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173349 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-14qt: QtFilePicker: Use modern connect syntax, port from deprecated signalMichael Weghorn
Use modern connect syntax and address the warning about the use of a deprecated signal that this revealed: `QCheckBox::checkStateChanged` was introduced in Qt 6.7 [1] and `QCheckBox::stateChanged` was deprecated in Qt 6.9 [2]. In file included from .../libreoffice/vcl/qt6/QtFilePicker.cxx:10: .../libreoffice/vcl/qt6/../qt5/QtFilePicker.cxx:693:44: error: 'stateChanged' is deprecated: Use checkStateChanged() instead [-Werror,-Wdeprecated-declarations] 693 | connect(pCheckbox, &QCheckBox::stateChanged, this, | ^ .../qt5/qtbase/src/widgets/widgets/qcheckbox.h:40:19: note: 'stateChanged' has been explicitly marked deprecated here 40 | QT_MOC_COMPAT QT_DEPRECATED_VERSION_X_6_9("Use checkStateChanged() instead") | ^ .../qt5/qtbase/src/corelib/global/qtdeprecationmarkers.h:179:44: note: expanded from macro 'QT_DEPRECATED_VERSION_X_6_9' 179 | # define QT_DEPRECATED_VERSION_X_6_9(text) QT_DEPRECATED_X(text) | ^ .../qt5/qtbase/src/corelib/global/qtdeprecationmarkers.h:29:33: note: expanded from macro 'QT_DEPRECATED_X' 29 | # define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text) | ^ .../qt5/qtbase/src/corelib/global/qcompilerdetection.h:1004:36: note: expanded from macro 'Q_DECL_DEPRECATED_X' 1004 | # define Q_DECL_DEPRECATED_X(x) [[deprecated(x)]] [1] https://doc.qt.io/qt-6/qcheckbox.html#checkStateChanged [2] https://doc.qt.io/qt-6/qcheckbox-obsolete.html#stateChanged Change-Id: I0787b378855009abea740a0f5c1aab537c41987e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173348 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-14qt: Use modern connect syntax in QTimerMichael Weghorn
Change-Id: Ic4a6c64de834b133a2708807d45c39d6ada4a00c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173347 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-09-14qt: Use nullptr instead of Q_NULLPTRMichael Weghorn
There's no reason to use that macro. As the doc says [1]: > /* * Compatibility macros for C++11/14 keywords and expressions. > * Don't use in new code and port away whenever you have a chance. > */ [1] https://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/global/qcompilerdetection.h?id=07749de7ef59827a2deb2719cd20208bdce201e2#n935 Change-Id: I93ef0ae34a737a6ff93270f52ba308bd90bfc505 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173343 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-14remove OSubComponent from OConnectionNoel Grandin
which attempts to implement a very dodgy and almost but not actually thread-safe dispose function. Rather just hold a weak reference to the data source that created us. Change-Id: I431bb43aef1d6ce92d7987e7d731b724b64a9767 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173341 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-14use more concrete UNO type in DOM::CElementListImplNoel Grandin
Change-Id: I5a480714fc85d623e524e7862e90e76cd65b5c0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173351 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-09-14use more concrete UNO types in svxNoel Grandin
Change-Id: I55fd67a66067f0c4f43ef182101c8d72a22fe3f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173325 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-09-14use more concrete UNO type in SwXDocumentIndexNoel Grandin
Change-Id: I502c37a0d3ac27896e2b9237ade0c285933c922a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173356 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-09-14use more concrete UNO type in vba::ColumnsEnumWrapperNoel Grandin
Change-Id: Ie674fdb503e49d465a13eca9afdca9fc5c7e7eb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173353 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-09-14use more concrete UNO type in SwXTextTableNoel Grandin
Change-Id: I5db405a6da6bd9820b3e3f09fb89eb5f7ece1bab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173355 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-14Resolves tdf#133041 New list style is not added back afterJim Raykowski
undoing and then redoing it by following the approach used by commit c4d82fc21c5e155472f6a30244b3fce806ada85c Change-Id: I09c877aecdcf49d4be5451e247bf1010856c2d39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173312 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-09-13sc: fix revert conflictXisco Fauli
After 27be65a7d5326608f75839e3964ac322e88224a1 "tdf#162938: Revert "tdf#61313 Replace the static ">="..." I saw it right after I clicked the submit button :| Change-Id: I8a1abf583714c288e6d6ed2c42615d333527e6d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173328 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-09-13use more concrete UNO type in librdf_NamedGraphNoel Grandin
Change-Id: I97b8965bc73923c35aa086e10bfef081a263de58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173339 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-13Fix regression from 27be65a7d5326608f75839e3964ac322e88224a1^!Julien Nabet
Crash when: - open https://bugs.documentfoundation.org/attachment.cgi?id=196417 - select a cell with icon - Format/Conditional/Icon Set... => popup dialog with message which at the end proposes "No" or "Yes" - Click "No" => Crash with bt: 0 0x00007f35e28acb66 in ScIconSetFrmtDataEntry::SetFirstEntry (this=0x55b37f0244d0) at /home/julien/lo/libreoffice/sc/source/ui/condformat/condformatdlgentry.cxx:1357 1 0x00007f35e28ad4cc in ScIconSetFrmtEntry::IconSetTypeHdl (this=0x55b37ee14940) at /home/julien/lo/libreoffice/sc/source/ui/condformat/condformatdlgentry.cxx:1422 2 0x00007f35e28ad1ac in ScIconSetFrmtEntry::ScIconSetFrmtEntry (this=0x55b37ee14940, pParent=0x55b37ad5a4e0, pDoc=0x55b37ae30350, rPos=..., pFormat=0x0) at /home/julien/lo/libreoffice/sc/source/ui/condformat/condformatdlgentry.cxx:1391 3 0x00007f35e289185d in ScCondFormatList::init (this=0x55b37ad5a4e0, rDoc=..., pFormat=0x0, rRanges=..., rPos=..., eType=condformat::dialog::ICONSET) at /home/julien/lo/libreoffice/sc/source/ui/condformat/condformatdlg.cxx:117 4 0x00007f35e2894ef0 in ScCondFormatDlg::ScCondFormatDlg (this=0x55b37eed53b0, pB=0x55b37ae6fd50, pCW=0x55b37ef0eb00, pParent=0x55b37af94cc8, pViewData=0x55b37b17c160, rItem=std::shared_ptr<ScCondFormatDlgData> (use count 2, weak count 0) = {...}) at /home/julien/lo/libreoffice/sc/source/ui/condformat/condformatdlg.cxx:479 Change-Id: Ifd79edd1fe04ebbf50fd736989e5dd787cf91aa3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173338 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-09-13tdf#162798: python3: Add lib/importlib/readers.pyXisco Fauli
Somehow I missed to add it in a1295cb177295752f8cbfbb49e13d5bb69ed7dc7 "python: upgrade to 3.10.14 (master only)" Change-Id: I53e5fa6b89a7ac799041fd28ef4c2558df9743e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173323 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-09-13use more concrete UNO types in chart2Noel Grandin
Change-Id: Id2d58ad76b6e8ff569bd7b65f86a7fdd0152f3d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173324 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-13tdf#161444 sc a11y: Send focused event when switching sheetsMichael Weghorn
When switching to another spreadsheet table in Calc (e.g. using Ctrl+Tab or Ctrl+PageUp), send an `AccessibleEventId::STATE_CHANGED` for the `FOCUSED` state of the newly active/focused sheet before sending an `ACTIVE_DESCENDANT_CHANGED` event for the currently active cell in that sheet. Call `ScAccessibleSpreadsheet::GotFocus` instead of `ScAccessibleSpreadsheet::FireFirstCellFocus` to achieve that, which takes care of both events. With that in place, the corresponding events when using the gtk3 VCL plugin now are shown as expected in Accerciser's event monitor: 86.3 object:children-changed:remove(0, 0, [table | Sheet Sheet2]) source: [document spreadsheet | Untitled 1 - LibreOfficeDev Spreadsheets] application: [application | soffice] 86.3 object:children-changed:add(0, 0, [table | Sheet Sheet3]) source: [document spreadsheet | Untitled 1 - LibreOfficeDev Spreadsheets] application: [application | soffice] 86.3 object:state-changed:focused(1, 0, 0) source: [table | Sheet Sheet3] application: [application | soffice] 86.3 object:active-descendant-changed(212998, 0, [table cell | G14]) source: [table | Sheet Sheet3] application: [application | soffice] This however still doesn't make Orca as of commit 6f6e0f79ff5d8669591c7c19ecdaca5ec45ab67d, i.e. the commit prior to the Orca-side workaround [1] commit 4ead75fdaebdde60535cfbadca108ccaeeeb9401 Author: Joanmarie Diggs <jdiggs@igalia.com> Date: Thu Sep 12 19:56:48 2024 +0200 Hack around https://bugs.documentfoundation.org/show_bug.cgi?id=161444 Because removing workarounds is regressing the end user experience, add the following hack: When we receive an active descendant event from LO, and the event source is not an ancestor of the current focus: 1. Silently set the locus of focus to the parent of the event source. Otherwise we'll be super chatty in response to the next item. 2. Non-silently set the locus of focus to the event source. This will cause us to present the sheet name. 3. Allow the default script to do its thing which will set the locus of focus to the cell with the common ancestor being the table and thus it will not be double-spoken. speak the newly active sheet before announcing the cell, but still requires further changes on Orca side, s. discussion in tdf#161444 and attached Orca diff there. [1] https://gitlab.gnome.org/GNOME/orca/-/commit/4ead75fdaebdde60535cfbadca108ccaeeeb9401 Change-Id: I699258ba395dd212fa45c7d1546b26a7c241db97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173331 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-09-13package: m_nMagicalHackSize appears superfluousMichael Stahl
Change-Id: Idc32af25b7835b04b777a2a0767e1982d074f6d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173322 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-09-13ITEM: adapt SfxPoolItemHolder::operator=Armin Le Grand (allotropia)
I formally tried to avoid un/re-register if Item needs surrogate support, but there are more aspects to this, e.g. the pool could be different or even the WhichID of the Item, so just do the necessary here. These cases are also not too often used. Change-Id: I8d1e8854f5ce3cac5566c076797162ba2e4b4b75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173329 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2024-09-13tdf#162911 sw: add an assert not to use default itemsMichael Stahl
Change-Id: I6234b132bb741a3910a4a3f9a11efc0e3340fb21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173321 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-09-13scriptforge.py Connect via pipeJean-Pierre Ledure
Python scripts using ScriptForge start like: from scriptforge import CreateScriptService, \ ScriptForge ScriptForge(...) (*) sv = CreateScriptService(...) The (*) statement has next syntaxes: either (1) ScriptForge() (2) ScriptForge(host: str = ..., port: int = ...) (3) ScriptForge(pipe: str = ...) Syntax (1) is implicit at the first invocation of CreateScriptService() without a former call to ScriptForge() Syntax (2) exists in previous versions. This commit implements syntax (3) to connect a Python process to a LO process on the same system via a pipe mechanism. The change impacts only Python scripts. The documentation should be upgraded to include the new functionality. Change-Id: I50457b6fffc8c9d6a9ad5c5289de1c363c6680e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173252 Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2024-09-13Resolves: tdf#162455 svg->curve causes text in objects to disappearCaolán McNamara
Rather than assuming there is a uniform unchanging MapMode scaling, follow the same pattern as SVGWriter and map positions/sizes back relative to the original MapMode. Examples of #i119125#, tdf#162455 and tdf#160625 work Change-Id: I8229cebee6173fa4905828afb3b973c80ede3315 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173126 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-13ofz: 22 byte .zip is min sizeCaolán McNamara
at which point nPos is 0 on entering this test. If the buffer does not start with PK\x5\x6 then nPos is decremented before checking against 0, so nPos is -1 and doesn't throw as an unhandled .zip. Change-Id: I4a7fed6e863582324945a75bc077f6346ddd5c23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173208 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-09-13use more concrete UNO types in dbaccessNoel Grandin
Change-Id: I017d4fd7131735dfd2dba6e1b046fbe691522745 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173280 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-13sort comments by time or positionMohit Marathe
Change-Id: I1f4014e20b4baaca0dde742e7384397c1311f926 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170492 Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de> Tested-by: Jenkins
2024-09-13sw: add Comments Panel in sidebarMohit Marathe
This commit adds a sidebar deck for comments. It has all the functionalities of the old comments shown via annotation window. Change-Id: Ibab0e21a54c097d0f42bddb1d07da74319970135 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167840 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
2024-09-13ICU: fix aclocal dependencyXisco Fauli
Patch configure directly instead of configure.ac Change-Id: Iaaf3e10dc435d5d8f546c009b27c9a4aa7c09141 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173315 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-09-13tdf#162823 package: fix loss of ODF encrypted basic macrosMichael Stahl
The problem is that there is a ZipEntry ZipPackageStream::aEntry which does not necessarily correspond to the values read from the Zip central directory, because of a call to ZipPackageStream::setSize() in ZipPackageStream::successfullyWritten() to override nSize and nMethod for encrypted entries. This triggers the consistency checks in readLOC(), where this aEntry is passed. Refactor things so that ZipPackageStream::aEntry and thus hopefully all ZipEntry instances correspond to the Zip file's central directory. For encrypted entries, store the decompressed size (which is read from manifest.xml) in m_nOwnStreamOrigSize and pass it as a separate parameter to the ZipFile functions that need it, and ultimately to XUnbufferedStream, resolving multiple TODO comments. (regression from commit efae4fc42d5fe3c0a69757226f38efc10d101194) Change-Id: Ib6ea32595c6027b98da9196a2e2bd0a99b62a983 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173273 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2024-09-13add a comment of an example where this dialog appearsCaolán McNamara
Change-Id: Icca2eb703b9fd926e7145822e9671c23c6e83356 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173316 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-13tdf#162938: Revert "tdf#61313 Replace the static ">="...Xisco Fauli
... with a dropdown of different operators" Why was this patch submitted in the first place? It added a call to convertToOldCondFormat in testTdf101104, testComplexIconSetsXLSX and testTdf64401 to make those tests pass but the issue was already reproducible with those files This reverts commit fcc5770dd1e33dcb4f4f0c28683569af5d1d8368. Change-Id: Ifd8904de26d39d23e52ec2188d917bec34ad93b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173310 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-09-13vcl: move variables closer to first usage in BitmapEmbossGreyFilter::execute()Chris Sherlock
Change-Id: I711b82e2c86035aa1bfbb245c125be65277043f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173198 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-09-13vcl: just return a BitmapEx() in BitmapDisabledImageFilter::execute()Chris Sherlock
Change-Id: I2a257211d7fdf22abb8d6e1f994293873348b38e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173191 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-09-13tdf#43157 vcl: remove OSL_ENSURE from BitmapEx functionsChris Sherlock
Change-Id: I8232751174dccc55139ab4878950636c32b1d6a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173199 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2024-09-13UBSan CppunitTest_editeng_borderline etc. need more RTTI nowStephan Bergmann
...presumably since 5ba893dfb8838b0ef946b52de9ef1336d2ab0512 "use more concrete UNO type in editeng", > DynamicLibraryManagerException: "Failed to load dynamic library: /home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/LinkTarget/CppunitTest/libtest_editeng_borderline.so > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libeditenglo.so: undefined symbol: _ZTIN3vcl9unohelper18DragAndDropWrapperE" (<https://ci.libreoffice.org/job/lo_ubsan/3306/>) Change-Id: I4501c3df9f353d9b1244f92b5bbc6fb2dafc24bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173311 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-09-13tdf#162911 sw: fix crash after autocorrect inserts hyperlinksMichael Stahl
The problem is that SwDoc::SetFormatItemByAutoFormat() inserts a static pool default item of SwFormatINetFormat as SwTextINetFormat into the document. SfxPoolItemHolder::SfxPoolItemHolder() does not clone a static pool default item, hence it will be deleted multiple times. The code that was added in SwDoc::SetFormatItemByAutoFormat() to fix tdf#62536 is for the RES_CHRATR_* items, it is not needed for any of the other items that autocorrect/autoformat may insert (RES_TXTATR_INETFMT or RES_PARATR_TABSTOP). (regression from commit fe444d1f74abe417962be0bcd3340f40f2446b58 and/or commit ca3c6d468f68af1506bf4e56b47655e5d56306a8) Change-Id: I8b0414995f9fd8f94d1903a8e66f0c25c7038ebd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173267 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-09-13libpng: upgrade to 1.6.44Xisco Fauli
Downloaded from https://unlimited.dl.sourceforge.net/project/libpng/libpng16/1.6.44/libpng-1.6.44.tar.xz Change-Id: I0132e6edb0078d1d4479bb79b7f740c23719d72b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173309 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-09-13[API CHANGE] XDocumentDigitalSignatures: remove deprecated / unused functionsMiklos Vajna
Some functions were already a stub and only aborted on calling them. The *Package* functions were added in commit c9ed2f359a9e899c3046c8151c831e24250fddbb (INTEGRATION: CWS xmlsec08 (1.4.24); FILE MERGED 2005/02/22 13:07:19 mt 1.4.24.1: #i36682# Accept separate Stream for signatures..., 2005-03-10), but it seems nobody called them. This also means that DocumentSignatureMode is now never set to DocumentSignatureMode::Package, so remove that as well. It seems to be unlikely that this non-published service was used by 3rd-party code, since it was specific to the needs of sfx2/ code, not generic functionality that could be useful in other contexts. Change-Id: Icfed9a0e6568f6eb21f9236901af01f1915bf2f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173313 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-09-13lok: export transition info to getPresentationInfo JSON structureTomaž Vajngerl
Added only basic transitions (type + subtype conversion) + added test case Change-Id: Ibebc34005ee0ffe1fdc2d1587c746538f657fbdd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169620 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172869 Tested-by: Jenkins
2024-09-13convert OKeySetValue to a structNoel Grandin
for better readability Change-Id: I9750668a31740bb1de0b6f024912d5cc73f7e766 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173279 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-13Update git submodulesXisco Fauli
* Update dictionaries from branch 'master' to 75f5dff8c972fff4a32e4ea8434722c277f02a3f - Updated Slovak dictionaries to v2.4.8 Downloaded from https://github.com/sk-spell/hunspell-sk/archive/refs/tags/v2.4.8.zip Change-Id: I369a4703c7accc635572a0f711c5c0304429e4e9 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/172738 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-09-13tdf#162926 Revert "tdf#100037 vml import: add AS_CHAR images...Justin Luth
... to zOrder calculation" This reverts my 24.8 commit 6c2ab0f3ca440f6e10b438e6ee0e235cbe155216. Change-Id: Ia163c5adf7edfa70e49a85be6eea7908ae93ef79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173240 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2024-09-13tdf#162926 Revert "tdf#100037 vml import: set fly-anchored AS_CHARs...Justin Luth
...above fly's zOrder" This reverts my 24.8 commit f714fb262ad8561afcababf4b7a97dedb1b72c15. Some activeX binary (I assume) seemed to be composed of two parts and yet didn't have a TextBox property, but when sent to the background the textbox part of it disappeared. I assume it was some kind of two-part monstrosity, but nothing in the ServiceInfo indicated anything excludable. Change-Id: I6e088a74e62db8b2bb732ba66e2cb3319b9c401e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173239 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2024-09-13tdf#162935: use PUTC for WITH variable assignment: it doesn't copy valueMike Kaganski
SbiRuntime::StepPUT, SbiRuntime::StepSET, SbiRuntime::StepVBASET call checkUnoStructCopy eventually, which copies the UNO struct by value. This is not what we need. On the other hand, SbiRuntime::StepPUTC only makes the by-ref assignment, and makes the reference const; but Basic code never assigns anything to the internal variable itself, only to its members. I hope that this time, I get it right. Change-Id: I2b4a51a2dca9e7106e14e03360ef0d5a50b60079 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173305 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-09-13Refactor SbxValue::FormatMike Kaganski
Change-Id: I1a55f2c6148246733699c1ff1086436af9d450b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173254 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-09-12Optimize TokenMap and AttributeList in oox and xoMike Kaganski
Shaves lots of string allocations, and uses optimized code paths Change-Id: I8e33e2aecdc7e0d2f2c31b774daa36304b3973ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173179 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-09-12Fix typoAndrea Gelmini
Change-Id: I8659ec30e8cabbbbd693bc50266fa0a386fb007c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173271 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2025-01-28 09:30:38 +0000