summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-09-20new loplugin flattenNoel Grandin
look for places where we can flatten the control flow in a method by exiting early with a throw, ie. instead of if (cond) stuff(); else throw ex; we change it to: if (!cond) throw ex; stuff(); Change-Id: I8b6bdf883b325807c7e3a3ef698e4f4606e7d38b
2017-09-20tdf#112381 Macro Organizer: Move Run, Close, Help buttons to the bottomSabin Frandes
Change-Id: Id08ce71bcd060121630c3a9194f8cfe663ca5822 Reviewed-on: https://gerrit.libreoffice.org/42331 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-20beanshell: don't remove the getPeer call, access it by reflectionFridrich Štrba
Change-Id: I031580c6edd0d80727d940b4fd300308a905a383
2017-09-20group java-requiring tests togetherDavid Tardon
Change-Id: Ie4e5422d2a6cb01b4a899ed0982d60fe65c386d7
2017-09-20Ignore DrawWorkStartupTimer on Scheduler shutdownJan-Marek Glogowski
Change-Id: Ia0cf4311b42dfa170ce429a958a26afd9c70ff0c
2017-09-20tdf#112333 PPTX export animClrSzymon Kłos
Change-Id: Ibf230a6c4ddac4806dab235c3394778db26da38c Reviewed-on: https://gerrit.libreoffice.org/42476 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-09-20Bin some noise comments and ASCII graphicsTor Lillqvist
Change-Id: Ib0e786b0e8401da3e3c93bf254727411774e8f43
2017-09-20unused m_sNoSubjectST/m_sDefaultAttachmentST in SwMMResultEmailDialogNoel Grandin
ever since commit ba0796b331247b27886384377c480e413c3ee83d Date: Wed Dec 23 17:43:14 2015 +0100 mailmerge: Killed the 'Save, print or send' page. Change-Id: Id77cd6beb3eaa13ead848495d9f8661c83f60975
2017-09-20unused maFilterService in filter_info_implNoel Grandin
since it was added in commit d0d152d4e3e99c41dd71187eca917470c4d64adf Date: Fri Apr 4 15:34:02 2003 +0000 INTEGRATION: CWS xmlfilter01 (1.1.2); FILE ADDED Change-Id: I69bf6cad4e3d637c065d967a2b5915312cc23e93
2017-09-20unused aDDLastRectPos in SvxIconChoiceCtrl_ImplNoel Grandin
since commit bf2373daf50595c02741f63d941fda0462535d62 Date: Tue Jul 26 23:32:40 2011 +0200 callcatcher: remove unused methods Change-Id: I2eef2bdcd40d4b4b1da8cf7ca95b0194ea99216f
2017-09-20unused fields in XFormsEventConcreteNoel Grandin
ever since commit 6297bf4e24bd48b52083ca711ac9930f60bf85c8 Date: Wed Mar 23 10:39:28 2005 +0000 INTEGRATION: CWS eforms4 (1.1.2); FILE ADDED Change-Id: Ic4915a9b31c3a5f0222da0a4fc8557b2cbe6078e
2017-09-20unused m_aModuleIdentifier in StatusBarManagerNoel Grandin
Change-Id: I1f8260fd148b694337ea0440eb2edde4753b34c1
2017-09-20unused m_aModuleIdentifier in UIConfigurationManagerNoel Grandin
Change-Id: Idd4ced156201e81ee818d4b6b69e6c4d254f3387
2017-09-20unused m_sUpdateTableName in OQueryControllerNoel Grandin
ever since commit 2106d8e648449d34b195068eef5f672a14ea64a8 Date: Sun Jun 10 21:51:19 2012 +0100 callcatcher: update unused code Change-Id: I88a13c5c414a86a82efc6883d2e1602199569dc9
2017-09-20unused sNumCharFmtName fieldsNoel Grandin
ever since commit 89ef4dea325a11c706ff9619ff4717124260f864 Date: Fri Jul 17 10:34:58 2015 +0200 loplugin:unusedmethods cui Change-Id: Ibfa3841168448d4f08075a684fa36262b303210f
2017-09-20unused m_nFetchSize in OResultSetNoel Grandin
since initial commit 77e4adbe4759f21f6cf095d954391a9ddbbec2cf Date: Mon Sep 17 22:50:49 2012 +0200 mork driver implementation Change-Id: I226c4065a5ab4404cc9e99eb3e026d153d1ccf08
2017-09-20unused bPageToggle in GraphicImport_ImplNoel Grandin
ever since commit 0929dfa83ca4dbc675c74854566ce4e25def0dbd Date: Sat Jan 11 11:54:14 2014 +0100 writerfilter: drop never generated rtf {XAlign,FHDR,YAlign,XRelTo,YRelTo} Change-Id: Icabe9ff848e3cc9918741e9c68d8f2312145fb74
2017-09-20unused bVertFlip/bHoriFlip in GraphicImport_ImplNoel Grandin
ever since commit 4a924576e415f16e0571542bb0d683529f9046ff Date: Wed Jan 15 20:24:41 2014 +0100 writerfilter: drop unused BlipDib and FSP in doctok Change-Id: I9bf644bdc4b37cb6c4a9a9ab7757c4a83a520cd7
2017-09-20unused m_xStorage in RTFDocumentImplNoel Grandin
ever since introduction in commit 328d154015f8cb733ed62d793bbbc31eb4cc971b Date: Fri Jun 10 18:56:08 2011 +0200 resolvePict: import the stream as a graphic object Change-Id: Ife03094d721621cc592be9cd94899a4e40550330
2017-09-20unused aCId in ScHTMLExportNoel Grandin
ever since commit fa135fd0e05fc4ba784b4349d65f2e5ed26c0f55 Date: Tue May 31 10:30:35 2016 +0200 remove unused SID constants and associated code Change-Id: I47388fa5dcfec67bbcd9f7bf0a079d9376bc05af
2017-09-20simplify calling listenersNoel Grandin
Change-Id: I4bf0d378003d1f54685f6c55c0314c117b243526
2017-09-20tdf#98980 Update selection inside control when new slide layout is selectedSerge Krot
Change-Id: Ibf8fe8d2fcdb5efef6df657607e65a791b67d4a0 Reviewed-on: https://gerrit.libreoffice.org/42462 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-20no need to queue formats in header and footer ...Bjoern Michaelsen
- we can call MakeFrames on them right away - as there had been performance issues on mail merge here before, this might a bit quicker for suoer large documents. Change-Id: Idd84d7e6a962d00d59e2981f63ed9db60377fa01 Reviewed-on: https://gerrit.libreoffice.org/42442 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2017-09-20tdf#112447: connect all objectsBjoern Michaelsen
- fixes regression from 575e222a1742918be052f2b716ddf57ce0008404 Change-Id: I686ce41c87e5b421e0382658404cf7bb153a4812 Reviewed-on: https://gerrit.libreoffice.org/42439 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2017-09-20Avoid API present from macOS 10.13 if building to run on olderTor Lillqvist
utimensat() and futimens() are new in 10.13. Change-Id: I03448adb17b40a646771c37179bd70c787547ca3
2017-09-19add signature icon cause the icon is available (in breeez)andreas kainz
Change-Id: If221848b1ef389a1816e5aab71f784ddd932c9bc Reviewed-on: https://gerrit.libreoffice.org/42347 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-09-19sc: fix infinite loop in XclImpDffConverter::ProcessShGrContainer()Michael Stahl
... and also in XclImpDffConverter::ProcessDgContainer() This was looping in CppunitTest_sc_filters_test, reportedly since commit 7e8c38b69742ff037a5e239bf0f02665f053ea53. The problem is that checkSeek() doesn't actually seek until EOF if the offset is too large. Change-Id: I16226a88388dcac8069d6a4cad860470540466e3
2017-09-19xmloff: fix stack-use-after-return in SvXMLExport::exportDoc()Michael Stahl
PropertySetInfo(PropertyMapEntry const * pMap) stores the pointers, and its lifetime is controlled by refcounting, so the lifetime of aInfoMap can't be automatic. ERROR: AddressSanitizer: stack-use-after-return on address ... ... is located in stack of thread T46 at offset 224 in frame SvXMLExport::exportDoc(xmloff::token::XMLTokenEnum) This frame has 39 object(s): ... [224, 288) 'aInfoMap' <== Memory access at offset 224 is inside this variable Change-Id: I4eaa9d38bab708b222d999b0982100d7ef97e95c
2017-09-19connectx() is available only on Mac OS X 10.11 and newerTor Lillqvist
Compiling against the 10.13 SDK with --with-macosx-version-min- required set to 10.9 or 10.10 (or defaulted, meaning 10.9) causes a compilation error now. Earlier SDKs did not catch it if you were using connectx() even if targeting pre-10.11. Try the approach from https://github.com/curl/curl/pull/1336/commits . Change-Id: I7cac294931c8afa6ff26a6ca9cf4491aff249de0
2017-09-19Writer Web export to PNG,JPG: switch to proper SvFilterOptionsDialogEike Rathke
Change-Id: I6388ad03d4b94556f5a955d06c1f4e0d8c7188b1 Reviewed-on: https://gerrit.libreoffice.org/42501 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19Writer does not support selection, so don't claim it wouldEike Rathke
Though it doesn't change anything UI wise. See also commit cb9d99dbb5a7249ca7437bd5c30c6c9374089a16 Change-Id: Ic5e0e411325945f91a00b58da5341eeecd7b6623 Reviewed-on: https://gerrit.libreoffice.org/42500 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19Accept macOS 10.13Tor Lillqvist
Change-Id: I52fb11c8830a5a78c7a9181708f1727b473069e3
2017-09-19Writer export to PNG,JPG: switch to proper SvFilterOptionsDialogEike Rathke
With all bells and whistles, instead of the crude size/dpi JPG dialog even for PNG. Change-Id: I695a78643e07900822ec9253ac818efd52339cc0 Reviewed-on: https://gerrit.libreoffice.org/42498 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19Call getCurrentPageWriter() only for WriterEike Rathke
Change-Id: I81dd61c33a0bc69e43d3325b297c44e5b7b732bd Reviewed-on: https://gerrit.libreoffice.org/42496 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19Detect Writer doc independent of selection, we'll need that laterEike Rathke
Change-Id: Ieddbcd3e8b750ec4b32643aec0433f8638ee46ee Reviewed-on: https://gerrit.libreoffice.org/42495 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19DocumentToGraphicRenderer: suppress selection for Writer, it doesn't workEike Rathke
See FIXME comment. Change-Id: I7511f5b498029fedcbd0c39d5ec67288782330ae Reviewed-on: https://gerrit.libreoffice.org/42493 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19Updated corePaul Menzel
Project: dictionaries 7250202493f1d91c5568db3363a268f7e5dcac42 de: Strip trailing spaces from README files Change-Id: Ie07d9c56d0e17612c1b1baaa2c0e29df4c3ad3cb Reviewed-on: https://gerrit.libreoffice.org/42484 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-09-19Updated corePaul Menzel
Project: dictionaries 8b73c571cb27bb29d26f3e218dedee2b680c3a04 de: Use more secure HTTPS URLs Change-Id: Iff2c6eddd7a0211b85f884d9e2601529daa3bab2 Reviewed-on: https://gerrit.libreoffice.org/42483 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-09-19DocumentToGraphicRenderer: current page is 1 if selectionEike Rathke
Change-Id: I0d26cd4da6f39c27b06df53596f9f405c5b0771f Reviewed-on: https://gerrit.libreoffice.org/42491 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19oops..Eike Rathke
Change-Id: I78c5bff1cc7503de066b151658f01fdc5d4b303b Reviewed-on: https://gerrit.libreoffice.org/42490 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19Introduce DocumentToGraphicRenderer::hasSelection() and maSelectionEike Rathke
Change-Id: Ib7a9df04eb1b8646e20f58c3f9af3ee2dbbb13db Reviewed-on: https://gerrit.libreoffice.org/42489 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19Rename getCurrentPageWriter() to getCurrentPage()Eike Rathke
... and let getCurrentPageWriter() be a private implementation detail. Change-Id: Iaa14d8eab81e5750fbaf45adc6aab66eee9018eb Reviewed-on: https://gerrit.libreoffice.org/42488 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19'a'CurrentPage gets on my nervesEike Rathke
Change-Id: Ifb6137048d7206c1f3a718331ed8b42f746052bb Reviewed-on: https://gerrit.libreoffice.org/42487 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19Writer export to PNG|JPG dialog preparation, current page number nonsenseEike Rathke
... if selection, workaround to get SvFilterOptionsDialog displayed. Change-Id: I7ebf2bfa8054555db2365078a02effd88ce5836f Reviewed-on: https://gerrit.libreoffice.org/42486 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19odk: document what doxygen means by "Protected Member" in IDLMichael Stahl
Interfaces and services that are marked as "optional" in IDL are deliberately tagged as "Protected" by doxygen, while everything else is "Public", so that in the inheritance diagrams dashed lines are drawn for "optional" bases and solid lines for non-optional bases. Unfortunately this also causes doxygen to produce the text "Protected Members", which appears hard to change, so just document it for now. Change-Id: Ice878981bac5bbb7a8a33a10f2b5f68c394e4340
2017-09-19sal: fix numerous doxygen warningsMichael Stahl
Change-Id: I2fd3fb7b67a62d349ff917466b08c75c19dcbff6
2017-09-19iOS, libzmf patch for 64 bit.jan Iversen
add patch Change-Id: Ieee366fc0bfd5837e5fd9c326e0a021bac7e3e84
2017-09-19iOS, prepare libfreehand for 64 bit.jan Iversen
updated config.sub Change-Id: I7ca88e740fc479794a902be8decdbcf82032130b
2017-09-19Updated coreOlivier Hallot
Project: help e52676102bf94041c27870a5ae86d7532db637ac Helponline: more language support Change-Id: I138ff9551f7d8c99c92a32bdcf91d261168ba5bb Reviewed-on: https://gerrit.libreoffice.org/42482 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-09-19Mark patch as upstreamedStephan Bergmann
Change-Id: I6e49099a264fbe1ddddd4931182eb6247be9cb10