summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-11-04Fix dialog name and titleSamuel Mehrbrodt
Change-Id: I55d628d6e61d4035155d42fa45270418a3e10387 Reviewed-on: https://gerrit.libreoffice.org/30563 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-04external/harfbuzz: -fsanitize=functionStephan Bergmann
Change-Id: Ie72eec98f1337e895b81c4ebebeefa4861a5a6a1
2016-11-04external/harfbuzz: Work around ASan out of bounds warningStephan Bergmann
CppunitTest_sccomp_lpsolver failed with the below error. struct _mtx (hb-ot-hmtx-table.hh) has two "variable-sized" array members (each of size VAR=1) longMetric and leadingBearingX, where the latter isn't used anywhere in the code; so removing it would make ASan's variable-sized array member heuristic kick in here and suppress the warning, but who knows whether there's some requirement on the exact sizeof(_mtx). > hb-ot-font.cc:128:12: runtime error: index 3 out of bounds for type 'OT::LongMetric const[1]' > hb_ot_face_metrics_accelerator_t::get_advance(unsigned int) const workdir/UnpackedTarball/harfbuzz/src/hb-ot-font.cc:128:43 > hb_ot_get_glyph_h_advance(hb_font_t*, void*, unsigned int, void*) workdir/UnpackedTarball/harfbuzz/src/hb-ot-font.cc:439:47 > hb_font_t::get_glyph_h_advance(unsigned int) workdir/UnpackedTarball/harfbuzz/src/./hb-font-private.hh:207:12 > hb_ot_position_default(hb_ot_shape_context_t*) workdir/UnpackedTarball/harfbuzz/src/hb-ot-shape.cc:613:35 > hb_ot_position(hb_ot_shape_context_t*) workdir/UnpackedTarball/harfbuzz/src/hb-ot-shape.cc:719:3 > hb_ot_shape_internal(hb_ot_shape_context_t*) workdir/UnpackedTarball/harfbuzz/src/hb-ot-shape.cc:768:3 > _hb_ot_shape workdir/UnpackedTarball/harfbuzz/src/hb-ot-shape.cc:792:3 > hb_shape_plan_execute workdir/UnpackedTarball/harfbuzz/src/./hb-shaper-list.hh:43:1 > CommonSalLayout::LayoutText(ImplLayoutArgs&) vcl/source/gdi/CommonSalLayout.cxx:485:23 > OutputDevice::ImplLayout(rtl::OUString const&, int, int, Point const&, long, long const*, SalLayoutFlags, vcl::TextLayoutCache const*) const vcl/source/outdev/text.cxx:1400:36 > OutputDevice::GetTextArray(rtl::OUString const&, long*, int, int, vcl::TextLayoutCache const*) const vcl/source/outdev/text.cxx:999:35 > OutputDevice::GetTextWidth(rtl::OUString const&, int, int, vcl::TextLayoutCache const*) const vcl/source/outdev/text.cxx:915:19 > ImplFontMetricData::ImplInitTextLineSize(OutputDevice const*) vcl/source/font/fontmetric.cxx:372:30 > OutputDevice::ImplNewFont() const vcl/source/outdev/font.cxx:1100:42 > OutputDevice::GetTextHeight() const vcl/source/outdev/text.cxx:924:14 > vcl::Window::ImplInitAppFontData(vcl::Window*) vcl/source/window/window.cxx:1177:33 > vcl::Window::ImplInit(vcl::Window*, long, SystemParentData*) vcl/source/window/window.cxx:1168:9 > ImplBorderWindow::ImplInit(vcl::Window*, long, BorderWindowStyle, SystemParentData*) vcl/source/window/brdwin.cxx:1758:13 > ImplBorderWindow::ImplBorderWindow(vcl::Window*, SystemParentData*, long, BorderWindowStyle) vcl/source/window/brdwin.cxx:1790:5 > VclPtrInstance<ImplBorderWindow>::VclPtrInstance<vcl::Window*&, SystemParentData*&, long&, BorderWindowStyle&>(vcl::Window*&, SystemParentData*&, long&, BorderWindowStyle&) include/vcl/vclptr.hxx:281:39 > WorkWindow::ImplInit(vcl::Window*, long, SystemParentData*) vcl/source/window/wrkwin.cxx:52:38 > WorkWindow::WorkWindow(vcl::Window*, long) vcl/source/window/wrkwin.cxx:95:5 > VclPtr<WorkWindow> VclPtr<WorkWindow>::Create<vcl::Window*&, long&>(vcl::Window*&, long&) include/vcl/vclptr.hxx:131:46 > (anonymous namespace)::VCLXToolkit::ImplCreateWindow(VCLXWindow**, com::sun::star::awt::WindowDescriptor const&, vcl::Window*, long) toolkit/source/awt/vclxtoolkit.cxx:1195:42 > (anonymous namespace)::VCLXToolkit::ImplCreateWindow(com::sun::star::awt::WindowDescriptor const&, long) toolkit/source/awt/vclxtoolkit.cxx:1306:22 > (anonymous namespace)::VCLXToolkit::createWindow(com::sun::star::awt::WindowDescriptor const&) toolkit/source/awt/vclxtoolkit.cxx:799:12 > non-virtual thunk to (anonymous namespace)::VCLXToolkit::createWindow(com::sun::star::awt::WindowDescriptor const&) toolkit/source/awt/vclxtoolkit.cxx:797:59 > (anonymous namespace)::TaskCreatorService::implts_createContainerWindow(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, com::sun::star::awt::Rectangle const&, bool) framework/source/services/taskcreatorsrv.cxx:268:73 > (anonymous namespace)::TaskCreatorService::createInstanceWithArguments(com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) framework/source/services/taskcreatorsrv.cxx:165:28 > non-virtual thunk to (anonymous namespace)::TaskCreatorService::createInstanceWithArguments(com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) framework/source/services/taskcreatorsrv.cxx:133:74 > framework::TaskCreator::createTask(rtl::OUString const&) framework/source/classes/taskcreator.cxx:112:63 > framework::Desktop::findFrame(rtl::OUString const&, int) framework/source/services/desktop.cxx:951:28 > non-virtual thunk to framework::Desktop::findFrame(rtl::OUString const&, int) framework/source/services/desktop.cxx:920:61 > framework::LoadEnv::impl_loadContent() framework/source/loadenv/loadenv.cxx:1017:50 > framework::LoadEnv::startLoading() framework/source/loadenv/loadenv.cxx:379:20 > framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) framework/source/loadenv/loadenv.cxx:165:14 > framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) framework/source/services/desktop.cxx:597:12 > non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) framework/source/services/desktop.cxx:583:64 > (anonymous namespace)::LpSolverTest::setUp() sccomp/qa/unit/lpsolver.cxx:45:67 ... Change-Id: If46d9b82225a70caa9ad2f17fbeb99c6adc63990
2016-11-04tdf#41542 globally allow padding without borders: layoutJustin Luth
Styles with borders do not have a requirement for visible borders in order to apply padding in the ODF specs. This was only an implementation design, so remove that layout restriction. So, padding will be allowed now for any border (not just textframes/cells) and it will be allowed for any format (not only those marked with the compatibility setting AllowPaddingWithoutBorders - which is now redefined to indicate whether the UI allows creating borderless padding). The global UI implementation to allow creating these types of documents will come in 5.4. Allow the layout already in 5.3 to enhance compatibility between supported versions. Change-Id: I75bab7cbfff23bf70406123f8531e2fea352ddda Reviewed-on: https://gerrit.libreoffice.org/30434 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-04sw: remove documentation for removed HasOtherCnt_impl()Miklos Vajna
Change-Id: Ib3a5c7116b1a877cfa33ca248b5a9b857f0a2999
2016-11-04tdf#103626 Workaround for AppIcon recursionJan-Marek Glogowski
Change-Id: I6d39d719ad0afb593fec15c9213cc5906c711cbc Reviewed-on: https://gerrit.libreoffice.org/30534 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-11-04-Werror=unused-functionStephan Bergmann
Change-Id: I33790862cfe40693921d07182ccf4645c3ef28a3
2016-11-04use aggregate initialisation instead of memset for arraysJochen Nitschke
Change-Id: I084dee370e5c1096e51b8ff4073443c719688469 Reviewed-on: https://gerrit.libreoffice.org/30517 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-04convert Image manual refcounting with std::shader_ptrTomaž Vajngerl
Change-Id: I9a086d4a5d2f1b0d1afa3afd155eadcb2ae62ab5 Reviewed-on: https://gerrit.libreoffice.org/30543 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-11-04vcl: extract PDFWriter::GetDateTime() from PDFWriterImplMiklos Vajna
And use it in xmlsecurity when signing an existing PDF. This is especially important on Windows, where the PKCS#7 blob doesn't have an (unsigned) timestamp. Change-Id: I4051dc19a43f8f8114d9f4d02309f28d6754e9ae
2016-11-04Upgrade libxmlsec to 1.2.23Miklos Vajna
Obsoletes xmlsec1-win32-fix-undeclared.patch.1. Change-Id: I11cd52aebbe5ab224de9ab00b74c02abb46296f6 Reviewed-on: https://gerrit.libreoffice.org/30539 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-04loplugin:defaultparamsJulien Nabet
Change-Id: I3436df5ebfe0ef4bca6d44ba426f26911482bbcb Reviewed-on: https://gerrit.libreoffice.org/30557 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-11-04tdf#91222 VclBuilder constructor cleanupmelikeyurtoglu
Change-Id: I619cb50c3475519921ffd318b32875ae4ff2c0b8 Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/30545 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-04loplugin:unnnecessaryvirtual in vclNoel Grandin
Change-Id: Ifa8bfafb2e527ce5976f3bd310d107cb2840a5f6 Reviewed-on: https://gerrit.libreoffice.org/30531 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-04update loplugin:unnnecessaryvirtual to handler destructorsNoel Grandin
and update modules writerfilter..xmloff with the resulting changes Change-Id: I54d19c22ddb0ff579b32e4934d266c925b19305c Reviewed-on: https://gerrit.libreoffice.org/30530 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-04loplugin:unusedmethodsNoel Grandin
Change-Id: Ie1f840c3ec9a2d5888f95cf05e531a8a9464bf2e Reviewed-on: https://gerrit.libreoffice.org/30524 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-04Font features are not a Graphite-only featureKhaled Hosny
We parse features appended to font names in CommonSalLayout as well, so code that takes care of their presence (striping them when searching, hashing, etc.) should not be dependent on the old Graphite support or it will not work when old Graphite is disabled (e.g. on macOS). Change-Id: If040782a86ec76d3743baf4d2b1d7a194e8e13f2
2016-11-04Misplaced #endifKhaled Hosny
Change-Id: I199cf879c13cdd65ec9b6f1dbfef9b615bf8cefc
2016-11-03Resolves: tdf#103684 calculate status bar functions across sheetsEike Rathke
Also trigger recalculation when additional sheets are selected or deselected. Change-Id: I259396a3e30c5653ac252b7bb2eb6a0a9405d6cc
2016-11-03tdf#88821: Implement support for <meta charset="..."> for HTML import.Jan Holesovsky
The editengine HTML import was not handling it at all, and consequently not setting the right encoding when importing HTML in Calc. Change-Id: I3ca3dd20f36cfb579fb7ae4cd3da63a69d97601e
2016-11-03tdf#88821: Set the encoding correctly for HTML files with a BOM.Jan Holesovsky
BOM (Byte Order Mark) in the HTML file changed the underlying eSrcEnc encoding, but did not actually update the rtl_TextToUnicodeConverter hConv. Subsequent changes of eSrcEnc in SetSrcEncoding() (triggered by 'content="application/xhtml+xml; charset=UTF-8"' in the HTML file) were then ignored (eSrcEnc was already set to UTF-8), and the parser was happily using the old (Windows-1250) hConv. Change-Id: If432d59891d51c6abe3517e325ed73057d0f8610
2016-11-03there is a function for that: CalcLineSpace(xx, bEvenIfNoLine)Justin Luth
Change-Id: Ideeb031f20611bd9d2a01343bc75e1d0510ad6e9 Reviewed-on: https://gerrit.libreoffice.org/30513 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2016-11-03tdf#93825: Missing accessibility events when selecting/deselecting cellsTamás Zolnai
Change-Id: I407f585354e78fb47a76561455ac67bb567c2771
2016-11-03tdf#89870: Add config option for layout engineKhaled Hosny
The env variable takes precedence. Change-Id: I273ec867725dd012b005d49fbfaa1dc27203c021
2016-11-03RepositoryExternal.mk: fix poppler linking on UbuntuMichael Stahl
need to link poppler static library *before* jpeg Change-Id: I0fd2abc12c93432715a02a3a567349abda4f990b
2016-11-03svx: add missing ~CONVERT_TWIPS mask in SvxPageItem::PutValue()Miklos Vajna
With this, it's possible to use AttributePage.* keys in macros. Change-Id: I3f0b1ea8fb6274e7c18511c2e80774205206a2ba
2016-11-03SafeModeDialog: Adapt label to realitySamuel Mehrbrodt
Change-Id: I649b1f1f9b8f5c50e69f2cd4228394cfa4d2974a
2016-11-03Fix some commentsSamuel Mehrbrodt
Change-Id: Ie74eaead67620decf9c9b954be1d13a8e5f400c6
2016-11-03SafeModeDialog: Improve descriptionSamuel Mehrbrodt
Change-Id: I86f4a322f3d68caafcfe206e2d0f2164bc789bd8
2016-11-03Disable gbuildtoide test on macOS, tooTor Lillqvist
Change-Id: I630fd447992ada459190acd1ee310bd2d38820b9
2016-11-03update deps for libzmfDavid Tardon
Change-Id: I627b3037d7e2dcecfed496068abf697c3258480d
2016-11-03xmlsecurity PDF sign: enable unit tests on WindowsMiklos Vajna
Now that the mscrypto part of PDFDocument::ValidateSignature() is implemented it's possible to run these tests on Windows as well, provided the machine has at least one signing certificate installed. Also fix a race, where the workdir of the signing test was used by the pdfsigning test. Change-Id: I80bbfbb5dc4baa400f9a6b85961883a247b0f22b
2016-11-03Use a single method of converting between points and 100th mm in starmathStephan Bergmann
The SmFormat ctor (starmath/source/format.cxx) uses SmPtsTo100th_mm(12) to initialize aBaseSize, resulting in a height of 422 100th mm. Getting that value (and writing it out to a file) through SmModel::_getPropertyValues mapped back to 12 point, but in turn setting that value (as read from a file) through SmModel::_setPropertyValues resulted in a height of 423 100th mm. That, in turn, caused SmDocShell::GetSize (starmath/source/document.cxx) to compute diverging sizes, so e.g. clicking into an OLE-embedded formula in a Writer document caused the Writer document to be marked as modified (as the embedded formula's size had changed). Change-Id: Ia90654aeaaf779690997b5c3bb868b193eaf46c6
2016-11-03RepositoryExternal.mk: really fix jpeg buildMichael Stahl
Change-Id: I1969db554d156e6af0975d03013ea4f7c10d839f
2016-11-03SafeModeDialog: Better grouping of optionsSamuel Mehrbrodt
Disable/Deinstall extensions are mutually exclusive, so group them appropriately Change-Id: I6dc9c53ef4c18103c7521d494a769d522b0412dd Reviewed-on: https://gerrit.libreoffice.org/30522 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-03SafeModeDialog: Improve labelsSamuel Mehrbrodt
Change-Id: If90b25e569a8feaa86e5c43da5966d5314cf0f14 Reviewed-on: https://gerrit.libreoffice.org/30521 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-03SafeModeDialog: Fix enabling/disabling of widgetsSamuel Mehrbrodt
Change-Id: I7133b64f975fa8e68550d41056b689dfc18cf172 Reviewed-on: https://gerrit.libreoffice.org/30520 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-03SafeMode: Add indicator to window title when in Safe ModeSamuel Mehrbrodt
Change-Id: I1d8350315768093b4c4af1cd8b732602c5217edb Reviewed-on: https://gerrit.libreoffice.org/30518 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-03SafeModeDialog: Allow to create zip file from profileSamuel Mehrbrodt
Change-Id: I4296d1cf5058be359ffed46745673cf26eba3375 Reviewed-on: https://gerrit.libreoffice.org/30479 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-03Bin the XSecController::m_pErrorMessage field as it was never usedTor Lillqvist
It was only assigned to. Some follow-up simplification. Change-Id: I3b522064e946667d3a4c8fb82ee40bd0d44dd569
2016-11-03Fix external libjpeg buildJan-Marek Glogowski
Change-Id: I952dd39559cff18dc7850b62915405954eac2fd7
2016-11-03Bin some useless commentsTor Lillqvist
No need to have a comment saying 'write signatures' when calling a function that is called WriteSignature(). (Actually, the function name is slightly misleading, as it says 'signature' in singular while what it actually does is write multiple signatures, if present.) Also drop some leftover comments that were related to code that was commented out already in 2004 or 2007 and removed completely in 2010. Change-Id: I7a53b3eabb81fc03c66e746f78267be4c1751b0f
2016-11-03loplugin:unusedmethods unused return typesNoel Grandin
Change-Id: I88204bca60dd1e299b040c52bc87e500cbfaa930 Reviewed-on: https://gerrit.libreoffice.org/30519 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03Add helper for creating zip filesSamuel Mehrbrodt
Change-Id: I8b49b74622bf4d671d640e4cd06dc2da348ee222 Reviewed-on: https://gerrit.libreoffice.org/30478 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-03coverity#1371313 Missing move assignment operatorCaolán McNamara
Change-Id: I07a9d7fe837c18e66b4a2a57186f1f9b0d44daee
2016-11-03configure: fix LIBJPEG_LIBS, jpeg-turbo can also be used on LinuxMichael Stahl
Change-Id: I710f8ba31b6f780e3fb1d174d9ea21f270f55264
2016-11-03Clarify comment to mention also HAVE_FEATURE_OPENCLTor Lillqvist
Change-Id: Ibca8ceedd8c01b4d12ccd9c29838f545fc234347
2016-11-03poppler: remove obsolete ubsan patch hunkMichael Stahl
With eea709f67d91e271e3df37e6c6724b7b5870b1ee "poppler: build against libjpeg" the poppler internal JPEG code is no longer used. Change-Id: I018a53a495ec505af92bb9b1c1a0c42e0a4f35b8
2016-11-03Related: rhbz#1390607 our side of per-monitor fullscreen on waylandCaolán McNamara
keep the move window to monitor code, so under X, gnome#773857 isn't a problem when gnome#772525 fix is available this presumably will then work under wayland Change-Id: I50cfe7ede8a4f1404c26d174ef3c5bb920eb5044
2016-11-03Bin unused XSecuritySAXEventKeeper::cloneElementCollectorTor Lillqvist
Change-Id: Icc0ead769fa0a052f7d4dfbc825c96dbb513b33f
generated by cgit (git 2.34.1) at 2025-02-09 04:18:12 +0000