summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-11-03loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I572b83949c7e643536b7d62567760546509e4d9f Reviewed-on: https://gerrit.libreoffice.org/30514 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03tdf#102308 sw redline tooltip: show secondsMiklos Vajna
Commit d9dca1eef91faa710112ffd20a2b2d36b48a9287 (tdf#102308 sw: improve redline timestamp precision) improved the manage changes dialog to show seconds of the redline timestamps, do the same with tooltips, when the mouse is hovered over a redline portion. Change-Id: I6ec42db49cb93d8bce0cdee02e37d871f8e7e2ce Reviewed-on: https://gerrit.libreoffice.org/30515 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-11-03tdf#103633 avoid segfault in a11yDavid Tardon
This partially reverts commit 8e8a88ec1ad02c153ae3c7653edc81716dc91b7a "loplugin:unusedfields". Change-Id: Id95a46374ed2b35e05dc32a8759e5db01829f050
2016-11-03Bin pointless differentiated exception handlingTor Lillqvist
All the catch blocks for classes derivved from uno::Exception contained the same single statement as the catch block for uno::Exception itself. Change-Id: Ic33b432416abfda7557862d25237dc7221585327
2016-11-03xmlsecurity PDF verify: initial Windows supportMiklos Vajna
The timestamp isn't extracted yet, but the digest match is already checked correctly and the certificate is exposed. Change-Id: Ieca002a5c4ca0b96f4dc397c460adb7f88f5ffc7 Reviewed-on: https://gerrit.libreoffice.org/30499 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-03Add FIXMETor Lillqvist
Change-Id: I4ebdca6a7d09a228122842a79b217ac2611a7c06
2016-11-03tdf#95341: Make last item of menus clickable againXisco Fauli
Regression from 4f1dca5083c5a301181786b563b165f19a9dec7f Change-Id: I7b7f3594499cd049ae59064da244e3f82dff7757 Reviewed-on: https://gerrit.libreoffice.org/28617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-11-03tdf#100352 Classification: Update French translationLaurent Balland-Poirier
Change-Id: Ie5efebfe4df73adca51638c85ba52e7901eac139 Reviewed-on: https://gerrit.libreoffice.org/30182 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-11-03Revert "remove unnecessary casts"Noel Grandin
This reverts commit fa80dae9a79a7414af8adcb91bc04dfff13bbb63. because current Clang master complains with /home/noel/libo3/svl/source/items/itemset.cxx:189:26: error: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Werror,-Wvarargs] va_start( pArgs, nNull ); ^ /home/noel/libo3/svl/source/items/itemset.cxx:176:89: note: parameter of type 'sal_uInt16' (aka 'unsigned short') is declared here SfxItemSet::SfxItemSet(SfxItemPool& rPool, sal_uInt16 nWh1, sal_uInt16 nWh2, sal_uInt16 nNull, ...)
2016-11-03tdf#91222 VclBuilder constructor cleanupmelikeyurtoglu
Change-Id: I53bca2a9113862b8e7058937e231721c5f81a9de Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/30511 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03tdf#91222 VclBuilder constructor cleanupmelikeyurtoglu
Change-Id: Ief4a9dfc0e0a2dad04c3ac9f1840b823fd9357de Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/30507 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03remove unnecessary castsJochen Nitschke
Which IDs are always sal_uInt16 and likely passed from defines Change-Id: I134358289ccd338ef1ff6ba963e25a524e790f4e Reviewed-on: https://gerrit.libreoffice.org/30498 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03bin nranges.*, move remaining functions into itemset.cxxJochen Nitschke
Change-Id: I1b88d98e00415e9c32a48486912d577a00fbfbda Reviewed-on: https://gerrit.libreoffice.org/30486 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03remove unused BiffInputStreamNoel Grandin
Change-Id: If34bc1d5ea0e0153991d4891b88550e471b4ec07 Reviewed-on: https://gerrit.libreoffice.org/30489 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03merge ScBiffReader and ScQProReaderNoel Grandin
Change-Id: I7267ffb4ad5c874d6c836a8d6ab823d63f8e2610 Reviewed-on: https://gerrit.libreoffice.org/30488 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03remove pParentFrame from SfxFrameNoel Grandin
Found by the singlevalfields loplugin. Dead as least as far back as commit 93a7b558588be1f12e137329548b706daccc07df Author: Frank Schoenheit [fs] <frank.schoenheit@sun.com> Date: Fri Nov 27 21:16:24 2009 +0100 [CWS autorecovery] merged SfxTopFrame into SfxFrame SfxTopFrame was the only class deriving from the abstract class SfxFrame, so both can effectively be treated as one class. Arguably when that commit was done, SfxFrame should also have been renamed to SfxTopFrame, since that it was it now seems to be. Expanding the nullptr value off that field means that: SfxFrame::GetTopFrame always return this SfxFrame::IsParent always returns false SfxViewFrame::GetTopFrame is now the same as SfxViewFrame::GetFrame SfxViewFrame::GetParentViewFrame now returns null Change-Id: Iac088fa485c3d7299d1553845ced2f5ced3c85f2 Reviewed-on: https://gerrit.libreoffice.org/30485 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03starmath: Remove unnecessary overridingTakeshi Abe
Change-Id: If64c3a1dbb27e85e2562cca78b608250b7e90c6d Reviewed-on: https://gerrit.libreoffice.org/30480 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-03Omit the default comparator std::less<key_type>Takeshi Abe
Change-Id: Iaf873fc8b5ca673d5e829be33074dffd8680ae03 Reviewed-on: https://gerrit.libreoffice.org/30452 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-03Revert "Revert "Enable the new text layout engine by default""Khaled Hosny
This reverts commit 3950166877bf1308f9e449992e20b558342af825. Change-Id: Ie22a99885a23d44a9870fcd286bee4ccf10c53ac Reviewed-on: https://gerrit.libreoffice.org/30505 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2016-11-02No XFastPropertySet hereTor Lillqvist
It has been commented out since creation in 2004. Change-Id: I25ff3ff953430ecbb84fecd3228e662a9c3e1276
2016-11-02jpeg-turbo: resolve some conflicts to fix poppler buildMichael Stahl
poppler uses both windows.h and jpeg headers, so runs into the conflict between Win32 definitions of boolean, INT16, INT32, and jpeg's. Tweak jpeg-turbo headers so it uses the Win32 definitions. Change-Id: I2dc2b35a8d08d521c95494e528c1e47ccbfc390a
2016-11-02Fix GetGlyphBoundRect() on macOSKhaled Hosny
The Y sign should be reversed to match VCL, apparently it was either unused on macOS before CommonSalLayout or it was wrong all along. This was the source of CppunitTest_svgio failure on macOS with CommonSalLayout. Change-Id: I3108aab7b6780c912e86e5591ca0f41ea437137b
2016-11-02Add FIXMETor Lillqvist
Change-Id: I37e614f6dfa0778cb126a6de282921a15417af1c
2016-11-02coverity#1375798 Uncaught exceptionCaolán McNamara
Change-Id: Id7e968170a038d9316503ee796cfd6a99e9fc3ae
2016-11-02widgetery warningsCaolán McNamara
Change-Id: I5f9c8011a43e2b15b9b2f58772f6f08ad103f4aa
2016-11-02poppler: build against libjpegMichael Stahl
Albert Astals Cid points out that --disable-libjpeg causes poppler to use internal JPEG code instead, which is not actively maintained. Add LIBJPEG_CFLAGS / LIBJPEG_LIBS to config_host.mk and patch poppler to respect LIBJPEG_LIBS. Change-Id: Id19a62a9bd9dc41fee5e8e43e2798e515aacc299 Reviewed-on: https://gerrit.libreoffice.org/30496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-11-02add missing gb_ExternalProject_use_externals, icuEike Rathke
Change-Id: Iaaa3363f315eb88f3be48e29bb82917695c3cfe0
2016-11-02add missing dependency to gb_Library_use_externals, icu_headersEike Rathke
Change-Id: Ia414b02c52f73724df6829431d090a18e76baa68
2016-11-02curl: upgrade to version 7.51.0Michael Stahl
- fixes about a dozen CVEs - tweak curl-7.26.0_win-proxy.patch: there is a "checksrc" thing now in curl that fails the build with: warning: use of strtok is banned (BANNEDFUNC) so use strtok_s instead (which is MSVC's name for standard strtok_r) - use Makefile.vc12 instead of Makefile.vc10 - remove strequal.obj from Makefile.vc12, it does not actually exist Change-Id: Ie2da64980d88c72b0c902376ffc01abf97a7bc91 Reviewed-on: https://gerrit.libreoffice.org/30484 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-11-02upgrade to ICU 58Eike Rathke
Change-Id: I4a992447df65b337721a2a2627d974172a14cba5 Reviewed-on: https://gerrit.libreoffice.org/30487 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-11-02check only Column elements when computing column indexDavid Tardon
Change-Id: I4856227c05e97daefbae7e98c0e9d70f84e1a2b4
2016-11-02check only Row elements when computing row indexDavid Tardon
Change-Id: I3bd1b0749f8889cbd1d92a0edfa84d754e888f03
2016-11-02rhbz#1390776 check only Row elements when computing row indexDavid Tardon
Change-Id: Ic5ef3971829597170acfdc0606b3c0f16c42be04
2016-11-02KAB loplugin:unnecessaryoverrideJan-Marek Glogowski
Change-Id: I62e6f2488554df663e0ae6c72b6af9e2ec9976a1
2016-11-02let menu button launch arbitrary floating windowsCaolán McNamara
and not just menus, this is like how the gtk equivalent can launch popovers Change-Id: I53ae96aab0c51d75405dba15ab8080d7315471e3
2016-11-02vcl: implement PDFWriter::Sign() on WindowsMiklos Vajna
Move Windows-specific code from PDFWriterImpl::finalizeSignature() to PDFWriter::Sign(), this way the pdfverify cmdline tool can sign a previously unsigned file. Change-Id: I1144e228bf8f12a284c3fc32fd3e74c355855ff3
2016-11-02Access2Base - Simplify CopyObjectJean-Pierre Ledure
Avoid Field object buffering in CopyObject as it is now done in the Recordset class Change-Id: I35ee9e953e27554cb361adbb22baa619e4b73aaf
2016-11-02Remove noise comment, add FIXMETor Lillqvist
Change-Id: I1ad8ff94744e3a4b0844a04eabb7f19a3b15bb1a
2016-11-02Access2Base - Buffer field objects in recordsetJean-Pierre Ledure
Field objects are buffered in a _Fields() array, part of a Recordset instance, to improve speed and memory consumption Change-Id: Iac732ab5a1db24341aa30c3c934853a21c76e2e4
2016-11-02unit test for tdf#99291, empty array elements match 0.0, not emptyEike Rathke
Change-Id: I65cac442583ecd90831ebea01d2be6c0b1e60b9a
2016-11-02disable gbuildtoide test on Windows as CI builders are unstableBjoern Michaelsen
Change-Id: Ib5eb4fece2bae3e04089f2389198df800620e6f8 Reviewed-on: https://gerrit.libreoffice.org/30483 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-02gtk3: grabs on floating window inside floating windowCaolán McNamara
under gtk3 with the floating window of the listbox inside the color floating window if the toplevel window is dismissed the focus doesn't remain locked to its parent, but skips to the grandparent so grab and ungrab only once elements in the hierarchy Change-Id: I14b1b8888671634c0c01c6416493f912e4abd2f9
2016-11-02gtk3: allow float grab inside float grabCaolán McNamara
this is so that the floating window belonging to the listbox inside the floating window color popup will track the mouse as it moves up and down over the menu. Change-Id: If108b5b3866fdbc04513c48c8d859bedd3867379
2016-11-02gtk3: just close the toplevel float if it corresponds to the event frameCaolán McNamara
Change-Id: I489acc288fb1c9564f208e024dd5aa3ae9660a49
2016-11-02support unfocused float window inside a focused float windowCaolán McNamara
if a floating window is inside a floating window, go up the floating windows until we find the first one that accepts focus, rather than pass the input to the toplevel frame Change-Id: I6c2a3de02ab436b8441b1fec15d51dec4f96c931
2016-11-02xmlsecurity PDF verify: add support for object streamsMiklos Vajna
Adobe Acrobat uses object streams (PDF 1.6) when it signs a PDF exported from LO (PDF 1.4), with this we can verify that signature. If the PDF had at least one signature in LO, then the doc is not upgraded from PDF 1.4, so that was working already. Change-Id: I54b4447ca965a8ba1ffc69bde228ab6f0bda59ee
2016-11-02getNonLayoutRealParent is unusedCaolán McNamara
Change-Id: Ie003bc7ccc9985162ea52a1b0164118d9c2ce437
2016-11-02lock tab-cycling inside the WB_DIALOGCONTROL widgetCaolán McNamara
activate the color selector in the toolbar in the sidebar panel, press tab to cycle between its widgets, when it hits the bottom it will not return to the first widget, but escape out of the floating window into the next sibling of the toolbar Change-Id: I806fd4d94c477e9cfb2ea238830f7b646ea274d2
2016-11-02drop SvxColorWindow::ResizeCaolán McNamara
Change-Id: I22ed6ace464cdfd4ee0c12e8269d8141efce57a6
2016-11-02move SvxColorWindow to include/svxCaolán McNamara
Change-Id: Ie2e11c8582cbb204178c0616580f942d1ce773fb