summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-10-25Use std::signed_integral conceptStephan Bergmann
...which, unlike std::is_signed, also requires that T is an integer type, not just any arithmetic type, but which appears to fit well here anyway. But LLVM 12 libc++, which is apparently used by Android builds, only provides a bare-bones <concepts> that lacks std::signed_integral (among others), so for now introduce o3tl/concepts.hxx providing what's missing (incl. std::integral and std::unsigned_integral, for some kind of consistency). Change-Id: I1c37d37fa1b57b5e3bf24c9e44f3973003905cb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158406 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-25tdf#155682 sw floattable: fix DOCX with big pictures causes endless loopMiklos Vajna
The bugdoc had a floating table in the header that overlapped with full-page, as-char anchored images in the body text, leading to a layout loop. The trouble is that the body text was broken into 2 lines: the first line just had fly portions for the area where the in-header floating table was rendered and then the second line hosted the actual image. But then this image didn't fit the remaining space, so it moves to the next page. And this happened again and again. Fix the problem by keeping in-header anchored floating tables inside the boundary of the header, this way the body text still doesn't overlap with the floating table, but the space available to the body text doesn't have to contain fly portions. Which means we don't try to move the image to a next page, so there is no loop. Note that the IsFollowingTextFlow flag is already ignored in some cases (e.g. sw/qa/extras/ww8export/data/tdf128700_relativeTableWidth.doc), so this doesn't break the use-case when a footer provides an anchor position for some text on the left/right margin. In that case the footer height is still unchanged as it should be. Change-Id: Id9e80140af3123d52b0fea2f96fc19c150c8e736 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158413 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-10-25CppunitTest_sw_ooxmlexport10: avoid preTest()Miklos Vajna
This keeps all code of a test in a single place, if we don't trigger the preTest() magic. Change-Id: I13254fd11be344f84e0a8bb8eab4b93d7c1a8825 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158400 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-10-25tdf#157790 invert alpha maskPatrick Luby
Due to commit 81994cb2b8b32453a92bcb011830fcb884f22ff3, the alpha mask needs to be inverted. Change-Id: I4771c5f6f3a08fb210b62a0533df895a4a476058 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158410 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-25Support conditional loading of Apache Parquet files into CalcKohei Yoshida
Also, use orcus::create_filter() and simplify the logic a bit. This requires orcus 0.19.1 or newer. Note that this change makes it possible to load Apache Parquet files if and only if orcus has been built with the parquet import filter enabled. Using orcus without the parquet import filter enabled will not break the build or run-time behavior; you just can't load parquet files. Change-Id: I9f8820998b7b0667d1e7cd532c32b1c7e55ca999 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158411 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2023-10-25Upgrade liborcus to 0.19.1Kohei Yoshida
Change-Id: I2190419e88323bbf000602a7762e850a33b5dfdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158409 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2023-10-24Use requires-clausesStephan Bergmann
Change-Id: I27c990f27023aba5e77c6b406d7dbdcc898054ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158405 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-24Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 2250a507ab35df482392e9f1fe297bb57f300af9 - tdf#153986 Drop "Numbering" from the label in bullet list Format/Tools Change-Id: Id7b604a6c1532b4799c7ec658b1a1f9e25b4c972 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158408 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-10-24Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to e423f2a7995db5bd4da002309afdd5efaf06af21 - tdf#144444 tdf#155877 Toggle edit points + toggle edit points Change-Id: Ieee6b0030ee4b001700443aa35ac87018ec1a7f5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158399 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-10-24tdf#157028 vcl: PDF export: inline attribute dictionariesMichael Stahl
There seems to be no reason why SE attribute dictionaries are separate objects, they could just be inline, which saves a little space (1%) and more importantly the PDF file is easier to read with less clutter. Change-Id: Iaaea2432313c0b710edabecae32545205f4f495e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158392 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-10-24tdf#153519 make TreeListEntryUIObject saferNoel Grandin
Do not store a raw pointer to an object that go away. Consequently we can remove the various sleep() hacks Change-Id: I3200c26b3a2a4eb7592cb2e5c6af64d6b739d1f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158390 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-24suppress more IndexHint accessibility warningNoel Grandin
Change-Id: I45bc0bf74f4ebeeb4155006e67309cd476ebc3c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158388 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-24Remove unused entry from log-areas.doxsahil
Change-Id: I1d7bb4183c45f752cddf118411259695a294b2cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158371 Reviewed-by: Hossein <hossein@libreoffice.org> Tested-by: Hossein <hossein@libreoffice.org>
2023-10-24tdf#156565 sw: PDF/UA export: only one Link ILSE per linkMichael Stahl
The problem is that for a hyperlink, multiple Link SEs are created, but only one Link annotation; the Link SEs all point to the annotation but the annotation can only point to one Link SE. So try to create only one Link SE for a hyperlink, similar to commit ee3c3fcf5c48964f7bc1d64484409f072c614866. This could be further subdivided by Spans when formatting properties change but it looks complicated and rarely needed. Change-Id: I7d158b599ec744b03e78eeca88d717183f2ba1dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158387 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-10-24gtk3 a11y: Take current type into account when setting new valueMichael Weghorn
This is the gtk3 variant of Change-Id I8674fc37798491fd0b57543acb491edbd4a5a056 qt a11y: Take current type into account when setting new value See that change's commit message for more details. Change-Id: I597220253fa0ca61252706915ad009b8846bbd42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158383 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-24qt a11y: Take current type into account when setting new valueMichael Weghorn
As the `XAccessibleValue` documentation [1] describes, the underlying implementations can used different types of numerical values. Qt's `QAccessibleValueInterface` uses `QVariant`, so could in theory also support different numerical types. The AT-SPI Value interface however always uses double. [2] So far, `QtAccessibleWidget::setCurrentValue` was also always extracting a double value from the `QVariant` param and creating an `Any` from that. This however would result in any `XAccessibleValue::setCurrentValue` implementations assuming to be passed an integer would fail to extract a proper new value from the Any. As an example, selecting a currently checked checkbox (e.g. the "Automatic" checkbox in Writer's "Paragraph" formatting dialog, "Indents & Spacing" tab) in Accerciser's treeview of LO's a11y hierarchy woul result in the checkbox to be unchecked, because Accerciser reads the current and then sets the same value again when selecting an item with its "Interface View" tab active. Prevent that from happening by passing a `sal_Int32`/`sal_Int64` value again if the current value is also using that type. [1] offapi/com/sun/star/accessibility/XAccessibleValue.idl [2] https://gitlab.gnome.org/GNOME/at-spi2-core/-/blob/7cc4cee53ddbd22631fd110f0e5ce045dec2e411/xml/Value.xml Change-Id: I8674fc37798491fd0b57543acb491edbd4a5a056 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158380 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-24tdf#157817 sw: PDF/UA export: fix ToX header sectionsMichael Stahl
The problem was that a P or equivalent element is not allowed as child of a TOC; previously the P was outside/before the TOC because the ToX header was completely ignored but now it starts a SE for the ToC content section before being ignored. Tagged PDF Best Practice Guide suggests putting the header inside a Caption element. Another problem is that if the ToX header is on one page but the first entry in the ToX content section is on the next page, BeginTag() created a new SE for the ToX content section. (regression from commit 033e37b49b5712df19dbfd2c307a102bce620de1) Change-Id: I3c1f8fdda81c1f10198f5eaefc10bcd14f277a8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158298 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-10-24xmloff: document the GutterAtTop Writer settingMiklos Vajna
Change-Id: Ic56d7b3333e50bd6cf0d32d19995b09bf612384c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158381 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-10-24tdf#135921 a11y Send event when toggling listbox checkboxMichael Weghorn
When toggling the state of the checkbox in a listbox/ treelist entry using the mouse or the keyboard, emit a `VclEventId::CheckboxToggle` event and process that in the a11y class that's used for the case where there's just a single checkbox (like in the spelling options dialog), `AccessibleListBoxEntry` by sending a corresponding STATE_CHANGED event on the a11y layer. This makes Orca with the qt6 VCL plugin and NVDA on Windows announce the new value when toggling a checkbox in the Spelling options dialog using either the mouse or the keyboard. As mentioned in the previous commit, Change-Id Ic78f9052d166be0da17a76261a09da02b8a11cd7 tdf#135921 a11y: Toggle listbox item checkbox on space , the case where a listbox entry has multiple checkboxes (like the autocorrect options dialog in Writer) uses different a11y classes and toggling a checkbox there still doesn't result in the new value being announced. Change-Id: I36a2b0a3fa3154279fb06af023fdb96f699fac2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158375 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-24tdf#135921 a11y: Toggle listbox item checkbox on spaceMichael Weghorn
Allow toggling the state of the checkbox in a listbox/ treelist entry using the space key if the entry is currently selected. This aligns it with the behavior for "plain" checkboxes. On the a11y layer, these listbox entries are even exposed just as a checkbox when there's only a single checkbox for the entry (s. `AccessibleListBoxEntry::getAccessibleRole`), like in the Spelling options dialog ("Tools" -> "Spelling", then press the "Options..." button). For the case where there are multiple checkboxes (like in the Writer autocorrect options dialog), the first checkbox will be toggled. Making it possible to toggle any of the checkboxes for that case would need further work, s.a. the the related tdf#135585. (For gtk3, it's possible to use the arrow keys to switch the column, then use the space key to toggle the checkbox.) That scenario also uses a different approach for the a11y layer, not a single `AccessibleListBoxEntry` object as is the case for the tdf#135921 scenario. This change makes it possible to toggle the checkbox, but so far, the new state is not yet announced when a screen reader is running, neither when using the keyboard nor when using the mouse (which was possible without this change already). The event handling that's required for this will be added in a separate commit. Change-Id: Ic78f9052d166be0da17a76261a09da02b8a11cd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158374 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-24ofz: Use-of-uninitialized-valueCaolán McNamara
Change-Id: Id7ae178e687edf9550ea1ccef475e326cbe4de2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158376 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-24vscode-ide-integration: bump C_Cpp.default.cppStandard to c++20Christian Lohmaier
Change-Id: I58b1eb86594c03ab7b6d0426b335bb3132effb8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158360 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-10-24vscode-ide-integration: editor.renderFinalNewline is not booleanChristian Lohmaier
…but tri-state (on/off/dimmed). Also fix missing comma in the debugger config. Change-Id: Iee4de01ccb5c0bb714b78a4fbbcb865b5e8d5b0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158358 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-10-24tdf#153519 Another TreeListEntryUIObject heap-use-after-freeStephan Bergmann
...similar to the one addressed with the commits leading up to 9a23ded27470a4c57015e9e5d686259a60d464f2 "Fix thinko when to sleep" Change-Id: I8114c6647e06ceb202cd790af691ecc18e9d4e17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158373 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-24Extend SAL_NON_APPLICATION_FONT_USE documentationStephan Bergmann
Change-Id: Ib3b65436d0703b0e4e691a00ef16b99c561658b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158370 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-24tdf#155040 sw floattable, RTF: fix table is overlapped by subsequent inline oneMiklos Vajna
The document had overlapping text on load since commit 05425f73bfa41d3f7591461e2ad0beb4fafc39b4 (sw floatable: teach the RTF import about SwFormatFlySplit, 2023-04-21). Interestingly the DOCX equivalent was fine, there the inline table is shifted down, below the floating table, so the overlap doesn't happen. Fix the problem by moving the AddVerticalFrameOffsets=true code from the DOCX filter to the shared dmapper, because RTF needs the same. See commit 50223ea6e212b60b7d33839c2753c5601fb50f95 (tdf#98987 sw: add AddVerticalFrameOffsets compat mode, 2016-03-31) for more details about this compat flag. It was already enabled for DOC, too. Change-Id: I948b179c9ec5fa24377014b0e86826568c417b6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158372 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-10-24loplugin:ostr (macOS)Stephan Bergmann
Change-Id: Id40ce74db71f685cc1c459ea2a5b174f3f8862f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158369 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-24Fix typoAndrea Gelmini
Change-Id: Ib2e612960f27d103bd25d14b86fa9eb0c0422669 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158367 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-10-24svx: prefix members of SdrLayerIDSetMiklos Vajna
See tdf#94879 for motivation. Change-Id: Ibac67e7f8535b231f63a01b7e572595f5b91a996 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158368 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-10-24changed sal_uInt8 to BenError (enum)sahil
Change-Id: Ia7cb2f879b7be833d1a5ccf845a8dc8bfb94befd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156900 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-10-24Fix typoAndrea Gelmini
Change-Id: Iac1d0f9a00fe5ccab84da1f1fb033354920341fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158366 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2023-10-24tdf#144444 Use same strings for same commandCosmin Humeniuc
Done during the conference hackfest Change-Id: I04f1dd77ca8866eff44e49d9f90805995cec9840 Change-Id: I53467e4e80f2d82fa126eb9a40ee28f67d7c321f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157187 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-10-24tdf#153986 Drop "Numbering" from the label in bullet list Format/ToolsPowerinno
Changed "Numbering alignment" to "Alignment" also changed "Numbering followed by" to "Followed by". Change-Id: I6230aa8d5abcd6311e527c96d6c3856d96194c88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157195 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-10-24tdf#154052: Change "Level" spinbox to comboboxBaole Fang
Change-Id: I58a50963f95a2c364557a7aa0992f9858ec5d9cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158301 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-10-24tdf#157838 - UI: Part 4 - Unify lockdown behavior of Options dialogBalazs Varga
for Print Page. Change-Id: I724dcbaf8e3ed479aaf053965d2d0e64381e53fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158269 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-10-24tdf#157837 - UI: Part 3 - Unify lockdown behavior of Options dialogBalazs Varga
for View Page. Change-Id: Iac27aa516e4e4a4c1469b0ff465477c44c3a5660 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158250 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-10-24tdf#157702 - UI: Part 2 - Unify lockdown behavior of Options dialogBalazs Varga
for General Page. Change-Id: Ide7c387d1b9f8ebba7f7801cdd69b1e1a93f90e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158196 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-10-24tdf#157700 - UI: Part 1 - Unify lockdown behavior of Options dialogBalazs Varga
for page User Data. Change-Id: I912fe2786ad5e7fc110137dfbcff73ee25fb0fbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158126 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-10-24Fix CppunitTest_sd_import_tests-smartart non_application_font_useStephan Bergmann
sd/qa/unit/data/pptx/smartart-composite-infer-right.pptx replaced some "Calibri Light" with "Noto Sans" sd/qa/unit/data/pptx/smartart-interopgrabbag.pptx replaced some "Calibri Light" with "Noto Sans" sd/qa/unit/data/pptx/smartart-pyramid-1child.pptx replaced some "Calibri Light" with "Noto Sans" sd/qa/unit/data/pptx/smartart-snake-rows.pptx replaced some "Calibri Light" with "Noto Sans" sd/qa/unit/data/pptx/tdf132302_SmartArt_rightArrow.pptx replaced some "Calibri Light" with "Noto Sans" sd/qa/unit/data/pptx/smartart-tdf134221.pptx replaced some "微软雅黑" with "Noto Sans" sd/qa/unit/data/pptx/tdf135953_SmartArt_textposition.pptx replaced some "Calibri Light" with "Noto Sans" sd/qa/unit/data/pptx/tdf145528_SmartArt_Matrix.pptx replaced some "Calibri Light" with "Noto Sans" replaced some "Calibri" with "DejaVu Sans" sd/qa/unit/data/pptx/tdf148665.pptx replaced some "Poppins Medium" with "Noto Sans" sd/qa/unit/data/pptx/tdf148921.pptx replaced some "Tahoma" with "Noto Sans" sd/qa/unit/data/pptx/pptx/tdf149551_SmartArt_Gear.pptx replaced some "Calibri Light" with "Noto Sans" sd/qa/unit/data/pptx/tdf149551_SmartArt_Pie.pptx replaced some "Calibri Light" with "Noto Sans" sd/qa/unit/data/pptx/tdf149551_SmartArt_Pyramid.pptx replaced some "Calibri Light" with "Noto Sans" sd/qa/unit/data/pptx/tdf149551_SmartArt_Venn.pptx replaced some "Calibri Light" with "Noto Sans" Change-Id: Ie224100d024dc4f3321650e33f13ed5a61b444e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158364 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-23Implement PreserveSpaces boolean HTML/ReqIF export filter optionMike Kaganski
This option changes how HTML/ReqIF export handles paragraphs with leading/trailing spaces, or multiple sequential spaces. Normally export may insert newlines every ~256 characters, in place of normal space characters; this relies on default processing of spaces, where leading/trailing spaces are trimmed, and runs of spaces are reduced to a single space. When PreserveSpaces is true, HTML/ReqIF export takes care to not alter spaces inside paragraphs. For that, it checks if paragraphs contain sequences of spaces that normally would be reduced; and for those paragraphs, it adds "white-space: pre-wrap" to style (in HTML), or 'xml::space="preserve"' attribute (in ReqIF). Import of 'xml::space' attribute and "white-space: pre-wrap" style is implemented; when paragraph has these, it keeps the spaces read from HTML/ReqIF intact. Import does not currently support this attribute/style in elements other than 'p'. Change-Id: I62dba5eaf313b965bf37d8fa5e3f5bbb8f5e8357 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158362 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-23tdf#157287: sw_core_txtnode: Add unittestXisco Fauli
Change-Id: I4c14cbe8610dc6426b910f4ef5d96ccc6e7a4604 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158359 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-10-23a11y: Make XAccessibleValue doc more consistentMichael Weghorn
* Align the method names in the documentation to what the acual methods are called (e.g. `getMaximumValue`, not `getMaximumAccessibleValue`). * Use "minimum" and "maximum" consistently, not "minimal" and "maximal" in some places. Change-Id: Idf4f36dca118a614b04a4b958e97d225f70dde0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158347 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-23a11y: Don't throw exception on valid list box entry action indexMichael Weghorn
`checkActionIndex_Impl` was previously throwing an IndexOutOfBoundsException for any index other than 0. The // only three actions comment in there was only adding to the confusion... Convert that helper function to a method of the class and take the actual count of actions into account. Also drop the misleading `ACCESSIBLE_ACTION_COUNT` define altogether, and just return 1 at the only remaining place using it. This fixes a crash seen with the qt6 VCL plugin and Orca running when opening the spelling options dialog ("Tools" -> "Spelling", then press the "Options..." button). 1 __pthread_kill_implementation pthread_kill.c 44 0x7f29908a80fc 2 __pthread_kill_internal pthread_kill.c 78 0x7f29908a815f 3 __GI_raise raise.c 26 0x7f299085a472 4 __GI_abort abort.c 79 0x7f29908444b2 5 ?? 0x7f29904a09db 6 ?? 0x7f29904affaa 7 std::terminate() 0x7f29904b0015 8 __cxa_throw 0x7f29904b0268 9 (anonymous namespace)::checkActionIndex_Impl accessiblelistboxentry.cxx 49 0x7f29562aeb82 10 accessibility::AccessibleListBoxEntry::getAccessibleActionDescription accessiblelistboxentry.cxx 770 0x7f29562b2b9b 11 QtAccessibleWidget::actionNames QtAccessibleWidget.cxx 805 0x7f297c84a8d7 12 QAccessibleBridgeUtils::effectiveActionNames qaccessiblebridgeutils.cpp 25 0x7f297b6c90a5 13 AtSpiAdaptor::actionInterface atspiadaptor.cpp 1862 0x7f297b6e2cc0 14 AtSpiAdaptor::handleMessage atspiadaptor.cpp 1438 0x7f297b6de432 15 QDBusConnectionPrivate::activateObject qdbusintegrator.cpp 1438 0x7f2979ec0ecb 16 QDBusActivateObjectEvent::placeMetaCall qdbusintegrator.cpp 1594 0x7f2979ec1bb0 17 QObject::event qobject.cpp 1446 0x7f297c02116e 18 QApplicationPrivate::notify_helper qapplication.cpp 3295 0x7f297a59d714 19 QApplication::notify qapplication.cpp 3246 0x7f297a59d524 20 QCoreApplication::notifyInternal2 qcoreapplication.cpp 1131 0x7f297bfa23ba 21 QCoreApplication::sendEvent qcoreapplication.cpp 1572 0x7f297bfa2ead 22 QCoreApplicationPrivate::sendPostedEvents qcoreapplication.cpp 1937 0x7f297bfa3ea6 23 QCoreApplication::sendPostedEvents qcoreapplication.cpp 1794 0x7f297bfa37ae 24 postEventSourceDispatch qeventdispatcher_glib.cpp 244 0x7f297c3b9108 25 ?? 0x7f29835111b4 26 ?? 0x7f29835142d7 27 g_main_context_iteration 0x7f29835148f0 28 QEventDispatcherGlib::processEvents qeventdispatcher_glib.cpp 394 0x7f297c3b999d 29 QXcbGlibEventDispatcher::processEvents qxcbeventdispatcher.cpp 96 0x7f2979c67036 30 QtInstance::ImplYield QtInstance.cxx 421 0x7f297c8c27c6 31 QtInstance::DoYield QtInstance.cxx 432 0x7f297c8c28ef 32 ImplYield svapp.cxx 377 0x7f298732dcc8 33 Application::Yield svapp.cxx 461 0x7f298732ea66 34 Application::Execute svapp.cxx 355 0x7f298732d9bb 35 desktop::Desktop::Main app.cxx 1601 0x7f2990a35716 36 ImplSVMain svmain.cxx 204 0x7f298734d600 37 SVMain svmain.cxx 236 0x7f298734d735 38 soffice_main sofficemain.cxx 94 0x7f2990aa058f 39 sal_main main.c 51 0x5629220af9d4 40 main main.c 49 0x5629220af9ba Change-Id: Ib3ed8616fb539942d9ba0cd60d5607859deb5a7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158344 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-23liborcus(-parser) also needs boost_iostreams - fixes wasm buildChristian Lohmaier
not handling that automatically from the info from the regular build is kinda ugly, probably can be done via RepositoryExternal.mk, but since it was done that way initially after much tinkering, I don't want to invest much time into rewriting the static build stuff just to get rid of the few lines for icu and liborcus .... Change-Id: I2a620426854eb16e2388159bb3bbf1a514872ef9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158267 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-10-23fix wasm build (int vs sal_Int32 mismatch)Christian Lohmaier
error: non-const lvalue reference to type 'sal_Int32' (aka 'long') cannot bind to a value of unrelated type 'int' in file /home/tdf/jenkins/workspace/lo_gerrit/tb/src_wasm/vcl/qt5/QtAccessibleWidget.cxx (since refactoring in 15a6e23c4fc160c50a316da3d18980a02fc10ce8 ) Change-Id: I2689701839ba18b5cffae13afcaa5b1a32b5e4b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158305 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2023-10-23tdf#111737 - Add new (master) page depending on the edit modeAndreas Heinisch
Change-Id: I5e0d0f604714cbc395cd6b0c7a9b5665f0d5f93b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157631 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-10-23tdf#157795 set color to black outside of of bitmap boundsPatrick Luby
Due to commit 81994cb2b8b32453a92bcb011830fcb884f22ff3, transparent areas are now black instead of white. Change-Id: I9456bb2603d4968a5d5df0a7bdbff48ce9a8e2f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158355 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org>
2023-10-23tdf#130924 replace '*printf' with 'SAL_*' logging macros in pyunosahil
Change-Id: I2c491629f52fe0b90517c563f221d7d0345b6ee9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156452 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-10-23tdf#130924 replace '*printf' with 'SAL_*' logging macros in toolssahil
Change-Id: I9721bfd3783fd6c5d41b2d9a0e8468c583ede0c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156864 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-10-23tdf#153519 Another TreeListEntryUIObject heap-use-after-freeStephan Bergmann
...similar to the one addressed with the commits leading up to 9a23ded27470a4c57015e9e5d686259a60d464f2 "Fix thinko when to sleep" Change-Id: Ia6db1440b3d9623b440edb3866b750ff5a14bdb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158348 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-28 17:33:19 +0000