summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-03-22coverity#705471 Dereference null return valueCaolán McNamara
Change-Id: I7706744e046d0c641300a9d9167d89f00acacd62
2014-03-22coverity#705457 Dereference null return valueCaolán McNamara
Change-Id: Ifde26af3d00fee3aa52afafa3986ef180be39908
2014-03-22coverity#1103725 Dereference before null checkCaolán McNamara
Change-Id: Ie09af4913d3ac7681a7328c43595d01a98050a07
2014-03-22coverity#983382 Dereference before null checkCaolán McNamara
Change-Id: Ifc665a78794dc86e2dbf98ae5f84b790739813ca
2014-03-22coverity#983370 Dereference before null checkCaolán McNamara
Change-Id: I524ce73811f32b7da38ef127ee4633a2c6a9f933
2014-03-22coverity#705005 Dereference after null checkCaolán McNamara
Change-Id: I4ed75d05777d55bd58542f4ffb39cc9af6215c56
2014-03-22coverity#705873 Dereference before null checkCaolán McNamara
Change-Id: I50a2642d754324e49d265c9eff13233fd181b75b
2014-03-22coverity#705875 Dereference before null checkCaolán McNamara
Change-Id: I83af9cbf298c26f9cd9c9fe0a5bd576fbf65d03e
2014-03-22coverity#705876 Dereference before null checkCaolán McNamara
Change-Id: If18649ff83b7127054171f59965a66ddb27b7363
2014-03-22coverity#705885 Dereference before null checkCaolán McNamara
Change-Id: I4e032dc9b77b98cc5981f812958667fc908993da
2014-03-22coverity#705913 Dereference before null checkCaolán McNamara
Change-Id: I2f025ede234cfbea4f6422001d1dcfb1b8e73a6f
2014-03-22coverity#705933 Dereference before null checkCaolán McNamara
Change-Id: I5812d4223b362d4df54b29de6285b3dc3ba572f8
2014-03-22coverity#705969 Dereference before null checkCaolán McNamara
Change-Id: Icb19931bb529e6c2b98621a603cdb86011d68a9e
2014-03-22coverity#736772 Dereference before null checkCaolán McNamara
Change-Id: Idf973cb888c7ac7a3e33aa2fdec0e25515b1feca
2014-03-22coverity#736776 Dereference before null checkCaolán McNamara
Change-Id: Ifd666fe1b71087ab8c5a20f1bd002277fe8f05da
2014-03-22coverity#736831 Dereference before null checkCaolán McNamara
Change-Id: I1c7a7b0d0ded11a18aa89df167a39b374520eb36
2014-03-22coverity#736847 Dereference before null checkCaolán McNamara
Change-Id: I83025065fd69a50ec06a9d1ed5fdd5ed0242bce0
2014-03-22coverity#736852 Dereference before null checkCaolán McNamara
Change-Id: I457fbd64af652efb902959b27696069b42665f46
2014-03-22coverity#736854 Dereference before null checkCaolán McNamara
Change-Id: I123887938735eb14e8ad4450f6d01b3b352f1b5e
2014-03-22fix higher debug level buildsCaolán McNamara
Change-Id: Ie8225ad476c43cbff2ee8fb0f3178b3cc4662ac9
2014-03-22Fix the conditionJulien Nabet
(thank you Kohei!) Change-Id: I45f94a2e09d24afeec545f4cf84acd209092ab7d
2014-03-22cppcheck: bRet reassigned before using its valueJulien Nabet
Change-Id: Iaa1dbf9c5638001018b71c946361bfc6db58be83
2014-03-22oox: no need to dump these hereMiklos Vajna
writeAppProperties() already uses this data as necessary. Change-Id: I5eea399ae2cfa37dc3a7c80114f5265fb4a0c648
2014-03-22fdo#76470: Avoid joining new formula cells individually.Kohei Yoshida
Instead, insert the formula cells in the group first, then only try to join the top and bottom cells afterward. Otherwise the grouping would get messed up and a problem would ensue. Change-Id: I4fdd5326c029032a636d8225b5fb16cbde427c7d
2014-03-22fdo#76470: Write unit test for this first.Kohei Yoshida
Change-Id: Iaf609b509165405c1a471dd8556c30dc019922da
2014-03-22fdo#76163 Fix for file corruption which contains fields and hyperlinkPriyankaGaikwad
Field inside a hyperlink closed after the ending tag of hyperlink, which corrupted the RT file. Reviewed on: https://gerrit.libreoffice.org/8688 Change-Id: Ie6fb5eff19c941819ca8c6193b3a6471de12c3e6
2014-03-22missing SwExtraRedlineTbl dtorMiklos Vajna
Change-Id: I58eaedd89fa039945a3907c8f8858599ea5bbe9c
2014-03-22WaE: unused variable 'aSrcOutRect'Tor Lillqvist
Change-Id: Ic64d9e3be43b3ad1751070242fc3ad9f7b35a92a
2014-03-22cppcheck: fix Possible inefficient checkingJulien Nabet
Change-Id: I71449d40875970aa49320ae86a3104d132f5d5e9
2014-03-22casting to void to silence a WaE lead to windows complaining.Norbert Thiebaud
Change-Id: I203b52d0a80dd3c04b75aab7e8a683b609e3efba
2014-03-22WaE unused parameterNorbert Thiebaud
Change-Id: I1390e327d8085badcfc3067763576fc6a0f3887c
2014-03-22fdo#74702 DrawOutDev() and CopyArea() functions now noops in PrinterChris Sherlock
DrawOutDev() and CopyArea() functions now assert when called from a Printer instance. This has allowed the removal of meOutDevType, which I hope to eventually completely eradicate from LO. I've also included DrawOutDev(...) which holds a parameter with a reference to a Printer object. This shouldn't be possible, so it asserts. Change-Id: Iabee853ca7c8bfc99349da086d1944ee13210a2e Reviewed-on: https://gerrit.libreoffice.org/8592 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-03-22fdo#74702 Moved CopyArea() Window specific functionChris Sherlock
There is Window specific code in OutputDevice::CopyArea(...). I have moved this to a protected function CopyAreaFinal(...). Conflicts: include/vcl/print.hxx vcl/source/gdi/outdev2.cxx Change-Id: I9098ec960527a2aca6154ac6e791b947a8e4f78e Reviewed-on: https://gerrit.libreoffice.org/8605 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-03-22use enhanced protection permission to override protection attributeEike Rathke
Change-Id: I53eeb5ffe6e700dd02e3966ccd66738c7b5ab464
2014-03-22no need to use the getter hereEike Rathke
Change-Id: I5bbec2c06a641729194ceee3882b88e7372d41a9
2014-03-22fdo#74702 Move BitmapEx drawing code to seperate functionsChris Sherlock
New virtual functions DrawTransformBitmapExDirect() and TransformReduceBitmapExTargetRange(). Printers cannot do either of these things so I make it a noop in the Printer class, Window and VirtualDevice will continue to work as intended. I have documented these functions in OutputDevice. Also made some small formatting changes to print.hxx to align tabs. Change-Id: Idd31d230f95d3b5ea360c72dc8191d47bfd8402b Reviewed-on: https://gerrit.libreoffice.org/8588 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-03-22added editable testers to enhanced table protectionEike Rathke
Change-Id: If535d92dada1e8a539af9aa105aa2f16aed629e9
2014-03-21write enhanced protection to .xls BIFF8 0x0868 Feat recordsEike Rathke
We now have a roundtrip of the EnhancedProtection feature. Change-Id: Ib13b4d23a10dd51d9328de872e076bf58ee3127d
2014-03-21copy-construct maEnhancedProtection in ScTableProtectionImplEike Rathke
Change-Id: Ia1f7415b853f9e5ac585f89cbc938c2464c33fe5
2014-03-21we don't need psprint.conf or the generic ppds on MacOSX and iOSCaolán McNamara
I think Change-Id: I876018d663bcfab0bfff52829637f85da3dc72bd
2014-03-21Resolves: fdo#76457 image buttons too narrowCaolán McNamara
but we liked the size of the symbol buttons regression since 1f6e88276006bea5d597ee6ca6fdf3af4dbf5ffd Really the PushButton::CalcMinimumSize and PushButton::ImplDrawPushButton are the better place to handle this, but its such a train-wreck Change-Id: Ib7ba00c6a9c2698ff4e4f264c4242bf48a686da8
2014-03-21fdo#74702 ImplPrintMask() implemented in PrinterChris Sherlock
Printer should implement ImplPrintMask(), as a protected function. If OutputDevice calls it, then do nothing. Also removed commented out code. Change-Id: If3e7d3b2057f0c89f48f81a4a7a7b2360c0a3439 Reviewed-on: https://gerrit.libreoffice.org/8593 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-03-21fdo#74702 Moved ImplReleaseGraphics into correct classesChris Sherlock
Made OutputDevice::ImplReleaseGraphics a pure virtual function, then implemented function in Printer, Window and VirtualDevice. The reason was that OutputDevice was checking to see if it was a Printer, Window or VirtualDevice that was calling on it in an if statement, very uncool :-) Now I let the classes themselves do the work. There is some common functionality, which is to release the fonts. I have put this into a protected OutputDevice function, ImplReleaseFonts. Change-Id: Id41db2119d4022ea2fc7855158ca9f610af3c85c Reviewed-on: https://gerrit.libreoffice.org/8548 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-03-21Revert "fdo#74064 The filename gets properly highlighted in the Save As dialog."Kohei Yoshida
This reverts commit 55eb86699d7d4b2151530e9a0b3ca2e99033595b, which caused a regression fdo#76466.
2014-03-21always resize vector, reserve is just thatEike Rathke
Change-Id: I6e6c54e5e6ee87039b8337258bb78da2f0201d06
2014-03-21refactored to use XclRangeList and XclImpAddressConverterEike Rathke
Change-Id: If0455f0243aace784c704e234469709e6da4542f
2014-03-21fdo#76361 : LO crash: LO crashes while saving the document to docxRajashri
The document contains an empty table with borders. LO was treating this table as a nested table, which lead to a TC tag mismatch. In docxattributeoutput.cxx, inside 'switchHeaderFooter' added a check against 'm_oldTableReference->m_pOldTablepInner' For some documents, even if the above value was null, still it was getting assigned to 'm_tableReference' . Thus in such situations it leads to a crash. Change-Id: I883267585cb804f961989797de57c4b843b96821 Reviewed-on: https://gerrit.libreoffice.org/8677 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-03-21Related: fdo#76457 set the edit fields to expandCaolán McNamara
the buttons remain too narrow, but that seems to be the case for all the formula buttons Change-Id: Ib7ecc6dffeed23459eddb1fc98140faf1a26296d
2014-03-21Fold psprint_config into vclKhaled Hosny
The files are only used by the psprint stuff in vcl, so move them closer to it. We should kill all of this anyway, but that is for another day. Change-Id: Ie3b893c92d556333c9d8b041859d5e97604ace10 Reviewed-on: https://gerrit.libreoffice.org/8694 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-21Related: fdo#74468 drop hard-coded 'sec' and use FUNIT_SECONDSCaolán McNamara
Change-Id: I11e2aa39d77c01446387b13ba4bc9f40b61a958a