summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-10-12Make NC_ constexpr-friendlyStephan Bergmann
...by moving the char8_t -> char reinterpret_cast out of any potential constexpr paths into a new TranslateId::getId. And demonstrate constexpr'ability by making the aCategories var in OApplicationIconControl::Fill (dbaccess/source/ui/app/AppIconControl.cxx) constexpr. (And there might be more such cases that could now be made constexpr.) Change-Id: I0b4e3292faf8f6b901f9b9e934e1aa6bf0f583ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157862 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-12loplugin:unusedmethodsNoel Grandin
Change-Id: I27782fb4b912d8b0d5f19cbe296c2a3b98b2bfd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157818 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-12split up the backtrace implementations into separate filesNoel Grandin
Because I cannot keep what is inside what #ifdef straight in my head Change-Id: Ie986a6928df179fc0e30ca12c6d2a6866ed82078 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157861 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-12Fix Windows x64 buildMike Kaganski
...after 6f45c0cf86b21772740bb0cafb3d462b058523f3 "cool#7318 Calc rendering acceleration" caused > sw/source/core/txtnode/fntcache.cxx(540): error C2672: 'std::min': no matching overloaded function found > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1438~1.331\Include\utility(108): note: could be '_Ty std::min(std::initializer_list<_Elem>)' > sw/source/core/txtnode/fntcache.cxx(540): note: '_Ty std::min(std::initializer_list<_Elem>)': expects 1 arguments - 2 provided > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1438~1.331\Include\utility(105): note: or '_Ty std::min(std::initializer_list<_Elem>,_Pr)' > sw/source/core/txtnode/fntcache.cxx(540): note: '_Ty std::min(std::initializer_list<_Elem>,_Pr)': could not deduce template argument for 'std::initializer_list<_Elem>' from 'sal_Int32' > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1438~1.331\Include\utility(98): note: or 'const _Ty &std::min(const _Ty &,const _Ty &) noexcept(<expr>)' > sw/source/core/txtnode/fntcache.cxx(540): note: 'const _Ty &std::min(const _Ty &,const _Ty &) noexcept(<expr>)': template parameter '_Ty' is ambiguous > sw/source/core/txtnode/fntcache.cxx(540): note: could be 'tools::Long' > sw/source/core/txtnode/fntcache.cxx(540): note: or 'sal_Int32' > sw/source/core/txtnode/fntcache.cxx(540): note: 'const _Ty &std::min(const _Ty &,const _Ty &) noexcept(<expr>)': could not deduce template argument for 'const _Ty &' from 'tools::Long' > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1438~1.331\Include\utility(88): note: or 'const _Ty &std::min(const _Ty &,const _Ty &,_Pr) noexcept(<expr>)' > sw/source/core/txtnode/fntcache.cxx(540): note: 'const _Ty &std::min(const _Ty &,const _Ty &,_Pr) noexcept(<expr>)': expects 3 arguments - 2 provided Change-Id: I9af33041a81190998303aec2795fe03da7e2f119 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157858 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-12tdf#145832 Typo when missing objectBogdan B
Change-Id: Ifc26d17aaf3d280f4eaefb94c4ef8009c11c3bfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157773 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-10-12tdf#157696 a11y: Escape commas in IAccessible2 color text attributeMichael Weghorn
The IAccessible2 text attribute specification [1] says: > These characters need to be escaped with a backslash: > backslash, colon, comma, equals, and semicolon. So adhere to this. Otherwise, the NVDA screen reader is unable to announce the text foreground or background color properly in local WIP branches of both LO and NVDA to use IAccessible2 text attributes on Windows as well. With this change in place, the backslashes are also contained in the corresponding AT-SPI attributes when using the qt6 VCL plugin on Linux. That seems undesirable there (s. e.g. the ATK text attribute spec [2] and how the Gtk variant of LO and also the gtk4-demo "Hypertext" example" expose it), but I think this should rather be handled in Qt's AT-SPI adaptor's mapping of the IAccessible2 attributes to the AT-SPI ones. Pending Qt Gerrit change implementing this: [3] (At least Orca still announces the colors just fine with the additional backslash in place, so having an extra platform-specific handling here doesn't seem to be urgent for now.) [1] https://wiki.linuxfoundation.org/accessibility/iaccessible2/textattributes#formatting [2] https://gnome.pages.gitlab.gnome.org/atk/AtkText.html#AtkTextAttribute [3] https://codereview.qt-project.org/c/qt/qtbase/+/511132 Change-Id: I51780f44930089249a769522d7130e97ac5446b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157845 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-12tdf#157696 vcl a11y: Move qt's translation to IA2 text attrs for reuseMichael Weghorn
Qt expects the text attributes to be reported as IAccessible2 attributes. Therefore, there is a translation/conversion from the LO-internal text attributes to IAccessible2 text attributes in `QtAccessibleWidget::attributes`. Move the logic from the qt-VCL-specific code into a new VCL helper class `AccessibleTextAttributeHelper`, so it can be reused in winaccessibility in following commits. Change-Id: I434481faa53c74bae95cae5b2c9f0907b87fb1bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157804 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-12drawinglayer,svx: PDF/UA export: put Form SE into anchor paragraph SEMichael Stahl
This is like commit d467f1aa3d028f399826c97e2eecedcd79efcf65 and commit 6e5d59c2ca6969e9491f97cd7a00d094fc62cfb3 but for the form controls, which have their own special ControlPrimitive2D. Change-Id: I4b4ac45e81f490a7b625acd9e8753300d10bf119 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157847 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-10-12tdf#157397 vcl: PDF export: fix CreateControl replayMichael Stahl
The problem is that the CreateLink and CreateControl actions are replayed in a different order than they are recorded, because CreateLink is a global action, and CreateControl a page action. This means that the mCurId at the time when PDFExtOutDevData::CreateControl() is called does not correspond to a position in mParaIds when CreateControl is replayed; it will be inserted too early and bump all the CreateLink ones to later indexes. Avoid this by adding another global action CreateControlLink that is added when CreateControl is being replayed, which appears to work. (Another subtle problem is that, in case of PDF/A-1, the page actions could be discarded completely; this should work in that case too.) (regression from commit d4d471fc88fe4fd14f44dfccdfe360dec327d4f0) Change-Id: I92d89ac08db6548e9f0d1480d984aeacb4d22262 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157767 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-10-12SwTextFly::GetAnchoredObjList never returns nullCaolán McNamara
Change-Id: Icd8a2aa356de24d977a72dc64825a03ed2f5b16d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157822 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-12COWASM-02 - Fix wasm build for co-23.05Balazs Varga
"Undeclared identifier mpParent in GetParent()" Change-Id: Ib613b2cf303b0ac50c6e899deda25d99c7e22343 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157245 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 21554305046e7faeb6d64c4eea622b968db1f474) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157778 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-12Fix typos in C++ feature test macrosStephan Bergmann
...that were accidentally made in e6fe048ded34a322007547d4d31e32c598aa4993 "Some more string_view use, add o3tl::starts/ends_with" Change-Id: I06470f705d1f51f98daffabe544c0194dfc34ee3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157832 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-12writerfilter: clean-up PushPageHeaderFooter method impl.Tomaž Vajngerl
in addition change m_aHeaderFooterTextAppendStack to use enum PagePartType for the "second" value in pair, instead of a bool to denote if it is an entry for header or footer. No change in functionality. Change-Id: I2aa75494c9b3337dd51bf79e282291cdca9d8547 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157839 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-10-12no need for these enums in BroadcasterStateNoel Grandin
the std::variant already knows which alternative it stores Change-Id: I3838d83959cf6a97876aba3543179338ba088ccc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157819 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-12Update to pdfium 6060Miklos Vajna
- external/pdfium/build.patch.1: re-generate with 'patch -p1' + 'git diff' Change-Id: I9258d6d0130620523d64fcd0854c4d96fc98a4bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157846 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-10-12cool#7318 Calc rendering acceleration (part2)Noel Grandin
we are spending a lot of time in SalLayoutGlyphsCache::GetLayoutGlyphs, and most of that is inserting into the GlyphsCache, which has a very very large key. Shrink that key a little bit Change-Id: I6f27c147652521502dba4517afd9a2ae2a6daebb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157754 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-12tdf#157636 FILEOPEN: PPT: Images have no backgroundNoel Grandin
regression from commit 81994cb2b8b32453a92bcb011830fcb884f22ff3 Convert internal vcl bitmap formats transparency->alpha (II) Change-Id: Ia0ed01e7c0d41bd909fe48666bc9aca5ff31d2bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157824 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-12Do not compare SwContentIndex instances from different nodesMike Kaganski
It fires an assert in dbgutil builds; and it doesn't make sense anyway: we must use the index from the beginning, not a strange minimal value between indices in start node and end node. Change-Id: I4a2b6062f5524703737ca6029f428f30555d25b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157842 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-12sw: prepare tests cases for first, left, right headers and variantsTomaž Vajngerl
This prepares the test case for first, left, right headers, only first and non-first headers, only left and right (no first) headers and make them run for ODF, where they should work as expected. In a follow up commit, the OOXML implementation should be fixed so that the same tests pass for OOXML documents. Change-Id: I1e7f610324c14dd9eb285ff9d46829610de5b1b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157838 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-10-12editeng: move the methods into Test class definitionTomaž Vajngerl
This makes makes all the Test class methods contined in the class definition body, so more readable and less noise for the actual test definitions. Change-Id: I3ea177f27aa868a396e537b1682ce91d93c1208e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157837 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-10-12change PageType (first, left, right) enum to enum classTomaž Vajngerl
Change-Id: I45bb7947266de1e18028c7ed460149c609e430b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157834 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-10-12tdf#138440 sc notebookbar: add right-to-left to home tabJustin Luth
The UI is pretty packed here, so for non-RTL languages having it on the toolbar would be distracting. So I decided to make it hidden - meaning a RTL user would need to customize the notebookbar to reveal it. However, adding it unconditionally to the dropdown menu is fine, so at least it is readily available there. It already existed in the paragraph menu of groupedcompact. Change-Id: Id4dc2de9c0922428fc44501c4eb2d7e3e51dea82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157851 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-10-12prefix some members of ImpEditEngineTomaž Vajngerl
Change-Id: I9975bed2af853374a10b87c468840ff22b230157 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157833 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-10-11tdf#157613 make sure surface is not a null pointerPatrick Luby
Change-Id: I8e3c1be3f05f7ccc1f3ba00093cd71a564e5ae9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157848 Reviewed-by: Patrick Luby <plubius@neooffice.org> Tested-by: Patrick Luby <plubius@neooffice.org>
2023-10-11Drop o3tl::span, can use C++20 std::span directly nowStephan Bergmann
Change-Id: Ic21ff7bf48f07f7277979d52e99d2c5c268de83f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157825 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-11drop empty accessibility descriptionCaolán McNamara
Change-Id: Ib2e4524ba668ce59ba1c5fad3e3180df396254a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157796 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-11InitAnchoredObjList never returns nullCaolán McNamara
Change-Id: I01b6accc5974caaa0533c95e50aa27c78af3ae0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157821 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-11__cpp_lib_char8_t is generally available nowStephan Bergmann
...after 1eef07805021b7ca26a1a8894809b6d995747ba1 "Bump baseline to C++20" Change-Id: I45aa7538174a0c62ad5a4871e2914b30580546c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157827 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-11Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to e7ec227d83792bdaf88cb53be5a5a8849f7f576a - tdf#155044 Help: Description -> Alt Text and Text Alternative -> Text Change-Id: I3c8317f4b747b05c7fbbf7119f9210627aaacd48 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157643 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-10-11tdf#155044 Missed one Description to Alt Text spotIlmari Lauhakangas
Change-Id: I4e454b1e3966007b04d6f50acf4249b9b80f5526 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157840 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-10-11FocusManager::IsPanelTitleVisible is deadNoel Grandin
ever since commit df2c41859287282501c8ebd7b3c67465455a457c Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Sat Sep 23 21:01:50 2023 +0200 MoveFocusInsideDeckTitle is dead Change-Id: I641622453b35526c7654c84d25d9d7c873249b43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157817 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-11both branches set mpAnchoredObjList the sameCaolán McNamara
Change-Id: I0a41bc4cee141b2a375be3d84f67367ef8d7a2c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157820 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-11The other OStringLiteral ctor should be non-explicit tooStephan Bergmann
It had been missed by 31cd6fd0f3c856a81a03d0229de1c4d10442844f "Make OStringLiteral ctor non-explicit", and now prevented u8"..."_ostr from compiling. Change-Id: Ifb214fba0957b0d26b11daae6190ffa9d21713f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157823 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-11disable more flakey navigator testNoel Grandin
Change-Id: Ic8de4333a33723c94cd86e5467f856170b0ae5b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157810 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-11tdf#157686 UI freezes after setting new master passwordNoel Grandin
regression from commit 49dd32a88d90097a1c50dc64dc42dc35645780b8 author Noel Grandin <noel.grandin@collabora.co.uk> osl::Mutex->std::mutex in PasswordContainer Change-Id: Ie6270f6ed47ee892181f7b9e51ed8ef75533f4e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157809 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-11Update git submodulesEike Rathke
* Update helpcontent2 from branch 'master' to 379510d74d95dd4e7878e8e86401a3b60a6ef107 - Follow-up: tdf#152412 Re-add the note to the STYLE() function ... to not use it without reason.. This got lost with commit 20d4c17ca1fb161bf5fccf3d94db93b0a4d322f2 CommitDate: Wed Jan 11 00:09:58 2023 +0000 tdf#152412 Improve the STYLE function help page Change-Id: I48b11d8360a0a95ae1a76e4d0a339b5fe6488d2d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157835 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-10-11Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 73620e7f6b800b0fb0c8d66859bcbfffb3b7dfac - update translations for master and force-fix errors using pocheck Change-Id: I38f3b37fa63d5b6becd7bceea107198034d41593
2023-10-11disable add-ons for NotebookBar in LOKit - perf. issuesTomaž Vajngerl
Searching for add-ons to use in NotebookBar causes perf. issues, so disable them for now. This was discovered during a editing session and the flame-graph showed up the NotebookbarAddonValues method. See COOL GitHub ticket [1] for more details. [1] https://github.com/CollaboraOnline/online/issues/6896 Change-Id: I4b2ced2be966de1cd1282f801a4410bc1625f0f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154513 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 0cda4c31c6c7881ea7b5089b04ad5147b28117af) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157815 Tested-by: Jenkins
2023-10-11Make the format > sections > options dialog a jsdialogSkyler Grey
- This dialog was not properly tunneled so did not show on collabora online - Running asynchronously as a jsdialog both fixes this issue and is a general improvement (in that jsdialog conversion improves accessability, looks more consistent with the rest of COOL, etc.) Note- This commit was previously given the Change-Id Ie9a70da70bbb30de039ded82f738285b1b734421 however I have replaced it due to accidentally creating it against the wrong base branch. To see the old change go to https://gerrit.libreoffice.org/c/core/+/147295 Change-Id: I2715eb1d8e3e301e1519e2ef6b69c823e571d08c Signed-off-by: Skyler Grey <skyler.grey@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151188 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 6aff11f36ecd02613c0613c9e89883c81656d9f6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157814 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-11Removing unused variable in preLoadShortCutAcceleratorsMarco Cecchetti
When all warnings are treated as errors the following error was reported: desktop/source/lib/init.cxx: OUString language = LanguageTag(installedLocales[i]).getLocale().Language; The problem started after commit 1cd46ba9140b7f5f077d8e9da405b180857f008d. Remove the allowed language check from UI languages. Change-Id: Id1f4269fe262b61b4fb05d61bf9c64a747275c28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152561 Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com> (cherry picked from commit b0fa2ea7decadae61ad10e340698a8dd4af45e6e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157813 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-11Remove the allowed language check from UI languages.Gökay Şatır
Allowed langauges list is for spell checking algorithms. No need to use it for UI shortcuts. Signed-off-by: Gökay Şatır <gokaysatir@gmail.com> Change-Id: I996861b79247269e9b788b008fe6fc26e5ef44c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152416 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 1cd46ba9140b7f5f077d8e9da405b180857f008d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157812 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-11make CppunitTest_framework_dispatch reliableCaolán McNamara
the appearance of 2 interceptions is reproducible for me on linux with make CppunitTest_framework_dispatch VALGRIND=memcheck 1st time #1 (anonymous namespace)::MyInterceptor::queryDispatch(com::sun::star::util::URL const&, rtl::OUString const&, int) at core/framework/qa/cppunit/dispatchtest.cxx:139 #2 non-virtual thunk to (anonymous namespace)::MyInterceptor::queryDispatch(com::sun::star::util::URL const&, rtl::OUString const&, int) at core/framework/qa/cppunit/dispatchtest.cxx:0 #3 framework::InterceptionHelper::queryDispatch(com::sun::star::util::URL const&, rtl::OUString const&, int) at core/framework/source/dispatch/interceptionhelper.cxx:87 #4 non-virtual thunk to framework::InterceptionHelper::queryDispatch(com::sun::star::util::URL const&, rtl::OUString const&, int) at core/framework/source/dispatch/interceptionhelper.cxx:0 #5 (anonymous namespace)::XFrameImpl::queryDispatch(com::sun::star::util::URL const&, rtl::OUString const&, int) at core/framework/source/services/frame.cxx:2329 #6 non-virtual thunk to (anonymous namespace)::XFrameImpl::queryDispatch(com::sun::star::util::URL const&, rtl::OUString const&, int) at core/framework/source/services/frame.cxx:0 #7 framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at core/framework/source/services/dispatchhelper.cxx:110 #8 non-virtual thunk to framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at core/framework/source/services/dispatchhelper.cxx:0 #9 unotest::MacrosTest::dispatchCommand(com::sun::star::uno::Reference<com::sun::star::lang::XComponent> const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at core/unotest/source/cpp/macros_test.cxx:94 #10 (anonymous namespace)::testInterception::TestBody() at core/framework/qa/cppunit/dispatchtest.cxx:172 2nd time #1 (anonymous namespace)::MyInterceptor::queryDispatch(com::sun::star::util::URL const&, rtl::OUString const&, int) at core/framework/qa/cppunit/dispatchtest.cxx:139 #2 non-virtual thunk to (anonymous namespace)::MyInterceptor::queryDispatch(com::sun::star::util::URL const&, rtl::OUString const&, int) at core/framework/qa/cppunit/dispatchtest.cxx:0 #3 framework::InterceptionHelper::queryDispatch(com::sun::star::util::URL const&, rtl::OUString const&, int) at core/framework/source/dispatch/interceptionhelper.cxx:87 #4 non-virtual thunk to framework::InterceptionHelper::queryDispatch(com::sun::star::util::URL const&, rtl::OUString const&, int) at core/framework/source/dispatch/interceptionhelper.cxx:0 #5 (anonymous namespace)::XFrameImpl::queryDispatch(com::sun::star::util::URL const&, rtl::OUString const&, int) at core/framework/source/services/frame.cxx:2329 #6 non-virtual thunk to (anonymous namespace)::XFrameImpl::queryDispatch(com::sun::star::util::URL const&, rtl::OUString const&, int) at core/framework/source/services/frame.cxx:0 #7 SfxStateCache::GetSlotServer(SfxDispatcher&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&) at core/sfx2/source/control/statcach.cxx:263 #8 SfxBindings::UpdateSlotServer_Impl() at core/sfx2/source/control/bindings.cxx:1083 #9 SfxBindings::NextJob_Impl(Timer const*) at core/sfx2/source/control/bindings.cxx:1254 #10 SfxBindings::NextJob(Timer*) at core/sfx2/source/control/bindings.cxx:1222 #11 SfxBindings::LinkStubNextJob(void*, Timer*) at core/sfx2/source/control/bindings.cxx:1219 #12 Link<Timer*, void>::Call(Timer*) const at core/include/tools/link.hxx:111 #13 Timer::Invoke() at core/vcl/source/app/timer.cxx:76 #14 Scheduler::CallbackTaskScheduling() at core/vcl/source/app/scheduler.cxx:480 #15 SalTimer::CallCallback() at core/vcl/inc/saltimer.hxx:55 #16 SvpSalInstance::CheckTimeout(bool) at core/vcl/headless/svpinst.cxx:161 #17 SvpSalInstance::ImplYield(bool, bool) at core/vcl/headless/svpinst.cxx:399 #18 SvpSalInstance::DoYield(bool, bool) at core/vcl/headless/svpinst.cxx:471 #19 ImplYield(bool, bool) at core/vcl/source/app/svapp.cxx:377 #20 Scheduler::ProcessEventsToIdle() at core/vcl/source/app/svapp.cxx:407 #21 unotest::MacrosTest::dispatchCommand(com::sun::star::uno::Reference<com::sun::star::lang::XComponent> const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at core/unotest/source/cpp/macros_test.cxx:95 #22 (anonymous namespace)::testInterception::TestBody() at core/framework/qa/cppunit/dispatchtest.cxx:172 setting bold/italic will invalidate the slot for the property and timer starts to update the normal listeners to those properties which might kick in on a slower run. Change-Id: Ib37e61c0fbed463f8974d476158e54a0160a2c92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157798 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-11writerfilter: use content controls for text in block SDTsJaume Pujantell
Text inside block SDTs was shown as Text Fields wich ignored properties such as alias and formatting. Now those texts are imported as content controls like in the case of run SDTs. Added the ability for content controls to remember and export the "multiline" property of block SDT text. Some existing tests have been changed due to some different export results. Change-Id: Ice1eb4ca6dd53c99d5abb239371f8ac896c3b6e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156867 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-10-11__cpp_char8_t is generally available nowStephan Bergmann
...after 1eef07805021b7ca26a1a8894809b6d995747ba1 "Bump baseline to C++20" Change-Id: I75509f3731357e0e3ae73c3774abd6e4070f605b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157806 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 3dda8f8e1aa70b6a89482e223c021cc0188beef2 - tdf#155876 UI cmds Calc (02) + refactoring + Digital Signature menu Change-Id: I9547d47c6f4f99800b17fec2fb2199c13b38bc40 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157801 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-10-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 22bb0cabc27b077214c08cf71e91b13098c305ba - tdf#155876 UI cmds Calc (01) + refactoring + Open/Save remote Change-Id: I9df9a7751f15fcbfbcfdbe346a1d513d41239abe Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157800 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-10-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to d13c170d0f21d8ab4d80110af95fe12bec8be5f1 - Fix grammar + Change-Id: I6b765e52c4868ee7c665d5db6794f2410671713d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157774 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-10-11curl: upgrade to release 8.4.0Thorsten Behrens
Fixes CVE-2023-38546 and CVE-2023-38545 Minor amount of bugfixes, nothing that immediately affects us. New feature: IPFS protocols via HTTP gateway now supported, with the right URL. Change-Id: I24af4d17b570685081aa031c50a87bb8dcf1833d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157807 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-11lok: flush the VOC primitives when trimming memoryAshod Nakashian
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk> Change-Id: I0a7748a1fb1b58b3bcfc6b8fdfa1410a345849a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154812 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 5fba074e7f22ff0e5d5b9591a912193f7be8c08c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154868 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-11tdf#156808: sd_png_export: Add unittestXisco Fauli
Change-Id: I64b1f1f179e263962394afbbebd0be5486720e75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157763 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2024-12-26 14:50:42 +0000