summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
13 daysFix typoAndrea Gelmini
Change-Id: Idccd17065affa1d5ed0821f71faac7d71e9a8928 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180443 Reviewed-by: Taichi Haradaguchi <20001722@protonmail.com> Tested-by: Jenkins
13 daysFix typoAndrea Gelmini
Change-Id: Ie50100eb2ab2b099aa4cc6962efc7923669dbf29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180442 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@protonmail.com>
13 dayscid#1640473 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: Id8e440ea08e2d6a853e870dc0161d30e63b75cc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180436 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
13 dayscid#1640469 Dereference null return valueCaolán McNamara
Change-Id: Ib115c3ee73a0124d9d6a3c895722c89158da2d22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180435 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
13 dayscid#1640471 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: I5b9e8ab80e884609bc18060674f3a974684a0303 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180434 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
13 dayscid#1640467 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: Id029fdf37d8b7b1e8d0bae672d37f6dfcbef8ce8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180433 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
13 daysQtVirtualDevice::SetSizeUsingBuffer is unnecessaryNoel Grandin
this method is only used by LOK and LOK only renders to the SVP backend Change-Id: I33b47e549e4762c61cb921ebbe4e60f97b0c28cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180439 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
13 daysUse EXTENDED_MAX_PATH in ShutdownIconMike Kaganski
Allows to use long paths in quickstarter, could be useful when the program is in a deeply nested directory. Change-Id: Iba6f8e2f7c54bfd442d19da63c94da9a50a867e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180444 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
13 daysUpdate git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to fae33ebe38ef8314058d90831f2b6c933feb4e8e - Clean up and optimise CSS Prefer readability over compactness. Repetition is fine, if it helps with readability. Took some tips from this validator: https://stylelint.io/demo/ Change-Id: I36108e2f063c848182503ea469d146bb00099a75 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180438 Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
13 daysfontconfig: upgrade to 2.16.0Xisco Fauli
* external/fontconfig/ubsan.patch is fixed upstream Downloaded from https://www.freedesktop.org/software/fontconfig/release/fontconfig-2.16.0.tar.xz Change-Id: Id1acbc473cc03e35c8a7a6bd2b2c080cbf653d1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180441 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
14 dayssw: Dereferencing NULL pointer 'pChangeHint'Xisco Fauli
After commit c239b6cad271d20f443482bc8b6039b1734d18f2 Author: Noel Grandin <noelgrandin@gmail.com> Date: Sat Jan 4 16:20:57 2025 +0200 convert RES_ATTRSET_CHG to SfxHint C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_analyze/sw/source/core/draw/dcontact.cxx(1670): error C2220: the following warning is treated as an error C:\cygwin\home\tdf\lode\jenkins\workspace\lo_tb_master_win_analyze\sw\source\core\draw\dcontact.cxx(1529) : warning C6011: Dereferencing NULL pointer 'pChangeHint->m_pNew'. : Lines: 1415, 1416, 1417, 1424, 1431, 1433, 1435, 1436, 1437, 1445, 1447, 1448, 1450, 1454, 1496, 1499, 1500, 1525, 1528, 1529 C: /cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_analyze/sw/source/core/fields/docufld.cxx(2318): error C2220: the following warning is treated as an error C: \cygwin\home\tdf\lode\jenkins\workspace\lo_tb_master_win_analyze\sw\source\core\fields\docufld.cxx(2294) : warning C6011: Dereferencing NULL pointer 'pChangeHint'. : Lines: 2265, 2271, 2273, 2274, 2275, 2276, 2290, 2279, 2294 Change-Id: I919d59d108a39dd77adb18967392a8ae8920275a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180431 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
14 daysvcl: Dereferencing NULL pointer 'pData'Xisco Fauli
After commit a108fce773d46441e30dcc14abe29751410ae4ed Author: Michael Weghorn <m.weghorn@posteo.de> Date: Fri Jan 17 14:18:30 2025 +0100 tdf#163186 qt: Show menu item tooltips C: /cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_analyze/vcl/source/window/menu.cxx(1144): error C2220: the following warning is treated as an error C: \cygwin\home\tdf\lode\jenkins\workspace\lo_tb_master_win_analyze\vcl\source\window\menu.cxx(1142) : warning C6011: Dereferencing NULL pointer 'pData'. : Lines: 1137, 1139, 1142 Change-Id: I62e8462fcff83817f876489a10bd010e246a1d01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180430 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
14 daysandroid-viewer translated using WeblateWeblate
Nepali currently translated at 17.2% (20 of 116 strings) Change-Id: Ic4035d126f219a07a06e5fca1cbbcda44da450cd android-viewer translated using Weblate Romanian currently translated at 1.7% (2 of 116 strings) Change-Id: I5546924ae3c8a06ef146ad9edace2d35b5808b77 Added translation for android-viewer using Weblate (Romanian) Change-Id: Ia8a83b4214d1e2534effba69ec1b3616a94eee1a android-viewer translated using Weblate German currently translated at 100.0% (116 of 116 strings) Change-Id: I4e8df9f44be8070659ef951e0a79ae1d358d9155 android-viewer translated using Weblate Polish currently translated at 100.0% (116 of 116 strings) Change-Id: I1963efa6ecef6c3259d31ef99fa087266c1e9156 Co-authored-by: Adam Rak <kitynska@gmail.com> Co-authored-by: Christian Kühl <kuehl.christian@googlemail.com> Co-authored-by: Miloiu Andrei <miloiuandrei@gmail.com> Co-authored-by: Nabin Khanal <boiinventer@gmail.com> Co-authored-by: Weblate <noreply@documentfoundation.org> Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/de/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ne/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/pl/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ro/ Translation: android-viewer/android-strings Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178880 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
14 daysbasegfx: simplify template code by using conceptsTomaž Vajngerl
Change-Id: Ie5bff37dbc20253ec869b2e0e0379eb22e78f6d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180415 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2025-01-18tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: I469e956f24a33b803243ffe20ebac252766821cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177154 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2025-01-18tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: I3749b9d198eb0f237de31ae479394f4e3800c973 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177137 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2025-01-18tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: I395cabac91b986e94869578921a1de491219dfc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177157 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2025-01-18sdext: Document the pdf import codeDr. David Alan Gilbert
Change-Id: I572d9a73a652df1f26cf4c6434be4ebe8c5bff00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180132 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2025-01-18tdf#164748 writerfilter: fix missing even/odd header propertiesJustin Luth
Lots of header/footer page style properties are ignored if the header/footer is not first enabled. So copying propertyList MUST follow completeCopyHeaderFooter() [which is where all those settings are turned on]. However, copying properties AFTER turning on the header/footer was Exception'ing when trying to copy BottomMarginComplexColor as void(). So ignore any property-copy errors, and then everything should work in theory... ...and it seems to. make CppunitTest_sw_core_header_footer \ CPPUNIT_TEST_NAME=testBnc519228OddBreaks make CppunitTest_sw_rtfexport8 \ CPPUNIT_TEST_NAME=testTdf160976_headerFooter Change-Id: Iecf0a070e77525c04b44c4fc38efa0f9d558eca5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180417 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2025-01-17vcl: prefix member variables with 'm' in BitmapBasicMorphologyFilterChris Sherlock
Change-Id: I7258502c509584301392c45a21cf0de2ccf5bca4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173700 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-01-17vcl: followup to remove unnecessary resetsChristopher Sherlock
Followup for 44dfcebde64b9edfa9f50eace34e5e1497ab9314 Just enclose it in the correct scope. Change-Id: I3bb3bfa0fa8bc5996d728f175aad16b64da52166 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180260 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-01-17Revert "tdf#163335 qt a11y: Work around broken sw selection handling"Michael Weghorn
The underlying issue in Writer was fixed in commit 65a5a4772af919e71a1fe7a752e622ec4cdba7ad Author: Michael Weghorn <m.weghorn@posteo.de> Date: Tue Jan 14 12:11:46 2025 +0100 tdf#163335 sw a11y: Handle cursor selection consistently , so revert the temporary workaround in the qt a11y bridge again (on master only, workaround remains in place for release branches). This reverts commit 3eaa35e8bacc19a85f5c9d907450846bfa8bffae. Change-Id: Ib53aa2d16e0302c4ccd7ba8ac38e9ebb7cf186e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180410 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-01-17tdf#163186 qt: Show menu item tooltipsMichael Weghorn
So far, the qt VCL plugins were not handling/showing menu item tooltips, like showing the full path for entries in the "File" -> "Recent Documents" submenu. Implement handling so they are shown: * Set the tooltip for the menu entry's QAction in QtMenu::InsertMenuItem. * Introduce SalMenu::SetItemTooltip, override it in the QtMenu subclass and call it in Menu::SetTipHelpText so newly set tooltips are propagated to the native Qt menu, to keep them up to date (similar to what already happens e.g. for the menu entry's displayed text in Menu::SetItemText). * Since Qt doesn't by default show tooltips for QActions used in menus, install an event filter on the QMenu/QMenuBar objects that handles the QEvent::ToolTip event to manually show a tooltip. See [1] for more background and a similar example using custom QMenu/QMenuBar subclasses instead of the QObject::installEventFilter/QObject::eventFilter approach taken in this commit. Only show the tooltip if one was explicitly set. QToolTip::tooltip() [2] by default returns a text based on the action's text (with accelerator's etc. stripped), so only show the tooltip if QToolTip::tooltip() returns something that differs from what would be used based simply on the text. [1] https://forum.qt.io/topic/6821/solved-settooltip-in-qaction-menu/2 [2] https://doc.qt.io/qt-6/qaction.html#toolTip-prop Change-Id: I1e2568d9d6e9e2baf7dcd7dffbaaabae7862b489 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180408 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-01-17Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to e17de2924949bccdbe3aedb527fac6acc210e6e3 - Fix typo Change-Id: Id592377c9916d5c18470b996e574710db0ef0c59 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180367 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
2025-01-17tdf#164394 Fix Vulkan vkCreateXcbSurfaceKHR validation errorJonathan Clark
Updates the Skia shared context patch to avoid surface/swapchain construction on invalid X11 windows. Change-Id: Ia591fb3755ed5adeec2b6246cf9a4a2fb9dcc74d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180420 Reviewed-by: Jonathan Clark <jonathan@libreoffice.org> Tested-by: Jenkins
2025-01-17Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 186169d9bd0f713a780e5aae2d8ac71916fb3a60 - Fix "Contents" heading color Change-Id: Ic6c42902bd554d365626793dd571607acb2c6433 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180418 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2025-01-17Refactor doc_paintPartTile a bit.Gökay Şatır
Move repeated lines into inline functions. Move large code blocks into inline functions. Separate the data validation and process parts. Change-Id: Icaf4a6fa0bdc15907b4bee7e148edc878555ea45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180412 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2025-01-17ScriptForge es.po Typos and enhancementsJean-Pierre Ledure
In addition the VALIDATEREGEX message is obsolete and removed from next language files modified: wizards/source/scriptforge/po/es.po modified: wizards/source/scriptforge/po/fr.po modified: wizards/source/scriptforge/po/pt.po Change-Id: I67c2e5604e548870bf1bdceb9641d4802530e437 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180413 Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins
2025-01-17prevent assignment if ENABLE_MSVC_ANALYZE existsXisco Fauli
so export ENABLE_MSVC_ANALYZE=1 can be used in https://ci.libreoffice.org/job/lo_tb_master_win_analyze/ if a macro/variable is only used by make, then there's no need to use export in config_host.mk Change-Id: I31ebef21c92dfaa279bd3bf7e5e5ecef1e960ac2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180384 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-01-17vcl: extract scanning for resources to UserResourceScanner classTomaž Vajngerl
So the scanning for resources can be reused for other things. Change-Id: Ia1589eb6c2ce4f254be0a62e296b1e186d0ba323 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180371 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2025-01-17lok: send username of the person who removed commentsPranam Lashkari
This can be userful to know when a user is editing comment and another user deletes it. It will help to identify and inform about the conflict to relevent users only Change-Id: I81f5edc8f6cbb85ad00e03b5bf668b68eeae1ad8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179298 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 0b3e73526496875735eeb657929d94897a840b02) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180289 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2025-01-17sc: make data validy error dialog async (invalid value error)Pranam Lashkari
Change-Id: Icd077776b26e21b226b4dee5beb1a5ff6dcf301a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179509 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 495be2dcb34d22af59a2028d3a686a0d48774166) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180286 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2025-01-17tdf#157519 Make solver's Sensitivity Report prettierRafael Lima
Currently the sensitivity report has no formatting whatsoever. This patch formats the report using table headers and adds a line delimiter at the table's end. The new formatting capabilities were added into AddressWalkerWriter so that it can also be used to improve other statistics reports (such as the features in Data - Statistics). Change-Id: I80da3c673fec457e3d5de07c5f7a09904412d01f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180305 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2025-01-17Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to c0b77292ca59b964feb3d039e9cb9e3adb927c96 - tdf#131927 Clarify criterion as string expression in SUMIF Change-Id: I6f59f9042e444011d044eeefb2aeda29b00425c4 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180364 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
2025-01-17LOK: preload hyphenatorsAndras Timar
Without this fix the hyphenation feature did not work when bind mounting was not available, e.g. in docker containers. Change-Id: I800012b5229ce5a56a5698db7057e3a27e760be3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180337 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 7b43ce868f980dc47c37f482900210eae2d0187e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180382 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2025-01-17tdf#137848 Speed up inserting rotated imageNoel Grandin
Since writer supports displaying rotation now, we don't need to convert and rotate the image data itself Change-Id: I547d8da98125f8956badeb0c113f2d6ab332ee86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180380 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2025-01-17ofz#390253942 Integer-overflowCaolán McNamara
Change-Id: Id53f4812622d87a6f775a495d82d9bd7ea1e2869 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180381 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2025-01-17LOK: Do not try to show an "update links" dialogMike Kaganski
In commit f8528cdda9292c7ae6c9d49b80c1a3a3b4a67094 (LOK: don't crash when trying to show a dialog during file load, 2024-12-26), all not yet async / not properly set up dialogs made to fail gracefully. In the follow-up https://gerrit.libreoffice.org/c/core/+/180334, an assert is added to still fail in debug builds. The specific "update links" dialog case, that triggered the original change in the first place, does not need to appear at all in the LOK case, because there is no external documents available for updating. This change avoids the dialog in that case. Change-Id: I7c6bc755d87656f002829460f4768fed34dc2f17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180335 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-01-17Add an assert to allow debugging not yet async dialogsMike Kaganski
Commit f8528cdda9292c7ae6c9d49b80c1a3a3b4a67094 (LOK: don't crash when trying to show a dialog during file load, 2024-12-26) fixed a crash when a not async / not properly set up dialog was attempted in Online. This is reasonable in release builds, but the added assert helps to find the problem in development (debug) builds. Change-Id: Ie75574cc7a69de06f6b63925249a5da2e50abb6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180334 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-01-17undo/redo of comment insertion assumes Par2 content matches TextObjectCaolán McNamara
contents (as much as conversion to plain text makes possible) To make things easier, add an EditTextObject::GetText() like EditEngine::GetText() that serializes multiple paragraphs in an equivalent way so there isn't a need to create an editengine just to do this conversion. Modify and extend DesktopLOKTest::testCommentsCallbacksWriter to use a html payload and add a undo/redo to it. Change-Id: I4d895138e919bab54ebbbcb966f9b9faef574086 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179594 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180377 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2025-01-17configure.ac: fix typoXisco Fauli
I hope it fixes https://ci.libreoffice.org/job/lo_tb_master_win_analyze/ where ENABLE_MSVC_ANALYZE=1 is not doing anything Change-Id: Ibc2ca6151720d152400f80da611093ec4679e21e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180376 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-01-17cid#1555986 Check of thread-shared field evades lock acquisitionCaolán McNamara
and cid#1556190 Check of thread-shared field evades lock acquisition cid#1555295 Check of thread-shared field evades lock acquisition cid#1608596 Check of thread-shared field evades lock acquisition cid#1555236 Check of thread-shared field evades lock acquisition Double-checked locking pattern Change-Id: Id5cba26750bbd9c7e0248181f636ff653ada5654 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176739 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2025-01-17Set StyleSettings::DisableColor value in WinSahil Gautam
WinSalFrame::UpdateSettings function loads colors from the widget toolkit into the StyleSettings objects. Themes uses these colors as default values. I tried using `OpenThemeData(mhWnd, L"Button")` to get the fill color value for background color, but didn't get the appropriate color. For the time being, modifying the ButtonRect luminance for the disabled state. Would replace it with something more appropriate as the Win32 welding work progresses. Change-Id: Ied04a8c6c6cb01b1388ef1d744077ae6dfd27b1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179439 Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2025-01-17tdf#153251 remove s_nPixelTwipsbruh
Change-Id: I43d39925931071b78e08adf47bf3c6c590b1a2ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180360 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins
2025-01-17tdf#148812 write #NAME? for an empty definedName valueTomaž Vajngerl
This keeps MSOffice silent when opening the documents that don't have the any range/formula expression set for the define name. Change-Id: Ib4cc01a5c51b3875c0d8e0870e2bdf9c15794df1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180258 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2025-01-16cool#10630 doc electronic sign: move signature line tracking to the viewMiklos Vajna
No functional changes intended: - Replace SfxObjectShell::GetSignPDFCertificate() and SfxObjectShell::ResetSignPDFCertificate() with SfxViewShell::SetSignPDFCertificate() and SfxViewShell::GetSignPDFCertificate(), because information about shape selection belongs to the view. - Change svx::SignatureLineHelper::setShapeCertificate() to use SfxViewShell::SetSignPDFCertificate() to avoid duplication. - Change GetSignatureLineShape() in xmlsecurity/ to use SfxViewShell::GetSignPDFCertificate(), again to avoid duplication. With this, all setters/getters of the inserted signature line go via SfxViewShell and the amount of getCurrentSelection() calls on the model is reduced. Change-Id: I021bc41262b2a16d1014fbf1431a0eb6e1e86c73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180355 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2025-01-16defer creating std::locale until it is neededCaolán McNamara
(if ever, seeing as it's only required if there is an error) Change-Id: Id8ba5ff495dfd2048401231023a09abba9bbf785 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180347 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2025-01-16convert RES_UPDATE_ATTR to SfxHintNoel Grandin
Change-Id: I4d5da5ba4e65ddbce2cb05bdfda34eb582c52d59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179843 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-01-16Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to d9104f52a1f7e3b2eee958544659cabb6808cd3c - Center everything with 1440px width Change-Id: I4a97df011b58c70f5ff8ef73433d8f6bd325d371 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180297 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2025-01-16Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 8f4c572d64b2fbe1ce66dc917c2709d96a4158fd - tdf#164068 Add Table style in style category page. + refactor Change-Id: I0f85fd41b62f980c118e2c00d9f7eacf691a723c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180361 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-02-01 00:47:38 +0000