summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-01-23loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I262ebd2479df0bfbca102d47e82d62bf98b339a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87234 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-23no need for repetitive GetShell()->GetWin() callsCaolán McNamara
Change-Id: I2c0a136db685e67b5981a0162619521d7f2070cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87216 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-23SdDocPreviewWin is unusedCaolán McNamara
since... commit bb8040595c9b6f0ccde39e6833f27a50abb891d8 Date: Mon May 30 01:57:00 2016 +0530 Impress: Replace Presentation Wizard with Template Manager Change-Id: Ibe610beb8ae98aca9bf29554528127ed1518179d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87219 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-23Fix German typoAndrea Gelmini
Change-Id: I7a45ba05fdeefed611024304bceffcf5c5aab5a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87229 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-23tdf#42949 Fix IWYU warnings in sw/source/ui/[c-u]*/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Icf4e6f8ea7c751c8d068dbde50ea1b4726d565d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87004 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-23Related tdf#126459: fix crash in presenter console using gen vclplugKatarina Behrens
A slide with video is needed to reproduce Regression from commit ac87cfdf263d2abd97b32857534d0f749b7c4479, 'toolkit' and 'platform' bits were never set (bc irrelevant) in gen vclplug but now if not set, values mapping to 0 (Gtk3, Wayland) will be used and things go down the drain in avmedia/gstplayer then Just between us girls, nobody in their right mind would use gen vclplug for presentation, but crash is not nice so let's fix this Change-Id: If318ab93897f9f4854f7316e630c35aaec2480fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87185 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-23pdfium: don't patch out the COMPONENT_BUILD check, define itMiklos Vajna
So next time we update, no need to adapt a failing patch. Change-Id: I785f16047d1decbf922177fdde4bc6aad7cfebfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87215 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-23Update git submodulesMike Kaganski
* Update helpcontent2 from branch 'master' to e2e898488f22bd638641ea45f50ef86ccf31548b - Fix "Error: Duplicated entry. ID = hd_id3156192 LANG = en-US" in File source/text/shared/00/00000001.xhp after commit d306cc3fc4d97c5e599acc6ad1bcb068d94085f9 Change-Id: I41f524b4fd3c709100adc6f8d55b3c8bef0e779f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/87231 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-23Use crt functions for IO in unopkg on WindowsMike Kaganski
Since https://gerrit.libreoffice.org/c/core/+/87210, the workaround using WinAPI is not needed anymore, so this unifies Windows behavior with other platforms. Change-Id: I0fa46b6b98a03a7e4d2fd1347b05c15b8f142607 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87221 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-23Revert "unopkg: Correctly display log messages on Windows"Mike Kaganski
https://gerrit.libreoffice.org/c/core/+/87210 makes unopkg proper console application, which doesn't need old complexity of sending UTF-16 strings to console redirected to pipes, so this workaround is not needed anymore. This reverts commit 015e9f780bc133788f79868bb7fb0b1d4e81f5f3. Change-Id: I9ab49df2b9c9cb841e591c07fcea191119dbe382 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87217 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-23Make unopkg.com proper launcher for unopkg.bin on WindowsMike Kaganski
... like implemented in 506173a7f42f34821238a63f3f8c7362c9fae9d9 for soffice.bin. Previously unopkg.com prepared some communication pipes, and launched unopkg.exe, which in turn launched unopkg.bin (both GUI subsystem apps), and when the latter sent output to console, it was redirected to the pipes, and finally sent to console by unopkg.com (details in dropped desktop/win32/source/guistdio/guistdio.inc). The implementation made it impossible to use standard console output function from c/c++ standard libraries; WinAPI had to be used. Special API had been implemented for that: dp_misc::writeConsole*, and still part of output was garbled. Commit 015e9f780bc133788f79868bb7fb0b1d4e81f5f3 tried to workaround that, effectively making loghandler unusable outside of unopkg. This change makes unopkg.com a console subsystem clone of unopkg.exe, and unopkg.bin is now also console application. This allows to cleanup and unify its output in a follow-up commit. Change-Id: I3b299e09f8a11a72883b06442b0e95131ffaac5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87210 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-23Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to d306cc3fc4d97c5e599acc6ad1bcb068d94085f9 - tdf#129517 corrections in position help page for List Styles - update access commands - update labels - add embedded "Reset", 'Apply' and "Preview" controls - clarify about selecting levels - use <menuitem> - adjust heading levels Change-Id: I25cfbe83d02fa67f0f05f0e8fc37acae489c2bb3 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/86932 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-01-22rptuilo-ConditionField does not appear in any .ui anymoreCaolán McNamara
Change-Id: Ibb45c4afc817e7a87ae70521cbca243a6d70525d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87218 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-22flush out unused MapModesCaolán McNamara
Change-Id: I691143162bf9a26171f3ede3bded34c7fb985244 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87207 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-22Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to a51da4ed164a09ce51bd92d3e99ddc9b70c6792d - Resolves: tdf#129497 help about reset for all help pages in paragraph style tabs -finishes adding help about "reset" to all tabs in Paragraph Style -added some help about "apply" to some tabs (conditionally) Change-Id: Ic2e5eccb331763d9f89b3e73ca7fd0b4e88e764b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/87115 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-01-22sw doc model xml dump: show all compat flagsMiklos Vajna
This is handy when they are not in the source document, e.g. DOCX or older ODT and newer compat flag. Change-Id: I62d6623bbe82fca454139ca892929b39fca68dfd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87198 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-22rework line style to be a wide toolbar buttonCaolán McNamara
involves converting SvxLineStyleToolBoxControl to a PopupWindowController because chart is doing interesting things in its panel there needs to be a non-standard way to report/detect the selected line style, which is then reused to disable/enable the arrows when none is selected/deselected in non-chart sidebars SvxLineBox becomes a toolbar dropdown instead of a combobox itemwindow linectrl.cxx split into linewidthctrl.cxx and linewidthctrl because SvxLineBox is now needed in svxcore Change-Id: Icf0ef5e612b894a43d389af8a2908138c2e9c580 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87164 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-22fix crash in popdown of popovers that contain a user-managed scrolling windowCaolán McNamara
which is not at its initial vertical 0 scrolled state Change-Id: I42fea8eb7c230f57184ba8dec8da04153906528e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87195 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-22scroll to make selected entry visibleCaolán McNamara
even before first format Change-Id: Ic19e6dca0c112e8d8a7d570c01bf924d7d0d832d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87197 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-22tdf#83779: convert TRUE/FALSE constants to functions TRUE()/FALSE()Mike Kaganski
This avoids problems with round-tripping Excel spreadsheets, where previously a formula like =IF(ISNA(A1)=FALSE;"a";"b") was imported as =IF(ISNA(A1)=0;"a";"b"), and when exported back, it didn't work in Excel, because boolean values had a distinct type in it. Change-Id: I672a631bfa1a4811349794f714293404c6b24381 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86238 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-01-22vs-ide-integration: Also add .c filesMike Kaganski
Change-Id: Icb4e879025278291270d908bb53178250c8e7007 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87192 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-22 don't warn about 0/0/0 year, commonly used as a default-value/no-valueNoel Grandin
Change-Id: I2f6dc371f99d6963753ffaf5365a7d69ca866ca8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87190 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-22avoid some unnecessary log warning messagesNoel Grandin
Change-Id: I72f839800b749bd5c90faea9f2fed25dd938bca4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87187 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-22Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 37a6f521ec6303193d6057736ff414ef7c62c6d4 - update translations for master and force-fix errors using pocheck Change-Id: Idf82bb4c2e7f863f2807524fdea1be4d11b88c2e
2020-01-22Add case table for Old HungarianAlex Henrie
Change-Id: Ie49a7b8866ab9c608cca87721fe175c575ffbf26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86566 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-01-22inline some construction methodsNoel Grandin
only called from one constructor Change-Id: I082cf3b459c936b79a6df695fffac5e3cf43705b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87186 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-22tdf#129786 give correct title for Draw dialog boxSeth Chaiklin
Change-Id: Ied53edf066ce8a554899848f261a272f812121cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87180 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-01-22tdf#77419 DOCX table import: ignore right white spaceLászló Németh
in table paragraphs in MSO 2010 compatibility mode. Change-Id: I99f11c6a9f7a5735cce06fac433d5acab704cb04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87136 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-01-22use fastparser in SwXMLBodyContext_ImplNoel Grandin
Change-Id: I0745fb6eb0a46b1c564cd0f1c596aed5206549b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87181 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-22tdf#129829 sfx2: fix handling of password to open vs modifyMiklos Vajna
Regression from commit e0f20211a8048a87b078aa4cf0f28c0c847487ad (sw reqif-xhtml import: add a new AllowedRTFOLEMimeTypes parameter, 2019-12-16), the problem was that in case the (input) stream for an opened document is kept alive, then we don't try to re-create it, which means providing a different password behaves the same as providing the same (wrong) password. It seems CheckPasswd_Impl() in sfx2 only calls comphelper::DocPasswordHelper::requestAndVerifyDocPassword() in case we don't have a decrypted stream already. Fix the problem by deleting those streams from the remembered input parameters, the interesting ones have custom key names anyway. [ No testcase, the problem is Windows-only and it's not clear to me why the behavior is platform-specific. ] Change-Id: I2fc1f0567244897caa18548161fe426ac7d0dfd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87182 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-22use fastparser in RptMLMasterStylesContext_ImplNoel Grandin
Change-Id: If66ee8d6441fea0a2bb9c6b8a956ecd94f025746 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87177 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-22tdf#129382: sw: assign names to shape object stylesVasily Melenchuk
Empty style names for drawing object will cause problems with udo/redo which right now refers style names instead of style pointers. Change-Id: If2266f1db04c624dbfdd716b5599d5f6cbb5371e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86520 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-01-22tdf#42949 Fix IWYU warnings in basctl/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Id956a2aaffb7ac8787847eedc4860bf9f4b70184 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86943 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-22use fastparser in ScXMLMasterStylesContextNoel Grandin
Change-Id: I02a303fb9940749fbd1ae3e951b1b9bbf4a3052e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87176 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-22tdf#130112 lok: Do not apply zoom-factor twice...Dennis Francis
... in ScOutputData::FillReferenceMarks(). mnPPT[XY] already has the factor aZoom[XY] in it. Refer ScViewData::CalcPPT() to see how PPT[XY] are derived. Change-Id: I3f9b5c01cb53514450fad5f7b2b6861b112effdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87158 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 3f62c10548466119ec6b1a662ab339e5dbe0b05f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87170 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-01-22use fastparser for XMLFontStylesContextNoel Grandin
Change-Id: I7b273cdc0f90f2a8c9527d1f19fed97672a74741 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87175 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-22sw: add DOCX export for semi-transparent textMiklos Vajna
This is the case when the value is not in the grab-bag, that was already supported. Change-Id: I334333ec441644229540a358d7bf8811373618c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87162 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-22android: Use system locale by defaultMichael Weghorn
Instead of hard-coding the use of English as default locale and allowing manually selecting another language, this now makes the system's default locale to be used by default in the Android Viewer. It's still possible to explicitly select another language to override that. In case there is no localization for the system locale, an automatic fallback to English happens anyway, so there should be no need to explicitly set the locale to English in that case either. Change-Id: I0b8cfafea6a4659c3657522cfd5895c00f25f054 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85583 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-01-22Android Viewer: Add German localizationMichael Weghorn
Change-Id: Id62bbb9404c51bf529bd7932d66e49b01d3d9c8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85125 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-01-22Convert reportdesign to fastparserNoel Grandin
Change-Id: I0703344aad4ca6c72e494160b019c13e24cc843a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87160 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-22rework of painting and removal of ImplAnimView using the STLAdrien Ollier
Change-Id: I9bcfd3e034097c0a3ba17a566201d708cec2b016 Signed-off-by: Adrien Ollier <adr.ollier@hotmail.fr> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87167 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-21Sidebar position and size updateandreas kainz
Change-Id: I8a5a6f088f6b4dffd051ee577999d1d1eeff8a17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87163 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-01-21Revert "Related: tdf#130035 let SvxLineEndWindow have a menubutton parent"Caolán McNamara
This reverts commit 08e633d777f1d2cf11a93ccb55f231d084f3220c. Reason for revert: unnecessary if we use the toolbar in the sidebar without bringing any menubutton into it Change-Id: I8392d01415af2f5e60aa70abe52e4809f52621fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87142 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-21rework ImplAnimView cleanup using STL algorithmsAdrien Ollier
Change-Id: Ie8c857f992d27bb0d70968256eea5d8f2491405e Signed-off-by: Adrien Ollier <adr.ollier@hotmail.fr> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87030 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-21Fix typoAndrea Gelmini
Change-Id: Ie4c9881fb9244980b4161275a08fac229efee88e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87147 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-21use more FastParser in SvXMLStylesContextNoel Grandin
Change-Id: I05c7314739246a864b16723c13bd8fbb4ef725e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87146 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-21use more FastParser in ScXMLChangeInfoContextNoel Grandin
had to hack the token constant generating process a little because we have two tokens that only differ in "-" vs "_" Change-Id: I0744d697918d28cca0c92b83ecfd37c1ae9d2bae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87138 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-21PDF export: don't ignore FilterData specified by UNO clientsMiklos Vajna
The data was given to the PDF filter, but then we stopped iterating right after finding our output stream. Seems this was always like this, ever since commit 4111b430a0a7954416ff95794a8ffb8fbc4472e3 (#101570#: added pdf filter, 2002-08-13). Change-Id: If26661935c22a7b7959fda5f92b4d50b15f13a35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87152 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-21remove unused GSOC 2005 "Tabbed Document Windows for OOo"Caolán McNamara
this was #i54847# Change-Id: I312e3ea9b123976e9929f6601a931ff8a108d7b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87113 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-21Sifr: Add more 32px extra large icons (tdf#129846)rizmut
- Add more 32px icons - Add localization items - Update frame, extrusion tilr - Add non cmd icons (spacing Writer sidebar, hyperlink insertion dialog, gallery items, page margin, orientation, etc) Change-Id: Ibbb91ecb6ccd9abf482c4bc2baa7d84f750112f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87144 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> Tested-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
generated by cgit (git 2.34.1) at 2025-01-31 13:41:48 +0000