summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-03-17round polygon points before merging them for Skia drawing (tdf#140848)Luboš Luňák
basegfx::utils::mergeToSinglePolyPolygon() appears to have rounding problems. Point coordinates are in pixels anyway. Change-Id: I9880cc32f934a08923a5c59278f6aa07852c05f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112647 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit ff1cfaf87ce0aa9673e1c3f92308cde6a2c6aa69) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112615 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-17tdf#141015: Show Mail Merge toolbar when DBData has data sourceMike Kaganski
Change-Id: I74ea06b47d851d979103599526ae970035854dae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112465 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 346153f08c907739ca310934ad45814379971027) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112514 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-17tdf#122894 skipping anchor in column in footnoteCaolán McNamara
a trawl of crash testing document didn't show up another example and it doesn't seem possible to create this scenario directly in out UI Change-Id: Ie65a51bf609e8bacd261f368f0b8037431c116ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112567 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112581 Tested-by: Caolán McNamara <caolanm@redhat.com>
2021-03-17tdf#141021 Correct sign in Origin in Extrusion NorthRegina Henschel
This is about customs shapes in 3D mode using direction floater. Shapes, which were created with older versions, keep their values until the direction is newly assigned. So the change will not automatically change existing documents. Change-Id: Ib1ce511de0f524bf59279fb4e976f66ed65bc080 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112474 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> (cherry picked from commit fa8d00560bbfededec7f2c328f04eb2b369c00e2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112617 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-17tdf#141011: Postpone SwFieldDBPage::Reset to tab activationMike Kaganski
This way, it will only ask for password when dialog is switched to that tab. Change-Id: Ie2a453b0b6867ceb1ef3728a8565de4f6cbf4757 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112469 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 0adf52a644aaf85ba2bd666147c62c134234ffbb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112516 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-17tdf#141012: do not try to expand the node if RequestingChildrenHdl failedMike Kaganski
Just select the database node itself, so that it's still obvious which database is associated with this document. After selecting this node when initializing the tab, another call to SwDBTreeList::Select will be made, so make sure to handle empty table and column names. Change-Id: Ie1d1bd445e18d5900910c780a24102b4dde5c787 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112467 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 351edb44eb0548f7e56464de42c1758a1f5e4ab4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112515 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-17tdf#40427: use node index as position, not Y position on screenMike Kaganski
As mentioned in comment to SwContent::nYPosition in sw/source/uibase/inc/swcont.hxx: some subclasses appear to use this for a tools/gen.hxx-style geometric Y position, while e.g. SwOutlineContent wants to store the index in its subtree Abusing the nYPosition to store vertical position *on screen* gives wrong results when a following section is positioned on screen higher than a previous section - e.g., when multiple-page view is active. So just use the section's node as Y position of the Navigator entry. When the section is inside a fly frame, use the frame's anchor node. Change-Id: I6caf26aeb19d845129dc837138c37f42bbc18655 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112197 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 4caf4403c1b862e7ccca94b9caee31394d019732) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112226 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-17CppunitTest_sw_ooxmlexport: clean up testEffectExtentMarginMiklos Vajna
The shape had line information, but the intent was to test what happens when the shape has some non-zero effect extent, line information is not needed for that. And do the same for a bunch of other tests: a test document should ideally have line information only if it's relevant for a test. (cherry picked from commit 0fc76a646233bebebbca3f86144f30eb32a5d60c) Change-Id: I9ea1f38841a30e7e61088d347443e37948b1a9d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112586 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-17tdf#134607 use kMDItemFSName instead of _kMDItemDisplayNameWithExtensionsChristian Lohmaier
apparently the latter is not available on older versions of macOS. https://developer.apple.com/documentation/coreservices/kmditemfsname lists it as in version 10.4 and not flagged as deprecated, so keeping fingers crossed that it is not affected by user-settings or similar… Change-Id: I208d22f2abd628e7d95babc23ddb145a88bcf5cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112385 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit daa162c20f4c7d61edc217ed44cb2854652a63ec) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112527 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-17tdf#136956 reorder undo actions in removeColumnsMark Hung
and removeRows. Inside the removeColumns and removeRows, undo actions are added first, and then cell spans are updated to reflect the removed columns or rows. Once undo the cell spans they become immediately invalid because the rows or columns are already removed, hence cause Impress to crash. Change-Id: I9d8641bdad43026eca03cbeaaa3a5907b516304f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112355 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com> (cherry picked from commit f3f7cc53efda828af8897fa45fa2a8f18cf3b48b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112526 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-17tdf#140986 hang in validity messageNoel Grandin
this doesn't fix the root of the problem (something generating an insanely long validation message). It just prevents that problem from locking up the UI. Change-Id: I334729a30eca4a11d0150e3c89ff11c92a862061 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112461 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 924733c65902d0b17764aded56c88c99d4b9a568) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112529
2021-03-16xls save: fix writing inline calendar modifiers as format code, don'tEike Rathke
E.g. ja-JP GGGE [~gregorian]YYYY saved as OOXML ended up as [$-411]ggge\ gregorianyyyy which when reloaded became GGGE GREGoRianYYYY displaying 令和3 R033Ro03ian2021 (whatever Xcl might have done with that). Change-Id: If8a7d5b837b69c32afacc7a8d7646fedc84ab87a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112510 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 3e73d3475711b790cc80b9a286c5d454f3929384) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112519 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-16Revert "tdf#114076: Expand ClipRange to next PixelBound" ...Xisco Fauli
and "tdf#124272 use ClipRegion's geometry if not a rectangle" This commit reverts c1230cede19ae3633e51c7ca780cb34d9dbaa20f and 362c1cf2bd580f6dc8bf27bdcd79174111bc1b5c tdf#114076, or any of its duplicates, is not reproducible in master if c1230cede19ae3633e51c7ca780cb34d9dbaa20f ("tdf#114076: Expand ClipRange to next PixelBound") is reverted. (Tested on Linux and Windows) So, if we revert it, we no longer need 362c1cf2bd580f6dc8bf27bdcd79174111bc1b5c ("tdf#124272 use ClipRegion's geometry if not a rectangle"), which was a follow-up fix for a regression introduced by the first commit. This also fixes tdf#129085 and all the duplicates, which were introduced by the follow-up commit. I plan to add the unittests in a different commit Change-Id: Ie4328c15b24b521127c1b653bd621bfc92ac39cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112340 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112398 Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-03-16tdf#139804 Focus form controls inside document with Alt-<Mnemonic>Samuel Mehrbrodt
Change-Id: I710a23a53ca0eb256a477a78ce1b7ae01129f717 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111865 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> (cherry picked from commit 67ad205404211a2ae17c430a17ede6e9d04d0b7e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112431 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-03-15tdf#141045 - fixed copy paste error in the replace functionAndreas Heinisch
Change-Id: Id68670fed89e4cc700c5eea395139914bebdb657 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112509 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> (cherry picked from commit ac0b6fb3842201e438950ea99a55ad334f8521ab) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112512 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-15tdf#127217: Fix buttons in forms not working in Adobe ReaderJulien Nabet
Regression from 76b5dca9dc0ff60f8f62cbecdee68f8f3b287ceb: author Thorsten Behrens <Thorsten.Behrens@CIB.de> 2019-04-09 02:19:14 +0200 committer Katarina Behrens <Katarina.Behrens@cib.de> 2019-07-03 14:48:45 +0200 commit 76b5dca9dc0ff60f8f62cbecdee68f8f3b287ceb (patch) tree e778dad33073a228eb61ab62ce5f38e2a26d07ca parent 1e8a9c19a6f7b82c9e0c481aee0c04c0780f4433 (diff) tdf#113448 don't export any font for radio buttons Don't let only color value in m_aDAString since it'll go here: if( !rWidget.m_aDAString.isEmpty() ) { if( !rWidget.m_aDRDict.isEmpty() ) { aLine.append( "/DR<<" ); aLine.append( rWidget.m_aDRDict ); aLine.append( ">>\n" ); } else { aLine.append( "/DR<</Font<<" ); appendBuildinFontsToDict( aLine ); aLine.append( ">>>>\n" ); } aLine.append( "/DA" ); appendLiteralStringEncrypt( rWidget.m_aDAString, rWidget.m_nObject, aLine ); aLine.append( "\n" ); if( rWidget.m_nTextStyle & DrawTextFlags::Center ) aLine.append( "/Q 1\n" ); else if( rWidget.m_nTextStyle & DrawTextFlags::Right ) aLine.append( "/Q 2\n" ); } But if we shouldn't have /DR at all since we don't want fonts for radiobutton, it also means we don't want /DA too. Indeed at the end of 12.7.3.3 https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf: The default appearance string (DA) contains any graphics state or text state operators needed to establish the graphics state parameters, such as text size and colour, for displaying the field’s variable text. Only operators that are allowed within text objects shall occur in this string (see Figure 9). At a minimum, the string shall include a Tf (text font) operator along with its two operands, font and size. The specified font value shall match a resource name in the Font entry of the default resource dictionary (referenced from the DR entry of the interactive form dictionary; see Table 218). Change-Id: Ib350495d7fc5a7a4fba88d710614a0f67a0b1553 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111724 (cherry picked from commit a0d63ee5df921e5f1ac915ada783fdef0dbbb057) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112305 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-15tdf#126742 make Windows file handling more unx-likeArmin Le Grand (Allotropia)
The bug mentioned happens due to a system-dependent difference: Unx-systems allow files to be opened for write multiple times while our windows implementation until now did prevent that. For that reason an embedded OLE which is still opened in the same LO instance behaves wrong/strange - the e.g. changed size cannot be written (to the file). Since we already have unx-like handling and in that scenario useful sync has to be done anyways, no new scenario will be created. Only Windows implemenation will change to behave closer to unx-like behaviour, I already test-built that on gerrit to make sure all tests for Windows work as before. I thought about this for quite some time, but see no too big risk. For thoughts/discussion please refer to the task. Change-Id: I8dbfd70c2f69d0a013f445e152e597f37fa6ecc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112237 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> (cherry picked from commit 2b4cd99d3360ccffb9829a02412824864d045753) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112427 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-03-14do same set error state as ReadAndVerifySignature doesCaolán McNamara
this function is nearly exactly the same as ReadAndVerifySignature except it doesn't set error-state on exception during parse Change-Id: Ife881f639a11d3185920ca62cc2cd22812fae36d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112366 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112394 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-03-14tdf#140136 sc: fix tree list expansion in AutoFilterAttila Szűcs
Now clicking on +/- buttons (i.e. before the checkbox) only expands/collapses the tree without toggling the associated checkboxes, using the new GetItemPos() to get the position (and width) of the checkbox in the actual list item. Regression from commit 2471d6f44c7e8ecbe86a90eeb593b899a08a7408 "tdf#116675 vcl tree list: toggle by label click (e.g. in AutoFilter)". Note: Use generic VCL plugin to test it on Linux: SAL_USE_VCLPLUGIN=gen instdir/program/soffice Co-authored-by: Tibor Nagy (NISZ) Change-Id: Iceb17bc9b235d297c313361429ee89f04d809e96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111668 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 216f32464ccb0f096e5fdf77f82baf30ae7bab5f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112308 Tested-by: Jenkins Reviewed-by: Attila Szűcs <szucs.attila3@nisz.hu> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-03-12TipOfTheDay: remove odd tip regarding GSOCXisco Fauli
Change-Id: I4d7111de1fb734c51e6449913caa52adaf43b594 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112381 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 6cae56fe25a51c9c0ec05253be8508940a013eee) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112415
2021-03-12tdf#140977 drop possible table-cursor before setting the new oneCaolán McNamara
Change-Id: I3d278af77886af3413b4a15464c8a52caa9a8e02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112310 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-03-12sw: DOCX export: put fly before fieldmark start into its own runMichael Stahl
If a fly starts at the same position as a CH_TXT_ATR_FIELDSTART, it is anchored before the field, and written in OutFlys() before the field is written in EndRun(), but the DOCX export reorders things in confusing ways. StartField_Impl() and CmdField_Impl() will actually end the current run (after putting the field char in it) and start a new one. So do something similar in this situation and create a new run if flys have been processed. Restrict this extra run to when there is actually a fly, because otherwise a dozen tests break; this requires a new FLY_NONE result for OutFlys() because FLY_PROCESSED is returned even if there are no flys. Change-Id: Id469c53d07eacad3992c7c0e451ab3756e02c8fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112267 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 3eced2d52415abeac266804ab682bee022322a19) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112230 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-12tdf#140590 Crash in Save-As dialog in Tools>Chapter NumberingNoel Grandin
This would only affect assert builds. The assert condition here did not match the condition in createFastChildContext several lines below. Bug since this code was introduced in commit 1535f39388223de53e4b923c6f7bb71ee32c1858 Date: Fri Nov 7 19:11:11 2014 +0100 sw: store Outline Numbering as ODF fragment instead of SfxPoolItems Change-Id: I3f6a0b91e3c17f4ca358a75116481fc38c01e94e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112233 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 677a18c2e16c5c1ae6be8d30e1a967f41fbf67a0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112303 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-12tdf#89754 - don't increment non different consecutive date cellsAndreas Heinisch
Change-Id: I6fedc0fe286ebe8b0110360391e8d3325fc2ca25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112054 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 3ba901f050d262cdeccefa5b21b0d32aa7332dc7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112295 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-11tdf#127471 Detect&Correct EMF/WMF with wrong FontScaleArmin Le Grand (Allotropia)
Before correcting our EMF/WMF export to write the Windows- specific data in the case of FontScaling, we wrote these files with wrong FontScaling. This change tries to detect and correct this at import, so that newer versions of the office on all plattforms can again load old, from us but not on Windows written EMF/WMF files. With this change we can read again all new and old EMF/WMF files (see table in task, comment 80). Change-Id: I1a0b0ab5f57c7cd40520401568af05cab4ecb4c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111399 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> (cherry picked from commit 3d33e4ce3987ea17e73a72e84f7f0df7af8101a6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112222
2021-03-11Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'libreoffice-7-1' to 84fc53d74283a053b3002d9108a1760369b6b606 - tdf#140395 remove "blinking" control from font effects The "blinking" property was removed from the UI (see tdf#132373). This patch removes the property from the help page, along with its bookmarks. Change-Id: I3b1317e7664e3bcd1813a0d0882eff109ede95fd Reviewed-on: https://gerrit.libreoffice.org/c/help/+/112293 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins (cherry picked from commit a50530fe4e224b01f37cd9c959d3bded32b8bd6a) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/112302 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-03-11tdf#140292 sw: fix z-order of textbox on undoMiklos Vajna
Regression from commit 200cd2b99bee18962a970edc5d059286f6c3ea0e (tdf#138995 DOCX import: fix handling of textbox zorders, 2021-01-11), the problem was already fixed by Michael Stahl, this just adds a test for it. Change-Id: Id613224d5fab0c2d2a3bdfd58bff6d77a92dd374 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112181 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112273
2021-03-11tdf#140292: (related: tdf#133487) sw: fix ordering of virtual SdrObjects for ↵Michael Stahl
textboxes Calling XShapes3::sort() on export of the testTdf130314 fails because of 2 consecutive textboxes; the function requires a textbox to immediately follow its shape in the list (i.e. textbox has OrdNum of shape + 1). This is because for shapes in header/footer, one virtual SdrVirtObj is created per page where the header/footer is shown, and the SwFlyDrawContact::GetOrdNumForNewRef() does not take textbox ordering into account. It's not clear if the assumption that the shape's SdrVirtObj is created before the textbox's always holds, but let's try this for now. Change-Id: I860896471211bf6c142ab825f298f4d4c0eec148 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112029 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112272
2021-03-11forgotten ComputeScanlineSize() (tdf#140917)Luboš Luňák
Change-Id: Id139cea52832b7973dfac47d309d5bba8299b4e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112263 Reviewed-by: Mark Hung <marklh9@gmail.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins (cherry picked from commit 7ba7a1170a46ad340d06822a03f7196ccef29d84) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112227 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-11tdf#140865 roundtrip pptx wordart 3D, add sp3dRegina Henschel
Change-Id: I446ae4e8c9dd5f2fbf3efe289681339f967c515a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112185 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> (cherry picked from commit dbbb8cafcb801638bde3b21796eaebfc807acbdc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112229 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-10bump product version to 7.1.3.0.0+Christian Lohmaier
Change-Id: I5aea53cd7428ea7751076ffcda38270fda4f0767
2021-03-10Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-7-1' to 3cc01e19df4c04f4f48376925d5d145530d57b4b - update translations for 7.1.2 rc1 and force-fix errors using pocheck Change-Id: Iadb5e48222cc660cd2dc8852006c249a00435c15
2021-03-10Adapt buck build to jars merged into libreoffice.jarRene Engelhard
Since ae855bf48163ff64d94cfc34aff8e37abdb5518d and 35518c92365cc183ba6cce2a4d284a130c0ca13f the ridl,jurt und unoil jars were merged into libreoffice.jar. Adapt the buck build correspondingly. Preserve the publishing of merged jars for now with dummy content and consider to remove them in future releases. Test Plan: 1. To replace version number with upcoming release version: $ solenv/bin/version.py 7.1.0 2. To install the API to local Maven repository: $ VERBOSE=1 buck build api_install 3. To deploy the API to Maven Central: $ VERBOSE=1 buck build api_deploy Change-Id: Id1b2135682ab962c901b944f3c26aeead9a4b19b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93724 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit ea8d6cd59670854cb153c4e984cb4044093e5994)
2021-03-10Fix an OUString constructionStephan Bergmann
...introduced with 9d161857f1d4afcb772b477455797a2da0e47a9b "tdf#127471 correct EMF/WMF im/export for scaled font" Change-Id: I2b807e102ca7f71a61794f511dee302c7e509026 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111095 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit e0f2256b90fb30a5a7858f93c168d9da12061e70) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112221 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-10tdf#140597 DOCX import: fix missing tblPrEx borderLászló Németh
of first table cells, caused by the workaround for tdf#138612. Now property set of a new cell is a copy of the table exception property set of the table row, as needed for the import of the table style inheritance. Regression from commit f319d6b543c2367546bc80d138e56ed03731e265 (tdf#138612 DOCX import: fix lost part of split table cell). Change-Id: Iaf6637e757fbfeef7651a4300a7f65a23615f5c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112247 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 53884e8fe92597e909e4fa5599192783c3d31a56) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112223 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-10tdf#140674 sw change tracking: fix :emoji: replacementLászló Németh
Regression from commit 2951c96bcb673a260a09e2c6eb92ca0f99bf0c18 (tdf#83419 sw change tracking: clean-up autocorrect). Note: only :snowman: -> ☃ was added to the test autocorrect file acor_en-GB.dat. Change-Id: Ic3013e969ab937a5f9e5b6d1a6fac2f533b541f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112166 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit db999ddee7a890390f66d7e34906066c8bf178da) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112218 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-10tdf#140498 middle-button paste doesn't depend on a vcl::WindowCaolán McNamara
Change-Id: I4f1f14994b35cec51761689875bf6b5135612f3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112085 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-10tdf#133473 Change SDRATTR_SHADOWSIZEX flag.Gülşah Köse
SDRATTR_SHADOWSIZEX holds a percentage value. So we shouldn't use METRIC_ITEM. Change-Id: I9f1a20d5871f60d2899ef7d525f4cf837b0a9088 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111311 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112241
2021-03-10tdf#127471 correct EMF/WMF im/export for scaled fontArmin Le Grand (Allotropia)
If FontScaling is used, system-dependent data is held at vcl::Font Width(). Already if not scaled, we have three definitions: Width is zero, Width is equal to Height (unx) or - on Windows - Width equals avgFontWidth. If used it is W!=H where on unx Width equals Height multiplied with the scale factor. On Windows, this is Width multiplied with the only there existing avgFontWidth. Unfortunately that is ex/imported (since ever) undetected to EMF/WMF thus making EMF/WMF files containing FontScaling system-dependent - on which system was LO running when creating the file? The error can be seen when loading such a EMF/WMF on the vice-versa system, the FontScale is very ugly and wrong. Since EMF/WMF *are* Windows-specific formats the Windows-like definition is the correct one. This change makes all other systems export that now, and adapt on import to their system- specific definition (assuming coming from Windows). As can be seen, the difficulty is that these adaptions are necessary on non-Windows plattforms, but these do not have that avgFontWidth available. Thus I made a deep-dive investigation and multiple experiments to create a as similar as possible value to apply the needed calculations. For details and discussion refer to the bug description. Change-Id: I983fb6d882e2e8fccf9c8460f01509201d8157f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111000 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112089
2021-03-10Reset ShapeProperty priority and handle only crop case.Gülşah Köse
With 2c96bd26ec488d865370fe9d394e7c4e228e05ab we changed the ShapeProperty priority uncessarily. Reset the priority as use FillBitmapName if supported. BlipFillProperties::moFillRect negative GraphicCrop values means stretched. BlipFillProperties::moClipRect positive GraphicCrop values means stretched. We add a control to handle only stretched cases. Change-Id: I2eb1233d0477acf093ada36b4cc29ff34f767037 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111479 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112242
2021-03-10Prevent the unnecessary lclCropGraphic call.Gülşah Köse
In case text::GraphicCrop aGraphCrop( 0, 0, 0, 0 ) we don't need to call lclCropGraphic. Change-Id: I9960900f9b5c5b770824c76ffeb9ec9b51cbaef3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111401 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112240
2021-03-09fix ScFlatBoolSegmentsImpl delayed setup with threads (tdf#140754)Luboš Luňák
Change-Id: I258263f6a15e7098a2292ba7f3336fcaaf5224ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112184 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 2fb274950e5207ca55f4f52325fb522bd44024e1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112212 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-09tdf#140661 Give shapes names when ungrouping if they don't already haveJim Raykowski
Change-Id: I8242a697980e4f661a914998792ae9efdb090915 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111725 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit 1c3e170d56d3cad1e7729f839fa63f607b62e4e3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112215 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-09make RenderMaskPrimitive2DPixel() clip using clipping (tdf#140797)Luboš Luňák
The original implementation had this peculiar idea of implementing clipping using transparency, which slows everything down, because contents need to be copied and then alpha-blended. Keep that only for when edges of the clip are to be smoothed. As a side-effect this also seems to fix tdf#115843 again. The commit also adjusts the test for tdf#133477 to not rely on the rounding introduced by the optimization from tdf#115843. Change-Id: Iebae5996159cf9f17066205985c5b591abdae105 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111966 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 6b8c157a0b4f37a09fdbf656919b2df06a3abc3e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112217 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-09Improve unit test accuracyMike Kaganski
I didn't take clock resolution into account when created the test, and it failed for me occasionally because the value was slightly less than expected. The typical system tick resolution is documented at https://docs.microsoft.com/en-us/windows-hardware/drivers/kernel/high-resolution-timers Change-Id: Ie48b10d15b14f9ac7d292a2cc9916bcbfff44b6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111946 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit eef43192d4c7b2867638c54a2ac31adfc26476c7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112076 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-09make both 'empty' widget and its treeview replacement the same sizeCaolán McNamara
so on flipping one visible vs the other the panel scrollbar position is equally valid for each mode Change-Id: Iae422c30eb8b752c407070b66852fe23fdc38912 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111925 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-09allow focus into master page panelCaolán McNamara
Change-Id: I34ab8ad6d267ffaab8ead2581e0d892ee37ec095 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111921 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-09master slide panel shouldn't have "more options" buttonCaolán McNamara
default the toolbox to hidden and show it if "more options" is enabled Change-Id: I6ff867268809d949e7854e0e76d3e45c8806797b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111955 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-09tdf#116983 tdf#136175: retry if failedMike Kaganski
Debugging the test case from the latter bug report shows that indeed the call to OleGetClipboard may fail first time, as jasonkres had suspected in the former bug. So follow the suggestion in tdf#116983, and retry the failing calls several times in case of failure. Many thanks to Telesto for preparing a clear bug report with reliable test case. Co-authored-by: jasonkres Change-Id: Ib3c497da830bc5faac586bcfe1eededa54bfa117 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111825 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit cf1c835e8016f8f1eefea6d625a913c0ac343a63) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112075 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-09tdf#127471 improve SVM FontScaling im/exportArmin Le Grand (Allotropia)
Due to svg::Font Width and it's expression of FontScaling being system-dependent the FontScaling when exchanging beween win-based SVM creators and others was creating errors. Corrected this to work now with newly created SVM files in both directions. For more aspects see discussion in task. Change-Id: I326e4e7e895a9dfc3cdfc5323174ca81e22795e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110330 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> (cherry picked from commit 40b56cd8da8c38582dc4660b486993d1b4711535) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112088
generated by cgit (git 2.34.1) at 2024-07-07 03:18:57 +0000