summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-07-31dbaccess: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation Change-Id: Icbce3ef3f77a19f9174f6aa39791dcf99e51f0c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98395 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-31ASan/UBSan build still needs VCLXEdit RTTIStephan Bergmann
...after 0c311bfbf67441823f8b3916db963e2680e9eb43 "make some classes private": > warn:sal.osl:729320:729320:sal/osl/unx/module.cxx:162: dlopen(instdir/program/libacclo.so, 1): instdir/program/libacclo.so: undefined symbol: _ZTI8VCLXEdit > warn:legacy.osl:729320:729320:toolkit/source/helper/accessibilityclient.cxx:183: AccessibilityClient::ensureInitialized: could not load the library, or not retrieve the needed symbol! > cppunittester: include/com/sun/star/uno/Reference.h:381: interface_type *com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleContext>::operator->() const [interface_type = com::sun::star::accessibility::XAccessibleContext]: Assertion `_pInterface != NULL' failed. during CppunitTest_sw_accessible_relation_set, with > $ find workdir/CxxObject/accessibility/source -name \*.o -exec bash -c 'nm "$0" | grep -F _ZTI8VCLXEdit && echo "^ $0"' {} \; > U _ZTI8VCLXEdit > ^ workdir/CxxObject/accessibility/source/standard/vclxaccessibleedit.o Change-Id: Ic1f5fcfa1ba2d415bc6f0e076a2e24daadf86d7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99823 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-30loplugin:flatten in sw/ui/dbuiNoel Grandin
Change-Id: Iab627f306a1caf52237369471393753bf2c736f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99804 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30loplugin:flatten in sw/filter/xmlNoel Grandin
Change-Id: If018f8b03816d8110bd3ba9eec3f26373e6c5a6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99803 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30loplugin:flatten in sw/ui/dialog..sw/ui/tableNoel Grandin
Change-Id: I2350c1d3f5fab727b0d47b6f3684804b77e68122 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99805 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30inline some use-once typedefsNoel Grandin
Change-Id: I66400bcfef1d609662f44cc25a4984b68efb4b44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99801 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30Update git submodulesCaolán McNamara
* Update helpcontent2 from branch 'master' to 1749b770bbfe4aeb1296c48cc9d20cb947a04e47 - fix broken build due to duplicate id since... commit d3a14f08c6a430a62cb46f130a494e305ebdf275 Author: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Date: Wed Jul 29 17:56:22 2020 +0300 Rethink some switch statements in Format Menu -related listings Change-Id: I5763023b30a21f6c1d0cc0f450ebf3337164b43b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/99808 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-30loplugin:unusedmethodsNoel Grandin
and tweak the plugin a little to speed it up Change-Id: Ia59456232602184c4f1b5d1d75ad94a9a2e2d0be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99799 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30ASan/UBSan build still needs DateField RTTIStephan Bergmann
...after 0c311bfbf67441823f8b3916db963e2680e9eb43 "make some classes private": > [GAL] sounds > instdir/program/gengal.bin: symbol lookup error: instdir/program/libtklo.so: undefined symbol: _ZTI9DateField > make[1]: *** [solenv/gbuild/Gallery.mk:56: workdir/Gallery/sounds.done] Error 1 with > $ find workdir/CxxObject/toolkit/source -name \*.o -exec bash -c 'nm "$0" | grep -F _ZTI9DateField && echo "^ $0"' {} \; > U _ZTI9DateField > ^ workdir/CxxObject/toolkit/source/awt/vclxwindows.o > U _ZTI9DateField > ^ workdir/CxxObject/toolkit/source/awt/vclxtoolkit.o Change-Id: Ica4f1ce6dfd5de0a3ca6cdddd59f85831348b81e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99802 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-30loplugin:flatten in sw/uibase/dbui..sw/uibase/envelpNoel Grandin
Change-Id: I20dc75b75e999ed82d221072d6ecaf2c02c834eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99793 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30loplugin:flatten in sw/uibase/app..sw/uibase/configNoel Grandin
Change-Id: I903631568cc5285bf167ba3f0dadb95dbcd43a21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99792 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30loplugin:flatten in sw/uibase/fldui..sw/uibase/ribbarNoel Grandin
Change-Id: Iff2bd302c3a6cc23be462e5a59aee0d12e7e7c09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99794 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 0b8d7ce936d4586bb8f46d3183977707122c703d - remove dup bookmark_value Change-Id: Ifddb1780f2504cb3307abd1032878f28f3106e1f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/99744 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-30fix leak in Mork::OResultSetNoel Grandin
Change-Id: I2e915762aca653acb7f9e1b322459f83297a997f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99786 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to d3a14f08c6a430a62cb46f130a494e305ebdf275 - Rethink some switch statements in Format Menu -related listings Also revert changing an icon from png to svg Change-Id: I956c8630530ae48ef68aadd1db50fe3ebaed2d0b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/99707 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-30loplugin:flatten in sw/uibase/shellsNoel Grandin
Change-Id: I003c2c4e48bb59590ba952c74e3ee4733ce1051f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99764 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30Add an optional Gerrit change ID to testfeatureJan-Marek Glogowski
This way it's possible to have all test runs in a single change, so it's easier to check different results. Change-Id: I1aa3a229f5ee3ba12dbd2c18328d34c8a4528c07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99688 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-07-30Resolves: tdf#134831 reorg to expand inspector to fit full panel sizeCaolán McNamara
Change-Id: I73e37dff01d67f04ea5a2a82e4083ffd5bd46440 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99774 Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-07-30tdf#134252 sw_redlinehide: fix SwUndoDelete for table before end of sectionMichael Stahl
In this funny case, the SwPaM starts inside a section, and ends in the first text node following the end of the section, which happens to be in a different section (but that doesn't matter)... this is because IsSelOvr() moves the end of the selection resulting in the 3rd SelAll off of the table end node (as the section ends with a table), but then it's on the section end node and moves forward again. SwUndoDelete::UndoImpl() must first create the outer section frames, skip over the start text node which has frames handled by RecreateStartTextFrames() and then create the frames following the start text node, where the end node of the outer section now finds its expected outer section frame. This relies on the code from 55576842ec72a748d0bad123d41fa03c89fc136d to move the existing text frame below the new section frame(s). (regression from 6c7245e789f973cf6dad03f7008ab3f9d12d350c) Change-Id: I9f39b09e603e75ef813d5c855d828ec9bd5fdd95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99723 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-07-30loplugin:flatten in sw/uibase/utl..sw/uibase/wrtshNoel Grandin
Change-Id: I9010524952ce3b99a62e53dbf715a72c86a89b01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99766 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30loplugin:flatten in sw/uibase/sidebar..sw/uibase/unoNoel Grandin
Change-Id: Ifc9c838ffc94e89d2049969ef28d66fed853548b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99765 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30tdf#38093 Writer outline folding - persistenceJim Raykowski
Patch 6/6 that breaks down https://gerrit.libreoffice.org/c/core/+/96672 Adds persistence attribute loext:outline-content-visible Change-Id: Ide3eeee0f127a05def4d4f493bb4b469e0877b00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99657 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-30tdf#38093 Writer outline folding - Navigator UIJim Raykowski
Patch 5/6 that breaks down https://gerrit.libreoffice.org/c/core/+/96672 Adds submenu 'Outline Content Visibilty' and action handling for submenu items to Navigator Headings context menu. Change-Id: Iccdcbc7518a83cc1b2e2e75f3052f8dbbffb1338 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99656 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-30tdf#38093 Writer outline folding - .uno:ToggleOutlineContentVisibilityJim Raykowski
Patch 4/6 that breaks down https://gerrit.libreoffice.org/c/core/+/96672 Add UNO command to toggle outline content visibility Change-Id: I5365b29ab88d67a449b551b303f050b52063b977 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99655 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-30tdf#38093 Writer outline folding - ctrl + click toggle visibilityJim Raykowski
Patch 3/6 that breaks down https://gerrit.libreoffice.org/c/core/+/96672 Adds ctrl + mouse-click to toggle outline content visibility. Right click includes sub levels. Outline content visibility of sub levels is set to that of the clicked outline content toggled visibility. Change-Id: I428b3c683bec48bec147385dcdb1708e1f28d791 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99654 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-30tdf#38093 Writer outline folding - outline visibility and on canvas uiJim Raykowski
Patch 2/6 Outline content visibility and on canvas collapse/expand control button implementations. Change-Id: I8481125b102d2f07bfcfce91e1379d8e786a7aa2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99653 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-30tdf#38093 Writer outline folding - feature sensitivityJim Raykowski
Patch 1/6 -Adds option 'Show outline visibility button' to options writer view tab in Display section. -Adds UNO command '.uno:ShowOutlineContentVisibilityButton' to toggle option on and off from menus, toolbars, and key bindings. -Makes feature experimental mode. Change-Id: If5a57defd8f568736ea08625ab6eb08e30b15c03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99652 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-30(related: tdf#134252) sw: fix assert when moving mouse pointerMichael Stahl
SwPageFrame::GetModelPositionForViewPoint() was calling GetCharRect() on a frame that doesn't match the passed prevTextPos; it was supposed to be initialised by GetModelPositionForViewPoint() call but that didn't work because the point was outside the frame so nothing was inited. (regression from edd2db1c783bd571ff796a5298385cacc91877b9) Change-Id: Ic064c3efc1b7f29d18d713206e5ea5ac0b67fbc8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99692 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-07-30DOCX import: fix overlapping floating tables when anchored inside a tableMiklos Vajna
The WW8 import does the same in SwWW8ImplReader::StartTable(), now we're on par with that. Change-Id: I2ce0d96d255d8f405203f36a358559687b36e9e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99762 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-07-30rhbz#1861794 csv fixed width import missing split handleCaolán McNamara
regression from... commit 1e97ca02773e2ba968606eed61d25d88f0d7e417 Author: Caolán McNamara <caolanm@redhat.com> Date: Mon Oct 14 11:05:07 2019 +0100 EndMouseTracking was left uncalled Change-Id: Ia952addac585737c3d3aa4fd68d772c3acbae848 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99752 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-30terminate XDesktop properly in unit testsNoel Grandin
So that the UNO constructor work can continue - where we need the desktop to be disposed properly so that all UNO constructors objects have their dispose() called, and they can clean up their global state. We detect this case by changing a SAL_WARN to an assert in Desktop::disposing() (*) in ~ScTabViewShell, don't call EnterHandler, because that tries to create EditEngine's and other stuff, which crashes (*) Need a fake singleton so that the servicemanager calls dispose() on the AnalysAddIn and we can clear the global variable there. Change-Id: Id13b51e17afc16fcbbc65d64281cdf847e4a58cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99640 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30tdf#133967: sw_uiwriter: Add unittestXisco Fauli
Change-Id: I7ec43fd7109e883b0ae560cc8832e449a09fddb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99758 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-30fix commentNoel Grandin
Change-Id: Iff0cb697a4f8670c897516d23f2701f3716171f3
2020-07-30fix shutdown crash in basicNoel Grandin
another change I am working on slightly tweaks the shutdown ordering and exposes this problem where two classes both think they own the same object. Change-Id: I7477cf7eda5b5729ee3861cb4a1be43bb34d9ea6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99724 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30loplugin:flatten in sc/core/dataNoel Grandin
Change-Id: I9ffe58d68172c6fe9c76000c01c0c67a03967146 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99699 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30make some classes privateNoel Grandin
Change-Id: Icfce56436aafa14fe923b4d35835ed6dee52afba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99624 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30sw: extract createDoc() from various test suites to a single getSwDoc()Miklos Vajna
Change-Id: I72d769860be8a401416e57111bea91d7a26ea4e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99751 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-07-30tdf#135244: don't jump when updating countsMike Kaganski
Change-Id: Id1693e420a51a913fa78da7b7f46e076876ffe68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99756 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-30loplugin:flatten in sc/uiNoel Grandin
Change-Id: I4e12da123924b1036c1348ad1b04eef1826ae26a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99703 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-30tdf#135244: prevent jumping when generating drop caps previewMike Kaganski
Change-Id: Ifd9ade76384c66312eda8c8ee7cb41891459b3f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99757 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-30svx: GalleryObjectCollection shared class and related refactoring workAditya
Add GalleryObjectCollection, a shared class primarily owned by GalleryTheme which contains object list to be used by GalleryTheme and GalleryBinaryEngine. Refactor ImplCreateUniqueURL, InsertGraphic() Implement comphelper::GraphicMimeTypeHelper::GetExtensionForConvertDataFormat() Refactor Actualize(), implement updateSvDrawObject(), updateTheme() Move ImplCreateSvDrawStorage into constructor instead of calling in directly. Change-Id: I6a8c552268628b4e192f45112ac9e8789c6e1609 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99035 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-07-30tdf#135244: prevent jumping to cursor at document renderMike Kaganski
This prevents the jumps when printing Change-Id: I8b6f7d60aa0ed443ec8e05ad5812830a6b655abb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99715 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-30tdf#135244: move LockAllViews to SfxObjectShellMike Kaganski
... so that it may be called from SfxObjectShell::SaveTo_Impl, and handle export cases in addition to save (as) handled in tdf#41063. Change-Id: Ie39196656dd1a95dcb6bab3ae8138c2f5c8729e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99714 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-29expand out macroNoel Grandin
Change-Id: I607e1defbd657546bfc017d16d0edfcf0dc2c028 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99721 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-29i18npool: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I814512ccc546bd015558a8122f0d2e3803437e38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99722 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-29tdf#134250 add unit testMichael Stahl
Change-Id: I4c5d7bc1c2471a14afabf331acb8c2f2781382bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99672 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-29update DbFilterField to use the new replacement controlsCaolán McNamara
Change-Id: I5b138a776ebbad9e5f7a50f3f44ab56fa283cba9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99719 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29Port to FreeBSD aarch64miki
Change-Id: Ib18894db8c2943dd1502c96951545bb75a1944eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91978 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-29center the filter checkbox like the normal oneCaolán McNamara
Change-Id: I7954430640fe9788c650f5fe7b103426731204cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99716 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29update svtools pchCaolán McNamara
Change-Id: If636d1bda03c2932225980d9f2f31f0d06748a34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99713 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-30 18:57:13 +0000