summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-03-12Colibre: tdf#146545 Add dark variantRizal Muttaqin
Change-Id: I041d74336c3f59e0240341acfb7c50d60d64429e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131411 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-03-12Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to 9760c17275898f3853f7b1d3e17ffb522a223318 - Consistency Change-Id: Ie76a00c8f234e99043b4f108448f65af4fd23a2c
2022-03-12tdf#147905 calc PROPER function doesn't like mulithreadingNoel Grandin
regression from commit dac29c278531d5474289eb54aa03987c4958ac83 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu Sep 16 11:03:04 2021 +0200 if you hit Transliteration_casemapping hard enough, like in this test case, the state changes become a problem, so remove that by having multiple copies. Change-Id: I1d795af4370d6f79468387997202ba11c6a9d7b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131441 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-12merge common parts of if/elseCaolán McNamara
Change-Id: I033eb905bcb3102ff1a1aa3beacd8c054e5011a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131376 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-12remove newly unused codeCaolán McNamara
Change-Id: I371fd1242070fe19e408277e008d8627fd8b28d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128567 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-12set portion width using the last position in the dxarrayCaolán McNamara
so both branches are consistent in measuring mechanism Change-Id: Ie9b671ac69d00550d42328ac28c707c850238312 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128566 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-12Introduce FastAttributeList::add(NS) taking std::u16string_viewMike Kaganski
... and simplify some places removing explicit conversions from OUString to OString. Change-Id: I4cdf9f3ee3101b3d00a0bbba53a983ed3bebce4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131445 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-03-12tdf#73125 sw: add Insert/Delete Comment Manage Changes action iconsLászló Németh
If the listed redline change contains only a comment. Note: filter actions haven't been extended, because tracked comments are still handled as text insertion/deletion, and their redlines joined with the tracked text changes around their placeholder character, i.e. not all tracked comments got new action icons. Change-Id: Ie78e18a48b9a71c3789fca1406e5d87ab95952bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131387 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2022-03-12tdf#144563: remove final dot in cross-references to paragraphVasily Melenchuk
It looks like in cross-references ending with dot (".") one last dot is removed in case of MS Word. This is not a true for any other suffixes after numeration. Change-Id: I554e62cf45e643bf27823df5344e1689b5b6ae54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131254 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-03-12tdf#147309: Recreating a view with same name and in the same session fails (FB)Julien Nabet
Since HSQLDB already worked, just do the same. Change-Id: I44929cf36179cc3cdff6e61f05899c9a913c78b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131442 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-03-12tdf#90391: sc_subsequent_filters: Add unittestXisco Fauli
Change-Id: If9e7dd7e4c022255bfae5afd3df337f7091f5e71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131383 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-12ofz#45501 and ofz#45503 Integer-overflowCaolán McNamara
Change-Id: I20576860dc20900589d13c43a98af91c5fd0fff9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131443 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-12cid#1502950 silence Uninitialized scalar fieldCaolán McNamara
Change-Id: I8bb8aac3eb091233ee625747aff7953f2ea28ded Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131377 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-12ofz#45269 Integer-overflowCaolán McNamara
Change-Id: I9fe6c4753da609933c8ce5ef051e49351a25fd56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131386 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-12CppunitTest_sc_subsequent_filters_test: combine crash tests in oneXisco Fauli
Change-Id: I92a07847a92dd6bfd96a57062d28ad740c953b47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131382 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-12tdf#147744: sc_uicalc: Add unittestXisco Fauli
Change-Id: Ica8f971ca12569cc299910a20b5a7a5bcfd49bd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131345 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-12check-missing-unittests: fix pathXisco Fauli
Change-Id: I568cfdd1874ccba2f7233e21166026cfcda8e733 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131384 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-12Related: tdf#111675 Clear global error for arguments if possibleEike Rathke
... i.e. if the last result / current stack value is svError already (usually is nowadays in case of error) and error evaluating functions may be pending. Change-Id: I36fc0f169d36dfa7007e8bd3a5c368ed2bb3c919 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131405 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-03-12an inconsistent SwTextFormatInfo index, len, text length caseCaolán McNamara
seen on loading sw/qa/python/testdocuments/TESTMETA.odt maybe since: commit 2f3684b2289a8c46dc6144064a452cc529400f28 Date: Tue Jul 31 16:00:02 2018 +0200 [API CHANGE] add some more asserts to the string functions but probably an underlying issue since conversion from UniString to OUString Change-Id: If731163fbc5e05b813ccd21df65164fe476cba9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131407 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-12expand with some specific documentationCaolán McNamara
Change-Id: I3886411c07b82417c29edaf612dd3720189a9ea9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131388 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-12cid#1502952 Logically dead codeCaolán McNamara
and cid#1502951 Logically dead code cid#1502949 Logically dead code Change-Id: I3e1f1c8457dbb3d8a0c4754efbc34c36972b7c31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131385 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-12ofz#45488 get WW8+ calculation of sprmTDefTable length rightCaolán McNamara
we have the calculation correct for WW7- which is what the special L_VAR2 case is for, but for the WW8+ variant that wasn't understood. Change-Id: Ic9dde07223386df796f57dd1f33e69d16d3abf21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131395 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-12Related: tdf#111675 Replace Pop() with PopError() where relevantEike Rathke
... to propagate the original (previous) error instead of overriding it with a new error. Pop() may only be used if the stack type is already known to be not svError, or to explicitly ignore a current error. Change-Id: I5a980c29f2d2679c0e2f2fc7e53c458dc147911f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131404 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2022-03-12no need to temporary OUString hereNoel Grandin
Change-Id: Iffd95fcf4fd1f9aac0ba77effc3c63eedce69adf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131412 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-12tdf#147767 html pasted to calc has very small fontNoel Grandin
regression from commit da9bba7cc3c243e936daea689fea64ecaf110f35 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Mon Jul 26 10:10:17 2021 +0200 use officecfg for SvxHtmlOptions Change-Id: Ia84d713a18b4c694af98478681996b6156cbb928 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131393 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-12tdf#147921 Filesave DOC: wrong layout and then all missing from 7.3Noel Grandin
regression from commit 990b2cb056788f7f412656a303456d90c003cf83 Author: Noel Grandin <noel@peralex.com> Date: Mon Jun 21 13:00:07 2021 +0200 simplify and improve Wildcard Cannot pass a string_view into something expecting a char* because then it gets the length wrong. Change-Id: I638660a1e9a8a0d17e4d2f77500b3f01365a43d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131396 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-12simplify some service factory codeNoel Grandin
no need to get the factory from the component context and then get the context from the service factory Change-Id: I7675728992fbb5202bc42e27b86b2dba571c62c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131394 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-12Related: tdf#128610 drop obsolete encoding attribute replacementMike Kaganski
It was needed once, when we used expat; now libxml2 does its own detection (in its xmlDetectCharEncoding) after the strange dance in our XMLFile2UTFConverter::readAndConvert (which does nothing useful for UTF-16 case). The original problem in tdf#128610 was addressed in commit c964700d16d99d1569373a1eb9a1352fb3512915. This one just drops the obsolete replacement. Change-Id: I2e6b28212619dd0f6cb90ae8234277092a37e7a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131409 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-03-12Fix Breeze & Sifr: Add missing iconsJulien Nabet
Local build error: Link cmd/sc_about.png -> res/mainapp_16_8.png -> cmd/sc_adddirect.png Some icons in links.txt were found to link to other linked icons Link cmd/sc_about.png -> res/mainapp_16_8.png -> cmd/sc_adddirect.png Some icons in links.txt were found to link to other linked icons make[1]: *** [/home/julien/lo/libreoffice/postprocess/CustomTarget_images.mk:53 : /home/julien/lo/libreoffice/workdir/CustomTarget/postprocess/images/images_sifr.zip] Erreur 1 make[1]: *** Attente des tâches non terminées.... make[1]: *** [/home/julien/lo/libreoffice/postprocess/CustomTarget_images.mk:53 : /home/julien/lo/libreoffice/workdir/CustomTarget/postprocess/images/images_sifr_dark.zip] Erreur 1 Change-Id: If7cc708f5201d21fb2134785cdb3f12a4974826a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131403 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-03-11allocate column in ScTable::SetPatternAreaCondFormat() (tdf#147894)Luboš Luňák
Change-Id: Id14bb20ef5e49551cef5216b5149e3c281c04223 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131389 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-03-11fix comparison operatorsLuboš Luňák
It seems the ranges are always distinct, so the < comparison always worked in practice, but the == comparison added by my 6810aa937caca1 is obviously incorrect. Change-Id: Ib7fcd36b5956901265248b34a4dc69e587cebe41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131340 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-03-11tdf#56036: sc_uicalc: Add unittestXisco Fauli
Change-Id: I48f5e0550e4ff7a57bd8a8eae057429b620c7508 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131379 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-11Colibre: Fix wrong color, the ones which doesn not follow Monoline (part2)Rizal Muttaqin
Change-Id: Ibf021302c6d43bec109969fd7174c3c1532db620 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131402 Tested-by: Rizal Muttaqin <rizmut@libreoffice.org> Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-03-11Colibre: Fix wrong color, the ones which doesn not follow MonolineRizal Muttaqin
Sometimes Inkscape change the object color to full back or sometimes a gradient from other file was carried out to the new SVG file. This could lead color inconsistencies. Here the fix comes to eliminate them. Change-Id: Id4dcdd3549ef4ef7b2f89dfe0dddabf324390266 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131400 Tested-by: Rizal Muttaqin <rizmut@libreoffice.org> Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-03-11Breeze & Sifr: Add missing iconsRizal Muttaqin
Change-Id: Iaeeb7026cf440d1db893c0673ea4154e8558e6a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131381 Tested-by: Rizal Muttaqin <rizmut@libreoffice.org> Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-03-11use more SfxItemSet::GetItemIfSetNoel Grandin
Change-Id: I58af59d82d92c89ca1939d35f9fb4121b6815559 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131336 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-11Breeze: Add many missing iconsRizal Muttaqin
Change-Id: I3619601346d7a0c5d149d53dee26e9e07ab35ad1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131339 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-03-11make svx::frame::Style ctor inlineLuboš Luňák
ScDocument: :FillInfo() may result in calling it often. Change-Id: I05d0582befc57c4959c33fae6dec3d340b8a49ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131338 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-03-11remove a pair of newly unneeded translationsCaolán McNamara
Change-Id: Ic4952938db458909dc20663af7dc5f9e5d0a443f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131374 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-11silence 'sal/rtl/strtmpl.hxx:162: Found non-ASCII char' warningCaolán McNamara
Change-Id: I7f537c641dcd8aa92cd5034b557f947b4a25ba02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131375 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-11Related: tdf#128610 Avoid use-after-freeMike Kaganski
Creating SvMemoryStream from string makes it non-owning, i.e. pointing to the string's memory. So the string must outlive the stream. Since commit 64bc8b45b5c23efc5fe57585a69aa4263aaf4e83 Date Wed Jul 08 12:31:43 2015 +0000 i#107734 Support for Math Input Panel in Windows 7 Was only working by chance, when destructor didn't clean the memory (e.g., in optimized release builds) and the released memory hasn't been reused yet. Change-Id: I2e0c195de7bd2aff2889a94ef0f2eb084411933f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131373 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-03-11tdf#147744: Make sure to pass valid position hints.Kohei Yoshida
When pasting a single cell to a range with filtered rows, the existing code wasn't updating the position hint iterator after inserting cloned formula cells via ScColumn::CloneFormulaCell(). This caused the next call into the cell store to receive an invalid position hint. This problem has been there all along, but apparently it did not cause a process termination with the previous storage layout of multi_type_vector for a reason unknown to me. Change-Id: Ie1a4b99c7077536499c6373ccb7022961e9d93e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131331 Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2022-03-11ofz#43310 don't try and delete prior header/footer contentsCaolán McNamara
If a duplicate appears, just hide the prior ones. FWIW our own html export only exports a single header/footer as far as I can see. Change-Id: I5df28f7215ed49ce4a13add990716edcc7f2c72c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131329 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-11tdf#63766: remove incorrect UItestXisco Fauli
the issue is still reproducible in master, thus this test makes no sense Change-Id: I101230ef13fd6408bab28e8fb7df6efe4ea3f9fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131371 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-11sw clearing breaks: add ODF exportMiklos Vajna
Write the clearing break as: <text:line-break loext:clear="..."/> Change-Id: Ieb517b825f2ee162bb70a453a3756ec870fa8aac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131346 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-03-11tdf#94208: sc: move UItest to CppUnittestXisco Fauli
The original test was incomplete and didn't fail without the fix in place Change-Id: I0ddec239b9cb06d90aed21be8b916f39d51a3a38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131367 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-11tdf#114150: Remove duplication of strings found in file dialogsJulien Nabet
Change-Id: I86f720a23dd9d400d39d9606e073b483850a9df2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131153 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-11loplugin:trivialdestructorStephan Bergmann
Change-Id: Id8a35dbbc1eecd2f568f253ddea5cb7ca3064ecd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131341 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-11use SfxItemSet::GetItemIfSet in sw/.../uiNoel Grandin
Change-Id: Ic6a15dfd159ee2e5d4aa0e0c3bc31cff1557a875 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-11Simplify MayBeRegExp/MayBeWildcardMike Kaganski
Change-Id: Ibc5dc0b1157fa28035fa0d09d7e1a5d34df9e39b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131333 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2024-12-26 06:40:03 +0000