summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-06-03tdf#129587: sc: Add UItestXisco Fauli
Change-Id: I4e8080d80f7cba19772c480b316249783f70b945 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95439 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-03ofz#23016 Invalid-enum-valueCaolán McNamara
Change-Id: Ie3a783002b6ad82c6939b567cb53c3d4afbfac7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95408 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-03tdf#133633 winaccessibility: Add null checkMichael Weghorn
The call to 'AccObjectManagerAgent::GetIAccessibleFromResID' may set 'pImAcc' to nullptr here (s. 'AccObjectWinManager::GetIAccessibleFromResID', which is called from there), so handle that case gracefully. Change-Id: I0dbd48974fd012ff086835b147cd9b9cfc8a052b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95430 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-06-03tdf#132420: sw: Add unittestXisco Fauli
Change-Id: Ic98667b688c8d865e637fb921913a2d8d57133f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95431 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-03Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 67026c44ece5d04b41eb1c2f2c3ebf086d558bbd - Improve readabilty of SERIESSUM Change-Id: Ia5f4c2ccd335f9be8606bb192cc88d703d80d00c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/95436 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-03vcl: allow BitmapFastScaleFilter for 1xN or Nx1 cases.Mark Hung
Limiting both side to be at least 2px is not necessary, so check for 1px and add test cases. Change-Id: I3c6f6ed5c8842bf24e7983bd8ed27fb8bb9568c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92117 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2020-06-03Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to c6409aa8d0e0c6342cb397f906ac602201581a27 - Fix [aria-hidden] topix in CSS Change-Id: Ifbc5d8d7a3ffc92965a78062c5943b5e94081bf0 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/95434 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-03Upcoming loplugin:elidestringvar: desktopStephan Bergmann
Change-Id: I46295b47daaa590b053433e0232e85e9c7b1f3cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95397 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-03enable backtraces for unit tests on macosNoel Grandin
Change-Id: I4f07e1e7b35bccc217d78662a45ac5eaf5865ee7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95394 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-03Update git submodulesSteve Fanning
* Update helpcontent2 from branch 'master' to e04a83713f38be33d0c51cc35d0c457919a3f213 - Improve help information for ACCRINT() function to better explain the behaviour of the Par argument. Change-Id: Ia1fb54abe828dc9d0310e83f9552099759b96d40 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/95329 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-03pdfium: only init pdfium library one and destroy on LO exitTomaž Vajngerl
With more and more usage of PDFium, it is hard to keep track of the life-time of the PDFium library, so it can happen that a FPDF_DestroyLibrary happens when we still have another instance where PDFium is still use. The result of this is a crash. To prevent this, just initialize the library once and delete, when on LO exit. This can be improved in the future to only keep the library active when in actual use. Change-Id: I5c7e5de7f8b97d10efb394c67c7a61b976c8d57c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95391 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-03vcl: VectorGraphicSearch - clean-up SearchContext member vars.Tomaž Vajngerl
Change-Id: I1740be5ed1b47235da3794fa46e3533b17ca1fb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95390 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-03sd: improve the test for LOKit search in PDF graphicTomaž Vajngerl
Record how many times we het the search result back, so we can be sure that the search happend and don't just read the old values. Assert the search result selection rectangles and text selection rectangles. Add tools:Rectangle support for CPPUnit into sdmodeltestbase.hxx Change-Id: I0b22d2d2f66abdc0dd0d5ac13a1bfebaa470749a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95383 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-03vcl: add search start position support for VectorGraphicSearchTomaž Vajngerl
By default we start at the begin of the page, but with this change make it possible to start at the end. This makes it possible to search in the backwards direction (set the start position at to the end and search with "previous"). Change-Id: I78fb1461b86bf9eab2f91c3b9a81cbb5c6557332 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95382 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-03Resolves tdf#130936 - Proper Icon Size for MIME type Icon in Start CenterHeiko Tietze
Icons are now in 48px Change-Id: I484458adf047999bc2ea0cbf16e7ff3fff131eec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95028 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-06-03Upcoming loplugin:elidestringvar: dbaccessStephan Bergmann
Change-Id: I5dc074a250ee169812f3ffd0cc4e598972ab87dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95396 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-03loplugin:simplifypointertobool improveNoel Grandin
to look for the x.get() != null pattern, which can be simplified to x I'll do the x.get() == nullptr pattern in a separate patch, to reduce the chances of a mistake Change-Id: I45e0d178e75359857cdf50d712039cb526016555 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95354 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-03tdf#133569 rework the SwCommentRuler buttonJan-Marek Glogowski
The original design was planned in tdf#38246 and documented as: https://wiki.documentfoundation.org/Design/Whiteboards/Comments_Ruler_Control This patch includes the following changes: * use the correct highlight colors * use a down-pointing arrow for expanse with a stable position, like some tree view implementations * left-align the label in RTL for better us- / read-ability * dynamic sized arrow for HiDPI: * draw arrow using a polygon * calculate arrow size and padding based on font size * drop almost all constant values * fix the instable, mouse-over tooltip -> just show it always While at it, I found clang-format just added some minimal, additional changes, so I removed the file from the blacklist and included these. Change-Id: I6e0bade387639eae6bdaaf7960b2fe44c73adf65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/75421 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-06-03vcl: add "previous" search to VectorGraphicSearchTomaž Vajngerl
Previous moves backwards in the search matches. Change-Id: I88d402e0b8cb9dc4fd93e7f1ce5b08fb42aadd06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95381 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-03Upcoming loplugin:elidestringvar: comphelperStephan Bergmann
Change-Id: Id388af90ca2c3dff435a1a6261e3de0c3c0dbdbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95376 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-03Upcoming loplugin:elidestringvar: connectivityStephan Bergmann
Change-Id: I406486e13b822c34cd2329cc3828dd0567be30e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95385 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-03Upcoming loplugin:elidestringvar: basctlStephan Bergmann
Change-Id: Ia0411cad22c23f16d5d85b7cb65822d19f923b4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95373 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-03Upcoming loplugin:elidestringvar: avmediaStephan Bergmann
Change-Id: I792998688f0ac0853cd6fee7a92d7c00580cb51b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95372 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-03Upcoming loplugin:elidestringvar: chart2Stephan Bergmann
Change-Id: Ibc668f42f2779d8f3542054c92338c9f4f3efe68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95375 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-03writerfilter: mark these as const to make it explicit they return a copyMiklos Vajna
I.e. move / scale doesn't modify the wrap polygon, it returns a modified copy. Change-Id: Ic0b23a1c9de0ce90032656351d9744dace2ef4e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95384 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-03uitest: avoid defining the same object multiple time in in mathShiko
Change-Id: I1ee5cde133390ca285bb154e6a373e0e5bc1cbed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95334 Tested-by: Jenkins Reviewed-by: Ahmed ElShreif <aelshreif7@gmail.com>
2020-06-03tdf#88109 improve autofill perf (2)Noel Grandin
make SvxWeightItem sortable, which shaves off 1% and turn the tree search off while performing this operation, which shaves off about 25% of the time on my machine. Change-Id: I94358ed565a0d9f1cc0ddb36b8349e83c9deb959 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95369 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-03sd: use getPDFSelection to get the search selection for LOKitTomaž Vajngerl
This reduces code duplication. Change-Id: I0a6a44d696841d1573d23f87353ac055cc92c83a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95386 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-03sd: fix not found case in PDF search + add PDF Search testsTomaž Vajngerl
When searching the PDF and the search text is not found (anymore) in the current VectorGraphicSearch, we need to remove it and mark that we don't currently search in a vector graphic (PDF) anymore. This wasn't handled correctly and caused a crash. In addition add a LOKit test for search into a PDF document, to make sure the not-found case and usual searching case are working correctly. Change-Id: I663a6b2cf4879f11d62e440ea0c35ffcd205f81f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95380 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-03sd: move LOK search tests out of tiledrendering.cxxTomaž Vajngerl
Change-Id: I76ff3e251afc877b0dcf54d772da95bb7a60e823 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95351 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-03sd: use b2DRectangleFromRectangle from canvastools.hxxTomaž Vajngerl
Change-Id: I8604b80f887a2c3a1143b8a9bc70f429576512f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95350 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-03Fix for tdf#133582, missing checkbox in gen envRizal Muttaqin
- - Add more SVG version of PNG icons Change-Id: I0217ec345215e710c7ee0b2bf3108c244e921f26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95387 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-06-03Revert "tdf#105478 sw layout: treat minHeight as "do not split row""Justin Luth
This reverts LO7.0 commit aa5dc0b48cd4db6883c9b52c68b16170c9c81d1f, in order to prevent regressions like tdf#133441. Change-Id: Id08f5277621703e1577fc9db917841b8b7c0bda5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95180 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-06-03Colibre: Fix for tdf#133261 wrong MIME type iconsRizal Muttaqin
Change-Id: Id516b8b558b74f8cb26f8d08f94b02530818aa96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95360 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-06-03tdf#101211 Add goto prev and next page uno commandsJim Raykowski
Change-Id: I7e195727066e47f93665fdebf1042282ecbb42b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91605 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-06-02OOXML support for shadow blurA_GAN
Add a new property for the blur radius and define an ID for it to support the import of OOX files. Add a test for importing the blur radius from PPTX file Change-Id: Iffaa33ff7159019ce9478cee558622bd61bcf60e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95090 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-02Upcoming loplugin:elidestringvar: basicStephan Bergmann
Change-Id: Ie723d07afcc6e0d5e52bec77617fec326a739415 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95374 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-02tdf#130950: sw: Add unittestXisco Fauli
Change-Id: Ia4094f4f411e3f0652fbcc019594ca99ce2428cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95368 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-02crashtesting: fix abi11870-2.odt assert in SwBookmarkPortion::Unchain()Michael Stahl
This m_pPrevious pointer is a bad idea, should just use FindPrevPortion() to find it, which shouldn't take that long to iterate all the portions in the current line. (regression from 4ce8120f1e53f7b81e653b01d141643013bc69ab) Change-Id: Ibb5f2bb28d959958547ed27c51e5084cc746d642 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91622 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-02use pseudo keyevent we already have if gtk_get_current_event is nullCaolán McNamara
so gtk's desire for one can be satisfied Change-Id: I486331bdc1778f07c02d0249f239c8d14fc4f5e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95371 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-02tdf#130354 sfx2: make PDF signing UI work againMiklos Vajna
Regression from commit 9112c18524c9f5e67d6cbb282586a439e3020cdb (Don't create unnecessary tempfiles for opened doc, 2019-10-18), restore the temporary file creation for the PDF case, as it's needed for PDF signing to work. Change-Id: I945f04f6ab90d0e04fb14a7634ec877fb0af1a0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95367 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-02sd: remove code dupl. when getting PDF text selection for LOKTomaž Vajngerl
Change-Id: I61d0a9851e9cfe60e9672acec38946b0b25f310f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95349 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-02sd: Search inside PDF document that were inserted as a graphicTomaž Vajngerl
This implements searching inside PDF documents that were inserted into the Draw/Impress document as a graphics and marks the areas of text that matches the search string. Complex (regex) search is not supported. Change-Id: I55d67772a2fe876ae72b9164998347304025d3e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95348 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-02svx: add ability to show sub-selections in a marked objectTomaž Vajngerl
Draws selection rectangles inside the object window. Change-Id: I994477426489ea4cea89c86f9e51c9978f16b350 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95347 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-02Use "Radius" instead of "Rad" for new propertiesTomaž Vajngerl
Change-Id: Ifd232bccf1519e0ed68195cf4344893175a675e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95331 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-02tdf#132301 AutoCorrect: fix ’« in French qu’« word »László Németh
instead of using the bad ’" -> ’» autocorrection. Also limit this for abbreviated single-letter form of French words ce, de, je, la, le, ne, me, te, se and si. See commit 8039c9eb27170a162830f0ecd2086010a7a5858f (tdf#38394 AutoCorrect: fix ’« in French l’« word »). Change-Id: I1761365d90ae3af3c9ab47a3a82bf0abbe1b32be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95345 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-02tdf#133589 AutoCorrect: transliterate to Old HungarianLászló Németh
In right-to-left paragraph mode, transliterate Hungarian text word by word during typing, also add the associated checkbox to Localized Options page of AutoCorrect dialog window. Old Hungarian (ISO 15924: Hung) is a historical and renewed script which is still in use to transliterate Hungarian writing. As a localized AutoCorrect feature, the patch supports the followings: – word-by-word transliteration of Hungarian texts only in right-to-left paragraph mode. – consonant disambiguation of digraphs and trigraphs based on hyphenation (now pattern-based Huhyphn dictionary of libhyphen, planned dictionary based Hunspell later) – transliteration by extended hu-Hung module of Numbertext library. Note: transliteration of the selected text using AutoCorrect Apply function has't been implemented, yet. Change-Id: Iee0f18e2485c974c35acf0a3abc3a49c2cf80196 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95303 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-02bump to libnumbertext 1.0.6László Németh
Fixes in various languages, also word transliteration support in Old Hungarian (renamed to hu_Hung.sor). Change-Id: I2eed60142273b8c353304a5b714f4e4bde5af1b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95302 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-02tdf#133555 xmloff: ODF export: don't produce text:drop-down in ODF 1.2Michael Stahl
This was added in ODF 1.3 as OFFICE-3881, but it's actually ancient and was written by OOo 2 already, just somehow forgotten to add it to ODF. Change-Id: I322fac471c940334f886a7c61769922ae03ee89b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95359 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-02tdf#133501 xmloff: ODF export: export annotation only if extendedMichael Stahl
(regression from 7c20c3c2a9fc85c66dad9d09908b257beeedd78d which forgot to adapt this under the erroneous assumption that the feature did make it into ODF 1.3) Change-Id: Idfe37444b8287edd063fa9576e6d76a332552754 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95355 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>