summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-09-25tighten up the pict filter a tadCaolán McNamara
Change-Id: Ib09a33a97a79fdeb5b61d486af4f11b5cc4035ec
2017-09-25Conditional jump or move depends on uninitialised valueCaolán McNamara
Change-Id: I772c38c62950edbcde450889bae61dc37118b8cd
2017-09-25Direct-leak fix effortCaolán McNamara
Change-Id: If267c2d40b9e511a8e13be34bb7ba09048a736c5
2017-09-25ofz: divide-by-zeroCaolán McNamara
Change-Id: Ie9a21a1432a98af3dca9a397057b7887ff30375f
2017-09-25Adapt Repository.mk to d383d0e9852ac52c36b138c33ce3b3ede8df9215Stephan Bergmann
..."Install fc_local.conf only where used" Change-Id: I3c10a77f37add8731d9844566c4ba364b34d8da1
2017-09-25Rename GetSelectEntryData -> GetSelectedEntryDataSamuel Mehrbrodt
Change-Id: Ia6402f6d2c978cbd5557052a43e9728ca9e11173 Reviewed-on: https://gerrit.libreoffice.org/42285 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-25Rename GetSelectEntryCount -> GetSelectedEntryCountSamuel Mehrbrodt
Change-Id: I405b347b404ed0acb3b6a0204e0b914a7698ce25 Reviewed-on: https://gerrit.libreoffice.org/42284 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-25Related: tdf#112388 last Fraction leakCaolán McNamara
This SdrEngineDefaults never changes its initial Fraction or Color and always returns a copy, so drop all the complicated stuff Change-Id: Ic26d221be022f4d1e75498eca675b4aae1c020f1 Reviewed-on: https://gerrit.libreoffice.org/42723 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-25tdf#112086 PPTX export fltValue, ppt_w, ppt_hSzymon Kłos
Change-Id: Ie77a2f5d9b0179d81c81704d7d760fdceecaa6e1 Reviewed-on: https://gerrit.libreoffice.org/42521 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-09-25Install fc_local.conf only where usedStephan Bergmann
...and at least issue a SAL_INFO when it's missing (there may theoretically be multiple directories, and it need not be present in every one, so nothing stronger than SAL_INFO can be used) Change-Id: I9b7257a551626e5ad081cfb75422a8bd71b86aa4 Reviewed-on: https://gerrit.libreoffice.org/42714 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-25RTF import: split this call into simpler onesMiklos Vajna
Hopefully with this it's easier to see which is the usual and which one is the exceptional case. Change-Id: Iac1b49b2a4f2b909db46155d1ff10d2ba99fd655
2017-09-24tdf#112622 Move dialog’s action buttons to the bottomAdolfo Jayme Barrientos
Change-Id: I41b51019ece99ab747377829bfd2473f39daf418
2017-09-25tdf#83320 Hide vertical text commands earlyMaxim Monastirsky
Instead of listing all commands in one big "if", just do it unconditionally in the shared controller. Change-Id: Ie415c4551a77ca8e1e29e73c0dabaff1dd13cbcb Reviewed-on: https://gerrit.libreoffice.org/42715 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-09-24fix some newer leaksCaolán McNamara
Change-Id: I3a13406db4e441c3a29056f80cb728da2ecc3c25 Reviewed-on: https://gerrit.libreoffice.org/42720 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-24fix some leaksCaolán McNamara
Change-Id: I06a3971d1d269b49b2a7954f977469fbc3d16f35 Reviewed-on: https://gerrit.libreoffice.org/42719 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-24tdf#112388 make aComboButton release its ScGridWindow outputdeviceCaolán McNamara
Change-Id: I938e36dda7fbc3b769b3fba8fd9a7d5d9b8e248c Reviewed-on: https://gerrit.libreoffice.org/42716 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-24Updated coreOlivier Hallot
Project: help 52ba0e435c17651f788021b74567c52e5c2b926f Placeholder for Calc 'data provider' help page Change-Id: I3238c9b6e02486289463990e17ed3c59ca856b06 Reviewed-on: https://gerrit.libreoffice.org/42717 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-09-24Updated coreOlivier Hallot
Project: help bba68b1547105a25f16b752fd3035f51c1ed3625 Placeholder for Calc 'data form' help page Change-Id: I134c0f9148854c23a1252bbcb2d85b43b3654dd2 Reviewed-on: https://gerrit.libreoffice.org/42711 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-09-24tdf#96505 Get rid of cargo cult "long" integer literals66kesara99
Remove unnecessary "Long" literals in multiple locations Change-Id: Icc44546f10fed841683053eee01b788274e0add1 Reviewed-on: https://gerrit.libreoffice.org/42683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-24iOS, static library.jan Iversen
First attempt to prelink all LO libraries into 1 static library. With all libraries directly linking to the swift module, link time is about 12 minutes. Experiments let to be believe this can be reduced to 1-2 minutes by doing prelinking, which will solve all symbols between the libraries. Because work will continue on the swift module, while the LoKit is a pretty stable interface, this will save much developer time Change-Id: I69b63481fc657f2188476f53c5b4d49abe59c5f6
2017-09-24add fodp fuzzerCaolán McNamara
Change-Id: Ib6c439fa8db7de0544c8ee3340c07a40bf10bcb6 Reviewed-on: https://gerrit.libreoffice.org/42582 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-24Use a ref for arg of DirectSQLDialog::displayJulien Nabet
Change-Id: Ia30866edb5a243c09af3256bd963cafa9e2335ba Reviewed-on: https://gerrit.libreoffice.org/42705 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-24ofz#3476 oom in tiff readerCaolán McNamara
Change-Id: Id103488ea0774b55521571f8b51059d06d4a0993 Reviewed-on: https://gerrit.libreoffice.org/42707 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-24Fix duplicated context attributes.Kiyotaka Nishibori
The duplication generates invalid .pot file: ./pot/sc/messages.pot. Change-Id: If2a5248ad3226f5cc2e866fdf2033c867943e8b9 Reviewed-on: https://gerrit.libreoffice.org/42702 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-24Updated coreOlivier Hallot
Project: help 657385a5e4be3bdef6aba37c17ba36e90548c911 Placeholder for Calc 'XML source' help page Awaiting for more contents Change-Id: Ie43002a9abf255d81c7cd77fe5d453c490f7bdb5 Reviewed-on: https://gerrit.libreoffice.org/42710 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-09-24Updated coreOlivier Hallot
Project: help 55ffe5b2a3b2ef10e16d271ca9b11e7615b4db83 placeholder for Calc 'data stream' help page Awaiting for more contents Change-Id: Ia44adb3f25f26df5b2f0ec360ac9d0cc421d8fe3 Reviewed-on: https://gerrit.libreoffice.org/42709 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-09-24move sanity checks before allocationCaolán McNamara
Change-Id: I7374b3cc4cb7f2be9cec71a385899051288234c9 Reviewed-on: https://gerrit.libreoffice.org/42706 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-24tdf#106762 Avoid warning when opening and closing the color pickerMaxim Monastirsky
... from the Drawing toolbar in Impress. The warning was "DockingWindow has become non-layout because extra children have been added directly to it.", but this DockingWindow is actually a ToolBox which set as the parent of the color picker, although it isn't really a parent in layout terms. Change-Id: Id1384653ceda938ca0cc300c35467e562984bca1
2017-09-24tdf#106762 Keep the previous m_xColorWindow lifecycleMaxim Monastirsky
Some logic here seems to depend on it. Change-Id: I62a2eeba1511a9be77030f726ceaa67e3ca3ace8
2017-09-24tdf#106762 Base SvxColorToolBoxControl on svt::PopupWindowControllerMaxim Monastirsky
This allows us to support tearoff without breaking gtk3/wayland. SvxColorWindow no longer inherits from FloatingWindow, so several call sites need also to be changed to use DockingManager. Change-Id: I5d0bc611bbd2a8b9bfd4335212d0ae7e8fc10593
2017-09-24rptui::OToolboxController becomes unused, tdf#106762 relatedMaxim Monastirsky
It was a wrapper around the color controller, because the latter used sfx2 registration. This will no longer be an issue, as we're moving to officecfg based registration. Change-Id: I45e1d8aeefdb62f5bd9b3dfac29910c77f0cd103
2017-09-24Support non-ToolBox popup case in DockingManager, tdf#106762 prepMaxim Monastirsky
Change-Id: I54d4de28336b70dbd07923377e6cceb67079fa80
2017-09-24Adjust DockingWindow layout calculation, tdf#106762 prepMaxim Monastirsky
This is needed for the color widget to have the correct size at initial show, and to keep this size after selecting a different palette. The parent FloatingWindow will assume that the border width stays outside the space that was allocated to the DockingWindow (see VclContainer::setLayoutPosSize), and yet DockingWindow tries to handle the border width as part of its allocated space. One option could be to let FloatingWindow handle this alone, but this won't work for other possible parents. The current solution is to load and store the border width in a way that can be used internally, but not visible to the outside world via get_border_width(). Change-Id: Id51152cf64eef719368e29253eb93e99834489cd
2017-09-24unused importChristian Lohmaier
Change-Id: I45ba3c258594e8f3b50ffdc07ca1e09dc5691c3d
2017-09-24lint: remove redundant type casts (findViewById to object of type)Christian Lohmaier
Change-Id: I0ec35ea5817d110ca20942ce9d95e0120848580a
2017-09-24use gradle to build the owncloud-android-libChristian Lohmaier
this will allow using current android SDK tools & emulator Change-Id: Ic7f9996a36e4af2a5cad07e28c8830b8df12aa44
2017-09-24Map Windows code page 42 to RTL_TEXTENCODING_SYMBOLStephan Bergmann
<https://msdn.microsoft.com/en-us/library/windows/desktop/ dd374130(v=vs.85).aspx> "WideCharToMultiByte function" suggests that there now is CP_SYMBOL, "Windows 2000: Symbol code page (42)." And a little test program on Windows indicates that our RTL_TEXTENCODING_SYMBOL is working the same way as CP_SYMBOL, where MultiByteToWideChar maps 00..1F to U+0000..1F and 20..FF to U+F020..F0FF. At least CppunitTest_writerfilter_rtftok, when testing writerfilter/qa/cppunittests/rtftok/data/pass/EDB-18940-1.rtf, goes into case RTF_FCHARSET in RTFDocumentImpl::dispatchValue (writerfilter/source/rtftok/rtfdispatchvalue.cxx) with nParam matching aRTFEncodings[2] (i.e., a mapping from charset 2 to codepage 42, see writerfilter/source/rtftok/rtfcharsets.cxx), then passes 42 into rtl_getTextEncodingFromWindowsCodePage and obtains an unhelpful RTL_TEXTENCODING_DONTKNOW. testFdo72031 (sw/qa/extras/rtfexport/rtfexport2.cxx, CppunitTest_sw_rtfexport2) needed to be adapted, as the circled plus from the Symbol font is now internally represented as U+F0C5, not (somewhat bogusly) as U+00C5 (aka LATIN CAPTIAL LETTER A WITH RING ABOVE). But, when displayed with the Symobl font, the glyph that is actually shown remains the circled plus. Turns out changing rtl_getTextEncodingFromWindowsCodePage would start to make CppunitTest_sw_rtfimport fail: Sep 20 15:49:24 <sberg> vmiklos, with <https://gerrit.libreoffice.org/#/c/42477/>, testN823675 (sw/qa/extras/rtfimport/rtfimport.cxx) fails, the aFont.Name is not "Symbol"; sw/qa/extras/rtfimport/data/n823675.rtf contains a \fonttbl that specifies \f3 to have \fcharset2 (i.e., symbol font) and fontname "Symbol". However, RTFDocumentImpl::checkUnicode (writerfilter/source/rtftok/rtfdocumentimpl.cxx) converts m_aHexBuffer (containing "Symbol;") with nCurrentEncoding apparently being the encoding specified by \fcharset2 (i.e., now RTL_TEXTENCODING_SYMBOL instead of old RTL_TEXTENCODING_DONTKNOW), so the resulting OUString is garbage (instead of the byte-for-byte conversion to Unicode "Symbol;" that RTL_TEXTENCODING_DONTKNOW would do there); do you know whether such \fonttbl fontnames should actually be interpreted in the given \fcharset? Sep 20 15:49:24 <IZBot> gerrit: »Map Windows code page 42 to RTL_TEXTENCODING_SYMBOL« by Stephan Bergmann for master [NEW] Sep 20 15:51:15 <vmiklos> sberg: let me check if the spec covers that Sep 20 15:54:29 <mst_> sberg: i think the name is typically encoded in the font's encoding but probably they have to make a (likely undocumented) exception for symbol encoding Sep 20 15:57:46 <vmiklos> sberg: the spec only says that \fcharset is about the encoding of the content using that font, i don't see it described what would be the encoding of the font name itself Sep 20 15:58:51 <vmiklos> sberg: i'm not sure about if that encoding should or should not affect the encoding of the font name in general, but indeed at least for 2 (symbol encoding) you're right, Word doesn't encoding the font name with that encoding, either. Sep 20 15:59:30 <sberg> vmiklos, mst_, at the top of page 14 of Word2007RTFSpec9.docx I see "Note that runs of text marked with a particular font index (see \fN in the Font Table section) use the codepage for that font as given by \cpgN or implied by \fcharsetN, unless they use Unicode RTF described in the following section." Would that match what mst_ says? Sep 20 15:59:33 <vmiklos> so if it helps you case to handle at as e.g. ascii, just for that encoding, i think there would be no problem with that. Sep 20 16:00:07 <vmiklos> sberg: that still talks about the content using the font, not the strings (font names) in the font table itself, i think. Sep 20 16:01:17 <sberg> vmiklos, what's the control word to select such a font, also \fN? I don't see any such in n823675.rtf Sep 20 16:02:16 <mikekaganski> loircbot: e.g. \af3 Sep 20 16:02:31 <mikekaganski> sberg: ^ Sep 20 16:02:47 <mst_> 04d5a280beeeb6e056df68395dc9c3b3a674361b Sep 20 16:02:50 <IZBot> core - related: fdo#77979: writerfilter RTF import: read encoded font name - http://cgit.freedesktop.org/libreoffice/core/commit/?id=04d5a280beeeb6e056df68395dc9c3b3a674361b Sep 20 16:02:52 <mst_> sberg: ^ Sep 20 16:04:05 <sberg> mst_, thanks; so there's likely an (implicit?) exception for \fcharset2, as you say Sep 20 16:04:33 <mst_> that's most plausible, our own font code is full of exceptions for "symbol fonts" too Sep 20 16:05:19 <sberg> mikekaganski, ENOCONTEXT Sep 20 16:05:36 <mikekaganski> sberg: [17:01:16] sberg: vmiklos, what's the control word to select such a font, also \fN? I don't see any such in n823675.rtf Sep 20 16:06:32 <sberg> mikekaganski, so you say selection is done with \af3 instead of \f3? Sep 20 16:06:40 <mikekaganski> sberg: yes, in that case Sep 20 16:07:34 <mst_> i think there are several different keywords that apply fonts, but can't remember the whole list Sep 20 16:08:10 <mst_> \fN shoudl be one of them though Sep 20 16:22:18 <sberg> vmiklos, so who generated that sw/qa/extras/rtfimport/data/n823675.rtf, was it manually created and lacks a \cpgN before "Symbol"? Sep 20 16:29:17 <sberg> vmiklos, (after further reading of the RTF spec): disregard the "and lacks a \cpgN before 'Symbol'" part of my above question Sep 20 16:30:27 <mst_> sberg: i suggest not reading too much about encoding in RTF, it gets pretty lovecraftian pretty fast... Sep 20 16:32:58 <vmiklos> sberg: given how short that bugdoc is, i'm pretty sure i cut it down manually to something readable from a multi-MB real bugdoc Sep 20 16:33:07 <sberg> mst_, do you have a recommendation how I could get that "don't use symbol font encoding to read a symbol font's name" into writerfilter/source/rtftok/rtfdocumentimpl.cxx? RTFDocumentImpl::checkUnicode lacks the context to tell whether it is using m_aStates.top().nCurrentEncoding to convert a fontname, and the caller of checkUnicode (at the end of RTFDocumentImpl::resolveChars in this case) appears to lack the context, too Sep 20 16:33:12 <mst_> various Old Ones from The Time Before Unicode and their Backward Compatibility Tentacles etc. Sep 20 16:34:59 <sberg> vmiklos, anyway, that "so there's likely an (implicit?) exception for \fcharset2" hypothesis sounds sane, so we should probably implement it (if only you or mst_ can give me a good hint how...) Sep 20 16:35:13 <vmiklos> sberg: looking for a code pointer Sep 20 16:36:05 <mst_> sberg: m_aStates.top().eDestination == Destination::FONTENTRY should be the relevant check? Sep 20 16:36:17 <vmiklos> sberg: RTFDocumentImpl::text() is where the text is taken, Destination::FONTENTRY is the state on the parser stack which is a font entry in the font table. so to detect "your case" during decoding a byte array into a string, m_aStates.top().eDestination == Destination::FONTENTRY is what you want Sep 20 16:36:35 <vmiklos> ah good, two independent matching hints are promising ;) Sep 20 16:37:35 <sberg> mst_, vmiklos, ah; but what also looks dodgy is that checkUnicode operates there on "Symbol;" including the closing ";" of the full <fontinfo>, not just the <fontname> part of the <fontinfo> Sep 20 16:39:24 <vmiklos> sberg: i think we already assume that the only "token" in the font entry destination that is not bound to a control world (\foo) is the font name Sep 20 16:40:52 <vmiklos> sberg: writerfilter/source/rtftok/rtfdocumentimpl.cxx:1237 is where we simply strip away the trailing semicolon, there is no further separation between the font name and other character content inside the destination (apart from the control words and their arguments) Sep 20 16:42:18 <sberg> vmiklos, OK, thanks; I'll just pretend I haven't seen those dodgy details :) ...so I'm switching to (somewhat arbitrarily) RTL_TEXTENCODING_MS_1252 there now Change-Id: Iebd1bcecb7fa71c489798154d3356062b052775e Reviewed-on: https://gerrit.libreoffice.org/42477 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-24iOS, removed outdated prototypejan Iversen
removed experiments prototype. Change-Id: I691c82dca79c652d9a7c6078f2c69dada9034a36
2017-09-24tdf#96411 Add slide layout to context menusYousuf Philips
Change-Id: Ia1a277b39ea1d553ff32af4b0287603dcbf5e2b0 Reviewed-on: https://gerrit.libreoffice.org/42698 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-09-24Improve wording for Writer compatibility optionOlivier Hallot
Change-Id: I852304204c1a95022dbd8305a892812c159a4445 Reviewed-on: https://gerrit.libreoffice.org/41544 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-09-24Compensate for loss of Type 1 "Standard Symbols L" substitute for "Symbol"Stephan Bergmann
At least for me on Linux since LO 5.3, 'soffice sw/qa/extras/rtfexport/data/fdo72031.rtf' shows "Å" (rendered in "DejaVu Sans") instead of "⊕" (rendered in "Standard Symbols L"). That's presumably because 47ea13ef8dc8ab9aeded6121845e3ebd1d28b292 "Kill the old Unix layout engines" removed support for Type 1 fonts (see "Ignore Type 1 fonts" in FontCfgWrapper::addFontSet, vcl/unx/generic/fontmanager/fontconfig.cxx), and my (Fedora 25) /usr/share/fonts/default/Type1/s050000l.pfb "Standard Symbols L" is a Type 1 font. So we fell back to fontconfig's generic (weak) suggestion of "DejaVu Sans" as a substitute for "Symbol". So extend our fc_local.conf to suggest our "OpenSymbol" as a substitute for "Symbol". As that fc_local.conf was originally brought along by --with-fonts, which is enabled by default but can be disabled, compilation of fc_local.conf from the various snippets is moved to postprocess. macOS and Windows were never affected, as they both come with a "Symbol" font installed in the system. (And we don't install fc_local.conf on Windows at all.) Change-Id: I8d6d87f24974577fd66f5f3989f606237ebb3d75 Reviewed-on: https://gerrit.libreoffice.org/42670 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-24Updated coreOlivier Hallot
Project: help 2ab31faddac65547ac961da7fc47f0c61dd694b3 Add hungarian to helponline ui Change-Id: Icc1abd566c32f6b873fd979cba2190a9ce959a69 Reviewed-on: https://gerrit.libreoffice.org/42685 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-24tdf#103685: "Commands out of sync" when connecting to MySQL using directJulien Nabet
Thanks to Lionel for his great help Change-Id: Ifcc1d72cca29c031f31da203cd1e3302ea0ea3e3 Reviewed-on: https://gerrit.libreoffice.org/42688 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-09-23ofz#3005 avoid timeoutCaolán McNamara
Change-Id: Ie06504957dab6a5035c7fa3c9313f316303c4eb8 Reviewed-on: https://gerrit.libreoffice.org/42700 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-23ofz#2956: Conditional jump or move depends on uninitialised valueCaolán McNamara
Change-Id: I399c2eb2379b23568dda83f9d41473858f33a802 Reviewed-on: https://gerrit.libreoffice.org/42699 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-23buildscripts section actually needs dedicated repositoriesChristian Lohmaier
Change-Id: I50f080d085dcd303b2cc54f503793f080ea4f50c
2017-09-23coverity#1418341 Dereference after null checkCaolán McNamara
Change-Id: I525895b3a37a52e05a06ad4f2e1663ecd9d7ce52 Reviewed-on: https://gerrit.libreoffice.org/42692 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-23these are cast to sal_Int32 immediatelyCaolán McNamara
Change-Id: I2357ecb5fecd3c232803530fcd131d54e63b85fb Reviewed-on: https://gerrit.libreoffice.org/42695 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-23want to add these together before multiply the resultCaolán McNamara
Change-Id: I5f42ed3d5ad5d64faeb06bbfaaa23d84e81963b0 Reviewed-on: https://gerrit.libreoffice.org/42694 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-23coverity#1418340 Division or modulo by zeroCaolán McNamara
Change-Id: I0941f8db6b406c8ac316daef46b42e4694053410 Reviewed-on: https://gerrit.libreoffice.org/42696 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-12-28 21:51:41 +0000