summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-02-28lok: update main threadHenry Castro
In the pre-initialization phase of the tiled rendering case the SvpSalInstance is created in a different process and when a new process is created (fork), the main thread identifier does not match so it is required to update it. Change-Id: I189e53f0b46c60f34a8016222079c9b1e2b3fef8 Reviewed-on: https://gerrit.libreoffice.org/50477 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2018-02-28Resolves: tdf#114555 check .xlsx col/row/tab overflow and display warningEike Rathke
Change-Id: I3091a890b6d4a3f27d9284fc5c0e2df3bc8ce527
2018-02-28ofz#6617 Integer-overflowCaolán McNamara
Change-Id: I4fc99ef32e769222164b30373acc5c387a922b88
2018-02-28weld SwStringInput to native dialogCaolán McNamara
Change-Id: I31333ef4a4cef3fe282245cc9622fc7e44d55432 Reviewed-on: https://gerrit.libreoffice.org/50520 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-28Fix assert(mpDialogImpl->get_response(pButton) == RET_OK) etc.Stephan Bergmann
...in Dialog::add_button (vcl/source/window/dialog.cxx:1338) during CppunitTest_cui_dialogs_test4 (part of `make screenshot`) Change-Id: I960c6e83ece088bc67888f265f90c663d8408adb Reviewed-on: https://gerrit.libreoffice.org/50518 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-28Fix assert(mpDialogImpl->get_response(pButton) == RET_HELP)Stephan Bergmann
...in Dialog::add_button (vcl/source/window/dialog.cxx:1344) during CppunitTest_cui_dialogs_test2 (part of `make screenshot`) Change-Id: I5dee49415421df9c7f476fadc5486636ca2af881 Reviewed-on: https://gerrit.libreoffice.org/50517 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-28use ok, cancel under kde vs cancel, ok under gnomeCaolán McNamara
for the native welded dialogs Change-Id: I34663616826c1eb084262ea1c830f8580785d50c Reviewed-on: https://gerrit.libreoffice.org/50458 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-28ofz#6571 catch exceptionCaolán McNamara
Change-Id: Ibbc5e7cc24d2125af8d757c8f59121d82ac8ce59 Reviewed-on: https://gerrit.libreoffice.org/50508 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-28vcl: test greyscale bitmap conversion functionsChris Sherlock
Change-Id: I9a71bcbc0bac0bdd4a401b129a7abd55eb43c910 Reviewed-on: https://gerrit.libreoffice.org/50399 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-28tdf#115859 Export number format for chart seriesSzymon Kłos
Change-Id: I65d30c6b92a530eadbd6fabe87fa8bd3416fee20 Reviewed-on: https://gerrit.libreoffice.org/50385 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-02-28Updated coreIlmari Lauhakangas
Project: help 1f58d6b4eb8d2e43f4abfca42196550912140a43 Add spacing between paragraphs, update normalize.css Change-Id: I85df8d29fa78377d684adb4435087cc9f586dbe3 Reviewed-on: https://gerrit.libreoffice.org/50516 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-02-28iOS, removed read to pipesjan Iversen
needed to run iOS Change-Id: I1176ce24023cde21846c71ffadb1bf01cb2c8399
2018-02-28Missing dependenciesStephan Bergmann
Change-Id: I1d153b9962cfe3b280831644c8d989ab8b515d3e
2018-02-28tdf#115795 Solve wrong redirect behavior of "Get Online Help"Franklin Weng
When under locale zh-TW, Help > Get Online Help would use only "zh" as the parameter of LOLang and sent it to hub.libreoffice.org, which would redirect to Simplified Chinese forum instead of zh_TW ask.libreoffice.org forum. After discussing with Guilhem he refactored the behavior of the Hub, use LOlocale instead of LOLang, and keep LOLang for backward compatibility. The LibreOffice sent LOlocale instead to avoid this problem happening again. Change-Id: Ia9348cff88723210f693e65260bb987826a3f3ea Reviewed-on: https://gerrit.libreoffice.org/50503 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-02-28Clean up Desktop::CreateTemporaryDirectoryStephan Bergmann
...avoiding the confusing, and apparently unnecessary back-and-forth between system path and file URL. (Superseding <https://gerrit.libreoffice.org/#/c/50422/> "Don't overwrite system temppath with old one that failed already".) Change-Id: I247982a40d54565f5c98bda9a36209cba83c5c9f Reviewed-on: https://gerrit.libreoffice.org/50494 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-28swarm: don't assert the result in testUnconstrainedTomaž Vajngerl
It can happen the algorithm doesn't converge the values towards the solution in the timeframe and number of generations it has available (slow execution, high cpu load, bad luck) so for now don't assert the expected value in the test, but still run it so we know the algorithm does end eventually and doesn't cause any seg. faults. Change-Id: Ic889ad1618bf057ac7b281c15bce735f8ec5e13c Reviewed-on: https://gerrit.libreoffice.org/50500 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-28Let Application::Abort always dump core in debug buildsStephan Bergmann
Change-Id: I788601193f77641d613005a93e73cf184cb0daf0 Reviewed-on: https://gerrit.libreoffice.org/50436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-28Drop unnecessary HIDs from Hyperlink dialogGabor Kelemen
The defaults from ui files will do just fine Change-Id: Idd0f3b2f171386142971e7b285abaf869e42717f Reviewed-on: https://gerrit.libreoffice.org/50379 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-02-28drop old tools/gen methods in reportdesign..xmloffNoel Grandin
Change-Id: I398831c526ba51d861557fa6c13c0e2fb44dfbe0 Reviewed-on: https://gerrit.libreoffice.org/50447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-28UBSan: signed integer overflowStephan Bergmann
It apparently happens during test_resize_table_with_keyboard_tdf53460 (UITest_writer_tests) that CalcRowRstHeight doesn't get into the while loop at all, and thus returned LONG_MAX where it presumably should have returned 0: > /sw/source/core/layout/frmtool.cxx:3149:24: runtime error: signed integer overflow: 9223372036854775807 + 9223372036854775807 cannot be represented in type 'long' > #0 0x2b7365e0b23c in lcl_CalcCellRstHeight(SwLayoutFrame*) /sw/source/core/layout/frmtool.cxx:3149:24 > #1 0x2b7365e085a4 in CalcRowRstHeight(SwLayoutFrame*) /sw/source/core/layout/frmtool.cxx:3162:43 > #2 0x2b7365e0b1f8 in lcl_CalcCellRstHeight(SwLayoutFrame*) /sw/source/core/layout/frmtool.cxx:3149:27 > #3 0x2b7365e085a4 in CalcRowRstHeight(SwLayoutFrame*) /sw/source/core/layout/frmtool.cxx:3162:43 > #4 0x2b736478608b in lcl_SetSelLineHeight(SwTableLine*, CR_SetLineHeight&, long, bool) /sw/source/core/doc/tblrwcl.cxx:3950:30 > #5 0x2b7364779d8e in SwTable::SetRowHeight(SwTableBox&, TableChgWidthHeightType, long, long, SwUndo**) /sw/source/core/doc/tblrwcl.cxx:4165:28 > #6 0x2b7364a775b9 in SwDoc::SetColRowWidthHeight(SwTableBox&, TableChgWidthHeightType, long, long) /sw/source/core/docnode/ndtbl.cxx:3975:16 > #7 0x2b7365824397 in SwFEShell::SetColRowWidthHeight(TableChgWidthHeightType, unsigned short) /sw/source/core/frmedt/fetab.cxx:2236:17 > #8 0x2b736ac1f100 in SwEditWin::KeyInput(KeyEvent const&) /sw/source/uibase/docvw/edtwin.cxx:2644:50 > #9 0x2b730315ee16 in WindowUIObject::execute(rtl::OUString const&, std::__debug::map<rtl::OUString const, rtl::OUString, std::less<rtl::OUString const>, std::allocator<std::pair<rtl::OUString const, rtl::OUString> > > const&) /vcl/source/uitest/uiobject.cxx:343:17 > #10 0x2b736b9960fc in SwEditWinUIObject::execute(rtl::OUString const&, std::__debug::map<rtl::OUString const, rtl::OUString, std::less<rtl::OUString const>, std::allocator<std::pair<rtl::OUString const, rtl::OUString> > > const&) /sw/source/uibase/uitest/uiobject.cxx:115:9 > #11 0x2b73031e89c2 in UIObjectUnoObj::executeAction(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)::$_0::operator()() const /vcl/source/uitest/uno/uiobject_uno.cxx:145:9 > #12 0x2b73031e7399 in std::_Function_handler<void (), UIObjectUnoObj::executeAction(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)::$_0>::_M_invoke(std::_Any_data const&) /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:1871:2 > #13 0x2b73003d6ba0 in std::function<void ()>::operator()() const /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:2271:14 > #14 0x2b73031e5f6a in (anonymous namespace)::ExecuteWrapper::ExecuteActionHdl(Timer*) /vcl/source/uitest/uno/uiobject_uno.cxx:92:13 ... Change-Id: I2263908e3136cc5205f838723e7e8a6ab18d6073 Reviewed-on: https://gerrit.libreoffice.org/50489 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-28Fix some IWYU warningsMiklos Vajna
Change-Id: I5aa3744ee7f26dfefecbe9b9fa6aef700049ff32 Reviewed-on: https://gerrit.libreoffice.org/50469 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-28use less COLORDATA_RGBNoel Grandin
part of removing ColorData Change-Id: I5518cddeeefe66f70380367e1e3f78af0f3b5fbc Reviewed-on: https://gerrit.libreoffice.org/50486 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-28sw HTML export: allow custom XHTML namespace aliasMiklos Vajna
This helps in case the HTML filter expected to produce an XHTML fragment that has an explicit namespace alias for <http://www.w3.org/1999/xhtml>. This only has an effect when HtmlWriter is used to write elements, though. Change-Id: I161caf4bb6bc6d0c21a7a67433b08bb060b447f1 Reviewed-on: https://gerrit.libreoffice.org/50448 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-28Use for-range loops in cuiJulien Nabet
Change-Id: I82cbea6d221ec0fd0e0d4620bdda698f2bed520e Reviewed-on: https://gerrit.libreoffice.org/50472 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-28Translate German comments and debug stringsJohnny_M
Change-Id: Ie2da785cb674e21f042caa5e6d461e3489036003 Reviewed-on: https://gerrit.libreoffice.org/50467 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2018-02-28tdf#113558: Replace 'AutoFormat' button in insert table dialog.Furkan Tokac
Writer > Table > Insert Table... > AutoFormat part is moved to "Insert Table..." dialog box with realtime style preview. Change-Id: I72ed46401fb053156a4787450fc974951923d049 Reviewed-on: https://gerrit.libreoffice.org/49886 Reviewed-by: Furkan Tokac <furkantokac34@gmail.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-02-28ofz#6602 infinite recursionCaolán McNamara
Change-Id: I358708f606655bcd0df948fd2e01725c706880c7
2018-02-28Merge upstream fixes into solenv/flatpak-manifest.inStephan Bergmann
* <https://github.com/flathub/org.libreoffice.LibreOffice/commit/ f5d97291e302d98c217c955c52b255795d4d4cad> "Bump runtime-version to org.gnome.Platform 3.26" * <https://github.com/flathub/org.libreoffice.LibreOffice/commit/ 7d69e505165d4bbf5fa0b34b5fb2cbff9dfaf9bd> "For now, bundle gst-libav to be able to play mp4 videos in impress" Change-Id: I1924d84be7fe577e302b0c1b8c7e2971e8583d73
2018-02-28sneaky uppercase OK,CANCEL,HELP responsesCaolán McNamara
Change-Id: I02324d31822c37daa1e5e1b8c87aa597def58957 Reviewed-on: https://gerrit.libreoffice.org/50437 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-28ensure [Message]Dialog dispose order on direct .ui hackeryCaolán McNamara
Change-Id: I31f190a1232331dd2076cdb8583e2036887f4f9f Reviewed-on: https://gerrit.libreoffice.org/50441 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-28Updated coreLászló Németh
Project: dictionaries 2b7711678410bc531e9d07b4d6f85bfb85f2116a tdf#116072 Improve Hungarian spell checking by better word breaking and ignore the special characters of the word forms, or break at the special character and check the word stem and affix (with a starting hyphen) separately: vár(hat)nak -> várhatnak „Tisza”-ban -> Tisza, -ban [Note: this removes false alarms in Writer, but extra grammar checking can help to check matching of the stem and the affix.] Change-Id: Icb810ccc1ecb84fea3ee5093100e2fdc874edb6c Reviewed-on: https://gerrit.libreoffice.org/50475 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2018-02-28tdf#116072 Extend MidLetter in Hungarian word breakingLászló Németh
Now ”, (, ), ], ?, ! are MidLetter characters to handle (1)-ben, "ember(ek)ről", "„Tisza”-ban" etc. forms as words for better Hungarian spell checking. Change-Id: I47882e73af08531d14d555ced5dd4c98403686ec Reviewed-on: https://gerrit.libreoffice.org/50473 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2018-02-28loplugin:cppunitassertequals in tiledrendering (sw/qa)Julien Nabet
Since https://cgit.freedesktop.org/libreoffice/core/commit/?id=3c3e07b51fb09d09cfef54193f93b07304f4ccda Change-Id: Iec43809719c71f856aa4a89ffbf40473c48b2fe1 Reviewed-on: https://gerrit.libreoffice.org/50488 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2018-02-28convert COL_ constants to be of type ColorNoel Grandin
Change-Id: I0e25c8950ac26b851ff42f71e1471fcbe4770d48 Reviewed-on: https://gerrit.libreoffice.org/50373 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-28Remove obsolete commentMike Kaganski
Obsoleted by commit 7ce1e0e1ecbb1b3ec5e3cc15306a9df7e786c564 Change-Id: I479455ba704c7e2bf1df2308950e7a9b682762b6 Reviewed-on: https://gerrit.libreoffice.org/50433 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-28tdf#116074: Use modeless dialogs with supporting mailersMike Kaganski
When sending mail using MS Outlook, our UI gets locked until user closes the Outlook's compose message window. This patch uses Outlook 2013+ option to show modeless window. Change-Id: Ib99b4440cd20a8bff0c7cd96838b31a2d14bd804 Reviewed-on: https://gerrit.libreoffice.org/50476 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-28Use Unicode for senddocMike Kaganski
Also removes unused code and unnecessary dependencies from it. Change-Id: Ib6de29358098846ca5e7330b10e67a88cfff8a6a Reviewed-on: https://gerrit.libreoffice.org/50444 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-28sax: don't crash during loggingVasily Melenchuk
SaxParser was crashing during load of some MS documents if logging is enabled. Change-Id: I08a57b9a948bb4a35afcb82a29614c2f6a443446 Reviewed-on: https://gerrit.libreoffice.org/50110 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-28tdf#115429: declare fill-ruleJulien Nabet
Change-Id: I5eb93d08b1dd56db19038132b560ddf7ba174bc6 Reviewed-on: https://gerrit.libreoffice.org/49242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-28Updated coreAndika Triwidada
Project: dictionaries ed6a0c24ca0c76b21375f73c29cc73e9974142ea Add Indonesian dictionary Change-Id: I1368bccffe9f192de4d73c5f658d4f864e3374da Reviewed-on: https://gerrit.libreoffice.org/49785 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-28ofz#6576 check border param lenCaolán McNamara
Change-Id: Ie479ef953b7c0f4a30afdafa27a9be121a346562 Reviewed-on: https://gerrit.libreoffice.org/50455 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-27Updated coreOlivier Hallot
Project: help 9e31d6fffa7505c009c603f3fd605eea9460958d tdf#36970 Revisit digital signature help content Many thanks to orcmid for the precisions. Change-Id: I362abe27a3eb5748e90b8797206f414c0eade537 Reviewed-on: https://gerrit.libreoffice.org/50471 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-02-27cast MessBox into exileCaolán McNamara
Change-Id: I2fccc06b2228c1e7fd791d049d951d3a09f0f814 Reviewed-on: https://gerrit.libreoffice.org/50432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-27Add newly wrong formatted files to clang-format blacklistMiklos Vajna
Change-Id: I1c3c3754f4c18415f74342c01de6afd246b29f4d
2018-02-27Updated coreOlivier Hallot
Project: help dd09149dfe0135a4abbd1abbcee15d115af0f982 tdf#97977 Mark MODE function as ODFF compliant Change-Id: I50f669c2b64645eaa6f93d45fb161c2598f1e903 Reviewed-on: https://gerrit.libreoffice.org/50461 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-02-27astyleDavid Tardon
Change-Id: I3ea599f491a464458865ce42930be4728ede5dc9
2018-02-27set number of read bytes correctlyDavid Tardon
It was wrong if we read less than was expected. Thanks to Antti Levomäki and Christian Jalio from Forcepoint. Change-Id: I070c1731d1aace4c101fa01efed0c28734c44899
2018-02-27Resolves: tdf#116062 revert [fr-CH] to use previous single quote charactersEike Rathke
Even if that's not what should be used.. see sources in commit 4b938c558d004537cf73ca4319019ff64f052270 Date: Fri Feb 9 12:59:51 2018 +0100 Use angle quotation marks (Guillemets) for [*-CH], tdf#115493 related Change-Id: I733bc767ff4484c251f8624f90a5295875bf17ea
2018-02-27tdf#45904: Move _SheetFilterDescriptor Java tests to C++Jens Carl
Change-Id: I894b2e2534efeb5369c491053caf56f67dc56618 Reviewed-on: https://gerrit.libreoffice.org/50411 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-02-27tdf#114441 sal_uLong to better integer typesShubham Verma
Change-Id: I55b45821cf67a99f97ba067a3d4923d76c19696e Reviewed-on: https://gerrit.libreoffice.org/50204 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>