summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-01-17Recheck modules [e-f]* with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: I49a3ce10dee4b03f99156f5b641f69448e1d5617 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128479 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-16Mysql/MariaDB: implement edit VIEW with GUI or SQLJulien Nabet
Delete View works (and the list is updated) Modifying View works But, there are at least 2 things to fix: - adding a view still works but the list isn't updated without manual refresh) - renaming view doesn't work (a popup error message appear) Change-Id: I48ffb322910ca64d51a161424f265de387bdd7ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128483 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-16tdf#146421 Calc Sidebar Alignment Section follow arrangement guidelineandreas kainz
Change-Id: If1ffb50743292f3cc0c3271646d0538337977762 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126688 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2022-01-16SwNavigator: use one loop instead of two to fill fields member listJim Raykowski
Change-Id: I02f20e48606a34b2f9f4739f1777dd8aea8637ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127798 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-01-16dump AltNaturalDXArray if presentCaolán McNamara
Change-Id: I3410a7c4c999e660b2df69dcea8f7c5bd7fa3196 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128486 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-16add missing placeholder labelsCaolán McNamara
Change-Id: Iae743fd6d7e13f91501e386e609e5965ef742db0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128482 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-16ofz: Use-of-uninitialized-valueCaolán McNamara
Change-Id: Ib1c3b306573dda073f6ff3d7d0cc17aef39c0a0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128480 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-16tdf#146453 retain precise vertical base pos with ResolutionIndependentLayoutCaolán McNamara
Change-Id: Ied157d8d4bc9b57cfa17716453189ddf48cba641 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128485 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-16Related: tdf#146453 retain accurate positioning in rotated text renderingCaolán McNamara
Change-Id: I477c5a72dd9618a2b0f3e91a96209ae3f6b3d1aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128484 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-16Firebird: missing space in DROP commandJulien Nabet
It's more to have something clean. Indeed there wasn't impact on Firebird since the table name is surrounded by quotes, eg: DROP TABLE"TableTest" Change-Id: Iad525ccb912347798c6780fd1a5bac12ee85333f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128488 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-16restore the explicit translatable="no" for some labelsCaolán McNamara
Change-Id: Ifbb05dc12a02afd11470e868b88d72fa18c1a388 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128481 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-16ofz#43689 Null-dereferenceCaolán McNamara
Change-Id: I6edb50b3c281d50187d8965ce9665a9aae0e9098 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128478 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-16Qt notify LO of many QScreen related eventsJan-Marek Glogowski
LO just has a single display event, SalEvent::DisplayChanged, Qt has a multitude. So this will generate multiple LO notifications. I don't see any reasonable way to prevent that. Doesn't seem a problem here. Change-Id: I2f11e53765869a4ca292a1d337347e4e7470e3c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128474 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-16use more concrete types in chart2, ChartViewNoel Grandin
Change-Id: I51d503cd71ef2adc0e590ef836dabf9906495bbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128475 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-16use more concrete types in chart2, DiagramNoel Grandin
Change-Id: Iae84e16b3406f4c08139764a1838e38b13cebee7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128471 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-16tdf#146439 retain precise base start pos when using ResolutionIndependentLayoutCaolán McNamara
Change-Id: I16a585abf4805d87a2eeb4e3e9d9bd9f2697b838 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128472 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-15include memory for std::unique_ptrCaolán McNamara
Change-Id: I63aa82b45f3dfcfd89d5d655eae3b347c1092af4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128470 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-15use more concrete types in chart2, ChartModelNoel Grandin
Change-Id: Iecbc92aa096ede1845936faa708d1a9e8747b658 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128467 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-15Mysql/MariaDB: make rename table workJulien Nabet
by just letting general mechanism deal with it Change-Id: Iac70137c94419b719266f31222205d651d18b43b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128468 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-15include memory for std::unique_ptrCaolán McNamara
Change-Id: I15f78ecfc53e75403bb8edbcd6e5400e8ecaaa44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128465 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-15A unit test for tdf#146367Eike Rathke
Change-Id: Ie47f1525f387d019c7c1131a76faf3784ee99d4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128466 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-01-15Let loplugin:nullptr look into template instantiationsStephan Bergmann
It missed some occurrences of 0 when only looking into uninstantiated template code, as Clang doesn't model them with an ImplicitCastExpr, even if the target is known to be a (dependent) pointer type. Looking into all template instantiations of course carries the risk that a given use of 0 is meant to be interpreted as a pointer in some and as an integer in other instantiations. But the only case where that happened in the current code base is RegistryValueList::getElement (include/registry/registry.hxx), where {} is arguably a better choice anyway. (And which would presumably also hold for any future such cases.) Change-Id: I708bcfc8bedc0a49c9282d7814eb325afa29905c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128462 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-01-15use more concrete types in chart2, ChartViewNoel Grandin
Change-Id: I7316d01d08eb1d9d482937fdd87bd34e2ae7e3c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128461 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-15remove XTransformation UNO APINoel Grandin
unused after commit 18bc9ea75daf4eb3520a4d0ef6649d92261012a6 Date: Tue Jan 11 15:02:14 2022 +0200 replace XTransformation with more efficient class Change-Id: I9e6bf80d8a8cdba8514ad0e94ce090bdbceab853 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128460 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-15Allow g to run git gc commandArnaud VERSINI
Change-Id: Ibca338cbd99839b20a2373075a2e544e7ab638e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127870 Tested-by: Jenkins Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2022-01-15request the 2nd rect explicitly instead of one with a particular 'top' valueCaolán McNamara
Change-Id: I04caee2263e5e7345fb3fb0c07830d1bf504bf7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128448 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-15Mysql/MariaDB: related:tdf#81430, fix regression refresh tables/views manuallyJulien Nabet
Change-Id: Ia17a396a8d55e38ac8ad42fab90c50bfaf96809e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128459 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-15tdf#146367 reintroduce approxAdd() similar handling with last summandEike Rathke
... to tie result to 0 eliminating opposite sign small equalish fractions. This does not "fix" all interim values of the bug's sample document, which repeatedly adds single values in sequence using SUM() and should use the + operator instead to benefit from approxAdd() for each, but maintains the better accuracy of Kahan summation in the not near equal zero cases. And the dreaded SUM(0.1;0.2;-0.3) also works again resulting in 0 with all permutations. Change-Id: I67188a6abbdb98212f070166ad02319c3d477e28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128451 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-01-15Change cursor -> pointer in spreadsheet option tipOlivier Hallot
Change-Id: I4fe40f321849846daaddd1c9374a0271689b5823 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128425 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-01-15Fix extended tip on printer options for speradsheetsOlivier Hallot
Change-Id: Iad153527e4ee4b74cb9d7bf6a57821a9f13f1f16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128426 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-01-15Resolves tdf#139395 - Redesign of font name and effects pagesHeiko Tietze
* Western/CJK/CTL selection placed into a GtkNotebook * Font color and transparency in one line * Alignment adjusted at font effects page * Char-, para- & style dialogs made non-resizable according the guideline Change-Id: I242c3886534a2696b4c2438ca17e6e778c2c3991 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125909 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-01-15Mysql/MariaDB: related:tdf#81430, fix regression create tableJulien Nabet
Change-Id: I8f2983c1d08026ad0cbe796f73e0ff44f917de17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128458 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-15tdf#146754: consider xyz:123 as host:port when parsing URLs smartMike Kaganski
... rather than scheme: and path. Change-Id: I9a48310b585b8fa3e31635f877a91f1560b065f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128457 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-01-15Mysql/MariaDB: related:tdf#81430, fix regression drop tableJulien Nabet
Change-Id: I4b021847cfe855061b862006fbdc4ac36797ee09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128455 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-14Mysql/MariaDB: tdf#81430 make tables editable (with or without PK)Julien Nabet
Change-Id: I7df464107e692817ef80d887a4addea618d6cc72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128356 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-14Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to 143eb86de536e863170222617485c3e7f41d628a - Related tdf#123318 Fix filtering with SHARED Change-Id: Ic704b5ddcc0448a884da4ca01fa54bb94692495f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128423 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-01-14make comphelper::OInterfaceContainerHelper4 more threadsafeNoel Grandin
(*) make all the methods that require an external mutex take a std::unique_lock as a parameter, so that call sites cannot forget (*) make the forEach method drop the lock when firing listener methods, to reduce the odds of deadlock Change-Id: I0a80e3b3d1c1c03b7de4a658d31fcc2847690903 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128415 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-14Removed duplicated includeAndrea Gelmini
Change-Id: I080325a828d26a9d3fd93542315b3c4f5f1584e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128421 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-14sw tests: audit uses of loadAndSave()Miklos Vajna
When it comes to changing import + import-export-import tests to do only import-export instead, this is only safe if we assert the resulting exported XML. Replace calls to loadAndSave() with loadAndReload() when we want to assert the doc model after an export. Thanks to Justin for flagging this, luckily it seems there is only a single test that fails after restoring the lost asserts (and that has already been fixed). Change-Id: I62cd4330c62d801dd9e6c7ef73decab3972c0b58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128411 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-01-14VCL move SolarMutex (un)locking into (De)InitVCLJan-Marek Glogowski
Fixes all the backends, where SolarMutex access needs SalInstance. The ImplSVData::SalInstance is just set fron the return value of CreateSalInstance, so it can't be accessed earlier, globally. Regression from commit ad94bb5d23d9c4ecbb2ca84807f01623862de43e ("VCL drop m_pInstance from *nix SalData). Change-Id: I13259009571a9973ea7e3ded20c0ea4c660ee214 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128420 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-14tdf#146375: sw: add UItestXisco Fauli
Change-Id: I8d165b257f4bee3921f1a4624a7797ed22327e40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128419 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-14VCL drop m_pInstance from *nix SalDataJan-Marek Glogowski
AKA the "*nix SalData untangling" commit. The original plan was to get rid of vcl/inc/saldatabasic.hxx and even SalData for all the *nix backends. But after many backs and forths, reinspecting the code and imagining the resulting code, I decided against that plan. All these variants would have resulted in reinterpret_cast calls, I wanted to prevent. And they would have required larger renames for no benefit. An other, related idea was to include all SalData implementations in the vcl/inc/svdata.hxx header, but that seemed like an include explosion, so was also dropped. I tried to untangling iOS from using GenericUnixSalData, as it doesn't use any of it's features. The new, minimal SalData should be sufficient. I'm leaving the easier drop of mpInstance from the Windows and MacOSX backend as a minimal interesting EasyHack. Change-Id: I5be01c1f42131a7e31cb30899392308e1e2de53b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128402 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-14tdf#136481 show the focus rect for the case nothing is yet selectedCaolán McNamara
but the cursor is at pos 0 Change-Id: I7c94480bffdced23fe89d4e3ba0e729742247130 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128414 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-14ofz: fix build. error: missing member 'm_pPIManager'Caolán McNamara
probably since... commit bc3f70f220091f09ad02c148a6a49fdccb7b85c5 Date: Thu Jan 13 20:15:39 2022 +0100 VCL move PrinterInfoManager into GenericUnixSalData ... and use a std::unique_ptr. Change-Id: I07ffed4f722e30269ddf4828ffba3ac34952adb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128417 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-14respect TextRenderModeForResolutionIndependentLayout for mac tooCaolán McNamara
Change-Id: I1e572bd03387e1708fe75b90c2bce220b41c29e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128409 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-14Restore tdf#134951 docxexport: stop duplicating stuff in postponed textMichael Stahl
Partially revert commit f261fae4af72b1328bc3e93fc52a9a24ce0975b3 to restore deb892628a1501527c8c41b85a65282df95b81b1 because as reported by jluth the test case testfdo79008 that failed was apparently somewhat misleading and the test case testTdf134951_duplicates that should test comments erroneously failed to fail because it is doing a loadAndSave() instead of a loadAndReload(). Change-Id: I7e788287da3b1742f65697ec350997d175db9e69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128410 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-14tdf#146747 InternalItems has to be null terminatedCaolán McNamara
Change-Id: I15c0afdcae3e9bc1412e6564c15df2196515052e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128412 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-14tdf#146703 Rework previous fix to query extension metadataGabor Kelemen
to limit its error potential by encoding only the category string Change-Id: Ia3d3bfa6981ec46b71b500980abda9ad7f606cd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128361 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2022-01-14Resolve tdf#124572 - Draw a faint line between tabsHeiko Tietze
Change-Id: I6cbbefe1cb16599ae81fc6dcb5a51ef1ca2db6f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128407 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-01-14Firebird: no need to override getTypes in TableJulien Nabet
Change-Id: I0af49eef735f5191f956f9ef9ae8e39c1eb7651a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128375 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2025-01-29 00:49:13 +0000