summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-11-03crash on loading tdf77861-3.rtf in calc rtf filterCaolán McNamara
pActDefault is either pInsDefault or a member of maDefaultList, so clear it if its not pInsDefault at this location ScRTFParser::ProcToken(RtfImportInfo*) (rtfparse.cxx:332) ScRTFParser::RTFImportHdl(RtfImportInfo&) (rtfparse.cxx:160) ScRTFParser::LinkStubRTFImportHdl(void*, RtfImportInfo&) (rtfparse.cxx:155) Link<RtfImportInfo&, void>::Call(RtfImportInfo&) const (link.hxx:84) EditEngine::CallRtfImportHandler(RtfImportInfo&) (editeng.cxx:2770) EditRTFParser::NextToken(int) (eertfpar.cxx:231) SvRTFParser::Continue(int) (parrtf.cxx:643) SvxRTFParser::Continue(int) (svxrtf.cxx:128) SvRTFParser::CallParser() (parrtf.cxx:574) SvxRTFParser::CallParser() (svxrtf.cxx:123) EditRTFParser::CallParser() (eertfpar.cxx:112) ImpEditEngine::ReadRTF(SvStream&, EditSelection) (impedit4.cxx:161) Address is 52 bytes inside a block of size 56 free'd std::default_delete<ScRTFCellDefault>::operator()(ScRTFCellDefault*) const (unique_ptr.h:76) std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >::~unique_ptr() (unique_ptr.h:239) void std::_Destroy<std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> > >(std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >*) (stl_construct.h:93) void std::_Destroy_aux<false>::__destroy<std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >*>(std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >*, std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >*) (stl_construct.h:103) void std::_Destroy<std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >*>(std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >*, std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >*) (stl_construct.h:126) void std::_Destroy<std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >*, std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> > >(std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >*, std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >*, std::allocator<std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> > >&) (stl_construct.h:151) std::__cxx1998::vector<std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >, std::allocator<std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> > > >::_M_erase_at_end(std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >*) (stl_vector.h:1436) std::__cxx1998::vector<std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >, std::allocator<std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> > > >::clear() (stl_vector.h:1210) std::__debug::vector<std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >, std::allocator<std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> > > >::clear() (vector:690) ScRTFParser::ProcToken(RtfImportInfo*) (rtfparse.cxx:274) ScRTFParser::RTFImportHdl(RtfImportInfo&) (rtfparse.cxx:160) Change-Id: I36624a76ddb01f0d26d38f708af6b910384ad7fd Reviewed-on: https://gerrit.libreoffice.org/44225 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-03ofz: crash with empty aParserStatesCaolán McNamara
Change-Id: Ie3f327605ce795da30f915969177f21a7d38824c Reviewed-on: https://gerrit.libreoffice.org/44232 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-03tdf#111486 Fix component names in SAL_INFOsBartosz Kosiorek
Change-Id: I22a6747446d5571a883555db748ca3d40579cb13 Reviewed-on: https://gerrit.libreoffice.org/44222 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-11-03Fix comment markupSamuel Mehrbrodt
These do not appear on api.libreoffice.org if they arent marked up correctly Change-Id: I38873e1d763d97ff11e28b9ce5efe1cc68b12bf7 Reviewed-on: https://gerrit.libreoffice.org/44221 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-03Return new line symbol in unit testSerge Krot
For Win32 we cannot use directly "\n" symbol, instead SAL_NEWLINE_STRING should be used. Change-Id: Icf607fcc20086201fb34423f0a98d6817218bb0f Reviewed-on: https://gerrit.libreoffice.org/44207 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-03sw: clean up temporary debug code in itrform2Miklos Vajna
Change-Id: I817ea7abea99683f691b9fd363af7330ab975f87 Reviewed-on: https://gerrit.libreoffice.org/44234 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-03Enforce coding style with clang-format for new codeMiklos Vajna
- The actual blacklist has to be generated with solenv/clang-format/generate-style-blacklist.sh in a separate commit. - .clang-format is from <https://lists.freedesktop.org/archives/libreoffice/2014-August/062802.html>, except: - the commented out lines are removed - Standard is Cpp11 instead of Cpp03 - explicitly avoid sorting includes (requested during ESC meeting 2017-10-11) - no indentation inside namespaces (lots of existing code in sc wants this) - The git hooks prints a diff when the style is violated, along with a command to fix up the violation automatically. It also enforces style only in new files and ignores all files listed in the blacklist. - To avoid introducing one more hard-to-setup build dependency for new developers, help them two ways: - if clang-format is not installed, provide pre-built binaries for Linux/Windows/macOS - download/install of these binaries are printed as cmdline instructions, similar to how we have our own 'make' on Windows - As per ESC call 2017-11-02, currently don't do any checks if clang-format is not installed (as a first step). Change-Id: Iaa139c396337e8734aa1853305d808438260c41a Reviewed-on: https://gerrit.libreoffice.org/43736 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-03solenv: add list of existing C++ files for clang-format blacklist purposesMiklos Vajna
Generated with solenv/clang-format/generate-style-blacklist.sh from <https://gerrit.libreoffice.org/#/c/43736/>. Change-Id: I9ac621494450c42ef83e5cb7c1956124d17a8de6
2017-11-03xmlsecurity: can hold UriBindingHelper by rtl::ReferenceMiklos Vajna
... in XMLSignatureHelper and XSecController Change-Id: Ie3817684c9ed9ed8a222e3ba56c8fbc389a68071 Reviewed-on: https://gerrit.libreoffice.org/44193 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-03tdf#45904 Move Java _XSheetCellRange tests to C++Jens Carl
Change-Id: Ia4534f083a804d450ac8fdd31759f1554b684e15 Reviewed-on: https://gerrit.libreoffice.org/44245 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-03loplugin:includeform: document the requirementsMike Kaganski
See commits acb3ed0615a1b4e31257fa1014e9e2f2188c602c and 189abcf0db61c41a565bd355294bf6e712fc3e5a, and mail thread <https://lists.freedesktop.org/archives/libreoffice/2017-October/078601.html> Change-Id: I2eea0b0a13bfe7f2919f36c94e76796b6a8cf122 Reviewed-on: https://gerrit.libreoffice.org/43945 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-03Updated coreMike Kaganski
Project: help d25e28bb1ef1f0c07c263c48167135f4116eb730 Correct the explanation for STYLE spreadsheet function Change-Id: Ia0fedd0bc673f3090cf065ac578ef193d1d3b6b7 Reviewed-on: https://gerrit.libreoffice.org/44196 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-11-03Move ado_{pre,post}_sys_include.hStephan Bergmann
...to connectivity/source/inc/ado/, as it is included from include files there, which only happens to work because of -I$(dir $(3)) in gb_CObject__command_pattern (in solenv/gbuild/platform/com_MSC_class.mk) and the fact that those include files in connectivity/source/inc/ado/ are in turn only included from .cxx files in connectivity/source/drivers/ado/. Change-Id: I0bbecaeeaac1f94fa86355e391d2826f3e29c440 Reviewed-on: https://gerrit.libreoffice.org/44230 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-03-Werror,-Wsign-compare (clang-cl)Stephan Bergmann
Change-Id: I32f19344d73323482c140e3bd6db5eb3c3ccb8f7 Reviewed-on: https://gerrit.libreoffice.org/44229 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-03elementary icons: first update of the icon theme start with lc_andreas kainz
Change-Id: I6db076e67ca742c410899a2f6cbf9728bc16b92b Reviewed-on: https://gerrit.libreoffice.org/44219 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2017-11-03loplugin:constmethod in drawinglayerNoel Grandin
Change-Id: I6a33765f6589fc2941162eb2dcaa4e0a2d9e46e1 Reviewed-on: https://gerrit.libreoffice.org/44214 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-03improve debug printing of ErrCodeNoel Grandin
Change-Id: Ia6ebf2c43777774a91e27468272d713f0dadb1c3 Reviewed-on: https://gerrit.libreoffice.org/44204 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-03iOS include error in bridgesjan Iversen
Need to use "" for call.hxx include Change-Id: I9a30f3d3cfab83076f9ad22a5b637f8f4fc7c432
2017-11-03Replace list by vector in filtergrouping (sfx2)Julien Nabet
Change-Id: Ic5170843d8f47f92c7975cceaa9c33d278445b98 Reviewed-on: https://gerrit.libreoffice.org/43378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-03A first step to refactor ShapeList (sd)Julien Nabet
Change-Id: I5b036a9e2ba2b4c5eb784d7264adaa525fd4c08d Reviewed-on: https://gerrit.libreoffice.org/44156 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-03tdf#113597: Inserting table in header and saving crashesJulien Nabet
test xTextPortionEnumerationAccess before trying to use it bt: 0x00007fffca9201e6 in SwEditShell::CollectAdvancedClassification (this=this@entry=0x55555790c710) at /home/user/libreoffice/sw/source/core/edit/edfcol.cxx:804 804 uno::Reference<container::XEnumeration> xTextPortions = xTextPortionEnumerationAccess->createEnumeration(); 0 0x00007fffca9201e6 in SwEditShell::CollectAdvancedClassification() (this=this@entry=0x55555790c710) at /home/user/libreoffice/sw/source/core/edit/edfcol.cxx:804 1 0x00007fffca927e8c in SwEditShell::ClassifyDocPerHighestParagraphClass() (this=0x55555790c710) at /home/user/libreoffice/sw/source/core/edit/edfcol.cxx:1722 Regression from b480d5e4c03438487b645ae10347c5c22f36bb25 Change-Id: I255165ca2aa8e701fe011812165b32dd17e4e2ec Reviewed-on: https://gerrit.libreoffice.org/44240 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-03Replace some lists by vectors (vcl)Julien Nabet
Change-Id: Ic31f4f5a2f44e39ee965e7c3fc6a2246bbb10076 Reviewed-on: https://gerrit.libreoffice.org/44237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-03Replace lists by vector or deque in ucb/ucbhelperJulien Nabet
Change-Id: I9f72d7c8ab48f8dc2eec779db2f40531a33db6f9 Reviewed-on: https://gerrit.libreoffice.org/44238 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-03Replace remaining lists by deques (desktop)Julien Nabet
because of addToUnoRc and addToConfigmgrIni which use push_front (and no easy way to change this), I couldn't use vectors + use for range loops Change-Id: I15300122b449b3a5af7c6402a7ad4cd5a2000413 Reviewed-on: https://gerrit.libreoffice.org/44233 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-03vcl: remove sgf/sgv ancient gfx filtersThorsten Behrens
Change-Id: Ib02986e5b3d54d65982836e22ebcb70eb7a0e7b3 Reviewed-on: https://gerrit.libreoffice.org/44216 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-11-03tdf#45904 Move Java _XSheetCellRanges tests to C++Jens Carl
Change-Id: I6f6dcbc5368ce034c25553edf8b88c6669074243 Reviewed-on: https://gerrit.libreoffice.org/44194 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-03tdf#45904 Move Java _XSheetConditionalEntries test to C++Jens Carl
Change-Id: I96c1b0dc8d6c6b9cc4f8e02ef8c9ca184fb4d6a4 Reviewed-on: https://gerrit.libreoffice.org/44184 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-03tdf#45904 Move Java _XSheetConditionalEntry tests to C++Jens Carl
Change-Id: I51924e69183260ba0eba94c3a14bde252c24cc18 Reviewed-on: https://gerrit.libreoffice.org/44182 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-03tdf#45904 Move Java _XSheetCondition tests to C++Jens Carl
Change-Id: I013ccd0258a567ba69d624a02a4d4daab5c7f4fa Reviewed-on: https://gerrit.libreoffice.org/44181 Reviewed-by: Jens Carl <j.carl43@gmx.de> Tested-by: Jens Carl <j.carl43@gmx.de>
2017-11-03ofz#3577 TimeoutCaolán McNamara
Change-Id: I723552fe277a9a16c8a14c01f4701e1077ddfac3 Reviewed-on: https://gerrit.libreoffice.org/44223 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-03update creditsChristian Lohmaier
Change-Id: Icd33bbe415f321a82a52364aa93ba6cf4a28507f
2017-11-03Infinite loop in ooo32227-1.rtf with calc rtf filterCaolán McNamara
Change-Id: I068b205c844296379b5641356e4087b17f0a3535 Reviewed-on: https://gerrit.libreoffice.org/44218 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-02sw: ODF import: default as-char shapes to vertical-pos="top"Michael Stahl
The problem is that we don't render ShapesWithWrapping.odt the same as Word does: https://beta.opendocumentformat.org/rendercompare/upload/223/86/191/1 The first shape in the file is anchored "as-char" and has no style:vertical-rel or style:vertical-pos attribute affecting it. If Word would write either style:vertical-rel="baseline" or style:vertical-pos="top" explicitly, the rendering in LO would be the same. So the problem is that, for drawing shapes (note, text frames are images, embedded objects handled differently), LO's default vertical alignment is different, it is hard-coded in SwShapeDescriptor_Impl::GetVOrient() as SwFormatVertOrient(0, text::VertOrientation::NONE, text::RelOrientation::FRAME) This effectively positions as-char shapes *below* the baseline, which, while technically allowed, isn't really a good default. So fix this by making the default alignment dependent on the anchor type, so that as-char shapes sit on top of the baseline. The ODF filter sets the anchor type before inserting the shape in XMLTextShapeImportHelper::addShape(), however as it turns out the various MSO filters insert the shape before setting the anchor, which means the new default in SwXShape has an unwanted effect on them, as inserting the shape causes the default to be created. This requires changes to VML import to always set the VertOrient property, and to RTF import to set the anchor type before inserting. The DrawingML import is unaffected as it already sets VertOrient for every non-as-char shape. The testDmlTextshape "dml-textshape.docx" test still fails, but it turns out that the change in alignment for this test document is a bugfix, as it now has the same vertical alignment as in Word, so adapt the test. Change-Id: Ifcabd96a037515f7803f5474ec995f968b3b4de1
2017-11-02ofz#3858 use a single scratch bufferCaolán McNamara
Change-Id: Icdea835b89da2e7233e17893c759e411d659811c Reviewed-on: https://gerrit.libreoffice.org/44213 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-02revert drop of SetBufferSizeCaolán McNamara
reported spike in load time, so still necessary I guess Change-Id: I38c139b85ed922af18674ac84263150407a3277f Reviewed-on: https://gerrit.libreoffice.org/44231 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-02ofz#3927 ensure same sort order cross platformsCaolán McNamara
annoyingly was getting different order on oss-fuzz vs normal case making things hard to reproduce Change-Id: Ie50a546946b2dfa89bc3af1b4a04a88217c1a668 Reviewed-on: https://gerrit.libreoffice.org/44212 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-02iOS allow newest SDKjan Iversen
allow SDK 11.1 alongside 11.0 Change-Id: I0ad3c47ebccfac90fe7ae9101781c91a0fcd5fba
2017-11-02iOS, update to new xcodejan Iversen
Updated settings to new xcode Change-Id: I04eed7eaaf02dda69b4dbce7376b883478b78d27
2017-11-02iOS, remove bitcode from compilerjan Iversen
compiling with bitcode slows builds process Change-Id: Icee263652d31f3a7a6e92a91ef5320a804d0bef1
2017-11-02iOS activated full build for testjan Iversen
Removed compile of dummyLO, meaining full link is performed (to test LOkit_open) Removed faulty properties in property view scene Change-Id: I980cadaf98d40f3e497ee6aa69cb6166fa1b87f7
2017-11-02Divide-by-zeroCaolán McNamara
Change-Id: Ieb94b1ff71fb70f38d8bf8a1b9f62edbc3cfb867 Reviewed-on: https://gerrit.libreoffice.org/44198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-02Integer-overflowCaolán McNamara
Change-Id: Ic99219ff65cea0f316831696231ed6ba8dd10b60 Reviewed-on: https://gerrit.libreoffice.org/44199 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-02Unit test for CellStoreEvent::swap() in ScColumn::SwapCol(), tdf#111428Eike Rathke
Change-Id: Iaba95e2cfb6b34ab3ad04f96dd2c8e2c12115d95
2017-11-02Begin sentence with uppercase letterSamuel Mehrbrodt
Change-Id: I32056d860dfb6dd5683d13de86705c3d70f51d46 Reviewed-on: https://gerrit.libreoffice.org/44215 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-02static_cast followed by dynamic_castCaolán McNamara
Change-Id: I722ba0ab1e056904c55b4ad6cdec6f26fa3b723d
2017-11-02Winreg configuration layer: don't assert on user inputMike Kaganski
Change-Id: I1314e37315450ead3bf131ed3fabd9351a88a4e5 Reviewed-on: https://gerrit.libreoffice.org/44191 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-02ofz#3886 Integer-overflowCaolán McNamara
Change-Id: I936f681b835cca62fc14a326b7ae5cb062b3f1df Reviewed-on: https://gerrit.libreoffice.org/44197 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-02writer notebookbar update tabbed compact toolbarandreas kainz
Change-Id: Id7be2fdd497b3c49005c50d4e990b0dd44e86d12 Reviewed-on: https://gerrit.libreoffice.org/44192 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2017-11-02Use gb_UnpackedTarball_get_dirStephan Bergmann
Change-Id: I931f0d95cad0a63d344c84d89ba7c80f14be8ec9
2017-11-02Avoid warning thrashStephan Bergmann
...between "error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]" (in some builds, for the original code) and "error: fallthrough annotation in unreachable code [-Werror,-Wimplicit-fallthrough]" (in other builds, after adding SAL_FALLTHROUGH). Change-Id: I75bbefd69c81f43f22117f8ad110237de24e18af
generated by cgit (git 2.34.1) at 2025-01-16 18:01:10 +0000