summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-04-06tdf#124579: ensure to provide an event to wake up main loop when notifyingMike Kaganski
Without that, Request::waitProcessMessages might wait indefinitely for Application::Yield() to return; while the latter would wait for a message in GetMessage. If there's no visible LO window, the message might never arrive by itself. Co-authored-by: Jan-Marek Glogowski <glogow@fbihome.de> Change-Id: Ie2622053a8d4467eb1cbd579d8496cb5ddef08aa Reviewed-on: https://gerrit.libreoffice.org/70346 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-06weld OTableSubscriptionPageCaolán McNamara
Change-Id: I55c23448480384c9a7d78cd55550bb4812ebde72 Reviewed-on: https://gerrit.libreoffice.org/70314 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-06clang-tidy modernize-avoid-c-arrays in animationsArkadiy Illarionov
Change-Id: I3dc1c0e63bd90735c20a65b1af25b243e5a5eee5 Reviewed-on: https://gerrit.libreoffice.org/70341 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-06respect read-only config item: MSCompatibleFormsMenuTamás Zolnai
Change-Id: I4eacbe8ad2025a54c13f4c0fa06e30e5ab59b721 Reviewed-on: https://gerrit.libreoffice.org/70344 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-04-06ofz#14093 bunch of new ofz detected crashes related to tdf#50916Caolán McNamara
since... commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic. Change-Id: I7588e34a9a52cde0d38dd9c1f15e6bbdb3601241 Reviewed-on: https://gerrit.libreoffice.org/70345 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-06crashtesting, threading crash with bitmapinfoaccess_null_ptr_deref.sampleCaolán McNamara
on export to .ods Thread 1: 5 0x00007f758fde4969 in raise () from /lib64/libc.so.6 6 0x00007f758fde5f98 in abort () from /lib64/libc.so.6 7 0x00007f758f485afd in __gnu_debug::_Error_formatter::_M_error ( this=0x7f7588872860 <__gnu_debug::_Error_formatter::_M_at(char const*, unsigned int)::__formatter>) at ../../../.././libstdc++-v3/src/c++11/debug.cc:1069 8 0x00007f7587b42922 in __gnu_debug::_Safe_iterator<std::__detail::_Node_iterator<ImpGraphic*, true, false>, std::__debug::unordered_set<ImpGraphic*, std::hash<ImpGraphic*>, std::equal_to<ImpGraphic*>, std::allocator<ImpGraphic*> > >::operator++ ( this=0x7f755a58e440) at /srv/crashtestdata/gccbuild/gcc8/include/c++/8.2.0/debug/safe_iterator.h:295 9 0x00007f7587b415d5 in vcl::graphic::Manager::registerGraphic (this=0x5fe9860, pImpGraphic=std::shared_ptr<ImpGraphic> (use count 1, weak count 0) = {...}) at /home/buildslave/source/libo-core/vcl/source/graphic/Manager.cxx:123 10 0x00007f7587b418e2 in vcl::graphic::Manager::newInstance (this=0x5fe9860) at /home/buildslave/source/libo-core/vcl/source/graphic/Manager.cxx:156 11 0x00007f758798c406 in Graphic::Graphic (this=0x7f755a58e6d0) at /home/buildslave/source/libo-core/vcl/source/gdi/graph.cxx:187 12 0x00007f758799c85a in ImpGraphic::loadPrepared (this=0x80d2500) at /home/buildslave/source/libo-core/vcl/source/gdi/impgraph.cxx:1540 13 0x00007f758799c999 in ImpGraphic::ImplSwapIn (this=0x80d2500) at /home/buildslave/source/libo-core/vcl/source/gdi/impgraph.cxx:1561 14 0x00007f758799c813 in ImpGraphic::ensureAvailable (this=0x80d2500) and a bunch of other threads looking like they've just come from the same family of methods Change-Id: Ic13d3c7cb2fb4adaa2a0a6b8845fc2156d53005e Reviewed-on: https://gerrit.libreoffice.org/70271 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-06Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Add info on convert-to filter names command line --convert-to option miss description of the internal names of the filters. The xhp file is generated by the python script based on the filter xcd's. P2: fix typo, Fix <filename>, Put modules in upercase. P3: reduce L10n workload with <embedvar> P4: Make xmllint happy again Change-Id: I455491b1f6a141688308d768b2822f051566ae53 Reviewed-on: https://gerrit.libreoffice.org/70273 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-04-06Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Create XSLT replacement table for missing icons Missing UI icons have a replacement table in /core/icon-themes/colibre/links.txt Help must also use this replacement table when Help pages have missing icons. The previous approach was a manual creation of a XSLT for the replacement. The patch moves the replacement table creation inside the Custom makefile, making it automatic and carrying changes of the original links.txt source. Change-Id: I7f834fa03bbd85f329efbec43e5c51cc86d51586 Reviewed-on: https://gerrit.libreoffice.org/70080 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-04-06Fix typoAndrea Gelmini
Change-Id: I9904cf43548fc04e339b1592280efc326a0f6ad1 Reviewed-on: https://gerrit.libreoffice.org/70330 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-06Fix typoAndrea Gelmini
Change-Id: I7fa59ba667a35b4f2fbfa284cf5257218428259a Reviewed-on: https://gerrit.libreoffice.org/70331 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-06Fix typoAndrea Gelmini
Change-Id: I2d5b20bdc5c87edce37930b5acced910fe1aec70 Reviewed-on: https://gerrit.libreoffice.org/70332 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-06Fix typoAndrea Gelmini
Change-Id: Iecec6056db7809cc786c21f4bbfa64db9f437200 Reviewed-on: https://gerrit.libreoffice.org/70333 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-06Fix typoAndrea Gelmini
Change-Id: I4d1f652759ca65f15894c290ea5e77fb206701cb Reviewed-on: https://gerrit.libreoffice.org/70334 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-06Follow 4a4b1df72909fe96acdbcb95f90e30bd1a79c5ebJulien Nabet
Change-Id: I46d62ec8b7f5347fe7a69e6eb7ac0f1affcfd5b8 Reviewed-on: https://gerrit.libreoffice.org/70342 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2019-04-06SwXTextField::Impl FieldTypeClient: SwClient no moreBjoern Michaelsen
Change-Id: I745ebae5a58df9b3a7dcb96448099f6803b7b1a2 Reviewed-on: https://gerrit.libreoffice.org/70326 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-04-06Fix 6a9cf9ba2d37fee9b7c2f190b347e0d7c4a2676aJulien Nabet
Change-Id: If025c21f3961372f861c8bb9df722fbdae5cc3cb Reviewed-on: https://gerrit.libreoffice.org/70339 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-06tdf#91634 XLSX export: fix hyperlink inserted to imagetundet
Hyperlink inserted to image lost after export. image_hyperlink.xlsx: Test file from Excel. Change-Id: I8dc47528dafc8de5d1e01720697ef57f0ad9628d Reviewed-on: https://gerrit.libreoffice.org/70248 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-04-06tdf#119931 Fix accessibility warnings in chinesedictionary.uiRasmus Jonsson
Change-Id: I144b0530d5eb029fac4fad458373da4474974876 Reviewed-on: https://gerrit.libreoffice.org/70336 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-04-06tdf#119931 Fix accessibility warnings in printerpaperpage.uiRasmus Jonsson
Change-Id: If92bf6ac4c466524da2eab33440bf765b3d5d6f6 Reviewed-on: https://gerrit.libreoffice.org/70335 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-04-05tdf#124326 : ScUndoDragDrop : don't do update references...Dennis Francis
on undo, as all affected formula-cells are preserved in original form in the undo document. This is ensured by the drag-drop move-block code (ScDocFunc::MoveBlock) which in-turn calls ScDocument::UpdateReference, which records all original formula-cells to the undo-document. Anyway the sc::RefMovedHint object created in ScUndoDragDrop::Undo is wrong, as it operates on original data-range(aCxt.maRange = aSrcRange) which is interpreted as "old data-range" in the context of undo-move operation. Change-Id: Ic48cc3fa51fdb17e9338f65ac95b8e8d30c2c92c Reviewed-on: https://gerrit.libreoffice.org/70315 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-04-05sc hash functions, use 64-bit range when availableNoel Grandin
Change-Id: If4d5b302343991122290ae64ec62b6f0bcfa97a3 Reviewed-on: https://gerrit.libreoffice.org/70305 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-04-05Replace legacy dynamically-loaded functions with statically linked onesMike Kaganski
We don't need the dynamic load complexity for these now with baseline Windows version being Windows 7 SP1. Stuff used only for compatibility with older versions was dumped. Change-Id: I810f271796cfd875cfa18a3081c9ad444fe57b3e Reviewed-on: https://gerrit.libreoffice.org/70321 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-05android: fix ArrayIndexOutOfBounds on selecting 'Drawings' in ↵kaishu-sahu
DefaultFileFilter setting Change-Id: I5ed924d9d79db169b11a0561b89da9b57eb078d9 Reviewed-on: https://gerrit.libreoffice.org/66971 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-04-05android: Setting default values to setting preference, minor ux improvementskaishu-sahu
Change-Id: I356871429f2e26d9d34e0e1428334a4d2287b683 Reviewed-on: https://gerrit.libreoffice.org/67295 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-04-05tdf#123502: Make sure to hold the mutex before releasing itMike Kaganski
Fixes a regression after commit 5b2f1243bd44b450da26c8344b3ee459f8e88f6c The destruction of the dialog is initiated by a callback executed from VCLXButton::ProcessWindowEvent, which notifies listeners, using a call to VCLXWindow::ImplExecuteAsyncWithoutSolarLock. The stack looks like this: ucrtbased.dll!issue_debug_notification(const wchar_t * const message) Line 28 at minkernel\crts\ucrt\src\appcrt\internal\report_runtime_error.cpp(28) ucrtbased.dll!__acrt_report_runtime_error(const wchar_t * message) Line 154 at minkernel\crts\ucrt\src\appcrt\internal\report_runtime_error.cpp(154) ucrtbased.dll!abort() Line 51 at minkernel\crts\ucrt\src\appcrt\startup\abort.cpp(51) comphelper.dll!comphelper::SolarMutex::doRelease(bool bUnlockAll) Line 65 at c:\lo\src\core2\comphelper\source\misc\solarmutex.cxx(65) vclplug_winlo.dll!SalYieldMutex::doRelease(bool bUnlockAll) Line 169 at c:\lo\src\core2\vcl\win\app\salinst.cxx(169) comphelper.dll!comphelper::SolarMutex::release(bool bUnlockAll) Line 89 at c:\lo\src\core2\include\comphelper\solarmutex.hxx(89) vcllo.dll!SalInstance::ReleaseYieldMutexAll() Line 114 at c:\lo\src\core2\vcl\source\app\salvtables.cxx(114) vcllo.dll!Application::ReleaseSolarMutex() Line 548 at c:\lo\src\core2\vcl\source\app\svapp.cxx(548) fps.dll!SolarMutexReleaser::SolarMutexReleaser() Line 1479 at c:\lo\src\core2\include\vcl\svapp.hxx(1479) fps.dll!fpicker::win32::vista::AsyncRequests::~AsyncRequests() Line 84 at c:\lo\src\core2\fpicker\source\win32\asyncrequests.cxx(84) fps.dll!fpicker::win32::vista::VistaFilePicker::~VistaFilePicker() Line 72 at c:\lo\src\core2\fpicker\source\win32\vistafilepicker.cxx(72) fps.dll!fpicker::win32::vista::VistaFilePicker::`scalar deleting destructor'(unsigned int) cppuhelper3MSC.dll!cppu::OWeakObject::release() Line 233 at c:\lo\src\core2\cppuhelper\source\weak.cxx(233) cppuhelper3MSC.dll!cppu::WeakComponentImplHelperBase::release() Line 84 at c:\lo\src\core2\cppuhelper\source\implbase.cxx(84) fps.dll!cppu::PartialWeakComponentImplHelper<com::sun::star::ui::dialogs::XFilePicker3,com::sun::star::ui::dialogs::XFilePickerControlAccess,com::sun::star::ui::dialogs::XFilePreview,com::sun::star::ui::dialogs::XFolderPicker2,com::sun::star::lang::XInitialization,com::sun::star::lang::XServiceInfo>::release() Line 86 at c:\lo\src\core2\include\cppuhelper\compbase.hxx(86) invocationlo.dll!com::sun::star::uno::cpp_release(void * pCppI) Line 48 at c:\lo\src\core2\include\com\sun\star\uno\genfunc.hxx(48) cppu3.dll!cppu::_release(void * p, void(*)(void *) release) Line 86 at c:\lo\src\core2\cppu\source\uno\prim.hxx(86) cppu3.dll!cppu::_destructAny(_uno_Any * pAny, void(*)(void *) release) Line 130 at c:\lo\src\core2\cppu\source\uno\destr.hxx(130) cppu3.dll!uno_any_destruct(_uno_Any * pValue, void(*)(void *) release) Line 131 at c:\lo\src\core2\cppu\source\uno\any.cxx(131) invocationlo.dll!com::sun::star::uno::Any::~Any() Line 111 at c:\lo\src\core2\include\com\sun\star\uno\any.hxx(111) invocationlo.dll!stoc_inv::Invocation_Impl::~Invocation_Impl() invocationlo.dll!stoc_inv::Invocation_Impl::`scalar deleting destructor'(unsigned int) cppuhelper3MSC.dll!cppu::OWeakObject::release() Line 233 at c:\lo\src\core2\cppuhelper\source\weak.cxx(233) invocationlo.dll!stoc_inv::Invocation_Impl::release() Line 110 at c:\lo\src\core2\stoc\source\invocation\invocation.cxx(110) pyuno_d.pyd!com::sun::star::uno::Reference<com::sun::star::script::XInvocation2>::~Reference<com::sun::star::script::XInvocation2>() Line 110 at c:\lo\src\core2\include\com\sun\star\uno\reference.hxx(110) pyuno_d.pyd!pyuno::PyUNOInternals::~PyUNOInternals() pyuno_d.pyd!pyuno::PyUNOInternals::`scalar deleting destructor'(unsigned int) pyuno_d.pyd!pyuno::PyUNO_del(_object * self) Line 81 at c:\lo\src\core2\pyuno\source\module\pyuno.cxx(81) python35_d.dll!_Py_Dealloc(_object * op) Line 1795 at c:\lo\src\core2\workdir\unpackedtarball\python3\objects\object.c(1795) python35_d.dll!dict_dealloc(PyDictObject * mp) Line 1646 at c:\lo\src\core2\workdir\unpackedtarball\python3\objects\dictobject.c(1646) python35_d.dll!_Py_Dealloc(_object * op) Line 1795 at c:\lo\src\core2\workdir\unpackedtarball\python3\objects\object.c(1795) python35_d.dll!subtype_dealloc(_object * self) Line 1194 at c:\lo\src\core2\workdir\unpackedtarball\python3\objects\typeobject.c(1194) python35_d.dll!_Py_Dealloc(_object * op) Line 1795 at c:\lo\src\core2\workdir\unpackedtarball\python3\objects\object.c(1795) python35_d.dll!frame_dealloc(_frame * f) Line 431 at c:\lo\src\core2\workdir\unpackedtarball\python3\objects\frameobject.c(431) python35_d.dll!_Py_Dealloc(_object * op) Line 1795 at c:\lo\src\core2\workdir\unpackedtarball\python3\objects\object.c(1795) python35_d.dll!fast_function(_object * func, _object * * * pp_stack, int n, int na, int nk) Line 4858 at c:\lo\src\core2\workdir\unpackedtarball\python3\python\ceval.c(4858) python35_d.dll!call_function(_object * * * pp_stack, int oparg) Line 4783 at c:\lo\src\core2\workdir\unpackedtarball\python3\python\ceval.c(4783) python35_d.dll!PyEval_EvalFrameEx(_frame * f, int throwflag) Line 3291 at c:\lo\src\core2\workdir\unpackedtarball\python3\python\ceval.c(3291) python35_d.dll!_PyEval_EvalCodeWithName(_object * _co, _object * globals, _object * locals, _object * * args, int argcount, _object * * kws, int kwcount, _object * * defs, int defcount, _object * kwdefs, _object * closure, _object * name, _object * qualname) Line 4080 at c:\lo\src\core2\workdir\unpackedtarball\python3\python\ceval.c(4080) python35_d.dll!PyEval_EvalCodeEx(_object * _co, _object * globals, _object * locals, _object * * args, int argcount, _object * * kws, int kwcount, _object * * defs, int defcount, _object * kwdefs, _object * closure) Line 4092 at c:\lo\src\core2\workdir\unpackedtarball\python3\python\ceval.c(4092) python35_d.dll!function_call(_object * func, _object * arg, _object * kw) Line 627 at c:\lo\src\core2\workdir\unpackedtarball\python3\objects\funcobject.c(627) python35_d.dll!PyObject_Call(_object * func, _object * arg, _object * kw) Line 2166 at c:\lo\src\core2\workdir\unpackedtarball\python3\objects\abstract.c(2166) python35_d.dll!method_call(_object * func, _object * arg, _object * kw) Line 330 at c:\lo\src\core2\workdir\unpackedtarball\python3\objects\classobject.c(330) python35_d.dll!PyObject_Call(_object * func, _object * arg, _object * kw) Line 2166 at c:\lo\src\core2\workdir\unpackedtarball\python3\objects\abstract.c(2166) python35_d.dll!PyEval_CallObjectWithKeywords(_object * func, _object * arg, _object * kw) Line 4634 at c:\lo\src\core2\workdir\unpackedtarball\python3\python\ceval.c(4634) python35_d.dll!PyObject_CallObject(_object * o, _object * a) Line 2092 at c:\lo\src\core2\workdir\unpackedtarball\python3\objects\abstract.c(2092) pyuno_d.pyd!pyuno::Adapter::invoke(const rtl::OUString & aFunctionName, const com::sun::star::uno::Sequence<com::sun::star::uno::Any> & aParams, com::sun::star::uno::Sequence<short> & aOutParamIndex, com::sun::star::uno::Sequence<com::sun::star::uno::Any> & aOutParam) Line 251 at c:\lo\src\core2\pyuno\source\module\pyuno_adapter.cxx(251) msci_uno.dll!`anonymous namespace'::callVirtualMethod(void * pAdjustedThisPtr, long nVtableIndex, void * pRegisterReturn, _typelib_TypeClass eReturnTypeClass, long * pStackLongs, long nStackLongs) Line 74 at c:\lo\src\core2\bridges\source\cpp_uno\msvc_win32_intel\uno2cpp.cxx(74) msci_uno.dll!`anonymous namespace'::cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy * pThis, bridges::cpp_uno::shared::VtableSlot aVtableSlot, _typelib_TypeDescriptionReference * pReturnTypeRef, long nParams, _typelib_MethodParameter * pParams, void * pUnoReturn, void * * pUnoArgs, _uno_Any * * ppUnoExc) Line 249 at c:\lo\src\core2\bridges\source\cpp_uno\msvc_win32_intel\uno2cpp.cxx(249) msci_uno.dll!unoInterfaceProxyDispatch(_uno_Interface * pUnoI, const _typelib_TypeDescription * pMemberDescr, void * pReturn, void * * pArgs, _uno_Any * * ppException) Line 430 at c:\lo\src\core2\bridges\source\cpp_uno\msvc_win32_intel\uno2cpp.cxx(430) invocadaptlo.dll!stoc_invadp::AdapterImpl::invoke(const _typelib_TypeDescription * pMemberType, void * pReturn, void * * pArgs, _uno_Any * * ppException) Line 467 at c:\lo\src\core2\stoc\source\invocation_adapterfactory\iafactory.cxx(467) invocadaptlo.dll!adapter_dispatch(_uno_Interface * pUnoI, const _typelib_TypeDescription * pMemberType, void * pReturn, void * * pArgs, _uno_Any * * ppException) Line 617 at c:\lo\src\core2\stoc\source\invocation_adapterfactory\iafactory.cxx(617) msci_uno.dll!`anonymous namespace'::cpp2uno_call(bridges::cpp_uno::shared::CppInterfaceProxy * pThis, const _typelib_TypeDescription * pMemberTypeDescr, _typelib_TypeDescriptionReference * pReturnTypeRef, long nParams, _typelib_MethodParameter * pParams, void * * pCallStack, __int64 * pRegisterReturn) Line 155 at c:\lo\src\core2\bridges\source\cpp_uno\msvc_win32_intel\cpp2uno.cxx(155) msci_uno.dll!`anonymous namespace'::cpp_mediate(void * * pCallStack, long nFunctionIndex, long nVtableOffset, __int64 * pRegisterReturn) Line 345 at c:\lo\src\core2\bridges\source\cpp_uno\msvc_win32_intel\cpp2uno.cxx(345) msci_uno.dll!`anonymous namespace'::cpp_vtable_call() Line 380 at c:\lo\src\core2\bridges\source\cpp_uno\msvc_win32_intel\cpp2uno.cxx(380) tklo.dll!ActionListenerMultiplexer::actionPerformed(const com::sun::star::awt::ActionEvent & evt) Line 146 at c:\lo\src\core2\toolkit\source\helper\listenermultiplexer.cxx(146) tklo.dll!ActionListenerMultiplexer::actionPerformed(const com::sun::star::awt::ActionEvent & evt) Line 146 at c:\lo\src\core2\toolkit\source\helper\listenermultiplexer.cxx(146) tklo.dll!VCLXButton::ProcessWindowEvent::__l8::<lambda>() Line 593 at c:\lo\src\core2\toolkit\source\awt\vclxwindows.cxx(593) tklo.dll!std::_Invoker_functor::_Call<void <lambda>(void) &>(VCLXButton::ProcessWindowEvent::__l8::void <lambda>(void) & _Obj) tklo.dll!std::invoke<void <lambda>(void) &>(VCLXButton::ProcessWindowEvent::__l8::void <lambda>(void) & _Obj) tklo.dll!std::_Invoker_ret<void,1>::_Call<void <lambda>(void) &>(VCLXButton::ProcessWindowEvent::__l8::void <lambda>(void) & <_Vals_0>) tklo.dll!std::_Func_impl_no_alloc<void <lambda>(void),void>::_Do_call() tklo.dll!std::_Func_class<void>::operator()() tklo.dll!VCLXWindowImpl::OnProcessCallbacks(void * __formal) Line 300 at c:\lo\src\core2\toolkit\source\awt\vclxwindow.cxx(300) ... So it seems like the only place where we could guarantee the invariant to hold solar mutex for GUI protection before releasing it is right before the releaser itself. Co-authored-by: Jan-Marek Glogowski <glogow@fbihome.de> Change-Id: Ie95bd3423a25f210f0bbb2a88288c7c60a528ea0 Reviewed-on: https://gerrit.libreoffice.org/70301 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-05tdf#124360: The cui component is needed in the iOS appTor Lillqvist
Used at least in the Edit > Edit Style... > Area > Color dialog for the Pick button.. Change-Id: I864ec5918482a2f8ee5c5d80b79eacd6e8fcd88e
2019-04-05tdf#119693 base incorrect icon was showandreas kainz
Change-Id: I2e7380dcf2af1a51c837a798a20de03d50eb7065 Reviewed-on: https://gerrit.libreoffice.org/70304 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-05Revert "Get rid of b2u/u2b helpers; use OUString's toUtf8/fromUtf8 instead"Mike Kaganski
This reverts commit 84662e9030a855c8db7cd40d9ce354b773d78c16. Change-Id: I1cc98d3201390609ae3615baa8e92c926cdcde9a Reviewed-on: https://gerrit.libreoffice.org/70294 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-05tdf#124287 wrong tooltip at Field command in NBandreas kainz
Change-Id: I49e3a53db5137b62063f2664c945e256ced33856 Reviewed-on: https://gerrit.libreoffice.org/70300 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-05tdf#124198 sd modules move imagemap to toolsandreas kainz
Change-Id: I6d582032d419b832aa2610cad61d9c5596fcc9a4 Reviewed-on: https://gerrit.libreoffice.org/70299 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-05FIX: DOCX export: use all updated attributes during table exportPatrick Jaap
In a previous commit only x/y coordinate were considered. For better overview make use of the OOXML converter for orients and relations. Change-Id: I9792ccfbc2ebb58fd768c14278cdfd9b54efe62f Reviewed-on: https://gerrit.libreoffice.org/69523 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-05tdf#124392 remove undo/redo commands from groupedbar drop downandreas kainz
Change-Id: I7224eaf1b569d018a85fee6a65afe43d0d37bfbc Reviewed-on: https://gerrit.libreoffice.org/70298 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-05fix spinbox right press SVG - plus sign didn't define a colorTomaž Vajngerl
Change-Id: I1db6c5e4841530be7d46e8829899bf3f8cef8a3b Reviewed-on: https://gerrit.libreoffice.org/70293 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-05support opacity for widget definition draw SVGsTomaž Vajngerl
This opacity influences the whole shape (stroke and fill). Change-Id: I82e10e07dbf2f321805b55a5f4831a513e52dab8 Reviewed-on: https://gerrit.libreoffice.org/70292 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-05menubar add separator between different zoom itemsandreas kainz
Change-Id: Ie6a9ef6441b2b0053ea539bc0f1846fba8422313 Reviewed-on: https://gerrit.libreoffice.org/70297 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-05sw: extract UITest_sw_findSimilarity from UITest_sw_findReplaceMiklos Vajna
I'm not exactly sure how, but in case sw/qa/uitest/findReplace/findSimilarity.py and sw/qa/uitest/findReplace/findReplace.py are in the same suite, then 3 tests from the later fail for me. I don't see anything obviously problematic in either of these tests, so just split them to separate suites, these are slow tests after all, so more parallelism is good anyway. (What may happen is that one of the dialogs remember its state in the user profile, but then why this doesn't happen for everyone is unclear.) Change-Id: If11f5b171972422fab5f79a047b1aabb1adee04d Reviewed-on: https://gerrit.libreoffice.org/70296 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2019-04-05tdf#50916 Makes numbers of columns dynamic.Noel Grandin
With this commit we are making numbers of columns dynamic, but the number of maximum supported columns will be the same (1024). Such approach will allow us to check issues (eg. performance, LO format etc.), and improve it. Increasing number of maximum columns, will be done in separate commit. Change-Id: Ibac4101e9ffc05e3548eca1c198f6319ac7ff9aa Reviewed-on: https://gerrit.libreoffice.org/44802 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2019-04-05lo-commit-stat: Only search for bug ids in the summaryXisco Fauli
Sometimes, developers mention other bugs in the body as related issues. This might create mislead information in the release notes E.g: https://wiki.documentfoundation.org/Releases/6.1.1/RC1 * Caolán is mentioned as fixer of i#66963 because the id is in the body of 9c3d8b1c64c2ce5a2fd39aa785df45f6b1d6628b which fixes tdf#98558 * M. Stahl is mentioned as fixer of tdf#112447 because the id is in the body of 31e66bd07c1082bb375be8aaf7835f019351d9bb This bug was fixed by Bjoern Michaelsen in ce2fce9a41729774689080c8b5552b60c2e6ee2d Change-Id: I8d0ee038741dbb27364a56a7fa9285f32839c37b Reviewed-on: https://gerrit.libreoffice.org/69750 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-04-05menubar: reverte recentfilelist change to have it after openremoteandreas kainz
Change-Id: I775e9d6d6bedbfe00a4e5349cf0a664ccbd0ecc4 Reviewed-on: https://gerrit.libreoffice.org/70288 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-05tdf#118269 Replace InsertAnnotation commands accel for Hungarian onlyGabor Kelemen
So that Insert - Comment command would not insert an & on Windows with Hungarian keyboard layout Change-Id: I83f43cdc0b3f32e284cd747648de5bcb07505314 Reviewed-on: https://gerrit.libreoffice.org/70279 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-04-05Remove stale accelerator for uno:AnimationModeGabor Kelemen
Corresponding command was removed in b94abbc8fd83e2ac5c7d95a8a4f03da6bc15facd (2004!) This and 15bdac207302fb54155310b0cc7fdb7283e612ed is why this accelerator showed up as uno:AnimationMode in the list instead of a human readable name Change-Id: I7b2f2cf76c75d815b85b1ceb6e8468588e3d15f1 Reviewed-on: https://gerrit.libreoffice.org/70268 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-04-05Remove stale accelerators for uno:StyleCatalogGabor Kelemen
The uno:StyleCatalog command was removed in b4c18dc0ea32af9f070d43278e547ee0b2e540a4 Change-Id: I31118e97c5445b1021ea60b2629f12d2f60595cd Reviewed-on: https://gerrit.libreoffice.org/70267 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-04-05sc menubar: rearrange subgroup items to have > items last sortedandreas kainz
Change-Id: Ie46fcc58039ce9686b779d27699e4988e93e8bd7 Reviewed-on: https://gerrit.libreoffice.org/70195 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-05tdf#112318 sd opengl: fix lack of initial animationMiklos Vajna
Commit 881043d1f01fad663c0a17f11cbe2dab79e31217 (#i98792# Allow frequent calls to slide show update()., 2009-04-27) added a comment in sd::SlideshowImpl::updateSlideShow() talking about an "above" case, when the slideshow update suggests to not wait till the next update, but later commit 12dcf5e6e770b1933252a1f919663ba45ded4cdf (slideshow: cleanup main-loop usage, post-yield listeners, etc., 2015-11-13) removed that handling. That was fine till opengl rendering was introduced, which swaps its backbuffer in an idle handler. Given that OpenGLFlushIdle's priority is TaskPriority::POST_PAINT and SlideshowImpl::maUpdateTimer's priority is TaskPriority::REPAINT, the GL backbuffer is not always painted while an animation is ongoing. This is more visible when tweaking the bugdoc to have an e.g. 5 sec animation, then starting the slideshow results in waiting for 5 seconds and only then the slide shows up, without an animation. Fix the problem by re-introducing the handling of the fUpdate == 0, and processing idle events there, which means the GL backbuffer will be always painted, regardless if fUpdate is a small number or 0. Change-Id: I25b2dc0aa41af62d9bd89617178eb2e9997f5b17 Reviewed-on: https://gerrit.libreoffice.org/70287 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-04-05tdf#42949 Fix IWYU warnings in include/sfx2/sidebar/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ic2bd25bcbcc7f5fb6e29ced70fddb74385b5fb2f Reviewed-on: https://gerrit.libreoffice.org/70077 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-05Fix typoAndrea Gelmini
Change-Id: I49ffb2fff63a8818c4e84a26923fca1484bf1e36 Reviewed-on: https://gerrit.libreoffice.org/70284 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-05Related: tdf#116098 avoid ctrl-shift-e shortcut in more placesGabor Kelemen
These were originally added in commit 4105862b03b78ff5d80d5e1f5a48f15015f79d3c Avoid the reported problem for the other two instances (Calc and Master document) too Change-Id: Ief3adafec1f05f9fb881da76c844fe8525143029 Reviewed-on: https://gerrit.libreoffice.org/70272 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-05Remove unused using declarations in directories [e-l]*Gabor Kelemen
Found by: run-clang-tidy-7 -checks=-*,misc-unused-using-decls Change-Id: Iee4e9df37d4c971ea97256d041afbc3d3aaa3d27 Reviewed-on: https://gerrit.libreoffice.org/70027 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-05sw btlr writing mode: implement RTF exportMiklos Vajna
Note that we can't work with the table box (and frame format) of pTableTextNodeInfoInner in RtfAttributeOutput::TableVerticalCell(). This is because cell definitions are written in RtfAttributeOutput::TableDefinition(), and the loop only calls setCell(), i.e. the cell index is updated in the node info, but the table box is not. Import was already working as-is. Change-Id: Ia089c42b3a49f1a8f012a8cadaa8bcad16128c3e Reviewed-on: https://gerrit.libreoffice.org/70269 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-05tdf#120703: partially revert commit 85456fae54029edd26df2277a9eec5e2fe3d9739Mike Kaganski
... to take into account possible differences of results of dynamic_cast vs static_cast; the change casts dynamically, as before the commit, and only adds asserts on the result of the cast. Thanks to sberg for pointing my mistake out! Change-Id: Ib77d443e5a858e744f369f58542de603f948fd1c Reviewed-on: https://gerrit.libreoffice.org/70274 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-19 18:58:37 +0000