summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-08-16backendtest: Asymmetrical Filled Drop Like Shape testhomeboy445
Change-Id: Iacf121483aefa71d6f24e14782fcaf22c0d5d56e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118859 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-16Revert "tdf#143114 Avoid StartDrag on TreeListBox when CaptureOnButton"Julien Nabet
This reverts commit ca7dab5d96e73b7b4b045e2460e0b2ee150757db. It created tdf#143749 + the dup tdf#143865 Change-Id: Ibd68c45213491b0df7dc36f0418de307412499c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120531 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-08-16ofz: log with date -uCaolán McNamara
Change-Id: I9e85ee0f98c3b7cfab15db5e93f65a053996bf00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120534 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-16ofz: use system curl .a and system glm headersCaolán McNamara
Change-Id: Idf4aa5f8d76afb3f0842830c2c874a10241ecc3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120528 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-16pass OutlinerParaObject around by valueNoel Grandin
since it uses o3tl::cow_wrapper, so it is really just a wrapper around a pointer, no point in allocating it on the heap Remove assert in SdrText::SetOutlinerParaObject, which was bogus anyhow, because it was comparing pointers, not deep equality. And since we are now being more efficient and avoiding copying of the internal data in OutlinerParaObject, we hit this assert. Change-Id: I6dbfaab5ee2ca05b2001baf63110041e469df9c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120510 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-16Use o3tl::toTwips to define MINBODYMike Kaganski
This changes its value from 56 to the proper 57. See 9be17c52b7c565758088b8020a543d7b840e31a7, which had changed the previous 5-mm value to the incorrectly rounded 1-mm value; and cefce1a247a4674c5726a31b61571eab16328a0b, which had unified the other places mentioning i19922. Change-Id: I7186320b4c1a2a65a6f728ed8bafcbf0eb45c4cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120441 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-16LOK: freemium: added new parameter in the APIPranam Lashkari
Added new parameter in the freemium API to make it consistent with other APIs Change-Id: Ieb73fd1f97e1886051b1de44a93ba87622862e2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119974 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120484 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2021-08-16sfx2: fix uninitialized SfxViewShell::mbLOKIsFreemiumViewMiklos Vajna
Introduced in commit 1b9fe58acb7b5bbbc83ecca30e17663fff7f0db4 (LOK: introduced Freemium LOK API, 2021-06-02). Change-Id: Ifdd6c13a64a167fa00b0305441c52340167f3809 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118632 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120483 Tested-by: Jenkins
2021-08-16LOK: introduced Freemium LOK APIPranam Lashkari
also block the uno commands from deny list Change-Id: Iee994411891b73b865e6496403682f996d5e9321 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116384 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120482 Tested-by: Jenkins
2021-08-16Cleaning up decleration and initialization of unique_ptr variablesHossein
Cleaning up decleration and initialization of unique_ptr variables pPageSizeItem, pPageLRMarginItem, and pPageULMarginItem according to the request: https://gerrit.libreoffice.org/c/core/+/120456 Change-Id: I0cf5149308fe06c10403bfb82ca6a1786096bf3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120520 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-16tdf#132739: sw_htmlexport: Add unittestXisco Fauli
Change-Id: I69a5b0659d8b9a13b662ee1e7612e056f9d3ce4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120512 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-15crashtesting: failure on export tdf87915-2.odt to docxCaolán McNamara
in this example ConvertToPolyObj returned a SdrObjGroup* so cast to SdrPathObj* goes wrong. new since commit 61ef73bb9e06ac7325abc26698314d7e35c164cc Date: Sun Aug 8 01:05:09 2021 +0200 tdf#143432 and more, improve wrap contour export Change-Id: I80312971fbe7e5b6e17e7ae41f2afbbb05f21d76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120515 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-15tdf#142760: sw_ww8export3: Add unittestXisco Fauli
Change-Id: I82a1e8b8ddf5e392b9c2b578247a2364864a0970 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120513 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-15tdf#143860 non-primitive needs custGeom not prstGeomRegina Henschel
Error was, that for a custom shape with type 'non-primitive' method DMLPresetShapeExporter::WriteShape() was called. For such shapes the method GetOOXMLPresetGeometry() returns preset type 'rect' and in case the shape had no handles, that preset geometry was written. In my solution I exclude shapes of type 'non-primitive' from using DMLPresetShapeExporter, because such shapes never belong to a OOXML preset shape. Change-Id: I714f69c98fe15c2b7e70dc0a474a7f85ad757034 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120511 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2021-08-15Fix typosAndrea Gelmini
Change-Id: I3b75c0b8500bebe3025e038dba02a0d6f444bce6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120181 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-08-15rtl::Static -> thread-safe static localNoel Grandin
Change-Id: Iac0501e6aa35cc3d8e62f6b6e68b76cf70233aae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120459 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-15Simplify tools::Rectangle a bitMike Kaganski
1. Simplify/delegate ctors 2. Simplify getWidth/getHeight 3. Simplify expand 4. Simplify operators += / -= / + / - Change-Id: I023aa1bb2905394fbbd29adc7c544d629f9ae2d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120476 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-15Add the possibility to check if a mathml attribute is manually setdante
Change-Id: I9c5eaee8e2cce47d9286306031e807ca2c0eed57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120473 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-15Add the Form attribute to modante
Change-Id: I4f64460e15c707fa8ecdcfdfbea460b2f1410947 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120469 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-15Avoid computing LanguageTag fallbacks several hundred timesEike Rathke
... over and over again even for known and present locales for each and every localizable config item. Change-Id: I19974c56169f45a7c53ed6b0eede47365e1365dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120496 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-08-15Resolves: tdf#137742 Workaround cheesy Google Docs writing language-only tagsEike Rathke
Change-Id: I2dc85abb70d53769d2e36102070e30ed71e8d888 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120495 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-08-14upgrade to openssl-1.1.1kCaolán McNamara
Change-Id: Ibd930ab4f97e2f74868b73163d7f2f46fb466749 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120490 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-14cid#1490212 silence Untrusted divisorCaolán McNamara
"The divisor could be controlled by an attacker, who could cause a division by zero." but this division can only happen if the divisor is either 8 or 4 Change-Id: I7cae93f48d84e023912b8613be89cf9db5589d4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120489 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-14ofz: build with system libexttextcatCaolán McNamara
Change-Id: I1dd2c49bfc5577a8502eb42721f3ef9b08f8fdb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120485 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-14tdf#142605 use frame size in oox export of BezierCurveRegina Henschel
The export had used the bound rectangle of PolyPolygonBezier. But that contains control points. Use API position and size instead. I have not incorporated the changes into existing WritePolyPolygon, but have made an own version for SdrPathObj, because I find it easier to read and maintain, than having a lot of case distinctions depending on the shape type. Change-Id: I2e646c4f5fa37174c4979855212ca72f2dfa447e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120407 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2021-08-14tdf#143148: Use pragma once in sdextYildiray
Change-Id: Ic626b9064d9bcd024f938bbd43375bc3fff5838f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120178 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-08-14Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to a5ea0c841f16a2cfaa8b00ca15aecae1b59e9d1b - Create help page for the "Search Commands" feature Change-Id: Ic62e9671575709ca3ac788495edaf4b2753499ee Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120245 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-08-14Fixed documentation references to the custom shape generate scriptHossein
* Fixed references to the custom shape generation script in the oox/README.md to use generate.sh instead of README.md * Added README.md to oox/source/drawingml/customshapes folder * Moved documentation parts from the script to the README.md The README script was renamed to generate.sh before in the commit 59577dbb84fae18a3216d57ffec6008af157ce9b Change-Id: Id167b32c7a101806c33126ea1642a0194d693231 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119376 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-08-14flatten svt::table::DefaultInputHandlerNoel Grandin
Change-Id: Idba4039bbedd7c276505c5e9763b559d505cf7a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120467 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-14flatten OFlowChainedTextNoel Grandin
Change-Id: I0836d1f850c71700f8691cf8847e4f4d30d4dbb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120475 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-14tdf#140226: use StaticWhichCastEmircan Agac
Change-Id: I5eb25fdfd629e397582cd49e3fa4acab32c05bbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120456 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-08-14tdf#140226: use StaticWhichCastEmircan Agac
Change-Id: I54f898d3341155d88b6b9599995b9e5001de71c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120406 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-08-14formatter maps can use unordered_mapNoel Grandin
Change-Id: I733537e98cccc1a5dcb2c275b3baeb56af5f15c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120468 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-14tdf#140226: use StaticWhichCastEmircan Agac
Change-Id: I013b6ff371992a31a1ee11f93072eeb49566fe52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120401 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-08-13Help older linkers (Ubuntu 18.04, Fedora 31)Jan-Marek Glogowski
Fixes a regression from commit 429e6e6efbfbc65d36452cbf8b3a25740a1dc8bc ("osl::Mutex->std::mutex in OInputStreamHelper"), which results in failed linking with some older toolchains: /usr/bin/ld.gold: error: workdir/CxxObject/xmlsecurity/source/helper/UriBindingHelper.o: requires dynamic R_X86_64_PC32 reloc against '_ZThn40_N3utl18OInputStreamHelper7acquireEv' which may overflow at runtime; recompile with -fPIC include/com/sun/star/uno/Reference.hxx:240: error: undefined reference to 'non-virtual thunk to utl::OInputStreamHelper::acquire()' collect2: error: ld returned 1 exit status xmlsecurity/Library_xmlsecurity.mk:10: recipe for target 'symbols/instdir/program/libxmlsecurity.so' failed Known problematic setups are my Ubuntu 18.04 build schroot and Caolán's Fedora 31 VM to run Coverity. Change-Id: I40f0734a0cb9131193abf21ba95dc63816b5c1d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120426 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-13let return in java param dialog entry 'add' when possibleCaolán McNamara
Change-Id: Idfa2283dde0596db5c7fe2b56e8db761a5c75fc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120465 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-13cid#1490212 try and silence bogus divide by zero Untrusted divisorCaolán McNamara
Change-Id: I132d01c6007cd1da47f7dc405cfc3c4967757241 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120464 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-13cid#1490210 silence Arguments in wrong orderCaolán McNamara
Change-Id: I8767fe556142ec7e3254eaff56bbb1b4eb8322e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120462 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-13bibliography, local URL: better starting directory when picking a new fileMiklos Vajna
Improve the case when we have no old file, so we can't take its old parent directory as a starting point in the file picker, opened by the browse button. It turns out both places that open that file picker have access to the base URL of the current document, so can open the directory of that instead. Change-Id: I4db84b6036771f48962d49ae5e4c46a99c306def Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120455 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-08-13pre-select todays's date if the date is emptyCaolán McNamara
Change-Id: If34dbb31d14512b7a7c2a76a3adeb99882a8c60c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120457 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-13tdf#143148:Use pragma once instead of include guardsEmircan Agac
Change-Id: Ib3c0d6c158e5efbbca55e03f189dccaf67832a96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119888 Reviewed-by: Hossein <hossein@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins
2021-08-13tdf#127543 add saveacopy to File dropdown menu tabsAndreas-Kainz
Change-Id: I19dc3e298f3199823224dab9796faee67307b494 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120298 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2021-08-13tdf#141908: CppUnittests: replace usage of sal_Int32 with colorsEmircan Agac
Change-Id: I7df5ec2eac7339e27f03ce8756522756b2fc80da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120184 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-08-13tdf#143852: Revert "Move ActionLockGuard up a bit"Mike Kaganski
This reverts commit b791974837a99ead793b4ead6760b2f4e5237de2. Change-Id: I4bb95c915aa27b509ea2a41602ba2198c2f20cea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120370 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-13Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to 12f1ebf5f989b60ec2c2470e79fbeabf8247f483 - sf_base review - typo in Python example Change-Id: I43c6125b20b0c5a4b94c3160e8157eb094bd7a78 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120434 Tested-by: Jenkins Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2021-08-13Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to f6422656f4d6d5432cf18fab6a104a75d369662f - Document sf_string Python support - Typo in FindRegex Change-Id: I7b2f98140585f7ff0ff04f9c4855deb299664592 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120432 Tested-by: Jenkins Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2021-08-13tdf#143432 and more, improve wrap contour exportRegina Henschel
tdf#143432 The example document triggers the case, that there is no own, no from docx imported, and no from customShape generated wrap polygon. In that case WrapTextMode_LEFT and WrapTextMode_RIGHT were not evaluated and default bothSides was written. The patch moves evaluation of WrapTextMode up and out of individual cases, so that result can be used in all cases. tdf#142433 The previous solution has written the enhanced-path of a customShape literally as wrap polygon. But it might contain references to equation or modifier. The patch uses the polyPolygon, which you can get from the customShape. tdf#143760 The previous solution took a wrap polygon, which was imported from docx unconditionally. So it misses the case that the user has changed the wrap type. The patch reorders it so, that first the current wrap type is evaluated and then a wrap polygon is determined if the wrap type needs it. tdf#136386 The previous solution wrote for shapes not imported from docx a wrap polygon only in case of customShapes. So for other kind of shapes contour wrap was lost. The patch adds wrap polygons for other kind of shapes too. Default is a rectangular wrap polygon. That is used too, if a shape type would need an individual wrap polygon, but that is not yet implemented. The wrap polygon for Bezier curves is correct, but the curve itself is wrongly exported. That is bug tdf#142605. The previous solution misses to normalize the wrap polygon to range [0..21600; 0..21600.] In case there was no contour wrap in the imported docx and the user sets a contour wrap, the wrap polygon had wrong range, because the enhanced-path of an ooxml-foo shape is not in range [0..21600; 0..21600]. Change-Id: Idc678fd385b705e66b7d5cb02a7dea5925f2ada1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120169 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-08-13Include the starmath version inside the configurationdante
Change-Id: I4492fad6eb498e0c8c9a53b2096f538f2916d843 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120271 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-13rtl::Static -> thread-safe static localNoel Grandin
Change-Id: If5b7181fb1bb3f3f21ec3742680e5a3e12b21b73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120431 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-13ofz: use system .a curl, fontconfig, freetypeCaolán McNamara
Change-Id: I2d0fcf28aa8d2fe937f850a2a54125073a6913d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120423 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>