summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-01-15Remove a fragment from a file URL early onStephan Bergmann
...as ShellExecuteExW would ignore it anyway Change-Id: I969db094bb7d2ea230ac8c36eb23d71a90fbe466 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86868 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-15tdf#114441 Changing sal_uLong to appropriate integer type in filters moduleshashikdm
changed sal_uLong to one of {size_t, sal_uInt64, sal_uInt32, sal_uInt16, sal_uInt8} in flash/impswfdialog.cxx and graphicsfilter changed PS_* in file filter/source/eps/eps.cxx to enum and overloaded bitwise or (|) made types of nSize, nParseThis, nComp and nBytesRead to sal_uInt32 as Michael Stahl suggested changes suggested by Michael Stahl changed x, y, j to sal_uInt32 in filter/source/graphicfilter/etiff/etiff.cxx changed nMinPercent, nMaxPercent, nLastPercent, nMainEntitiesCount to sal_uInt16 in filter/source/graphicfilter/idxf/dxf2mtf.hxx removed nGcount variable from filter/source/graphicfilter/idxf/dxfgrprd.hxx and filter/source/graphicfilter/idxf/dxfgrprd.cxx removed static_cast in filter/source/graphicfilter/idxf/dxf2mtf.cxx changed nComp in filter/source/graphicfilter/ieps/ieps.cxx to size_t changed mnCol to sal_uInt16 in filter/source/graphicfilter/ipbm/ipbm.cxx revised a number of datatypes as suggested by michael stahl in his reviews removed redundant static casts which caused test to fail Change-Id: Id892ee7e9c1ef3cf75c9d768b790ced9c2ce3f3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84726 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-15Toolbox needs to be a complete type here (Windows --disable-pch)Stephan Bergmann
...because of the m_xToolBox data member and inline copy/move functions of SVX_DLLPUBLIC MenuOrToolMenuButton Change-Id: Ia070c28e31797f7d09c2862f5bb2775379c0a170 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86867 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-15Missing includes (Windows --disable-pch)Stephan Bergmann
...after f7804fc28bc65de4938d67d6f8a19f1eacab3341 "tdf#42949 Fix IWYU warnings in sfx2/source/[d-n]*/*cxx" Change-Id: I3dc8fbfb353daec980fc0a73809fc2cd83972d2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86866 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-15tdf#129574 sw: fix RTF export of table of contentsMichael Stahl
The problem is that the hyperlink that starts at the start of the first paragraph of the ToX content is written to RTF before the TOC field itself, so the hyperlink contains the entire ToX: {{\field{\*\fldinst HYPERLINK "#__RefHeading___Toc250984071" }{\fldrslt {\rtlch\langfe1024 \ltrch\lang1024\loch {\field{\*\fldinst { TOC \\o "1-3" \\h \\z }}{\fldrslt {1.India\tab 1}}}} This is because the HYPERLINK is written into m_aRun but the TOC into m_aRunText. Interestingly StartRun() asserts that m_aRunText should be empty, so we don't try to change StartURL() to write the HYPERLINK into m_aRunText. The only function that moves text from m_aRunText to m_aRun is EndRun(), so wrap the TOC field in StartRun()/EndRun(). This breaks the export of the ToX to DOCX because a mysterious SDT is no longer written around the field but only the field result, so only do this for RTF. Change-Id: I22e45c4a9c9ce6edb2b9114b4a29b2a373ec3284 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86860 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-15tdf#42949 Fix IWYU warnings in svx/source/*/*hxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I2c846dba43bec95b2ef2739ee9c0940880f51c1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86621 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-15tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorMesut Çifci
Change-Id: Ib58c66590c60175d7984af55d23b7c55a6a2383e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86828 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-15tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorMesut Çifci
Change-Id: Ice7c0ecc8ee05a5c3b0af458ceeee8191bdde322 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86752 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-15tweak GetBitmap methods in BitmapExNoel Grandin
so we return a const& for the normal case, just like other methods, which reduces copying. This revealed that CreateDisplayBitmap in Bitmap can be const. Change-Id: I9f9b9ff0c52d7e95eaae62af152218be8847dd63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86836 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-15StartCascading is unusedCaolán McNamara
Change-Id: Ic58ab3715aadf53bf4f3fd1e32a241d9d9275322 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86839 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-15rework SvxColumnsToolBoxControl to be a PopupWindowControllerCaolán McNamara
and weld it, convert it and TableWindow to use two CustomWidgetController for the content widgets. Change the ColumnsWindow from an auto-grow width element to something with a fixed width and add a spinbutton to handle the overflow cases that don't fit in the fixed width Change-Id: I046a21dfd2a7c23828c4e2945b42c30db362b049 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86812 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-15lok: ui: increase the 'step-increment' property to 5Henry Castro
Change-Id: I1090a9f6435619f095ca22ef401c5e1bc9741d06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86820 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-01-15external: update pdfium to 4021Miklos Vajna
Change-Id: I1c3280e811bf65641bf559e3f01bc62e609548f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86811 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-15avoid needless copy by SkSurface::makeImageSnapshot(rect)Luboš Luňák
It seems to make data copy if the given rectangle is a subset of the size, so rather use the whole rectangle and specify the subset in drawImageRect(). Change-Id: I42f1da533dbf4334ec538e478131901b2d7ed7b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86775 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-15do not ignore return value of a (confusing) function (tdf#126248)Luboš Luňák
The two ScCellFormat::GetString() overloads are lame API, one returns the value normally and the other one returns void and uses a reference parameter. I got confused by this in 6f810e3d7dafcd7d0101173a501 and didn't use the return value in one case. Change-Id: I0b6c839f9d0299e14ea022813481802275df5ea6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86750 Tested-by: Jenkins Reviewed-by: 锁琨珑 <suokunlong@126.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-15tdf#126795 docx export: do not output tab stops twiceSerge Krot
Change-Id: I70235df7fb73133f413863ee5eb7c76905a60248 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86767 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-01-15tdf#129525 writerfilter: ignore GOTOBUTTON fieldMichael Stahl
The bugdoc contains nested fields for some of the page numbers: {\field\flddirty{\*\fldinst {\caps0\lang1024 GOTOBUTTON _Toc434317064 }{\field{\*\fldinst {\caps0\lang1024 PAGEREF _Toc434317064 }}{\fldrslt {\caps0\lang1024 4}}}}} The problem is that the outer field does not have a \fldrslt, only the inner PAGEREF field has one. This used to be imported incorrectly because the nested field's result ended up in the outer field's result; now it's imported correctly but then there's no field result to show, because Writer can't expand fieldmarks. As we can't do anything with a GOTOBUTTON field, just ignore it explicitly to prevent creating a generic fieldmark; the PAGEREF is already ignored inside of a ToX since commit 9679e9c23216decb5f9f25f85b04cb3f25211111. ("regression" from e511a0ca5dde6d731bb126bbfe21768867890102..d9030ad6298e2f49ee63489d6158ea6ad23c0111) Change-Id: I8135c8d14995378181ce959d22d9be5ea0cae260 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86796 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-15improve "convert OSL_ASSERT to assert"Noel Grandin
this fixes commit 3a0c4574449fc2313306c4e0e39bb7416cc20657, by converting the assert in removeInterface() to SAL_WARN_IF, and similarly for the related addInterface() method Comment from sberg on the original commit: This leaves OInterfaceContainerHelper::add-/removeInterface in somewhat inconsistent state (as addInterface OSL_ASSERTs non-null but then also explicitly checks for null, i.e., effectively supports null). css.lang.XComponent::add-/removeEventListener do not explicitly specify whether or not their arg may be null. I /think/ we traditionally supported null; asserting non-null thus might cause issues for 3rd-party code. Change-Id: I1e28cc03aa7dfe662125c573d60b447309009448 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86827 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-15Bump boost version to 1.71David Ostrovsky
Change-Id: Ica4aba467aa00236a4d1c5b0411d1ebc657ea4df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86594 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-15Sidebar expandable fixandreas kainz
Change-Id: Ie6398eeec89112caa9f27b278c4f267049c8b436 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86817 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-15clang-tidy modernize-concat-nested-namespace in svxNoel Grandin
Change-Id: I8a00f2823aa956afb995ee68c9f995bf08ad5239 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86824 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-15tdf#129393 Calc: cannot format whole row of unprotected cellsNoel Grandin
regression from commit 3c3a371c799d00475deb13b4c3e0a8860c7e4fb3 tdf#125254 Performance: A spreadsheet opens too slow, part2 Change-Id: I87e06a58d6a4eb1a32bdf7e9267a4fe9d6dc4f2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86826 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-15WaE: unused parameterTor Lillqvist
Change-Id: Iba0c5c6c67d54e89bd3252315d83d6b9f947acdf
2020-01-15use FastParser for SchXMLImportNoel Grandin
Change-Id: Ib43f109dce8226d29b19c141010e4480147933ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86825 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-15clang-tidy modernize-concat-nested-namespace in connectivityNoel Grandin
Change-Id: Id18966cc44c012730a872ebfa93f2b468cefff38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86823 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-15convert OSL_ASSERT to assertNoel Grandin
and fix the one place triggering it Change-Id: I87ec57c6a92ed89fdacfcb0d650525eaeaa266b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86822 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-15Clean up safeRead/WriteStephan Bergmann
...using more appropriate parameter types, replacing cheesy OSL_ASSERT overflow checks with cap_ssize_t, and replacing one remaining good OSL_ASSERT in safeWrite with assert. Change-Id: I6105ba5135216333e68003458be7ca28f1715a51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86807 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-15tdf#125089 Fix shoowing a separator in View-User interfaces submenusRoman Kuznetsov
for non EN GUI Change-Id: I8761560e48f781ed516494984fc5a86c72019ad0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86619 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>
2020-01-15clang-tidy modernize-concat-nested-namespace in sdNoel Grandin
Change-Id: I805cc225420de46d1fa7cbfcc22468e00cb5f5ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86805 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-15clang-tidy modernize-concat-nested-namespace in ooxNoel Grandin
Change-Id: I9877be75e1f7dcefdf7172d05dfbb0a63d06ced1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86803 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-15clang-tidy modernize-concat-nested-namespace in scNoel Grandin
Change-Id: I6a9b2b912434c053e20ce06ef03e52451e506693 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86804 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-15clang-tidy modernize-concat-nested-namespace in codemaker..configmgrNoel Grandin
Change-Id: I48452480fae169e11d60b125bbd0226b6a35a25c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86800 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-15clang-tidy modernize-concat-nested-namespace in cppcanvas..cppuhelperNoel Grandin
Change-Id: I0bb4ea91288a15fb590d077fb390c53be8b50400 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86801 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-15clang-tidy modernize-concat-nested-namespace in swNoel Grandin
Change-Id: Ie7643f6a9f9df2591d9253b18259403c655e5bcf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86806 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-15Update git submodulesStanislav Horacek
* Update helpcontent2 from branch 'master' to 69896de636113d0bae2b1c44316f2c50b643f524 - fix typo in explanation of regular expression example Change-Id: I35103839b29ea98ee0295dbbe71712b9c041a807 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/86816 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-14prefix is unused when all implementations have constructorsStephan Bergmann
...which is the case here since 5d0901a75e7ef96dc722b5277450cc18ad163f7b "sd pptm: Add a separate PPTM filter." Change-Id: I4318681da9971cac4df083f9170f3a0f9fd26f75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86780 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-14ofz#20087 Invalid-enum-valueCaolán McNamara
Change-Id: I32966a6b3973a0db9e186260225ded216607efbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86809 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-14Avoid loplugin:redundantcast from within qWarning macroStephan Bergmann
...as seen with qt5-qtbase-devel-5.13.2-1.fc31.x86_64: > vcl/unx/gtk3_kde5/kde5_filepicker_ipc.cxx:367:5: error: redundant static_cast from 'const char [65]' to 'const char *' [loplugin:redundantcast] > qWarning() << "unhandled command " << static_cast<uint16_t>(command); > ^~~~~~~~ > /usr/include/qt5/QtCore/qlogging.h:167:33: note: expanded from macro 'qWarning' > #define qWarning QMessageLogger(QT_MESSAGELOG_FILE, QT_MESSAGELOG_LINE, QT_MESSAGELOG_FUNC).warning > ^~~~~~~~~~~~~~~~~~ > /usr/include/qt5/QtCore/qlogging.h:156:30: note: expanded from macro 'QT_MESSAGELOG_FILE' > #define QT_MESSAGELOG_FILE static_cast<const char *>(__FILE__) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Change-Id: I9578b07cfd1a2de570ae2ab5842d65ef708f5d6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86802 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-14rework SfxEmojiControl to be a PopupWindowControllerCaolán McNamara
Change-Id: Ia3262e5b54257d5556c500f440806ac2df9886cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86794 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-14weld PageOrientationControlCaolán McNamara
Change-Id: I4b8b5e9a467396a97531c915613d84a361163775 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86789 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-14rework PageOrientationPopup to be a PopupWindowControllerCaolán McNamara
Change-Id: I5930d6e16b99754a60e3bb22a70fadfc5d673aa5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86786 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-14weld PageMarginControlCaolán McNamara
Change-Id: Ie0af7bf21a8804620746fe42ad009717db65bf24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86783 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-14rework PageMarginPopup to be a PopupWindowControllerCaolán McNamara
Change-Id: I60a66b9be14f79cd2968f4bd3d91740137ee9d85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86782 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-14svmedit2.hxx doesn't need to be a public headerCaolán McNamara
Change-Id: I8f193478eb74b544a075b477fbeed5dc5b55402e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86781 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-14Silence -Werror,-Wdeprecated-declarations for nowStephan Bergmann
...as seen with qt5-qtbase-devel-5.13.2-1.fc31.x86_64: > vcl/unx/gtk3_kde5/kde5_filepicker.cxx:233:18: error: 'setConfirmOverwrite' is deprecated: Use setOption(DontConfirmOverwrite, !enabled) instead [-Werror,-Wdeprecated-declarations] > _dialog->setConfirmOverwrite(true); > ^ > /usr/include/qt5/QtWidgets/qfiledialog.h:174:5: note: 'setConfirmOverwrite' has been explicitly marked deprecated here > QT_DEPRECATED_X("Use setOption(DontConfirmOverwrite, !enabled) instead") > ^ Change-Id: I322dda4353a69746cc80afade8206c3cecee8a96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86799 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-14update and enable loplugin:duplicate-definesNoel Grandin
Change-Id: I713b9985b2a69fe3c84069f19c772969e2631e46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85571 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-14Sifr: Add more 32px icons (tdf#129846)rizmut
- Add 32px items in links.txt Change-Id: I110340b85190c859915436b13e27930c235b4f3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86695 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-01-14tdf#129360: don't try to use uninitialized objectsMike Kaganski
And also don't forget to re-initialize member list of watch item. Another old bug masked by hacks removed in commit 62f3f3d92aa204eaaa063b30d7ade44df501b997. E.g., previously in code Type t1 var1 var2 End Type Type t2 var1 var2 var3 End Type Sub test Dim v1 As t1, v2 As t2, v v = v1 v = v2 End Sub breaking on line 'v = v1', expanding v in Watch, and stepping to next line, didn't update the children count. After the change, this surfaced, and now fixed. Change-Id: Ia47f5363a2fc62042701ff14d084870d1cced392 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86792 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-14tdf#129805 writerfilter: fix import of nested generic fieldMichael Stahl
The problem was that the end of the outer nested generic field did not call PopFieldmark(), so the end of the field was at the end of the document. (regression from f610f9b611fe9f206b872ed06f7e859d688385fc) Change-Id: If5928b14dd35f7dd509370c2b8eef4c31bd149dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86785 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-14clang-tidy modernize-concat-nested-namespace in chart2Noel Grandin
Change-Id: I320234b60963d80f6870a9ce1fead8e29de437aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86759 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>