summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-08-22updater: fix error in linux part of updater makefilesMarkus Mohrhard
Change-Id: I2d32159364d34fb4154b7f88590045dc3a442bc3
2017-08-21cppuhelper: fix double checked locking in getTypeEntries()Michael Stahl
Change-Id: I73674f0293a57ed7c4d54aa6b68ff64d5ca4e7bd
2017-08-21stoc: remove extra bracesMichael Stahl
Change-Id: I3b6b77ba58832d7bfc350eeb5e589513b716a081
2017-08-21stoc: deadlock osl::Mutex::getGlobalMutex() vs getImplHelperInitMutex()Michael Stahl
As found in a clang/ASAN build running UITest_writer_demo. cppu::getTypeEntries locks getImplHelperInitMutex(). Let's try to replace the usage of getGlobalMutex() in proxyfac_create() with a new static Mutex that is only used in that function. {1: 7, 6: 1, 7: 1} Thread 1 is waiting for 7 Thread 7 is waiting for 1 Thread 7 (Thread 0x7f34a147a700 (LWP 2530)): 2 osl_acquireMutex(oslMutexImpl*) (pMutex=0x7f34f620a3e0 <globalMutexImpl>) at sal/osl/unx/mutex.cxx:97 3 osl::Mutex::acquire() (this=0x7f34f61f7da0 <osl_getGlobalMutex::globalMutex>) at include/osl/mutex.hxx:56 4 osl::Guard<osl::Mutex>::Guard(osl::Mutex*) (this=0x7f349f6dc420, pT_=0x7f34f61f7da0 <osl_getGlobalMutex::globalMutex>) at include/osl/mutex.hxx:122 5 com::sun::star::lang::cppu_detail_getUnoType(com::sun::star::lang::XSingleComponentFactory const*) () at workdir/UnoApiHeadersTarget/udkapi/normal/com/sun/star/lang/XSingleComponentFactory.hpp:69 6 cppu::UnoType<com::sun::star::lang::XSingleComponentFactory>::get() () at include/cppu/unotype.hxx:296 7 com::sun::star::lang::XSingleComponentFactory::static_type(void*) () at workdir/UnoApiHeadersTarget/udkapi/normal/com/sun/star/lang/XSingleComponentFactory.hpp:146 8 cppu::getTypeEntries(cppu::class_data*) (cd=0x7f34bddacb40 <cppu::detail::ImplClassData<cppu::WeakImplHelper<com::sun::star::lang::XSingleComponentFactory, com::sun::star::lang::XServiceInfo>, com::sun::star::lang::XSingleComponentFactory, com::sun::star::lang::XServiceInfo>::operator()()::s_cd>) at cppuhelper/source/implbase_ex.cxx:96 9 cppu::queryDeepNoXInterface(_typelib_TypeDescriptionReference const*, cppu::class_data*, void*) (pDemandedTDR=0x60f000042940, cd=0x7f34bddacb40 <cppu::detail::ImplClassData<cppu::WeakImplHelper<com::sun::star::lang::XSingleComponentFactory, com::sun::star::lang::XServiceInfo>, com::sun::star::lang::XSingleComponentFactory, com::sun::star::lang::XServiceInfo>::operator()()::s_cd>, that=0x606000d3d3c0) at cppuhelper/source/implbase_ex.cxx:168 10 cppu::WeakImplHelper_query(com::sun::star::uno::Type const&, cppu::class_data*, void*, cppu::OWeakObject*) (rType=invalid uno::Type, cd=0x7f34bddacb40 <cppu::detail::ImplClassData<cppu::WeakImplHelper<com::sun::star::lang::XSingleComponentFactory, com::sun::star::lang::XServiceInfo>, com::sun::star::lang::XSingleComponentFactory, com::sun::star::lang::XServiceInfo>::operator()()::s_cd>, that=0x606000d3d3c0, pBase=0x606000d3d3c0) at cppuhelper/source/implbase_ex.cxx:296 11 cppu::WeakImplHelper<com::sun::star::lang::XSingleComponentFactory, com::sun::star::lang::XServiceInfo>::queryInterface(com::sun::star::uno::Type const&) (this=0x606000d3d3c0, aType=invalid uno::Type) at include/cppuhelper/implbase.hxx:108 12 non-virtual thunk to cppu::WeakImplHelper<com::sun::star::lang::XSingleComponentFactory, com::sun::star::lang::XServiceInfo>::queryInterface(com::sun::star::uno::Type const&) () at include/cppuhelper/implbase.hxx:107 13 com::sun::star::uno::BaseReference::iquery(com::sun::star::uno::XInterface*, com::sun::star::uno::Type const&) (pInterface=0x606000d3d3e8, rType=invalid uno::Type) at include/com/sun/star/uno/Reference.hxx:55 14 com::sun::star::uno::Reference<com::sun::star::lang::XSingleComponentFactory>::iquery(com::sun::star::uno::XInterface*) (pInterface=0x606000d3d3e8) at include/com/sun/star/uno/Reference.hxx:70 15 com::sun::star::uno::Reference<com::sun::star::lang::XSingleComponentFactory>::set(com::sun::star::uno::BaseReference const&, com::sun::star::uno::UnoReference_Query) (this=0x7f349f92b7e0, rRef=...) at include/com/sun/star/uno/Reference.hxx:279 16 cppuhelper::ServiceManager::loadImplementation(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, std::shared_ptr<cppuhelper::ServiceManager::Data::Implementation> const&) (this=0x61500000e900, context=uno::Reference to (cppu::ComponentContext *) 0x611000003b50, implementation=warning: RTTI symbol not found for class 'std::_Sp_counted_ptr<cppuhelper::ServiceManager::Data::Implementation*, (__gnu_cxx::_Lock_policy)2>' arnound for class 'std::_Sp_counted_ptr<cppuhelper::ServiceManager::Data::Implementation*, (__gnu_cxx::_Lock_policy)2>' td:weak 0) 0x60b000013ff0) at cppuhelper/source/servicemanager.cxx:823 17 cppuhelper::ServiceManager::findServiceImplementation(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&) (this=0x61500000e900, context=uno::Reference to (cppu::ComponentContext *) 0x611000003b50, specifier="com.sun.star.configuration.ConfigurationProvider") at cppuhelper/source/servicemanager.cxx:1811 18 cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) (this=0x61500000e900, aServiceSpecifier="com.sun.star.configuration.ConfigurationProvider", Context=uno::Reference to (cppu::ComponentContext *) 0x611000003b50) at cppuhelper/source/servicemanager.cxx:993 19 cppuhelper::ServiceManager::createInstance(rtl::OUString const&) (this=0x61500000e900, aServiceSpecifier="com.sun.star.configuration.ConfigurationProvider") at cppuhelper/source/servicemanager.cxx:950 Thread 1 (Thread 0x7f34f632b4c0 (LWP 2487)): 2 osl_acquireMutex(oslMutexImpl*) (pMutex=0x604000098a90) at sal/osl/unx/mutex.cxx:97 3 osl::Mutex::acquire() (this=0x7f34f12fa820 <rtl::Static<osl::Mutex, (anonymous namespace)::theImplHelperInitMutex>::get()::instance>) at include/osl/mutex.hxx:56 4 osl::Guard<osl::Mutex>::Guard(osl::Mutex&) (this=0x7f34c6611420, t=...) at include/osl/mutex.hxx:129 5 cppu::getTypeEntries(cppu::class_data*) (cd=0x7f3498adf290 <cppu::detail::ImplClassData<cppu::WeakImplHelper<com::sun::star::lang::XServiceInfo, com::sun::star::reflection::XProxyFactory>, com::sun::star::lang::XServiceInfo, com::sun::star::reflection::XProxyFactory>::operator()()::s_cd>) at cppuhelper/source/implbase_ex.cxx:89 6 cppu::queryDeepNoXInterface(_typelib_TypeDescriptionReference const*, cppu::class_data*, void*) (pDemandedTDR=0x60f00003c6d0, cd=0x7f3498adf290 <cppu::detail::ImplClassData<cppu::WeakImplHelper<com::sun::star::lang::XServiceInfo, com::sun::star::reflection::XProxyFactory>, com::sun::star::lang::XServiceInfo, com::sun::star::reflection::XProxyFactory>::operator()()::s_cd>, that=0x6080005aa620) at cppuhelper/source/implbase_ex.cxx:168 7 cppu::WeakImplHelper_query(com::sun::star::uno::Type const&, cppu::class_data*, void*, cppu::OWeakObject*) (rType=invalid uno::Type, cd=0x7f3498adf290 <cppu::detail::ImplClassData<cppu::WeakImplHelper<com::sun::star::lang::XServiceInfo, com::sun::star::reflection::XProxyFactory>, com::sun::star::lang::XServiceInfo, com::sun::star::reflection::XProxyFactory>::operator()()::s_cd>, that=0x6080005aa620, pBase=0x6080005aa620) at cppuhelper/source/implbase_ex.cxx:296 8 cppu::WeakImplHelper<com::sun::star::lang::XServiceInfo, com::sun::star::reflection::XProxyFactory>::queryInterface(com::sun::star::uno::Type const&) (this=0x6080005aa620, aType=invalid uno::Type) at include/cppuhelper/implbase.hxx:108 9 com::sun::star::uno::BaseReference::iquery(com::sun::star::uno::XInterface*, com::sun::star::uno::Type const&) (pInterface=0x6080005aa620, rType=invalid uno::Type) at include/com/sun/star/uno/Reference.hxx:55 10 com::sun::star::uno::Reference<com::sun::star::uno::XWeak>::iquery(com::sun::star::uno::XInterface*) (pInterface=0x6080005aa620) at include/com/sun/star/uno/Reference.hxx:70 11 com::sun::star::uno::Reference<com::sun::star::uno::XWeak>::query(com::sun::star::uno::BaseReference const&) (rRef=...) at include/com/sun/star/uno/Reference.hxx:371 12 com::sun::star::uno::OWeakRefListener::OWeakRefListener(com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&) (this=0x603000e789b0, xInt=uno::Reference to ((anonymous namespace)::FactoryImpl *) 0x6080005aa620) at cppuhelper/source/weak.cxx:371 13 com::sun::star::uno::WeakReferenceHelper::operator=(com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&) (this=0x7f3498ae06e0 <(anonymous namespace)::proxyfac_create(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&)::rwInstance>, xInt=uno::Reference to ((anonymous namespace)::FactoryImpl *) 0x6080005aa620) at cppuhelper/source/weak.cxx:500 14 com::sun::star::uno::WeakReference<com::sun::star::uno::XInterface>::operator=(com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&) (this=0x7f3498ae06e0 <(anonymous namespace)::proxyfac_create(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&)::rwInstance>, xInt=uno::Reference to ((anonymous namespace)::FactoryImpl *) 0x6080005aa620) at include/cppuhelper/weakref.hxx:173 15 (anonymous namespace)::proxyfac_create(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) () at stoc/source/proxy_factory/proxyfac.cxx:443 16 cppu::OSingleFactoryHelper::createInstanceEveryTime(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) (this=0x61000031cfa8, xContext=uno::Reference to (cppu::ComponentContext *) 0x611000003b50) at cppuhelper/source/factory.cxx:140 17 cppu::OSingleFactoryHelper::createInstanceWithContext(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) (this=0x61000031cfa8, xContext=uno::Reference to (cppu::ComponentContext *) 0x611000003b50) at cppuhelper/source/factory.cxx:175 18 cppu::OFactoryComponentHelper::createInstanceWithContext(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) (this=0x61000031cf40, xContext=uno::Reference to (cppu::ComponentContext *) 0x611000003b50) at cppuhelper/source/factory.cxx:378 19 non-virtual thunk to cppu::OFactoryComponentHelper::createInstanceWithContext(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) () at cppuhelper/source/factory.cxx:364 20 0x00007f34f0e6d166 in cppuhelper::ServiceManager::Data::Implementation::createInstance(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool) (this=0x60b000001850, context=uno::Reference to (cppu::ComponentContext *) 0x611000003b50, singletonRequest=false) at cppuhelper/source/servicemanager.cxx:668 Change-Id: I8d10cca4965feb704c35c70cf99995be26e23a41
2017-08-21WB_STDTABDIALOG no more usedAndrea Gelmini
Since commit 6df2c90c08b6 Change-Id: I2862e7c415b9f0d0d1ca2ea1a07e416222d81fd9 Reviewed-on: https://gerrit.libreoffice.org/41405 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-21Fix typoAndrea Gelmini
Change-Id: Ife6c317187915ba8df0351b7b96d481345343df6 Reviewed-on: https://gerrit.libreoffice.org/41404 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-21Fix typo in codeAndrea Gelmini
Change-Id: I1a26ab5e9c029c533b87c67499d6aebf871011e7 Reviewed-on: https://gerrit.libreoffice.org/41371 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-21tdf#111844 infobar icons on high dpiheiko tietze
scaling factor added Change-Id: Iccfc76832ccfaaffb9950d4b591b379dfb0d9eca Reviewed-on: https://gerrit.libreoffice.org/41401 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-08-21WB_FLATSPLITDRAW is deadNoel Grandin
since commit 2235846149e89dd9fe83cd4fbaf32908983aa571 Date: Tue Nov 23 18:50:48 2010 +0100 vcl117: reduce duplication of enums Change-Id: Ib9c8015934bc794df4b96cd35f5f93b23f372f70 Reviewed-on: https://gerrit.libreoffice.org/41386 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-21WB_FORCETABCYCLE is deadNoel Grandin
since commit 7ced337e1f0e1fae81ff7f196e59e558b729bdde Date: Tue Jun 18 16:59:27 2013 +0200 startcenter: GSOC Use Widget Layout for the Start Center Change-Id: I406059568f15500a21a1b41d3a4b8e12b2adb5cf Reviewed-on: https://gerrit.libreoffice.org/41385 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-21Updated coreGabor Kelemen
Project: help 8ecf172a2713f691ac63908676446fd86eefb2c1 Fix help pages after translator review http://nabble.documentfoundation.org/libreoffice-l10n-Errors-in-help-found-in-Pootle-td4218288.html Change-Id: I41a1ea18c9039e002135ac425ff21c296d65755b Reviewed-on: https://gerrit.libreoffice.org/40014 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-08-21Temporary fix for Clang on F26Tor Lillqvist
I get a mysterious linking error: sw/qa/core/uwriter.cxx:1416: undefined reference to `SfxEnumItem<SvxRotateMode>::operator==(SfxPoolItem const&) const' Change-Id: I2363ebf84784d17b8aea2f37cece191f48a1b717
2017-08-21Updated coreOlivier Hallot
Project: help 12f5fcacd219532e748c24b96c3be143e1fec99f tdf#107040 Calc: help for SUBTOTAL indexes 101-111 Change-Id: I90ad83a574748597553bb58c5436343b84947395 Reviewed-on: https://gerrit.libreoffice.org/41359 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-08-21emfplus: Corrected ReadWindowMetafileArmin Le Grand
There are two places which do hand over not a complete SvStream staring at pos zero, but pass a seek position indirectly in that stream. Thus this needs to be used. There is one usage in sc that copies the data to a MemStream to avoid that, so this hints that this 'trap/feature' was not known to everyone using it Change-Id: I94139b86c8bdd82879124c574bc3014e02d9ab5f Reviewed-on: https://gerrit.libreoffice.org/41399 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2017-08-21tdf#111626 switch underline color.Mark Hung
Switch underline font color if it is from the underline color of the portion. If the underline color is auto, take the font color into consideration. Change-Id: I81a0e100cd024add603b574f07e10b5e3a785d0b Reviewed-on: https://gerrit.libreoffice.org/41090 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2017-08-21WalkAndMatchElements: really really limit the match, tdf#108292 follow-upEike Rathke
getRemainingCount() could deliver a wrapped around overflow value if mnIndex was already greater than the end index, which could happen if when/for non-matching larger block sizes were added, and if then a match was found behind those blocks a non-requested/unexpected index was returned, which in turn led to the assert() being hit in ScInterpreter::CalculateLookup(). In non-debug could result in an invalid block position access. This happened with the bug case document of tdf#111943 which in master can be loaded. Also, the start and end index are not dynamic and don't have to be recalculated each time, so make them const; column argument values are unused after. Change-Id: Ic294cade4e8e7828bee394e5ade61d7127be6bbb
2017-08-21sw: check the target text node, not the sourceMichael Stahl
Change-Id: I386f4ded70cc3deffc2f2e43709edf16eba94c63
2017-08-21tdf#111524 sw: don't expand annotation mark when showing redline...Michael Stahl
... at a position directly behind the annotation mark. This happens with the the annotation "__Annotation__5847_848227920" in the bugdoc, followed by <text:change text:change-id="ct266312216"/>. When the redline is shown, the annotation mark expands from 5 - 101 to 5 - 240, but the SwPostItField is of course still at 101, so during the ODF export lcl_FillAnnotationStartArray() asserts. The problem is that the "bDelete" parameter of SwTextNode::Update() disables a whole bunch of code that prevents update of positions of redlines, bookmarks, fly frames, and shell cursors. This was introduced in 2004 with CWS dvoea1, but there is absolutely no documentation of what problem it was supposed to solve. So just try to remove it here and see if it causes any issue. Change-Id: I2d1f78c7163eddaf0ce6bbb7c6685ca759874ec5
2017-08-21tdf#111524 sw: delete annotation marks when creating delete redlineMichael Stahl
Range annotations are represented by a SwPostItField at the end of the annotated range, and a AnnotationMark that covers the range (including the field). During a normal delete, SwUndoDelete calls SwUndoSaveContent::DelContentIndex(), which has a special case to remove the AnnotationMark if the field is deleted. The problem is that when change tracking is enabled, the AnnotationMark survives, but the field is moved out of the paragraph when the redlines are hidden (as happens during ODF export), hence lcl_FillAnnotationStartArray() doesn't find its field. There doesn't appear to be a good solution to this, because in ODF it's also not possible to represent this, because the deleted content is outside the text:p element. It doesn't work to delete the annotation mark in DelBookmarks(), when hiding the redline, because then no Undo is created to restore the mark, and DelBookmarks() is also called from Undo code from SwUndoDelete, which breaks with this change. So delete the annotation mark when creating the redline in DocumentContentOperationsManager::DeleteAndJoinWithRedlineImpl(). Fixes the assert and the subsequent crash, which is a regression from 31c54fa7bb03768b425ae019096e0a0e26e9c736. Change-Id: I361ffee8e6ab86de499c25f34a96ceeaf83d9e0b
2017-08-21fix bogus always-true assertsMichael Stahl
Most of these were converted from OSL_ASSERT Change-Id: Ia95a758cdebf72ee80d00866644d92e6bb915071
2017-08-21WB_CBLINESTYLE is deadNoel Grandin
since commit 51e6fc0c9e401162036913a943708b7cca1b2598 Date: Wed Oct 1 13:31:44 2008 +0000 CWS-TOOLING: integrate CWS vcl92 Change-Id: I31e39286d207ab7be91411b5644578762ec0d0d1 Reviewed-on: https://gerrit.libreoffice.org/41383 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-21WB_FAST/WB_TOPLEFTVISIBLE are deadNoel Grandin
since commit 2235846149e89dd9fe83cd4fbaf32908983aa571 Date: Tue Nov 23 18:50:48 2010 +0100 vcl117: reduce duplication of enums Change-Id: Ic34a09ae79c5226e4f07230ac8ec5f528210d988 Reviewed-on: https://gerrit.libreoffice.org/41384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-21WB_TOPIMAGE is deadNoel Grandin
since commit a6ff21250bbc960cbcff026e8eeb72be032f56b2 drop window related stuff from rsc Change-Id: If9e0ccd75e7c4807b6c06697139d0f2142d46ce5 Reviewed-on: https://gerrit.libreoffice.org/41382 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-21WB_PATH,WB_OPEN are deadNoel Grandin
since commit c2f912b51efa458ba9bd1601a8676ab119aca1bd convert FilePicker flags to scoped enum Change-Id: I5f79c84e2faf9af2db3dc6c6a01b7e37d723f413 Reviewed-on: https://gerrit.libreoffice.org/41381 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-21Make cpp cope with long source linesStephan Bergmann
under --with-lang=ALL it had started to crash during e.g. > LD_LIBRARY_PATH=${LD_LIBRARY_PATH:+$LD_LIBRARY_PATH:}".../instdir/program:.../instdir/program" .../workdir/LinkTarget/Executable/cpp -+ -P -DWITH_POSTGRESQL_SDBC -DWITH_FIREBIRD_SDBC -DWITHOUT_EXTENSION_MEDIAWIKI -DWITHOUT_SCRIPTING_BEANSHELL -DWITHOUT_SCRIPTING_JAVASCRIPT -DWITH_HELPPACK_INTEGRATION -DWITH_EXTENSION_INTEGRATION -DENABLE_EXTENSION_UPDATE -DX86_64 -DLINUX -D_PTHREADS -DUNIX -DUNX -DCOMID=gcc3 -D_gcc3 -DWITH_LPSOLVER -I.../scp2/inc -I.../workdir -I.../config_host -I.../workdir/CustomTarget/scp2/macros -I.../workdir/ScpTemplateTarget/scp2/source/templates .../scp2/source/calc/file_calc.scp > .../workdir/ScpPreprocessTarget/scp2/source/calc/file_calc.pre because of > Syscall param read(buf) points to unaddressable byte(s) > at 0x4F31A80: __read_nocancel (syscall-template.S:84) > by 0x404F98: fillbuf (_lex.c:631) > by 0x404CCF: gettokens (_lex.c:479) > by 0x400F0A: process (_cpp.c:77) > by 0x400E80: main (_cpp.c:60) > Address 0x5278494 is 0 bytes after a block of size 32,772 alloc'd > at 0x4C2DB9D: malloc (vg_replace_malloc.c:299) > by 0x402034: domalloc (_cpp.c:321) > by 0x40554F: setsource (_lex.c:679) > by 0x403E38: doinclude (_include.c:130) > by 0x401F9D: control (_cpp.c:297) > by 0x401002: process (_cpp.c:101) > by 0x400E80: main (_cpp.c:60) There appears to be no other check that fillbuf doesn't overflow the Source's input buffer, other than gettokens checking that the buffer isn't more than three quarters full ("if (ip >= s->inb + (3 * INS / 4)) ..."). That smells like cpp assumes input lines to be shorter than some maximum number of characters (like the C99 standard setting a minimum limit of "4095 characters in logical source lines"), and > #define README_TXT_ALL_LANG(key, name, ext) \ > key (af) = READMETXTFILENAME(name,_af,ext); \ > Name (am) = CONFIGLANGFILENAME(name,am,ext); \ > Name (ar) = CONFIGLANGFILENAME(name,ar,ext); \ [...] > Name (zh-CN) = CONFIGLANGFILENAME(name,zh-CN,ext); \ > Name (zh-TW) = CONFIGLANGFILENAME(name,zh-TW,ext); \ > key (zu) = READMETXTFILENAME(name,_zu,ext) in workdir/CustomTarget/scp2/macros/langmacros.inc (which appears to be the culprit here) exceeding that limit under --with-lang=ALL. So just bump the input buffer size. Change-Id: I5d863050fb772dc7e691a604009ff8702dc718e3
2017-08-21loplugin:checkconfigmacrosStephan Bergmann
Change-Id: Ic9ffe0af9e32b45c304c1edee92ed4b185b4ed19
2017-08-21allow to build with released libepubgenDavid Tardon
Change-Id: I12d297e8a3e57a3b24d85e4c537996cad0106125
2017-08-21drop unused SdOptionsContentsItemJochen Nitschke
unused since commit e933538779d29a472c92252f14660c245aa8622e Date: Mon Nov 26 13:34:57 2007 +0000 INTEGRATION: CWS aw053 (1.23.124); FILE MERGED Change-Id: I67db5558e0a125273c4d5647329e9cecf70cf581 Reviewed-on: https://gerrit.libreoffice.org/41380 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-21loplugin:unnecessaryparen (clang-cl)Stephan Bergmann
Change-Id: I11a535a5271ec15965877986f15adc0804c00a4f
2017-08-21Adapt tests to WindowsStephan Bergmann
Change-Id: I8d33234196060f96ad47c9d0fead4f31218f8bdd
2017-08-21Updated coreAdolfo Jayme Barrientos
Project: help 8bece13f73046ebebfb5c18d02d857a961a4cdab These lame ASCII x’s didn’t need to be translatable The table looks cooler with U+2713 and localizers don’t need to waste time with superfluous strings. Double win! Change-Id: Ie5b308e451a7877ebfe8a393b00be11d09d8f7cc
2017-08-21drop pointless headersJochen Nitschke
Change-Id: Ia4e26760d4fad655bbd20714fa0abcad0921605a Reviewed-on: https://gerrit.libreoffice.org/41369 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-21simplify sd error macrosNoel Grandin
Change-Id: I0c2a720c4dddda77715e9d2697e9436f48a7d471 Reviewed-on: https://gerrit.libreoffice.org/41377 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-21remove dead sw error codesNoel Grandin
and inline some macros Change-Id: Ida8db46bec4fcec46a779da0180fe3bf1a1af59d Reviewed-on: https://gerrit.libreoffice.org/41375 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-21tdf#111908: only freopen if we try to use another consoleMike Kaganski
Change-Id: If513faa4aac03b4c41759445e34cc965ece0b48e Reviewed-on: https://gerrit.libreoffice.org/41378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-08-21updater: add a way to test the dialog code of the updaterMarkus Mohrhard
Change-Id: I7436edc85f87d1f68b50d39bf29564ff498c9ab9
2017-08-21trivial WaE when pdfium is disabledCaolán McNamara
Change-Id: I43a5061c9549a0aff217407ebd3cc5baf68ac60d Reviewed-on: https://gerrit.libreoffice.org/41334 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-21updater: always show the updater UIMarkus Mohrhard
Change-Id: I0e1dc86673779966ff247b81852fb2f29655d2b9
2017-08-21Fix typosAndrea Gelmini
Change-Id: I3f3abc3c6e12536d4bc38f0c676d5fc20532a1e3 Reviewed-on: https://gerrit.libreoffice.org/41370 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-08-21Typo notifcation->notificationJulien Nabet
Change-Id: I411105f1a3d519dd08bee55c722e4a06a14f238d Reviewed-on: https://gerrit.libreoffice.org/41368 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-21tdf#45904 Remove/disable obsolete _XPrintAreas Java testsJens Carl
The _XPrintAreas test are already written in C++ since commit b9337e22ce1dbf2eba0e8c8db294ae99f4111f91. Change-Id: I282ef018d96e824d73cedc83994dc998ff732b3b Reviewed-on: https://gerrit.libreoffice.org/41350 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-21tdf#45904 Remove/disable obsolete _XNamedRange testsJens Carl
The _XNamedRange tests are already written in C++ since commit b9337e22ce1dbf2eba0e8c8db294ae99f4111f91. Change-Id: I0b19653f99de108e76999629927260f1cfddeb8a Reviewed-on: https://gerrit.libreoffice.org/41348 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-21updater: set executable type GUI for updater.exeMarkus Mohrhard
Change-Id: I795cbd8634a3afe219db033ce40f833af0eee44a
2017-08-21avoid out of bounds accessMarkus Mohrhard
Change-Id: I4c7ddf2fcabc231b7250306b4a9255fab1a9ef7c
2017-08-21updater: also write channel to version.ini outside of instdirMarkus Mohrhard
Change-Id: Ibb087fc9cd17e50accf78f805e0fec4f202334b1
2017-08-21updater: looser throw specification for what() of exceptionMarkus Mohrhard
Change-Id: Ia73dea0cb845e1fb9a743157bbeadbcfeb1d3627
2017-08-20tdf#111775 - Default list of favourite special charactersAkshay Deep
Change-Id: I530c772d5b885132d38c168de66de923703f4b9f Reviewed-on: https://gerrit.libreoffice.org/41342 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
2017-08-20updater: move the update channel info from the config to versionrcMarkus Mohrhard
Change-Id: Id19578a889de51cacac869d7ec681c5c18c40cf9 Reviewed-on: https://gerrit.libreoffice.org/41365 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-20tdf#107129: correct showing orderSzymon Kłos
Change-Id: I2e72b8e0d3ff8ef9de16d634d85d43ef2da9ca75 Reviewed-on: https://gerrit.libreoffice.org/41361 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-08-20Fixing threadedStream produce loop condition:Mohammed Abdul Azeem
hasBytes() is for the consuming thread, produce loop should be stopped as soon as we've read as much as size of the stream. Change-Id: I0d857cc9cbcc4dd7d4a43cddbc4c457e8280353f Reviewed-on: https://gerrit.libreoffice.org/41364 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
generated by cgit (git 2.34.1) at 2025-01-19 21:34:28 +0000