summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-01-08add a scheme to host welded toolbar dropdown windows in unwelded toolbarsCaolán McNamara
Change-Id: I72c9896798740a760eac479bdccaf7825872c01b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86420 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-08tdf#96505:Get rid of cargo cult long integer literalsayhanyalcinsoy
Change-Id: I6ee1f79d4b96c4ed161eff11c1b75574d89902dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85843 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-08DOCX import: fix lost page break when footer ends with a tableMiklos Vajna
Regression from commit 7d3778e0ef9f54f3c8988f1b84d58e7002d6c625 (bnc#816593 DOCX import: ignore page breaks in tables, 2013-09-02), the page break was ignored because the preceding footer ended with a table (no empty paragraph at the end of the footer stream). Fix the problem by saving/loading the table state around header/footers, that way the page break is not ignored. Adjust testTdf102466 to test the page number from Word. Change-Id: Ia4c22452ee2c37f7f941dfd922db04c851644d0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86435 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-08rework ParaLineSpacingPopup to be a PopupWindowControllerCaolán McNamara
Change-Id: I8b43e0345d8d3c38a7ef21f31655b578a8dc8ea2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86384 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-08weld ListsPropertyPanelCaolán McNamara
Change-Id: I8fdf25a7e34bf3cf2b25a8b1a19af95a3a08af2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86348 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-08Avoid -Werror,-WundefStephan Bergmann
> In file included from C:/lo-clang/core/vcl/skia/salbmp.cxx:20: > In file included from C:/lo-clang/core/vcl/inc\skia/salbmp.hxx:27: > C:/lo-clang/core/workdir/UnpackedTarball/boost\boost/smart_ptr/shared_ptr.hpp(833,5): error: '__GNUC__' is not defined, evaluates to 0 [-Werror,-Wundef] > #if __GNUC__ == 2 && __GNUC_MINOR__ <= 96 > ^ with clang-cl. We already have external/boost/include/boost/shared_ptr.hpp ignoring (among others) -Wundef, but don't have such a wrapper for boost/smart_ptr/shared_ptr.hpp. Change-Id: I448fef581b0870cba821d7bbafcec759dd80dce4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86416 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-08tdf#75280 Convert inappropriate use of sal_uIntPtr to better integer typesYusuf Keten
Change-Id: Idf73b768671c0daa0d815b75ce71740fc0e5f5c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86310 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-08return fast context in SvxXMLTextImportContextNoel Grandin
Change-Id: I1a0bf073bb053cc0c63b5d1b98f1c5f9d32b2a63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86419 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-08tdf#129606: limit precision in ScTable::FillAnalyseMike Kaganski
... to 16th significant digit of least precise argument. This follows the practice to only consider 16 significant digits of user-provided values. Change-Id: Ic44fff82396f4f383c96343f9b2f7d35ccce9070 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85795 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-08Update git submodulesChristian Lohmaier
* Update helpcontent2 from branch 'master' to 9fc4da0db94a4d06ab31ada262551a0a28f2859e - avoid unnecessary change in po files due to use of spaces to indent po file extraction would strip tabs, but keeps spaces when extracting strings. Change-Id: I2947b12787f52f65ef9981ba6a9c9ffdee503a6b
2020-01-08Adapt solenv/flatpak-manifest.in to implicit --enable-skiaStephan Bergmann
(or should it better explicitly --disable-skia?) Change-Id: Id9483bee4148ec1101272b7b05f2ca1cd12e12e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86414 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-08loplugin:includeform (clang-cl)Stephan Bergmann
Change-Id: I30d1f3e67eafddb6334d0cb6cdc9bbe132057ea7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86415 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-08tdf#129879 Fix wrong order of buttonsTomáš Chvátal
Change-Id: I0cb135c5b8298fd7c5579673d0eaff7068a03842 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86425 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2020-01-08Missing include (Windows --disable-pch; for std::min)Stephan Bergmann
Change-Id: Ie6951257a94ae004e1a51f46e908917a07d137f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86417 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-08Fix typoAndrea Gelmini
Change-Id: I76be5d73d9acfe0c3f5525b251bb3feffb1e4c1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86380 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-08Fix typoAndrea Gelmini
Change-Id: I01c4bfadfabce128f1e28b0c871da1722b865b6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86377 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-08Fix typoAndrea Gelmini
Change-Id: I211fb36e9ad16b8ed468ce8dec5c95e7f5ab9391 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86381 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-08Fix typoAndrea Gelmini
Change-Id: I4e4a1b24d6b19ab62d9f0d73bcd74492bc955beb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86379 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-08Fix typoAndrea Gelmini
Change-Id: I29fcf584404acf9302e261721bb6c255e4701918 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86382 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-08Fix typosAndrea Gelmini
Change-Id: I2f498d16882e2aa6e75d6fc0a1073f094869a2b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/77765 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-08 tdf#96505 Get rid of cargo cult long integer literalsYusuf Keten
Change-Id: Ic0cde7c087d54a80a57d2a2574fa1f3932192367 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86311 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-08Options Dialog Compatibility options update first global than fileandreas kainz
Change-Id: Ibd906476eb9a798b1ef290a35545e0b22c10b892 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86407 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-01-08Options Dialog AutoCaption fix label alignment to follow HIGandreas kainz
Change-Id: Ia1e6370ba2c15d9ef6c940b60ebe8ada846622c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86411 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-01-08Grammar fixesAndrea Gelmini
Change-Id: I6ac6f6abb601aa254e94612e6826488393de8e3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86383 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-08Adapt solenv/flatpak-manifest.in to ffe9ff2cf63112ac04a695740a5637f25c16abe8Stephan Bergmann
..."update cppunit to 1.15.1" Change-Id: Id27a3c1b54845e965381514584ebaac13f70d8da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86413 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-08Fix typo/grammarAndrea Gelmini
Change-Id: I8e7320224a9cb4ff9317b842a2c1c0b1a3ddcd17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86390 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-08pyuno: remove redundant ifMichael Stahl
Change-Id: Ie0359efa8777439818e357a14db3e2474e936ef6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86403 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-01-08pyuno: fix build against system-python-3.6Miklos Vajna
pyuno/source/module/pyuno_runtime.cxx:984:57: error: use of undeclared identifier 'PyThread_get_thread_ident' It's only an assert, so simply do it only for >=3.7. Change-Id: Ia3fffc7a9af30780adff9bc7dbabe1727c1f8f54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86410 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-01-08ofz#19901 Invalid-enum-valueCaolán McNamara
Change-Id: I14273dfc695c504bd00f23f614b041207a8f2b29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86396 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-08Fix case mapping for undefined characters in the Osage blockAlex Henrie
Regression from commit 209fc9fd7fa433947af0bf86e210d73fa7f5a045 Change-Id: Icd181d0611b5fe194ba00352a93bf40bef35a8f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85641 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-01-08tdf#129517 add "Preview" labels in BulletandNumberingStyle dialog box"Seth Chaiklin
added GtkFrame to include label with Preview Window in Customize tab added label in Position tab Change-Id: Id37a2c696832ebe9dcd3cb4910a7bc3292cb0143 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86320 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-08Make OPT_ functions string more meaningful.Olivier Hallot
Help pages on OPT_ functions have more descriptive arguments lists and the change here is to make the Functions Wizard param's compatible with the Help pages. Change-Id: I0d90b0279ce24f773923935a7212fe7ab1c2c45b PS2: remove underscores and slashes in variable names Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85157 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-01-08make ODBFilter return a fast contextNoel Grandin
And (*) use the fast parser already inside ODBFilter (*) pass around ODBFilter explicitly to make the code easier to read Change-Id: Ib0dd24e530b32b5edb94f150390df1e405c3efb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86248 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-08Resolves: tdf#129681 Handle array/matrix in AGGREGATE() with ignore errorsEike Rathke
This also changes AGGREGATE() 3rd and subsequent parameters' classification from ReferenceOrRefArray to ReferenceOrForceArray to force the expected array mode on inline calculations. Change-Id: I53a5591e46bfbabbfa6a273f5b9590a69fad87a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86388 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-01-08Options Dialog Formating Aid update to fulfill HIGandreas kainz
Change-Id: Ic42946e661f2e7e8f31a0520d895c2fa07d6a387 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86401 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-01-08tdf#42949 Fix IWYU warnings in sw/source/uibase/[i-t]*/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I53139566ff41c8ee748945b39cd70b66fed8dc97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85973 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-08Drop duplicating range checkMike Kaganski
This is checked several lines below, with much stricter range. Change-Id: I3bfaf71f9e40dd1af089ed1ac238bc2939d0fc3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86392 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-08Enable Clang -Wembedded-directiveStephan Bergmann
...which might have helped avoid the confusion with patch set 6 of <https://gerrit.libreoffice.org/c/core/+/84765/6> "python3: upgrade to release 3.7.6", in that it would have reported: > pyuno/source/module/pyuno.cxx:340:2: error: embedding a directive within macro arguments has undefined behavior [-Werror,-Wembedded-directive] > #if PY_VERSION_HEX >= 0x030200f0 > ^ > pyuno/source/module/pyuno.cxx:342:2: error: embedding a directive within macro arguments has undefined behavior [-Werror,-Wembedded-directive] > #else > ^ (-Wembedded-directive was introduced with <https://github.com/llvm/llvm-project/ commit/300237f00c7ddf9c74de96272f2bb571fda61202> "Add a warning flag for ext_embedded_directive. gcc considers this undefined" in 2011, so should be available in all versions of Clang relevant for us.) Change-Id: I4d90212aac30ba8715496d8c99cc6de05c6dc99a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86394 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-08tdf#121458: chart: change "Data Ranges" button enabled condition.Vasily Melenchuk
"Data Ranges" button right now enabled if chart has no own table (as it was before 0074951704022d173a5fdb9df933f47be1dcbb91) or own table exists and it is possible to create data provider (LibreOffice will warn later about destroying data table). Change-Id: If92b0aad8a6099250effdb68022addb277ef4371 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86391 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-01-08Options Dialog Basic Fonts Label left align see HIGandreas kainz
Change-Id: I5589175401f1da584c310106ae8b27a0b411bbf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86395 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-01-08tdf#128782: sw: set name for draw frame style for text boxVasily Melenchuk
Since new undo/redo code operates style names instead of pointers, it is important to have all formats with name. Change-Id: Ib91cd13b8a324ae674e9ace9bb5f17e679bd2dab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86162 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-01-08python3: upgrade to release 3.7.6Michael Stahl
* external/python3/python-3.3.3-aix.patch.1: most of it doesn't apply and AIX port isn't maintained anyway so remove it for now * external/python3/ubsan.patch.0: apparently one of the files was removed * 0001-3.6-bpo-17239-Disable-external-entities-in-SAX-parse.patch.1: fixed upstream * python3-osx-avoid-new-10.13.patch.1: replace with simply passing ac_cv_func_utimensat=no to configure * external/python3/python-3.5.4-ssl.patch.1: project files to build OpenSSL removed upstream * There have been changes to how python locates OpenSSL; new variables OPENSSL_INCLUDES etc; it turns out that you have to pass one directory to --with-openssl, as the variables cannot be passed * libuuid.so.1 is a new dependency of the _uuid module * libffi.so.6 is a new dependency of the _ctypes module (the bundled copy of libffi for non-Darwin platforms was removed) * python-3.3.0-pythreadstate.patch.1: the PyThreadState functions have been changed such that CppunitTest_services asserts when there is a PyThreadAttach on top of PyThreadDetach on top of PyThreadAttach, i.e., 2 PyThreadState per thread (PyGILState_Check() fails). Instead of patching in additional workarounds, change PyThreadAttach so that it re-uses an existing PyThreadState if one exists for the thread. Change-Id: I24c19d79b43a30709261fd9db66312b2e3872fd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84765 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-08Resolves tdf#129793 - Remove "Field codes" optionHeiko Tietze
var m_xFieldNameCB, elem m_bFieldName, ui fieldcode removed Change-Id: I6711f9b8c4f84d6ef19bc295243df0341f8c4f3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86350 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-01-08weld LinePropertyPanelCaolán McNamara
Change-Id: If4ff18c3d312d273e9d28aeef97db053f56007ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86309 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-08AreaPropertyPanelBase::Initialize not called in chart sidebarCaolán McNamara
AreaPropertyPanelBase::Initialize used to be called twice in the "normal" sidebar, the effort in commit 40fe5b93bc0838e04b46bfc7942d1ee6a2482ce0 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Jan 2 14:45:32 2020 +0000 weld AreaPropertyPanel to get it called once in the normal case caused it to get called 0 times in the chart case, fix it to get called once in either case Change-Id: I2c4acffb58ed3b45e86e3bf0ce91db52989a0e25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86356 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-08tdf#94411 use f. and ff. in alphabetical indexSeth Chaiklin
Corrects en_US for index At present en_GB index is defined as en_US, and all other (en_*) are defined as en_US or en_GB Change-Id: Ib4c3e189c1d9a08c8f4eb17a1da526fbf23291d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86080 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-01-08Remove some unused includesMiklos Vajna
Change-Id: Icc451b72fd0b4181a082f2ee2b85b82765bd0c31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86385 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-08Paragraph Dialog Alignment preview fixandreas kainz
Change-Id: I63c3c28dedf82bfc8e28c0a323aaa8c26b4c82d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86316 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-01-07sw: don't send LOK notifications about redlines during saveMiklos Vajna
SwXMLWriter::Write_() sets redline flags to show insertion and hide deletion, but it resets those flags before the function returns. So LOK notifications for redline changes during save is not useful. Change-Id: I4bf963bbe9c7003cbe85ea6c5538be733a3e3cdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86363 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-07Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 84e12edbc498a2fca5a7e39eb87541969999b5df - tdf#129497 updating help for Condition tab of Paragraph Style dialog - add another access possibility - correct labels to match dialog box - add help about Reset Change-Id: I622cacbeb8c6dfb2945a3077e87eb04046ce50e9 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/86193 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>