summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-04-20loplugin:unusedfieldsNoel Grandin
Change-Id: I9c80805788d49b13552c168a36fdf395da19df26 Reviewed-on: https://gerrit.libreoffice.org/53196 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-20Adapt solenv/flatpak-manifest.in to recent download.lst changeStephan Bergmann
...58433a8b88537a1a0883d107972de5c5fad59d4a "Upgrade to language-subtag-registry-2018-03-30" Change-Id: Ic58160a56e739d8850566bf67eaed5c981109eb1
2018-04-20Updated coreStephan Bergmann
Project: help fe257ad7f55c500237bbeba8c6e13d7aa682fc22 Syntactic clean-up in GeneratedPackage_html_media.mk Change-Id: Ic3c1873c6c746434f00b3babd74e718cd941e39b Reviewed-on: https://gerrit.libreoffice.org/53209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-20Updated coreStephan Bergmann
Project: help 64bb1203851bc92fd5ee2acaf0d4c4babf7a6180 Avoid name clash between Package and GeneratedPackage htmlcontent2_html ...by renaming the latter to htmlcontent2_html_generated. The name clash happened to not cause trouble yet, but would once these packages are added to installation sets (i.e., once both would want to occur in gb_Helper_register_packages_for_install lists in Repository.mk). (Also do some minor syntactic clean up.) Change-Id: I009c154d3bb06312a9f4224b2d5feb1d9f6689fc Reviewed-on: https://gerrit.libreoffice.org/53208 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-20tdf#116266 Add unit testSerge Krot
The bug appeared only in libreoffice-6-0, but the unit test is useful for master anyway. Change-Id: I884ae18939b6def683bb318260c4e195da5bb252 Reviewed-on: https://gerrit.libreoffice.org/52375 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-on: https://gerrit.libreoffice.org/53192
2018-04-20loplugin:constantparamNoel Grandin
Change-Id: Ia58d8950b3b9e48bbe9f075b9fe1eed62d9abf0d Reviewed-on: https://gerrit.libreoffice.org/53188 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-20Updated coreOlivier Hallot
Project: help f10b89e1d34ab5faca7c4121dc9d1389617d1ba5 New Help: Improve table head rendering Add class to parent <td> of <paragraph role="tablehead"> Change-Id: Ifb9caf4d4ac3ab5e4c750b5bd96260e2dcb298e1 Reviewed-on: https://gerrit.libreoffice.org/53179 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-04-20use a map to avoid looping on every obj deleteCaolán McNamara
Change-Id: I47ff4f0f959b7d09fc91593b7dacb3d1a2b50472 Reviewed-on: https://gerrit.libreoffice.org/53164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-20remove unnecessary braces in GotoNextTableNoel Grandin
and comment the flow a little, it can be confusing Change-Id: I22fb11896a6d7e3b2007d822021b791b06caa1de Reviewed-on: https://gerrit.libreoffice.org/53185 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-20tdf#115582 Correct coordinate usage for sc's ::ArrayArmin Le Grand
In ScOutputData::SetCellRotations() eventually existing CellRotations are added to the svx::frame::Array data that gets created for repaint. This used the wrong coordinate calculation, thus in some cases the repaint of rotated Cells failed. Change-Id: Ib5df8576e8c9404d717d5dcc5662aa04b82cf959 Reviewed-on: https://gerrit.libreoffice.org/53171 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-04-20Remove unused HELP_COMMON_ONLYStephan Bergmann
Unused ever since its introduction in b70d4ad13b909265c54a9ff55f07224a14e9feb2 "add --with-help=common parameter to the configure option". (Whether --with-help=common is also unused is a different question that needs to be addressed separately.) Change-Id: Ic7843c838242bfe95dba7388f63358973f42e5b7 Reviewed-on: https://gerrit.libreoffice.org/53187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-20bump the MAXNUM_SUGGESTIONS comparisionCaolán McNamara
Change-Id: Id42a6ffb19a8f7e5425ade86e5e042edfa279d27 Reviewed-on: https://gerrit.libreoffice.org/53186 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-20Updated coreStephan Bergmann
Project: help 5de2306da7f9dea5231c0fd1bfd91491cceb646f Clean up Package_html_static.mk For ONLINE_HELP, apparently the source helpcontent2/help3xsl/index.html goes to instdir/help/index.html while the source helpcontent2/help3xsl/index2.html goes to instdir/help/$PRODUCTVERSION/index.html. And for !ONLINE_HELP, apparently both source files (index.html and index2.html) went to instdir/help/index.html, and the second one (index2.html) apparently happened to win. Cleaned that up, so that only the source helpcontent2/help3xsl/index2.html goes to instdir/help/index.html. Whether that's all as intended, or some of that is junk, I don't know. (Also sorted list of files lexicographically, for easier comparison with `ls` output.) Change-Id: I36f645e0de99a03b6e76f6c29fc18aa80e48a420 Reviewed-on: https://gerrit.libreoffice.org/53190 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-20writerperfect: astyle -> clang-formatMiklos Vajna
< vmiklos> dtardon: are you strongly attached to astyle usage in core.git writerperfect/? my problem is that 1) when less regular contributors touch it, they don't run astyle 2) core.git has git hooks in place to enforce consistent style for selected files, but that uses clang-format. i wonder if switching to the standard core.git clang-format would be an option to stop this reformat game <@dtardon> vmiklos, clang-format is okay. we started to use astyle years ago, before there were even any serious talk about automatic formatting for the whole libreoffice Change-Id: I844fc9c2e8560e54a49f26064cc0b3c55a5f034c Reviewed-on: https://gerrit.libreoffice.org/53184 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-20Updated coreStephan Bergmann
Project: help d9211d6ba5b3b5d46e2d4be8f8aa623372233394 Syntactic clean-up in Package_html.mk Change-Id: Ibc0f5773714f0e0df0f5bcdf0d52a482dcdbb4a7 Reviewed-on: https://gerrit.libreoffice.org/53189 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-20Fix typosAndrea Gelmini
Change-Id: I8674d279fe1e2d386a12de97fb3d2e3cfa7c5258 Reviewed-on: https://gerrit.libreoffice.org/53003 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-20weld SwSaveLabelDlgCaolán McNamara
Change-Id: I463ee75667e22d3b4b3ec64afabad52c5159d4ac Reviewed-on: https://gerrit.libreoffice.org/53168 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-20MungeTextIntoDrawBox 1st arg is member of 2nd argCaolán McNamara
Change-Id: I43a443af6b208f3ac100cd689bd2c24c3a080b75 Reviewed-on: https://gerrit.libreoffice.org/53163 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-20forcepoint#38 notify that obj in group was deletedCaolán McNamara
Change-Id: I4599a8e93eccb28c8a406418fd5c7c670b59c871 Reviewed-on: https://gerrit.libreoffice.org/53162 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-20Function to load graphic swapped out (loaded on demand)Tomaž Vajngerl
When a document is loaded it takes a lot of time and memory to load the graphic that are in the documet, so avoid that and just store the compressed graphic into a temporary file (handeled by GfxLink) and load when we really need to show the graphic. GraphicObject cached some attributes from Graphic, but this attributes now aren't available immediately so this attributes are removed form GraphicObject and now delegate to the Graphic itself. GetSizeBytes attribute however was removed as it is only used in some tests. GfxLink initial values were moved to the constructor and are not set in the header file anymore (as it is the recommended way to do it). The SdImportTest::testDocumentLayout failed as it looks like the dump sometimes didn't include the width and height of the null bitmap (which is set to 32x32) of the FillBitmap in some situations, but then in other situations it did include this attributes. With this change the width and height are always included for the FillBitmap which looks like it is more correct. Change-Id: Ia1218f93b1735402b7828404f65660e2d4acf32f Reviewed-on: https://gerrit.libreoffice.org/53016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-04-20tdf#42949 Remove unnecessary localization headers of svtoolsGabor Kelemen
Found by searching for the header names and the localization function: git grep -l -e \<svtools/svtresid.hxx\> -e \<svtools/strings.hrc\> | xargs grep -c SvtResId | grep :0$ | grep -v /pch Change-Id: I861fed778660412dc73616da29503538b3fe9ccb Reviewed-on: https://gerrit.libreoffice.org/53136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-20OBJ_TEXTEXT is deadNoel Grandin
with commit dfefe448c41921f2f1e54d3f69b8b9e89031d055 Date: Thu Mar 1 15:54:32 2018 +0100 SOSAW080: Added first bunch of basic changes to helpers Change-Id: Ib0dc816a62f36966f0d61b16916a49f11007b413 Reviewed-on: https://gerrit.libreoffice.org/53169 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-04-20loplugin:unusedenumconstantsNoel Grandin
TableChgWidthHeightType::RowTop is dead with commit 2d5ce0e1b233c83f91481cd6b9306ac8de7f5ff8 Date: Mon Mar 26 13:08:54 2018 +0200 tdf#116452 Remove "3 seconds to add/delete col/row" functions Change-Id: I2fa82822b70457673419bd90ae82016c796acaa8 Reviewed-on: https://gerrit.libreoffice.org/53167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-20loplugin:singlevalfieldsNoel Grandin
Change-Id: I8f3bad622daa3ce118d20c5be12294a3fab85c2a Reviewed-on: https://gerrit.libreoffice.org/53166 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-20loplugin:unnecessaryvirtualNoel Grandin
Change-Id: Ieecb426f4f839bb1f94e58e45a99643a74ec3009 Reviewed-on: https://gerrit.libreoffice.org/53165 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-20Merge in Flatpak improvementsStephan Bergmann
...from <https://github.com/flathub/org.libreoffice.LibreOffice/>: commit 715fbcfb4e5c51d40387998932984e54639476a1 Author: Robert McQueen <rob@endlessm.com> Date: Tue Apr 17 10:26:32 2018 +0100 edit .desktop files to add X-Endless-Alias with original names Endless OS uses this to update icon grids & taskbar pins if the original files have been removed. (Happy to update this to a more standardised key if a consensus emerges.) Change-Id: I646350090c38d84d1930c5afbec0ee500b60d0fb
2018-04-20loplugin:expressionalwayszero (clang-cl)Stephan Bergmann
Change-Id: If47b5bb3436ebdf799b74f7c0070f674ab52804e
2018-04-20loplugin:sallogareas (clang-cl)Stephan Bergmann
Change-Id: I2509f0c165de0f0754d93482825603da4644009a
2018-04-20loplugin:simplifybool (clang-cl)Stephan Bergmann
Change-Id: Ic63ebe497d9b9598be389d58cff294df2136ce2f
2018-04-20loplugin:cstylecast (clang-cl)Stephan Bergmann
Change-Id: Ica7c080e08d74443687069df42216e0f0c4f2153
2018-04-20loplugin:redundantfcast (clang-cl)Stephan Bergmann
Change-Id: I2ce9f8bcf4631ea93407eeaa49ca27eed3eb8e23
2018-04-20vcl: move Bitmap{Ex}::ReduceColors() to BitmapColorQuantizationFilter classChris Sherlock
Change-Id: I32b58e8d451e7303e94788a546a5b5f9a5bb4590 Reviewed-on: https://gerrit.libreoffice.org/53037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-04-20vcl: ImplSeparableBlurFilter() -> BitmapGaussianSeparableBlurFilterChris Sherlock
Change-Id: I996c9fcb0524e14e0093142be0749f0e5836426b Reviewed-on: https://gerrit.libreoffice.org/53071 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-04-19Related: tdf#116951 rhbz#1569331 end should be in terms of unicode charsCaolán McNamara
not bytes Change-Id: I05114019abb6c283586cd5c23ed1d148c9cf71d3 Reviewed-on: https://gerrit.libreoffice.org/53175 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-19turn #error into static_assertCaolán McNamara
Change-Id: Iddd4b344d77e43866975ce28797ff643055bfd04 Reviewed-on: https://gerrit.libreoffice.org/53160 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-19gla11y: fix some grandfathered warningsCaolán McNamara
Change-Id: I01723d0cb889f192a3e5aecadd86bb36682214c8 Reviewed-on: https://gerrit.libreoffice.org/53161 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-19Satisfy Coverity errorJim Raykowski
Change-Id: Ib619617adca0cb64fb69daffb3b57214e882d9b4 Reviewed-on: https://gerrit.libreoffice.org/53145 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-19weld XMLFilterTabDialogCaolán McNamara
Change-Id: I5ef92805690f55913e6366fce1fd4dc5180bb5a6 Reviewed-on: https://gerrit.libreoffice.org/53146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-19tdf#95843: Wait for fire_glxtest_process also in --headless modeStephan Bergmann
Discussed with mmeeks on IRC that fire_glxtest_process is probably called as early as possible so that its reuslt is ready by the time it is needed in the non-headless case. So best fix for headless is probably to just wait for the sub-process at an opportune point, instead of redesigning the whole mess so that fire_glxtest_process would only be called once its result is actually needed. Change-Id: I4ea9c9d54b83c9695a3b72317e68fed0c410da0e Reviewed-on: https://gerrit.libreoffice.org/53154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-19tdf#117103 Warning error is emptyNoel Grandin
regression from commit e9c74a075c3c0809b993c017c11d1505bd244dc8 drop ErrCode::GetRest Change-Id: I937478dbc9dd217255dc5cdecb6cf66d55394cba Reviewed-on: https://gerrit.libreoffice.org/53153 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-19weld XMLFilterTestDialogCaolán McNamara
Change-Id: Iaf2af607af1a6f42ab3156fabbc468d80264b14a Reviewed-on: https://gerrit.libreoffice.org/53141 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-19weld HangulHanjaNewDictDialogCaolán McNamara
Change-Id: I66db57e550e5035cc4830bfe51f671974eee6686 Reviewed-on: https://gerrit.libreoffice.org/53147 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-19sw lok: Accept / reject change is always enabled in the context menuTamás Zolnai
Use conditional fastcall for allow executing these two uno commands even if there is no tracked changes at the cursor position instead of enable the menu slots unconditionally. See also: b6011f07254f8003929320ad842d8d09daca0e09 Change-Id: Iaf8a8082961cd174c038fc021d2c41fb7cb97bff Reviewed-on: https://gerrit.libreoffice.org/53148 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-04-19tdf#117075 TOC numberings have incorrect right indentNoel Grandin
This reverts parts of commit 867a22fd199e732803c9050fe9f84ad630ec27fb Date: Wed Mar 28 10:00:30 2018 +0200 loplugin:virtualdown in xmloff/xmlsecurity and commit 73e6a7975b3508c5cfccb3df7c35b0303f87d9bb Date: Thu Mar 29 09:35:22 2018 +0200 loplugin:unusedmethods Change-Id: Id4230fafc10bbfe5822f7011a1b1d3d9dff30735 Reviewed-on: https://gerrit.libreoffice.org/53149 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-19cppcheck - fix variableScope in some filesGökhan Gurbetoğlu
Reduced the scope of some variables in source. Change-Id: I705e7f2587fd81015f06fb301eb8d4a270668d73 Reviewed-on: https://gerrit.libreoffice.org/53042 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Gökhan Gurbetoğlu <gokhan.gurbetoglu@pardus.org.tr> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-19Colibre icons: update math app iconandreas kainz
Change-Id: I567237f6bd379a0319511dd9dc15843e79da5291 Reviewed-on: https://gerrit.libreoffice.org/53140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-04-19Add help button to signature line dialogsSamuel Mehrbrodt
Change-Id: I984889c374333a7c76dac0221334366cfdf471ee Reviewed-on: https://gerrit.libreoffice.org/53106 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-04-19tdf#42949 Remove unnecessary localization headers from reportdesignGabor Kelemen
Found by searching for the header names and the localization function: git grep -l -e \<core_resource.hxx\> -e \<strings.hrc\> reportdesign/ | xargs grep -c RptResId | grep :0$ | grep -v /pch A few false positives were omitted from the commit. Change-Id: I93a17a3edb2c9ab89a913c92541eafb250086201 Reviewed-on: https://gerrit.libreoffice.org/52910 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-19Colibre icons: update notebookbar icon to hamburger menuandreas kainz
Change-Id: I45cf2ed0a4eed8a879eb7b157c79c3fb06d72dea Reviewed-on: https://gerrit.libreoffice.org/53139 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-04-19comphelper: fix some doxygen tagsChris Sherlock
Change-Id: I75fb71ac88f48d3a821aa8b2cefd395a70cf35bb Reviewed-on: https://gerrit.libreoffice.org/52555 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2024-12-28 09:23:00 +0000