summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-09-24Compensate for loss of Type 1 "Standard Symbols L" substitute for "Symbol"Stephan Bergmann
At least for me on Linux since LO 5.3, 'soffice sw/qa/extras/rtfexport/data/fdo72031.rtf' shows "Å" (rendered in "DejaVu Sans") instead of "⊕" (rendered in "Standard Symbols L"). That's presumably because 47ea13ef8dc8ab9aeded6121845e3ebd1d28b292 "Kill the old Unix layout engines" removed support for Type 1 fonts (see "Ignore Type 1 fonts" in FontCfgWrapper::addFontSet, vcl/unx/generic/fontmanager/fontconfig.cxx), and my (Fedora 25) /usr/share/fonts/default/Type1/s050000l.pfb "Standard Symbols L" is a Type 1 font. So we fell back to fontconfig's generic (weak) suggestion of "DejaVu Sans" as a substitute for "Symbol". So extend our fc_local.conf to suggest our "OpenSymbol" as a substitute for "Symbol". As that fc_local.conf was originally brought along by --with-fonts, which is enabled by default but can be disabled, compilation of fc_local.conf from the various snippets is moved to postprocess. macOS and Windows were never affected, as they both come with a "Symbol" font installed in the system. (And we don't install fc_local.conf on Windows at all.) Change-Id: I8d6d87f24974577fd66f5f3989f606237ebb3d75 Reviewed-on: https://gerrit.libreoffice.org/42670 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-24Updated coreOlivier Hallot
Project: help 2ab31faddac65547ac961da7fc47f0c61dd694b3 Add hungarian to helponline ui Change-Id: Icc1abd566c32f6b873fd979cba2190a9ce959a69 Reviewed-on: https://gerrit.libreoffice.org/42685 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-24tdf#103685: "Commands out of sync" when connecting to MySQL using directJulien Nabet
Thanks to Lionel for his great help Change-Id: Ifcc1d72cca29c031f31da203cd1e3302ea0ea3e3 Reviewed-on: https://gerrit.libreoffice.org/42688 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-09-23ofz#3005 avoid timeoutCaolán McNamara
Change-Id: Ie06504957dab6a5035c7fa3c9313f316303c4eb8 Reviewed-on: https://gerrit.libreoffice.org/42700 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-23ofz#2956: Conditional jump or move depends on uninitialised valueCaolán McNamara
Change-Id: I399c2eb2379b23568dda83f9d41473858f33a802 Reviewed-on: https://gerrit.libreoffice.org/42699 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-23buildscripts section actually needs dedicated repositoriesChristian Lohmaier
Change-Id: I50f080d085dcd303b2cc54f503793f080ea4f50c
2017-09-23coverity#1418341 Dereference after null checkCaolán McNamara
Change-Id: I525895b3a37a52e05a06ad4f2e1663ecd9d7ce52 Reviewed-on: https://gerrit.libreoffice.org/42692 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-23these are cast to sal_Int32 immediatelyCaolán McNamara
Change-Id: I2357ecb5fecd3c232803530fcd131d54e63b85fb Reviewed-on: https://gerrit.libreoffice.org/42695 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-23want to add these together before multiply the resultCaolán McNamara
Change-Id: I5f42ed3d5ad5d64faeb06bbfaaa23d84e81963b0 Reviewed-on: https://gerrit.libreoffice.org/42694 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-23coverity#1418340 Division or modulo by zeroCaolán McNamara
Change-Id: I0941f8db6b406c8ac316daef46b42e4694053410 Reviewed-on: https://gerrit.libreoffice.org/42696 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-23coverity#1418338 Uncaught exceptionCaolán McNamara
Change-Id: I95248e7171910a8acedeedc092754e812103be2e Reviewed-on: https://gerrit.libreoffice.org/42693 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-23normalize -> styleCaolán McNamara
Change-Id: I10895e686c7f583dd3d4a002b878f4499d15efa3 Reviewed-on: https://gerrit.libreoffice.org/42697 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-23iOS, update distrojan Iversen
Added copy of autogen.input that works for arm64 and simulator. Some of the disabled libraries might work, that is future work. Change-Id: I7df3491872a1f13110dd49655fdc0a4ede3bfa28
2017-09-23iOS, dummy avmedia to satisty sdi filesjan Iversen
if disable_avmedia is defined, change avmedia to a dummy module. libreOfficeLight links ! Change-Id: Ibb41ed3ba48cc3143f17000f1c6073611c798e53
2017-09-23tdf#112089 add charts to the ShapeMapSzymon Kłos
Charts weren't added to the collection what resulted in missing ids during export (target field). Change-Id: Ie96a4e33a52c5448342a3c3dcec0d8e8b244e270 Reviewed-on: https://gerrit.libreoffice.org/42552 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-09-23ofz#3467 mul and div are the sameCaolán McNamara
so can just pass the values through Change-Id: I793ea0fd5fec00fc942b3b5a5c17c483ec2df267 Reviewed-on: https://gerrit.libreoffice.org/42675 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-23coverity#1418337 Unchecked dynamic_castCaolán McNamara
Change-Id: Ic7c7030687d39e35610f7aa14555d8b19b11acea Reviewed-on: https://gerrit.libreoffice.org/42681 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-23Watermark: apply when new page style is createdSzymon Kłos
Change-Id: I0d0103f8cc351ec87f7c3bf936ef4725a166d315 Reviewed-on: https://gerrit.libreoffice.org/42581 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-09-23iOS, simplified build demandsjan Iversen
moved iOS build demand to same location as other os. Change-Id: If235aff2af7b58b26b94cb6818404100fa50d2d8
2017-09-23tdf#86083 Restore old operation buttons but have them hiddenYousuf Philips
Change-Id: I7d006d3d5e22ade59ddfe46f21fbc777a1c75dac Reviewed-on: https://gerrit.libreoffice.org/42684 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-09-23tdf#103733 Unify master doc menu and toolbars with writerYousuf Philips
Change-Id: I1f6ce6c98cd7087ccb874001c29a8532cd7ed360 Reviewed-on: https://gerrit.libreoffice.org/42108 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-09-23cid#1418339: resource leakJulien Nabet
Change-Id: I87374e32e787f58aa5e4d1b6a78fcd1dddcccdf6 Reviewed-on: https://gerrit.libreoffice.org/42680 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-23vcl: no need to have dispose() hereTakeshi Abe
Inlining it in dtor is enough. Change-Id: I20769f4b0af51103dd8fb2c5d24ee5e6ef2be1f8 Reviewed-on: https://gerrit.libreoffice.org/42634 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-23vcl: Drop a couple of unused member variablesTakeshi Abe
Its usage was gone at df6ba2adbaeea9c5abe6e3ea0a583ec78ca9e7bd. Change-Id: Ia153cb8fb9247818684be09a81ac5eabdb1120e4 Reviewed-on: https://gerrit.libreoffice.org/42682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-23loplugin:flatten in svl..svxNoel Grandin
and implement a check in the plugin to prevent us modifying the same patch of source code twice. This logic should probably be moved into plugin.cxx at some point. Change-Id: I7ebff6424cc8733bb2c8f7dba75eaaec68649290 Reviewed-on: https://gerrit.libreoffice.org/42660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-23loplugin:flatten in sdext..stocNoel Grandin
Change-Id: I460e813e20a691c53738373376d3363f553bbab2 Reviewed-on: https://gerrit.libreoffice.org/42636 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-23new loplugin unnecessarycatchthrowNoel Grandin
Change-Id: Iabab71ee076227bc38447ec109afaea1e53a86a6 Reviewed-on: https://gerrit.libreoffice.org/42643 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-23tdf#106781 Enable a few hidden items in writer styles toolbarYousuf Philips
Change-Id: I8c2131f31e98e1cf6c790d446ddd84b17507d0ee Reviewed-on: https://gerrit.libreoffice.org/42679 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-09-23Fix typoAndrea Gelmini
Change-Id: I970201eb99c56db3ac5fefb9e113c0bb3b8c754b Reviewed-on: https://gerrit.libreoffice.org/42678 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-23sw: actually SetTableNode() ought to always be called before deleteMichael Stahl
Change-Id: I5e830e91ae7c773ad3945550c640a190b6504796
2017-09-23sw: fix crash on loading tdf109006-1.odtMichael Stahl
~SwDDETable() accesses its boxes' start node but that follows the SwTableNode and SwNodes::RemoveNode() counts backwards so the box nodes are all dead. This was always broken but spontaneously started to crash today. Because dtors don't have parameters, resort to a little subterfuge to ensure ~SwDDETable() finds out where it is. Change-Id: Id681005989dd1e9f2611e8c99841927a7c5f6bfa
2017-09-22Use const reference instead of copyEike Rathke
Change-Id: Idf5239e2037dcfa808e016a726f5a980d862ede6 Reviewed-on: https://gerrit.libreoffice.org/42669 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-22GraphicExportFilter: adding FilterData defaults is unnecessaryEike Rathke
... now that we use the proper dialog that sets the proper filter properties. Change-Id: Iabc3e4b2c13b60bccc0b596a851109df32fe535c Reviewed-on: https://gerrit.libreoffice.org/42668 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-09-22Apply replaceFirst() only onceEike Rathke
It's unnecessary to call if a replacement was already done and might even harm, though unlikely. (e.g. file extension "web") Change-Id: I6615c9a31178770429b523e0ee878661f1b2b6e8 Reviewed-on: https://gerrit.libreoffice.org/42667 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-22Group member variables and functions and fix naming nitpicksEike Rathke
Change-Id: Ie0b13c0ed4657200b6c92ae66ea25093e35a6c8f Reviewed-on: https://gerrit.libreoffice.org/42666 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-22No using namespace in header fileEike Rathke
And using namespace css is sufficient, it's actually good to see some namespace.. Change-Id: I8cd3418e04769bb2fd1c632d6d671b368aae06b3 Reviewed-on: https://gerrit.libreoffice.org/42665 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-22Export to PNG: selected shapes via drawing::GraphicExportFilter, tdf#108317Eike Rathke
Change-Id: Id09d9b21b2e6c018dd199a1911a9125c118abec2 Reviewed-on: https://gerrit.libreoffice.org/42658 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-09-22Move implementation to filterRenderDocument()Eike Rathke
Change-Id: I632a26c5f149fabbe3a4a1186bfbe822fff0ea24 Reviewed-on: https://gerrit.libreoffice.org/42656 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-22Remember XComponentContextEike Rathke
Change-Id: I52847249b3e17a31f6c6bf76af7bfe91a414d072 Reviewed-on: https://gerrit.libreoffice.org/42657 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-09-22Check availability of XPageCursorEike Rathke
Change-Id: I458655d52992e40c2330ec10628fcea0fdc00f76 Reviewed-on: https://gerrit.libreoffice.org/42655 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-22GetGraphicSource: use DocumentToGraphicRenderer::isShapeSelected()Eike Rathke
Change-Id: I50852360a29b4d5fd08277fcb2198f7956f9ebe0 Reviewed-on: https://gerrit.libreoffice.org/42654 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-22Introduce DocumentToGraphicRenderer::isShapeSelected()Eike Rathke
Change-Id: I66fc0e39a7a35969b937253c88326516949ea7e7 Reviewed-on: https://gerrit.libreoffice.org/42653 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-22Remove include of converters.hxx from precompiled_drawinglayer.hxxMike Kaganski
Commit cf48347e7a56c38c000e657965f25f4c7e7b4803 didn't take into account commit 632edfabe8065cd59a237d975ee03468ce4d868b landed before it. Change-Id: I108027a460943b14194adcff4af2a41b7720f3be Reviewed-on: https://gerrit.libreoffice.org/42677 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-22android: bump support library & buildtools/SDK versionsChristian Lohmaier
also add google maven repo, since "The support libraries are now available through Google's Maven repository. We no longer support downloading the libraries through the SDK Manager, and that functionality will be removed soon.." https://developer.android.com/topic/libraries/support-library/setup.html Change-Id: Ica0a2542903f60c7bffa1daa2409b60422bde88f
2017-09-22Fresh run of bin/update_pch.shMike Kaganski
Change-Id: I69d4157aaf6570cecd51ea59df20556914942e06 Reviewed-on: https://gerrit.libreoffice.org/42565 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-22Windows: avoid dependence on UNICODE define; prefer W functionsMike Kaganski
Change-Id: I95b90128e93f0d88ed73601bcc5a7ca9279d4cf1 Reviewed-on: https://gerrit.libreoffice.org/42560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-22Put definition of _CRT_RAND_S into bin/update_pchMike Kaganski
so it doesn't get removed again from sal/inc/pch/precompiled_sal.hxx (see commit 4af9612f2be9e023e762831207cbdb1d5f25906f). Also make necessary changes to some of the files that start to fail building after running bin/update_pch.sh, so that the patch is self-contained and leaves the tree in fully functional state. tools namespace had to be prepended with :: to disambiguate from drawinglayer::tools vcl/inc/window.h includes were amended, because ExtTextInputAttr is from vcl/commandevent.hxx, and enum class ShowTrackFlags is from vcl/window.hxx Change-Id: I47179622350754cba2f95d26a1bafd3dfbbc935b Reviewed-on: https://gerrit.libreoffice.org/42559 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-22vcl: [loplugin:badstatics] pManagerMichael Stahl
Move this to class GenericUnixSalData, which is deleted on shutdown. Change-Id: I6366c12f255bfeca737b22259c3f58ffa2c6222c Reviewed-on: https://gerrit.libreoffice.org/42632 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-22move TestImportOLE2 where it can be used by fftesterCaolán McNamara
Change-Id: I7b41d9ec673cfb96f51b5008540df63fe78a7581 Reviewed-on: https://gerrit.libreoffice.org/42639 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-22ofz#3466 avoid oomCaolán McNamara
Change-Id: I79f7390dda9c087ae4bc5af9855b72e888e284a1 Reviewed-on: https://gerrit.libreoffice.org/42641 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>