summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-01-29use unique_ptr in ScDataPilotFieldObjNoel Grandin
Change-Id: I351999f92b83e156ffe62e02c851050d4621fe7e Reviewed-on: https://gerrit.libreoffice.org/67048 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-29ofz: reduce max_len for metCaolán McNamara
Change-Id: If81ee19dd0127f48b9e57bf420323927c5981840
2019-01-29tdf#123013: Allow to change trendline name in gtk3Xisco Fauli
Change-Id: I3eeb6b8e27cced0a8a86969368f48a2af8ac5892 Reviewed-on: https://gerrit.libreoffice.org/67026 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-29ofz#11104 for timeouts, limit decompression ratios when fuzzingCaolán McNamara
Change-Id: If9efe56a40a866269a06ce944885a324495af48a Reviewed-on: https://gerrit.libreoffice.org/67036 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-29Remove some kde4 leftoversMichael Weghorn
The kde4 VCL Plugin was removed with 6ca3b3648e25ae9d4d2d29a0df83349198ec3f5e, so drop some now superfluous leftovers. Change-Id: I92887b679462a6ac22c3668a24ec6a9fdee8fac1 Reviewed-on: https://gerrit.libreoffice.org/67047 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-01-29tdf#123011 Detect kde5 desktop in Plasma Wayland sessionMichael Weghorn
Both env variables 'KDE_FULL_SESSION' and 'KDE_SESSION_VERSION' are set in both X11 and Wayland sessions for Plasma 5 (kde5), s.a. https://userbase.kde.org/KDE_System_Administration/Environment_Variables, so drop the alternative X-specific check. Move the check for a kde5 upward, so that kde5 is actually detected in a Plasma 5 Wayland session, rather than falling back to assuming GNOME. Change-Id: Ieb5b47272f375ceed4d44a2ccc5b517222ae86b9 Reviewed-on: https://gerrit.libreoffice.org/67044 Reviewed-by: Tomáš Chvátal <tchvatal@suse.cz> Tested-by: Tomáš Chvátal <tchvatal@suse.cz> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-01-29Add XServiceInfo tests to ScFilterDescriptorBaseJens Carl
Change-Id: I5063d29baa5e4140d2be35684eed746ae28c2cf5 Reviewed-on: https://gerrit.libreoffice.org/67040 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-29tdf#122430 RTF import: fix lost font size on footnote startMiklos Vajna
This become more visible since commit 49614a9ea971ff7f370f863ce8a2735aab973cee (tdf#119599 RTF import: fix missing deduplication of font size, 2018-09-24) as now incorrect font size from style affects the rendering result. Change-Id: I5b339337f021e2fc359f6fc5f5aa2ed0bcf844b9 Reviewed-on: https://gerrit.libreoffice.org/67034 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-29tdf#106463 set new firebird connections as autocommit by defaultLionel Elie Mamane
as per SDBC specifications Change-Id: I132a8e565468bcacf0fa5ee0dfb62bf0dd717e24 Reviewed-on: https://gerrit.libreoffice.org/67015 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2019-01-29Simplify containers iterations in sc/source/filter/[d-e]*Arkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: I7be6568641e154e74ff7bde812da9a8e67790a7f Reviewed-on: https://gerrit.libreoffice.org/66972 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-29Sifr icon: add cmd/32px svg icons and update the png outputandreas kainz
Change-Id: I2da45245f65e3c693a87dfa6026b8c4bb3fc0f6e Reviewed-on: https://gerrit.libreoffice.org/67037 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-01-29o3tl::make_unique -> std::make_unique in scGabor Kelemen
Since it is now possible to use C++14, it's time to replace the temporary solution with the standard one Change-Id: Ib69a4a2a08b1edbc0f40beac00f7f68075b479a1 Reviewed-on: https://gerrit.libreoffice.org/66967 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-29loplugin:flatten in svgioNoel Grandin
Change-Id: I3276c2c368c755e070fd8b19a15a954948a68df7 Reviewed-on: https://gerrit.libreoffice.org/67008 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-29loplugin:flatten in stoc..storeNoel Grandin
Change-Id: Ib8c86179a3d13852cbb02b389b6103aca5456dba Reviewed-on: https://gerrit.libreoffice.org/67013 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-29Fix typoAndrea Gelmini
Change-Id: Ie64a300a73db666231ae7b37f15e5d7556e594bc Reviewed-on: https://gerrit.libreoffice.org/67039 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-29tdf#45904 Move XPropertySet Java tests to C++Jens Carl
Move XPropertySet Java tests to C++ for ScFilterDescriptorBase. Change-Id: I86a16f3c53a5aacea0ce88a54ec8b340d13dff4f Reviewed-on: https://gerrit.libreoffice.org/67038 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-29Improve ODF enhanced-path command moveTo to follow specRegina Henschel
ODF 1.2 section 19.145 says 'If a moveto is followed by multiple pairs of coordinates, they are treated as lineto.' The patch does this on import. Change-Id: Ib493ca49288cdb2d34b7ee801bd052281617d2e8 Reviewed-on: https://gerrit.libreoffice.org/66888 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-01-29tdf#45904 Move XSimpleText Java tests to C++Ajay Mahato
Change-Id: I6232615f15b52a1f004a13ed97fc0b8002a22269 Reviewed-on: https://gerrit.libreoffice.org/66694 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-29Rename ScFilterDescriptorBaseObj to ScFilterDescriptorBaseJens Carl
Rename ScFilterDescriptorBaseObj to ScFilterDescriptorBase so it matches the object name we test against. Change-Id: Ia5ce59997e99b2b537e50ddfeaa9d96b2b55555f Reviewed-on: https://gerrit.libreoffice.org/67033 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-28libgpg-error: use custom soname and symbol versionMichael Stahl
The hope is that this should allow both system's libgpg-error.so.0 and LO's bundled libgpg-error-lo.so.0 to be loaded by soffice.bin without unintended hilarity. Change-Id: I94498097a847b9756de86051798cb4ce022f6c83 Reviewed-on: https://gerrit.libreoffice.org/67012 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-01-28Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' - tdf#121571 Solve cognitive dissonance with note icons and colors More often than not, the alarmist colors given to note boxes didn’t match their content. Change-Id: I88d7a8e2d07ffba661c218887fd54638506d21c8
2019-01-28split basegfx 2d tests to separate files (one per tested class)Tomaž Vajngerl
Change-Id: Icb2f745851ba3de31f6a672d1bc20659de687d2e Reviewed-on: https://gerrit.libreoffice.org/67031 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-01-28basegfx: just use the std::clamp for clamping the inputTomaž Vajngerl
Change-Id: Ia7d6c103956c8e3cebd6ebe656fd88586d33a9c8 Reviewed-on: https://gerrit.libreoffice.org/67032 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-01-28Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' - Drop this pitiful, bothersome, gimmicky animation Change-Id: If533f8565e38e02d503cc1ab59f65e2445f1369b
2019-01-28Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' - A couple of articles and tag vomit cleanup Change-Id: I5e3d9c7f9ce78807d1acfa190a740f41ddd8a378
2019-01-28Resolves: tdf#122949 gtk_style_context_save doesn't work the way I wantCaolán McNamara
so write something that does Change-Id: I294b9288af0ddf49cbb5a8a69b4509e1ae03d9b8 Reviewed-on: https://gerrit.libreoffice.org/67018 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-28Resolves: tdf#123019 give modal dialog a parentCaolán McNamara
Change-Id: I669d8cb18ed78fcdb50aa3f452661500d75ad880 Reviewed-on: https://gerrit.libreoffice.org/67021 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-28Resolves: tdf#122992 allow pre-selected fonts not in the font listCaolán McNamara
Change-Id: I75c1b6d3933a5773d9e1dce40744c2342ab63ee8 Reviewed-on: https://gerrit.libreoffice.org/67024 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-28Resolves: tdf#122991 do not truncate time duration [] format valuesEike Rathke
Regression from commit e2e47898180e547cad7ccde1e5890385d573e551 CommitDate: Fri Aug 31 12:50:52 2018 +0200 Use tools::Time::GetClock() in number formatter for wall clock time This partly reverts the change for the affected time duration [] formats, which truncated the value within the magnitude that due to the imprecision of floating point values lead to "false" precision of h:m:s.999999... This might again yield imprecise display values (old behaviour) for a difference of two wall clock times that now are not rounded up into the next magnitude for display. If so, a tools::Time::GetDuration() might be appropriate. Change-Id: If8fbcc2e4c2e0da04ca742a2837f57cd313d0367 Reviewed-on: https://gerrit.libreoffice.org/67005 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-01-28tdf#122942 sw: update shape insert UI for the AddVerticalFrameOffsets optionMiklos Vajna
Regression from commit 50223ea6e212b60b7d33839c2753c5601fb50f95 (tdf#98987 sw: add AddVerticalFrameOffsets compat mode, 2016-03-31), SwFEShell::ImpEndCreate() was not adapted to call SwTextFrame::GetBaseVertOffsetForFly() when determining the vertical position of the inserted shape. The call can be unconditional, the returned value is already 0 when the DocumentSettingId::ADD_VERTICAL_FLY_OFFSETS compat setting is false. Change-Id: Iec6af5a6d1ff3466e08377853cc8ca84f33a76d1 Reviewed-on: https://gerrit.libreoffice.org/67017 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-01-28Resolves: tdf#122930 paper tray is to update on focus-inCaolán McNamara
which adds the problem that GtkComboBox doesn't send a focus-in, but its toggle does, to find and use that instead Change-Id: I18d46511bf2e6997539a8413f574a94b24b4583f Reviewed-on: https://gerrit.libreoffice.org/67009 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-28It's called libatomic_ops not libatomic-opsStephan Bergmann
cf. <https://github.com/ivmai/libatomic_ops/> (as mentioned in external/libatomic_ops/README) Change-Id: Ibd50ca81695cbcd73e005b0bbbd46ceb62b1e9dc Reviewed-on: https://gerrit.libreoffice.org/66912 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-28Upgrade libatomic_ops to latest libatomic_ops-7.6.8.tar.gzStephan Bergmann
...from <https://github.com/ivmai/libatomic_ops/wiki/Download>. (The md5sum given there is 99128f05e3e3f4e0cd39aa23f23bbe0c.) The old version of external/libatomic_ops failed to build at least when building a Flatpak for aarch64, see <https://flathub.org/builds/#/builders/39/builds/702/steps/5/logs/stdio>: [...] > Making all in src > Making all in atomic_ops > Making all in sysdeps > In file included from atomic_ops_stack.h:32, > from atomic_ops_malloc.c:20: > atomic_ops.h:343:4: error: #error Cannot implement AO_compare_and_swap_full on this architecture. > # error Cannot implement AO_compare_and_swap_full on this architecture. > ^~~~~ > atomic_ops.c:97:1: error: unknown type name ‘AO_TS_t’; did you mean ‘AO_TS_T’? > AO_TS_t AO_locks[AO_HASH_SIZE] = { > ^~~~~~~ > AO_TS_T [...] (cf. <https://github.com/flathub/org.libreoffice.LibreOffice/pull/67/commits/ 48b22dbabc06f1822df74f755096cf0ea5ba2499> "Upgrade libatomic_ops to latest libatomic_ops-7.6.8.tar.gz") Change-Id: Icc040cc47f45f71577995a2ff9c63df97150bdea Reviewed-on: https://gerrit.libreoffice.org/66983 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-28ofz#12729 integer-overflowCaolán McNamara
Change-Id: I78db6ab6fcc677247716f42d3c102314415c34d2 Reviewed-on: https://gerrit.libreoffice.org/66993 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-28aarch64 and arm need libatomic_opsStephan Bergmann
(cf. LO's configure.ac, needed for external/firebird on non-x86[-64]), but org.freedesktop.Sdk//18.08 apparently doesn't provide it (while org.freedesktop.Sdk//1.6 apparently did) (cf. <https://github.com/flathub/org.libreoffice.LibreOffice/pull/67/commits/ b2762523a4678bedd55c11db232868cbaf9c7bdd> "aarch64 and arm need libatomic_ops") Change-Id: I6eb060251ce85bfd399b72d9c90a93497a3a9029 Reviewed-on: https://gerrit.libreoffice.org/66987 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-28org.freedesktop.Sdk//18.08 `uname -i` always returns "unknown"Stephan Bergmann
(cf. <https://github.com/flathub/org.libreoffice.LibreOffice/pull/67/commits/ deda15380b436ca8fe62e2ebc1feec8bcb6dd43e> "org.freedesktop.Sdk//18.08 `uname -i` always returns 'unknown'") Change-Id: Id158d769edb07aa09189907d120cb1e9cd8d9b17 Reviewed-on: https://gerrit.libreoffice.org/66985 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-28Fix misplaced Scale checkboxKatarina Behrens
regression from weld-ing this tabpage Change-Id: Id79ff793842982e9dba79478ad7da23ea17f97c3 Reviewed-on: https://gerrit.libreoffice.org/66989 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-01-28tdf#122997 Canceling Paragraph dialog causes crashNoel Grandin
regression from commit bf359d01ac8b1e0292e8a92c38e58c03e6c17d8b add a Dialog::runAsync for the non-controller case Change-Id: I02e3f62b8304139003af1c137ea59750afb4be4c Reviewed-on: https://gerrit.libreoffice.org/66988 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-28sw: avoid wrong and unnecessary downcast in SwDrawView::DeleteMarked()Miklos Vajna
/sw/source/core/draw/dview.cxx:967:39: runtime error: downcast of address 0x6060006d1cc0 which does not point to an object of type 'SwDrawContact' 0x6060006d1cc0: note: object is of type 'SwFlyDrawContact' 1d 02 00 2e b0 3e 06 87 15 7f 00 00 18 3f 06 87 15 7f 00 00 50 1c 28 00 50 61 00 00 00 00 00 00 ^~~~~~~~~~~~~~~~~~~~~~~ vptr for 'SwFlyDrawContact' #0 0x7f157de946d8 in SwDrawView::DeleteMarked() /sw/source/core/draw/dview.cxx:967:39 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /sw/source/core/draw/dview.cxx:967:39 in When executing testPasteListener in CppunitTest_sw_unowriter since commit 2a054445f09e8ba66e7cfb9f1d598554b555772d (sw paste listener: expose pasted images as well, 2019-01-24), though that code was added much earlier in commit 33141f999b22ce10cdbfbd76081fff211c4b5067 (SwDrawView::DeleteMarked: delete textbox of shape as well, 2014-06-23), just no testcase invoked it. Change-Id: I22a384ab7cc4b3eb00198b28de294896c2d1e3bb Reviewed-on: https://gerrit.libreoffice.org/66986 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-01-28avoid a calc threads assert because of an undetected cyclic dependencyLuboš Luňák
ooo#103156-1 has a quite complex cycle of cells, some of them (and only some) in formula groups. And the complex Interpret() nesting confuses its cycle detection into believing that Interpret() can simply return without providing a value, which is ok if it's called from dependency checking of threaded calculation, but is not ok when it's called for a single cell evalution. So make the code set cyclic-dependency error even when it's possibly inside dependency checking, since if it's really that case, the error will be later overwritten by the actual value. This is still not a completely correct fix, as the document on repeated hard recals alternates some cells between correctly reporting an error and providing some bogus values (e.g. column S in the second sheet). But the document uses iteration, which complicates all this stuff even more, and after spending quite some time on this I'm still not sure on how to fix that. So at least for now, at least avoid the assert. Change-Id: I395f97d104d98b5c043d1f17878338d3f1b31146 Reviewed-on: https://gerrit.libreoffice.org/66911 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-01-28sw: prefix members of SwTableAutoFormatMiklos Vajna
Change-Id: I17515ea4e444986f50d554c864540a625a521970 Reviewed-on: https://gerrit.libreoffice.org/66984 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-01-28both branches have a common pieceCaolán McNamara
Change-Id: I1fd28f7dc0911bfdb8fd46aee91c3a81ce034ba6 Reviewed-on: https://gerrit.libreoffice.org/66899 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-28o3tl::make_unique -> std::make_unique in sax...svtools (except sc)Gabor Kelemen
Since it is now possible to use C++14, it's time to replace the temporary solution with the standard one Change-Id: I6eea0877eaa1886b64c0cce06a43b8088cbccd8e Reviewed-on: https://gerrit.libreoffice.org/66751 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-28Fix typoAndrea Gelmini
Change-Id: I372918497b91bd2da0432df7b27795cbf29dc6b8 Reviewed-on: https://gerrit.libreoffice.org/66982 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-28Fix typoAndrea Gelmini
Change-Id: If648e007a6db44e26021c12ac919d81ccceaa081 Reviewed-on: https://gerrit.libreoffice.org/66981 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-28Fix icon load error for uno commands with paramsMuhammet Kara
Change-Id: I31e4c28322a3492a603bce5c7226e2dbcf131173 Reviewed-on: https://gerrit.libreoffice.org/66980 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-27Bail out earlyMatteo Casalin
Change-Id: I7851f4952ca2c863d92fd14fa19005ed35634033 Reviewed-on: https://gerrit.libreoffice.org/66941 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-01-27tdf#122990: return if no mpMenuBarContainerWidget in ApplyPersonaJulien Nabet
Related to patches for tdf#122241 Change-Id: I0ce46a3a362855aaa6c11f375d20c2212f1cb20b Reviewed-on: https://gerrit.libreoffice.org/66973 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-27Could not determine MSC version with French UIJulien Nabet
Fix regexp for cl.exe This command returns some special characters preventing regexp to work. For more details, see: http://document-foundation-mail-archive.969070.n3.nabble.com/Could-not-determine-MSC-version-Visual-Studio-2017-td4256538.html Change-Id: I734dcd533b0f38430d1be8852f1e4f721221e580 Reviewed-on: https://gerrit.libreoffice.org/66959 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-27Use indexed getTokenMatteo Casalin
Change-Id: I7c0bb328def955efce7b3866776e4d47a0ba32c0 Reviewed-on: https://gerrit.libreoffice.org/66947 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
generated by cgit (git 2.34.1) at 2025-01-22 12:49:35 +0000