summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-02-15weld ScDPSubtotalDlgCaolán McNamara
Change-Id: I33403031421a9f372c240cddea320591ac72bfc2 Reviewed-on: https://gerrit.libreoffice.org/67878 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-15weld ScDPSubtotalOptDlgCaolán McNamara
Change-Id: I986346fa26f397fee6f0a2d9d724a1bdfb2e4220 Reviewed-on: https://gerrit.libreoffice.org/67872 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-15BitmapColor string representation - fix proper paddingTomaž Vajngerl
Change-Id: I42727152e71b2dce4c2b5ce71f9a54464388a7fb
2019-02-15disble test of rendering BitmapEx with alpha on Windows for nowTomaž Vajngerl
Tinderboxes fail, but Jenkins was fine so we must have problems with rounding errors in some code paths. Change-Id: I38a457c0ee7a079bebaa599794b0e65c433dfe64
2019-02-15work around Werror=format-truncation in onlineupdate for nowMarkus Mohrhard
Change-Id: I6230cc8c76313b5d180ef3fbebec4bc20b794150 Reviewed-on: https://gerrit.libreoffice.org/67879 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2019-02-15Mention that temporaryHackToInvokeCallbackHandlers() is for LibreOfficeLightTor Lillqvist
Change-Id: I0b53fea8df48bea17c56678d6d9b7d43c571d0a1
2019-02-15weld ScImportOptionsDlgCaolán McNamara
Change-Id: Ib8ea4726d20f0bd7f40283983fec2d5890fac382 Reviewed-on: https://gerrit.libreoffice.org/67869 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-15weld ScDPDateGroupDlgCaolán McNamara
adding a weld::Calendar and a pretty menubutton to access it, sidestepping the difficulty of abusing a spinbutton to select a date. The prettiness is wasted on this hard to find obscure dialog Change-Id: I51d461fe0220f947c106d96965e6422b4b26575b Reviewed-on: https://gerrit.libreoffice.org/67863 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-15sw btlr writing mode: implement DOCX filterMiklos Vajna
Replace the old trick with character-level rotation with the usage of the new writing direction. This means that finally table cells with btlr text direction and multiple paragraphs show all content, not only the first paragraph, as before (seen as data loss by users). Change-Id: I094f36fa6ba0701579e487e8e0212707987b1b2f Reviewed-on: https://gerrit.libreoffice.org/67870 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-15Disable automatic border creation in swSamuel Mehrbrodt
This "feature" would convert "___" to a full width paragraph border. See e.g. https://ask.libreoffice.org/en/question/15711/stop-auto-line-formatting/ for problems caused by this. So I strongly suggest to turn this "feature" off by default. Change-Id: Ib0f650e408711e3409a5066f4c0941d2eb300787 Reviewed-on: https://gerrit.libreoffice.org/67865 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-02-15tdf#40780 extend default media duration from 0.01s to 0.3s.Mark Hung
Player can only update the duration when the state of the GStreamer pipeline changes. But GStreamer need some time to get ready. However the default duration (0.01s) is so short that the audio node is deactivated before the duration update. Hence I just pick up a value that is long enough to allow update happen empirically. Change-Id: If94133fde09e414bd9ea3c4b162a13d5c70f4524 Reviewed-on: https://gerrit.libreoffice.org/67783 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2019-02-15Adopt odk configure to new java 6 baselineSamuel Mehrbrodt
Change-Id: I015f439b04ddbc337a1c0b000fa708686d1f83bb Reviewed-on: https://gerrit.libreoffice.org/67751 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2019-02-15Fix build without HAVE_FEATURE_AVMEDIATor Lillqvist
Change-Id: I65d16c3561fa6fd83aa37cb12ae4fd931d03029f
2019-02-15loplugin:flatten in sd/source/coreNoel Grandin
Change-Id: Ide9a83e5baaef24fcbd2b2fa8fb89abdf5f8ce77 Reviewed-on: https://gerrit.libreoffice.org/67838 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/filterNoel Grandin
Change-Id: I4f4b32e8bbe7601f10724c519226d06b04838e72 Reviewed-on: https://gerrit.libreoffice.org/67837 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/ui/[a-c]*Noel Grandin
Change-Id: I7e568e563d2097c7052dfd406396335f5ae36170 Reviewed-on: https://gerrit.libreoffice.org/67836 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/ui/d*Noel Grandin
Change-Id: I0879c98e92a482fb6733099057305c3283830075 Reviewed-on: https://gerrit.libreoffice.org/67835 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15sw btlr writing mode layout: fix multiple paragraphsMiklos Vajna
aVerticalLeftToRightBottomToTop was wrong, it mapped from physical to logical, and it should be the other way around. In practice this means that when SwTextFrame::AdjustFrame() is invoked for a second lower, then nAdd will be a small positive (and not a large negative) number, so the warn:legacy.osl:20827:20827:sw/source/core/text/frmform.cxx:479: Ey warning goes away and the second lower becomes visible. Change-Id: I894fef4a89b1feeb333537ff7d76793130007ed8 Reviewed-on: https://gerrit.libreoffice.org/67862 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-15Simplify containers iterations in oox, opencl, packageArkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: I91405920d91383bc6cf13b9497d262b1f6f0a84d Reviewed-on: https://gerrit.libreoffice.org/67848 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15SourceManager::getExpansionRange already returns CharSourceRange since Clang 7Stephan Bergmann
Change-Id: Ic7c6c648c71203116ca074bd7392a48ff850cd51 Reviewed-on: https://gerrit.libreoffice.org/67864 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-02-15loplugin:simplifybool extend to !(a == b) where comparison an overloaded opNoel Grandin
Change-Id: I08fcbe2569c07f5f97269ad861fa6d38f23a7cc7 Reviewed-on: https://gerrit.libreoffice.org/67816 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15Initialise an integer to 0, not falseTor Lillqvist
Change-Id: I9d85f6a86d96353312bb00aeb1c173fa9fdfefda
2019-02-15Remove unused importSamuel Mehrbrodt
Forgot to remove in e756b6f310f309ac29bb2bce92309bb74edd788d Change-Id: I8e736726f81d87406473cd43e94870205d0f6902 Reviewed-on: https://gerrit.libreoffice.org/67855 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-02-15Update git submodulesStephan Bergmann
* Update helpcontent2 from branch 'master' - tdf#121532 Don't use non-standard `echo -n` At least the version of echo used to build TDF's LO 6.2.0.3 release apparently doesn't understand that non-standard option and printed out "-n" verbatim, generating a broken languages.js. (Though my local macOS 10.14.3 /bin/echo does understand that option.) Change-Id: I7233fa5c6e7851c5086c428a67aaee71604061e1 Reviewed-on: https://gerrit.libreoffice.org/67858 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-15tdf#42949 Fix IWYU warnings in registry/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I819bb44e36bdb6ec671cf11bd779085767d82fd0 Reviewed-on: https://gerrit.libreoffice.org/67697 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-15tdf#123474: use INetURLObject methods to construct valid URIMike Kaganski
This ensures that no extra slashes are added to the path when it already ends with a slash; for Windows drive root path (e.g. C:\) the trailing slash is always kept to not change the meaning to "current path on the drive", which is different from "root of the drive". Our IsValidFilePath does not allow more than one slash after <drive:>. Change-Id: Ife3cd9e146573a0c278834f795f0d7318c2d303a Reviewed-on: https://gerrit.libreoffice.org/67850 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-15move Calendar to vcl and map to GtkCalendarCaolán McNamara
Change-Id: I1784d4d69c6c069ef1b0ad6412e83e6a0b1db12a Reviewed-on: https://gerrit.libreoffice.org/67840 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-15Add a FIXME noteTor Lillqvist
Change-Id: Iedda7ca9cff1bda763845e665e0e21656b253793
2019-02-15Interpret the parameter of WordBasic.FileClose() more correctlyTor Lillqvist
In particular, the value 2 means "do not save". Change-Id: I9788d201f8ecfcc016a12aa2088552ee994e1c17
2019-02-15loplugin:flatten in sd/source/ui/frameworkNoel Grandin
Change-Id: Id1da25f6ee6ee867e93e0b4c58b6429e07b12429 Reviewed-on: https://gerrit.libreoffice.org/67834 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/ui/funcNoel Grandin
Change-Id: I1d5d3ea51d012ade653aef70a17f2c173d31d3b9 Reviewed-on: https://gerrit.libreoffice.org/67833 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15CppunitTest_sw_layoutwriter: disable testBtlrCell() on Windows, tooMiklos Vajna
Till it's clear why it has unexpected values. Report from mailing list: > Test name: SwLayoutWriter::testBtlrCell > equality assertion failed > - Expected: 2707 > - Actual : 2710 > - In <>, attribute 'y' of '//textarray[1]' incorrect value. Change-Id: Ic914f513df544dcf472b0870a3936f87d876c76b Reviewed-on: https://gerrit.libreoffice.org/67856 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-15xmloff: create XMLImpressStylesExportOasis instances with an uno constructorMiklos Vajna
Change-Id: I831321bcce241bc180e22b20364137f776fee0f9 Reviewed-on: https://gerrit.libreoffice.org/67847 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-15loplugin:flatten in sd/source/ui/slidesorterNoel Grandin
Change-Id: I001e0957dafee168bb997a0673be64b2e92cb658 Reviewed-on: https://gerrit.libreoffice.org/67830 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15Format anchor.cxx with clang-formatSamuel Mehrbrodt
It has nearly correct formatting already, lets keep that. Change-Id: I0b3b7baf69655cb3241ba039b181b0d8262a3f55 Reviewed-on: https://gerrit.libreoffice.org/67845 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-02-15tdf#122982 Remove image from cell when cutting the cellSamuel Mehrbrodt
Change-Id: Idd73dcc88a8cd76eb4011bb26efdd5c712d16e5e Reviewed-on: https://gerrit.libreoffice.org/67844 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-02-15loplugin:flatten in sd/source/ui/sidebarNoel Grandin
Change-Id: I1a636fdfc505e7927b8833ad55110f6ed8fe360d Reviewed-on: https://gerrit.libreoffice.org/67832 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/ui/slideshowNoel Grandin
Change-Id: Id820f0f7ac51928ba1a783615c3e9d6c268affdd Reviewed-on: https://gerrit.libreoffice.org/67831 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/ui/[t-u]*Noel Grandin
Change-Id: I6db7c26c9534b249a38cec96f3875f808702a598 Reviewed-on: https://gerrit.libreoffice.org/67829 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/ui/viewNoel Grandin
Change-Id: I28e75ec162cde89fe1aa7d85aecce7ce80878d88 Reviewed-on: https://gerrit.libreoffice.org/67828 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15tdf#97575 Chart OOXML: Export ShapeProps of Error BarsBalazs Varga
Export the shapeProps (fillstyle, linestyle, linewidth, linecolor etc.) of the Error Bars to OOXML. Change-Id: Iff74fa463fdd0fb6ed95e4d1bf0d3e906349860c Reviewed-on: https://gerrit.libreoffice.org/67825 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-02-15Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I81d83b9053329a19af4f478d21f8c452dcf39538 Reviewed-on: https://gerrit.libreoffice.org/67849 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-14weld ScDPNumGroupDlgCaolán McNamara
Change-Id: I5f5861a1f39307133f4c87e4d5ca50ced24409ba Reviewed-on: https://gerrit.libreoffice.org/67813 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-14Resolves: tdf#123426 don't reformat tabstop pos while editingCaolán McNamara
we want to know what it would format as, but we don't want to do the formatting during typing Change-Id: I817798adf5b3f9325682f43b92fe107659803b4f Reviewed-on: https://gerrit.libreoffice.org/67819 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-14buttons are at the wrong endCaolán McNamara
Change-Id: Ie4c2c017d2e4426f5b4ad06e4318b439d1aac1a4 Reviewed-on: https://gerrit.libreoffice.org/67839 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-14cleanup of PngImageReaderTomaž Vajngerl
Change-Id: Ifa5efe5fab644f1c684ada3f6cd46e19c002d7ca Reviewed-on: https://gerrit.libreoffice.org/67842 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-02-14uitest for bug tdf#122398Zdeněk Crhonek
Change-Id: I47e7df381d7bb03c27833b37234471a746212f12 Reviewed-on: https://gerrit.libreoffice.org/67826 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-02-14sw btlr writing mode layout: fix baseline offsetMiklos Vajna
The problem was that the x position of the btlr text had a 159 twips difference (it was too close to the cell border), since the text portion height -> baseline offset calculation worked with the descent, not with the ascent. The position of the text now matches exactly what Word does. As a side-effect this means that multiple portions in a line and also multiple lines in a text frame now work correctly. Change-Id: Ic139db328e2a913e5cae4026886c3410cdab357d Reviewed-on: https://gerrit.libreoffice.org/67823 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-14don't need a special function to get the BlueOrIndex colorTomaž Vajngerl
Change-Id: Idee5a82f8b69a25afa603ce8743d071d0093d617 Reviewed-on: https://gerrit.libreoffice.org/67824 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-02-14move pngwrite/pngread to vcl/filter/pngTomaž Vajngerl
Change-Id: Ib6bf092854208eea5257c357850213815639968c Reviewed-on: https://gerrit.libreoffice.org/67821 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>