summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-05-16tdf#97635 Added unindentation using shift-tab (mimicked eclipse behavior)Andreas Heinisch
Change-Id: Iaf64451c92f3465751032dde9c283141e548b3ca Reviewed-on: https://gerrit.libreoffice.org/72228 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-05-16Make gdb autoload template more pythonicJens Carl
Replace vim modeline with Python specific one to avoid problems with tabs and spaces, and also make code more pythonic. Change-Id: Ia0959787ceea740b5c97f500c60ef423fbed0651 Reviewed-on: https://gerrit.libreoffice.org/72375 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-16tdf#125254 Performance: A spreadsheet opens too slow, optimise listenerNoel Grandin
saves about 0.5s out of a 43s load And remove the comment in EndListeningAll, SfxBroadcaster::RemoveListener doesn't have any weird side-effects any more Change-Id: Id7c8ac1bed8ff3487cb8f977990d8fac351d7f03 Reviewed-on: https://gerrit.libreoffice.org/72396 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-16Drop obsolete commented out debug outputMike Kaganski
Change-Id: I60f7bbb2921b242396b4620077ca30e12a0d3b4b Reviewed-on: https://gerrit.libreoffice.org/72393 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-05-16tdf#125131: tip of the day dialog should be modalXisco Fauli
Change-Id: I13cd8734f843b734826535f55c60d67625cd9e79 Reviewed-on: https://gerrit.libreoffice.org/71902 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-05-16split methods upCaolán McNamara
Change-Id: Ib6f27574b8a45b29d6887d268f2e291314c796bf Reviewed-on: https://gerrit.libreoffice.org/72382 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-16refactor to move overlay creation to SdrPaintViewCaolán McNamara
Change-Id: Idbb734a44289d7ecead84f3c4ac2bc1ebc44ef40 Reviewed-on: https://gerrit.libreoffice.org/72381 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-16convert back from logic to pixel for queue_draw_areaCaolán McNamara
Change-Id: Ideb0f4066629dec0c6375a01897c0c8d6e2ff524 Reviewed-on: https://gerrit.libreoffice.org/72380 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-16tdf#42949 Fix IWYU warnings in javaunohelper/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I16c46b6640a349b886fe934f5634f2ba79d64887 Reviewed-on: https://gerrit.libreoffice.org/71934 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-16xmloff: create XMLDrawImportOasis instances with an uno constructorMiklos Vajna
Change-Id: I4e4e0b56306a6e0e1b61f432e487a47d700e5e9f Reviewed-on: https://gerrit.libreoffice.org/72379 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-16tdf#43157 Clean up OSL_VERIFY (replace with SAL_WARN)Jens Carl
Replace OSL_VERIFY with if-statement and SAL_WARN. Change-Id: Ib286a2151fe19a91b4e9db8db9f92ac0d5264d36 Reviewed-on: https://gerrit.libreoffice.org/72330 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-16Fix typoAndrea Gelmini
Change-Id: I6f7a40e8fefe09f9799927853b66dcae6c7a31d1 Reviewed-on: https://gerrit.libreoffice.org/72388 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-16Fix typoAndrea Gelmini
Change-Id: I38249b6ceeea7d59a23a6a4b841877724a343b78 Reviewed-on: https://gerrit.libreoffice.org/72390 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-16Fix typoAndrea Gelmini
Change-Id: I9fdd5e25dff09593dec3947de4c5a916a15f48a1 Reviewed-on: https://gerrit.libreoffice.org/72389 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-16uitest for bug tdf#124829Zdeněk Crhonek
Change-Id: I5eea7de34a37270e1bdf16ede271d73f9ea05730 Reviewed-on: https://gerrit.libreoffice.org/72376 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-05-16Fix typoAndrea Gelmini
Change-Id: I2615f979b9abbf87972dd67503ceda90724ce9bb Reviewed-on: https://gerrit.libreoffice.org/72387 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-16Fix typoAndrea Gelmini
Change-Id: I3e6446680571202a6825293e8b6c671022be6e0b Reviewed-on: https://gerrit.libreoffice.org/72386 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-16Use hand-crafted passwd entry for iOS Simulator as getpwuid_r() does not workTor Lillqvist
getpwuid_r() returns nullptr. Oddly enough, it does work on actual iOS, though. So use hand-crafted values that match behaviour on actual iOS. Change-Id: Idcc95d330a93495938520229e039f340876c3653
2019-05-15do not add non-text to PRIMARY selection in VclQt5ClipboardLuboš Luňák
E.g. tdf#80853 repeatedly sets the selection, which results in the entire document getting converted to html. Other VCL backends seem to be even faster, it looks like they convert the data only on-demand, but this at least makes things bearable. Change-Id: Ib08423bd89d7c7065ad0522338979f1ce66701c7 Reviewed-on: https://gerrit.libreoffice.org/72369 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-05-15Qt5 don't unconditionally disconnect close buttonJan-Marek Glogowski
Change-Id: Ibfa4d493ed752a03554020c6ab06bfc38745d97d Reviewed-on: https://gerrit.libreoffice.org/71871 Tested-by: Jenkins Reviewed-by: Aleksei Nikiforov <darktemplar@basealt.ru> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-15Qt5 IM report selected text and anchorJan-Marek Glogowski
Implement the text selection IM queries. Never seen them, but since the text querying code is already there, it's easy to extend to include the selection. Anchor is the non-cursor position of the selection and should return the cursor in case of not selected text. Change-Id: I0e49a8593a5a6c6268395857748b5fc304372210 Reviewed-on: https://gerrit.libreoffice.org/71797 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-15Qt5 IM handle surrounding text requestsJan-Marek Glogowski
This is almost a C'n'P from gtk / gtk3. That code is from 2006 (see i#68048 / commit 28c5cdcc53ae068b0c763c660d61a8291dd96726). The original patch was described by the author (caolan) as hilarious. No change from my side, except using QString. Completely untested, in theory correct. Change-Id: I8373ca7ac9eda6e377da985532fd2b7cd595bf48 Reviewed-on: https://gerrit.libreoffice.org/71786 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-15uitest for bug tdf#124675Zdeněk Crhonek
Change-Id: I81070b04bb1aefb3a8983cade701afd1b0392f3d Reviewed-on: https://gerrit.libreoffice.org/72374 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-05-15uitest for bug tdf#125261Zdeněk Crhonek
Change-Id: I282f4f3a07fece65bd482c7664aedd44d5852a4e Reviewed-on: https://gerrit.libreoffice.org/72378 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-05-15SM fix element control scrollbarJan-Marek Glogowski
The element layouting must always be done without a scrollbar, so it can be decided, if a scrollbar is needed. If it's needed the first paint will update the scrollbar accordingly. This also sets the scrollbar's page size to the control height, so clicking in an empty area will correctly scroll the widget not just a single pixel. Change-Id: Ib9a0eb1952bc0355f683cd8d116c61f9c9d462c4 Reviewed-on: https://gerrit.libreoffice.org/72315 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-15tdf#90297 set default SmEditWindow backgroundJan-Marek Glogowski
This implements ApplySetting for the proper background of the undocked SfxDockingWindow. In addition, like all other code, this sets the text color via the EditEngine font objects and therefore reverts the uneeded EditEngine interface from the original commit ea191cf9807d ("tdf#90297 use field colors for math's edit engine"). Change-Id: Ib7df4ce730da92a1e41f58b8348a5aec18208166 Reviewed-on: https://gerrit.libreoffice.org/72312 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-15SM handle background theme changesJan-Marek Glogowski
Replaces ApplyColorConfigValues with standard ApplySettings. I also opted to use COL_WHITE for the elements list, as the highlight color is also hard-coded to some light gray. Change-Id: I8be9d5897bf1dda4078b91d4df34a3339ac6cf31 Reviewed-on: https://gerrit.libreoffice.org/72314 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-15qt5: Fix build error on 32 bit archsMichael Weghorn
... as observed in [1]: > [...] > In file included from /usr/include/c++/8/algorithm:61, > from /usr/include/i386-linux-gnu/qt5/QtCore/qglobal.h:142, > from /usr/include/i386-linux-gnu/qt5/QtGui/qtguiglobal.h:43, > from /usr/include/i386-linux-gnu/qt5/QtWidgets/qtwidgetsglobal.h:43, > from /usr/include/i386-linux-gnu/qt5/QtWidgets/qwidget.h:43, > from /usr/include/i386-linux-gnu/qt5/QtWidgets/QWidget:1, > from /<<PKGBUILDDIR>>/vcl/inc/qt5/Qt5Widget.hxx:22, > from /<<PKGBUILDDIR>>/vcl/qt5/Qt5Widget.cxx:20: > /usr/include/c++/8/bits/stl_algobase.h:265:5: note: candidate: ‘template<class _Tp, class _Compare> constexpr const _Tp& std::max(const _Tp&, const _Tp&, _Compare)’ > max(const _Tp& __a, const _Tp& __b, _Compare __comp) > ^~~ > /usr/include/c++/8/bits/stl_algobase.h:265:5: note: template argument deduction/substitution failed: > /<<PKGBUILDDIR>>/vcl/qt5/Qt5Widget.cxx:502:69: note: deduced conflicting types for parameter ‘const _Tp’ (‘int’ and ‘sal_Int32’ {aka ‘long int’}) > std::vector<ExtTextInputAttr> aTextAttrs(std::max(1, nLength), ExtTextInputAttr::NONE); [1] https://buildd.debian.org/status/fetch.php?pkg=libreoffice&arch=i386&ver=1%3A6.3.0%7Ealpha1-1&stamp=1557890923&raw=0 Change-Id: Ic0e3e0b8bc65d9755b3d62385673f8d1e357b122 Reviewed-on: https://gerrit.libreoffice.org/72352 Tested-by: Jenkins Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org>
2019-05-15Move FindFocusedEditableText from gtk* into vclJan-Marek Glogowski
Now that it will be used by four VCL plugins, move its code into the common VCL library. The none-XAccessibility, none-UNO version used on Windows needs much more work to function with various widgets (including some API refactoring IMHO). (see ImplHandleSalSurroundingTextRequest and friends). Change-Id: I0fdf72336a66fc578b18b1edc8f8627d5dfdc57f Reviewed-on: https://gerrit.libreoffice.org/72364 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-15Attempt to load the theme when LibreOfficeKit is active.Jan Holesovsky
Change-Id: Ie8640b7179a96cb40fb774ede097ca7b3640edd8 Reviewed-on: https://gerrit.libreoffice.org/72349 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 7d55c2b8886ae00a60aa469503f596ee488c25c0) Reviewed-on: https://gerrit.libreoffice.org/72353 Tested-by: Jenkins
2019-05-15import GtkStatusbar same as GtkBoxCaolán McNamara
Change-Id: I44c2358659081d4990f5a7398a79249fb35c9c19 Reviewed-on: https://gerrit.libreoffice.org/72358 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-15give invalid region in target device logic unitsCaolán McNamara
Change-Id: I894e82cc97f63911c9cbb69e90d0212d6868527f Reviewed-on: https://gerrit.libreoffice.org/72359 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-15use tool button label as default tooltipCaolán McNamara
Change-Id: I67e1697a1621d1ff645eecb2f010041ce84448b8 Reviewed-on: https://gerrit.libreoffice.org/72318 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-15tdf#125303 bring back Autofit to textbox commandandreas kainz
Change-Id: I58a7391aec0c5cb3b5b5feb6be1ab3ecac2f0d5e Reviewed-on: https://gerrit.libreoffice.org/72356 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-05-15git-review: Use the hostname instead of alias.Jan Holesovsky
Change-Id: Ibbcb29b411bf413bf110c7d734ff8dc2763b2708 Reviewed-on: https://gerrit.libreoffice.org/72351 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-05-15tdf#114245 : Let both ScDocument::CopyToDocument()...Dennis Francis
methods use delayed-grouping introduced in commit 169a1b542165f3444791fd6e672d56d3fe48bd66 avoid possible expensive repetitive formula group changes (tdf#102364) The drag-drop move takes around 6-7 seconds now. Change-Id: I0916719ffca2072b7cf86b4f99518316cfdd99fa Reviewed-on: https://gerrit.libreoffice.org/72338 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins
2019-05-15cache cell positions when opening standard filter in calc (tdf#80853)Luboš Luňák
Part of the performance problem in the bugreport. Mdds otherwise always starts a search from the beginning of the contaier. Change-Id: Ic5c542220b7a8dc3aec0cfa93a0888997435fbfe Reviewed-on: https://gerrit.libreoffice.org/72347 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2019-05-15tdf#116431 Make the string "LibreOffice (Safe Mode)" translatableTakeshi Abe
Change-Id: I29f68f16c228c46841a7a3a50bb6dfe4f703403f Reviewed-on: https://gerrit.libreoffice.org/72212 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-05-15tdf#83722: Restrict the condition only to File > NewKatarina Behrens
referrer =~ private:user Change-Id: Ic67b0285ab7f49546499e4a9d90d9061c9d1274c Reviewed-on: https://gerrit.libreoffice.org/72346 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-05-15SM constify SmElementJan-Marek Glogowski
Change-Id: I6334a6c87cb548c434f0dae05e7cb2cc6e6fd66a Reviewed-on: https://gerrit.libreoffice.org/72316 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-15Reimplement IObjectSafety from aggregate object into ancestorMike Kaganski
Also simplify it, don't issue warnings for now, until we understand clearly what each its option implies. Change-Id: I0d74a42b878991ad84c5c3bba36c8978d920b9be Reviewed-on: https://gerrit.libreoffice.org/72337 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-05-15Update git submodulesAndras Timar
* Update helpcontent2 from branch 'master' - MIME types are not localizable Change-Id: I9bd17e2514cada5dc12b6957ba1d74b30334a13a Reviewed-on: https://gerrit.libreoffice.org/72345 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-05-15Check passed pointersMike Kaganski
Change-Id: Idf5e77e4122ad4b5b91f25c50fdaaf25e34a76ae Reviewed-on: https://gerrit.libreoffice.org/72336 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-05-15Use lambdas to initialize staticsMike Kaganski
Change-Id: Ib03bfd795967ba70333d71d9e5eeec97be90be79 Reviewed-on: https://gerrit.libreoffice.org/72334 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-05-15tdf#105622 Highlight 128 cells.Shubham Goyal
Change-Id: I72897ed9eb8bb0b042c6353fef82c0fa60be86a3 Reviewed-on: https://gerrit.libreoffice.org/69828 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-05-15Fix typoAndrea Gelmini
Change-Id: I407e8aa9c75fd5598321294437d9340f3f8e9456 Reviewed-on: https://gerrit.libreoffice.org/72325 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-15tdf#42949 Fix IWYU warnings in unotools/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Also recheck include/unotools/* Change-Id: I3b8489aca69fbe80fa4a21748ac3c872d0d266c4 Reviewed-on: https://gerrit.libreoffice.org/71883 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-15Add unit test for pptx import, crop to shapeTamas Bunth
Change-Id: I2a987278320a5685780962de2d3dfc165f3ef3aa Reviewed-on: https://gerrit.libreoffice.org/72309 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-05-15xmlsecurity: make DocumentSignatureManager members privateMiklos Vajna
Change-Id: I1262ca0dc2b2f843bdd6277415ee7967e9e59458 Reviewed-on: https://gerrit.libreoffice.org/72320 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-15tdf#118699 DOCX import: don't add numberingLászló Németh
after a tracked deletion of a numbered list to the next not numbered paragraph. Note: we remove the numbering of the first item of the deleted numbered list to import the actual text content correctly, giving correct numbering after accepting the changes or in the Hide Changes mode. Change-Id: I98767937bc783cb5e8ecb05558a5ad05a57ff281 Reviewed-on: https://gerrit.libreoffice.org/72001 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
generated by cgit (git 2.34.1) at 2025-01-15 09:39:14 +0000