summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-01-31avoid dangling tmp files in hwp importCaolán McNamara
if there is embedded data use office-binary-data to transport it instead of a temp file https: //issues.oasis-open.org/browse/OFFICE-3933 Change-Id: Ia1cebf0770c99210df09f03dbb507451d9cf7764 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129076 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-31tdf#126960, tdf#131330: FB make views editable+refresh auto after creationJulien Nabet
Change-Id: I78783056659a26cc8139d74eefc225de1a11ca7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129011 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 0adff3f2476f797843fb62d6810de90bfb333e10) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129067 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-31upgrade expat to 2.4.4Caolán McNamara
Change-Id: I1f2694abd9f577e0b4fedbf27118b52be8a1a688 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129072 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-31ofz#43577 valid reclen must be >= 20Caolán McNamara
Change-Id: I454bff4acfcd85701a7f094a8bd76898825e9ce2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128388 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 444477a07bcaf59181dbbc719b913566091deadc) ofz: Use-of-uninitialized-value Change-Id: I6b768b80d972c5379005efecfb803463ca648b4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128644 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 7b37a1a5144a3a4c8b0803b7e2da81e9e108bf66) ofz: Undefined-Shift Change-Id: Ib935359071ef9e390aa3d6c9713ed48241ad18e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129066 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit e863b90a0e5fc90c3b824e4b0012f9389b87a3ac) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129182 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-31fix loading file with very large number of stylesNoel Grandin
where nCurrentPosition was wrapping around Change-Id: I839215f3138d58884f03509b6341147ef28edb4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129108 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 7f3682ecb8a40fe85b6525be9e73d49d76bb308b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129075
2022-01-31tdf#147041 Always show navigated heading at top of visible view areaJim Raykowski
Revert to pre commit 1df2581cfffc87386c6de7614793b2d664244e5a behavior Change-Id: I06fe630bf0c0e611351e0e9a56361a3028f207d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129129 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit b0434f62c17b69e10caf05ad85a60f1bffdb5238) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129080 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-30Resolves: tdf#147016 ensure focus returns to document after popup closesCaolán McNamara
Change-Id: I67e59afc08bc5983d473cb9dceb4fcefedeec117 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129095 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-30Resolves: tdf#147013 transform the control point positions tooCaolán McNamara
Change-Id: Ia73317a79de66778d4b2d0face07ee4c41e328d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129078 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-30DOCX import: handle a subset of <w:ptab w:alignment="left">Miklos Vajna
The case when we can map it to a line break. This way the page number is visually inside the rectangle shape that is behind the field. The test intentionally uses \n as-is for line-break, because SwASCWriter::WriteStream() uses \n in the LINEEND_LF case even on Windows (and not SAL_NEWLINE_STRING), while SAL_NEWLINE_STRING is used for paragraph-break. Change-Id: Ic85e57b2391bfac73507727b17240f4d85fc2698 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129059 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit 8bac48991857d222f0e8f0c07b8c4e06649e1632) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129077 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-29make sure to not divide by zero when computing miter limitLuboš Luňák
The minimal angle is valid only if the line join style is miter, and e.g. FileDefinitionWidgetDraw can call these with round join style and 0 angle, which would divide by 0. So either clamp the value or compute it only when needed. Change-Id: I2a2c71481490c03ec6d01b8e33cab991400adb35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129006 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129029 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-29Add CIRCLED NUMBER TWENTY ONE through CIRCLED NUMBER FIFTY to numbring listKevin Suo
Previously we only supported CIRCLED NUMBER ONE through CIRCLED NUMBER TWENTY. Unicode already has CIRCLED NUMBER TWENTY ONE through CIRCLED NUMBER FIFTY. This improves Circled Numbering, especially for CJK. E.g. ➀, ➁, ➂, ... ㉑, ㉒, ㉓, ... ㊽, ㊾, ㊿. Change-Id: I7c4c851f03522fef9d44163da7450cf69aab3889 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129015 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 7e380a76e1f0faa90fdf8f0575053d4a1ca6e1de) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129068 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-28Fix gtk3_kde5 build when qt5/kf5 VCL plugins are not builtMichael Weghorn
Since commit 894450d6ebbb2d5e063d72b971580d1b8c10a5e3 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Tue Sep 28 08:36:44 2021 +0200 Unify how Qt/KF build flags/libs are set the qt5/kf5 externals are used to set includes and compiler/linker flags for the gtk3_kde5 VCL plugin as well. However, the relevant link targets were only actually defined as needed when building the qt5 and kf5 VCL plugins was enabled as well. Adapt that so that building the gtk3_kde5 VCL plugin but not the qt5 and kf5 ones also works again (e.g. '--enable-gtk3-kde5 --disable-qt5 --disable-kf5'). [NOTE: This backport for 7-3 also incorporates the follow-up fix commit ba67202007f37d228a813c0915fd630bc2ff177b Author: Michael Weghorn <m.weghorn@posteo.de> Date: Thu Jan 27 15:16:47 2022 +0100 Fix up "Fix gtk3_kde5 build when qt5/kf5 VCL plugins are not built" ] Change-Id: I65b75d7c2ccab71eade01aa2529fb45174056701 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129022 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 5801b9fc65508391e130670f79a9af51f18d4e96) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128965 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-28use mktemp for outdir, UNPACKDIR and FAKEDBRPMCaolán McNamara
Change-Id: I53d0f027b60d681e16298531e3d890fafc43aea6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129092 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-27Take layoutInCell into consideration when placing graphic in tableTor Lillqvist
Set our IsFollowingTextFlow property accordingly. Thanks to Miklos for doing most of the work. Change-Id: I67d214d6ed41c19dcb2f3ad2db9be94ca77c5842 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128880 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 9aa90da7e03b4b0806b27451665b7c41b8836bc0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128966 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-27tdf#144166 use border drawing style for VclScrolledWindowCaolán McNamara
to avoid rounded rectangles on Windows. Change-Id: I29b9631ec0f3d125cbf103b0c12580a41f9b9264 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128964 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-27ofz#44080 throw exception on a negative lengthCaolán McNamara
Change-Id: I3e2286cea69908fae3a2dd177d10fca2b7f0c877 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128955 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-27tdf#139737 sw_fieldmarkhide: add unit testMichael Stahl
Change-Id: I4adfed97a00db71d42bbc4771221f5ebde43197c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128997 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit cd62fa66a7b57c1cdcbf7cdbdf155edf8e40c9fc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128961 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-27tdf#139737 sw_fieldmarkhide: writerfilter: don't copy header/footerMichael Stahl
... when inserting into an existing document. The header/footer will not be removed by SwUndoInserts::UndoImpl() and thus the extra nodes will screw up subsequent Undo actions. Inserting a header from a file is already disabled, but there is a function that copies from a preceding page style that was missing a check. This never worked and reportedly crashes since commit 4dc1615c80e8e66d339dc86fa95bbc76e884d988 Change-Id: I895d867ee9fd30a936144492f3ee1633d045fe8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128635 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 94ef342679629c76eff2686243b423e926bbf680) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128960 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-27svgexport: fix: attribute id redefinedRash419
If there is a id for empty paragraph exist we need to create a empty text paragraph to accomodate the id if we don't do that then we get multiple id attribute on same element for example: <tspan id="id14" id="id15" id="id17" class="TextParagraph"> Change-Id: I41c21dc94deef93e423aaff2248f6931fa6ca8de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128856 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128924 Tested-by: Jenkins Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128954
2022-01-27tdf#146966 sw: fix inserting empty rows at copying multiple rowsLászló Németh
HTML expansion of the clipboard content is used to calculate the row number of the table on the clipboard. Skip its empty <tr></tr> elements here, similar to Paste As HTML in Edit->Paste Special-> Paste Special... to avoid inserting empty rows (e.g. selecting and copying/moving 4 rows inserted 30 extra empty rows). Note: likely this was a regression, related to the new empty rows in the clipboard/expansion code. Change-Id: I58b16c7869c08cda7e2a2c21c3c03bf38446d826 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128986 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 6ad9a3d74ef6eae3e645df12dedbe059acc180c4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128959
2022-01-26warning is a dialog not a popupCaolán McNamara
with the wrong setting it appears misplaced on a multi-monitor setup Change-Id: I43faeb72f6678a653feef82e0f0deaf87c039e9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128958 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-01-26tdf#146992 gtk_window_set_attached_to causing widgets to shiftCaolán McNamara
which isn't desirable, just drop its use. Change-Id: Ic29efa9e785cad3c221e0ef37816b8485979e719 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128957 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-26update creditsChristian Lohmaier
Change-Id: Ib2d0e2477b932669ab55b36abcfc347d43dc8bcd (cherry picked from commit 65564103f619aa75eb1d1872546af78caf3144b6)
2022-01-26tdf#123973 fix missing MasterPage content in exportArmin Le Grand (Allotropia)
The old fix tdf#96922 is no longer needed, so I remove it now. It prevents MasterPage content to be included in export. Checked that task is fixed && old task does bnot re-appear. Change-Id: I8b6923e01f6e24f662288e24d26634c06c9527f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128940 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> (cherry picked from commit 87866def6bfe2ee91be34a5ce37b79d6da881617) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128952 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-26Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-7-3' to 22e60373393e60eacb736936c265807ca7e0f946 - update translations for 7.3.0 rc3 and force-fix errors using pocheck Change-Id: Iedaea86e48ece63ca63d38dceac9b0d15091f38d (cherry picked from commit 59aa6716126252d64cbd897153f231389c05ac2d)
2022-01-26tdf#146857 sw change tracking: fix freezing during UndoLászló Németh
Re-insertion of hundreds of redlines during Undo resulted freezing, because of the unnecessary call of isMoved() in SwRedlineTable::Insert(), multiplying the slow Undo by ~40 extra redline checkings around each redline to find tracked text movings. Stop unnecessary call of isMoved() during Undo in SwRedlineTable::Insert(). The state of isMoved bit i.e. the green/double strikethrough/underline redline formatting is preserved anyway. Regression from commit f51fa7534421a195a58b4a737a2e836d8c25ba81 "tdf#145718 sw, DOCX import: complete tracked text moving". Change-Id: Ib7901c7b4fefd87633c49ef252750b84dcdb73dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128762 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit b15638440d692dd8cce55c0e936fbb82d24f8414) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128953
2022-01-26avoid Xlib cairo surfaces for small virtual devices (bsc#1183308)Luboš Luňák
The (private :( ) document contains a large number of small shapes for which VclProcessor2D::RenderTransparencePrimitive2D() gets called, which results in GetBitmapEx() on the VirtualDevice. And Cairo normally needs to do a roundtrip to the XServer to fetch the content, which makes the rendering pretty slow. Forcing image-based surface for small sizes of VirtualDevice actually has better performance for the document, and the lack of possible HW acceleration generally shouldn't matter for a surface this small. Additionally drawinglayer's VirtualDevice reusing tries to reuse even a large one when a small one is needed, so a hack is needed to avoid that in this case, I couldn't find a better way. Change-Id: I0f58659ab88165a6bd915f100fc3b1d4802a0fa9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128309 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit cf9be3417bc2be5f772c03180b7cbd248b82cad5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128815 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-26tdf#146970 use a textview to show the proposed replacement formulaCaolán McNamara
so it can scroll and keep the text area to some finite size no strings changes or new translations, so this is a backportable change. Change-Id: Ibc36812c6aa7fff8e035c06d0dad885909f057ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128933 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 36121e87b7e2a2defbfe75dfdadb2dde4fff6b4f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128948 Reviewed-by: Eike Rathke <erack@redhat.com>
2022-01-25uno sequences with different sizes are not equalLuboš Luňák
This should often the case, and should be way faster than the UNO data comparison. Change-Id: Ied648d75779ef3aafd293c36906a1bab66bdeade Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128098 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 9e7e63b8f812977b253b05db8a02dd0444de375a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128816 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-01-25ScInputHandler::UpdateFormulaMode() also for multi-line formulasEike Rathke
Additionally sprinkle some TODO: MLFORMULA comments on places where multi-line formulas should be supported as well but code currently only works for one paragraph. Change-Id: If2630a6493910984e0abb81ff2ed42ed51394681 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128787 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 8204d322379cbc054fb834911d88fb0fe3b040c6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128822 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-01-25tdf#146941 qt: QtFilePicker::finished needs SolarMutexGuardMichael Weghorn
Change-Id: I4165c72ddd6370c8fe7faf55f9db831359f6f8a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128923 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit a85908f507f39c88a6cf244f5f4120361ad5e2ae) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128826 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-25tdf#146967 sw table: fix freezing in Hide Changes modeLászló Németh
During change tracking, drag & drop or Cut & Paste a table row resulted freezing in Hide Changes mode. Test: In Hide Changes mode, select a table row by clicking on their left border, and drag & drop or Cut & Paste it in a different table row. Regression from commit 5a1c19624eda0c8b847af0dcee70b82502578ceb. Follow-up to commit 5a1c19624eda0c8b847af0dcee70b82502578ceb tdf#146965 sw track changes: fix tracked table row moving Change-Id: Iab606ce036fedcc70e42638e3ccf804c9dbca064 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128875 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128922 Tested-by: Jenkins
2022-01-25tdf#146965 sw track changes: fix tracked table row movingLászló Németh
During track changes, drag & drop or Cut & Paste a table row resulted a nested table in the first cell of the newly inserted empty table row instead of moving the original table row. Test: select a table row by clicking on their left border, and drag & drop or Cut & Paste it in a different table row. Note: This fixes crashing at Redo of tracked table row insertion, too. Regression from commit dbc82c02eb24ec1c97c6ee32069771d8deb394f9 "tdf#143358 sw: track insertion of empty table rows". Change-Id: I9a31cae2c0e6e5e05450336a1e5b8d792035df35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128726 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128921
2022-01-25DOCX import: fix <wp:anchor layoutInCell="1"> with <wp:wrapNone>Miklos Vajna
If wrap is set to none ("in front of text"), then <wp:positionH relativeFrom="column"> ignores layoutInCell="1" in Word. But in case relativeFrom is something else (e.g. page) or wrap is not none, then the old behavior is OK. Adjust our import so that Writer's layout also allows this shape to leave the cell. Change-Id: I6ca7511d46d7a70df11a65dc67c182f4fff4ae69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128862 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit e993638d5ecd33783f2eebdccfa87a81e5a8a2c5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128824 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-25tdf#146571 Ignore focus changes after closing Manage changes dialogCaolán McNamara
Change-Id: Ib588310410a265acdd129a8e51adf56bb5973bd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128869 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128910 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-25DOCX import: floating table with negative top margin has to be a fly frameMiklos Vajna
The bugdoc has a large header, then part of the table goes into the whitespace of the header by specifying a negative vertical position. Keep this as a floating table as normal tables can't have negative top margins. Change-Id: I95299051f004976778765965971428d9764bef08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128724 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit 3eb6d764b3023500f2299d36bf1860bc8e67db9f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128813 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-25gtk3: "expand" icon in reference windows goes missing on entering shrunk modeCaolán McNamara
Change-Id: Ie303f82d1cc0de10ebd14248a31111a16be344f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128814 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-25tdf#146971 changing a11y desc to replace %PRODUCTNAME has perf issuesCaolán McNamara
so leave it alone, and do the conversion just for the originally report situation as a safely backportable change with a follow up to not allow us to get into this situation in the first place Change-Id: I4f95f85791d0f937e53d7541804870b2cbf62b44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128820 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-24SwNavigator: disallow tracking update when content tree has focusJim Raykowski
When document layout has not finished and there is no content to track at the cursor position, e.g. the cursor position is at the start of a document having text before the first heading paragraph, a selection made in the Navigator content tree can automatically unselect. This is not only annoying but causes a crash when action of a choice from the Navigator context menu is dependent on entry selection, e.g. 'Delete', 'Edit', 'Rename'. This patch prevents this annoyance and crash by disallowing content tracking when the content tree or the content tree context menu has focus. Change-Id: I2b0fd1ac4f53571e30ce1efa2934a70de2aad819 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128520 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit 0e7e8bb7ed30cdb1dee7ca72748c742657b19dab) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128531 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-24tdf#122995 Trigger Chart refresh directly in UpdateCharts for SWArmin Le Grand (Allotropia)
For OLE/Charts in SW we do not (yet) have a refresh mechanism or embedding of the primitive represetation, so this needs to be done locally here (simple solution). To have the Chart already invalidated at the next repaint, I needed to add a 'immediate' mode to InvalidateTable. Note: The text there claiming that the framework should do this is correct, but as long as the mechanism is incomplete (VC/VOC/OC in SW) direct refresh is needed. Change-Id: I3c845b3ec46fbb494e7bce163cfe105145421450 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128572 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> (cherry picked from commit d769e75de28a1afbb1df31b48840626cb35ed7ba) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128810 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-24sc: fix VBA Copy-Paste using same and separate documentTomaž Vajngerl
This fixes 2 issues with VBA copy-paste: - VBA command Range(..).Copy issue where the range wasn't selected when copying and the copied cells were from the previous selection. The Copy command now does the same selection as the Cut command. - VBA PasteSpecial issue where the wrong view was used to get the clip document. - VBA Workbooks.Add issue where the new workbook wasn't activated after it was created, which causes an issue when running tests, but not when running in LO application. The Add command does now the same as the Workbooks.Open command. All the issues are supported by new test cases. Change-Id: I36ec45c01f18f7f76e4f95a25a28402a6ee0e2e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128720 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 0c6ee963e1f089cb73e0c68a28af29d0f8d9e0df) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128678 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-23tdf#146144 sw: add tooltip to table rows with change trackingLászló Németh
Showing "Row Deleted" and "Row Inserted" with Author and Date (of the associated SwRangeRedline: latest tracked deletion in deleted rows, and first tracked insertion in inserted rows). Follow-up to commit c6af542a31e167e5a01908d049e399ce06a5e4e4 "tdf#146120 sw: show tracked table changes with different color" and Change-Id: I913e234de1a60311306fbebdfb1ae16dcea7cd8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126575 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 84fbb3398f7486f00e7b7dea415e1ea2510a9535) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128683 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-23Related tdf#146909: add missing IDIGNORE in BasicJulien Nabet
Change-Id: Idbbceb2f5375d47c942bab70ce81f7be79b17478 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128780 (cherry picked from commit c1205c1cf6e08d94e6e2e2753679d99bc1842ca0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128685 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-22tdf#146367 reintroduce approxAdd() similar handling with last summandEike Rathke
... to tie result to 0 eliminating opposite sign small equalish fractions. This does not "fix" all interim values of the bug's sample document, which repeatedly adds single values in sequence using SUM() and should use the + operator instead to benefit from approxAdd() for each, but maintains the better accuracy of Kahan summation in the not near equal zero cases. And the dreaded SUM(0.1;0.2;-0.3) also works again resulting in 0 with all permutations. Change-Id: I67188a6abbdb98212f070166ad02319c3d477e28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128451 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 730b8aba72356bb8ba0066a5517b1224a4f1e232) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128432 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-01-22python3: fix build on Win 10Aron Budea
With Windows 11 SDK (10.0.22000.0). Error message is: fatal error RC1116: RC terminating after preprocessor errors https://bugs.python.org/issue45220 Applied fixing patches to 3.8. Change-Id: I0860b05fd963ea81b493a4b9df7f39db86598dd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127395 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit fa9ab05d78bb398efa3c09148e9d6d717f6168d1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128686 Tested-by: Jenkins Tested-by: Aron Budea <aron.budea@collabora.com> Reviewed-by: Aron Budea <aron.budea@collabora.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-22Related: tdf#135935 set some hints as to what widget should have starting focusCaolán McNamara
for wizards where the help button gets initial focus under gen Change-Id: I40b0a4620f417a4688366c028db4c9cb59eb333c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128750 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-22tdf#146891 there is a case where "chapter numbering" can be changedCaolán McNamara
where "Chapter Numbering" is present but the list is editable, so we can't be sure that just adding "Chapter Numbering" for display purposes is safe enough, so add a specific id for the "pseudo" list style and check for that id (instead of the name) to determine the additional case where "Edit" button cannot be enabled Related: tdf#145804 show "Chapter Numbering" as (uneditable) list style Change-Id: I35d852523314c985ea5b7217e9394ac3e9c6e331 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128679 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-22tdf#135935 Ensure help page is opened in chart creation Wizard dialogRafael Lima
Prior to this patch, if the user opens the Chart Wizard dialog (Insert > Chart) and clicks the Help button without clicking anywhere in the dialog, the help ID was not being applied. This problem happens on kf5 and gen, but not on gtk3. With this patch, the expected behavior is achieved in gtk3, gen and kf5. Change-Id: Ief7852fce00de45f65c21ea0ddc8e4d6477612d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127783 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 67e88d173fb56a2628a5464d56276134bf6f65a2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128680 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-21ucb: webdav-curl: fix the debug logging moreMichael Stahl
Unfortunately didn't work in the cases where it needed to work. Change-Id: Ia132ba38fb6f0be4481dce48da2d713d47fa8bf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128658 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit f8ef102a82513233fb794109cecd599304e78407) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128670 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-21comphelper: fix UAF in SequenceOutputStreamService dtorMichael Stahl
Change-Id: I91f77ee9ab4d509ebee3d04f94a3c63986de0ef1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128657 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 03e8e1a408eef3c8acc5545416eda9d0938e21f7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128669 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
generated by cgit (git 2.34.1) at 2025-03-10 22:10:27 +0000