Age | Commit message (Collapse) | Author |
|
...by removing explicitly user-provided functions that do the same as their
implicitly-defined counterparts, but may prevent implicitly declared copy
functions from being defined as non-deleted in the future. (Even if a dtor was
declared non-inline in an include file, the apparently-used implicitly-defined
copy functions are already inline, so why bother with a non-inline dtor.)
Change-Id: I6de6b84ebd177f494864d7de91e538fa5a64985c
Reviewed-on: https://gerrit.libreoffice.org/58058
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...by removing explicitly user-provided functions that do the same as their
implicitly-defined counterparts, but may prevent implicitly declared copy
functions from being defined as non-deleted in the future
Change-Id: I75e356ee9e12bb2d88ed9db6c60c49b3f4ac5d58
Reviewed-on: https://gerrit.libreoffice.org/58056
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I43ecb3c0daac421e48433af04b1109bac02cc9aa
Reviewed-on: https://gerrit.libreoffice.org/58044
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...by removing explicitly user-provided functions that do the same as their
implicitly-defined counterparts, but may prevent implicitly declared copy
functions from being defined as non-deleted in the future
Change-Id: Idd25cd86db429b0f3391e359bb2617863b29eb67
Reviewed-on: https://gerrit.libreoffice.org/58053
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
* Update helpcontent2 from branch 'master'
- tdf#115254 Some branch bookmarks are not working 8
module sw s-
Change-Id: I8a8c40c6506f57caeb6de2d55181b4af91a28fce
Reviewed-on: https://gerrit.libreoffice.org/58027
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
- tdf#115254 Some branch bookmarks are not working 7
Module sw , t- to w-
Change-Id: Ic307998cd8f2080c3c0a98a114308e30394362d9
Reviewed-on: https://gerrit.libreoffice.org/58026
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: If4671f7db2afb46dc68aa7a8a92c509e1735ab9f
Reviewed-on: https://gerrit.libreoffice.org/58051
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
...for whatever reason, ever since the file's introduction with
359fd901c7c8a1c37e1d2ccee2b5a2cf6c3c93d1 "INTEGRATION: CWS xmlfilter02". Make
the copy ctor expliticly defaulted to avoid -Werror=deprecated-copy with GCC
trunk towards GCC 9.
Change-Id: I7785dfb073767ba963ceec682cfbdfe192eed69b
Reviewed-on: https://gerrit.libreoffice.org/58040
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...by removing explicitly user-provided functions that do the same as their
implicitly-defined counterparts, but whose presence may prevent implicitly
declared copy functions from being defined as non-deleted in the future
Change-Id: Ie9b943af57bd8081c06a531fb3c634e52f0a99b6
Reviewed-on: https://gerrit.libreoffice.org/58048
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
See gerrit#57911.
Change-Id: I122cf6069cdac05ef6781bfb0a4840614514d435
Reviewed-on: https://gerrit.libreoffice.org/58067
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
|
|
Change-Id: I520b19e2486bf1622206c74649f7105148b7bd87
Reviewed-on: https://gerrit.libreoffice.org/58047
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I87f89818c321fadb28faa600377b9e8bc3ad3085
Reviewed-on: https://gerrit.libreoffice.org/58046
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I25703979ebe94649f9cf1464d282b21a70cfe1fa
Reviewed-on: https://gerrit.libreoffice.org/58041
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I2daec11938361a6988741bd29e713a36a4c77414
Reviewed-on: https://gerrit.libreoffice.org/58042
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...so make sure the (implicitly defined) copy assignment op is not deleted and
has sane semantics
Change-Id: If34cb5bd1ef250505a4c876ab78aba2a3d5dfc21
Reviewed-on: https://gerrit.libreoffice.org/58039
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Regression from d379d18666aa42031359ca8eb34b0021960347ae (oox: import
WPS shape with text as shape with textbox, 2014-06-18), the position of
the textbox should be relative to the print area of the text frame, not
to the text frame itself.
Change-Id: I2b591dc46ad4967edd8a1691d9b100ef0d74bed3
Reviewed-on: https://gerrit.libreoffice.org/58009
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Not just in the merged-does-not-need-refresh case, in the needs
refresh case ScMF::Auto is not handled.
Change-Id: I6d1b98a4afb51893d052498c87a0477982106a36
|
|
If cups is configured to require a password prompt, it causes unittests
to hang indefinitely.
e.g.
0 0x00007fe545a41ccd in __pthread_join (threadid=140622167353088, thread_return=0x0) at pthread_join.c:90
1 0x00007fe53e3aa4bf in psp::CUPSManager::checkPrintersChanged(bool) () from /home/peter/libreoffice/instdir/program/libvcllo.so
2 0x00007fe53e3bcbe0 in SvpSalInstance::GetPrinterQueueInfo(ImplPrnQueueList*) () from /home/peter/libreoffice/instdir/program/libvcllo.so
3 0x00007fe53e27d532 in Printer::ImplGetQueueInfo(rtl::OUString const&, rtl::OUString const*) () from /home/peter/libreoffice/instdir/program/libvcllo.so
4 0x00007fe53e27d739 in Printer::Printer() () from /home/peter/libreoffice/instdir/program/libvcllo.so
And in another thread:
Password for peter on localhost?
0 0x00007f07f3c3834a in __GI___libc_read (fd=<optimized out>, buf=0x7f07d4a30b0f, nbytes=1) at ../sysdeps/unix/sysv/linux/read.c:26
1 0x00007f07ea7603ab in _cupsGetPassword () from /usr/lib/libcups.so.2
2 0x00007f07ea7231dd in cupsDoAuthentication () from /usr/lib/libcups.so.2
3 0x00007f07ea759266 in cupsSendRequest () from /usr/lib/libcups.so.2
4 0x00007f07ea7596d4 in cupsDoIORequest () from /usr/lib/libcups.so.2
5 0x00007f07ea72650b in _cupsGetDests () from /usr/lib/libcups.so.2
6 0x00007f07ea727403 in ?? () from /usr/lib/libcups.so.2
7 0x00007f07ea7275d1 in cupsGetDests2 () from /usr/lib/libcups.so.2
8 0x00007f07ec090b2d in psp::CUPSManager::runDests() () from /home/peter/libreoffice/instdir/program/libvcllo.so
Fix this by exporting SAL_DISABLE_SYNCHRONOUS_PRINTER_DETECTION=1 for unittests.
Change-Id: I0a3a2e7e9a88f5e6e1a9481cbb134538505381be
Reviewed-on: https://gerrit.libreoffice.org/55255
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
|
|
When configure wants to show a warning, it tries to check whether the
terminal supports colour. This check produces an error message
when running with no TERM environment variable set (seen on a tinderbox)
Fix this check so that it tolerates failure of the `tput colors` command
Change-Id: I263136142120cf66fe900df0deb74d2fa6e5d1d0
Reviewed-on: https://gerrit.libreoffice.org/57009
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
|
|
Remove comments that are copied from other tests by mistake.
Change-Id: I2dde9a7fc0c1e2f693947ff3bf9d83cf644a03cc
Reviewed-on: https://gerrit.libreoffice.org/57979
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
|
|
since...
commit 5be0637827cd987b7b7dda7ca2c54a3548d9ef51
Date: Mon Jun 25 16:46:32 2018 +0200
loplugin:useuniqueptr in ScSheetEvents
Change-Id: Ia20f6c8dfc1fcde49e35c07415f336f49ef79a28
Reviewed-on: https://gerrit.libreoffice.org/58037
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
...since ee025b744ac9efafe7c083ed80f8e2cc7cb3e2c1 "loplugin:returnconstant in
tools,comphelper,unotools"
Change-Id: Ia5fb60f5929084d8e3c6f45d81eefa55da100954
|
|
Non-AA lines were already working, but text was always anti-aliased.
(Use-case is reference bitmaps in a testsuite, where AA just makes it
harder to determine if the expected and actual rendering output match.)
Change-Id: I7c5ab4c80675e1a523d67b71f3cd3cbc9c6416c3
Reviewed-on: https://gerrit.libreoffice.org/58035
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins
|
|
Change-Id: I4f8e5f643126bea5deef7636b6d20f8080cb6662
Reviewed-on: https://gerrit.libreoffice.org/56309
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
warning: binding reference member 'n1_' to stack allocated parameter
'n1'
Change-Id: Ifa4c1520453e00d6fc35411fa0edbf2bf2b42708
|
|
Change-Id: Ia78195d49dfa72bc8ee06b81a1b18d38b17a72a3
Reviewed-on: https://gerrit.libreoffice.org/58028
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
|
|
The bugdoc has 2 slides. When switching to the second slide, the graphic
is loaded in the background, but OpenGLSalBitmap::Create() can't work
correctly if the caller doesn't own the solar mutex.
This already asserts in OpenGLContext::prepareForYield() in a less
obvious way.
Focus on the correctness, so just hold the solar mutex during the whole
ImportGrpahic() call. If it turns out that the purpose of running this
on a thread is to avoid synchronous network traffic, then the data could
be first copied to a memory stream, and only then take the lock + import
the graphic.
Change-Id: I88203c12b4e7a5f2b689928c01e2ba953c5b13c5
Reviewed-on: https://gerrit.libreoffice.org/57970
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|
|
Change-Id: I18cde30e132b8209d189e9438b49a1c3e5a36672
Reviewed-on: https://gerrit.libreoffice.org/57997
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
and make WW8PLCFx_PCDAttrs store a reference to the vector in
WW8ScannerBase rather than storing pointers to the data() inside a
vector. yuck.
Change-Id: I1a74a0f9cd9bf4669a7e49e2a56282d49be834cb
Reviewed-on: https://gerrit.libreoffice.org/58023
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: If8b9b999fd46022b5be0a3353e58653f5a42a06c
Reviewed-on: https://gerrit.libreoffice.org/58022
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: If1a8a0301a94c6303f7fe0db52fb3e5ae8c04715
Reviewed-on: https://gerrit.libreoffice.org/58021
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I81473abfd71f816495fe562dd57f987df03c11ab
Reviewed-on: https://gerrit.libreoffice.org/58019
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I1211daba231e4c5557dad06e8392a28fca922ab7
Reviewed-on: https://gerrit.libreoffice.org/58018
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I73c43bd95350a8ebb7373872d58fa8911736a0a3
Reviewed-on: https://gerrit.libreoffice.org/58017
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Id924a16aa9ee2935606bf89d676145d1f68f236e
Reviewed-on: https://gerrit.libreoffice.org/58020
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I8d98585fa759070a82bf5738d20b018ec9fbabf0
Reviewed-on: https://gerrit.libreoffice.org/58016
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I570b45e4174375be9e30f6ebc8c8171cace78990
Reviewed-on: https://gerrit.libreoffice.org/58015
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Iafe979a9a6c6f92226a25dc52b510682c5e5924f
Reviewed-on: https://gerrit.libreoffice.org/58014
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I208d46c27e5fefb20fbc9e049a0b3b36f7be4cbb
Reviewed-on: https://gerrit.libreoffice.org/58013
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I3499860f02e8fcdd5177f66cb648f7bdb12e4f6e
Reviewed-on: https://gerrit.libreoffice.org/58012
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I6c362954a8004a246773e6e72137d6eafb6e019e
Reviewed-on: https://gerrit.libreoffice.org/58011
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I3f4e4efa8ea839f48b9700ebc26c7e5ab279ce49
Reviewed-on: https://gerrit.libreoffice.org/57975
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Iabc3c67b4cdcd0344a37c533bf92dd00cd4700d8
Reviewed-on: https://gerrit.libreoffice.org/57974
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I893845570e4bd2961797fa1c2dd3e5316c9d262d
Reviewed-on: https://gerrit.libreoffice.org/58008
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
|
|
Change-Id: Iaf6cbe8dcfd107a66660746719b6b61e82a6ed0a
Reviewed-on: https://gerrit.libreoffice.org/57998
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Iea067e3529de9208bd0a00c276eb03858816bd00
Reviewed-on: https://gerrit.libreoffice.org/57996
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ifbeda8a97c81167d5ba6c66c9691b059794f32b1
Reviewed-on: https://gerrit.libreoffice.org/58025
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
|
|
Change-Id: Ic870fce3b88745ca6d25bab17c8c995cbd13f967
Reviewed-on: https://gerrit.libreoffice.org/58031
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: Ic1c9e854229a80f82c7ce6187816cc63f85c1f41
Reviewed-on: https://gerrit.libreoffice.org/57992
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: I836019b91866ecb993a3604dd646759acfd70a46
Reviewed-on: https://gerrit.libreoffice.org/58030
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|