summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-01-29tdf#122079 - Document orientation is no longer changed in print dialogDaniel
Change-Id: I9d13cfd136f9b70674b3e43268525f8a6e1c0954 Reviewed-on: https://gerrit.libreoffice.org/66483 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-01-29Grab fous from child in spell dialogSzymon Kłos
Change-Id: I8c21623f7148ab2c05fe3d4198cf12231600f88d Reviewed-on: https://gerrit.libreoffice.org/67077 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-01-29framework: allow dispatching a command on the main threadMiklos Vajna
This is similar to commit 2dc3a6c273cb82506842864481d78df7294debbf (framework: allow loading a component on the main thread, 2018-12-19), just it allows saving (via .uno:Save) and other commands operating in a similar environment. The use-case is that once a document is loaded on the main thread (see commit message of the above mentioned commit), then saving also has to happen on the main thread, or OLE objects on Windows may be lost. Change-Id: I7321659550b556e96085ac20f197a87d5d13f1ed Reviewed-on: https://gerrit.libreoffice.org/67089 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-01-29Add comments to autocorrect functionsIlmari Lauhakangas
It was difficult to find the sentence capitalization function. I thought it would be a good idea to add the UI strings of the options as comments before the function blocks. Also added a couple of notes inside FnCapitalStartSentence. Change-Id: I7047b199193ee0b61ba7fd955411952aae33ab41 Reviewed-on: https://gerrit.libreoffice.org/66812 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-01-29tdf#89998 set increment for percent values to 1%Martin van Zijl
Change-Id: I759f1041faa1222b0feb42e01c95166f56591e19 Reviewed-on: https://gerrit.libreoffice.org/66129 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-01-29sc: Fix CJK Unified Ideographs range in commentsTakeshi Abe
i.e. 4E00-9FAF -> 4E00-9FFF. According to <https://www.unicode.org/mail-arch/unicode-ml/y2003-m02/0351.html>, the confusion was partly due to older Unicode specification. As of Unicode 4.1 the trailing end (9FB0-9FFF) is in fact in use by "CJK Additions": <https://www.unicode.org/versions/Unicode4.1.0/> Change-Id: Ibd3704a81341743b3fa80686d3fcfc0bd11104ef Reviewed-on: https://gerrit.libreoffice.org/67087 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-01-29mysqlc: fix timestamp query of result setTamas Bunth
Also add test for inserting and reading timestamp values. Change-Id: I2ba997c438f4e33965b0fe0602e58eddeff38b01 Reviewed-on: https://gerrit.libreoffice.org/67066 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-01-29give better warning explanationCaolán McNamara
Change-Id: If76e1acdcb601d70c956bcaf0392046430f4853e Reviewed-on: https://gerrit.libreoffice.org/67086 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-29sc: fix CppunitTest_sc_ddelinkobj to copy its test documentMichael Stahl
XRefreshable::testRefreshListener() fails on read-only filesystem because the ScDDELinksObj.ods cannot be loaded read-write. It is loaded read-write since commit 5b2794e27a81f8078cc251580ca59cc47807c7a0. Change-Id: I27b954b216acd3d138ade0d3f1b21fedd2f74fb1 Reviewed-on: https://gerrit.libreoffice.org/67071 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-01-29tdf#123031 allow natural cell width if the combobox contents are >= requestCaolán McNamara
which matters in at least gtk 3.19 Change-Id: I760e46d02f2678842a685aa077bd0129520a3263 Reviewed-on: https://gerrit.libreoffice.org/67072 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-29odk: CustomTarget_build-examples hard-codes on "gcc" and "g++"Michael Stahl
... so it fails if these aren't available; instead use the C++ compiler of the LO build system. Change-Id: I8a95d1865c481dc0a790d6fec6ff9fae8284d76d Reviewed-on: https://gerrit.libreoffice.org/67078 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2019-01-29cppu: fix Android buildMiklos Vajna
By restoring includes which are still needed, conditionally. Change-Id: Icc331c7d6a084af7d93b941ea879f0c60b9ca9f3
2019-01-29Resolves: tdf#110429 width of page number wider than traditional widthCaolán McNamara
since... commit c80ac2ba4a6486e6161e17f9118ba1563b7fc00e Date: Fri Nov 11 18:16:52 2016 +0100 Avoid -fsanitize=signed-integer-overflow Change-Id: I2ec85e854ee1547d55b43b8540c357297d3b6cce Reviewed-on: https://gerrit.libreoffice.org/67068 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-29tdf#42949 Fix IWYU warnings in cppu/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia1b2f0a9c99acc7ac538f3b41c1b6757d414db35 Reviewed-on: https://gerrit.libreoffice.org/66970 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-29tdf#117713 set a tiny default size-request for the fixed containerCaolán McNamara
otherwise we get a default one if SetMinClientSize is never called, which is the case for these spawned-from-basic dialogs Change-Id: I4f0389de6abcb1e99b32798969dca49bf8f0f760 Reviewed-on: https://gerrit.libreoffice.org/67063 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-29KDE5 map QFont::stretch() == 0 to WIDTH_DONTKNOWJan-Marek Glogowski
From the Qt5 documentation: "QFont::AnyStretch / 0: Accept any stretch matched using the other QFont properties (added in Qt 5.8)". So this maps 0 to LO's WIDTH_DONTKNOW, which fixes the too narrow font selection in the KDE5 backend, when applying the KDE5 font setting to LO. Change-Id: I5f1a62d6c314c0766b540869c49c72bc3f6821c3 Reviewed-on: https://gerrit.libreoffice.org/67059 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-01-29Drop kde4 desktop detectionMichael Weghorn
KDE 4 has been unmaintained upstream for various year now and the kde4 VCL Plugin was removed with 6ca3b3648e25ae9d4d2d29a0df83349198ec3f5e in favor of the kde5 one. Drop desktop detection for this obsolete KDE 4 version as well. Should new LO versions be run on old systems still running KDE 4, it's very unlikely that they have the kf5 libraries that are required to use the kde5 or gtk3_kde5 SAL plugins anyway, so the default fallback for an unknown desktop environment is quite as good. Change-Id: If8de489fbca836a80451435edfb00d2a8d501031 Reviewed-on: https://gerrit.libreoffice.org/67053 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-01-29framework: avoid crashing in ~HandlerCFGAccess() in atexit()Michael Stahl
Commit d587931fba77246db3a2ccc6ab61ca77446d23f4 changed HandlerCache::s_pConfig to a unique_ptr, which may now crash on shutdown because it's a utl::ConfigItem and by atexit() time the configmgr is long gone. Due to the HandlerCache::m_nRefCount, the crash probably only happens in case of an unclean shutdown, but we don't know whether this can happen in practice or not, so just avoid crashing on shutdown. Change-Id: Ifd2b782aa5592c344d1bc85acaa434c3f2a69b60 Reviewed-on: https://gerrit.libreoffice.org/67029 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-01-29dbaccess: don't try to migrate read-only fileMichael Stahl
It's going to throw IOException anyway. This fixes CppunitTest_dbaccess_hsqldb_test on read-only file system. Change-Id: Ifc8a4791ab9a1a8d3e0f1e67d65e10dac458147c Reviewed-on: https://gerrit.libreoffice.org/67028 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-01-29dbaccess: fix Tdf119625Test with read-only $SRCDIRMichael Stahl
The buildLowLevelConnection() will try to modify the read-only storage and throw IOException. Change-Id: I9b8ec840bebcac3c8a69bc6921d32e692d9d9e86 Reviewed-on: https://gerrit.libreoffice.org/67027 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-01-29drop now hopeless non-optimal depth warningCaolán McNamara
pointless since... commit 33761c69e9d3fa16e7a5b176200d183dc3236627 Date: Sun Dec 3 23:35:26 2017 -0500 vcl-svp: Store 24-bit images in 3-byte pixels squashed the effort to percolate preferred target format as bitmap storage format Change-Id: I8a5367d4d7d251d5dd37011d0e51ab09cf5c57ac Reviewed-on: https://gerrit.libreoffice.org/67055 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-29Replace macros with their payloadMike Kaganski
This actually increases readability of the code (for me) Change-Id: I39603f2921dcbd57984ced7e2c64b28868e8b608 Reviewed-on: https://gerrit.libreoffice.org/67052 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-29use unique_ptr in LotusRangeListNoel Grandin
Change-Id: Ie99b3a4d6a311b2f5140a00fddbbd53801b8cfb3 Reviewed-on: https://gerrit.libreoffice.org/67045 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-29b2dpolygontools: removing debug code, doesn't seem to be usefulTomaž Vajngerl
Change-Id: Id1aff2ede83e4c35976ebd51fc05aeea80dfae20 Reviewed-on: https://gerrit.libreoffice.org/67049 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-01-29configure: require autoconf 2.68Michael Stahl
LO's own configure doesn't need it, but the ExternalProject_libnumbertext requires this version; since it's available in RHEL6 as "autoconf268", just keep it simple and require it in the top-level configure. Change-Id: I43a6ef10089363c344f06134d75f54685ed7026b Reviewed-on: https://gerrit.libreoffice.org/67002 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-01-29pass ScConditionalFormat around by unique_ptrNoel Grandin
Change-Id: If15ac08d8334a386312870d3ebebb385cf55e5f6 Reviewed-on: https://gerrit.libreoffice.org/67050 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-29use unique_ptr in ScDataPilotFieldObjNoel Grandin
Change-Id: I351999f92b83e156ffe62e02c851050d4621fe7e Reviewed-on: https://gerrit.libreoffice.org/67048 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-29ofz: reduce max_len for metCaolán McNamara
Change-Id: If81ee19dd0127f48b9e57bf420323927c5981840
2019-01-29tdf#123013: Allow to change trendline name in gtk3Xisco Fauli
Change-Id: I3eeb6b8e27cced0a8a86969368f48a2af8ac5892 Reviewed-on: https://gerrit.libreoffice.org/67026 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-29ofz#11104 for timeouts, limit decompression ratios when fuzzingCaolán McNamara
Change-Id: If9efe56a40a866269a06ce944885a324495af48a Reviewed-on: https://gerrit.libreoffice.org/67036 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-29Remove some kde4 leftoversMichael Weghorn
The kde4 VCL Plugin was removed with 6ca3b3648e25ae9d4d2d29a0df83349198ec3f5e, so drop some now superfluous leftovers. Change-Id: I92887b679462a6ac22c3668a24ec6a9fdee8fac1 Reviewed-on: https://gerrit.libreoffice.org/67047 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-01-29tdf#123011 Detect kde5 desktop in Plasma Wayland sessionMichael Weghorn
Both env variables 'KDE_FULL_SESSION' and 'KDE_SESSION_VERSION' are set in both X11 and Wayland sessions for Plasma 5 (kde5), s.a. https://userbase.kde.org/KDE_System_Administration/Environment_Variables, so drop the alternative X-specific check. Move the check for a kde5 upward, so that kde5 is actually detected in a Plasma 5 Wayland session, rather than falling back to assuming GNOME. Change-Id: Ieb5b47272f375ceed4d44a2ccc5b517222ae86b9 Reviewed-on: https://gerrit.libreoffice.org/67044 Reviewed-by: Tomáš Chvátal <tchvatal@suse.cz> Tested-by: Tomáš Chvátal <tchvatal@suse.cz> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-01-29Add XServiceInfo tests to ScFilterDescriptorBaseJens Carl
Change-Id: I5063d29baa5e4140d2be35684eed746ae28c2cf5 Reviewed-on: https://gerrit.libreoffice.org/67040 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-29tdf#122430 RTF import: fix lost font size on footnote startMiklos Vajna
This become more visible since commit 49614a9ea971ff7f370f863ce8a2735aab973cee (tdf#119599 RTF import: fix missing deduplication of font size, 2018-09-24) as now incorrect font size from style affects the rendering result. Change-Id: I5b339337f021e2fc359f6fc5f5aa2ed0bcf844b9 Reviewed-on: https://gerrit.libreoffice.org/67034 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-29tdf#106463 set new firebird connections as autocommit by defaultLionel Elie Mamane
as per SDBC specifications Change-Id: I132a8e565468bcacf0fa5ee0dfb62bf0dd717e24 Reviewed-on: https://gerrit.libreoffice.org/67015 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2019-01-29Simplify containers iterations in sc/source/filter/[d-e]*Arkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: I7be6568641e154e74ff7bde812da9a8e67790a7f Reviewed-on: https://gerrit.libreoffice.org/66972 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-29Sifr icon: add cmd/32px svg icons and update the png outputandreas kainz
Change-Id: I2da45245f65e3c693a87dfa6026b8c4bb3fc0f6e Reviewed-on: https://gerrit.libreoffice.org/67037 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-01-29o3tl::make_unique -> std::make_unique in scGabor Kelemen
Since it is now possible to use C++14, it's time to replace the temporary solution with the standard one Change-Id: Ib69a4a2a08b1edbc0f40beac00f7f68075b479a1 Reviewed-on: https://gerrit.libreoffice.org/66967 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-29loplugin:flatten in svgioNoel Grandin
Change-Id: I3276c2c368c755e070fd8b19a15a954948a68df7 Reviewed-on: https://gerrit.libreoffice.org/67008 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-29loplugin:flatten in stoc..storeNoel Grandin
Change-Id: Ib8c86179a3d13852cbb02b389b6103aca5456dba Reviewed-on: https://gerrit.libreoffice.org/67013 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-29Fix typoAndrea Gelmini
Change-Id: Ie64a300a73db666231ae7b37f15e5d7556e594bc Reviewed-on: https://gerrit.libreoffice.org/67039 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-29tdf#45904 Move XPropertySet Java tests to C++Jens Carl
Move XPropertySet Java tests to C++ for ScFilterDescriptorBase. Change-Id: I86a16f3c53a5aacea0ce88a54ec8b340d13dff4f Reviewed-on: https://gerrit.libreoffice.org/67038 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-29Improve ODF enhanced-path command moveTo to follow specRegina Henschel
ODF 1.2 section 19.145 says 'If a moveto is followed by multiple pairs of coordinates, they are treated as lineto.' The patch does this on import. Change-Id: Ib493ca49288cdb2d34b7ee801bd052281617d2e8 Reviewed-on: https://gerrit.libreoffice.org/66888 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-01-29tdf#45904 Move XSimpleText Java tests to C++Ajay Mahato
Change-Id: I6232615f15b52a1f004a13ed97fc0b8002a22269 Reviewed-on: https://gerrit.libreoffice.org/66694 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-29Rename ScFilterDescriptorBaseObj to ScFilterDescriptorBaseJens Carl
Rename ScFilterDescriptorBaseObj to ScFilterDescriptorBase so it matches the object name we test against. Change-Id: Ia5ce59997e99b2b537e50ddfeaa9d96b2b55555f Reviewed-on: https://gerrit.libreoffice.org/67033 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-28libgpg-error: use custom soname and symbol versionMichael Stahl
The hope is that this should allow both system's libgpg-error.so.0 and LO's bundled libgpg-error-lo.so.0 to be loaded by soffice.bin without unintended hilarity. Change-Id: I94498097a847b9756de86051798cb4ce022f6c83 Reviewed-on: https://gerrit.libreoffice.org/67012 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-01-28Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' - tdf#121571 Solve cognitive dissonance with note icons and colors More often than not, the alarmist colors given to note boxes didn’t match their content. Change-Id: I88d7a8e2d07ffba661c218887fd54638506d21c8
2019-01-28split basegfx 2d tests to separate files (one per tested class)Tomaž Vajngerl
Change-Id: Icb2f745851ba3de31f6a672d1bc20659de687d2e Reviewed-on: https://gerrit.libreoffice.org/67031 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-01-28basegfx: just use the std::clamp for clamping the inputTomaž Vajngerl
Change-Id: Ia7d6c103956c8e3cebd6ebe656fd88586d33a9c8 Reviewed-on: https://gerrit.libreoffice.org/67032 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-01-28Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' - Drop this pitiful, bothersome, gimmicky animation Change-Id: If533f8565e38e02d503cc1ab59f65e2445f1369b