Age | Commit message (Collapse) | Author |
|
Change-Id: Ibca921eff3647507ffb7e9011a84aeefbec58d7a
|
|
maItemListRect serves as a sort of bounding box for what items /could/
be visible on screen, however it is only used for determining the id
of an item we have just clicked on -- given that we already know that
we are clicking inside the visible area this is an unnecessary check.
In fact this check is erronous as we no longer limit ourselves to "whole"
rows as of 806919adf9c9bafbaba92c2d2ab35d2e2f9863f8 -- i.e. the previous
assumption was that a view large enough for n rows will show precisely
n (whole) rows, whereas we might be showing (n-1) complete rows, and a
fraction of a row at the top and bottom of the screen, i.e. a total of
n+1 rows, where maItemRect only encloses the top n rows, meaning we
were erronously ignoring clicks on the (partly visible) lowest n+1 row.
Change-Id: Ia52ed2e0d217a9f077cef86ee9c1847252844995
|
|
Change-Id: I96e84e3ec756216fabe9739e6bd53d2a89d186b5
|
|
Change-Id: Ifd89b00c525ed4d75fcffe92845c4ca2f73705a8
|
|
Don't be fooled even when the document doesn't have a drawing layer
initialized. Sometimes a note creates caption on demand later, but if
the drawing layer isn't there the caption will not get created, which
ultimately causes this crash.
Change-Id: I37f4902fa84de91c9f793dc352127d9345a725e3
|
|
Change-Id: I7ac9792da93a1b5231ddac5398823667b28adf92
|
|
There is a good reason for that: File lists of
some file pickers handle double click event on
mouse down. So if a start center thumbnail is
exactly behind the file on which the user double-
clicked, it will receive the mouse up event, and
will also open.
Change-Id: I9fc9ceff0874d0486d5b568c9b35143c8d8aabf8
|
|
Change-Id: I3055df538fc4dfa625aa942ad0d0e6b6299c53b3
|
|
Change-Id: I6d7f6e035bb0dcc86f8aebfdfa4b7f9521bc8820
|
|
Change-Id: If22324ea65a45ac93f6c4b9cbaf9cfb11ef91195
|
|
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/Headers/Events.h
says that 0x27 is kVK_ANSI_Quote, which we call KEY_QUOTERIGHT,
i.e. the plain ASCII apostrophe, while 0x32 is not the ASCII tilde but
kVK_ANSI_Grave, which we call KEY_QUOTELEFT.
Makes the Command-' binding (see Kohei's
56cce6fd8151a916e1be540ac18724b46d1b15fc) work at least for the US
English keyboard. But not for the Finnish keyboard, for instance,
where the key labeled with an apostrophe (or "ASCII-style" single
quote) generates a different keycode than the single quote key on the
US English keyboard. (Which, I guess, isn't surprising as it after all
is a different physical key.)
In other words, situation normal, using keycodes is a horror as
always...
Change-Id: Ibf8f994370fec75849391e1dba30c7b7d54d237f
|
|
Change-Id: I2acd44d54966dd227f5dc23ca4acde3c50ca8347
|
|
Change-Id: I9fd2980a32bd0a3eb4849a53f29cc10b9a371f4c
|
|
Change-Id: Id320bc41fefff17035c8a30115dc94af5cbf9503
|
|
this is like it was pre ui conversion
Change-Id: Ie0fe230893dc448531a44c6d79c00b4a29120cba
|
|
Change-Id: I3b6d7091922ed345d24c15c5a52d37521792d551
|
|
Change-Id: If872737d2a7db5d9053a256f7e3d57007c24230e
|
|
Change-Id: I9dfe76d422ad732a081442b95a995d8d395a098e
|
|
Change-Id: I8914e0dc253c636a1393672f7a20bcb5d39d4276
|
|
Change-Id: I8e163e63bfbbbaa5f7f4de2151fea41d735417d0
|
|
Change-Id: If417d8091896c9f6c9650cf7d6036ffacbcc0884
|
|
Change-Id: I6510f486707b08ea8f611105f40cc4c7e1581a7f
|
|
Change-Id: I9c2aecd5dea617e7cd69c1fc005b6a9ee237f202
|
|
Change-Id: Id6bac3a8dd46d7994c9e64c9e0c16e8c7ac036ac
|
|
Change-Id: Ibfed531e48848ea711be429d6e5c08094473f781
|
|
Change-Id: I91220e8ebffa0090fa7e9146df853f16b6783491
|
|
Change-Id: If0454ace5ef21b9d32299f3edea115a2726aac00
|
|
Change-Id: I651c0e5830008fd08ba886ccf1be99d40868bb72
|
|
Change-Id: Ic117de10be2181a80e65ea48c888789456abfb0a
|
|
Change-Id: I7a3680aa324c4242572b71c91ec5bc4f85eff9e9
|
|
Change-Id: I7b1ca054006500d468da73d2d85eafaad85dda67
|
|
Change-Id: Ia2e09c92673b97fd48c4ede7ebb9ff47da821926
|
|
Change-Id: If1e0e78e1b62c547bd0f03e727e1856227b32821
|
|
Change-Id: I7a2acd99f3a8cb143c2ad1c978dfa4b02bf54464
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
... during DOCX import of shapes with text, so that we don't crash when
the currently always active
setServiceName("com.sun.star.text.TextFrame") call is not present.
Change-Id: I5b005583ddcee81b9683e3b34e8f0a2e5faa4f95
|
|
Fix build error on windows with --enable-dbgutil autogen.sh option.
We need to link freetype248_D.lib,when we use --enable-dbgutil option.
(Suffix "_D" is needed.)
Change-Id: Ib2927e777d9b9bb615e1df62e428cf17cc8bc26e
Reviewed-on: https://gerrit.libreoffice.org/9248
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Look for code like:
xxx ? yyy : false;
Which can be simplified to:
xxx && yyy
Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
|
|
This reverts commit f76026a43acc65465882924796d93e635c35fd90. This
brings back the paragraph style and font name combo boxes in Writer.
Change-Id: Idb28253797ef842d575fe10537f6e70faa34fe75
|
|
Project: help ada56299c9e1c2d2cf36a475fc4e746bf5977354
|
|
I don't know what the root cause is exactly that made at least Mac OS X
--enable-dbgutil JunitTest_forms_unoapi start to fail recently, but when nWidth
is just 1 (which might be the root of the problem here, but could probably also
legitimately be the case) and GetTextWidth returns -1 (which it probably is
allowed to do), this would lead to an out-of-bounds OUString::operator[] access
at
> rtl::OUString::operator[] (this=0x118a04be0, index=-1) at ustring.hxx:421
> com::sun::star::i18n::BreakIterator_Unicode::getLineBreak (this=0x11986f6f8, Text=@0x118a04be0, nStartPos=-2, rLocale=@0x7fbd83821d98, nMinBreakPos=4, hOptions=@0x118a04620) at i18npool/source/breakiterator/breakiterator_unicode.cxx:429
> com::sun::star::i18n::BreakIteratorImpl::getLineBreak (this=0x1112d5c98, Text=@0x118a04be0, nStartPos=-1, rLocale=@0x7fbd83821d98, nMinBreakPos=4, hOptions=@0x118a04620, bOptions=@0x118a045f8) at i18npool/source/breakiterator/breakiteratorImpl.cxx:242
> OutputDevice::ImplGetTextLines (rLineInfo=@0x118a04bb0, nWidth=1, rStr=@0x118a04be0, nStyle=12560, _rLayout=@0x118a04db8) at vcl/source/outdev/text.cxx:527
> OutputDevice::ImplDrawText (this=0x7fbd8302d000, rTargetDevice=@0x7fbd8302d000, rRect=@0x118a05058, rOrigStr=@0x118a04f70, nStyle=12560, pVector=0x0, pDisplayText=0x0, _rLayout=@0x118a04db8) at vcl/source/outdev/text.cxx:1500
> OutputDevice::DrawText (this=0x7fbd8302d000, rRect=@0x118a05058, rOrigStr=@0x118a04f70, nStyle=12560, pVector=0x0, pDisplayText=0x0, _pTextLayout=0x0) at vcl/source/outdev/text.cxx:1754
> sfx2::TitledDockingWindow::Paint (this=0x7fbd8302d000, i_rArea=@0x118a051d0) at sfx2/source/dialog/titledockwin.cxx:218
Change-Id: I95c6027e86b9a608fe9eb05ffb83fb2316c175f2
|
|
Case 1: If PAGEBREAK appears in first paragraph, LO was inserting
BreakType_PAGE_BEFORE but since it was first paragraph, PAGEBREAK
was not rendered in LO hence not exported back to docx file properly.
case 2: If PAGEBREAK appears after first run of any paragraph in document
LO was rendering it in wrong paragraph.
case 3: If COLUMNBREAK appears in first paragraph of section, LO was not
rendering and exporting it.
Change-Id: Ic557b3e6f80cfa6dd3eb6b4204be7e6531b9ecbf
Reviewed-on: https://gerrit.libreoffice.org/9191
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Project: help 400d3515694ff3857f253c8da9ea44b962161ee0
|
|
Change-Id: I77fe282a9dcebde5ad7684aee4597fe4cfb07e11
|
|
Change-Id: Ibb2eca48edb30a88b1ab4bcc35e7e5852efbb436
|
|
Change-Id: I5588e84a486ca751e94e097bc8bceaa35fe8b969
|
|
Change-Id: I7ea90d4be037d9935ef23822512f48b100a446a2
|
|
Change-Id: Iaf2747e64e486f8536c3074f247a3b85dd78bbd1
|
|
Change-Id: I6036988fc53f00f0344623a4d28a2de5962e160a
|
|
This reverts commit 9b8c33ecc561bf8685614ec61d709c8001901fb6.
|
|
Change-Id: I5c3b3c6212524430068e3fd8d9e9d259557bbea2
|