summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-07-06Fix typoAndrea Gelmini
Change-Id: I8d011f948f1e9876a5b22f921c01eab898e8256d Reviewed-on: https://gerrit.libreoffice.org/75151 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-06Fix typoAndrea Gelmini
Change-Id: I84190fa4f5073a4ba480998ed097539e1957e2c4 Reviewed-on: https://gerrit.libreoffice.org/75153 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-06Fix typoAndrea Gelmini
Change-Id: I14ec3a1351ec3fc32f4ead36886a06bb5fd5efe9 Reviewed-on: https://gerrit.libreoffice.org/75150 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-06cid#1448352 Arguments in wrong orderNoel Grandin
Change-Id: I3f7a8aab6608b3ab891fc9ab20448549be3d3dd7 Reviewed-on: https://gerrit.libreoffice.org/75140 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-06no need for XResultSet_impl to extend NotifierNoel Grandin
it never returns any kind of ContentEventNotifier Change-Id: I53d14378c3c70e4797782aa2c35602103c7cf813 Reviewed-on: https://gerrit.libreoffice.org/75139 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-06small optimisationsNoel Grandin
In UNOMemoryStream (a) let the vector use it's natural grow strategy, so we avoid extending the vector by only the small amount we need now. (b) don't throw the vector storage away on truncate, we might need it soon In unoidl/ reserve some vector capacities. Change-Id: I6668a679e689d46d311a9e11eb3d0bc3395f3b6e Reviewed-on: https://gerrit.libreoffice.org/75136 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-06remove duplicate codeNoel Grandin
Change-Id: I75c43d254cd2da2ffb05c1ebd3aaf075ff3da5ec Reviewed-on: https://gerrit.libreoffice.org/75135 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-06simplify and flatten OutDevStateStackNoel Grandin
Change-Id: Ic2ee5c2e122244e11770ab5fb73f65800828439a Reviewed-on: https://gerrit.libreoffice.org/75128 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-06WIN fix some unit tests more generallyJan-Marek Glogowski
Fixes regressed unit test failures from commit 3f7e8ddea89f ("Enable many more unit tests on all archs"). Change-Id: I76a8f7560675b9be3765237f8368d05cff22591d Reviewed-on: https://gerrit.libreoffice.org/75155 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-06Constify GlyphItemJan-Marek Glogowski
This hides all the data, which shouldn't change after init. Real const makes a lot of problems for copying, so this is the 2nd option to just add getters for private data. While at it use typed_flags for the GlyphItemFlags. Change-Id: Ic1eeabe2398f6c30080fdd516285b72c620b11be Reviewed-on: https://gerrit.libreoffice.org/75147 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-05Fix typoAndrea Gelmini
Change-Id: I7e22d7e56e0816f446d9d37ca85c7fddee79bd66 Reviewed-on: https://gerrit.libreoffice.org/75115 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-05Fix typoAndrea Gelmini
Change-Id: Iac082acf6940cef62463d505697243b27387334b Reviewed-on: https://gerrit.libreoffice.org/75112 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-05Fix typoAndrea Gelmini
Change-Id: I6b761a20bfe06936aa6872320caff42b044c84e3 Reviewed-on: https://gerrit.libreoffice.org/75125 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-05Revert "cid#1448383: Resource leak in object (reportdesign/formula)"Julien Nabet
I should have use delete or unique_ptr This reverts commit 99ec957948ce3af0c40e9cb1560e2de59fbc8912. Change-Id: I746c2307ca0d4d6cdbe8dbb1c6fd6de624666726 Reviewed-on: https://gerrit.libreoffice.org/75144 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-05cid#1448260 Argument cannot be negativeNoel Grandin
Change-Id: I147f68c04c8905aac9e790766c260a30cc061d92 Reviewed-on: https://gerrit.libreoffice.org/75141 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-05Fix !HAVE_FEATURE_MULTIUSER_ENVIRONMENT buildJan-Marek Glogowski
The Android-ARM_24-Bytemark-Hosting build currentl< fails with: error: unused parameter ´pLockData´ [-Werror,-Wunused-parameter] Regression from commit 0f9599b687c1 ("Show who has locked the document when reopening a read-only document"). Change-Id: I6d8f900957d79a9c5bf70645e2021995e8a28d43 Reviewed-on: https://gerrit.libreoffice.org/75145 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-05Simplify Sequence iterations in sw/source/filter/*Arkadiy Illarionov
Use range-based loops, STL and comphelper functions Change-Id: I8ec58bdd38061936f621cdfdbfde59a38ac86705 Reviewed-on: https://gerrit.libreoffice.org/75103 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-07-05Make UITests depend on MORE_FONTSJan-Marek Glogowski
Change-Id: Ie81a1d0bfc430ec3a5ca03a5ac76f1c82fee6218 Reviewed-on: https://gerrit.libreoffice.org/74969 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-05Enable many more unit tests on all archsJan-Marek Glogowski
This depends on commit "Make font-based unit test depend on instdir fonts, not that it's sure that this really fixes the problem, as its origin is really unknown. It especially enables all the font-based tests I could find on all archs. Same for many more test where I couldn't see any reason they don't work generally. To get rid of even more ifdefs, it moves these from the class to the functions, so there is actually just one needed for any test. As a result some few tests run but do nothing. There is still some problem with embedded fonts on MacOS and with delayed graphics loading on Windows, so these ifdefs are kept. Change-Id: I63f8424e9debda6cbf3e5777c93245e09f8eb0f2 Reviewed-on: https://gerrit.libreoffice.org/74719 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-05Make font-based unit test depend on instdir fontsJan-Marek Glogowski
The current dependency is already a hack, because there is no way I know of to depend on delivered top-level modules like more_fonts. The original patch parses the gb_Package_MODULE_ooo_fonts list of registered packages to add them as build dependencies. But this is not sufficient, as it just adds the dependencies on the installed / unpacked fonts in the workdir (actually it's just the installer filelist), where they can't be found by the unit test running in the instdir environment. So this converts the depndency into a make error, if either the filelist is missing or the included font files. But if we are in a full run and know the more_fonts module, we simply depend on its delivered files. This needs some minimal changes to gbuild, as neither the delivered file list nor the modules class names are yet available. And this moves the fontconfig handling to extras, where the opensymbol font is already handled. Change-Id: I1b70a4c45ff189266ce56c57e534ddc45e7c5c19 Reviewed-on: https://gerrit.libreoffice.org/74624 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-05WIN get embedded font info from EnumFontFamiliesExJan-Marek Glogowski
Instead of some manual decoding of the .fot file, this extracts all the relevant information of the registered font using the default routines already used when enumerating the system fonts. We still have to extract the font family from the .fot file to know the registered family name of the embedded font. And it uses the OSL functions to create the temporary font resource file name and generally adds more SAL_WARNs when some part of the private font registration fails. Change-Id: I5e118bf1f3bc1fb7bbf4c68a383a45892dffaf98 Reviewed-on: https://gerrit.libreoffice.org/75102 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-05WIN separate LO shared and embedded fontsJan-Marek Glogowski
This way we can get rid of the embedded fonts without the reqirement to re-process all of LO's shared fonts. Change-Id: I25661a611d43ae05052e5cb9cc21e74ccd06b172 Reviewed-on: https://gerrit.libreoffice.org/75101 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-05WIN don't register LO's shared fonts twiceJan-Marek Glogowski
This separates the system registration (AddFontResourceEx) of LO's shared fonts from the later PhysicalFontCollection population using EnumFontFamiliesEx. Calling AddTempDevFont from GetDevFontList creates a new WinFontFaces, but the later EnumFontFamiliesEx also creates WinFontFaces for all registered fonts, resulting in duplicate WinFontFace entries in the PhysicalFontCollection. Also currently the provided WinFontFace from AddTempDevFont is much less accurate, compated to the EnumFontFamiliesEx one. Change-Id: I2cd8af77197429508d0a7112ff98706d7f449659 Reviewed-on: https://gerrit.libreoffice.org/75067 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-05sw lok: hide UI to set Word-incompatible anchor typesMiklos Vajna
Let's make it a bit harder for users to hurt themselves, at least in Online. Affects the context/popup menu and the dialog of frames. This is similar to how certain border types are hidden on the UI, depending on if MSO supports them. Though that goes a bit further and disables those types even on the desktop. Change-Id: I6b9205ef3df8a7bc15fbcf787d134743c09e98da Reviewed-on: https://gerrit.libreoffice.org/75129 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-07-05Related tdf#98575 Add "Edit Hyperlink" to context menu in sdSamuel Mehrbrodt
Change-Id: I121373fae5122e779614a53ac73b4b9d058908d2 Reviewed-on: https://gerrit.libreoffice.org/75126 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-05SmartArt: remove calculateHierChildOffsetScale() from org chart algorithmGrzegorz Araminowicz
Its purpose was to center subtree if sibling parent has no children. It was not working correctly for complex charts causing shapes to overlap. Without it chart is still readable (just sometimes not centered). Remove it for now until more universal solution is found. Change-Id: I397bd4264d6ce0fadf5c5fa1352f22e72d5d163a Reviewed-on: https://gerrit.libreoffice.org/75092 Tested-by: Jenkins Reviewed-by: Grzegorz Araminowicz <grzegorz.araminowicz@collabora.com>
2019-07-05flatten and simplify FontMetricNoel Grandin
Change-Id: I9cce47c132345e40d3500ba69178e871d68bf764 Reviewed-on: https://gerrit.libreoffice.org/75130 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-05Remove executable bit from source filesAdolfo Jayme Barrientos
Accidentally added in commit ff7e327e9e537ea129464a1de5a01bf32c1b9fd3 Change-Id: Ia27ce22cfabdbbd9abfa0b67a8b4a8b5986eab6f
2019-07-05qtcreator: Make paths work with cygwinMichael Weghorn
Absolute paths in files created by GbuildToJson in Cygwin environment are Windows paths (like "C:/....'), while relative paths in the Python program executed in Cygwin are treated as Unix paths ('/cygdrive/c/....') which caused wrong relative paths to be generated by the call to 'os.relpath'. It would walk up to the root of the Windows path and then walk down the tree in the Unix file system path again. This converts the paths to absolute Windows paths first to avoid this issue. Change-Id: I2e3e6926e312d64aa18067933a5903ac7ad5d31a Reviewed-on: https://gerrit.libreoffice.org/75114 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-07-05Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Insert sys=MAC in some menu paths MAC often forgotten in menu path descriptions. Change-Id: Ib6e9062b06389063d6f8293a95cd3e07e1919161 Reviewed-on: https://gerrit.libreoffice.org/75040 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-07-05Show who has locked the document when reopening a read-only documentMike Kaganski
Pass the locking data from SfxMedium::LockOrigFileOnDemand, to allow clients to show it themselves when required. Change-Id: I6afe46a1896e1b60771c080efa2f58794dbed8a6 Reviewed-on: https://gerrit.libreoffice.org/75113 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-05tdf#93476 Sort Macro library list after creating/importing a macroAndreas Heinisch
Added sorting to modules, dialogs and libraries using locale Change-Id: Ie9dcadc593beb13417f38b83958a8aeeb77698ee Reviewed-on: https://gerrit.libreoffice.org/74692 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-05tdf#125863 Rework tdf#107593 so header footer delete doesn't crashJim Raykowski
Header footer delete from the last page when last page is unneeded (stack level 24 SwRootFrame::RemoveSuperfluous /// remove pages that are not needed at all) causes SwFrameMenuButtonBase::dispose() which sets m_pFrame to nullptr which causes crash when IsEmptyHeaderFooter calls GetPageFrame(). Doing ToggleHeaderFooterEdit() when header or footer deletion is accepted in SwWrtShell::ChangeHeaderOrFooter avoids the crash. SwHeaderFooterWin is also disposed which would make the GrabFocusToDocument crash if it got that far so use the shell window which is still valid here to GrabFocusToDocument. Change-Id: Iaced23e6716442671c5ea29b79be178f4fc836d3 Reviewed-on: https://gerrit.libreoffice.org/75010 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2019-07-05tdf#120338 DOCX: add rejection of paragraph formatting changesLászló Németh
using imported change tracking data, instead of doing nothing for the user request. Change-Id: I37775ae2d9b78fe3a31541a331f686af9ca9094f Reviewed-on: https://gerrit.libreoffice.org/75089 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-07-05tdf#42949 Fix IWYU warnings in sw/inc/*Gabor Kelemen
New IWYU and recent developments in f-u-i helped to identify some non self contained files and mostly those were fixed. Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I21550193293b987311c56d8f7c9c3145547d2c6d Reviewed-on: https://gerrit.libreoffice.org/74909 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-05sw btlr writing mode: handle import from VMLMiklos Vajna
Instead of the character-level rotation added in commit 8738ded7bb1bb6262fe1038e310b5110407f4cfa (fdo#69636 VML import: handle mso-layout-flow-alt shape prop for sw frames, 2013-09-26) which does not work for multiple paragraphs. Change-Id: Ibe9a85d7f880846edfd1f4594c03b0617d83a965 Reviewed-on: https://gerrit.libreoffice.org/75104 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-05Colibre, Breeze, elementary, KJ: tdf#107144, Breeze: tdf#126233rizmut
- Add Impress transition, 3D related icons - Add many 32 px size for Calc and Draw specific icons - Fix blurred icons - Add more missing menu items Change-Id: I915e31aee51e84c88dd99e1fa3f6d5a4c7ca50d0 Reviewed-on: https://gerrit.libreoffice.org/75106 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2019-07-05tdf#126069 Set fixed height level and preview frames.Gülşah Köse
Set fixed height for level and preview frames to avoid overlapping non-gtk backends. This change needed for when we set the spacing our list. To see real spacing, preview frame's height shouldn't be change. Change-Id: I78b5277f447f751f6e7e411cd6d5eef0b34e394a Reviewed-on: https://gerrit.libreoffice.org/75066 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-07-05tdf#121740 improve ppt load time on windows, reduce image swapoutNoel Grandin
Reduces load time of this file by 10%. This logic is here since commit 8ab086b6cc054501bfbf7ef6fa509c393691e860 Date: Mon Sep 18 16:07:07 2000 +0000 initial import and there does not seem to be any good reason to immediately trigger a swapout. Our balancing logic will perform a swapout as necessary. Change-Id: I02592dfd3bde1a00bcca2fcbcd4d38aacc8f3de4 Reviewed-on: https://gerrit.libreoffice.org/75086 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-05move the contour-finding code inside vclNoel Grandin
Change-Id: Iac52b72831868a917fc445e970edabc1c2585b55 Reviewed-on: https://gerrit.libreoffice.org/75080 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-05tdf#83618 Make line spacing values agreeJim Raykowski
Change-Id: I372a673bbad442d28314498248b12ce7f86fce09 Reviewed-on: https://gerrit.libreoffice.org/73737 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-07-04cid#1448299: Constant expression result (sw/basesh)Julien Nabet
Change-Id: Id4fab1797be58acd179d6e0fc7c9be21c454e676 Reviewed-on: https://gerrit.libreoffice.org/75105 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-07-04cid#1448425: Resource leak (sc/htmlprovider)Julien Nabet
Change-Id: I3c23280da75e51be37c4b66f14f805ca49ebf3cf Reviewed-on: https://gerrit.libreoffice.org/75095 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-04cid#1448320: Resource leak in object (l10ntools/treemerge)Julien Nabet
Change-Id: I9d09d690e003d73878ef2e30da11cf079d0db441 Reviewed-on: https://gerrit.libreoffice.org/75098 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-04cid#1448518: Resource leak (test/xmltesttools)Julien Nabet
Change-Id: I7894b65e2b20ce94d53a7ca04eb229347145686c Reviewed-on: https://gerrit.libreoffice.org/75097 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-04cid#1448383: Resource leak in object (reportdesign/formula)Julien Nabet
Change-Id: Ia57e6961dab9be857e81289f8d2d20f82f24643d Reviewed-on: https://gerrit.libreoffice.org/75099 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-04cid#1448515: Resource leak (test/xmltesttools)Julien Nabet
Change-Id: Ifadb599697fca738a41e4aad098edf4de32e174f Reviewed-on: https://gerrit.libreoffice.org/75096 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2019-07-04cid#1448380: Resource leak (avmedia/gstplayer)Julien Nabet
Change-Id: Ieaf5f68f17558f27e187241869c8fe01f8e29ba2 Reviewed-on: https://gerrit.libreoffice.org/75094 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-04Update git submodulesChristian Lohmaier
* Update translations from branch 'master' - update translations for 6.3.0 rc1 and force-fix errors using pocheck Change-Id: Icf55b3be0f6fbcb1993f3b4bc57161b89d3429e7
2019-07-04sw comments on frames: fix comment insert for as-char frame at para startMiklos Vajna
This adapts SwWrtShell::InsertPostIt() to behave similar to commit 86fd893e32ef7a737b2c4b60e0938146b102fc07 (sw comments on frames: delete comment of frame when deleting frame, 2019-07-03), i.e. instead of hoping that the cursor will be at the end of paragraph and traveling back, just set the cursor to the remembered anchor position. This is cleaner, and as a side-effect also fixes the scenario when creating a comment on an as-char image, which happens to be at the start of the paragraph. Change-Id: Iedca0feb62242677b6e8b69ef7b813d6da72c8eb Reviewed-on: https://gerrit.libreoffice.org/75093 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-01-10 12:27:31 +0000