summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-06-29Fix typosAndrea Gelmini
Change-Id: If6fafa1ef192411a9d59ef9a4ef4d7f522c67f66 Reviewed-on: https://gerrit.libreoffice.org/55964 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-06-29tdf#118425 xmlsecurity UI: fix OOXML signingMiklos Vajna
Regression from 13596e704e4b48e8b0892867b3f3fc351a2729f9 (Don't pass ODF version, just retrieve it directly, 2018-05-17), just checking the file format explicitly like the PDF signing does fixes the problem. Change-Id: I1ba7cf9096e01c6c5a2d3875b08fa3a66acae829 Reviewed-on: https://gerrit.libreoffice.org/56635 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-29tdf#96099 Remove trivial std::map typedefs in [cd]*Arkadiy Illarionov
Change-Id: I043d265d3d73a3e16f05d5ca7e29a09341651d82 Reviewed-on: https://gerrit.libreoffice.org/56639 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29loplugin:useuniqueptr in SwOLEObjNoel Grandin
Change-Id: I36b14c31bfdf66b158dd2cf8f6a7a125d52cddb5 Reviewed-on: https://gerrit.libreoffice.org/56627 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29loplugin:useuniqueptr in SwGrfNodeNoel Grandin
Change-Id: I9f0993f7fbbdaf7552fe0b0c19d3fca691471fa8 Reviewed-on: https://gerrit.libreoffice.org/56626 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29loplugin:useuniqueptr in SwEnterLeaveNoel Grandin
Change-Id: I948c146f675675c1902c158be4d97b6d19679a51 Reviewed-on: https://gerrit.libreoffice.org/56625 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29loplugin:useuniqueptr in SwTextAPIObjectNoel Grandin
Change-Id: Ied235aefe2cc2ce5e88487503c17e1a54d25ac52 Reviewed-on: https://gerrit.libreoffice.org/56624 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29loplugin:useuniqueptr in SwTableNodeNoel Grandin
Change-Id: I28bca27b6841ba9b263392b2e30f8684a8e2c4e5 Reviewed-on: https://gerrit.libreoffice.org/56622 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29loplugin:useuniqueptr in ScAnnotationEditSourceNoel Grandin
Change-Id: Ia1ba66e511fc5ad9b0871d04df859cd79d7521a5 Reviewed-on: https://gerrit.libreoffice.org/56621 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29loplugin:useuniqueptr in ScCellFieldsObjNoel Grandin
Change-Id: I894abfcfd9b2710a1aa81cca94158dbe4a7d9eeb Reviewed-on: https://gerrit.libreoffice.org/56620 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29loplugin:useuniqueptr in various ScUndo*Noel Grandin
Change-Id: I604d7b900836e87fc768e1b00dc62a570ff477b5 Reviewed-on: https://gerrit.libreoffice.org/56619 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29inline DeleteSdrUndoActionNoel Grandin
so that loplugin:useuniqueptr can trigger on it Change-Id: I04d68278f870ec137b3a78491e83e8adc7374fa4 Reviewed-on: https://gerrit.libreoffice.org/56618 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29loplugin:useuniqueptr in ScEditWindowNoel Grandin
Change-Id: I0398045030b8c2dcc8cd8e47112271c80d194616 Reviewed-on: https://gerrit.libreoffice.org/56617 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29tdf#114227 Add support for OS proxy to ucbhelper::InternetProxyDecider on UnixNoel Grandin
Also make m_nProxyType a scoped enum so the code is a little easier to follow. Change-Id: Ic2862a1de8fe1005c4fb25147b3effc49b95140c Reviewed-on: https://gerrit.libreoffice.org/56599 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29menubar draw update zoom subgroup in viewandreas kainz
in every app there is in view as last subgroup zoom ordinary you have fullscreen and zoom with the submenu as in draw there fuulscreen isn't available panning was shown and the submenu was updated to show also the draw specific zoom items Change-Id: I390ac40815aa28c7df883cf63dcd214b181785ed Reviewed-on: https://gerrit.libreoffice.org/56586 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-06-29Menubar: move InsertDoc in ObjectMenu Subsection like in calcandreas kainz
Insert section in writer is very long and when move InsertDoc into the Object Subgroup it will be on the same level than in calc Change-Id: Ie34b5853dd462ed17df02f645a1e6953beaf3f13 Reviewed-on: https://gerrit.libreoffice.org/56584 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-06-29tdf#118442: Fix incorrect index calculationMike Kaganski
If a number string has leading spaces and/or minus, then calculating index into the aBuf as the difference between p and pStart gives wrong (too big) number. This asserts in debug builds, when e.g. an assignment is made in a BASIC macro: Dim f As Double f = " -12.20" "include/rtl/ustrbuf.hxx:490: sal_Unicode &rtl::OUStringBuffer::operator[](sal_Int32): Assertion `index >= 0 && index < pData->length' failed." This affects, e.g., https://gerrit.libreoffice.org/56610 (see https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/9527/consoleFull#1820989527d893063f-7f3d-4b7e-b56f-4e0f225817cd) Change-Id: I14654166be721907e2a26ea6f4091f203a9437d7 Reviewed-on: https://gerrit.libreoffice.org/56611 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2018-06-29tdf#118421 ww8export: rotate vertically: not Lines or groupsJustin Luth
Lines and Groups often are exceptions. Normally, the import code swaps vertical rotations also. In the case of lines (from the tests that I observed) lines don't have a rotation value at that point during import, so no correction is made. Grouping always messes things up. Change-Id: I344c5a29f887294b751ffc87c01b30e472cfb4c2 Reviewed-on: https://gerrit.libreoffice.org/56595 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2018-06-29Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I0229c3221a2b4d1bc0b8fa3a0347c9e97136f333 Reviewed-on: https://gerrit.libreoffice.org/56646 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-06-29uitest for bug tdf#116474Zdeněk Crhonek
Change-Id: I6b19626bf872c2eff61c57342579ec682a1c37d0 Reviewed-on: https://gerrit.libreoffice.org/56632 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-06-29Colibre icons: add 32px iconsandreas kainz
Change-Id: I696d3f643166f4a581e666c3a1b1340a3ab69499 Reviewed-on: https://gerrit.libreoffice.org/56640 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-06-29tdf#45904 Move _XDocumentAuditing Java test to C++Jens Carl
Change-Id: Ic03e42c9c2ff27579b442dc8d1408deaea839ec4 Reviewed-on: https://gerrit.libreoffice.org/56644 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-06-28Colibre icons: update 3d iconsandreas kainz
Change-Id: I248a0c7f32c2cfb1891fd618025f89f53e216267 Reviewed-on: https://gerrit.libreoffice.org/56636 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-06-28Colibre icons: update shadowed iconsandreas kainz
Change-Id: Id6fadce6125a61d50f6211bf5c214974c923a8ad Reviewed-on: https://gerrit.libreoffice.org/56638 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-06-28writer: add icons for menubar actionsandreas kainz
Change-Id: Ib222936295c4815f9d87a0da4c2c7a93c929391c Reviewed-on: https://gerrit.libreoffice.org/56604 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-06-28Updated coreTor Lillqvist
Project: dictionaries fe72d24920c8a4dcbee18925cb19e6b6625f6553 tdf#118423: Fix problems introduced by my recent pt_BR speedup Change-Id: I25b1d11e13c01678195210d42597281896543ff2 Reviewed-on: https://gerrit.libreoffice.org/56612 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-06-28lok: Don't even try to paint the ruler via LibreOfficeKit.Jan Holesovsky
But we need to have it behind the scenes, otherwise the Online's ruler does not get notifications. Change-Id: I72bef28cb15c462572b511449d538b067f7cb141 Reviewed-on: https://gerrit.libreoffice.org/56598 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit ee6e6bd5b853aa68c9721f53b5892384e7403eec) Reviewed-on: https://gerrit.libreoffice.org/56601 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-06-28Remove leftover importStephan Bergmann
...from 1b4c09401053ff6df8de9e839299ac26efa28b37 "uitest Calc/Goal seek; tdf#37341 ; tdf#43693" Change-Id: I7c346311c975709e71ca332a8894e6df7a745ab6 Reviewed-on: https://gerrit.libreoffice.org/56588 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-28Curious inconsistency of SvxPageModelItem copy functionsStephan Bergmann
...where the implicitly-defined copy ctor will copy the bAuto member while the user-provided copy assignment op does not. The code is like that ever since at least c779feb1dfa340d61902dcd9d0b754046ffd8e5b "INTEGRATION: CWS hedaburemove01". The bAuto member is only used in Put/QueryValue with MID_AUTO, but MID_AUTO appears to be effectively unused? So lets assume that the user-provided copy assignment op is like that due to a (presumably harmless?) accident, and make it implicit, too. (Avoids -Wdeprecated-copy with GCC trunk towards GCC 9.) Change-Id: I4e3156305e2b9862d337074105edc4317538af1f Reviewed-on: https://gerrit.libreoffice.org/56592 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-28Colibre icons add some 32px iconsandreas kainz
Change-Id: I480178687b3403b60d3466ce44524a4ce8753d48 Reviewed-on: https://gerrit.libreoffice.org/56583 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-06-28schema: fix some obvious issues in ODF 1.3 schemasMichael Stahl
editorial changes: * maintain alphabetical sorting (by moving some of the new named patterns) * consistent indentation substantive changes: * manifest schema: for no apparent reason, the QName pattern lost its + * OFFICE-2118: Fatal: reference to the undefined pattern "table-data-pilot-groups" * OFFICE-3857: Fatal: more than one attribute accepts the same name "scale-to" * OFFICE-3933: the removal part of the diff was not applied * OFFICE-3883: applied one line off, with missing rng: namespace prefix * OFFICE-3928: - removed combine=interleave attribute (was in 1.1 but no longer used in 1.2 schema) - added missing rng: prefix to <empty> Change-Id: I80871dec69b1dbc7b1438366d895c443a44fb72c Reviewed-on: https://gerrit.libreoffice.org/56398 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-06-28schema: update to latest available ODF 1.3 draft schemasMichael Stahl
OpenDocument-schema-v1.3-wd06.rng OpenDocument-manifest-schema-v1.3-wd01.rng OpenDocument-dsig-schema-v1.3-wd01.rng (same for libreoffice dir, those are unchanged currently) Change-Id: I8f5c3069d436a501ce87223c4fdaa7c657fe7218 Reviewed-on: https://gerrit.libreoffice.org/56397 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-06-28tdf#53993 broadcast the change when dragging ends.Mark Hung
Eventually MotionPathTag::Notify() and CustomAnimationPane:: updatePathFromMotionPathTag will be called to update the motion path of the effect. Change-Id: I1cd0756ea24d9b56ad3c44c99ef015c584c74dc7 Reviewed-on: https://gerrit.libreoffice.org/56353 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-06-28tdf#107690 DOCX, XLSX and PPTX unit tests for "Open as read-only"László Németh
ie. OOXML export/import of "_MarkAsFinal" MSO document property. Change-Id: I01f0702d5467e78eb93ce8dce8ba25874839c3e3 Reviewed-on: https://gerrit.libreoffice.org/56475 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-06-28tdf#107690 OOXML import/export of setting "Open as read-only"László Németh
Import custom document property _MarkAsFinal as LoadReadonly setting, export LoadReadonly as _MarkAsFinal in DOCX, XLSX and PPTX documents. Before this fix, LibreOffice opened read-only OOXML documents as editable, also saved and exported _MarkAsFinal=true silently, resulting unintented read-only warning info bar in MSO. This commit improves interoperability a lot, because this is a basic document protection of MSO, recommended on its UI. Note: LoadReadonly (on File->Properties...->Security, property "Open file read-only") doesn't show "Edit read-only" info bar from commit 630186ff4e0eba7317e542f8c3eca39ebd068721, but it's still possible to switch on editing by Edit->Edit Mode. MSO shows info bar for _MarkAsFinal. (There is an advantage to hide the info bar in LibreOffice in a mixed environment, to avoid overwriting of press-ready MSO files by LibreOffice.) Note 2: Other differences of LoadReadonly in LO and _MarkAsFinal in MSO: (1) Switching on editing doesn't remove the LoadReadonly property automatically in LO. (2) Saving with LoadReadonly doesn't switch off editing of the actual (still opened) document in LO. Change-Id: Ie279c0670090d075103384cfa44ff1c2a2898216 Reviewed-on: https://gerrit.libreoffice.org/56180 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-06-28Document correct @param name NativeNumberParametersEike Rathke
Jenkins for 'NativeNumberParams' unfortunately only on 6-1 bailed out with /home/tdf/lode/jenkins/workspace/gerrit_windows@2/offapi/com/sun/star/i18n/XNativeNumberSupplier2.idl:57: warning: The following parameters of com::sun::star::i18n::XNativeNumberSupplier2::getNativeNumberStringParams([in] string NumberString, [in] ::com::sun::star::lang::Locale Locale, [in] short NativeNumberMode, [in] string NativeNumberParameters) are not documented: parameter 'NativeNumberParameters' Change-Id: I3379e1bba5b79196c86410e0115d04eba49dc2a2
2018-06-28Fix typosAndrea Gelmini
Change-Id: I1b966b636f67a549718ca19c00c2820e8d168c7a Reviewed-on: https://gerrit.libreoffice.org/56589 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-06-28tdf#86612: statusbar: hide some elements if width is not sufficientVasily Melenchuk
new statusbar element property mandatory=true/false to determine if this element can be hidden if total statusbar width is not enough to fit all elements. marked some calc and draw statusbar elements as not mandatory. Change-Id: I20e26d3c4bd865e94ea48632a1e97d55f3fa712f Reviewed-on: https://gerrit.libreoffice.org/56443 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-06-28tdf#117866 cui personalization: fix a possible raceMiklos Vajna
The case when the thread is re-scheduled exactly after checking for m_bExecute but before taking the solar mutex. Change-Id: I494c123a6225da60407391771622208c055ae49b Reviewed-on: https://gerrit.libreoffice.org/56585 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-06-28tdf#36867 - Undo autocapitalization when inserting a cell in CalcNickson Thanda
Change-Id: Ia70144d6c86b1b08e14425bf537e9c39d585a614 Reviewed-on: https://gerrit.libreoffice.org/55820 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-06-28tdf#118429 Provide unsigned signature imageSamuel Mehrbrodt
when creating signature line. OOXML Export expects this. Change-Id: Ib6ab1f879c5ef27e8347002576ba95104117cadd Reviewed-on: https://gerrit.libreoffice.org/56576 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-06-28Clean up ownership tracking of SalVisual's visual (in X11 Visual base class)Stephan Bergmann
GCC trunk towards GCC 9 emits -Wdeprecated-copy because SalVisual has implicit copy functions but a user-declared dtor. The implicitly-defined copy functions are actually used (so cannot be deleted), but in fragile interaction with the semantics of the user-provided dtor in the SalColormap(sal_uInt16) ctor. Changing SalVisual into a move-only class (moving the "this instance must delete its visual member" information) doesn't work well, as SalDisplay::ScreenData is used as a supply of SalVisual instances (but which will never be of the "this instance must delete its visual member" variety) that are then copied into SalColormap::m_aVisual. As only SalColormap creates SalVisual instances of the "this instance must delete its visual member" variety, what actually works is to track that information in SalColormap instead of directly in SalVisual, and make SalColormap a move-only class. Change-Id: Ib968a38c40b660ce91981b3c7b281f4add6ece6b Reviewed-on: https://gerrit.libreoffice.org/56579 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-28tdf#102195: don't exclude everything between first and last subsetMike Kaganski
When subsets are non-contiguous, we need to include the parts between subsets. Change-Id: I28214dccc75e6a6af5c65397b2126049a65bf79f Reviewed-on: https://gerrit.libreoffice.org/56571 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-06-28loplugin:useuniqueptr in ScAccessiblePreviewTableNoel Grandin
Change-Id: I75b37dab51f3510f6e7155c191a85af99b0d350f Reviewed-on: https://gerrit.libreoffice.org/56547 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-28tdf#42949 Fix IWYU warnings in include/osl/*hGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib2301526d7aa6982af6c8c79ed7e9a4c34b7bbf7 Reviewed-on: https://gerrit.libreoffice.org/56491 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-28pdfium: replace FPDFPath_GetDrawMode() patch with backportMiklos Vajna
Change-Id: I86c7c0f73a21f670676716d7c22f519ed82da145 Reviewed-on: https://gerrit.libreoffice.org/56544 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-28loplugin:useuniqueptr in ScConsolidateDlgNoel Grandin
Change-Id: I80cd0b051a137f51aa03ebc573369c945ca502da Reviewed-on: https://gerrit.libreoffice.org/56553 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-28loplugin:useuniqueptr in ScUndoDBDataNoel Grandin
Change-Id: I6107079f8474a2ddc76a9cb6e93552d95861dc6c Reviewed-on: https://gerrit.libreoffice.org/56563 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-28loplugin:useuniqueptr in ScAutoFmtPreviewNoel Grandin
Change-Id: I748382e73a2e2b80292e8c396cb61ca805c03549 Reviewed-on: https://gerrit.libreoffice.org/56562 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-28loplugin:useuniqueptr in ScUndoWidthOrHeightNoel Grandin
Change-Id: I224c5d7b2562cc0ad5d03dc7dffc5476c83a5f54 Reviewed-on: https://gerrit.libreoffice.org/56561 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-01 10:45:20 +0000