summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-09-28Revert "cid#1607805 Overflowed constant"Noel Grandin
This reverts commit f063ea562c6ba14db15b9773bdcbb18af4a72ff8. Reason for revert: bad idea. We're not going to re-evalute the loop condition if we use a goto Change-Id: I8b892cd35c3560396f65619cd095a9b186ecbd24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174011 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-28cid#1607100 Overflowed constantNoel Grandin
Change-Id: I930e8661845c3c089e8d3d5b180815b1d65d4423 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174153 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-09-28tdf#163154 revert "tdf120224 writerfilter: consume excess bookmarkJustin Luth
... from fields" The intention of my 6.2 commit 579c0749bef8c980507229439715e72060c1b077 hack was to avoid importing duplicate LO-exported bookmarks. (LO exported the bookmarks inside the field definition, while MS normally has the bookmarks outside the field.) So the impact of this revert should be neglible, affecting mainly documents that LO round-tripped before 6.2 which would just import one more "Copy" of a bookmark. The reason for doing the revert is also not terribly important. For a few odd documents that otherwise wouldn't import a bookmark around a field, it will allow the LO navigator a way to quickly jump to the field (since Legacy Fields are not included in the Navigator's field list). Note that what I am reverting was a HACK any way. It did a pretty good job of only ignoring LO-exported bookmarks, since MS Word usually puts the bookmark around the OUTSIDE of the field, while LO always puts the bookmark inside the field definition (and thus IsOpenField()) make CppunitTest_sw_ww8export3 \ CPPUNIT_TEST_NAME=testTdf79435_legacyInputFields make CppunitTest_sw_ooxmlexport12 \ CPPUNIT_TEST_NAME=testTdf120224_textControlCrossRef Change-Id: Iefaf1173794c66b2a6f3e5c2143ed594de7efe35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174081 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-09-28cid#1607041 PA: Public AttributeCaolán McNamara
Change-Id: I8ec74e943232f98c861e035c0da11e8d75f8fa29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174106 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-28cid#1606705 Overflowed constantCaolán McNamara
and cid#1607841 Overflowed constant Change-Id: Ia84d2c0d29e485379fe6338a784306bc8ff5343b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174105 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-28cid#1607672 silence Overflowed constantCaolán McNamara
Change-Id: I8f66304c961d78c9f8745c68f2e7c6a3d8283586 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174104 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-28cid#1608030 Check of thread-shared field evades lock acquisitionCaolán McNamara
and cid#1608103 Check of thread-shared field evades lock acquisition Change-Id: Ifb3191512434f4938f02bfa1a1b6ed038b3e555e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174103 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-28cid#1557088 Data race conditionCaolán McNamara
since: commit d181d8acbf49e2fe87c8cf53a9431e503ccced55 CommitDate: Fri Aug 25 12:44:33 2017 +0200 tdf#84237 use XErrorHandler in CDocumentBuilder Change-Id: Iac1d2b88f2910298d30de4d12798bb38c36a0de9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174102 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-28cid#1620316 Uninitialized scalar variableCaolán McNamara
Change-Id: I3ef7f30dc2045b0386bd7f14c0e9be34f7e67726 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174101 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-09-28cid#1607680 Overflowed constantNoel Grandin
Change-Id: I8522cfe5422c187b9045858c2f94753d0f2c8714 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174123 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-28cid#1607687 Overflowed constantNoel Grandin
This code does not appear to be handling the case where there is no anchor correctly, all the way back to commit c5718b941491ffaa937767c579627444c0957b86 Author: Andreas Bille <abi@openoffice.org> Date: Wed Oct 31 12:08:14 2001 +0000 #83054# Now reading the necessary variables( provider.cxx ), Change-Id: Ia8f514a95ca2e3ae17129b34f0ed444cd9d0ade8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174122 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-28cid#1607691 Overflowed constantNoel Grandin
Change-Id: Ib3f32065334769298483d4cf9131040ab28a3a1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174121 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-28cid#1607692 Overflowed constantNoel Grandin
use less convoluted logic here Change-Id: I786d7f857c7104358559782247c4272914299314 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174112 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-09-28Update git submodulesSahil Gautam
* Update helpcontent2 from branch 'master' to 0d61990c85ed2135a6064b6caf1e989e820cd65c - tdf#85976 Help page for HandleDuplicateRecords dialog https: //gerrit.libreoffice.org/c/core/+/160685/comments/9dd92aa8_beae1c5f Change-Id: I4ce7ad0022ed34b3704a3a5b17416eabcf91dd03 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173142 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-09-28cid#1607751 Overflowed constantNoel Grandin
help out coverity by asserting what should be true here Change-Id: I1c98c29cccf0fd40eb6cc19699428872a5bf56a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174111 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-28cid#1607790 Overflowed constantNoel Grandin
Change-Id: Ia2b180d6a93f139a0f83653ee45b4ad929ccef45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174110 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-28cid#1607805 Overflowed constantNoel Grandin
Change-Id: Id146853a86a54597a1e07efba6c86abc10d93796 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174109 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 14476c266b8097805df0292dc9a07468024c12f0 - tdf#162607 disambiguate hid2file.js, DBNew* + Removed bookmark from the toolbars help page + refactor Change-Id: Ie51d6b61f735f041b677d711203729476af4625d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/174148 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-09-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 909308152bef7ce6bc4bdac384aaf55f2431b7eb - tdf#162607 disambiguate hid2file.js, paste special + Removed bookmark from sdatabase file Change-Id: I9922d86768ea79ed7fa652fb0af62ba165d82aee Reviewed-on: https://gerrit.libreoffice.org/c/help/+/174147 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-09-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to ac18fb999e675f78ce6f2b687a67ea001edf5ccd - tdf#162607 disambiguate hid2file.js, SaveGraphic + Removed bookmark from simpress file Change-Id: Ia9ddb3cd9f2c1d6b8a611e958d5b966d882092d9 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/174146 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-09-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to d81dc3348d3ac27155b0f9b021d95c7599848150 - tdf#162607 disambiguate hid2file.js, TableBoundaries + Removed bookmark from the options help page Change-Id: If3b3aa13283e0f6733640676137d834fb8662475 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/174145 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-09-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 446f60711a2d62504ac3011987ad22fb64af6ffc - tdf#162607 disambiguate hid2file.js, uno:ScrollBar + Remove useless bookmark Change-Id: I38689febf073c29353fb1b7e089617eed3d52b69 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/174144 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
2024-09-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to b038ab4ef42ff67d505cdf5deddfe492852ad56b - tdf#162607 disambiguate hid2file.js, uno:SheetMenu + Remove singleton help file used nowhere (superseeded by scalc/main0116.xhp) Change-Id: I5e675d84c9e54fcf0d2bf7c3f0c46bd6de6d43aa Reviewed-on: https://gerrit.libreoffice.org/c/help/+/174143 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-09-28cid#1620317 COPY_INSTEAD_OF_MOVEJulien Nabet
Change-Id: I7d31cf2a977cb095a6d3cd89f9cadf82bea3bddd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174099 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-09-28cid#1620321 COPY_INSTEAD_OF_MOVEJulien Nabet
Change-Id: I9030fafe12bb48d43049493102de23ca8212cd9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174087 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-09-28cid#1620328 UNINIT_CTORJulien Nabet
Change-Id: I4c56bf457920bb3800413d5e2289e49e5d64eb0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174085 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-09-28cid#1620326 UNINITJulien Nabet
Change-Id: Ic99797c2e286e25e7803668480a1aabd26cdca27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174086 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-09-28Typo: bDuplicatRows->bDuplicateRowsJulien Nabet
Change-Id: I307c81013723d6b47cf2e7f98ce9ac2e179136f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174100 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-09-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 6ad81aa6d12b615374b39d0eb7e2dec4e12ebcbc - More tweaks in XHP DTD Added more entities Change-Id: Idc529efd6f26496e22ac56586622c4b54742531f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/174037 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-09-28tdf#163183 Improve Tip of the day 8/225Bogdan Buzea
Change-Id: Ib9bb049afc56a889d764aa9d3a9c0bcf5a1ea1f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174009 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins
2024-09-28setParentStorage is always called with an empty referenceCaolán McNamara
Change-Id: I973811b3e8aa41bc331362a96a7cb519aec363a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174068 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-28tdf#130857 qt weld: Declare support for "License Information" dialogMichael Weghorn
Now that previous commits have implemented what's needed to display the dialog and for button clicks to result in the expected action, add the .ui file for the "Help" -> "License Information" dialog to the list of supported .ui files for QtInstanceBuilder, so native Qt widgets will be used for that one with the Qt-based VCL plugins unless starting LO with the SAL_VCL_QT_NO_WELDED_WIDGETS environment variable set. Change-Id: I8a2dff1c751739567a3c9c0728e3357859069a9b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174080 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-09-28tdf#130857 qt weld: Close dialog on button clickMichael Weghorn
For QDialogs (created for "GtkDialog" objects in .ui files) that have a button box, let clicking any of the buttons that have a response code set close the dialog with that response code by connecting to the QAbstractButton::clicked signal. This addresses the remaining aspect for the "Help" -> "License Information" dialog mentioned in earlier commit Change-Id: Ic9393755ec474f77ff22a1115e3cccba9d7b26cb Author: Michael Weghorn <m.weghorn@posteo.de> Date: Sat Sep 28 00:07:28 2024 +0200 tdf#130857 qt weld: Add initial support for dialog and label > However, currently (...) clicking the buttons doesn't yet have any > effect. Actually using Qt(InstanceBuilder) for that dialog will be enabled in an upcoming commit. Change-Id: Ie3c26963318fd5832688e3ed73f6952e09da4bb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174079 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-09-28tdf#130857 qt weld: Move button response prop to QtInstanceDialogMichael Weghorn
It will be used for QDialog as well, not just QMessageBox Change-Id: I887b3fe45beea40cc92f2b0b77f316ad73d7f922 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174078 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-28tdf#130857 qt weld: Ensure dialog button box is last in layoutMichael Weghorn
For QDialog, make sure that if a button box is included in the dialog's layout, that this is the last item in the layout, by removing from the layout and adding it at the end again. I don't see any explicit child index explicitly being set in the .ui file for the "Help" -> "License Information" dialog ("sfx/ui/licensedialog.ui"). Potentially GTK implicitly visually makes the dialog's button box the last item in the dialog. Corresponding child is this one: <child internal-child="action_area"> <object class="GtkButtonBox" id="dialog-action_area1"> Potentially the `<child internal-child="action_area">` identifies this as the dialog's button box that should be last, at least dialog newly created in glade also has that set. For QMessageBox, which is a QDialog subclass, this special handling is not needed, as its default button box is used, which is already at the right place. This addresses the first aspect mentioned in previous commit: Change-Id: Ic9393755ec474f77ff22a1115e3cccba9d7b26cb Author: Michael Weghorn <m.weghorn@posteo.de> Date: Sat Sep 28 00:07:28 2024 +0200 tdf#130857 qt weld: Add initial support for dialog and label > However, currently buttons and the label with the text > are in the wrong order (i.e. buttons are above the text) Still missing: > and clicking the buttons doesn't yet have any effect. Change-Id: Id991551548c1e54fdf2e169886a6c67fc307931f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174077 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-09-28tdf#130857 qt weld: Add initial support for dialog and labelMichael Weghorn
Add initial support for the "GtkDialog" and "GtkLabel" objects in .ui files by creating corresponding Qt widgets (QDialog for "GtkDialog" and QLabel for "GtkLabel"). This makes the elements of the "Help" -> "License Information" show up once the .ui file of that that dialog ("sfx/ui/licensedialog.ui") is added to the set of supported .ui files. However, currently buttons and the label with the text are in the wrong order (i.e. buttons are above the text) and clicking the buttons doesn't yet have any effect. Those aspects will be addressed in separate commits before actually claiming support for the dialog in QtInstanceBuilder::IsUIFileSupported. Change-Id: Ic9393755ec474f77ff22a1115e3cccba9d7b26cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174076 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-09-28tdf#130857 qt weld: Use QDialog* as param for findButtonBoxMichael Weghorn
Don't restrict to QMessageBox, but allow using the method with any QDialog, and don't assert that the dialog has a layout set in this case. The method will be reused in an upcoming commit. Change-Id: I1992f2eb4f34b25e487bbd349631b6ecd4365c95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174075 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-28tdf#130857 qt weld: Avoid unnecessary OUString copyMichael Weghorn
Change-Id: I36802f84070e579b714b696144536a2f130e2f7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174074 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-28tdf#130857 qt weld: Use "p" prefix for pointer param nameMichael Weghorn
Change-Id: I732b67ef6f864fcbb1724b6d6bc3290417660dcb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174073 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-28tdf#130857 qt weld: Set widget layout and add to parent layoutMichael Weghorn
When creating a QLayout, pass the parent widget to the ctor as well, which makes the layout be set for the widget. Quoting from the QVBoxLayout ctor doc [1] > Constructs a new top-level vertical box with parent parent. > > The layout is set directly as the top-level layout for parent. > There can be only one top-level layout for a widget. It is returned > by QWidget::layout(). Also add widgets to their parent layout if the parent is a QLayout, and not a QWidget. This makes the items of the "Help" -> "License" dialog actually be part of the dialog in a WIP branch that has "QtInstanceBuilder::IsUIFileSupported" in the set of supported files in QtInstanceBuilder::IsUIFileSupported. [1] https://doc.qt.io/qt-6/qvboxlayout.html#QVBoxLayout-1 Change-Id: Ib823896a28520b6f7e1e89244239d3204d1d10e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174072 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-28tdf#130857 qt weld: Ignore placeholdersMichael Weghorn
In QtBuilder, ignore placeholders as encountered e.g. in "sc/uiconfig/scalc/ui/checkwarningdialog.ui" (that's not yet in the list of supported .ui files for QtInstanceBuilder yet). VclBuilder mostly ignores them as well, see VclBuilder::makeObject. Change-Id: I68481e31365561719af5e72ee20adb428b642941 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174071 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-28sc: Resave checkwarningdialog.ui with glade 3.40Michael Weghorn
Change-Id: Idb8efd7a8be06436b16572bfcf1d352a823e2497 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174070 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-28tdf#130857 qt weld: SAL_WARN and assert on unsupported widget typeMichael Weghorn
Change-Id: I45b0eac84a5820d0ef8a3bb36de35827f0ae1e33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174069 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-28qt: No longer use SalFrame::maGeometry in QtFrame at allMichael Weghorn
With previous commit Change-Id: Icaf712c956297dbc7a774bbd995d42eb8a63a1bb Author: Michael Weghorn <m.weghorn@posteo.de> Date: Fri Sep 27 11:06:55 2024 +0200 qt: Query screen on demand in QtFrame in place, all relevant members are explicitly set for the returned SalFrameGeometry in QtFrame::GetUnmirroredGeometry, so there's no more reason to start with a copy of `maGeometry` instead of a default-constructed SalFrameGeometry. Margins for decorations are never set for the Qt-based VCL plugins (using methods like SalFrameGeometry::setLeftDecoration), so the default of 0 is fine for all of these. Change-Id: Ibed98c665e61a4ba06bf9087a159048417598798 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174035 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-09-28qt: Query screen on demand in QtFrameMichael Weghorn
Similar to how Change-Id: Ifa0eff271c7d3fa2b6db9bdc1669e62333bd3094 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Thu Sep 26 18:22:12 2024 +0200 tdf#160837 qt: Rely on toolkit for frame positions, drop menubar hack implements it for the frame/widget position and size, also retrieve the current screen number by querying the QWidget for it's current screen instead of doing own bookkeeping of the current screen in SalFrame::maGeometry by getting/setting it using `SalFrameGeometry::{getS,s}creen. Only set it in the returend SalGeometry when the current SalGeometry explicitly gets requested by calling QtFrame::GetUnmirroredGeometry. Change-Id: Icaf712c956297dbc7a774bbd995d42eb8a63a1bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174034 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-09-28qt: Just ignore request to set frame to invalid screen numberMichael Weghorn
Instead of setting the screen to the primary screen, just ignore the request when QtFrame::SetScreenNumber gets called with an invalid screen number. The previous handling was introduced in commit f806a2832aee62efc0e0404f7c24d53aaaf814d0 Date: Mon Oct 22 16:35:21 2018 +0200 tdf#120451: Use primary screen if requested screen doesn't exist to fix a crash, but just ignoring the request avoids crashing, too. (`git show --ignore-space-change` helps to see the "actual" change more easily.) Change-Id: I272ec64f89ef835161fa68c7fdc8cd0e407b7495 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174033 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-09-28qt: Make screenNumber() a QtFrame methodMichael Weghorn
Don't explicitly pass a QScreen, but use the current one. Both callers set the screen just before calling the method. Change-Id: I57b3ffc4341cabc0370dda3c26d85f2f63ec9292 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174032 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-28gen: Use std::vector::at instead of operator[]Michael Weghorn
std::vector::at does bounds checking. Change-Id: Id173ad08fb3bf54e4b3e625b45bc439c59b4d9d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174031 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-28qt: Use QList::at instead of operator[]Michael Weghorn
Change-Id: I366ec4439d2647f433a9dc480c6efa6160a451a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174030 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-09-28qt: Use QList::indexOf instead of reimplementing logicMichael Weghorn
Change-Id: If78bc419ccffd874e47419bc06ed2841ffbeab96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174029 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-01-27 17:22:29 +0000