Age | Commit message (Collapse) | Author |
|
Change-Id: Ie13242800c9a171a93d266601fed11bf2d62f942
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124209
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I3e2b004578394e0199ac425f7b80da47a668f70d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124266
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
|
|
Change-Id: I56e17e876803a11047904187ae2fd40fbae01487
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124264
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
|
|
Change-Id: I4dc8b6c4e324a0b2ec2d3dba25cc322e0fbefa6c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124263
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
|
|
The Region() property expects one mandatory argument,
a range given as a string.
It returns a new range as a string, including the sheet name,
corresponding with the smallest area
- containing the input range
- completely surrounded with empty cells
It is complementary to Offset() and A1Style() to make easy the
definition of new ranges relative to known ranges
The property is available both in Basic and Python user scripts.
Change-Id: Ifc9ce07b76e72fe580baf2c8103387cab56a6ef0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124230
Tested-by: Jean-Pierre Ledure <jp@ledure.be>
Tested-by: Jenkins
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
|
|
Change-Id: Iec12f3c4f948d7e9e7991a212860e79f80750417
|
|
now supported
Change-Id: I0f357e0e7eb1e783d2e5868fa5a6852bb0b93833
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123509
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Must have been some misunderstanding, or temporary mistake in the 10.9
SDK?
Change-Id: I19d86c7a0e752676b317423361a18d2b156f0d95
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124259
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
|
|
Change-Id: Ic24218bee76ed9b8df3169bd8e2ede6a91689770
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124252
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Helps understanding the condition more clearly.
Change-Id: Ibb2b60283ea650bfac93621feb0333953cac8fcf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124188
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
The deprecations were introduced in SDK 10.12 and we
require at least SDK 10.13 so this should not be
controversial in any way. (And seriously, I doubt LO
can be built with such an old SDK anyway.)
Change-Id: I5e2b18b61fa66a6b06f2c751fc9d6ea87b6cbe47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123990
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
|
|
Watching a variable which returns a value from a function always shows
"out of scope" in the watch window of the Basic IDE. In order to resolve
this issue, the name of the variable being watched will be searched also
in the current method instance.
Change-Id: I5ff6ce22067e11d74275eeb82da814da1eebe3db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124239
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
|
|
Jenkins Windows builds occassionally fails with illegal instruction
(https://ci.libreoffice.org/job/gerrit_windows/110191/console).
This seems to be because those AVX etc. files use std::abs(double),
which is really just a fancy inline function calling the real
fabs() or whatever function. And in debug builds inlines do not
get inlined, they get emitted as copies. And since arraysumAVX.cxx
is listed as the first object for Library_sc, apparently the linker
likes to pick up the AVX-compiled inline function as the std::abs()
version to use for Library_sc.
Try to avoid this in two ways:
- move the CPU-specific object files later in the list of library
files
- use plain C headers in those sources, no fancy <cmath>
Change-Id: Ifd14076f79e9fbd7cc4c4a63a9764dff6715e63a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124249
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
...after 5d5da77e82b6498dd73123ec0dc36d2315e279a1 "tdf#116305 Add timeout to
help Windows bring browsers to the front" renamed those parameters, gratuitously
Change-Id: I4d62960458ad747b3de4fd99f9bcab987d19aa9f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124173
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
This comes from https://bz.apache.org/ooo/show_bug.cgi?id=62084 ,
but it's unclear to me what the steps to reproduce actually mean.
If it's print preview, then I can't reproduce, and all tests work
fine too. This code is called very often from LOK code in a loop,
and this check makes it O(n^2), so remove it under the assumption
that the problem no longer exists, only keep an assert just in case.
Change-Id: I0e7ed03ef370aa32f2064c587b242e1ffaff73b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124185
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: If1a897270f2fc43cdd5b2a4560bc5d1ce4fdba35
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124247
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
...which I happened to run into when the breakpad code kicked in due to some
crash happening,
> src/client/linux/minidump_writer/minidump_writer.cc:721:12: runtime error: null pointer passed as argument 2, which is declared to never be null
/usr/include/string.h:44:28: note: nonnull attribute specified here
> src/client/linux/minidump_writer/minidump_writer.cc:763:14: runtime error: applying non-zero offset to non-null pointer 0x000000200000 produced null pointer
> src/client/linux/minidump_writer/minidump_writer.cc:772:64: runtime error: applying non-zero offset 3200848 to null pointer
(Unlike the changes in the existing external/breakpad/ubsan.patch, which is only
applied when doing sanitizer builds, these changes should be non-controversial
and OK to apply always, so they go into a different patch file.)
Change-Id: Ib1b3f87ba22f96d5fb93b8fcb9951ddc3c353697
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124245
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I61f90680f907ee567f1af45801be3e939849d4ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124246
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
* Update helpcontent2 from branch 'master'
to 7f8b84bbf7fda91426d01bab26b5fa0d148624a1
- Update help description of Calc’s TRUNC function.
The help description for Calc’s TRUNC function currently does not indicate that the Count argument is optional. However, the help description for the ROUNDDOWN function does show the Count argument as optional.
Since both user functions are implemented via one C++ function (ScRoundDown()), the optionality status of arguments should be the same for both functions. This was checked by confirming that the formulas =ROUNDDOWN(-45.67) and =TRUNC(-45.67) give the same return value (-45).
This change updates the optionality status of Count for the TRUNC function and provides the additional example given above.
Change-Id: I2078d068b870dd05f4c977a2f9909537ecf7f9ab
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124190
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: I322b2cc0bae0889e5f3aaaf0542320c9dda82079
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124243
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: Ic87c8e57a6b530a742a6bf3916c7a944e1bed2b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121306
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Still unclear what exact scenario in lcl_ScAddress_Parse_OOo() it
would positively detect, but loading broken references may be
caught by this and just a '.' dot somewhere leading to an
(unresolved) external and then the InfoBar triggering. At least
restrict that to the maximum length of 4 characters for common
filename extensions.
Hit by loading a range name pointing to
$'zens. politik hj 1'.$#ref!#REF!
or
$'zens. politik hj 1'.$a$#ref!:#REF!
in
https://ask.libreoffice.org/uploads/short-url/6jOXRPprzGPOc5y0eHkUT6y6MfB.ods
of
https://ask.libreoffice.org/t/69315/15
Change-Id: I2191f4511cc492679259e74edd242bfced03b0fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124240
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
|
|
Change-Id: I779b6a20b814815b480876d8e65ef6b8e80f9443
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124241
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
...introduced with 5d5da77e82b6498dd73123ec0dc36d2315e279a1 "tdf#116305 Add
timeout to help Windows bring browsers to the front". (And remove a redundant
return statement, which had originally been `return true;`.)
Change-Id: Idf7fe33b25cd243e31eea460e4af325c84dae88b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124174
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ib95e7c562741f76a742cd31aa033956a0f0a3c45
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124169
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
...which are already adequately covered by overloads for OUString and the
OUStringLiteral-to-OUString implicit conversion that became cheap in
e6dfaf9f44f9939abc338c83b3024108431d0f69 "Turn OUStringLiteral into a
consteval'ed, static-refcound rtl_uString".
The only place where the removal of the ctor overload caused an issue for copy-
initialization (in sfx2/source/appl/newhelp.cxx) could easily be rewritten using
direct-initialization.
Change-Id: I458fb80eebabf981633f3437e7e967caa4c50a5b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124176
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
"definition of implicit copy assignment operator for 'NfCurrencyEntry' is
deprecated because it has a user-declared copy constructor" after
97e63ff5375d9d80d6fe5d4bd68883e35bd56d91 "Fix toolbar button's currency list's
number format for default locale" added that user-declared, defaulted
constructor, for no apparent reason
Change-Id: I070c8189c6dae8e62eb69ce40a2a1342cf0214a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124227
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
|
|
Change-Id: Ice8ec4868baab5182957ce335e2bc2cb93822af7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124228
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I99676a273c7ad1dad61ba82bc538c1ee4bd35d03
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124175
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
It's quite unclear why exactly this would even be necessary, but
commit 296baa2fb6dd4150a7855114093a9703cdc18b09
CommitDate: Tue Oct 5 18:14:37 2010 -0400
Ported calc-extref-interpreter-rework-*.diff from ooo-build.
introduced a heuristic whether a reference could be a so far
unrecognized external reference and used String.Erase(n) to strip
a detected possible filename extension starting from the '.' dot
to form a sheet name.
commit 6f93499b881416140c57bc86acdac0ae6e01c314
CommitDate: Tue Oct 8 10:03:08 2013 +0200
convert sc/inc/address.hxx from String to OUString
then changed the String.Erase(n) to OUString::replaceAt(n, 1, "")
which of course does not the same but just removes the '.' dot
character. In that commit this was the only replacement doing
that, others already used a correct OUString::copy().
Just restore the original intention, whyever..
Change-Id: Icc46115f9f25eaf1ed727c233fb1c69942c4b1af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124238
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
|
|
Change-Id: I34be2bc813bf0d62cac935a84c6371cd64ee68f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124168
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I987c56feab147cdbeb4ad58bd5ebb23dce6dbbca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124215
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I5d1b1240518aa97d229d56545e353259d226f1e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124237
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I884c8209e6b26e6c99654c4126ba81cf7e46c69f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124236
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
so its not always 100% in the custom value dialog, but whatever is the
current spacing value
Change-Id: I7a2690b2a38d2c49652830ad65d5dcf7bc80ba90
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124171
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I03b47080707c469d49e6cd9148573522d7f79da9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124232
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Id8a8dbeb2164e291324ddcb2409c0d7f05d5774a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124231
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
setUpdatedTypePerViewId() gets called so often that even unordered_map
lookup and allocations show up in profiling. It seems that flat_map
can do better.
Change-Id: Id2e4f0c40d6973b51e557f84a08bf12feb58b3ce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124210
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
use the clip rectangle to stop early when the text exceeds the height
of the cell
Change-Id: I63dadc5b63c1f6c0852e0ba86a58f18c2b207cca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124221
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
* Update helpcontent2 from branch 'master'
to c94585cd933b70a844719985ea63f70928e6d365
- Add example to help description of Calc's SERIESSUM function.
Change-Id: Ie3c95990e2ec75d439405d8fb79d9fde8d852bdd
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124192
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: I6b6573c8d9ad09a7087ddbb5fb673265c6af456b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124211
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Applying a numbering style to text causes export to save that
out as a number (valued as zero). That is not good because
the ODF spec says that a number overrides a string.
So don't accept a numbering format on non-number text.
Why is this change good?
-the cell previously had no direct formatting (by definition).
-the cell's previous old format was text (tested).
-any numbering format applied obviously isn't correct (by definition).
-any previous formatting has already been overwritten with numformat.
-the default numbering is appropriate for text.
-empty cells still get the numbering format (tested).
-odd human-designed formats are accepted as intentional (tested).
What are the concerns?
-the scope of this change is HUGE, way beyond this bug.
-on both my dev box and patch box I saw occassional crashes.
-the bug was "fixed" by a different import commit that ensured
different languages were treated consistently.
So this patch is no longer critical, just nice to have
to avoid exporting out-of-spec content.
Change-Id: Id3dc5f803c3cf4875bc0cab52d1019a18679da77
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123904
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
* Renaming all README files inside 'vcl' to use .md extension
* The content was previously converted into Markdown format in
dc984e7fed26ed26a2cafecb0c5b27feca56bfe2
Change-Id: If55d363b418ff14864297d02a6986c4fc3625ed7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113531
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
|
|
* Added information about dumping metaactions using mtfdemo
* 'sax' dependency was removed in d49900e5a3aae75a4c673f593e99fbc296f67cee
* Listing indirect dependencies from 'emfio/Library_emfio.mk'
Change-Id: I5ee7e20c872aff388424930a23c9a17614b5e3c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124180
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
|
|
Change-Id: Ic7a1bd818a308f5caff5923ff30a0741ffec7f86
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124177
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
* Use git.libreoffice.org instead of cgit.freedesktop.org for the git
links generated by mkdocs scripts
Change-Id: Iac6e9ea1b73dcd0155786798c0ec162865299ada
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124186
Tested-by: Jenkins
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
|
|
The module 'svgio' is used to read SVG. This is
the list of topics discussed in the documentation:
* Introduction
* How does it work?
* Known Bugs
* Dependencies
* Related Software
* References
Change-Id: If42e9c2e10145c12cd5d74019b36bc5d78dd5bb9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124178
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
|
|
Moving up a list item over a tracked paragraph insertion
changed non-tracked text to tracked insertion.
Manual test:
- Create a 3-element list;
- switch on Record Changes and Show Changes;
- at the end of the list item 2, press Enter to insert a
new list item, and type some text:
Item 1
Item 2[
New item]
Item 3
where parenthesis shows the boundaries of the tracked
insertion;
- move up the last list item over list item 2 (the unmodified
paragraph text with a tracked paragraph insertion at the
end).
Paragraph text before the tracked paragraph insertion
changed to tracked insertion joining its tracked insertion
with the moved list item, resulting only 2 tracked changes:
Item 1
[Item 3
Item 2
New item]
[Item 3]
instead of the requested 3 changes:
Item 1
[Item 3]
Item 2[
New item]
[Item 3]
Change-Id: I4716b2d244b57cf86d7d14d972452191549f5fea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124144
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Change-Id: I92bf81801797821c9ec4aa73c005f1d6c6f6da62
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124182
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
sw/source/uibase/uiview/viewsrch.cxx:97:13: error: variable
'textSelection' set but not used
Change-Id: I67a37e9440343a34147dd5be82cfc3dfb1282419
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124184
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|