summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-11-28tdf#83877 OOXML Roundtrip of SignatureLine propertiesSamuel Mehrbrodt
Change-Id: I521e5f35663c5ab3c2702f1416fcec872f2f5e3f Reviewed-on: https://gerrit.libreoffice.org/44683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-28loplugin:unusedmethods ignore recursive callsNoel Grandin
Change-Id: I651a7bf0c705acc5580af8b7742d2d035ec64388
2017-11-28loplugin:countusersofdefaultparams in svxNoel Grandin
Change-Id: I2c9ea6c38b75dcafeb36931b6c2e94489819144f Reviewed-on: https://gerrit.libreoffice.org/45336 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-28Simplify methodSamuel Mehrbrodt
Change-Id: I4de0c0fc0127b454f19ecf154d8ce58f189852cf Reviewed-on: https://gerrit.libreoffice.org/45164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-28Set correct file permissionsJens Carl
Change-Id: I3667d1feda74aad160bbfd79e6baafc42e3cf83d Reviewed-on: https://gerrit.libreoffice.org/45302 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-27loplugin:useuniqueptr (clang-cl)Stephan Bergmann
Change-Id: Id9020bef2ce0fa9a7a70f48d27fb57735c6f57ca Reviewed-on: https://gerrit.libreoffice.org/45340 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-27Pass $(MAKE) into external/gpgmeppStephan Bergmann
...similar to e8e5bd65d31a60712afcab17d2e5f77c3322f86f "Pass $(MAKE) into external/libassuan" Change-Id: Icb90eb0831e74270a2600ab8ea9a6b0ac88a7e5f Reviewed-on: https://gerrit.libreoffice.org/45345 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-27Silence clang-cl -Werror,-Wundef in workdir/UnpackedTarball/gpgmepp/ includesStephan Bergmann
> workdir/UnpackedTarball/libgpg-error/src\gpg-error.h(709,5): error: '__GNUC__' is not defined, evaluates to 0 [-Werror,-Wundef] > #if __GNUC__ > ^ > 1 error generated. Change-Id: Icae46745069431e60faa7d2e6ca44ab800e72b95 Reviewed-on: https://gerrit.libreoffice.org/45341 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-27Silence clang-cl -Werror,-Wc++11-narrowing in external/gpgmeppStephan Bergmann
> workdir/UnpackedTarball/gpgmepp/lang/cpp/src/gpgadduserideditinteractor.cpp(105,10): error: case value evaluates to -1, which cannot be narrowed to type 'unsigned int' [-Wc++11-narrowing] > case ERROR: > ^ > workdir/UnpackedTarball/gpgmepp/lang/cpp/src/gpgadduserideditinteractor.cpp(182,10): error: case value evaluates to -1, which cannot be narrowed to type 'unsigned int' [-Wc++11-narrowing] > case ERROR: > ^ where ERROR is defined in gpgadduserideditinteractor.cpp as > enum { > START = EditInteractor::StartState, > COMMAND, > NAME, > EMAIL, > COMMENT, > QUIT, > SAVE, > > ERROR = EditInteractor::ErrorState > }; and ErrorState is defined in editinteractor.h as > enum { > StartState = 0, > ErrorState = 0xFFFFFFFF > }; but ERROR is nevertheless signed according to MSVC's broken enum rules. Change-Id: Ie85361a681ef02dc9705b565ca892d9a4c705afa Reviewed-on: https://gerrit.libreoffice.org/45346 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-27Missing --tag=RCStephan Bergmann
...causing failure > make[5]: Entering directory 'workdir/UnpackedTarball/libassuan/src' > C:/cygwin64/bin/sh.exe ../libtool --mode=compile windres --preprocessor=[...]' `echo -DHAVE_CONFIG_H -I. -I.. | sed -e 's/-I/--include-dir /g;s/-D/--define /g'` -i versioninfo.rc -o versioninfo.lo > libtool: compile: unable to infer tagged configuration > libtool: compile: specify a tag with `--tag' > make[5]: *** [Makefile:1172: versioninfo.lo] Error 1 for me. (And note how e.g. workdir/UnpackedTarball/libgpg-error/src/Makefile.am contains such a --tag=RC, too.) Change-Id: I3919a59d5443c558d9bc37fd0a851ea161f44406 Reviewed-on: https://gerrit.libreoffice.org/45344 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-27Pass $(verbose) into ExternalProject_libassuanStephan Bergmann
Change-Id: I66771b49933a9092ad0c07c5ebaabfb3d80dcdcd Reviewed-on: https://gerrit.libreoffice.org/45343 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-27tdf#113455 follow-up: use spin button labels as checkboxesMike Kaganski
This streamlines the UI (avoids extra controls on page). Labels' ids kept intact to preserve localization context. Change-Id: Idbeb47d7f4e783107d49cb045125434291331140 Reviewed-on: https://gerrit.libreoffice.org/45333 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-27rhbz#1517407 Capitalize every word doesn't work after bracketsCaolán McNamara
Change-Id: Iab2da3f74f6116bb1b9855044df2a2ece977bb95 Reviewed-on: https://gerrit.libreoffice.org/45335 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-27ofz#4412 do not read past end of fileEike Rathke
Change-Id: Id1d9e83a931fda3921948206cf927b2c20d88173
2017-11-27Work around clang-cl issue with __int128Stephan Bergmann
(see external/libtommath/clang-cl.patch for details) Change-Id: Ice2e1b3e3c5944b3ae72365981679c1effdcfdbd Reviewed-on: https://gerrit.libreoffice.org/45342 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-27loplugin:simplifybool (clang-cl)Stephan Bergmann
Change-Id: Id86ddcbed61df87f8da7a58972387d950d14634d Reviewed-on: https://gerrit.libreoffice.org/45339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-27loplugin:unnecessaryparen (clang-cl)Stephan Bergmann
Change-Id: I5452235287fd5986de25ee542edd57bf1abded52 Reviewed-on: https://gerrit.libreoffice.org/45338 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-27Groupedbar full add priority functionallityandreas kainz
Change-Id: Id1bbc7da811c76be5b413b2c66da280f504d97a0 Reviewed-on: https://gerrit.libreoffice.org/45361 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2017-11-27keep track of available dataCaolán McNamara
Change-Id: Idc54cdef0f3a4355a7e26f25cdc5b50d65d9d583 Reviewed-on: https://gerrit.libreoffice.org/45351 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-27undo "ofz#3577 force refresh"Caolán McNamara
oss-fuzz shows no reduction of timeouts. Seeing as this is the root of importing ole docproperties none of the lines from SfxOleStringHelper:: up can be in any timeouts, so the original stacktrace isn't in any way helpful and it must be the generic ReadUInt16 downwards part of the stack. In other words the timeout bugs in oss-fuzz are useless if they aren't reproducible This reverts commit ecc3b1fcaddd4066d90161faf4a3f532b445c85a. Change-Id: I3fb8d2ded8502278098bd223898e3e90f6e4a378 Reviewed-on: https://gerrit.libreoffice.org/45352 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-27vcl: fix loplugin:unnecessaryparen warningMiklos Vajna
Change-Id: I332fd599e879adaf65bf24bb8c75a533e48d8bc5
2017-11-27Address some nitpicks, tdf#39593 follow-upEike Rathke
* clarify the comment in ClearableClipRegion dtor * invest some spaces for readability * indicate that "auto ClipRegion" is actually a (unique) pointer, so name it pClipRegion * also const auto Change-Id: Ia4d822df37a1a783c1b362e9c602567fde4bafa9
2017-11-27tdf#39593 deduplicate code in ScOutputDatatagezi
Change-Id: Ic709739c75b7305757b2e1985765497985a0b8b6 Reviewed-on: https://gerrit.libreoffice.org/45106 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-27tdf#108048: update InsertBreak slot to use PageNumberFilled paramMike Kaganski
Since commit c2ccd20c0fd92bddfff76447754541705e3eb8f3 (tdf#44689), SwWrtShell::InsertPageBreak takes page number as optional argument. The FN_INSERT_BREAK_DLG case in SwTextShell::Execute expects third parameter (FN_PARAM_3) to be boolean flag indicating if page number is filled. But corresponding sw slot was not updated to that fact. This prevented macros inserting page breaks with page numbers to be properly recorded, and one couldn't fix that manually, too, because the slot didn't expect that extra param (which would be dropped in TransformParameters). This adds the boolean parameter named PageNumberFilled to the list of InsertBreak slot. Unit test included. Change-Id: Ibccaece59b0e9848c0b754aa91b6700054b7fe97 Reviewed-on: https://gerrit.libreoffice.org/45319 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-27loplugin:unnecessaryparenStephan Bergmann
Change-Id: Ie66c3bec510138b75c41d261b447c956a92486a7
2017-11-27Add int pool items to NatvisMike Kaganski
Change-Id: I5840baff5bd052f95233f13d89ee64a926a2dd93 Reviewed-on: https://gerrit.libreoffice.org/45348 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-27Turns out SdiTarget needs the extended SOLARINC after allStephan Bergmann
After fbfe55e58c4b14f86cbb2c7b822f727e5b2e4a66 "There appears to be no need for -I. in SOLARINC", on Windows, e.g. workdir/Dep/SdiTarget/basctl/sdi/basslots.d now contains basslots.sdi without a path, because the call to osl::File::searchFileURL in SvIdlParser::ReadInclude (idl/source/prj/parser.cxx) is done with rBase.GetPath() no longer containing the basctl/sdi/ source dir, so searchFileURL silently returns "basslots.sdi" unmodified. (The non-Windows implementation in sal/osl/unx/file_url.cxx appears to also check CWD, so doesn't suffer from this regression.) Change-Id: I51802192cfe112f810b193a77d14787d965c2761 Reviewed-on: https://gerrit.libreoffice.org/45323 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-27loplugin:unnecessaryparenStephan Bergmann
Change-Id: Ief879dde0613859a9ea9b3e3e70938594ab99209
2017-11-27The eTempGrammar[12] fields can be constTor Lillqvist
Change-Id: Ibf3f0f9fed7c2158c4ad366f0c865b075943f2a8 Reviewed-on: https://gerrit.libreoffice.org/45321 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-11-27tdf#114078 Missing gettext markup on Numbering format stringsCaolán McNamara
Change-Id: I8ac705dc964d23984cba00f51ec25ad07243554e Reviewed-on: https://gerrit.libreoffice.org/45329 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-27tdf#114023 typo of FMT_REF_ARY instead of FMT_REG_ARYCaolán McNamara
Change-Id: Id3e0588ee0f5dc0aa93270f58de1d1fd4bc9c912 Reviewed-on: https://gerrit.libreoffice.org/45326 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-27TSCP: don't put a non-existing name into doc. propsTomaž Vajngerl
We combined the abbr. name with the name and put that as a value into doc. properties. This is not correct as such a name doesn't exist in the BAPolicy and con't be identified anymore, so removing this. Also use the values that were put into the ClassificationField instead of the extracted text. Change-Id: I3037bc90a7a394d430f7c0cca4d326473eff3147 Reviewed-on: https://gerrit.libreoffice.org/45316 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-27loplugin:unnecessaryparen: Warn about parentheses around literalsStephan Bergmann
...that are not composed of multiple tokens, like ("foo" "bar"). Also don't yet warn about Boolean literals, which are sometimes wrapped in parentheses to silence unreachable-code warnings. To avoid multiple warnings about code like f((0)) switch to generally using a set of ParenExpr to keep track of which occurrences have already been handled. Change-Id: I036a25a92836ec6ab6c56ea848f71bc6d63822bc Reviewed-on: https://gerrit.libreoffice.org/45317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-27loplugin:countusersofdefaultparams in sw (3)Noel Grandin
Change-Id: I2657c1146bc377135e13116f32dbf518f8815417 Reviewed-on: https://gerrit.libreoffice.org/45318 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-27loplugin:countusersofdefaultparams in sw (2)Noel Grandin
Change-Id: Ibb045a0b7750cf6807d6f5caba86a9e6e59828ae Reviewed-on: https://gerrit.libreoffice.org/45237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-27iOS, change workdir for prelink objectjan Iversen
workdir/ios is no longer created so move Kit.o to CObject/ios Change-Id: Ibcd6f9f5a17fb26861ed8fe5313e90f314018090
2017-11-27ofz#4441: Divide-by-zeroCaolán McNamara
Change-Id: If83e6bb22239d0fd82f40836601447cbba2f1df4 Reviewed-on: https://gerrit.libreoffice.org/45297 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-27accessibility : AccessibleBrowseBoxBase::isAlive is not thread safeArnaud Versini
Change-Id: I243328a662bf37944e1fa718f63a0e509250db15 Reviewed-on: https://gerrit.libreoffice.org/44930 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-27EPUB export: fix char props of <text:sequence> charactersMiklos Vajna
These are typically inherited from parent, <text:sequence> is similar to e.g. <text:span> in this regard. Change-Id: Ic84f6e2e4fc6866ffca23eef2c932ee63e6978ca Reviewed-on: https://gerrit.libreoffice.org/45314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-27EPUB export: handle sequence fieldsMiklos Vajna
Just emit their expanded content for now. Change-Id: Ibca40d201dde9c8d6ef920b5213f786f64d7c027 Reviewed-on: https://gerrit.libreoffice.org/45313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-27EPUB export: handle text box wrap typesMiklos Vajna
Change-Id: I89487bc115ba84cfb7700b1617e531f2d3aed950
2017-11-27EPUB export: avoid wrap type for as-char anchored imagesMiklos Vajna
This fixes the wrapping of the inner frame of writerperfect/qa/unit/data/writer/epubexport/text-box.fodt. Change-Id: I8f2a4a2db8e49469c08f3dbf11d5891df3eddff8 Reviewed-on: https://gerrit.libreoffice.org/45311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-27EPUB export: handle non-image framesMiklos Vajna
TextFrame on the Writer UI. Change-Id: I755fde113ef86a656b7f1f39c02642c22a5a6102 Reviewed-on: https://gerrit.libreoffice.org/45310 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-27EPUB export: handle image wrap typesMiklos Vajna
Change-Id: If7ef8f8e72e68fb71285ddb0164f033f44c62a53 Reviewed-on: https://gerrit.libreoffice.org/45309 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-27EPUB export: handle horizontal left/right positioning of non-as-char imagesMiklos Vajna
The change in XMLStyleContext::startElement() just makes sure that properties from the parent graphic styles are read, but currently it's just a nice-to-have addition, we don't depend on this yet, so no test. Change-Id: Ieac599dd47049edea57cb0860aa483f1045b47fd Reviewed-on: https://gerrit.libreoffice.org/45308 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-27EPUB export: handle images outside spansMiklos Vajna
CreateParagraphOrSpanChildContext() is already a factory for paragraph-or-span parents, just move image handling there. Change-Id: Ieeb57dc0913a17e92fdc57d79c26326f9cecb6a4 Reviewed-on: https://gerrit.libreoffice.org/45307 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-27EPUB export: switch back to using an external CSSMiklos Vajna
And fix the root of the problem in libepubgen. Also clean up related test code, so asserting CSS markup is as simple as asserting XML markup now. Change-Id: Iebe20be07e604b864e65a3376609a44a35bfa491 Reviewed-on: https://gerrit.libreoffice.org/45306 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-27EPUB export: handle image bordersMiklos Vajna
This requires handling of graphic styles. Change-Id: I74d4ee882b91192da44d8d7bbd88c1a66e97695f Reviewed-on: https://gerrit.libreoffice.org/45305 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-27loplugin:unnecessaryparen check for (f1()).f2Noel Grandin
Change-Id: I93257b0ddd41c649875124d6d5c5faeaa431bae3 Reviewed-on: https://gerrit.libreoffice.org/45218 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-27tdf#113831 Show number of search resultsheiko tietze
Skipped label used to show the number via resource strings Change-Id: I6f57799565126c202041d0bf6a9f361d4e64cdfd Reviewed-on: https://gerrit.libreoffice.org/45269 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
generated by cgit (git 2.34.1) at 2024-12-26 23:01:39 +0000